Commit Graph

44812 Commits

Author SHA1 Message Date
Chris Ross 156c4feb65
Put request trailers in a separate collection (#10410) 2019-05-23 09:00:39 -07:00
Stafford Williams c2e2d7d135 SignalR: Fix Crankier build (#9976)
* fix benchmarkapps build
* move Directory.* to BenchmarkServer
2019-05-23 08:20:34 -07:00
Steve Sanderson 6c5e1690ad
Update Mono WebAssembly for Blazor (https://github.com/aspnet/Blazor/pull/1807) 2019-05-23 13:10:53 +01:00
Pranav K 66dd6b35d3 Specify UpToDateReloadFileTypes (dotnet/aspnetcore-tooling#611)
* Specify UpToDateReloadFileTypes

Specify a list of file extensions that VS will monitor for file changes to reload the app.
Includes .razor and .cshtml files.

\n\nCommit migrated from 9a964127bf
2019-05-22 16:43:02 -07:00
Dániel Lőczi dbe9ab7dd5 Respect CancellationToken in HubConnection.StartAsync() (#10140) 2019-05-22 14:37:08 -07:00
Ajay Bhargav Baaskaran db66452bbd Fix bug in bind lowering logic
\n\nCommit migrated from 5bcd008779
2019-05-22 14:06:32 -07:00
Nate McMaster 2cc071a41d
Update BuildFromSource.md to explain CS0006 errors (#10465) 2019-05-22 12:59:27 -07:00
BrennanConroy f26b87aa42 Check for Java in local SignalR build (#10455) 2019-05-22 11:02:37 -07:00
Nate McMaster 52133ac431
React to deprecation of Fedora.28.Amd64.Open (#10409) 2019-05-22 10:59:04 -07:00
Pranav K 72e2d13217 Make JsonPatch netstandard2.0
Fixes https://github.com/aspnet/AspNetCore/issues/9812
2019-05-22 10:22:42 -07:00
Chris Ross ede9249223 React to Authorization refactor (#10453) 2019-05-22 09:36:52 -07:00
Isaac Levin b38bcbfd62 updates to pass tests 2019-05-22 10:47:11 -04:00
Chris Ross f5879cc0d5
Add new Negotiate Auth handler (#9831) 2019-05-22 06:14:50 -07:00
Nate McMaster 9c84558c9b
Add <frameworkReferences> metadata to nuspec of packages that depend on the shared framework (#10429) 2019-05-21 19:16:00 -07:00
Nate McMaster 01a8798936
Update links and disable warnings related to tests that don't work in Helix (#10427) 2019-05-21 16:39:06 -07:00
Ryan Nowak 95bb698c5a Make duplicate attribute names an error (dotnet/aspnetcore-tooling#604)
This came up in the context of discussion around aspnet/AspNetCoredotnet/aspnetcore-tooling#5071.

Browsers use a 'first attribute wins' rule for evaluating attributes and
building the DOM - though duplicate attributes are considered to be a
spec violation.

Blazor wants to use 'last attribute wins' rules because that's most
sensible when you consider evaluation order and splatting.

This means that we have to have the markup block pass do the same thing
as the Blazor runtime when duplicates appear. However, since this is a
spec violation I'm proposing that we just make it an error (like we do
for malformed tags). There's no useful purpose for duplicate attributes
since browsers ignore it.

Since we're not going to allow this for elements. Let's go all of the
way and block it for components as well. And while we're here, lets
block some of the invalid cases where users try to mix onchange and
bind. These don't work today, so we should make them an error. If we
decide to add support for this case to the runtime that would require
compiler work anyway.
\n\nCommit migrated from 0c59ca5f74
2019-05-21 16:37:08 -07:00
Pranav K 26b53236b1
Fix more null refs in Api Analyzers (#10375)
*  Fix more null refs in Api Analyzers

 * Make attributes used by analyzer public
 * Compile analyzer tests against ref assemblies
 * Turn on Nullable reference types and harden some null-checks

Fixes https://github.com/aspnet/AspNetCore/issues/8686
2019-05-21 16:17:15 -07:00
Ajay Bhargav Baaskaran 72d017cc1b Added support for @attribute directive (dotnet/aspnetcore-tooling#607)
\n\nCommit migrated from 67b8a838da
2019-05-21 15:42:56 -07:00
John Luo e925df6a85
Disable test reporting for flaky tests on Helix (#10352) 2019-05-21 15:03:39 -07:00
Nate McMaster 213076ff4b Obsolete TestPathUtilities (dotnet/extensions#1698)
\n\nCommit migrated from da5dee978f
2019-05-21 14:18:22 -07:00
Pranav K 5df6e452b6
Support a few more complex types with DefaultTempDataSerializer (#10314)
* Support a few more complex types with DefaultTempDataSerializer

Fixes https://github.com/aspnet/AspNetCore/issues/9540
2019-05-21 13:51:48 -07:00
Ajay Bhargav Baaskaran 5bad5de7ee Directive attributes part 1: Support parameters in bound attributes (dotnet/aspnetcore-tooling#597)
* Directive attributes part 1: Support parameters in bound attributes

* update

* Fix test

* feedback

* Updated design

* Do case sensitive comparison

* more

* Bug fix
\n\nCommit migrated from 9bbf240948
2019-05-21 13:07:23 -07:00
Alessio Franceschelli 7ab01a3f79 Build: fixed JDK detection via registry to support finding JDK 8 (#10369) 2019-05-21 11:35:29 -07:00
Ryan Brandenburg 66fd4be4d7
Accessibility (#10247)
Template Accessibility
2019-05-21 11:22:21 -07:00
dotnet-maestro[bot] cebd9000e9 [master] Update dependencies from Arcade and dotnet/arcadeaspnet/AspNetCore-Tooling (#10359)
* Update dependencies from https://github.com/dotnet/arcade build 20190520.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19270.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19270.1

* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190520.2
- Microsoft.NET.Sdk.Razor - 3.0.0-preview6.19270.2
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview6.19270.2
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview6.19270.2
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview6.19270.2
2019-05-21 08:53:01 -07:00
Justin Kotalik 47d39501a5
Upload native symbols for ANCM shim. (#10297) 2019-05-21 08:34:28 -07:00
Javier Calvarro Nelson 13397dd4d6 Initial support for static assets in Razor Class Libraries (dotnet/aspnetcore-tooling#580)
* Imports static assets from packages containing custom msbuild
  targets defining a StaticWebAsset item group.
* Generates an embeds a manifest into the application assembly
  that contains a list of paths to the content roots of the
  assets defined in the packages custom msbuild targets.\n\nCommit migrated from 8e70013b70
2019-05-21 15:03:00 +02:00
BrennanConroy 663c83c140
Fix build failures with new VS (#10411) 2019-05-20 17:51:06 -07:00
Dylan Dmitri Gray 55555bedd5
Merge pull request #10275 from aspnet/dylan/requestQ
start of request queue
2019-05-20 17:02:47 -07:00
Hao Kung 16a47948f8
Move AuthZ policy types back into Policy and rejigger AddAuthorization (#10021) 2019-05-20 16:20:19 -07:00
Nate McMaster 0f96289087
Update CODEOWNERS 2019-05-20 14:06:28 -07:00
dotnet-maestro 347ddcb6e2
Initialize eng/common/ folder from dotnet/arcade 2019-05-20 14:04:04 -07:00
Javier Calvarro Nelson 111e26dd03 Conditionally enable content items in the razor SDK (dotnet/aspnetcore-tooling#589)
* Move the globs from the project system into the Razor SDK on a separate file that can be imported by itself.
* Import the file conditionally based on the EnableRazorContent property\n\nCommit migrated from 62e33dac1d
2019-05-20 21:06:38 +02:00
Dylan Dmitri Gray 54e5b15c24 it's gone for good 2019-05-20 11:58:30 -07:00
Isaac Levin 487ccf71e6 test failure fixes 2019-05-20 14:48:34 -04:00
Pranav K 200c9e21bd
Use attributes for application part discovery (#10271)
* Use attributes for application part discovery

Fixes https://github.com/aspnet/AspNetCore/issues/4332
2019-05-20 09:10:12 -07:00
Alessio Franceschelli e92b4800df Skip Java detection on restore if not building (#10368) 2019-05-20 08:57:55 -07:00
Nate McMaster 630af4d319
Fix detection of the JDK from a registry setting 2019-05-20 08:51:01 -07:00
Nate McMaster 194b0b4523
Update install JDK script an instructions to make it easier to use for local development (#10306) 2019-05-20 08:48:54 -07:00
Isaac Levin 19bf518de1 #10333 Template Updates 2019-05-20 10:55:15 -04:00
Steve Sanderson 147880f796
Components auth step 2 (#10293)
* CR feedback left over from #10227

* Begin adding E2E test case

* Add cookie auth and test login page

* Make E2E auth component work client-side too

* Restructure auth E2E tests around a router so there can easily be multiple such test components

* Add E2E test case for AuthorizeView

* Prepare for E2E test implementations

* Fix ToBaseRelativePath handling of hashes

... otherwise E2E test will fail, because we're using the hash to control server-or-client execution

* Decouple E2E execution mode from hosting mode

* Actual E2E tests for cascading authentication state

* Actual E2E tests for AuthorizeView (in "no authentication rule" mode)

* Fix inconsistent namespace

* CR: Manual ref assembly definitions for AuthorizeView/CascadingAuthenticationState
2019-05-20 15:41:02 +01:00
Alex Lorimer 98a2a4348b fixed destructive property assignment (reference self correctly using `$(GetCopyToOutputDirectoryItemsDependsOn)` instead of `$(GetCopyToOutputDirectoryItems)`) (dotnet/aspnetcore-tooling#603)
The intention here would have been to add to the existing GetCopyToOutputDirectoryItemsDependsOn property, defined in Microsoft.Common.Targets. Instead what was happening is that it was being completely overwitten with the _RazorGetCopyToOutputDirectoryItems entry, given that $(GetCopyToOutputDirectoryItems) doesn't exist as a property and must have been a typo (it exists as a task, not a property).

An effect of this bug was that the `AssignTargetPaths` target is not always executed before the `GetCopyToOutputDirectoryItems` target, which should explicitly depend on it. `AssignTargetPaths` is responsible for populating the `ContentWithTargetPath` itemgroup. Left empty, it appears to `GetCopyToOutputDirectoryItems` task that there are no Content files to copy to the final output directory, when in fact there are.\n\nCommit migrated from 4597bc3d55
2019-05-20 06:39:51 -07:00
Doug Bunting 5502c2080e Fix sign check
- most likely cause of failing official builds
- small typo in #10340: need to find .cab files _below_ `$(TargetDir)`
2019-05-18 19:00:04 -07:00
Dylan Dmitri Gray 7ff5293177 added HttpsPolicy back 2019-05-18 18:31:31 -07:00
BrennanConroy e953537307
Fix silly npm warnings (#10339) 2019-05-17 23:20:32 -07:00
Stephen Halter 8d83e5352d
Disable request body data rate limits per HTTP/2 stream (#10355) 2019-05-17 18:25:41 -07:00
Dylan Dmitri Gray 68606a2d80 removed redundant HttpsPolicy dependency 2019-05-17 16:56:17 -07:00
Justin Kotalik 2e89aa4aa6
Log stdout to event log on failure to start process for ANCM out of process (#10123) 2019-05-17 16:30:59 -07:00
Pranav K b9546df5d4
Defer link interception until Router is initialized (#10062)
* Defer link interception until Router is initialized

Fixes https://github.com/aspnet/AspNetCore/issues/9834
2019-05-17 15:33:35 -07:00
Pranav K fdc056cebe
Fixup 2019-05-17 15:12:24 -07:00