Commit Graph

749 Commits

Author SHA1 Message Date
James Newton-King bff2060454
Fix JsonHubProtocol error message when too many arguments (#2312) 2018-05-18 19:55:53 +12:00
BrennanConroy 32cee74a0c
Generate baselines and enable Api check (#2304) 2018-05-17 15:21:13 -07:00
Pavel Krymets 3719dc00fa
Enable analyzers (#2300) 2018-05-17 09:48:07 -07:00
James Newton-King eaa03679de
Fix flakey tests from SSE receiving a 404 response on stop (#2282) 2018-05-17 18:31:56 +12:00
Andrew Stanton-Nurse 2388dd3a76
Merge pull request #2287 from aspnet/release/2.1
Android HttpClientHandler.ClientCertificates fix (#2270)
2018-05-16 12:39:50 -07:00
James Newton-King e1a22b315d Android HttpClientHandler.ClientCertificates fix (#2270) 2018-05-16 11:25:39 -07:00
Mikael Mengistu 2041cf6ede
Don't create empty lambdas (#2283) 2018-05-16 11:12:53 -07:00
Mikael Mengistu 283297f455
Remove handlers from HubConnection (#2267) 2018-05-15 23:57:02 -07:00
BrennanConroy 9cb683a41d Merge branch 'release/2.1' into dev 2018-05-15 16:16:02 -07:00
BrennanConroy 95f543848c
Fix multiple connections for a single user in Redis and MemoryLeak (#2273) 2018-05-15 15:57:23 -07:00
James Newton-King 43aa392dff
Add state to TS HubConnection (#2268) 2018-05-16 08:43:08 +12:00
James Newton-King 7625bbcb6c
Add HubConnection.State (#2204) 2018-05-14 19:23:00 +12:00
Stephen Halter ffc665ccc2 Use correct TaskCompletionSource ctor (#2261)
https://github.com/dotnet/corefx/issues/29664
2018-05-13 19:52:19 -07:00
BrennanConroy 7916f95235 Merge branch 'release/2.1' into dev 2018-05-10 16:54:26 -07:00
BrennanConroy 4b1fb58a8a
Throw error on unexpected close (#2205) 2018-05-10 16:38:21 -07:00
James Newton-King db33d593f0
Gracefully handle disposing while writing (#2180) 2018-05-09 17:57:56 -07:00
BrennanConroy f09b0e13d9
Upgrade to netcoreapp2.2 and remove netcoreapp2.0 testing (#2221) 2018-05-09 09:59:02 -07:00
Mikael Mengistu 62d892315b
Merge pull request #2224 from aspnet/release/2.1
Use params passed into HubConnectionBuilder (#2223)
2018-05-07 21:44:04 -07:00
Mikael Mengistu 6f6382799b
Use params passed into HubConnectionBuilder (#2223) 2018-05-07 18:19:20 -07:00
James Newton-King da7a95f563
Handle null collections when writing NegotiateResponse (#2202) 2018-05-04 16:08:06 -07:00
Andrew Stanton-Nurse 6429e8e8ea
Merge pull request #2198 from aspnet/release/2.1
fix #2187 by passing min size through to buffer writer when encoding (#2190)
2018-05-03 19:10:42 -07:00
Andrew Stanton-Nurse b492dbe5d1
fix #2187 by passing min size through to buffer writer when encoding (#2190) 2018-05-03 19:10:15 -07:00
BrennanConroy 8c7f33a6d7
Port C# client perf fix to release (#2189) 2018-05-02 21:53:39 -07:00
Andrew Stanton-Nurse 622e133a8a
fix #2134 by disposing httpconnection if start fails (#2137) (#2188) 2018-05-02 13:10:58 -07:00
James Newton-King 9f40bd639f
Merge pull request #2186 from aspnet/release/2.1
Fix not setting HttpConnection.ConnectionId (#2154)
2018-05-01 23:01:20 -07:00
James Newton-King 41c8dcf449
Fix not setting HttpConnection.ConnectionId (#2154) 2018-05-01 21:48:57 -07:00
James Newton-King 277e2963ef
Merge branch 'release/2.1' into dev 2018-05-01 17:52:01 -07:00
James Newton-King 3e906fb64a
Minor API cleanup (#2147) 2018-05-01 17:51:08 -07:00
James Newton-King 49cdaad6d6
Merge pull request #2185 from aspnet/release/2.1
Fix not detecting marker service (#2149)
2018-05-01 17:42:39 -07:00
James Newton-King 555c1fd720
Fix not detecting marker service (#2149) 2018-05-01 17:42:00 -07:00
Andrew Stanton-Nurse 2a236193da
Merge pull request #2184 from aspnet/release/2.1 2018-05-01 16:37:54 -07:00
Andrew Stanton-Nurse 1bba0fde87 Merge branch 'release/2.1' into dev 2018-05-01 16:15:57 -07:00
Andrew Stanton-Nurse d711916ad6
fix #2140 by ensuring the access token flows to WebSocketTransport (#2173) 2018-05-01 16:14:24 -07:00
James Newton-King 295801ac50
XML documentation (#2106) 2018-05-01 16:08:09 -07:00
David Fowler f3ba1babfc
Remove unnecessary state machines in DefautHubDispatcher (#2167)
* Remove unnecessary state machines in DefautHubDispatcher
- Remove state machines for async tail calls
- Added fast path for auth check when there are no policies
2018-04-30 22:41:32 -07:00
David Fowler c53514fa19
Don't throw from AbortAsync (#2166)
- Log from inside of HubConnectionContext if the user callback failed.
- Use ThreadPool.QUWI instead of Task.Factory.StartNew.
- Remove try catch from HubConnectionHandler
2018-04-30 09:22:48 -07:00
David Fowler ab451b53b7
Simplify error handling in HubConnectionHandler (#2162)
* Simplify error handling in HubConnectionHandler
- Since we execute hub methods inline, there's no need to abort the connection on unexpected exceptions.
- Don't pass the cancellation token to ReadAsync, instead just use CancelPendingRead.
- Don't treat OperationCancelledException errors as errors.
2018-04-29 22:51:16 -07:00
BrennanConroy 43fc0854c3
Remove unnecessary hop (#2136) 2018-04-23 15:25:57 -07:00
Andrew Stanton-Nurse bd46d757ba
fix #2134 by disposing httpconnection if start fails (#2137) 2018-04-23 12:38:37 -07:00
BrennanConroy 33ee8626c8
Cache some property access in json hub protocol (#2128) 2018-04-22 09:55:38 -07:00
Andrew Stanton-Nurse 47eafca4d8
CancellationToken EVERYWHERE (#2101) 2018-04-20 16:21:51 -07:00
Andrew Stanton-Nurse 058830c9df
fix #2116 by requiring task return values from typed client (#2117) 2018-04-20 13:49:12 -07:00
BrennanConroy 9101ab636b
Always check for WebSockets close (#2100) 2018-04-20 08:21:04 -07:00
James Newton-King 5516a969e3
Change Hub and friends to abstract (#2108) 2018-04-20 20:53:01 +12:00
Andrew Stanton-Nurse ace9a0d414
fix #2097 by adding GetHttpContext to HubConnectionContext (#2099) 2018-04-19 19:14:39 -07:00
BrennanConroy 1957655653
Run hub invocations serially (#2086) 2018-04-19 16:59:06 -07:00
Andrew Stanton-Nurse 6b6d890c8f
fix #2078 by adding locking (#2079) 2018-04-19 15:32:04 -07:00
David Fowler 676bf179f3
Reduce redundant dependencies (#2091) 2018-04-19 00:18:52 -07:00
BrennanConroy e9937ffb66
Split lock into WriteLock and StateLock to prevent deadlocks and unneeded lock contention (#2081) 2018-04-18 17:44:05 -07:00
David Fowler 903fe1e902
Added support for negotiate response to redirect the client to another SignalR endpoint (#2070)
- Add a SkipNegotiation flag to the .NET and ts client
to allow skipping the negotiation phase. Don't infer it based on the transport type.
-  Updated the negotiate protocol to support returning a redirect url
- Added support to .NET client to handle redirect negotiations
- Handle poorly written endpoints that sends infinite redirects
- Added access token support and an infinite redirect guard
- Add delete handler for stopping the transport
2018-04-18 14:22:45 -07:00