Commit Graph

232 Commits

Author SHA1 Message Date
Ben Adams 8fcadf72cd Allow headers to match on ReferenceEquals before OrdinalIgnoreCase (#9341) 2019-04-18 12:00:01 -07:00
Andrew Stanton-Nurse f95960d856
[SignalR] Test definition isn't async (#9481)
Jest is warning us that this will be deprecated in the future. There's no reason for the `describe` callback to be `async` since all it's doing is registering tests through nested `it` calls.
2019-04-18 08:44:35 -07:00
Andrew Stanton-Nurse 46db367760
Fix #8974 by supporting strings in configureLogging for SignalR JS client (#9252) 2019-04-17 08:15:55 -07:00
Nate McMaster 607cbc3133
Suppress warnings about breaking changes to Newtonsoft.Json dependency in SignalR (#9405) 2019-04-16 09:11:55 -07:00
BrennanConroy 9fae14a926
System.Text.Json Hub Protocol (#8932) 2019-04-13 09:20:30 -07:00
Stephen Halter 28970a3e93
Fix SignalR TS client build on macOS (#9230) 2019-04-13 01:14:57 -07:00
Andrew Arnott 0684498efc Fix SignalR HubProtocol spec typo (#9338) 2019-04-12 16:29:04 -07:00
Brennan Conroy 6ecdff7c68 Merged PR 898: Update MessagePack dependency
Update MessagePack dependency
2019-04-12 22:25:38 +00:00
BrennanConroy b1ca2c1155
Properly wait for karma to exit (#9315) 2019-04-12 11:04:58 -07:00
Pranav K de39ededfa
Merge branch 'master' into merge/release/3.0-preview4-to-master 2019-04-11 14:43:21 -07:00
Pranav K ae34697797 Fix #9041 - Complain if auth hasn't been set up correctly (#9181) 2019-04-11 10:36:21 -07:00
Mikael Mengistu 74951717bc backport accessTokenProvider fix (#8726) 2019-04-10 13:14:15 -07:00
BrennanConroy af0fb91d9f
Remove writeline from test (#9056) 2019-04-10 10:06:06 -07:00
BrennanConroy 7c76144865
Remove Cpp Client from this repo (#9050) 2019-04-10 09:51:33 -07:00
Stafford Williams 3b32f43453 Crankier: Log connection exceptions (#9045) 2019-04-10 00:36:18 -07:00
Mikael Mengistu 454ac15443
Expose Connection Id in SignalR TS Client (#9188) 2019-04-09 12:56:07 -07:00
Mikael Mengistu 1a259fb49e
Stabilize StreamAsyncCanBeCanceledThroughGetAsyncEnumerator test (#9174) 2019-04-08 15:58:15 -07:00
Stephen Halter 74bba27f43
Implement auto reconnect for SignalR TypeScript client (#8566) 2019-04-08 07:33:20 -07:00
Mikael Mengistu 6f197a9e5d
Using IAsyncEnumerable in the .NET Client (#8935) 2019-04-06 11:48:29 -07:00
BrennanConroy 074b1757d7
Report JUnit test results for SignalR TS tests (#9058) 2019-04-04 08:21:19 -07:00
Stafford Williams 73ec62adbd Added Crankier docs (#9044)
Docs describing usage of Crankier
2019-04-04 08:06:23 -07:00
Mikael Mengistu 722a34cd56
Up the SignalR test timeout to match Kestrel's (#8563) 2019-04-03 16:36:40 -07:00
Pranav K d86c9b3f07
Use MessagePackReader \ MessagePackWriter to implement IHubProtocol for server-side Blazor (#8687)
* Use MessagePackReader \ MessagePackWriter to implement IHubProtocol for server-side Blazor

Fixes #7311
2019-04-01 14:25:23 -07:00
BrennanConroy 9d8990a710
Remove pplx::task from public API (#8747) 2019-03-29 23:54:44 -07:00
David Fowler 61b3504dbe
Added NegotiateMetadata to negotiate endpoints (#8907)
- This makes it a bit cleaner to identify the negotiate when trying to apply policies (like replacing the endpoint)
- Added tests that cover MapConnectionHandler for endpoint routing
2019-03-29 19:24:43 -07:00
Mikael Mengistu f10635f6c8
Java Client Expose ConnectionId on HubConnection (#8689) 2019-03-28 17:02:00 -07:00
Ryan Nowak 658b37d2bd
Make UseEndpoints a thing (#8765)
* Make endpoint middleware explicit

This change makes the endpoint middleware explicit again, and updates
all of the templates.

The other change here is make UseEndpoints be the place where you
register endpoints. This is vital because it puts your code visually at
the point of the pipeline where it executes.

Lastly, I removed support for UseMvc with endpoint routing. This is
causing issues for some security features, and we're moving in the
direction of trying to make the middleware heavy implementation required
in 3.0. There are some issues we won't be able to fix in MVC if we can't
unambiguously know if UseMvc was used or the middleware.
2019-03-28 15:41:11 -07:00
Mikael Mengistu 5e8a7ad725
Fix jasmine timeout for SignalR daily tests (#8748) 2019-03-28 11:45:15 -07:00
Mikael Mengistu 017f409fe4
Expose ConnectionId on .NET Client (#8668) 2019-03-27 17:30:43 -07:00
Mikael Mengistu e979426809
Update Gradle to version 5.3 - Now with retries (#8840) 2019-03-27 10:04:25 -07:00
Ryan Brandenburg 70cd5f5f9f
Mark tests flaky instead of skipped (#8727)
Mark tests flaky instead of skipped
2019-03-26 09:51:37 -07:00
BrennanConroy 969c72acfd
C++ client low level API (#8420) 2019-03-25 13:52:38 -07:00
Mikael Mengistu 316fbbe9c4
Marking tests as flaky(#8749) 2019-03-22 17:59:21 -07:00
Sebastien Ros 1fb26a6467 Fixing NETCore.App version in benchmarks 2019-03-22 16:49:09 -07:00
BrennanConroy 4b230ec419
Copy EndpointFeature when using LongPolling (#8730) 2019-03-22 15:36:57 -07:00
David Fowler 0d6e0637af Small HubConnection cleanup (#8643) 2019-03-21 16:30:56 -07:00
Mikael Mengistu 6038621630
Update acessTokenProvider selecting logic for restarting connection (#8569) 2019-03-19 10:55:53 -07:00
Mikael Mengistu 694dcae53e Make ResetSendPing and ResetTimeout private methods (#8525) 2019-03-14 22:05:07 -07:00
Mikael Mengistu cfe0cc38ec Resolve deadlock with `InvokeAsync` in `On` handler (#8334)
- Use a channel to unblock the dispatch loop
- Added tests
2019-03-14 22:04:36 -07:00
Stephen Halter 1338973212
Better handle HttpConnectionContext state transitions (#8225) 2019-03-14 11:33:32 -07:00
Mikael Mengistu a5e20fdc90
Fix SignalR build from VS (#8492) 2019-03-14 10:04:04 -07:00
Ryan Nowak e78a6521b9 Make naming of IEndpointRouteBuilderConsistent across usages. 2019-03-13 20:12:53 -07:00
BrennanConroy 2aa6c01b58
C++11 compliant (#8457) 2019-03-12 22:48:23 -07:00
Andrew Stanton-Nurse 61a9964a15
[BRT] Mitigating flaky SignalR tests (#8423)
* add the ability to skip c++ tests and skip signalr one (mitigates #8421)
2019-03-12 12:33:54 -07:00
Mikael Mengistu 5efa1ba0b9
Fix SignalR transport test (#8424) 2019-03-12 12:22:02 -07:00
David Fowler 107e1862b7
Add HubMetdata (#8425)
- Added HubMetadata to detect the hub type on Endpoints
- Added a test
2019-03-12 11:33:55 -07:00
BrennanConroy e4f5fef7ac
Fix race in LongPolling causing flaky tests (#8114) 2019-03-12 10:24:54 -07:00
Mikael Mengistu 96764d27eb
Returning rejected promises in HttpConnection (#8315) 2019-03-11 16:33:09 -07:00
Andrew Stanton-Nurse 8759aa2fc0
SignalR additional xml docs (#7980)
Reviewed our xml docs as both ramping back up after leave and docathon. Things look pretty good, added a few things to some public methods.
2019-03-11 09:29:41 -07:00
BrennanConroy aef62d9ff8 Backport SSR fix (#8174) 2019-03-08 10:00:18 -08:00
Mikael Mengistu c0c2bb3049
Skip flaky transport test (#8295) 2019-03-07 18:26:38 -08:00
Mikael Mengistu b1f828e161
Client to Sever Streaming Java Edition (#8222) 2019-03-07 09:34:28 -08:00
Ryan Brandenburg 7573597577 Merge branch 'merge/release/2.2-to-master' of github.com:dotnet-maestro-bot/AspNetCore into merge/release/2.2-to-master 2019-03-06 11:36:41 -08:00
Mikael Mengistu 9b4f8d79fd
Fix Java Client transport select (#8143) 2019-03-05 11:31:56 -08:00
David Fowler d1ee93b94b
Allow disabling automatic MVC reference (#8167) 2019-03-05 09:19:28 -08:00
Andrew Stanton-Nurse 98a49e332f
skip flaky SignalR test: ErrorDuringPollWillCloseConnection (#8171)
see #8138 for discussion on test priority and re-enabling
2019-03-05 08:30:40 -08:00
BrennanConroy c8c12cda9b
Fix test discovery (#8201) 2019-03-04 23:11:16 -08:00
BrennanConroy 508256d028
Always load NodeHttpClient to fix SSR (#8047) 2019-03-04 09:16:52 -08:00
David Fowler 9cb1185a5c
Add option to restrict the maximum hub message size (#8135)
- This change moves the limit checking from the transport layer to the protocol parsing layer. One nice side effect is that it gives us better control over error handling.
2019-03-03 15:18:32 -08:00
BrennanConroy 67d339ee3b
C++ client: string_t to string (#8063) 2019-03-02 22:11:18 -08:00
Ben Adams ddce32a791 Use C#8 (#8128) 2019-03-02 19:48:43 -08:00
Ryan Brandenburg 4a5720beba Updated PR with my changes 2019-03-01 15:25:58 -08:00
Andrew Stanton-Nurse 22e706cdc3 pr feedback 2019-03-01 13:55:45 -08:00
Andrew Stanton-Nurse 8c2c458891 some little xml doc changes 2019-03-01 13:55:45 -08:00
BrennanConroy 337370263a
Remove private assets (#8080) 2019-03-01 11:17:29 -08:00
BrennanConroy d0c415a4dc
Skip flaky websocket test (#8085) 2019-03-01 11:14:25 -08:00
Justin Kotalik 3509323ad1
Remove extra await/state machine in FlushAsync (#7646) 2019-02-28 22:42:42 -08:00
Mikael Mengistu 745941058c
Detect Classic SignalR Server in Java Client (#7817) 2019-02-28 18:12:53 -08:00
Nate McMaster e7b00a5508
Deprecate the Microsoft.AspNetCore.App metapackage in favor of targeting and runtime packs (#7832)
* Deprecate the Microsoft.AspNetCore.App metapackage in favor of targeting and runtime packs
* Stop producing Microsoft.AspNetCore.App, and runtime.$(rid).Microsoft.AspNetCore.App
* Generate the shared framework without using 'NuGet' restore
* Stop producing intermediate packages for shared-framework only assemblies
* Put the platform manifest into the targeting pack (data/Microsoft.AspNetCore.App.PlatformManifest.txt)
* Create well-known, shared intermediate directories that installers can use to bundle content
2019-02-28 10:14:18 -08:00
BrennanConroy 47220cf13e
Fix StreamInvocationsBlockOtherInvocationsUntilTheyStartStreaming (#8015) 2019-02-28 09:23:33 -08:00
Sébastien Ros fd83f4dbb9
Using <FrameworkReference> in benchmark apps (#7957) 2019-02-27 10:27:01 -08:00
Mikael Mengistu 0d570a2d42
Add small doc comment for TransportType Enum(#7994) 2019-02-27 09:17:08 -08:00
Stephen Halter 46fe595606
Support IAsyncEnumerable returns in SignalR hubs (#6791) 2019-02-25 15:08:11 -08:00
Mikael Mengistu 3d17ac3d4c
Handle onReceive logic in background thread (#7809) 2019-02-25 14:24:07 -08:00
Nate McMaster f2658821b5
React to System.Runtime.CompilerServices.Unsafe moving into Microsoft.NETCore.App
React to dotnet/corefx#35526
2019-02-24 15:37:03 -08:00
BrennanConroy f8368097a9
Remove web::uri usage from public API (#7834) 2019-02-23 13:35:37 -08:00
Stephen Halter 90e893ed07
React to #7751 (#7842) 2019-02-22 16:24:01 -08:00
Nate McMaster f0ef784783 Run yarn import to convert package-lock.json to yarn.lock 2019-02-22 13:30:19 -08:00
Nate McMaster 5be7d30231 Replace npm commands with yarn 2019-02-22 13:30:19 -08:00
Pavel Krymets 9355c7c1a5
Add reference assemblies support (#7764) 2019-02-21 14:33:35 -08:00
Ryan Brandenburg 019a1be305 Make the linter happy 2019-02-20 17:02:56 -08:00
Ryan Brandenburg 918f3d3c40 Fix merge doubling 2019-02-20 16:35:52 -08:00
Ryan Brandenburg b2ee8e6b66 Merge branch 'merge/release/2.2-to-master' of https://github.com/dotnet-maestro-bot/AspNetCore into merge/release/2.2-to-master 2019-02-20 16:21:24 -08:00
Mikael Mengistu f33cc20dbf
Add support for Async On Delegates (#7700) 2019-02-20 15:44:54 -08:00
BrennanConroy e455c2c22b
Add negotiation response support (#7675) 2019-02-20 12:38:43 -08:00
Nate McMaster 9a2db43848
Follow-up to VS2019 conversion (#7753)
* Set VS version in file to 16.0.0.0
* Fix for restore failure on Microsoft.AspNetCore.App.Runtime.csproj
2019-02-20 11:02:38 -08:00
Nate McMaster 85ae18c723
Make Visual Studio 2019 a prerequisite to building this repo (#7005)
Changes:

* Make Visual Studio 2019 a prerequisite for building this repo
* Update .sln files
* Update Windows SDK to 17134
* Update developer docs
* Disable ANCM tests
* Update to .NET Core SDK 3.0 Preview 2
* Use Microsoft.NET.Sdk.Razor as a package consistently accross the repo
* React to changes in metadata from Microsoft.NETCore.App
* React to changes in .NET Core SDK
* Attempt to workaround CodeCheck.ps1 failure which doesn't repro locally or on different agents. Possibly due to differences in the version of the PowerShell task?
* Remove dead YML file
* Rename usages of win7-{x64,x86} to win-{x64,x86}
* Update KoreBuild to 3.0.0-build-20190219.1
2019-02-20 09:53:53 -08:00
Chris Ross 4e44025a52
Replace IHostingEnvironment with IWebHostEnvironment (#7725) 2019-02-19 21:11:52 -08:00
BrennanConroy f37d30833d
Ignore unexpected stream items and completions from client (#7511) 2019-02-19 15:25:50 -08:00
Mikael Mengistu d1fac57734
Ensure SignalR client messages are processed in order (#7697) 2019-02-19 11:48:22 -08:00
TimTim dffe9abf6b Fix connection ID (#7681) 2019-02-18 17:13:53 -08:00
Mikael Mengistu af43b80b1a Make server timeout configurable (#7340) 2019-02-17 07:57:36 -08:00
Stephen Halter 8ae4c4dbd6 Add SignalR web worker sample and test (#7378) 2019-02-17 07:52:18 -08:00
David Fowler 799b91a324
Change the namespace of the extension methods (#7651)
- The other routing extension methods use Microsoft.AspNetCore.Builder
2019-02-16 00:36:59 -08:00
Mikael Mengistu c806c5a61a
Wait for stop to complete in SignalR test to prevent flakiness. (#7634) 2019-02-15 18:42:04 -08:00
David Fowler 5ef51822de
Added endpoint routing support (#7608)
- Basic endpoint routing support to for SignalR hubs, ConnectionHandler and IConnectionBuilder endpoints
- Updated all functional tests and samples to use it
- Added all attributes as metadata from Hubs and ConnectionHandlers
- Added a test to verify client is rejected if auth is ineffective
2019-02-15 12:32:01 -08:00
BrennanConroy 9fda946f0f
[Backport] Add CancelInvocation support to MsgPack in TS client (#7404) 2019-02-14 13:49:49 -08:00
Joseph Musser 50587d7d6d Fix “must comprised of” (#7519)
* Fix missing word

* Replace ‘comprise’ with simpler wording
2019-02-14 09:27:55 -08:00
BrennanConroy bca85b92fc
More C++ Client cleanup (#7551) 2019-02-14 08:31:15 -08:00
BrennanConroy 9de42d516e
Copy Kestrel perf changes (#7480) 2019-02-13 16:31:37 -08:00