Commit Graph

3 Commits

Author SHA1 Message Date
N. Taylor Mullen d312d797fc Change non-public [Parameter] warning severities to error.
- In preview8 we warned users for non-public `[Parameter]`s and `[Parameter]` setters. For preview9 this is now an error because things will not work as they expect.
- Updated existing tests to reflect the new error expectation.

#12294
2019-08-02 10:25:26 -07:00
N. Taylor Mullen a2e26434aa Don't apply analyzer restrictions to cascading parameters.
- Today all of our analyzer warnings only operate on `[Parameter]` properties.
- Updated existing test to not expect `CascadingParameter` as a possible error case.
- Added a new test to ensure we skip `CascadingParameter`s.

#8825
2019-07-12 10:28:27 -07:00
N. Taylor Mullen b647a223f7 Add analyzer to expect public properties for component parameters.
- If we find a parameter that is non-public we will create a warning for that situation and notify the user.
- Updated the naming of existing properties and classes that referred to public/private required properties to be specific to those properties setters (that's what they verified before these changes).
- Updated test expectations and names.
- Changed the code fix provider to no longer worry about the property setters and instead inspect the properties declared accessibility. Did not re-add the property setter code fix provider because these code fix providers do nothing in practice (Razor light bulbs aren't enabled in the editor).
- Added new tests.

#8825
2019-07-08 13:56:16 -07:00