Commit Graph

779 Commits

Author SHA1 Message Date
David Fowler 5e7f63b096
Make un-graceful shutdown a bit more graceful (#2748)
* Make un-graceful shutdown a bit more graceful
- Change how graceful shutdown is done to ensure there are no errors on shutdown.
- Avoid closing pipes from under other components that own those pipes.
- Close the application output so that the application's read loop ends gracefully. For websockets, we cancel the token, for other transports, we close the output directly.
2018-08-07 21:39:09 -07:00
BrennanConroy e403de7fbf
Solve LongPolling races by moving Cts disposal to connection disposal (#2731) 2018-08-06 19:17:29 -07:00
BrennanConroy e78e3db6f4
Honor InherentKeepAliveFeature for server timeout (#2727) 2018-08-06 10:37:12 -07:00
BrennanConroy 810c7cf9ad
Fix ODE race with cancellationtokensource (#2721) 2018-08-02 15:24:26 -07:00
BrennanConroy 90606338fb
Log when closing connection due to timeout (#2722) 2018-08-02 15:21:24 -07:00
BrennanConroy c8eedb3540
Fix race when connection is canceled and new poll comes in (#2697) 2018-07-31 16:36:54 -07:00
BrennanConroy 651b39bc90 Revert "Merge branch 'master' into release/2.2"
This reverts commit 785200877a, reversing
changes made to 3d6e1e69fd.
2018-07-31 15:24:33 -07:00
Mikael Mengistu 785200877a
Merge branch 'master' into release/2.2 2018-07-31 10:22:09 -07:00
BrennanConroy 3d6e1e69fd
Close LongPolling connection on poll exception (#2701) 2018-07-31 09:52:10 -07:00
BrennanConroy 34a7fc4d99 Merge branch 'merge/release/2.2-to-master' 2018-07-25 11:45:32 -07:00
BrennanConroy 433eeb6943
Abort connection on protocol error (#2654) 2018-07-19 14:50:14 -07:00
Dylan Dmitri Gray 748e992865
Dygray/handshake versioning (#2520)
* set minor versions on the protocols
2018-07-05 16:42:42 -07:00
Dylan Dmitri Gray e7e2ca50e9
Ping Cleanup (#2530)
Tidied up some comments, to make the ResetPing client behavior easier to understand.

Will ping in debug mode for consistency. If this becomes a problem when debugging, developers can disable the pings manually. It's easier to fix something noisy, than try to diagnose inconsistently missing behavior.
2018-06-25 17:09:05 -07:00
Mikael Mengistu a4a8b49908
Removed extra reference to Internal.AspNetCore.Sdk (#2475) 2018-06-12 16:12:52 -07:00
Mikael Mengistu c7ebae47ea
Show detailed error message for HubExceptions (#2461) 2018-06-11 13:55:47 -07:00
BrennanConroy 0306038658
Return empty string for connectionId in some cases (#2470) 2018-06-11 12:50:34 -07:00
Mikael Mengistu dd64e4d9a5
Clean up Spec Test dependencies (#2451) 2018-06-08 15:28:23 -07:00
Mikael Mengistu e41764c161
Update AddSignalRCore to respect user registered services (#2434) 2018-06-07 16:32:37 -07:00
Nate McMaster 9d58e41521
Update Microsoft.AspNetCore.SignalR.Specification.Tests.csproj (#2449) 2018-06-07 12:26:09 -07:00
Mikael Mengistu 648705f648
Create a Public Test Suite for HubLifetimeManager implementations (#2353) 2018-06-06 16:59:55 -07:00
Dylan Dmitri Gray 3d0f68b22c
server closes connections that have gone silent (#2364) 2018-06-05 15:21:55 -07:00
James Newton-King 4f85ca2b1d
Add connection ID scope to HubConnection (#2394) 2018-06-01 11:12:51 +12:00
James Newton-King 8d680db112
Remove scanning connections log messages (#2397) 2018-05-30 15:29:46 +12:00
Dylan Dmitri Gray f0f1df9b4a
PingInterval -> KeepAliveInterval (#2384) 2018-05-25 15:15:38 -07:00
James Newton-King 02a9bde10d
Fix flaky ClientPingsMultipleTimes test (#2368) 2018-05-24 17:29:15 +12:00
James Newton-King 5c633aa183
Log 404 responses from long polling transport DELETE as Debug instead of Error (#2366) 2018-05-24 14:21:48 +12:00
Dylan Dmitri Gray 736b7f5042
Client pings server on interval (#2309) 2018-05-23 13:53:23 -07:00
James Newton-King e29296220d
Fix not reading to end of argument JSON on binding error (#2319) 2018-05-19 19:50:43 +12:00
James Newton-King 879646aba3
Fix losing UTC DateTimeKind on ISO8601 UTC values (#2317) 2018-05-19 18:43:14 +12:00
James Newton-King 96bbe70cd8
Handle incoming HTTP requests being canceled gracefully (#2314) 2018-05-19 13:32:05 +12:00
James Newton-King bff2060454
Fix JsonHubProtocol error message when too many arguments (#2312) 2018-05-18 19:55:53 +12:00
BrennanConroy 32cee74a0c
Generate baselines and enable Api check (#2304) 2018-05-17 15:21:13 -07:00
Pavel Krymets 3719dc00fa
Enable analyzers (#2300) 2018-05-17 09:48:07 -07:00
James Newton-King eaa03679de
Fix flakey tests from SSE receiving a 404 response on stop (#2282) 2018-05-17 18:31:56 +12:00
Andrew Stanton-Nurse 2388dd3a76
Merge pull request #2287 from aspnet/release/2.1
Android HttpClientHandler.ClientCertificates fix (#2270)
2018-05-16 12:39:50 -07:00
James Newton-King e1a22b315d Android HttpClientHandler.ClientCertificates fix (#2270) 2018-05-16 11:25:39 -07:00
Mikael Mengistu 2041cf6ede
Don't create empty lambdas (#2283) 2018-05-16 11:12:53 -07:00
Mikael Mengistu 283297f455
Remove handlers from HubConnection (#2267) 2018-05-15 23:57:02 -07:00
BrennanConroy 9cb683a41d Merge branch 'release/2.1' into dev 2018-05-15 16:16:02 -07:00
BrennanConroy 95f543848c
Fix multiple connections for a single user in Redis and MemoryLeak (#2273) 2018-05-15 15:57:23 -07:00
James Newton-King 43aa392dff
Add state to TS HubConnection (#2268) 2018-05-16 08:43:08 +12:00
James Newton-King 7625bbcb6c
Add HubConnection.State (#2204) 2018-05-14 19:23:00 +12:00
Stephen Halter ffc665ccc2 Use correct TaskCompletionSource ctor (#2261)
https://github.com/dotnet/corefx/issues/29664
2018-05-13 19:52:19 -07:00
BrennanConroy 7916f95235 Merge branch 'release/2.1' into dev 2018-05-10 16:54:26 -07:00
BrennanConroy 4b1fb58a8a
Throw error on unexpected close (#2205) 2018-05-10 16:38:21 -07:00
James Newton-King db33d593f0
Gracefully handle disposing while writing (#2180) 2018-05-09 17:57:56 -07:00
BrennanConroy f09b0e13d9
Upgrade to netcoreapp2.2 and remove netcoreapp2.0 testing (#2221) 2018-05-09 09:59:02 -07:00
Mikael Mengistu 62d892315b
Merge pull request #2224 from aspnet/release/2.1
Use params passed into HubConnectionBuilder (#2223)
2018-05-07 21:44:04 -07:00
Mikael Mengistu 6f6382799b
Use params passed into HubConnectionBuilder (#2223) 2018-05-07 18:19:20 -07:00
James Newton-King da7a95f563
Handle null collections when writing NegotiateResponse (#2202) 2018-05-04 16:08:06 -07:00