Commit Graph

95 Commits

Author SHA1 Message Date
David Fowler 667f7ca491
Don't fire DiagnosticSource.StopActivity in some cases (#9595)
- Don't fire the event if DiagnosticSource.StartActivity was never called. This avoids allocating the anonymous object and extra strings.
2019-04-21 16:09:40 -07:00
Ben Adams b893777898 HostingApplicationDiagnostics resolve Request.Headers once (#9605) 2019-04-20 20:41:49 -07:00
John Luo 7a040f310b
Enable Pubternal API checks (#9530)
* Enable Pubternal API checks

* Use pragma

* Convert to pragma

* Test fix

* Remove extra restore dependencies
2019-04-19 18:49:07 -07:00
Pavel Krymets 56c064bd53 Display startup errors in ANCM (#8518) 2019-04-18 13:48:48 -07:00
Ben Adams 8fcadf72cd Allow headers to match on ReferenceEquals before OrdinalIgnoreCase (#9341) 2019-04-18 12:00:01 -07:00
Justin Kotalik 8b536b08ca
Revert "Skip IIS Express on Windows 7 (#8330)" (#9490)
This reverts commit b2a58ab8de.
2019-04-18 08:57:50 -07:00
David Fowler 32c46c7201
Create an activity more often than before (#9361)
- Create an Activity if there's a diagnostic listener attached with the activity name or if logging is enabled.
- Add the activity id to the logging scope (and call the field ActivityId)
2019-04-17 18:23:12 -07:00
Liudmila Molkova 4649449206 Call DiagnosticListener.OnActivityImport before starting Activity to support sampling better (#9340)
* use OnActivityImport and HttpContext in the extra argument
2019-04-15 18:48:56 -07:00
David Fowler 717fa39167
Remove target invocation exceptions from Startup invocation (#9318)
- This change takes advatage of the new DoNotWrapExceptions binding flag to avoid throwing a TargetInvocationException when invoking Configure/ConfigureServices and ConfigureContainer
2019-04-12 08:26:42 -07:00
Patrick Westerhoff bcad853cbd Dispose configuration in WebHost (#9149)
Register the application configuration as a factory to make it dispose
automatically when the service provider gets disposed. This will dispose
the underlying configuration providers and change token registrations.

The host configuration will be disposed implicitly when the chained
configuration provider within the app configuration gets disposed.
2019-04-11 07:16:44 -07:00
penenkel b6bbc29498 HostingLogScope now logs RequestPath as Request.BasePath+Request.Path #8942 (#8944) 2019-04-02 12:33:15 -07:00
Daniel Marbach d24ec01224 Add overload for Configure that gets WebHostBuilderContext (#8697) 2019-03-28 10:10:06 -07:00
Vance Morrison 18b81bacce Support for receiving ID via TraceParent HTTP header. (#8495)
- Also moved the fetching of ANY HTTP header fields until AFTER the most stringent
- Check to see if logging is on (thus deferring work if the logger is sampling).
- Added transfer of TraceState from http header to Activity
- Added tests to insure that we were reading traceparent and tracestate headers as expected.
2019-03-27 22:40:17 -07:00
Ryan Brandenburg 7248ecbaf1
Make some skipped tests flaky (#8795) 2019-03-27 10:20:16 -07:00
Ryan Brandenburg 70cd5f5f9f
Mark tests flaky instead of skipped (#8727)
Mark tests flaky instead of skipped
2019-03-26 09:51:37 -07:00
Mikael Mengistu 316fbbe9c4
Marking tests as flaky(#8749) 2019-03-22 17:59:21 -07:00
Chris Ross 0456c9dcc9
Handle SIGTERM exit code #6526 (#8294) 2019-03-19 19:15:00 -04:00
Justin Kotalik 9f724f6ac4 Revert "Publish MusicStore as part of build (#8578)" (#8655)
This reverts commit f3eaa73c1a.
2019-03-19 11:03:48 -07:00
Pranav K f3eaa73c1a
Publish MusicStore as part of build (#8578)
* Publish MusicStore as part of build

* Add a target to publish MusicStore as part of E2E tests
* Publishing for x86 causes unit tests in MusicStore to have weird
reference issues. Removing these since they are very pretty low value.
2019-03-19 07:17:55 -07:00
Alexey Malinin 2eb0692434 Change name of argument in "WebHostExtensions" (#8411) 2019-03-16 12:16:27 -04:00
Pavel Krymets b2a58ab8de
Skip IIS Express on Windows 7 (#8330)
https://github.com/aspnet/AspNetCore/issues/8329
2019-03-11 08:44:28 -07:00
Justin Kotalik 02dbe55466
Fix StartsWithPortableAndBootstraperExe (#8219) 2019-03-06 11:59:42 -08:00
Chris Ross c0e6722020
Make ConventionBasedStartup pubternal #6975 (#7800) 2019-02-28 15:21:01 -08:00
Chris Ross f168835c0a
Avoid port conflicts for HttpSys Internal/#1795 (#7808) 2019-02-28 10:31:15 -08:00
Chris R 87ae40f814 Update Microsoft.AspNetCore.Hosting.Abstractions ref assembly 2019-02-25 17:17:10 -08:00
Doug Bunting d515bd977f
Merge branch 'master' into merge/release/3.0-preview3-to-master 2019-02-25 15:56:46 -08:00
Chris Ross ff79e9bda5
Replace EnvironmentName with Environments #7733 (#7899) 2019-02-25 08:13:48 -08:00
Pavel Krymets f1b188611a
Fix generated code (#7883) 2019-02-22 18:15:13 -08:00
Nate McMaster 7fe3b7640d
Merge branch 'release/3.0-preview3' 2019-02-22 15:07:50 -08:00
Chris Ross 7d90d4d1e7
Use friendly obsolete messages (#7831) 2019-02-22 08:40:34 -08:00
Pavel Krymets 9355c7c1a5
Add reference assemblies support (#7764) 2019-02-21 14:33:35 -08:00
Nate McMaster 9a2db43848
Follow-up to VS2019 conversion (#7753)
* Set VS version in file to 16.0.0.0
* Fix for restore failure on Microsoft.AspNetCore.App.Runtime.csproj
2019-02-20 11:02:38 -08:00
Nate McMaster 85ae18c723
Make Visual Studio 2019 a prerequisite to building this repo (#7005)
Changes:

* Make Visual Studio 2019 a prerequisite for building this repo
* Update .sln files
* Update Windows SDK to 17134
* Update developer docs
* Disable ANCM tests
* Update to .NET Core SDK 3.0 Preview 2
* Use Microsoft.NET.Sdk.Razor as a package consistently accross the repo
* React to changes in metadata from Microsoft.NETCore.App
* React to changes in .NET Core SDK
* Attempt to workaround CodeCheck.ps1 failure which doesn't repro locally or on different agents. Possibly due to differences in the version of the PowerShell task?
* Remove dead YML file
* Rename usages of win7-{x64,x86} to win-{x64,x86}
* Update KoreBuild to 3.0.0-build-20190219.1
2019-02-20 09:53:53 -08:00
Chris Ross 4e44025a52
Replace IHostingEnvironment with IWebHostEnvironment (#7725) 2019-02-19 21:11:52 -08:00
Doug Bunting 3e0c75187c
Place limits on model binding collection size and recursion depth (#7214)
- #7052
- add MvcOptions.MaxModelBindingCollectionSize` and `MvcOptions.MaxModelBindingRecursionDepth`

nits:
- update syntax of a few `Resources.Designer.cs` files (I ran `/t:resx` on Mvc.sln)
- take VS suggestions in a few test classes
2019-02-19 15:17:56 -08:00
Chris R b571246c93 Suppress warnings for obsolete Extensions types 2019-02-17 09:29:57 -08:00
David Fowler 0fd753bfc2
Align host behavior with respect to exceptions (#7657)
- Don't catch errors in IHostedService.StartAsync
- Only catch errors when executing StopAsync but rethrow an aggregate
- Updated the tests
2019-02-16 19:09:14 -08:00
Chris Ross 93a24b03bb
Disable AllowSynchronousIO by default in all servers #4774 (#5120)
* Disable AllowSynchronousIO by default in all servers
2019-02-15 16:05:49 -08:00
Nate McMaster 338de4710a
Automatically set 'PrivateAssets=All' for .Sources references (#7539)
When a `<Reference>` is named `*.Sources`, set PrivateAssets=All (exclude from generated nuspec) and IncludeAssets=ContentFiles (only consume content files, not .dll's)
2019-02-13 14:31:15 -08:00
Nate McMaster 3fd8a97af2
Add targets to generate the list of shared framework assemblies from project property (#7510)
Changes:
* Add support for a property, `IsAspNetCoreApp`, in the .csproj file of assemblies which are part of the shared framework. 
* Remove unused dependencies
* Remove reference which have become part of 'netcoreapp3.0'
2019-02-12 23:00:19 -08:00
David Fowler 3be85751d5
Make Hosting.sln compile in vs (#7431) 2019-02-10 16:24:33 -08:00
Hao Kung 26acbc3861
Reorganize helix files (#7353) 2019-02-07 16:27:48 -08:00
Hao Kung c9499e14e4
Run helix tests on master (#6728) 2019-02-07 09:20:08 -08:00
Pavel Krymets 5cd72c1fb2
Remove ANCMV1 from everywhere (#7334) 2019-02-07 09:06:27 -08:00
Pavel Krymets b21c09665e
Add DisposeAsync support to WebHost and RequestServices (#7091) 2019-02-05 15:42:41 -08:00
Pavel Krymets 35746adf68
Allow test projects to run standalone (#7144) 2019-02-01 15:19:49 -08:00
Nate McMaster 6081fec894
Add new build.cmd/sh options for suppressing restore, NodeJS, setting target arch and OS name, and more (#7137)
Add new command line parameters for working with the project:

* `-NoBuild`, `-NoRestore` - these already existed, but users found it hard to discover this powershell syntax: '-build:$false'
* `-Arch`/`--arch` - set the target CPU architecture to build. Defaults to x64
* `--os-name` - on non-Windows builds, manually specify if the build should target Alpine. generic Linux, or MacOS
* Rename flags used to build specific project types. The pattern now is `--build-$(group)` or `--no-build-$(group)` (In PowerShell its `-Build$(Group)` or `-NoBuild$(Group). Example: -NoBuildJava

Changes to build definitions:
* Update the ci build definition to build all supported architectures
* Support publishing multiple artifacts per job

Other changes:
* `-NoBuild` implies `-NoRestore`
* Add new properties, `TargetArchitecture`, `TargetOsName`, and `TargetRuntimeIdentifier`
* Replace usages of `SharedFxRid` with these new properties
* To make `--no-build-nodejs` actually work, replaced Components.Browser.JS.csproj with Components.Browser.JS.npmproj
* Fix errors when building for win-arm on a clean machine
* Fix a few other project errors, like using the wrong syntax for DefaultItemExcludes, or using the wrong Platform value for x86
2019-01-31 15:47:47 -08:00
Pavel Krymets f06e1822f5
Enable strict mode in roslyn compiler (#6950) 2019-01-28 15:56:27 -08:00
Nate McMaster ac04019e42
Remove obsolete build infrastructure (#6995)
Changes:

* Remove obsolete targets which are unnecessary now that this repo no longer builds git submodules in a separate build process
* Remove the need for static analysis of 'ArtifactInfo' items
* Simplify how the code signing task is configured
* Remove unused repo tasks
* Remove duplicate lists of external dependencies and packages to be produced
* Remove obsolete build definition
* Remove obsolete build script parameters
* Add VisualStudioSetupOutputPath
2019-01-28 09:57:59 -08:00
Chris Ross a16a6dfaeb
Block generic host Startup.ConfigureServices that return IServiceProvider #5149 (#6997) 2019-01-25 08:16:39 -08:00