Commit Graph

20207 Commits

Author SHA1 Message Date
Ryan Brandenburg b501f13fb3
Quarantine a flaky test (#23827) 2020-07-09 23:44:29 +00:00
Youssef Victor 32b8ad6dce
Add missing comma to xml documentation (#23634) 2020-07-09 16:02:11 -07:00
Ryan Brandenburg a5901c084a
Include Assets in helix builds (#23784)
* Include Assets in helix builds
* Fix IdentityUI test
2020-07-09 13:47:51 -07:00
Javier Calvarro Nelson 0c5c1771ef
[Https] Export the certificate in PEM format too (#23803)
* Changed `--key-format` to `--format`.
* Changed the format of the certificate to PEM when `--format pem` is indicated.
2020-07-09 10:04:12 -07:00
github-actions[bot] eac4925653
Sync shared code from runtime (#23796) 2020-07-09 08:24:42 -07:00
Steve Sanderson 6cb575216f
Cache JS->.NET string decoding results within a single renderbatch (#23773) 2020-07-09 14:40:37 +01:00
Brennan c202344d27
[Java] Test accessTokenProvider usage (#23751) 2020-07-08 19:18:25 -07:00
Safia Abdalla bbc116254a
Add framework support for lazy-loading assemblies on route change (#23290)
* Add framework support for lazy-loading assemblies on route change
* Configure lazy-loaded assemblies in WebAssemblyLazyLoadDefinition
* Move tests to WebAssembly-only scenarios
* Refactor RouteTableFactory and add WebAssemblyDynamicResourceLoader
* Address feedback from peer review
* Rename 'dynamicAssembly' to 'lazyAssembly' and address peer review
* Add sample with loading state
* Update Router API and assembly loading tests
* Support and test cancellation and pre-rendering
* Apply suggestions from code review
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
* Spurce up API and add tests for pre-rendering scenario
* Use CT instead of CTS in NavigationContext
* Address feedback from peer review
* Remove extra test file and update Router
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-07-08 18:16:47 -07:00
Kevin Pilch 3117f43c33
Migrate to single sln file + slnf files (#23581) 2020-07-08 15:27:22 -07:00
Kevin Pilch 1da13e6501
Enable FxCop Analyzers for the repo (#23709)
All rules are currently disabled, except for one that I enabled for
src/Http via a new ".editorconfig" file I added there.

Other changes:

* Allow editorconfigs in MVC and Razor to flow to the root
* Consolidate a few editorconfig settings
* Tweak Ruleset config in Azure/AzureAD where it clashed.

Addresses the beginning of #9620, but it's a fair chunk of work to
enable most rules through the whole repo. That can be done directory by
directory and rule by rule by dropping .editorconfig files though.
2020-07-08 15:26:22 -07:00
Steve Gordon f83ce075ca
Fix summary comment (#23702)
It seems like this should say "locked out", rather than "logged out".
2020-07-08 21:13:11 +00:00
Pranav K 763a18ee56
Avoid running restores for dotnet-watch run (#23421)
* Tweaks to make dotnet-watch run faster

* Previously dotnet-watch calculated the watch file list on every run by invoking MSBuild. This
  changes the tool to only calculate it if an MSBuild file (.targets, .props, .csproj etc) file changed
* For dotnet watch run and dotnet watch test command, use --no-restore if changed file is not an MSBuild file.

* Add opt-out switch

* Update src/Tools/dotnet-watch/README.md

* Fixup typo

* Update src/Tools/dotnet-watch/README.md
2020-07-08 18:56:25 +00:00
Martin Costello 769fc6d289
Cache Entries' Count for loops (#23707)
Cache the value of Entries.Count into a local when enumerating loops, rather than re-evaluating on each pass.
2020-07-08 09:40:49 -07:00
Steve Sanderson 1bccebd22a
Fix razor whitespace removal in methods (#23699) 2020-07-08 12:43:09 +01:00
Steve Sanderson c5ba43f011
CSS isolation rewriter tool (#23657) 2020-07-08 12:42:22 +01:00
Chris Sainty b8c5193562
[Blazor][Wasm] Expose login mode option for AAD and AAD B2C Authentication (#23694)
* Adds a login mode option via MSAL provider options and updates the AuthenticationService.ts to use the new setting
2020-07-08 04:26:33 -07:00
Huei Feng 37a4457150
Update `StaticWebAssetsFileProvider NormalizePath` (#22418)
Skips an unnecessary null check.
2020-07-08 01:58:39 -07:00
Doug Bunting 16be480616
Quarantine tests and bump Helix timeouts (#23762)
- see #23756 and #23757 for more info on quarantined tests
- see #23760 for more info on Helix timeouts
2020-07-07 19:56:30 -07:00
Brennan d0ab959c89
TestServer registers NoopHostLifetime to avoid hangs from not disposing (#23761) 2020-07-07 19:50:31 -07:00
James Newton-King 3709eda270
Fix HTTP/2 stream output flow control abort error (#23727)
* Fix stream output flow control abort error

* Clean up

* Clean up

* Add timeouts
2020-07-08 01:41:23 +00:00
Eric Erhardt cc3c1d0e74
Remove unnecessary entries in LinkerWorkaround for WASM. (#23747)
* The underlying Json issue is fixed.
* The X509 issue is not an issue when TrimMode is set to link (which is it now by default).

Contributes to #23262
2020-07-08 01:00:21 +00:00
Brennan f1dd68f1bd
[Middleware] Move to GenericHost (#23626) 2020-07-07 17:32:35 -07:00
Pranav K 93634cd772
Follow ups for nullable (#23736)
* Follow ups for nullable

* Update src/Http/Routing/src/Matching/DfaMatcherBuilder.cs

Co-authored-by: James Newton-King <james@newtonking.com>

Co-authored-by: James Newton-King <james@newtonking.com>
2020-07-07 21:46:50 +00:00
Hao Kung 380a5679bb
Remove bootstrap v3 (#23547) 2020-07-07 11:40:30 -07:00
Steve Sanderson 0ec15ea01d CR: Add ctor overload accepting IComponentActivator 2020-07-07 19:27:21 +01:00
Steve Sanderson 9e365f4356 CR: Make DefaultComponentActivator internal 2020-07-07 19:27:21 +01:00
Steve Sanderson 53588b45dc Updates to IComponentActivator PR 2020-07-07 19:27:21 +01:00
Mladen Macanović dae55edfec Add IComponentActivator 2020-07-07 19:27:21 +01:00
Javier Calvarro Nelson 156023d3f9
[HTTPS] Support exporting the dev-cert in PEM format and support importing an existing dev-cert in PFX (#23567)
* Support exporting the certificate key into PEM format
* Support importing an existing https dev certificate into the certificate store
2020-07-07 08:26:08 -07:00
Martin Costello 54bd692c78
Use TryGetValue() in TokenExtensions (#23708) 2020-07-06 22:27:59 -07:00
Pranav K 8750cd1038
Nullable followup for Routing (#23474)
* Nullable followup for routing.

* Update nullability based on usage
* Use nullable enable in a few files

* More nullable
2020-07-07 03:24:20 +00:00
Martin Costello fd1f1c3559
Use preferred overloads of string.Split() (#23712)
* Use preferred overloads of string.Split

* Revert TrimEntries for netstandard2.0

Revert usage of StringSplit.TrimEntries for projects that target netstandard2.0.

Co-authored-by: Levi Broderick <levib@microsoft.com>
2020-07-06 16:49:38 -07:00
msftbot[bot] a738d1ccfb
Merge pull request #23717 from dotnet-maestro-bot/merge/release/5.0-preview7-to-master
[automated] Merge branch 'release/5.0-preview7' => 'master'
2020-07-06 23:41:07 +00:00
Tanay Parikh 1c2a0f4fe6
Add Razor TagHelper Parsing Benchmarks (#23627)
* Add Razor TagHelper Parsing Benchmarks

Benchmarks:
|                                  Method |        Mean |     Error |    StdDev |     Op/s | Allocated |
|---------------------------------------- |------------:|----------:|----------:|---------:|----------:|
|      'TagHelper Design Time Processing' | 2,331.51 us | 28.916 us | 27.048 us |    428.9 | 985.33 KB |
| 'TagHelper Component Directive Parsing' |    90.46 us |  0.472 us |  0.394 us | 11,055.1 |   3.01 KB |

Notes / Attributions:
- `BlazorServerTagHelpers` is just a demo file concatonated from the basic `BlazorServer` files
- `taghelpers.json` was updated from: 73c96f1c00/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Performance/taghelpers.json
- `ReadTagHelpers` was copied over from fef50ba623/src/Razor/benchmarks/Microsoft.AspNetCore.Razor.Performance/ProjectSystem/ProjectSnapshotManagerBenchmarkBase.cs (L83-L93)

Fixes: https://github.com/dotnet/aspnetcore/issues/23454
2020-07-06 16:32:12 -07:00
Ajay Bhargav B 7412976b4c
Update Roslyn package versions (#23630)
* Update Roslyn package versions

* Fixes

* Fix analyzer warnings

* Fix root cause for analyzer warnings

* Fixed RuntimeCompilation test

* Add back nowarns
2020-07-06 14:35:10 -07:00
N. Taylor Mullen 17b01ae667 Fix PoliCheck issues
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1151846
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1151847
2020-07-06 13:02:45 -07:00
Kahbazi 5a375a7c22
Add Extensions method for options (#23602) 2020-07-06 11:54:44 -07:00
Martin Costello bbb695fe16
Minor code refactoring to TestHost library (#23692)
* Make fields readonly

Make a number of fields that aren't changed readonly.

* Use range to trim string

Use a range to trim the last character of the paths.

* Use nameof()

Use nameof() for exceptions rather than literals.

* Use Task.CompletedTask

Use Task.CompletedTask instead of Task.FromResult().

* Use Array.Empty()

Use Array.Empty() instead of allocating an empty array.

* Remove unused parameter

Remove unused CancellationToken parameter.

* Fix compilation error

Fix compilation error.

* Apply suggestions from code review

Add comment explaining range syntax.
2020-07-06 11:52:53 -07:00
Stephen Halter 0bc8ad7e6e
Change HttpRequest/ResponseJsonExtensions namespace (#23496) 2020-07-06 11:28:57 -07:00
Martin Costello a97746b72b
Remove used-once field (#23693)
Remove a field that's only used in one place, and just pass the char directly to string.Join() on use.
2020-07-06 10:32:15 -07:00
Pranav K 4b796c7bad
Quarantine components tests (#23644) 2020-07-06 10:30:10 -07:00
Brennan f6bc908a32
Write default values by default in Json (#23542) 2020-07-06 10:08:55 -07:00
Stephen Halter a57a80fcfb
Fix ContentLengthReadAsyncSingleBytesAtATime (#23641) 2020-07-06 09:48:07 -07:00
Martin Costello afbf3fdf6a
Remove unused code (#23691)
Remove an unused private method and an unused local variable.
2020-07-06 08:51:25 -07:00
Pranav K 80de1e7588
Quarantine test (#23636) 2020-07-06 15:49:33 +00:00
Javier Calvarro Nelson 9d3bf572b3
[HTTPS] Adds PEM support for Kestrel (#23584)
* Adds support for loading PEM certificates and keys in Kestrel.
* You can load PEM Certificate + PKCS8 encoded PEM Keys.
* Certificates in DER format + PKCS8 encoded PEM Keys.
* Supported key types are:
  * RSA
  * ECSA
  * DSA
2020-07-06 06:48:46 -07:00
Pranav K de034feb98
Merge branch 'master' into merge/release/5.0-preview7-to-master 2020-07-05 20:54:56 -07:00
Martin Costello 4b3fcaf769
Use new string.Split() overloads (#23683) 2020-07-05 13:16:15 -07:00
Martin Costello 3d5c8ed114
Use Array.Empty in WebEncoders (#23677) 2020-07-05 13:11:36 -07:00
Chris Ross df5269fea2
React to regression in Http.Sys (#23590)
* React to regression in Http.Sys #23164

* Add granular version check
2020-07-04 17:12:19 +00:00