Commit Graph

40898 Commits

Author SHA1 Message Date
Stephen Halter 4f0480a4d0 Gracefully handle exceptions thrown from OnStarting callbacks
- If OnStarting is being called after the app func has completed, return a 500.
- If Onstarting is being called due to a call to write, throw from write.
2015-08-14 12:05:43 -07:00
Stephen Halter 6a01043e1a Fix ListenerSecondary so it reliably accepts new connections on Windows
Calling uv_read_start on a named pipe with a larger than necessary buffer
would cause pieces of the next uv_ipc_frame_uv_stream struct to be read into
the uv_read_start buffer when a lot of tcp handles were passed quickly over
the pipe.

This prevented the struct from properly being queued for the next call to
uv_accept to consume. The empty queue caused the call to uv_accept in
ListenerSecondary to fail and return WSAEWOULDBLOCK leaving the connection
in a zombie state.
2015-08-14 11:57:21 -07:00
Stephen Halter c0cc511b5b Prevent access to closed socket in in Connection.End 2015-08-14 11:49:45 -07:00
Stephen Halter b162202519 Properly close keep alive connections 2015-08-14 11:49:43 -07:00
Ajay Bhargav Baaskaran 156f859edc Removed constructors from TagHelperAttributeDesignTimeDescriptor,
TagHelperDesignTimeDescriptor and TagHelperDirectiveDescriptor
2015-08-14 11:42:51 -07:00
sornaks e0c5e6c2fb Reacting to Mvc TagBuilder changes. 2015-08-14 11:08:12 -07:00
Kirthi Krishnamraju b271887d9f fix build break due to aspnet/configuration #246 2015-08-14 10:59:21 -07:00
sornaks f2540f9ba1 Making TagBuilder implement IHtmlContent and removing ToHtmlContent.
- Making TagRenderMode a property in TagBuilder.
- Modifying places where TagBuilder is used to suit the new model.
- This reduces space occupied by a normal application by 11.8%.
2015-08-14 10:58:51 -07:00
Kirthi Krishnamraju d487a709e5 fix build break due to aspnet/configuration #246 2015-08-14 10:04:49 -07:00
Pranav K 93d07147b2 ViewViewComponentResult doesn't handle `~/` in view paths correctly
Fixes #2856
2015-08-14 09:53:36 -07:00
Chris R 43ebf710ab Fix regression in reading config 2015-08-14 09:33:02 -07:00
Kirthi Krishnamraju a669ae18b7 fix build break due to aspnet/configuration #246 2015-08-14 00:07:35 -07:00
Kirthi Krishnamraju 18c3ad25fb fix build break due to aspnet/configuration #246 2015-08-13 23:19:56 -07:00
Kirthi Krishnamraju 87e1acf034 fix build break due to aspnet/Configuration #246 2015-08-13 22:59:09 -07:00
Kirthi Krishnamraju c7535f127c fix build break due to aspnet\configuration #246 2015-08-13 22:42:48 -07:00
Kirthi Krishnamraju b67ca0a277 fix build break due to aspnet\Configuration #246 2015-08-13 22:22:45 -07:00
Hao Kung 62a1d49710 Move generics off of Validator/TokenProvider interfaces 2015-08-13 18:49:04 -07:00
Ajay Bhargav Baaskaran 4295a57504 [Fixes #2817] Support client side validation for all numeric types 2015-08-13 17:32:13 -07:00
Ryan Nowak 7aa5967cd4 Fix #2859 - Correct UrlHelper for special tokens
This change restores a link generation behavior from MVC5 and earlier
where 'action' and 'controller' values are special cased-when using
Url.Action(...).

The change is that in-effect 'action' and 'controller' are always included
in the route values given to the routing system. Passing a null value into
the Url.Action(...) method means that the ambient value for that token
should be used explicitly. This means that the 'action' and 'controller'
tokens become sticky, even when something to the lexical left in the URL
(like area) changes.
2015-08-13 17:04:21 -07:00
N. Taylor Mullen 21d96eb16a Enabled `LinkTagHelper` to be written in the void format.
- Updated existing tests to showcase it can be written as just the start tag.
2015-08-13 16:19:30 -07:00
N. Taylor Mullen e1572f98ce Added `InputTagHelper` `TagRenderingMode` modificaitons to react to `output.TagMode`. 2015-08-13 16:19:29 -07:00
N. Taylor Mullen 1b51f6bca6 Enable input, image and url resolution `TagHelper`s to be written as void elements.
- Razor rendering now understands `TagMode` which allows void elements to be rendered.
- Added a `TagStructure.WithoutEnd` bit to `InputTagHelper`, `ImageTagHelper` and `UrlResolutionTagHelper`. This will allow users to write the various elements in the void format. Used the HTML5 spec to determine the elements appropriate.
- Added tests to ensure `TagMode.StartTagOnly` is rendered properly.
- Updated a few functional tests to showcase the void element formats.

aspnet/Razor#450
2015-08-13 16:19:28 -07:00
N. Taylor Mullen e9292a0e30 Add ability to write start tag only `TagHelper` elements.
- To write a start tag only `TagHelper` you can now utilize the `TagStructure` property on the `TargetElement` attribute. If none is specified it'll be treated as unspecified and default to old behavior of being start/end tag or self-closing.
- Added `TagMode` to showcase what the user initially wrote in their Razor document. This way `TagHelper`s can flow end-to-end in thesame format as they were written with.
- Updated code generation to specify `TagMode` instead of the boolean self-closing.
- Updated existing tests to move from `SelfClosing` => `TagMode`.
- Added `TagStructure` related tests to the set of tests that we currently have for `TagHelperBlockRewriter` and `TagHelperParseTreeRewriter`.

#450
2015-08-13 16:18:06 -07:00
Ryan Nowak 89a8d0e36c Remove IScopedInstance - use AsyncLocal for ActionContext and
ActionBindingContext

This change replaces IScopedInstance<T> in favor or IActionContextAccessor
and IActionBindingContextAccessor. In the spirit of IHttpContextAccessor,
these are both singletons which use AsyncLocal for storage.

This change allows the invoker factory to be cached which results in some
significant perf gains.
2015-08-13 15:58:29 -07:00
Ajay Bhargav Baaskaran ecfbdf2ae1 React to aspnet/Razor#428 2015-08-13 15:48:16 -07:00
Ryan Nowak a6ce9abab1 Fix #2776 - Add implicit [BindRequired] for value type properties 2015-08-13 15:35:54 -07:00
Ajay Bhargav Baaskaran 71c4c8dac6 [Fixes #428] Removed newlines at the end of razor comments 2015-08-13 15:06:09 -07:00
Chris R 3d06f3dfc2 Add ServerTests repo to build list. Fix build list ordering. 2015-08-13 14:28:31 -07:00
Kiran Challa f2a0ea6a21 React to HttpContextAccessor change 2015-08-13 11:34:38 -07:00
Pranav K 3558c1d979 Reacting to Logging changes 2015-08-13 11:22:28 -07:00
Pranav K 9a5ebf1497 Use NonDisposableStream instead of using MemoryStream.ToArray() 2015-08-13 11:16:21 -07:00
Alxandr 39ab9badde Make sure references are readable multiple times 2015-08-13 11:16:20 -07:00
Pranav K c631d533c4 * Refactoring RazorFileInfoCollectionGenerator to not be instantiated.
* Adding CompilerGeneratedAttribute to generated code.
* Adding unit tests for RazorFileInfoCollectionGenerator.
2015-08-13 11:15:46 -07:00
Chris R c91cc89ee3 ResponseBuffering middleware initial checkin.
Restrict buffer to reset. Add sample. Cleanup.
2015-08-13 10:04:42 -07:00
Kiran Challa 34ae48f242 Enable pinning build script 2015-08-13 10:03:39 -07:00
Chris R fc7224a639 #54 React to CoreCLR Cryptography package changes. 2015-08-13 09:50:17 -07:00
Kiran Challa 80bc61cbea Reacting to disposable logger provider 2015-08-13 08:48:40 -07:00
Kiran Challa 289182b872 Reacting to disposable logger provider 2015-08-13 08:47:53 -07:00
anurse f26b20b7ee fix NuGet.Config 2015-08-12 19:45:31 -07:00
anurse c9f53cd924 react to HttpContextAccessor move 2015-08-12 19:44:36 -07:00
anurse 1723ef0e97 react to IHttpContextAccessor move 2015-08-12 19:07:24 -07:00
Kiran Challa 97e66878a7 Reacting to disposable logger provider 2015-08-12 16:07:16 -07:00
Stephen Halter 097fb35ddf Fix startup when you reference the assembly directly instead of Hosting
- I missed this change in Program.cs when doing the initial package merging
2015-08-12 15:14:01 -07:00
Andrew Stanton-Nurse 3c322b4a06 react to DNX renames 2015-08-12 15:12:36 -07:00
Hao Kung a3f0ee3330 Add a shared dataprotection test for cookies 2015-08-12 14:10:42 -07:00
Hao Kung ad6e4b838a Goodbye HttpContextAccessor 2015-08-12 13:13:27 -07:00
Kiran Challa 9275250f6e Fix build break 2015-08-12 13:10:09 -07:00
Hao Kung 8487e42a68 Hello HttpContextAccessor 2015-08-12 13:08:58 -07:00
Stephen Halter 599217e7f8 React to Kestrel rename
aspnet/KestrelHttpServer#11
2015-08-12 12:26:48 -07:00
Stephen Halter e48cf0a91b React to Kestrel rename
aspnet/KestrelHttpServer#11
2015-08-12 12:22:11 -07:00