Pranav K
c27b07ef3f
Use C# 7 features
2017-06-11 22:11:51 -07:00
Pranav K
1c4b0fcdf3
Code clean up
2017-06-09 22:38:46 -07:00
Pranav K
b1b7252ddc
Merge pull request #6383 from aspnet/rel/2.0.0-preview2
...
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 15:11:23 -07:00
Pranav K
d92d8cddeb
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 14:40:29 -07:00
Pranav K
a5f3a6425e
Remove TaskCache and TaskCacheOfT
2017-06-08 08:19:20 -07:00
Jass Bagga
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
Kiran Challa
f1dd475eae
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 09:35:33 -07:00
Kiran Challa
af91b58bd3
Enabled a way to buffer request body in formatters
2017-06-06 09:33:32 -07:00
Ryan Nowak
b796bc0f39
Add Page filters
2017-06-05 08:05:49 -07:00
Kiran Challa
03e696a05e
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-01 15:19:13 -07:00
Jass Bagga
4e91e4e36f
Correct short-circuit log message for result filters ( #6350 )
...
Addresses #6318
2017-06-01 14:01:08 -07:00
Kiran Challa
0f0cfdfe94
Removed unnecessary package references
2017-06-01 12:02:05 -07:00
Jass Bagga
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
Pranav K
3089bf74fe
Remove reference to Microsoft.Extensions.PlatformAbstractions
2017-05-27 17:22:05 -07:00
Ryan Nowak
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
Ryan Nowak
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
Hao Kung
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
Ryan Brandenburg
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
Ryan Brandenburg
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
Ryan Nowak
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
Chris R
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
Pranav K
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
Jass Bagga
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
Mardoxx
ece5e748ad
Minor documentation fix for SerializableError
...
ModelStateEntry -> ModelStateDictionary
2017-05-18 11:02:23 -07:00
Ryan Nowak
4d905a4110
Make our executor methods virtual
...
Fixes #5874 - we are marking these methods virtual just in case someone
wants to customize the executors. These are in the 'public internal'
namespace but can't really be replaced because they aren't sufficiently
virtual.
2017-05-16 08:43:45 -07:00
Henrik W. Moe
af7303cd8d
Corrected xml-comment for the User-property
...
Removed comment about setting the User. `User` property only supports `get`.
2017-05-16 08:01:38 -07:00
Jass Bagga
cd6befdef1
Assign unique event Ids in the logger ( #6270 )
...
Addresses #6062
2017-05-15 11:52:52 -07:00
Pranav K
42a4e9a143
Make uses of ObjectMethodExecutor internal
2017-05-10 21:17:51 -07:00
Pavel Krymets
cf64b335f6
Remove unnecessary package references ( #6252 )
2017-05-10 12:06:10 -07:00
Pranav K
7d28714d9a
Pin build of ObjectMethodExecutor to allow breaking change to go thru first
2017-05-10 10:15:14 -07:00
Steve Sanderson
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
Ryan Nowak
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
Pranav K
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
Pranav K
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
Steve Sanderson
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
Ryan Brandenburg
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
Smit Patel
bd39d36d75
Update API Check related files
...
React to aspnet/BuildTools#238
2017-04-25 08:19:00 -07:00
Pranav K
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
Ryan Nowak
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
Doug Bunting
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
Pranav K
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
Ajay Bhargav Baaskaran
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
Christopher Dresel
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
Hao Kung
ea3becb3ca
Reenable APICheck
2017-04-20 13:48:26 -07:00
Andrew Stanton-Nurse
a975d7fa01
react to removal of PlatformAbstractions ( #6164 )
2017-04-20 11:09:18 -07:00
Ryan Nowak
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
Hao Kung
6cd487e15f
Disable api check temporarily to unblock build
2017-04-19 16:07:23 -07:00
Ryan Brandenburg
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
Hao Kung
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
Pranav K
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
Pranav K
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
Jass Bagga
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
Steve Sanderson
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
Pranav K
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
Pranav K
10d2d7c9f6
Remove System.Reflection.TypeExtensions added to workaround test failures
...
Fixes #6005
2017-04-03 14:47:14 -07:00
Steve Sanderson
d19150ed22
Fix comment typos in preceding commit
2017-03-31 10:36:53 +01:00
Steve Sanderson
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
Ryan Brandenburg
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
Doug Bunting
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
Pranav K
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
David Fowler
d2430f0f4e
Merge pull request #6004 from CoskunSunali/dev
...
Avoid entry point assembly being loaded twice during assembly parts discovery
2017-03-22 22:07:28 -07:00
Pranav K
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
Pranav K
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
Coskun Sunali
11d265bddd
Avoid entry point assembly being loaded twice during assembly parts discovery.
...
Addresses https://github.com/aspnet/Mvc/issues/6003
2017-03-22 04:37:06 +03:00
Ryan Nowak
8f4ca32f48
Fix #5807 - Race condition in Invoker
...
This change addressed a race condition in the ObjectMethodExecutor where
the default argument values array can become visible before it is
initialized. If a second observer accesses the array while it is being
initialized, it can observe a null value for a reference type parameter,
leading to a nullref.
The fix here is to make everything immutable and initialize it all up
front. There's no reason to create an OME without eventually running it,
so there's no downside to doing the initialization up front.
2017-03-15 17:19:29 -07:00
Nate McMaster
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
Pranav K
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
jacalvar
3cd8c8c14d
[ Fixes #5932 ] Add constructor taking the BinderType to ModelBinderAttribute
2017-03-09 08:16:00 -08:00
Steve Gordon
b6a6b50776
Fixing up an error in the XML Comments ( #5888 )
2017-03-06 11:07:16 -08:00
Ryan Brandenburg
de1d0919e5
Add Http Response Codes to doc comments ( #5867 )
2017-03-06 10:00:07 -08:00
N. Taylor Mullen
acfad83aa6
Migrate to MSBuild
...
- thanx to @NTaylorMullen for initial conversion
- e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files
Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
- see 63507c8 for previous, project.json work
- apply dependency version downgrade from 0097e40 in *.csproj world
Make other test-related changes:
- make Microsoft.AspNetCore.Mvc.TestDiagnosticListener a regular class library
- add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests
- separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test
- work around inability to deserialize a odd `ref` type
- xUnit and vstest now serialize / deserialze test data more often
- skip poor test mentioned in #5768
- work around Microsoft/vstest#392
- rename tests to avoid duplicates
- work around Microsoft/vstest#419
- set up created `AppDomain`s with current `ApplicationBase`
2017-02-28 21:20:39 -08:00
Stefan Nikolei
0e914e55fa
Remove double null check ( #5862 )
...
Address #5834
2017-02-28 12:00:23 -08:00
Jass Bagga
927e75870d
Add BindingSourceMetadataProvider
...
Addresses #5673
2017-02-17 13:22:10 -08:00
Ryan Brandenburg
366dbde378
Add culture constructor to RouteValueProvider
2017-02-16 14:47:34 -08:00
Ryan Brandenburg
239e2202e1
ActionContextAccessor netstandard behave like net451 ( #5810 )
2017-02-16 14:34:13 -08:00
Nate McMaster
0097e40e46
Downgrade to stable packages
2017-02-15 14:23:48 -08:00
Kiran Challa
a00acceaa9
Merge branch 'rel/1.1.2' into dev
2017-02-15 12:43:37 -08:00
Kiran Challa
29647fda33
[ Fixes #5801 ] Move call to validate constructor in ComplexTypeModelBinder into CreateModel
2017-02-15 12:33:01 -08:00
Ryan Nowak
af5648c1f7
Merge branch 'rel/1.1.2' into dev
2017-02-13 08:34:18 -08:00
Ryan Nowak
531c11df2a
Fix 5594 - ExceptionHandled + Result is broken
...
This change ensures that setting ExceptionContext.Result will always
execute if set. The problem with 1.1.0 is that when we had a real short
circuit the wrong set of conditions were checked. I suspect that when you
set ExceptionFilter.Result and didn't short circuit that result filters
were also running (which is a bug).
Added a few tests that verify that the result doesn't trigger result
filters.
I did some general cleanup on this code path to make the state transitions
more clear.
No exception was thrown -> BeginResult
Exception was handled -> ExceptionHandled
Exception was not handled -> gets rethrown
2017-02-13 07:58:32 -08:00
Doug Bunting
fc40985412
Merge branch 'rel/1.1.2' into dev
2017-02-10 14:55:32 -08:00
Kiran Challa
842d661ac2
[ Fixes #5698 ] Regression in 1.1 model binding for model types without default constructor
...
- Also reverts "Check for default constructor in ComplexTypeModelBinderProvider" commit d09e921c4a .
2017-02-10 11:10:02 -08:00
Pranav K
9f3dfd9819
Make RazorPages work E2E
2017-02-06 19:05:31 -08:00
Kiran Challa
c95c2a5a6d
[ Fixes #5686 ] Extend `ModelMetadata` to reduce ugliness
2017-02-03 11:37:28 -08:00
Ryan Nowak
cf70ed663b
Merge tag 'rel/1.1.1' into dev
2017-02-03 10:31:17 -08:00
Joonas Westlin
d44c9aee1e
Added printing of route values when a route is not matched
2017-01-27 11:31:05 -08:00
Kiran Challa
42ae78a360
[ Fixes #5012 ] ProducesAttribute should not inherit from ResultFilterAttribute
2017-01-25 14:00:35 -08:00
Kiran Challa
8ac6b6699f
[ Fixes #4945 ] Simple string returned by controller action is not a valid JSON!
2017-01-25 13:29:18 -08:00
Ryan Nowak
5885feb7c0
Fixes a parsing bug with the AcceptHeaderParser
...
When we find an invalid character at the end of a media type value we
should advance and skip over it.
2017-01-23 13:12:40 -08:00
Ryan Brandenburg
6396e14504
Add null-check back to MediaType
2017-01-18 16:56:08 -08:00
Doug Bunting
ce53675b87
Add `[ValidateNever]` and `IPropertyValidationFilter`
...
- #5642
- lazy-load `ValidationEntry.Model`
- avoids `Exception`s when moving to a property that will not be validated
nits:
- remove duplicate code in `ValidationVisitor`
- clarify "all properties of" doc comments
- also add missing `<param>` doc in `ViewDataInfo`
2017-01-15 21:40:29 -08:00
Ryan Brandenburg
93774a0234
Mitigate MediaType overflow
2017-01-13 12:51:19 -08:00
Pranav K
13b32adeae
Move InvokeAsync to ResourceInvoker
2017-01-11 11:13:05 -08:00
Pranav K
6b0282fa84
Commonize code from ControllerActionInvokerCache and PageFilterFactoryProvider
2017-01-11 10:53:23 -08:00
Jass Bagga
473337ea33
CompositeChangeToken moved to aspnet/Common Microsoft.Extensions.Primitives
...
Addresses Common Issue aspnet/Common#163
2017-01-04 17:32:20 -08:00
Kiran Challa
de0f277892
Fix attribute routing error message related to replace tokens
2017-01-04 15:43:57 -08:00
hiiru
5070526f43
replaced hardcoded message with Resources.ArgumentCannotBeNullOrEmpty
2017-01-04 10:47:21 -08:00
Pranav K
78492b39d8
Introduce a base type for executing auth and resource filters.
2017-01-03 11:14:15 -08:00
Jass Bagga
9146fce4ec
Add extension method for IParameterModelConvention. ( #5640 )
2016-12-27 16:49:12 -08:00
Pranav K
2b50ec99df
Updating to 4.4 CoreFx packages
2016-12-21 16:47:14 -08:00