Commit Graph

7866 Commits

Author SHA1 Message Date
Pranav K a74235c7ec Reflect Access-Control-Request-Headers and Access-Control-Request-Method when policy is configured to support wildcard
Fixes https://github.com/aspnet/AspNetCore/issues/3684
2018-10-26 11:11:33 -07:00
Stephen Halter 395b681348
Add HTTP/2 request body data rate limit (#3051) 2018-10-26 10:46:46 -07:00
Pavel Krymets 99f2ecd02f
Move transformation tests from AzureIntegration (#3726) 2018-10-26 09:49:19 -07:00
Ryan Brandenburg 958e0b1d9f Get rid of Page1 Page2 2018-10-25 15:12:31 -07:00
Nate McMaster ae122d9bc0
Include rid-specific runtime packages in the list of artifacts 2018-10-25 14:42:00 -07:00
Nate McMaster 77a3089c8d
Workaround quirks in NuGet
* Disable package analysis because it incorrectly issues NU5109 on macOS, but not windows
* Normalize file paths because if you mix slashes, NuGet will just skip the entire folder
* Normalize the project path given to restore. If it not normalized, restore skips the project and issues a warning
2018-10-25 14:27:46 -07:00
Ryan Brandenburg b05185f1f1
ESLint (#796)
Include ESLint in react templates
2018-10-25 12:27:39 -07:00
Ryan Brandenburg 9b3d1f56fd
Handle peer dependency warnings (#794)
Handle peer dependency warnings
2018-10-25 12:00:49 -07:00
Nate McMaster 8c20892290
2.2: Remove BrowserLink from templates (#801)
This removes support for the `--use-browserlink` flag from the templates. The Microsoft.VisualStudio.Web.BrowserLink package will still ship in 2.2, but users who want this should use `dotnet add package Microsoft.VisualStudio.Web.BrowserLink` instead.
2018-10-25 10:49:44 -07:00
Pavel Krymets 044f613804
Include failed HRESULTs and exceptions in FREB log (#1548) 2018-10-25 08:48:21 -07:00
Justin Kotalik de185b6a06
Duplicate debug log handle for console logging (#1558) 2018-10-25 08:47:31 -07:00
Nate McMaster 11d0b328ba
Remove VS.Web.CodeGeneration packages from the fallback folder cache (#3717) 2018-10-24 21:05:44 -07:00
Nate McMaster 7bde7399e9
2.2: remove Microsoft.VisualStudio.Web.CodeGeneration.Design from templates (#802)
This package does not need to be in the project until someone uses Visual Studio code generation. Visual Studio will automatically add this package when scaffolding is used for the first time, so it's unnecessary to put this in our templates.
2018-10-24 17:42:02 -07:00
Nate McMaster 968df9578b
Refactor shared framework projects targets and project layout (#3703)
This refactors the targets used to build the shared framework and its .zip files. There are lots of reasons motivating this: Arcade convergence, migration to VSTS, making it easier to build this locally, etc.

Changes:
* Moves move content of build/Sharedfx.{props/targets} into eng/targets/SharedFx.Common.{props/targets}
* Update the build to produce a `runtime.$rid.Microsoft.AspNetCore.App` package (not just the one with symbols in it)
* Refactor the targets which produce .tar.gz/.zip files into separate projects in `src/Installers/`
* Refactor installers, unit tests, and the framework projects to use ProjectReference to flow dependencies between different parts of the build.
* Makes it easier to build the shared framework locally (for the inner dev loop, you can run `dotnet build -p src/Framework/Microsoft.AspNetCore.App/src/ -r win-x64`)
2018-10-24 15:42:06 -07:00
Hao Kung 91db78cf92
Add safe copy for enumeration (#1052) 2018-10-24 15:10:19 -07:00
Nate McMaster 01f9af21c5
Temporarily stop producing a package for dotnet-httprepl (#505)
This package isn't quite ship-shape yet, so we're delaying this from shipping with 2.2 RTM.

Setting IsPackable=false so we avoid accidentally building a 2.2.0 RTM version of this package along with the rest of the 2.2.0 RTM tools in this repo, like dotnet-watch.
2018-10-24 13:02:25 -07:00
Javier Calvarro Nelson aa88f16b08
Fix cors with creds (#193) 2018-10-24 12:56:07 -07:00
Justin Kotalik 70a786adcd
Make AspNetCoreHostingModel element not be insert when targeting net461 and inprocess => InProcess (#797) 2018-10-24 11:36:07 -07:00
Chris Ross (ASP.NET) a8073167e7 Revert "Flush response headers #3031"
This reverts commit 277a5502fd.
2018-10-23 15:49:11 -07:00
Chris Ross a5fcd9dd87
Add application/wasm #3681 (#259) 2018-10-23 14:43:47 -07:00
Gert Driesen 25b5ab2c39 Improve performance and reduce allocations in RouteValuesAddressScheme. (#879) 2018-10-23 13:25:43 +13:00
Gert Driesen bc482cd2b0 Minor performance improvement for DfaMatcherBuilder (#854) 2018-10-23 13:25:08 +13:00
Chris Ross (ASP.NET) 32532078d6 Log binary data as a parameter #2860 2018-10-22 14:51:29 -07:00
Gert Driesen bcbf2a1a68 Minor performance improvement for UriBuildingContext.ToPathString() with zero-length path. (#880) 2018-10-23 10:20:52 +13:00
Gert Driesen c93e3a76ff Eliminate redundant isValid check from DefaultEndpointSelector.ProcessFinalCandidates(...). (#881) 2018-10-23 10:20:30 +13:00
Gert Driesen 26e5ea3274 Improves performance and reduce allocations in DefaultEndpointDataSource (#882) 2018-10-23 10:20:15 +13:00
Ryan Nowak 4943bc4896 Remove LinkGenerationTemplate
This doesn't really accomplish our goals for 2.2 - I don't have a clear
scenario where I would tell a developer to use this VS something else.
Will reevaluate in 3.0
2018-10-22 14:18:22 -07:00
Ryan Brandenburg 707b1bbf3b Fix link 2018-10-22 12:48:30 -07:00
Justin Kotalik ffa72f5a0c
Fix two string allocation issues (#1539) 2018-10-22 11:23:14 -07:00
James Newton-King 1d05592cd7
Allow parameter names to match required keys in templates (#872) 2018-10-22 11:29:41 +13:00
Gert Driesen 2081160678 Improve performance and reduce allocations of TemplateSegment (#856) 2018-10-22 08:35:35 +13:00
Gert Driesen 0f90a15cf1 Use Array.Clone() to copy arrays, and avoid copy where applicable (#855) 2018-10-22 08:34:11 +13:00
Gert Driesen 42914d93ca Declare out variables inline, and use discards (#873) 2018-10-21 14:05:05 +13:00
Chris Ross (ASP.NET) 277a5502fd Flush response headers #3031 2018-10-19 18:00:24 -07:00
Pavel Krymets f1ce94a2cf
Add support for building 2.1 based Server.IIS package (#1534) 2018-10-19 12:42:16 -07:00
Pavel Krymets d3216a66c1
Create a build configuraition to build OOB logging site extension package (#3643) 2018-10-19 12:19:33 -07:00
Chris Ross (ASP.NET) 23a4e11261 Send RST for canceled HTTP/2 writes #3007 2018-10-19 11:03:44 -07:00
Nate McMaster 36add43f11
Merge branch release/2.1 into release/2.2 2018-10-18 16:53:03 -07:00
Justin Kotalik b92c82e97f
Add static shim test (#1505) 2018-10-18 13:58:56 -07:00
dotnet-maestro-bot 31849575f1 Upgrade to .NET Core 2.1.6-servicing-27017-02 2018-10-18 13:48:06 -07:00
Pavel Krymets 293d165a80
Fix flaky disconnect test (#1533) 2018-10-18 12:37:13 -07:00
Chris Ross (ASP.NET) d3f2ca9c9a Do not inherit socket handles #2789 2018-10-18 12:19:58 -07:00
Justin Kotalik 6dc4673881
Revert restarting was when installing ANCM (#3662) 2018-10-17 22:44:41 -07:00
Chris Ross (ASP.NET) 1d3090f056 Only reset the request body pipe for HTTP/1 #3006 2018-10-17 16:28:33 -07:00
James Newton-King e51da32e9d
Prefer StringComparison over StringComparer when not using comparers (#870) 2018-10-18 11:55:33 +13:00
Nate McMaster d991c50c82
Merge release/2.1 and aspnet/WebSockets release/2.2 2018-10-17 15:47:04 -07:00
Nate McMaster 24f85a200c
Reorganize source code in preparation to move into aspnet/AspNetCore
Prior to reorganization, this source code was found in a036f920b8
2018-10-17 15:34:25 -07:00
Nate McMaster b1427c759b
Remove the WebSockets submodule 2018-10-17 14:53:22 -07:00
Nate McMaster 9e952a22ed
Merge source code from aspnet/WebSockets 2018-10-17 14:30:38 -07:00
Nate McMaster 5d84c92b74
Reorganize source code in preparation to move into aspnet/AspNetCore
Prior to reorganiziation, this source code was found in 67f2c3149e
2018-10-17 14:27:00 -07:00
Gert Driesen 5c31f1f455 Add Remove(string key, out object value) overload to RouteValueDictionary (#858)
* Add Remove(string key, out object value) overload to RouteValueDictionary.

* Consistently use _count field instead of Count property in Remove overloads.
Added comment on EnsureCapacity call.
Added test for removing first/middle/last entry.
2018-10-17 13:24:07 -07:00
Nate McMaster 80d3bbfcc9
Update code signing config to exclude .js files in template packages 2018-10-17 11:13:02 -07:00
John Luo 97acb95715 Set default protocol to HTTP/1.x 2018-10-17 11:11:02 -07:00
itminus a43587290f fix : DefaultFilesMiddleware serve with unicode path (#257) 2018-10-17 08:07:37 -07:00
Justin Kotalik b951ac9b64
Fix path to aspnetcoreca.dll for signed output (#1513) 2018-10-16 15:55:15 -07:00
Pavel Krymets 8f99140f30
Add client disconnect logs (#1521) 2018-10-16 15:30:19 -07:00
Nate McMaster e75dc56327
Sign Newtonsoft.Json with AssemblySigning3rdPartyCertName 2018-10-16 14:29:10 -07:00
Nate McMaster 6366deb193
Update dataprotection to 2.2.0-rtm 2018-10-16 11:33:17 -07:00
Nate McMaster b64e64d9e5
Merge branch 'namc/merge-dp-22' into release/2.2 2018-10-16 11:32:28 -07:00
Justin Kotalik 92baa4a75b
Cleanup ANCM installers/ Sign AspNetCore custom action (#1499) (#1502) 2018-10-15 17:46:36 -07:00
Ryan Brandenburg 73f161cc60 Set crossorigin anonymous for integrity 2018-10-15 15:51:46 -07:00
Pavel Krymets 24e2e5ad52
Port startup tests to IIS (#1513) 2018-10-15 11:44:51 -07:00
Nate McMaster 6a14b47ccd
Add infrastructure changes to src/DataProtection can build on its own 2018-10-15 11:17:06 -07:00
Ryan Brandenburg bd375fc9ee Fix audit failure 2018-10-15 10:49:40 -07:00
Pavel Krymets b0deed05be
Add server abort tests (#1510) 2018-10-15 10:33:14 -07:00
Nate McMaster 489a88d21e
Merge aspnet/DataProtection release/2.2 into this repo 2018-10-15 10:21:02 -07:00
Nate McMaster a673bfd741
Add build script and CI config for the DataProtection folder 2018-10-15 10:13:04 -07:00
Nate McMaster 4dfd351c84
Remove DataProtection submodule and update path to DP source code to local folder 2018-10-15 09:46:20 -07:00
Nate McMaster c355f10074
Merge source code from aspnet/DataProtection 2018-10-15 09:40:44 -07:00
Pavel Krymets 0b5973e501
Enable auth tests on IIS (#1511)
* Enable auth tests on IIS

* FB
2018-10-13 10:54:20 -07:00
Nate McMaster c37a332a6a
Merge branch 'release/2.1' into release/2.2 2018-10-12 16:56:47 -07:00
Justin Kotalik dbc1d38a58
Move ANCM installers to Universe (#1456) 2018-10-12 14:32:12 -07:00
Nate McMaster fb3f5d95c2
Backport infrastructure changes and source reorganization
* Add build definition for Azure DevOps
* Put code for metapackages in a subfolder
* Update targets to prepare for submodules merging into this repo
* Add source code for windows installer
* Add source code for Debian installers
2018-10-12 13:59:43 -07:00
Stephen Halter 1f2e704dd3
Implement MinResponseDataRate for HTTP/2 (#3003)
#2807
2018-10-12 13:15:46 -07:00
Nate McMaster f4026cc100
Reorganize source code from aspnet/DataProtection into a subfolder
Prior to reorg, this source existed at 3f5f419df8
2018-10-12 13:14:22 -07:00
Peter Blazejewicz 98162cb7df Remove `launchsettings.json` entry from `.gitignore`. Closes #760 (#761)
Do not ignore launchsettings.json. Closes #760

As discussed in:
https://github.com/github/gitignore/pull/2705
https://github.com/github/VisualStudio/issues/1405
2018-10-12 12:58:50 -07:00
Pavel Krymets 642e8e9d7c
Add Basic auth tests and fix Windows auth tests (#1502) 2018-10-12 12:03:11 -07:00
Nate McMaster 4f14cda425
Reorganize source code from aspnet/DataProtection into a subfolder
Prior to reorg, this source existed at b62bb5778b
2018-10-12 10:07:51 -07:00
James Newton-King fbf0708f19
Fix DfaGraphWriter ISuppressMatchingMetadata check (#850) 2018-10-12 16:08:50 +13:00
Pranav K e6bdf128f2 Log when a request is an OPTIONS request but not a preflight request
Fixes https://github.com/aspnet/AspNetCore/issues/2375
2018-10-11 16:30:22 -07:00
Chris Ross (ASP.NET) 081cef0934 Track aborted streams for a given grace period #2832 2018-10-11 12:55:26 -07:00
Ryan Brandenburg df394051d0 JQuery Unobtrusive to 3.2.11 2018-10-11 12:29:32 -07:00
Pranav K 2690a3f621 Remove filtering from CorsService
* Add browser based integration tests
2018-10-11 12:23:40 -07:00
Pavel Krymets 1132cad70b
public const string AuthenticationScheme (#1496) 2018-10-11 10:54:00 -07:00
Justin Kotalik 0e04527fb4
General cleanup for client disconnect handling. (#1446) 2018-10-11 08:44:03 -07:00
Ben Adams 800c79c0e4 Fast-path async in HttpResponseStreamWriter 2018-10-10 18:13:58 -07:00
Günther Foidl 773aa6e6ff Http{Request|Response}Stream.ValidateState made inlineable 2018-10-10 17:45:05 -07:00
BrennanConroy 3f5f419df8
Add Redis 2.0 package (#325) 2018-10-10 16:40:52 -07:00
Pavel Krymets bfa583a9aa
Guard OnAsyncCompletion from completing request before OnExecuteRequestHandler exits (#1489) 2018-10-10 14:34:55 -07:00
Pavel Krymets ab124fc344
Fix applicationInitialization tests and disconnect handler (#1484) 2018-10-10 12:41:11 -07:00
Ryan Brandenburg 7d09ec6ccc
Low hanging fruit (#763)
Clean up low hanging fruit
2018-10-10 12:12:11 -07:00
James Newton-King f6e20a38e2 HostString throws ArgumentNullException for null host (#1045) 2018-10-10 08:27:33 -07:00
Pavel Krymets 7a09638afe
Modernize startup error pages (#1476) 2018-10-09 16:12:01 -07:00
Pavel Krymets f2fbd803b9
Flow request trace context to CreateApplication (#1480) 2018-10-09 16:11:52 -07:00
Pavel Krymets 27e4e1aca3
Remove RestoreOnPublish parameter (#1533) 2018-10-09 10:41:52 -07:00
Justin Kotalik 23db53eae6
Add more FREB events/ tests for FREB events (#1461) 2018-10-09 10:25:12 -07:00
Ryan Nowak 1f31e0556d
Add IHealthCheckPublisher for push-based checks (#498)
IHealthCheckPublisher allows you to configure and run health checks
regularly inside an application, and push the notifications elsewhere.

All publishers are part of a single queue with a configurable period and
timeout.
2018-10-08 17:58:45 -07:00
Stephen Halter 8bca6b3877
Add HTTP/2 keep-alive and request header timeouts (#2992) 2018-10-08 17:06:15 -07:00
Pavel Krymets 1be7cd1f74
Disconnect the disconnect handler when request processing ends (#1471) 2018-10-08 16:05:28 -07:00
Ryan Nowak 7b16053f27 Misc polishing
Rename `IEndpointFinder<>` -> `IAddressScheme<>`

Address the two 'marker' metadata types that I'm aware of.
2018-10-08 15:45:44 -07:00
Pavel Krymets 4347a45f29
Always add event source logger (#287) 2018-10-08 09:31:44 -07:00
Ryan Nowak 9722d89572 Adjust log levels 2018-10-06 16:18:55 -07:00
Ryan Nowak ce9ace84fd
Merge pull request #839 from aspnet/rynowak/fix-837
Fix Routing#837
2018-10-05 22:26:27 -07:00
Ryan Nowak 81fb93a896 Fix Routing#837
Fixes a few issues with how we initialize the middleare.
- Always completes the intitialization task
- Avoids capturing the ExecutionContext
- Allows initialization to occur repeatedly when it fails
2018-10-05 21:24:57 -07:00
Ryan Nowak 9db2833fc2 Make endpoint selector policies per-candidate-set
This allows us to filter `IEndpointSelectorPolicy` instance based on
whether the apply to a given candidate set. This should allow us to
remove some HAXXX from MVC.

The idea here is the ESP becomes much more pay-for-play if you can
statically eliminate many of the cases where it would usually no op.
2018-10-05 21:03:59 -07:00
Ryan Nowak af47b27f0d Add blurb about Host header 2018-10-05 19:03:21 -07:00
John Luo 5b90028fe3 Expose status code of BadHttpRequestException 2018-10-05 16:08:33 -07:00
Chris Ross (ASP.NET) daf6e1ecd7 Http/2 response trailers #622 2018-10-05 12:50:46 -07:00
Chris Ross (ASP.NET) 89b0430bda Add IHttpResponseTrailersFeature and extensions 2018-10-05 11:46:52 -07:00
Pranav K 6f76189846
Normalize internationalized domain names when adding to CORS
Fixes https://github.com/aspnet/Home/issues/3353
2018-10-05 11:08:02 -07:00
George Drak e9eea50966 Implement #2230 - Consume BindingAddress instead of ServerAddress (#2975)
* #2230 Mark ServerAddress as obsolete

* #2230 suppress CS0618 errors for obsoleted ServerAddress class

* #2230 Use BindingAddress instead of ServerAddress
2018-10-05 10:34:00 -07:00
Luke Latham e30ae8cc3d Fix typo (#1559) 2018-10-05 08:11:04 -07:00
Stephen Halter f91ae20a3c
Improve RequestAborted token handling (#2977)
- Improve test reliability of tests verifying the RequestAborted token gets tripped
- Once the response body is completed, don't fire the token for that request even if it is accessed later on.
2018-10-04 16:48:50 -07:00
Andrei Amialchenia df2ad98743 Use logical 'or' instead of bitwise in IsConnectionReset method. (#2983) 2018-10-04 15:37:24 -07:00
Chris Ross (ASP.NET) 35d35f22a3 Disallow any frames after a reset is received #2154 2018-10-04 09:40:21 -07:00
Stephen Halter 5bd2a41517
Make transport logs for connection close more detailed and consistent (#2978) 2018-10-03 12:41:00 -07:00
Nate McMaster f2691ee4b6
Add a copy of scripts from dotnet-deb-tool 2.0.0 to this repo (#1442)
We currently build .deb files using dotnet-deb-tool, which comes from a package feed. We're not completely sure where the source code is for this tool, so this moves the scripts from the dotnet-deb-tool 2.0.0 package into this repo for safe keeping.
2018-10-02 14:32:12 -07:00
Nate McMaster 4c49d5ce80
Resolve flaky tests (#497)
1. Prevent an ObjectDisposedException in dotnet-watch on slower machines
2. Fix flakiness caused by PID reuse
3. Fix flakiness in tests that await the restart of dotnet-watch. The `.TimeoutAfter` method doesn't cancel the long-running task. This left 2 readers running on dotnet-watch output which caused indeterminate test outcome.
2018-10-02 09:17:04 -07:00
Nate McMaster 7d3628b8ac
Merge branch 'release/2.1' into release/2.2 2018-10-01 15:58:37 -07:00
Ryan Nowak 014e7eb963 Add EFCore DbContext check 2018-10-01 13:33:00 -07:00
Justin Kotalik 3ddc86a428
Fix mof file (#1457) 2018-10-01 08:00:44 -07:00
Ryan Nowak 3227de8c0b Fix #629 - Add logging to DfaMatcther
Adds logging for the most common things that can prevent an endpoint
from matching.

Note that we already have good logging in other parts of the system, the
stuff here completes the story by providing details at the debug level.
2018-09-30 15:59:25 -07:00
Ryan Nowak b7939328b8 feedback 2018-09-30 14:09:59 -07:00
Ryan Nowak a2f404f4d5 Perf improvements for EndpointSelector 2018-09-30 14:09:59 -07:00
Ryan Nowak ed15bad5fb Make CandidateState (publicly) immutable 2018-09-30 14:09:59 -07:00
Ryan Nowak 1f5eec1d55 Rename EndpointFeature -> EndpointSelectorContext 2018-09-30 14:09:59 -07:00
Ryan Nowak 8b99832eaf Add ASCII optimized jump tables 2018-09-29 12:55:10 -07:00
James Newton-King d1f3b90a0e
RouteValuesAddressMetadata ctors and XML docs (#818) 2018-09-30 08:54:59 +13:00
Nate McMaster 72cd5eedcf
Prepare the 2.1.6 patch (#1434) 2018-09-28 17:57:33 -07:00
Nate McMaster 0eb57b2a29
automated: bulk infrastructure updates. Update bootstrapper scripts and remove unnecessary signing properties 2018-09-28 17:19:45 -07:00
Simon Cropp d4ab8b27a9 typos, inline outs, redundant usings (#2965) 2018-09-28 11:14:59 -07:00
Nate McMaster 89fccf3ac5
Enable MicroBuild code signing (#1456)
Fixup the paths to files to be signed.
2018-09-28 10:37:18 -07:00
John Luo 7cf1cf2a54 Update API check baselines to 2.1.0 2018-09-28 10:30:50 -07:00
Unai Zorrilla fa961b003f Added execution time duration (HealthReportEntry TotalDuration) (#493)
* Added execution time duration into HealthReportEntry and TotalDuration on HealthReport

* review PR feedback from @rynowak.

* added the same duration into HealthReportEntry and log when the health check throw
2018-09-28 09:14:58 -07:00
Justin Kotalik 45a52ebff5
Move Log call before starting application (#1453) 2018-09-28 08:53:32 -07:00
Simon Cropp 8dcc011324 spelling, inline outs, redundant braces (#252) 2018-09-27 20:24:42 -07:00
Stephen Halter e9c2acf4dc
Add HTTP/2 response draining timeout (#2956)
* Move drain timeout to Http1Connection
* Add TimeoutControl class
2018-09-27 17:59:12 -07:00
Justin Kotalik fc39ea3bec
Make hosting bundle get prodcon runtime versions (#1435) 2018-09-27 16:44:40 -07:00
Nate McMaster 4baa07ccae
Update code signing properties and configuration 2018-09-27 12:55:40 -07:00
James Newton-King 95753825ef
Comment registered key (#816) 2018-09-27 07:06:30 -07:00
John Luo f56b682b36 Impose integer decode limit in HPACK 2018-09-26 17:18:24 -07:00
Nate McMaster 0157e38a23
Fix the path for SignedPackageFile and include the VSIX .dll in signing 2018-09-26 15:06:06 -07:00
Pavel Krymets bac0f44fa7 Revert "Disconnect the disconnect handler when request processing ends (#1413)"
This reverts commit f808bdc331.
2018-09-26 14:17:40 -07:00
Ryan Brandenburg b07338b618
Don't use depricated methods (#751)
Don't use depricated methods
2018-09-26 12:50:24 -07:00
Ryan Brandenburg c6347f035f Conditionally include RootNamespace 2018-09-25 15:48:08 -07:00
Ryan Brandenburg 0745266c17 Razor->WebApp 2018-09-25 15:47:23 -07:00
Justin Kotalik 1eb5da31e5
Improve error messages and add static html pages for failure to start site. (#1421) 2018-09-25 15:40:15 -07:00
Chris Ross (ASP.NET) 3832019027 Update Facebook to v3.1 endpoints #92 2018-09-25 13:56:58 -07:00
Ryan Nowak 49c2317c14 Fix #810 2018-09-24 21:55:56 -07:00
Ryan Nowak 7c16c92317 Fix a bug in GetUriByRouteValues
Pride cometh before the fall...
2018-09-24 20:46:20 -07:00
Chris Ross (ASP.NET) 01b35bc391 Make HTTP/2 connection and stream windows configurable #2814 2018-09-24 15:31:50 -07:00
John Luo ceaa3c86fc Add configurability for max header field size in HPACK 2018-09-24 10:53:15 -07:00
Ryan Nowak 204ff0a785 Set cache headers in health check middleware 2018-09-24 10:43:57 -07:00
David Fowler f17142b2ec
Delay resolution until after application services are built (#1553)
- Resolve the logger from the right service provider to log duplicate hosting startup assemblies.
- Don't create a 3rd IServiceProvider if we resolved the default implementation.
2018-09-24 10:41:30 -07:00
Ryan Nowak 18145880fa Improved logging for health checks
- Add logging of description/data
- Add logging for aggregate begin/end
2018-09-24 10:29:23 -07:00
Ryan Nowak b642db5a47 Revised LinkGenerator 2018-09-22 15:47:50 -07:00
Pavel Krymets f808bdc331
Disconnect the disconnect handler when request processing ends (#1413) 2018-09-21 09:13:39 -07:00
Ryan Brandenburg a140f38810 Enhancments 2018-09-20 14:52:16 -07:00
Ryan Nowak 8fb6c2a50a Allow cancellation to propagate 2018-09-20 11:04:35 -07:00
Ryan Nowak a657c3bdf2 Updates to Parameter Transformer
- Rename -> IOutboundParameterTransformer
- Make it operate on object
- Implementing caching for constraints/tranformers for link generation
(cached as part of TemplateBinder)
2018-09-20 10:15:42 -07:00
Pavel Krymets d28468ca8f
Override IIS headers in inproc (#1409) 2018-09-20 09:21:34 -07:00
Pavel Krymets 375d037946
Add applicationInitialization tests (#1402) 2018-09-19 16:32:24 -07:00
Ryan Nowak 4259b65c16
Use options for registering health checks (#479)
* Use options for registering health checks

This change pivots to use options for registering health checks. We get
a few pretty nice things out of this, and it unblocks some of our
requirements.

Now all registration methods support the application developer
configuring the name, failure-status, and tags for each health check.
This is a requirment, that we weren't really satisfying - which is what
led to this redesign. In support of this health checks now return pass/fail,
and the service is responsible for assigning the status.

----

Health check authors that need configuration data (connection string as
an example) now have three ways to do this depending on their
requirements.
1. Create an instance and register that (easiest)
2. Use Type Activation and pass parameters (middle)
3. Use named options (richest)

We expect most health checks to need/want some kind of configuration -
which 1) works pretty well to solve. However many other health checks
will need DI + configuration. It was also a gap that we didn't have a
good way to use named options, when it's such a good fit for our
scenarios.

Added new registration methods for type activation that allow you to
pass parameters for 2).

Added a context type that allows the running health check access to its
registration for 3).

----

Redesigned and renamed how status gets reported. Health checks return
pass/fail result, but the overall HealthReport includes entries of a
different type. This seems fine because there isn't really a way to
consume a HealthCheckResult directly - the service is the only consumer.

----

Added support for tags. This was easy to add now that we have a separate
registration type, and it's quite handy for building filters (see
sample).

* HARDER BETTER STRONGER FASTER
2018-09-19 14:48:34 -07:00
Mike Harder 3f7ee338d4 Change SelfHostDeployer to use dynamic ports by default (#1383)
* Should significantly reduce flaky test failures due to AddressInUse exceptions
* Addresses https://github.com/aspnet/Hosting/issues/1296
2018-09-19 12:35:51 -07:00
Pavel Krymets b6c311c14d
Add client disconnect and connection abort support (#1388) 2018-09-18 16:36:52 -07:00
Ryan Brandenburg f63412f1bb Update package verions 2018-09-18 14:34:39 -07:00
Justin Kotalik ece5ad36e2
Implement ITlsConnectionFeature (#1390) 2018-09-18 14:22:56 -07:00
Stephen Halter f3b6430aab
Initialize Heartbeat in KestrelServer.StartAsync (#2939)
Fixes #2850 again
2018-09-17 16:43:30 -07:00
tiago-soczek a7e412ec80 Fix category logger for HttpsConnectionAdapter and LoggingConnectionAdapter. #2929 (#2935) 2018-09-17 16:01:14 -07:00
Chris Ross (ASP.NET) b8423b8530 Change how HTTP/2 frames are parsed and generated #2858 2018-09-17 14:48:43 -07:00
David Fowler 2999aa54cd
Remove calls to MemoryMarshal.GetReference (#2931)
- Spans can be pinned natively in C# 7.3
2018-09-17 14:47:04 -07:00
John Luo 69ff195f66 Enable hpack/4.2 - Maximum Table Size test
- Ensure dynamic tables size updates occur at the beginning of the header block
2018-09-17 12:46:51 -07:00
John Luo 025aca52df Port long Huffman encoding bug fix
https://github.com/dotnet/corefx/pull/32043
2018-09-17 12:41:36 -07:00
Pavel Krymets 5e896ca506
Implement IHttpBufferingFeature (#1391) 2018-09-17 12:04:12 -07:00
Justin Kotalik 2cd6ad6d50
Add windows auth tests for inproc (#1385) 2018-09-17 11:57:46 -07:00
James Newton-King 412944e1f5
Transform parameters before lower casing in link generation (#793) 2018-09-14 17:19:43 +12:00
Ryan Nowak 426a48a65a Performance improvments to LinkGenerator and TemplateBinder 2018-09-13 19:11:28 -07:00
Ryan Nowak 9a68f48a5c Minor improvments to RVD perf 2018-09-13 14:55:00 -07:00
Ryan Brandenburg b8f7f967ce Normalize FSharp templates and don't check in site.min.js 2018-09-13 14:41:32 -07:00
Pranav K d0ddb068be
Return FormCollection.Empty when Content-Length is 0 (#1038)
* Return FormCollection.Empty when Content-Length is 0

Fixes https://github.com/aspnet/Mvc/issues/5631
2018-09-13 13:35:31 -07:00
Chris Ross (ASP.NET) 55e5e56422 Dispatch Http/2 write callbacks #2878 2018-09-13 11:53:30 -07:00
Justin Kotalik 3649f5bb81
Add OutOfProc logging tests/ merge all inproc test sites into a single site (#1384) 2018-09-12 23:20:52 -07:00
James Newton-King cee960f3c5
Add IParameterTransformer (#750) 2018-09-12 21:45:25 +12:00
Ryan Nowak e5cc4564cb add docs for constructor 2018-09-10 16:55:39 -07:00
Ryan Nowak 5f172efa9d Add support Endpoint Name endpoint finding 2018-09-10 16:50:46 -07:00
Ryan Nowak 57cc8aea96 Various improvments to route values link APIs
- Add docs
- Add support for templates
- Remove undesirable constructor parameter
- misc cleanup
2018-09-10 16:50:46 -07:00
Chris Ross (ASP.NET) f38f60f8ce Map ListenOptions.Protocols from IConfiguration #2903 2018-09-10 16:27:51 -07:00
Ryan Nowak c683844817 Fix #553 - Add logging for new LinkGenerator
Adds logging for all of the failure cases of link generation.
2018-09-10 16:11:43 -07:00
John Luo de5ccb5c78 PR feedback for https://github.com/aspnet/KestrelHttpServer/pull/2838 2018-09-10 13:58:46 -07:00
Ryan Brandenburg 14b1432481 Fix min.css files 2018-09-10 12:25:27 -07:00
Glenn Condron 4bcfbe4d40
[REPL] Help improvements for repl (#478)
* Beginning of help additions. Fixed a nullref.
* Standardized help with options displayed as appropriate.
2018-09-07 15:21:42 -07:00
Nate McMaster aa93edcee2
Remove Microsoft.DotNet.GlobalTools.Sdk
These targets are now part of Microsoft.NET.Sdk
2018-09-07 10:01:52 -07:00
Nate McMaster e3ba165baa
Update build.ps1 2018-09-06 23:04:43 -07:00
Pavel Krymets 2597a2e009
Merge QueryStatus and CreateHandler calls to make them atomic (#1359) 2018-09-06 15:42:18 -07:00
Justin Kotalik 2cc108b2e1
Write wide strings to stdout; cleanup logging providers; test utf8 (#1332) 2018-09-06 11:57:00 -07:00
Simon Cropp d3d7c55198 fix some spelling (#2888) 2018-09-06 11:48:25 -07:00
Ryan Brandenburg c2f15f4199 Don't use depricated constructor 2018-09-06 11:39:34 -07:00
Justin Kotalik 1fca011674
Fix output location for lib files (#1373) 2018-09-06 10:32:49 -07:00
Pavel Krymets b1f0f173aa
Use ConnectionResetException with 'The client disconnected' message (#1364) 2018-09-06 10:10:07 -07:00
Chris Ross (ASP.NET) b8e56691cb Implement MaxRequestLineSize for HTTP/2 #2813 2018-09-06 10:01:28 -07:00
Chris Ross (ASP.NET) 384a518bda Implement MaxRequestHeadersTotalSize for HTTP/2 #2812 2018-09-06 09:07:16 -07:00
David Fowler edc1935475
Flow the cancellation tokens to ReadAsync and WriteAsync (#2865) 2018-09-06 09:04:39 -07:00
Simon Cropp cfb0d732b0 fix some spelling (#1035) 2018-09-06 08:46:34 -07:00
Ryan Nowak e3b704095b
Revisions to LinkGenerator (#770)
* Revisions to LinkGenerator

* PR feedback
2018-09-05 20:52:09 -07:00
James Newton-King dcfb63a768
Avoid RoutePattern allocating empty dictionaries (#772) 2018-09-06 14:00:52 +12:00
James Newton-King 1c74973c6a
Minor matcher builder allocation optimization (#771) 2018-09-06 13:47:34 +12:00
James Newton-King dbebdbecd6
Add flag for including label with DfaNodes (#769) 2018-09-06 13:38:17 +12:00
James Newton-King fe8c633224
Optimize builder and HTTP policy allocations (#768) 2018-09-06 13:25:35 +12:00
James Newton-King abc378d3dc
Avoid resizing large struct arrays (#767) 2018-09-06 13:10:17 +12:00
James Newton-King 0f5d471dfd
Create collections on DfaNode as needed (#779) 2018-09-06 12:58:57 +12:00
James Newton-King a777a4cdd5
Reuse collections in DfaMatcherBuilder (#778) 2018-09-06 12:25:45 +12:00
Mike Harder 71b7bb50b2
Ensure external processes are killed when test process exits (#1371)
- Prevents locked files when stop debugging unit test
- Addresses #1279
2018-09-05 17:21:59 -07:00
Pavel Krymets 88d8571474
Add Trace level for request events, allow logging to eventlog (#1337) 2018-09-05 17:15:04 -07:00
Pavel Krymets 18a718d1f0
Catch all exception in native callbacks (#1369) 2018-09-05 16:48:10 -07:00
Pavel Krymets 613fbcc349
Enable code analysis on shim project (#1361) 2018-09-05 16:47:51 -07:00
Nate McMaster e23e8fff95
Install MicroBuild code signing plugin and set SignType = real (#1376) 2018-09-05 12:50:34 -07:00
Justin Kotalik 1b87f1e913 Merge branch 'merge/release/2.1-to-release/2.2' into release/2.2 2018-09-04 14:10:35 -07:00
Chris Ross (ASP.NET) 991cfa8bd8 Remove limits on SETTINGS_HEADER_TABLE_SIZE #2874 2018-09-04 12:01:13 -07:00
Pavel Krymets 0459b6d0d4
Fix dotnet.exe abort exception and startup/shutdown timeouts (#1352) 2018-08-31 09:05:46 -07:00
Justin Kotalik db01ae3717 Remove FreeConsole calls. (#1358) 2018-08-31 08:16:07 -07:00
Nate McMaster 7520ffa0ef
Fix up service scoping in the EF Core xml repository and update package version to 2.2 2018-08-30 16:22:43 -07:00
John Luo 153020ef8a Allow UTF8 encoded header values 2018-08-30 16:21:34 -07:00
Ryan Nowak 525fbf495b Fix #468 - all UseHealthChecks without a path 2018-08-30 15:33:49 -07:00
Nate McMaster a6a21351b6
Merge branch 'release/2.1' into release/2.2 2018-08-30 15:28:26 -07:00
Ryan Nowak 945e798ca7 [Design] Set the endpoint feature only on success 2018-08-30 14:52:35 -07:00
Ryan Nowak 8395ad8340 remove references to ref emit packages 2018-08-30 13:26:22 -07:00
Justin Kotalik 729a98adfc
Call AllocConsole (#1351) 2018-08-30 12:20:53 -07:00
Justin Kotalik e7f3c7c62e
Remove bad rc files (#1355) 2018-08-30 12:18:30 -07:00
Justin Kotalik 922298bc90
Add rc file as an include for ANCMV1 (#1284) (#1344) 2018-08-30 12:00:13 -07:00
Ryan Nowak 3e4a3d0b90
Allow health checks to use any DI lifetime (#466)
* Allow health checks to use any DI lifetime

This change allows registered IHealthCheck implementations to use any DI
lifetime. This is necessary for scenarios like using EF which requires a
scope.

The works by having the health check service create a scope for each
time it queries health checks. This scope does not overlap or share
state with other scopes (the request scope) so there is no crosstalk
between processing going on per-request in ASP.NET Core and the health
check operation.

* PR feedback and some logging cleanup
2018-08-30 10:51:48 -07:00
Ryan Nowak 8d053853bb Address PR feedback, I hit merge too soon. 2018-08-29 19:46:25 -07:00
Ryan Nowak 3511c8cef0 Add vectorized il-emit trie jump table
Add new futuristic jump table. Remove old experimental jump tables since
this is much much better.
2018-08-29 19:30:02 -07:00
Ryan Brandenburg afccb085a2 Fix links and formating 2018-08-29 16:22:42 -07:00
Pavel Krymets 26710080fe
Set AspNetCoreHostingModel in templates (#716) 2018-08-29 16:08:58 -07:00
Ryan Brandenburg 75fa0cd6e8 Remove SpaServices where they're un-needed 2018-08-29 15:24:12 -07:00
Ryan Brandenburg ccb2c006aa Merge branch 'merge/release/2.1-to-release/2.2' into release/2.2 2018-08-29 15:21:15 -07:00
dan.s.ward 8f7d995508 Added Entity Framework Core backed IXmlRepository with tests and sample (#303) 2018-08-29 14:04:37 -07:00
Nate McMaster cf3d2f1299
Minor tweaks to meta-package descriptions (#1343)
Per feedback on #1320 which came in post-merge.
2018-08-29 12:03:24 -07:00
Patrick Westerhoff 208f6ff568 Fix #574: Set NoDefaultLaunchSettingsFile
When a project is created with ExcludeLaunchSettings enabled, set the
NoDefaultLaunchSettingsFile property to prevent Visual Studio from
creating a launchSettings.json.
2018-08-29 11:35:16 -07:00
James Newton-King 99c4f2f36a
Support policy arguments and resolving services by constructors (#753) 2018-08-29 14:51:34 +12:00
Gert Driesen 1a43e67542 Remove workaround for dotnet/corefx#24562 (#2863)
This issue caused a bind to a recently used endpoint to fail on macOS and Linux.

Addresses #2820
2018-08-28 15:59:17 -07:00
Stephen Halter 5ea537fbc4
Don't advance examined in Http1MessageBody.PumpAsync for canceled reads (#2847) 2018-08-28 11:28:17 -07:00
Stephen Halter 89f4850883
Avoid throwing the same exception instances in parallel (#2859) 2018-08-28 10:56:46 -07:00
Nate McMaster 5f89835420
Merge branch 'release/2.1' into release/2.2 2018-08-28 10:33:12 -07:00
Nate McMaster afa93f1852
Merge branch 'release/2.1' into release/2.2 2018-08-28 10:14:24 -07:00
Ryan Brandenburg 9c28f95b12 Add Microsoft.AspNetCore.Razor.Design to templates (#674) 2018-08-28 09:41:15 -07:00
Justin Kotalik 037482829d
Add commit hash to V1 description (#1281) 2018-08-28 09:36:21 -07:00
Justin Kotalik 5f20f2a2dd
Update schema for ANCMv1 (#1276) 2018-08-28 09:35:49 -07:00
Justin Kotalik cc26d973ba
Remove early dereference of ASPNETCORE_PORT env var (#1274) 2018-08-28 09:34:54 -07:00
Justin Kotalik 338af6f07d
Reduce probability of startup port collisions (#1273) 2018-08-28 09:34:10 -07:00