Commit Graph

16234 Commits

Author SHA1 Message Date
Ryan Nowak 8a46e8cd93 Update SpaDefaultPageMiddleware for endpoints
This change makes the SpaDefaultPageMiddleware noop when an endpoint has
been chosen. This is a problem today because this usually runs after
routing, but its always terminal.

So even if endpoint routing selected something, this would still serve
the default file. We're adding more things that fill this niche, but it
seems like a good idea to fix the existing stuff.
2019-03-06 09:48:07 -08:00
Ryan Nowak 089f64c528 Add fallback routing to file
This is a new routing feature that integrates static files to serve a
static file when routing doesn't match anything else.

This is a scenario that's covered by SPA services today, but given the
improvements to routing it makes much more sense to move lower in the
stack.
2019-03-06 09:48:07 -08:00
Ryan Nowak 7e63e2da43 Make StaticFiles Noop for middleware
Teaches all of the static files middleware (incl default files,
directory browser) to noop when an endpoint is selected. This is
desirable so you can place them after routing if you want with no ill
effect.
2019-03-06 09:48:07 -08:00
Ryan Nowak f150e89125 Add file/non-file and generic fallback
Adds new constraints for checking if a route value is a file or not.

Added a new set of builder methods that specify what it means to be a
'fallback'. This is really similar to what the older SPA fallback routes
do, but this is lower in the stack and directly integrated with
endpoints.
2019-03-06 09:48:07 -08:00
David Fowler 4c79e7fdc0
Rename Pipe properties (#8227)
* Rename Pipe properties
- Rename BodyPipe to BodyReader and BodyWriter on the request and response directly
2019-03-06 07:33:24 -08:00
Andrew Stanton-Nurse 303a354993
skip another flaky kestrel test in helix (#8216)
related #8215
2019-03-05 15:09:56 -08:00
Jeremy Lawrence a1f544b62f Correct doc comment for ApiConventionTypeMatchBehavior (#7861) 2019-03-05 14:43:59 -08:00
Pranav K b90220ad05
Improve NullHtmlEncoder perf (#7987)
Fixes #7987
2019-03-05 14:41:55 -08:00
shnja 4c3996f824 Use Request.Scheme instead of Protocol (#7911) 2019-03-05 14:39:37 -08:00
Hao Kung 4e271ac124
Send email confirmation after register via external login (#8013) 2019-03-05 13:53:15 -08:00
Chris Ross def25cb3de
Document the change policy for FileExtensionContentTypeProvider #2454 (#8213) 2019-03-05 13:50:48 -08:00
BrennanConroy 58ad7b7550
Fix build flakiness (#8211) 2019-03-05 12:59:21 -08:00
Pranav K b41959ac32 Add additional logging to TempDataInCookiesTest to diagnose test failure
Diagnosis for https://github.com/aspnet/AspNetCore-Internal/issues/1803
2019-03-05 12:33:49 -08:00
Pranav K 44c66c8314 Revert "Skipping flaky test"
This reverts commit 680c069554fd2a184b8a3030711aed35d4293c4b.
2019-03-05 12:33:49 -08:00
Ryan Brandenburg 0add673139
Include more template baselines (#4186)
Include more template baselines
2019-03-05 12:02:34 -08:00
Mikael Mengistu 9b4f8d79fd
Fix Java Client transport select (#8143) 2019-03-05 11:31:56 -08:00
Pavel Krymets 2665f6d238
Isolate message compiler output files (#8197) 2019-03-05 11:27:09 -08:00
Ryan Brandenburg 414d8a514f
Add missing doc comments (#8035) 2019-03-05 10:01:20 -08:00
David Fowler d1ee93b94b
Allow disabling automatic MVC reference (#8167) 2019-03-05 09:19:28 -08:00
Andrew Stanton-Nurse 98a49e332f
skip flaky SignalR test: ErrorDuringPollWillCloseConnection (#8171)
see #8138 for discussion on test priority and re-enabling
2019-03-05 08:30:40 -08:00
Andrew Stanton-Nurse e0dbc21ccc
skip flaky Kestrel ValidationFailureRejectsConnection test on Helix (#8170)
See #8168 for details on the failure and discussions on priority of unskipping.
2019-03-05 08:23:58 -08:00
BrennanConroy c8c12cda9b
Fix test discovery (#8201) 2019-03-04 23:11:16 -08:00
Pranav K 33839dc66a
Client reconnects when state's available on the server (#7395)
Reconnect if we have state on the server

Fixes #7537
2019-03-04 17:27:51 -08:00
Justin Kotalik d09c6e8576
Disable ConfigurationChange Test (#8113) 2019-03-04 16:58:28 -08:00
Ben Adams 19b52bdc8b Elide bounds check for MethodToString (#7887) 2019-03-04 16:44:21 -08:00
Chris Ross b9fda976c0
Update Worker template for Worker SDK (#7965)
* Update Worker template for Worker SDK

* Change template order

* Remove servergc
2019-03-04 16:17:25 -08:00
Pranav K 39e52578d3
Make page load async when using endpoint routing (#7938)
* Make page load async

Fixes #8016
2019-03-04 14:45:59 -08:00
Hao Kung 48a67cfd18
Fix for external logins disappearing after failed login (#7002)
Also adds external logins to register page
2019-03-04 12:46:18 -08:00
BrennanConroy 508256d028
Always load NodeHttpClient to fix SSR (#8047) 2019-03-04 09:16:52 -08:00
Steve Sanderson 7111c8ffd7 Handle async exceptions when not rendering root component. Fixes #8151 2019-03-04 16:44:42 +00:00
Andrew Stanton-Nurse 7b24304739
skip flaky SecureDataFormatTest in Helix (#8129)
related #7366
2019-03-04 07:50:53 -08:00
Nikita Potapenko 83cb05d83c Rename DataProtectorTokenProvider (#8027) 2019-03-04 02:03:31 -08:00
David Fowler 9cb1185a5c
Add option to restrict the maximum hub message size (#8135)
- This change moves the limit checking from the transport layer to the protocol parsing layer. One nice side effect is that it gives us better control over error handling.
2019-03-03 15:18:32 -08:00
BrennanConroy 67d339ee3b
C++ client: string_t to string (#8063) 2019-03-02 22:11:18 -08:00
Ben Adams ddce32a791 Use C#8 (#8128) 2019-03-02 19:48:43 -08:00
Andrew Stanton-Nurse 4aad7548c1
skip Libuv.FunctionalTests RemoteIPv6Address on Helix (#8111) 2019-03-01 18:37:51 -08:00
Andrew Stanton-Nurse 6e8a9f6d6a
Skip flaky clientcert test in Kestrel (#8112)
related #7265

flaked out in https://github.com/aspnet/AspNetCore/pull/7987
2019-03-01 18:37:23 -08:00
Chris Ross 93b195e566
Change SameSite default to None #2675 #4661 (#8043) 2019-03-01 16:22:12 -08:00
Ryan Brandenburg 4a5720beba Updated PR with my changes 2019-03-01 15:25:58 -08:00
Chris Ross 1830f4f0dd
Avoid race in FileWatcher test Internal/1710 (#8095) 2019-03-01 15:03:21 -08:00
Justin Kotalik fc9e48877c
Add FormPipeReader (#7964) 2019-03-01 14:41:05 -08:00
Andrew Stanton-Nurse 22e706cdc3 pr feedback 2019-03-01 13:55:45 -08:00
Andrew Stanton-Nurse 8c2c458891 some little xml doc changes 2019-03-01 13:55:45 -08:00
Andrew Stanton-Nurse 9a61275fa6
skipping ReactRedux test due to flakiness (#8100)
related #7377
2019-03-01 13:54:57 -08:00
Pranav K 85c051d8da
Skipping flaky test (#8101) 2019-03-01 13:37:19 -08:00
Damian Edwards bec911d8b4
Merge pull request #7993 from zbecknell/patch-1
Update Blazor NDC video link
2019-03-01 12:26:14 -08:00
Andrew Stanton-Nurse 8cd36953ef
skip flaky HttpSys test in helix (#8092)
Related to #8091
2019-03-01 12:20:59 -08:00
BrennanConroy 337370263a
Remove private assets (#8080) 2019-03-01 11:17:29 -08:00
BrennanConroy d0c415a4dc
Skip flaky websocket test (#8085) 2019-03-01 11:14:25 -08:00
Sebastien Ros 275960631d Updating ref file 2019-03-01 10:52:24 -08:00
Sébastien Ros 1c2c2c9be0 Update NullHtmlEncoder.cs 2019-03-01 10:52:24 -08:00
Sebastien Ros 23dee7c43f Keep argument checks 2019-03-01 10:52:24 -08:00
Sebastien Ros ba875bffcd Using spans to optimize the slicing case 2019-03-01 10:52:24 -08:00
Sebastien Ros 55fea7976c Improve NullHtmlEncoder perf 2019-03-01 10:52:23 -08:00
Justin Kotalik a7f1cc1b2a
Redisable AbortedStream_ResetsAndDrainsRequest_RefusesFramesAfterCooldownExpires (#8082) 2019-03-01 10:10:14 -08:00
Ryan Brandenburg 0d489304a4
Skip react for now (#8053)
Skip react for now
2019-03-01 09:47:53 -08:00
Hao Kung 3b16c69786 Skip NodeServices tests on helix (#8045)
NodeJs not installed on helix boxes by default currently

https://github.com/aspnet/AspNetCore/issues/8044 tracking this skip
2019-03-01 09:37:43 -08:00
Justin Kotalik 32aebef4d1
Disable any flaky IIS tests (#8050) 2019-03-01 08:19:26 -08:00
Javier Calvarro Nelson 98c7e965bd
[ApiAuthorization] Mark package as shipping (#8026) 2019-03-01 07:52:29 -08:00
Justin Kotalik 5fd53d9d07
Check HasStarted before calling Flush/Start in StartAsync (#8041) 2019-02-28 22:45:24 -08:00
Justin Kotalik 3509323ad1
Remove extra await/state machine in FlushAsync (#7646) 2019-02-28 22:42:42 -08:00
Mikael Mengistu 745941058c
Detect Classic SignalR Server in Java Client (#7817) 2019-02-28 18:12:53 -08:00
Chris Ross c0e6722020
Make ConventionBasedStartup pubternal #6975 (#7800) 2019-02-28 15:21:01 -08:00
Ryan Nowak cb21edc500
Fix #7258 - remove components.server dependencies on blazor-specific plumbing (#7934)
* Removes a bunch of trivial usage of Blazor

... in names and comments where we don't specifically mean Blazor.

* Remove obsolete Startup from Components app

* Move UseBlazor into Blazor.Server

Moves UseBlazor and the related features in Blazor.Server - along with
some other general cleanup of misc shared files.

Now Components.Server has a much slimmer set of dependencies (MVC is
gone) and doesn't contain the "double startup" pattern that we
introduced (sorry).

We'll revisit UseBlazor and the dependencies there once the new
MapFallbackToFile support is available from static files.

* minor PR feedback

* Update reference assemblies

* fix broken test
2019-02-28 10:36:07 -08:00
Chris Ross f168835c0a
Avoid port conflicts for HttpSys Internal/#1795 (#7808) 2019-02-28 10:31:15 -08:00
Nate McMaster e7b00a5508
Deprecate the Microsoft.AspNetCore.App metapackage in favor of targeting and runtime packs (#7832)
* Deprecate the Microsoft.AspNetCore.App metapackage in favor of targeting and runtime packs
* Stop producing Microsoft.AspNetCore.App, and runtime.$(rid).Microsoft.AspNetCore.App
* Generate the shared framework without using 'NuGet' restore
* Stop producing intermediate packages for shared-framework only assemblies
* Put the platform manifest into the targeting pack (data/Microsoft.AspNetCore.App.PlatformManifest.txt)
* Create well-known, shared intermediate directories that installers can use to bundle content
2019-02-28 10:14:18 -08:00
Steve Sanderson 18c1b994df
Basic integration tests for NodeServices (#8029) 2019-02-28 17:58:57 +00:00
Pranav K f79f2e3b12
Add some reference docs for MVC (#7981) 2019-02-28 09:56:55 -08:00
BrennanConroy 47220cf13e
Fix StreamInvocationsBlockOtherInvocationsUntilTheyStartStreaming (#8015) 2019-02-28 09:23:33 -08:00
Massimo Prota 0dd3375095 [Azure] Fixed two misspelling of 'tenant' in properties' inline XML documentation (#7912)
- Azure/AzureAD/Authentication.AzureAD.UI/src/AzureADOptions.cs
- AzureAD/Authentication.AzureADB2C.UI/src/AzureAdB2COptions.cs
2019-02-28 03:06:22 -08:00
Justin Kotalik 555e460c15
Fix flaky AbortedStream test in Kestrel (#8010) 2019-02-27 20:55:10 -08:00
Stephen Halter 896c027010
Increase shutdown timeout in Kestrel's other TestServer (#8011) 2019-02-27 18:15:25 -08:00
N. Taylor Mullen f5b6039add Add docs for Microsoft.AspNetCore.Mvc.TagHelpers.
- Also obsoleted two unused members on `ImageTagHelper`.
- Removed `NoWarn` for docs on `Microsoft.AspNetCore.Mvc.TagHelpers`.

Addresses aspnet/Docs/#10593
2019-02-27 15:42:38 -08:00
Hao Kung 07dad89721
Clarify ExternalLoginInfo displayName doc comment (#7833) 2019-02-27 15:02:20 -08:00
Chris R 58915cb8e4 Remove servergc 2019-02-27 14:53:38 -08:00
BrennanConroy a936d77845
Automatically capture crashdumps for C++ client tests (#7940) 2019-02-27 14:20:14 -08:00
Nathan 4e4fdaaf68 Adding SameSite comments (#7907) 2019-02-27 12:00:16 -08:00
James Newton-King a6b00f0d0d
Add xml docs to RazorPagesEndpointRouteBuilderExtensions (#7992) 2019-02-28 08:22:44 +13:00
Pavel Krymets 783131a750
Re-enable full IIS tests on Windows.10.Amd64.EnterpriseRS3.ASPNET.Open (#7959) 2019-02-27 11:03:41 -08:00
Sébastien Ros fd83f4dbb9
Using <FrameworkReference> in benchmark apps (#7957) 2019-02-27 10:27:01 -08:00
Mikael Mengistu 0d570a2d42
Add small doc comment for TransportType Enum(#7994) 2019-02-27 09:17:08 -08:00
Javier Calvarro Nelson 4fe4295720
[Components][Fixes #7405] Increase CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync timeout to reduce test flakyness
Increases the timeout from 500 to 1000
2019-02-27 04:28:07 -08:00
Zachary Becknell 0d48617ef9
Update Blazor NDC video link 2019-02-26 22:50:27 -05:00
Justin Kotalik bbe4a9d071
Call Complete on Http2Stream when stream is done earlier (#7933) 2019-02-26 18:24:35 -08:00
Chris R 608505652a Change template order 2019-02-26 14:32:22 -08:00
Chris R 0d304917dc Update Worker template for Worker SDK 2019-02-26 12:07:14 -08:00
Hao Kung a2c8a34556
Reenable some helix tests (#7763)
* Fix identity UI script tests on helix
* Add OnHelix static helper method
2019-02-25 23:39:46 -08:00
Chris Ross 40b2a945b3
Merge pull request #7918 from dotnet-maestro-bot/merge/release/3.0-preview3-to-master
[automated] Merge branch 'release/3.0-preview3' => 'master'
2019-02-25 19:46:41 -08:00
Ben Adams 423de42849 Use less stack for HttpResponseHeaders.CopyToFast (#7724) 2019-02-25 17:41:12 -08:00
Chris R 87ae40f814 Update Microsoft.AspNetCore.Hosting.Abstractions ref assembly 2019-02-25 17:17:10 -08:00
Doug Bunting d515bd977f
Merge branch 'master' into merge/release/3.0-preview3-to-master 2019-02-25 15:56:46 -08:00
Stephen Halter 46fe595606
Support IAsyncEnumerable returns in SignalR hubs (#6791) 2019-02-25 15:08:11 -08:00
Ryan Brandenburg 03460d81ce
Add retries to CDN downloads (#7881)
Add retries to CDN downloads
2019-02-25 14:44:22 -08:00
Mikael Mengistu 3d17ac3d4c
Handle onReceive logic in background thread (#7809) 2019-02-25 14:24:07 -08:00
Steve Sanderson 87f4ca7299
[Templates] Imports and CSS tweaks for forms/validation (#7914)
* Add Microsoft.AspNetCore.Components.Forms to default Components imports

* Add default validation CSS rules in Components/Blazor templates

* Add default validation CSS styles to Components testassets projects
2019-02-25 21:50:12 +00:00
Steve Sanderson 61098b6680
Make InputBase use EventCallback for ValueChanged (#7915)
* Make InputBase use EventCallback for ValueChanged

... so that the host component gets re-rendered automatically after each value change (like when binding to DOM elements).

* Improve E2E test code

... so that the host component gets re-rendered automatically after each value change (like when binding to DOM elements).
2019-02-25 21:49:28 +00:00
Hao Kung 9e21faeafb
Skip failing identity tests (#7926) 2019-02-25 12:55:35 -08:00
Nate McMaster d2d60000eb
Create Linux installers for the aspnetcore targeting pack (#7776)
This creates 3 new build outputs:

* aspnetcore-targeting-pack-$(version).tar.gz
* aspnetcore-targeting-pack-$(version)-linux-x64.deb
* aspnetcore-targeting-pack-$(version)-linux-x64.rpm

Other changes:
* Make RPM packaging consistent with other installers. Vendor == Microsoft Corporation
* Add shared properties for building the targeting pack (or not building it in a servicing build)
2019-02-25 12:00:36 -08:00
John Beisner f0cb6cc68b Modify the 'InstallLocation' registry key. (#7877)
Before = SOFTWARE\dotnet\Setup\InstalledVersions\<arch>\sdk
After = SOFTWARE\dotnet\Setup\InstalledVersions\<arch>
2019-02-25 11:05:00 -08:00
Javier Calvarro Nelson 23c528c176 [Azure] [Fixes #6033, #6580, #6669] Various fixes and cleanups.
* Adds an Azure AD Sample and adds a page to test access denied.
* Renames AzureAD and AzureADB2C internal classes for easier to debug
  stacktraces.
* Fixes service registration for options configuration.
* Adds missing deps to the solution.
2019-02-25 10:18:59 -08:00