James Newton-King
07e975a0ed
Return a shared contract resolver
...
Return a shared contract resolver from CreateSerializerSettings for performance
2017-06-06 17:52:18 +12:00
Pranav K
628dfc39c1
Remove model type from RazorPageAttribute
2017-06-05 16:07:14 -07:00
Pranav K
20c04d099e
Update to use Razor parser to parse page directive
2017-06-05 14:02:24 -07:00
Ryan Nowak
b796bc0f39
Add Page filters
2017-06-05 08:05:49 -07:00
Kiran Challa
03e696a05e
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-01 15:19:13 -07:00
Jass Bagga
4e91e4e36f
Correct short-circuit log message for result filters ( #6350 )
...
Addresses #6318
2017-06-01 14:01:08 -07:00
Kiran Challa
0f0cfdfe94
Removed unnecessary package references
2017-06-01 12:02:05 -07:00
Jass Bagga
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
John Luo
3a4cae72bd
Use Strict SameSite mode for temp data cookies
2017-05-30 21:04:32 -07:00
Pranav K
3089bf74fe
Remove reference to Microsoft.Extensions.PlatformAbstractions
2017-05-27 17:22:05 -07:00
Pranav K
597a0c9a11
Add support for friendly routes in pages
...
FIxes #6325
2017-05-26 14:29:00 -07:00
Ryan Nowak
688e518991
Add result filters to pages
2017-05-26 12:33:46 -07:00
Ryan Nowak
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
Ryan Nowak
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
Ryan Nowak
b7db6dbc8e
Remove pass-through activator for pages
...
This change removes a 'pass through' IRazorPageActivator that we were
using to avoid the default one initializing the Page twice.
The fix is to add an adapter so that the IRazorPage that the RazorView has
isn't the *real* page, it's the adapter. The adapter doesn't have anything
interesting to activate :).
2017-05-26 12:29:10 -07:00
Ryan Nowak
c3f7613725
Make RazorReferenceManage public
...
Fix for #4938 . This change makes the reference manager public and
documented so that it can be replaced.
2017-05-26 10:58:45 -07:00
Doug Bunting
9f4ff22c4a
React to breaking change latest API Check detects
...
- see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146
- relates to 014a786b45
2017-05-26 09:53:46 -07:00
Hao Kung
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
Pranav K
bb5eb96625
Load the precompilation type from the loaded assembly
2017-05-25 15:00:12 -07:00
Ryan Brandenburg
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
Ryan Brandenburg
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
Pranav K
452578e4a8
Revisit the architecture of CompilerCache
...
Fixes #5912
2017-05-25 08:54:15 -07:00
Ryan Nowak
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
Ryan Nowak
6094c6ff52
Remove use of AssemblyLoadContext
...
This will be needed for the switch back to net46.
2017-05-24 11:05:58 -07:00
Ryan Nowak
a6d97d35e3
Add back support for AddTagHelpersAsServices
...
This doesn't go through the Razor tag helper discovery pipeline because
this can really only ever work for ITagHelper based taghelpers. So
there's really no point in reusing that logic, which would be hard
anyway.
2017-05-23 14:04:42 -07:00
Chris R
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
Jass Bagga
e681c23d5c
Add ITagHelperComponentManager ( #6302 )
...
Addresses #6282
2017-05-23 13:22:15 -07:00
Pranav K
39f1f5c933
Move Pages filter creation to application model provider
...
Fixes #6198
2017-05-23 11:03:19 -07:00
Pranav K
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
Jass Bagga
9d38e2523c
Add methods to TagBuilder ( #6287 )
...
Addresses #5689
2017-05-19 12:23:16 -07:00
Jass Bagga
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
Mardoxx
ece5e748ad
Minor documentation fix for SerializableError
...
ModelStateEntry -> ModelStateDictionary
2017-05-18 11:02:23 -07:00
Ryan Nowak
97bbdafde3
React to Razor changes
2017-05-16 14:58:37 -07:00
Jass Bagga
51c142ae91
Modify GetProperties overload ( #6276 )
...
Addresses https://github.com/aspnet/Common/issues/219
2017-05-16 13:34:14 -07:00
Ryan Nowak
4d905a4110
Make our executor methods virtual
...
Fixes #5874 - we are marking these methods virtual just in case someone
wants to customize the executors. These are in the 'public internal'
namespace but can't really be replaced because they aren't sufficiently
virtual.
2017-05-16 08:43:45 -07:00
Henrik W. Moe
af7303cd8d
Corrected xml-comment for the User-property
...
Removed comment about setting the User. `User` property only supports `get`.
2017-05-16 08:01:38 -07:00
Ajay Bhargav Baaskaran
5662717983
Add null check in WriteLiteral
2017-05-15 15:08:50 -07:00
Jass Bagga
cd6befdef1
Assign unique event Ids in the logger ( #6270 )
...
Addresses #6062
2017-05-15 11:52:52 -07:00
Ryan Nowak
b2d95ffb21
Remove usage of NotFoundProjectItem
...
We're making this type internal in Razor, using a mock here is fine.
Also renamed some types with a generic name. The actual 'default'
RazorProject class lives in Razor and is internal.
2017-05-12 15:55:36 -07:00
Jass Bagga
b758a86a38
Modify ViewComponent_CannotFindComponent error message ( #6263 )
2017-05-12 14:15:29 -07:00
Ajay Bhargav Baaskaran
5eabae55cb
Added PushWriter and PopWriter to RazorPageBase
...
- Removed WriteXYZTo methods
2017-05-11 15:21:42 -07:00
Pranav K
42a4e9a143
Make uses of ObjectMethodExecutor internal
2017-05-10 21:17:51 -07:00
Pavel Krymets
cf64b335f6
Remove unnecessary package references ( #6252 )
2017-05-10 12:06:10 -07:00
Pranav K
7d28714d9a
Pin build of ObjectMethodExecutor to allow breaking change to go thru first
2017-05-10 10:15:14 -07:00
Steve Sanderson
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
John Luo
d13c9055f0
Merge branch 'rel/2.0.0-preview1' into dev
2017-05-05 19:29:20 -07:00
John Luo
a1977cac50
Migration
2017-05-05 19:28:24 -07:00
Ryan Nowak
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
Jass Bagga
87bb1d0ff5
Refactor GenerateCheckBox ( #6229 )
...
Addresses #5981 and #5983
2017-05-05 11:53:53 -07:00
Pranav K
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
Pranav K
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
Steve Sanderson
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
Pranav K
720a47765d
Re-enable baseline check for ViewFeatures\r\nFixes #6186
2017-05-02 11:51:01 -07:00
N. Taylor Mullen
8bece90c83
Fix asp-page-handler to generate form tags correctly.
...
- Prior to this change using asp-page-handler on its own did not create correct `<form>` elements. There were multiple issues, one as that the `FormTagHelper` would purposefully drop into a no-op code path. Second is the `DefaultHtmlGenerator` didn't call through to the `UrlHelper` correctly.
- Added functional test cases to validate asp-page-handler can live on its own on a form tag. This also included adding a variant where method="post".
- Added a `FormTagHelper` unit test to validate the `PageHandler` property is consumed properly.
#6208
2017-04-27 10:32:04 -07:00
Ryan Nowak
b1b3a816cc
Rename View() to Page()
...
This requires us to introduce another base class between RazorPageBase and
Page - you need this because you aren't allow to have Page.Page().
2017-04-27 09:27:14 -07:00
N. Taylor Mullen
490f94d425
Add placeholder `DefineSection` method.
...
- This enables 2.0.0 code generation to not error.
aspnet/Razor#1254
2017-04-26 15:12:16 -07:00
N. Taylor Mullen
f165914b40
Update how `FormTagHelper` handles `get` method attributes.
...
- Added functional test to verify `asp-*` attributes on form taghelpers work as expected.
- Added a unit test to validate `FormTagHelper` behaves as expected.
- Moved `Method == "get"` checks into appropriate code paths. These include the one where a user specifies an empty or non-existent `action` attribute and where a user doesn't utilize any `asp-*` attributes. In the later, we default `Method` to `"get"` if it's not provided.
#6006
2017-04-25 15:17:15 -07:00
Ryan Brandenburg
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
Smit Patel
bd39d36d75
Update API Check related files
...
React to aspnet/BuildTools#238
2017-04-25 08:19:00 -07:00
Pranav K
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
N. Taylor Mullen
ef0333ac6a
Add Antiforgery to the FormTagHelper pre-check for processing.
...
- Added a test case to the HtmlGeneration functional test (the one verifying complex FormTagHelpers).
- Added unit test verifying antiforgery behavior when it's the only provided parameter.
#6006
2017-04-24 21:46:54 -07:00
N. Taylor Mullen
5c8a161ace
Change `FormTagHelper` to apply to all form tags.
...
- Added functional test to validate that non-attributed form tags have an antiforgery input generated. Re-generated baseline to reflect changes.
- Added a unit test to validate that parameterless `FormTagHelper`s behave as expected.
#6006
2017-04-24 18:39:01 -07:00
Pranav K
ccdaa5a729
Make /Pages the default root for pages.
...
Fixes #6184
2017-04-24 15:46:32 -07:00
Ryan Nowak
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
Doug Bunting
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
Ryan Nowak
da5c304f5d
Temporarily deativate API Check
2017-04-21 19:42:04 -07:00
Pranav K
ca017eced2
Add page to AnchorTagHelper and FormTagHelper
...
Fixes #6088
2017-04-21 18:12:54 -07:00
Pranav K
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
Ryan Nowak
297196baa0
Design updates to handler methods and binding
...
Implements #6091 , #6072 , #6090 , #5927
2017-04-21 17:29:25 -07:00
Ryan Brandenburg
908b4c8d62
FormAction from QueryString
2017-04-21 15:04:37 -07:00
Ajay Bhargav Baaskaran
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
N. Taylor Mullen
83faaebdb6
Upgrade Roslyn dependency to 2.0.0.
...
- Added C# 7 unit and functional test to validate features work end-to-end.
#6149
2017-04-21 11:41:31 -07:00
Christopher Dresel
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
Ryan Brandenburg
5a184df808
Remove Binder from Page and PageModel
2017-04-20 17:54:50 -07:00
Hao Kung
ea3becb3ca
Reenable APICheck
2017-04-20 13:48:26 -07:00
Pranav K
9fe480f735
Add LazyReferenceMetadataFeature
2017-04-20 13:05:50 -07:00
Pranav K
681b798a2e
RedirectToPage doesn't trim /Index from URL
...
Fixes #6080
2017-04-20 11:15:45 -07:00
Andrew Stanton-Nurse
a975d7fa01
react to removal of PlatformAbstractions ( #6164 )
2017-04-20 11:09:18 -07:00
Ryan Nowak
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
Hao Kung
6cd487e15f
Disable api check temporarily to unblock build
2017-04-19 16:07:23 -07:00
Hao Kung
025efe1d6e
Fix usings to use Auth 2.0
2017-04-19 15:12:50 -07:00
Ryan Brandenburg
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
Hao Kung
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
Ryan Nowak
a8eb5bee70
Implement view search for pages
...
The View Engine now needs to know about pages :(. This isn't ideal but the
view engine needs to know what set of search paths to use. This was
already hardcoded for controllers vs controllers + areas. It felt right to
further hardcode instead of introduce a wierd abstraction that we only
use.
Additionally pages use a view location expander to implement an ascending
directory search.
2017-04-18 16:11:24 -07:00
Ryan Brandenburg
c56b64fc41
Add factory methods
2017-04-17 16:11:34 -07:00
Pranav K
8ed55107e7
Add support for page precompilation
2017-04-17 10:43:50 -07:00
Pranav K
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
Jass Bagga
d8a95c731b
Move RazorViewEngineOptionsSetup to internal namespace ( #6125 )
...
Addresses #6116
2017-04-13 13:35:35 -07:00
Pranav K
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
Pranav K
3474bdf776
RedirectToPage from a form-action handler includes the formaction
...
Fixes #6104
2017-04-12 09:27:08 -07:00
Ryan Brandenburg
59a3aade9b
Fix [TempData] for PageModel's
2017-04-11 16:45:44 -07:00
Jass Bagga
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
N. Taylor Mullen
36e272fdc2
React to Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore.Razor.Language.
...
aspnet/Razor#1169
2017-04-10 10:20:19 -07:00
Steve Sanderson
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
Pranav K
1e7972bd8f
Add convenience methods for redirecting from a Razor Page back to itself
...
Fuxes #5953
2017-04-07 10:03:42 -07:00
Ryan Nowak
4032de064e
Removing _PageStart.cshtml
...
Pages now also use _ViewStart.cshtml
Also contains some naming/text cleanup that was missed in the previous
commit.
2017-04-06 08:14:37 -07:00
Ryan Nowak
c6e4609096
Getting rid of _PageImports
...
Pages will just use _ViewImports.
2017-04-06 08:14:37 -07:00
Ryan Brandenburg
9e8d4db7d8
Move TempDataPropertyProvider into filter
2017-04-05 12:04:02 -07:00
Pranav K
925ad75cdf
Add convenience methods for redirecting to another Razor Page
...
Fixes #5956
2017-04-04 14:36:22 -07:00
Pranav K
2d19a82678
Update more resource designer files
2017-04-04 13:54:20 -07:00
Pranav K
b18e96717a
React to https://github.com/aspnet/Razor/issues/1098
2017-04-03 16:41:55 -07:00
Pranav K
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
Pranav K
10d2d7c9f6
Remove System.Reflection.TypeExtensions added to workaround test failures
...
Fixes #6005
2017-04-03 14:47:14 -07:00
Hisham Bin Ateya
fe3d45fad1
Adding AllowAnonymousToPage & AllowAnonymousToFolder
...
Fixes #5884
2017-03-31 20:17:31 -07:00
Steve Sanderson
d19150ed22
Fix comment typos in preceding commit
2017-03-31 10:36:53 +01:00
Steve Sanderson
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
Ryan Brandenburg
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
Jass Bagga
959324b337
Add EditorBrowsable attribute
2017-03-29 16:24:44 -07:00
Jass Bagga
eda5028cf4
Add TagHelperComponentTagHelper
...
Addresses #5728
2017-03-29 11:29:24 -07:00
Kiran Challa
c18f0780c1
[ Fixes #5413 ] JsonOutputFormatter adds all closing brackets when exceptions are thrown
2017-03-28 23:09:18 -07:00
Pranav K
b22326323a
Add properties to Page and PageModel
...
Fixes #6008
2017-03-28 13:26:38 -07:00
Kiran Challa
9c5b33dd8a
Upgraded Json.Net version to 10.0.1
2017-03-28 11:28:43 -07:00
John Luo
d21af1f26d
React to MemoryCache trigger removal
2017-03-27 12:45:54 -07:00
twirpx
58317b18ce
Fixing NRE when CacheTagHelper throws and exception ( #5989 )
...
Fixes #5988
2017-03-27 12:45:22 -07:00
Derek Gray
575fe68b2b
Order enum values by DisplayAttribute.Order
...
Fixes #4297
2017-03-27 12:22:35 -07:00
Doug Bunting
6436538068
Rename `IHtmlHelper.TextBox()` parameter (for consistency)
...
- #5394
2017-03-27 10:24:30 -07:00
Doug Bunting
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
Jass Bagga
cc6f0f6a26
ITagHelperComponent build fix
...
Fix build
In reaction to aspnet/Razor#1096
2017-03-24 15:23:03 -07:00
Pranav K
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
David Fowler
d2430f0f4e
Merge pull request #6004 from CoskunSunali/dev
...
Avoid entry point assembly being loaded twice during assembly parts discovery
2017-03-22 22:07:28 -07:00
Pranav K
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
Pranav K
e80abc1950
React to Razor changes
2017-03-22 18:06:18 -07:00
Doug Bunting
1152c468be
Disable API Check in projects with untracked breaking changes
2017-03-22 08:34:48 -07:00
Pranav K
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
Coskun Sunali
11d265bddd
Avoid entry point assembly being loaded twice during assembly parts discovery.
...
Addresses https://github.com/aspnet/Mvc/issues/6003
2017-03-22 04:37:06 +03:00
Stefan Nikolei
5c79d4e8ee
Remove Usage of RazorIrNodeVisitorOfT ( #5991 )
2017-03-20 14:52:30 -07:00
Ryan Brandenburg
270f66198f
Remove Razor from projects
2017-03-17 15:00:39 -07:00
Ajay Bhargav Baaskaran
1fdc5132cb
React to TagHelper descriptors api cleanup
2017-03-17 10:51:02 -07:00
Jass Bagga
1197657e5b
TempData property attribute
...
Addresses #5600
2017-03-16 16:34:35 -07:00
Ryan Nowak
8f4ca32f48
Fix #5807 - Race condition in Invoker
...
This change addressed a race condition in the ObjectMethodExecutor where
the default argument values array can become visible before it is
initialized. If a second observer accesses the array while it is being
initialized, it can observe a null value for a reference type parameter,
leading to a nullref.
The fix here is to make everything immutable and initialize it all up
front. There's no reason to create an OME without eventually running it,
so there's no downside to doing the initialization up front.
2017-03-15 17:19:29 -07:00
Nate McMaster
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
Pranav K
bee1a55cff
Use RazorPagesOptions.RootDirectory when looking for page hierarchies.
...
Fixes #5915
2017-03-14 18:56:50 -07:00
Pranav K
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
Ryan Brandenburg
82d87df166
Fix warning as error
2017-03-14 12:44:57 -07:00
Ryan Brandenburg
365ae19c8b
Add InvalidTagHelperIndexerAssignment to RazorPageBase
2017-03-14 10:04:15 -07:00
hishamco
e44d875df4
Adding AuthorizePage & AuthorizeFolder without requiring a policy
...
Refactoring
2017-03-13 16:39:52 -07:00
Pranav K
f7fd5114b3
Introduce MvcRazorTemplateEngine
2017-03-13 16:33:13 -07:00
Pranav K
4faef7afaf
Cache more things in HandlerMethodDescriptor
...
Add tests for DefaultPageHandlerMethodSelector
2017-03-13 13:15:26 -07:00
Pranav K
7b53ba1f6b
Reacting to https://github.com/aspnet/Razor/issues/1063
2017-03-13 09:46:36 -07:00
Ryan Brandenburg
1c74e31715
Add tests for PageActionInvokerProvider ( #5882 )
2017-03-09 16:19:20 -08:00
Ryan Brandenburg
7f3f6957be
Set path in DefaultPageFactory ( #5911 )
2017-03-09 16:15:43 -08:00
jacalvar
3cd8c8c14d
[ Fixes #5932 ] Add constructor taking the BinderType to ModelBinderAttribute
2017-03-09 08:16:00 -08:00
Nick Chapsas
015dafc25f
[Feature] String should be an acceptable value for a checkbox if it can be parsed as a boolean ( #5845 )
...
- `string` should be an acceptable value for a checkbox if it can be parsed as a `bool`
- `throw` with different resources when `ModelType` isn't `bool` or `string` and when `string` value is not acceptable
2017-03-08 14:22:28 -08:00
Ryan Brandenburg
d9d280d1ef
Make CookieTempDataProvider the default ITempDataProvider ( #5892 )
2017-03-07 16:04:47 -08:00
Pranav K
7bca31d079
Add convenience extension methods for IPageApplicationModelConvention
2017-03-06 15:28:44 -08:00
Steve Gordon
b6a6b50776
Fixing up an error in the XML Comments ( #5888 )
2017-03-06 11:07:16 -08:00
Ryan Brandenburg
de1d0919e5
Add Http Response Codes to doc comments ( #5867 )
2017-03-06 10:00:07 -08:00
Pranav K
00c38fca59
Add ModelState to Page
2017-03-03 17:27:39 -08:00
Pranav K
145d27f9b3
Add a PagesOption type that allows configuring the root for Page file discovery
...
Fixes #5785
2017-03-03 17:20:07 -08:00
Ryan Brandenburg
85e28ae478
Trim quotes from template ( #5838 )
2017-03-03 09:52:36 -08:00
Pranav K
7cadb58e12
Add convenience extension methods for IPageApplicationModelConvention
2017-03-02 17:38:04 -08:00
Pranav K
f6d25f7117
Fix build warning
2017-03-02 17:20:20 -08:00
Ajay Bhargav Baaskaran
f7c2e5bffc
[ Fixes #5844 ] Using ExtensionIRNode for Inject directive
2017-03-01 09:45:47 -08:00
N. Taylor Mullen
acfad83aa6
Migrate to MSBuild
...
- thanx to @NTaylorMullen for initial conversion
- e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files
Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
- see 63507c8 for previous, project.json work
- apply dependency version downgrade from 0097e40 in *.csproj world
Make other test-related changes:
- make Microsoft.AspNetCore.Mvc.TestDiagnosticListener a regular class library
- add support for `/p:GenerateBaselines=true` for functional and Razor.Host tests
- separate `GetCSharpTypeName_ReturnsCorrectTypeNames_ForOutParameter()` test
- work around inability to deserialize a odd `ref` type
- xUnit and vstest now serialize / deserialze test data more often
- skip poor test mentioned in #5768
- work around Microsoft/vstest#392
- rename tests to avoid duplicates
- work around Microsoft/vstest#419
- set up created `AppDomain`s with current `ApplicationBase`
2017-02-28 21:20:39 -08:00
Stefan Nikolei
0e914e55fa
Remove double null check ( #5862 )
...
Address #5834
2017-02-28 12:00:23 -08:00
Pranav K
ae61c7005c
React to Microsoft.CodeAnalysis.Razor version change
2017-02-27 17:12:37 -08:00
Pranav K
de30c5822a
* Cache ExecutorFactory as part of CompiledActionDescriptor
...
* Add tests for ExecutorFactory
2017-02-24 11:56:13 -08:00
martincostello
498c1c570d
Update error message
...
Update error message based on PR feedback to less C# specific.
2017-02-23 14:21:58 -08:00
martincostello
9950325269
Update view compilation error message
...
Update view compilation error message for csproj instead of
project.json.
2017-02-23 14:21:58 -08:00
Steve Smith
f3b1f2ca29
Fixing doc comments
2017-02-23 11:13:34 -08:00
Ryan Nowak
e11e6b3be7
Add TempData property and some functional tests
2017-02-22 08:14:02 -08:00
Ryan Nowak
19331f9532
Adding some basic functional tests
...
I ran into a blocking issue where page handlers aren't picked up, so I
fixed it. Logging another issue to follow up with better tests for this.
2017-02-21 16:41:25 -08:00
Steve Smith
39f41eae3c
Fixing typo (an -> a)
2017-02-21 06:52:30 -08:00
Ajay Bhargav Baaskaran
11d747fc33
React to CSharpTokenIRNode being removed
2017-02-17 19:31:33 -08:00
Ajay Bhargav Baaskaran
0f5d5ff3b5
React to aspnet/Razor#1017
2017-02-17 16:01:54 -08:00
Jass Bagga
927e75870d
Add BindingSourceMetadataProvider
...
Addresses #5673
2017-02-17 13:22:10 -08:00
Ryan Brandenburg
366dbde378
Add culture constructor to RouteValueProvider
2017-02-16 14:47:34 -08:00
Ryan Brandenburg
239e2202e1
ActionContextAccessor netstandard behave like net451 ( #5810 )
2017-02-16 14:34:13 -08:00
Ryan Brandenburg
401296ac43
Remove unneeded InternalsVisibleTo ( #5809 )
2017-02-16 12:01:42 -08:00
Nate McMaster
0097e40e46
Downgrade to stable packages
2017-02-15 14:23:48 -08:00
Kiran Challa
a00acceaa9
Merge branch 'rel/1.1.2' into dev
2017-02-15 12:43:37 -08:00
Kiran Challa
29647fda33
[ Fixes #5801 ] Move call to validate constructor in ComplexTypeModelBinder into CreateModel
2017-02-15 12:33:01 -08:00
Ajay Bhargav Baaskaran
38e1e7d14e
React to aspnet/Razor#996
2017-02-14 15:11:39 -08:00
Pranav K
eb820106e2
Generate the class name from relative path
2017-02-14 09:41:05 -08:00
Ajay Bhargav Baaskaran
44048331e9
Make `ViewComponent.View()` overloads respect explicitly passed in model even when `null`
2017-02-13 17:08:48 -08:00
Pranav K
35edc299d7
Fix test failures
...
Fixes #5794
2017-02-13 12:03:10 -08:00
Ryan Nowak
2cdd84f437
Remove pranav's hack
...
This is part 1 of the right fix for the directive getting removed. This
pass has the wrong order, an it should be running sooner before the
directive is processed by the default processor.
2017-02-13 09:23:58 -08:00
Ryan Nowak
af5648c1f7
Merge branch 'rel/1.1.2' into dev
2017-02-13 08:34:18 -08:00
Ryan Nowak
531c11df2a
Fix 5594 - ExceptionHandled + Result is broken
...
This change ensures that setting ExceptionContext.Result will always
execute if set. The problem with 1.1.0 is that when we had a real short
circuit the wrong set of conditions were checked. I suspect that when you
set ExceptionFilter.Result and didn't short circuit that result filters
were also running (which is a bug).
Added a few tests that verify that the result doesn't trigger result
filters.
I did some general cleanup on this code path to make the state transitions
more clear.
No exception was thrown -> BeginResult
Exception was handled -> ExceptionHandled
Exception was not handled -> gets rethrown
2017-02-13 07:58:32 -08:00
Doug Bunting
4bddb5ff1b
Small follow up to 8ee3d45
...
- rename `containsIndexers` to `doNotCache` in `ExpressionHelper`
2017-02-10 16:46:55 -08:00
Doug Bunting
fc40985412
Merge branch 'rel/1.1.2' into dev
2017-02-10 14:55:32 -08:00
Doug Bunting
8ee3d45ef1
Do not cache expressions containing method calls
...
- #5655
- also make `ExpressionTextCache` more robust for defence-in-depth
nits:
- two `null` expression nodes are equal
- declare data properties as `TheoryData<T>`
2017-02-10 14:50:09 -08:00
Pranav K
1652bf554f
Workaround APICheck errors
2017-02-10 12:46:15 -08:00
Kiran Challa
842d661ac2
[ Fixes #5698 ] Regression in 1.1 model binding for model types without default constructor
...
- Also reverts "Check for default constructor in ComplexTypeModelBinderProvider" commit d09e921c4a .
2017-02-10 11:10:02 -08:00
Pranav K
bc3a741eee
Use DocumentClassifierPassBase
...
Workaround issue with the model directive disappearing
2017-02-09 20:30:31 -08:00
Pranav K
8b03e9ef73
Make PageStart work
...
Move more API to RazorPageBase
2017-02-09 18:23:01 -08:00
Ryan Brandenburg
bd9e431873
Order IgnoreAntiforgeryTokenAttribute and add test ( #5765 )
2017-02-08 09:37:43 -08:00
Pranav K
f474d8bc52
React to optional Razor directive token feature
2017-02-07 21:58:31 -08:00
Ryan Nowak
9264f3aa2d
Add TryUpdateModelAsync to pages
2017-02-07 21:16:40 -08:00
Ryan Nowak
314aa366e1
Add TempData property support for Pages
2017-02-07 15:27:02 -08:00
Pranav K
690ef186a3
Add PageActionDescriptorChangeProvider to allow reloading on page changes
2017-02-07 12:53:44 -08:00
Pranav K
2ff80ffb49
Porting DefaultPageHandlerMethodSelector and ExecutorFactory
2017-02-07 12:44:27 -08:00
Pranav K
624909763b
Make _PageImports work
...
Add support for generating the Model property
2017-02-07 11:13:15 -08:00
Pranav K
9f3dfd9819
Make RazorPages work E2E
2017-02-06 19:05:31 -08:00
Ajay Bhargav Baaskaran
c349929cc1
Port old Razor tests to new Razor
2017-02-03 17:09:18 -08:00
Pranav K
8d5abd433f
Add support for PageStarts
2017-02-03 15:57:00 -08:00
Kiran Challa
c95c2a5a6d
[ Fixes #5686 ] Extend `ModelMetadata` to reduce ugliness
2017-02-03 11:37:28 -08:00
Ryan Brandenburg
dc0be8d747
SaveTempDataFilter handle write to body
...
(cherry picked from commit 03cdd15e5c )
2017-02-03 10:41:36 -08:00
Ryan Nowak
cf70ed663b
Merge tag 'rel/1.1.1' into dev
2017-02-03 10:31:17 -08:00
Ajay Bhargav Baaskaran
1777f7babd
Enabling Razor Instrumentation
2017-02-01 15:29:09 -08:00
Ryan Nowak
4c62eb89af
Unit tests for VCTH and model directive
2017-01-31 13:14:20 -08:00
Ryan Nowak
705369ee51
Add unit tests for ModelExpressionPass
...
Add unit tests for @inject
2017-01-30 19:08:39 -08:00
Ryan Nowak
b79f8384b0
Make some methods public for ViewCompilation.
2017-01-30 13:46:27 -08:00
Ryan Nowak
84d2e027f5
Use new Razor in MVC
2017-01-30 10:55:49 -08:00
Jass Bagga
7449ffad74
Add include and exclude attributes to EnvironmentTagHelper
...
Addresses #5671
2017-01-27 14:46:53 -08:00
Joonas Westlin
d44c9aee1e
Added printing of route values when a route is not matched
2017-01-27 11:31:05 -08:00
Kiran Challa
17dc23a024
[ Fixes #5637 ] Make CookieName of CookieTempDataProvider configurable
2017-01-27 11:01:26 -08:00
Ryan Brandenburg
03cdd15e5c
SaveTempDataFilter handle write to body
2017-01-27 10:54:00 -08:00
Pranav K
3e214e2399
Introducing IPageModelActivatorProvider
...
Fixes #5480
2017-01-26 11:31:14 -08:00
Jass Bagga
9b1271ba19
Remove obsolete DefaultHtmlGenerator ctor ( #5711 )
2017-01-25 16:25:12 -08:00
Kiran Challa
42ae78a360
[ Fixes #5012 ] ProducesAttribute should not inherit from ResultFilterAttribute
2017-01-25 14:00:35 -08:00
Kiran Challa
8ac6b6699f
[ Fixes #4945 ] Simple string returned by controller action is not a valid JSON!
2017-01-25 13:29:18 -08:00
Ryan Nowak
5885feb7c0
Fixes a parsing bug with the AcceptHeaderParser
...
When we find an invalid character at the end of a media type value we
should advance and skip over it.
2017-01-23 13:12:40 -08:00
Ryan Brandenburg
305748a800
Move classes out of .Internal
2017-01-19 11:11:28 -08:00
Ryan Brandenburg
6396e14504
Add null-check back to MediaType
2017-01-18 16:56:08 -08:00
Jass Bagga
6f7fc4fb34
Remove obsolete ViewEngine ( #5699 )
2017-01-18 16:29:20 -08:00
Pranav K
24efd4268b
Pin the version of RazorTooling packages to 1.1.0-preview4-final
2017-01-17 11:55:15 -08:00
Pranav K
e749a80b30
Check for empty location in ViewsFeatureProvider
...
Fixes #5675
2017-01-17 11:07:48 -08:00
Doug Bunting
ce53675b87
Add `[ValidateNever]` and `IPropertyValidationFilter`
...
- #5642
- lazy-load `ValidationEntry.Model`
- avoids `Exception`s when moving to a property that will not be validated
nits:
- remove duplicate code in `ValidationVisitor`
- clarify "all properties of" doc comments
- also add missing `<param>` doc in `ViewDataInfo`
2017-01-15 21:40:29 -08:00
Jass Bagga
07c22f2b29
Mutate API description parameter type from JsonPatchDocument to Operation[]
...
Addresses #5464
2017-01-13 16:39:08 -08:00
Jass Bagga
f95d49c870
Change datetime to datetime-local
...
Addresses #4871
2017-01-13 15:40:30 -08:00
Ryan Brandenburg
93774a0234
Mitigate MediaType overflow
2017-01-13 12:51:19 -08:00
Pranav K
a7abdeabcd
Introducing PageActionInvoker
2017-01-13 11:49:02 -08:00
Pranav K
13b32adeae
Move InvokeAsync to ResourceInvoker
2017-01-11 11:13:05 -08:00
Pranav K
6b0282fa84
Commonize code from ControllerActionInvokerCache and PageFilterFactoryProvider
2017-01-11 10:53:23 -08:00
Jass Bagga
9cc20ff114
Edited docs, removed unnecessary usings for ApiDescription ( #5634 )
...
Addresses #5625
2017-01-04 17:44:47 -08:00
Jass Bagga
473337ea33
CompositeChangeToken moved to aspnet/Common Microsoft.Extensions.Primitives
...
Addresses Common Issue aspnet/Common#163
2017-01-04 17:32:20 -08:00
Kiran Challa
de0f277892
Fix attribute routing error message related to replace tokens
2017-01-04 15:43:57 -08:00
hiiru
5070526f43
replaced hardcoded message with Resources.ArgumentCannotBeNullOrEmpty
2017-01-04 10:47:21 -08:00
Pranav K
78492b39d8
Introduce a base type for executing auth and resource filters.
2017-01-03 11:14:15 -08:00
Pranav K
2b8233932a
Add IPageFactory and IPageActivator
2016-12-29 15:11:29 -08:00
Jass Bagga
9146fce4ec
Add extension method for IParameterModelConvention. ( #5640 )
2016-12-27 16:49:12 -08:00
Pranav K
2b50ec99df
Updating to 4.4 CoreFx packages
2016-12-21 16:47:14 -08:00
Ryan Brandenburg
b2340d327e
Order IgnoreAntiforgeryTokenAttribute and add test
2016-12-12 14:55:36 -08:00
Pranav K
cfa9631ce8
Resolve path traversals in RazorViewEngine
...
This change moves the onus of path resolution from individual IFileProvider instances to RazorViewEngine.
Fixes #5574
Fixes https://github.com/aspnet/MvcPrecompilation/issues/33
2016-12-08 11:20:06 -08:00
Steve Smith
de1b763d96
Update IControllerModelConvention.cs
2016-12-07 11:11:57 -08:00
Steve Smith
b2f0438562
Fixing comment typo
2016-12-07 11:10:54 -08:00
Steve Smith
6fbe514626
Fixing comment typos
2016-12-07 11:07:31 -08:00
Joonas Westlin
1dd1d49321
Redirects with fragment ( #5519 )
...
- Added implementation of overloads where you can specify the fragment to redirect to.
- Added unit tests
- Added XML comments, including missing documentation of existing members
2016-12-06 10:32:01 -08:00
Doug Bunting
7178464ed2
Munch on less memory when handling property metadata
...
- #5499
- switch `foreach` to `for` and use less Linq when accessing `modelMetadata.Properties`
- change backing field for `ModelExplorer.Properties` from a list to an array
2016-12-05 20:47:45 -08:00
Doug Bunting
48546dbb28
Add more to `MvcCoreServiceCollectionExtensionsTest`
...
- 2nd half of #5554
- follow-on to #5540 PR
2016-12-05 20:05:24 -08:00
Daniel Roth
f32d0f2505
Update MvcCoreServiceCollectionExtensions.cs
2016-12-05 20:01:30 -08:00
Ryan Brandenburg
8f8bf5af34
Seperate view and model for enum display
2016-11-30 11:13:38 -08:00
Pranav K
52ee9afc31
Adding PageActionDescriptorProvider
...
Fixes #5353
2016-11-23 16:53:06 -08:00
Pranav K
74c9194aee
Pinning versions for 1.1.0 release
2016-11-18 12:12:52 -08:00
Julian Dominguez
2bacb6003f
Fix typo in XML doc
2016-11-18 10:56:46 -08:00
Pranav K
975dc212b7
Fix package versions
2016-11-17 10:19:48 -08:00
Pranav K
c5a5ba1fee
Add support for updateable ActionDescriptorCollection
...
Fixes #5350
2016-11-17 10:08:38 -08:00
Pranav K
29cd24f66b
Add Microsoft.AspNetCore.Mvc.RazorPages projects
2016-11-17 10:08:38 -08:00
Pranav K
5deda80e5a
Downgrade Microsoft.Extensions.DependencyModel to 1.1.0
2016-11-09 18:16:49 -08:00