cf09af52eb
Remove duplicate type
2017-06-26 16:32:51 -07:00
4e004c22ba
React to options
2017-06-26 15:49:23 -07:00
f4a86f5511
Add DiagnosticSource to RazorView ( #6386 )
...
Addresses #6222
2017-06-26 15:35:31 -07:00
e5da44a82f
Generate full pdbs for views on desktop and re-enable runtime error tests ( #6442 )
...
* Generate full pdbs for views on desktop and re-enable runtime error tests
StackTraceHelper \ PortablePdbReader used by Diagnostics is only useful for
reading portable pdbs on disk. However pdbs produced by views are entirely
in memory and therefore cannot be read. Consequently
we choose to generate full pdbs for views on Windows (when possible).
2017-06-26 10:46:12 -07:00
052db40567
Fix documentation and target files issues
2017-06-23 19:09:45 -07:00
35152d5933
[ Fixes #6233 ] Productionize and harden our functional testing infrastructure
2017-06-23 18:12:41 -07:00
aa5a348385
_ViewStart.cshtml not picked up when added to the root of the app
...
Fixes #6308
2017-06-23 08:25:58 -07:00
0dfffd45c2
RazorPages page directives missing quotes should alert user
...
Fixes #5868
2017-06-22 15:13:38 -07:00
9d138affa2
Suppress JsonPatchDocument validation ( #6429 )
...
Addresses aspnet/JsonPatch#80
2017-06-22 14:14:11 -07:00
53fb676069
React to new page directive expectations.
...
- This will be reverted once https://github.com/aspnet/Razor/issues/1448 has been completed.
2017-06-20 12:53:23 -07:00
c89f0a1e43
Allow AddPageRoute to route to pages root. ( #6412 )
...
* Allow AddPageRoute to route to pages root.
Fixes #6338
2017-06-20 12:33:33 -07:00
3fc3d8d060
Merge branch 'rel/2.0.0-preview2' into dev-gate
2017-06-15 03:48:49 -07:00
0c6460ab64
Changed WebApiCompatShim projects to use PackageTargetFallback
2017-06-14 16:08:04 -07:00
8832014516
PackageTarget->AssetTarget
2017-06-14 15:03:43 -07:00
dfe04bc917
Fix #5979 - Remove hardcoding of tempdata for pages
2017-06-12 15:05:36 -07:00
6961cf9211
Cleanup unused precompilation code
2017-06-09 16:45:43 -07:00
b1b7252ddc
Merge pull request #6383 from aspnet/rel/2.0.0-preview2
...
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 15:11:23 -07:00
d92d8cddeb
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 14:40:29 -07:00
a5f3a6425e
Remove TaskCache and TaskCacheOfT
2017-06-08 08:19:20 -07:00
8662422e18
Merge pull request #6376 from aspnet/rel/2.0.0-preview2
...
Perform case insensitive lookups for precompiled views
2017-06-07 15:19:42 -07:00
1124eb5016
Perform case insensitive lookups for precompiled views
2017-06-07 15:19:21 -07:00
8f883e8e13
Use RazorViewAttribute \ RazorPageAttribute for view discovery
2017-06-07 13:49:24 -07:00
4bf20035e4
Merge remote-tracking branch 'origin/rel/2.0.0-preview2' into dev
2017-06-07 13:48:27 -07:00
2845e9b7d4
Add configuration package reference because Logging dropped it ( #6375 )
2017-06-07 13:47:39 -07:00
945661ad0e
Remove unused test sample project ( #6368 )
2017-06-06 15:56:31 -07:00
e51d3c262c
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 13:13:11 -07:00
3448b6a74e
Re-enable net461 functional tests.
...
aspnet/Coherence-Signed#540
2017-06-06 13:10:29 -07:00
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
f1dd475eae
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 09:35:33 -07:00
af91b58bd3
Enabled a way to buffer request body in formatters
2017-06-06 09:33:32 -07:00
628dfc39c1
Remove model type from RazorPageAttribute
2017-06-05 16:07:14 -07:00
20c04d099e
Update to use Razor parser to parse page directive
2017-06-05 14:02:24 -07:00
b796bc0f39
Add Page filters
2017-06-05 08:05:49 -07:00
06ca0d1e9c
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-02 12:29:33 -07:00
dbd340a5e0
Fix test
2017-06-02 12:28:56 -07:00
03e696a05e
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-01 15:19:13 -07:00
0f0cfdfe94
Removed unnecessary package references
2017-06-01 12:02:05 -07:00
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
597a0c9a11
Add support for friendly routes in pages
...
FIxes #6325
2017-05-26 14:29:00 -07:00
688e518991
Add result filters to pages
2017-05-26 12:33:46 -07:00
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
b7db6dbc8e
Remove pass-through activator for pages
...
This change removes a 'pass through' IRazorPageActivator that we were
using to avoid the default one initializing the Page twice.
The fix is to add an adapter so that the IRazorPage that the RazorView has
isn't the *real* page, it's the adapter. The adapter doesn't have anything
interesting to activate :).
2017-05-26 12:29:10 -07:00
c3f7613725
Make RazorReferenceManage public
...
Fix for #4938 . This change makes the reference manager public and
documented so that it can be replaced.
2017-05-26 10:58:45 -07:00
ad6b029443
Temporarily disable MVC functional tests on net461
2017-05-25 21:10:01 -07:00
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
452578e4a8
Revisit the architecture of CompilerCache
...
Fixes #5912
2017-05-25 08:54:15 -07:00
c1dd95be2a
Add a test for #6294
...
This case was fixed by 2992f8e
2017-05-24 16:53:30 -07:00
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
a6d97d35e3
Add back support for AddTagHelpersAsServices
...
This doesn't go through the Razor tag helper discovery pipeline because
this can really only ever work for ITagHelper based taghelpers. So
there's really no point in reusing that logic, which would be hard
anyway.
2017-05-23 14:04:42 -07:00
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
3c7a2dc847
Revert "Temporarily skipping error page middleware test"
...
This reverts commit d916cfeadd
2017-05-23 13:23:52 -07:00
e681c23d5c
Add ITagHelperComponentManager ( #6302 )
...
Addresses #6282
2017-05-23 13:22:15 -07:00
04f74edd85
Revert "Disable building and testing FSharpWebSite to unblock the mirror when using latest CLI"
...
This reverts commit b28002a9e5
2017-05-23 13:20:36 -07:00
39f1f5c933
Move Pages filter creation to application model provider
...
Fixes #6198
2017-05-23 11:03:19 -07:00
083f55e337
Delete pranav's test logs :)
2017-05-22 17:38:27 -07:00
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
9d38e2523c
Add methods to TagBuilder ( #6287 )
...
Addresses #5689
2017-05-19 12:23:16 -07:00
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
c8614e9aa8
Fix build break due to Razor changes
2017-05-18 10:58:43 -07:00
51c142ae91
Modify GetProperties overload ( #6276 )
...
Addresses https://github.com/aspnet/Common/issues/219
2017-05-16 13:34:14 -07:00
5662717983
Add null check in WriteLiteral
2017-05-15 15:08:50 -07:00
d70bfdd1ea
Upgrade test framework versions and fix test issues
2017-05-15 14:11:27 -07:00
b28002a9e5
Disable building and testing FSharpWebSite to unblock the mirror when using latest CLI
2017-05-13 19:32:51 -07:00
cf4742735d
Fix Build Break
2017-05-12 20:06:51 -07:00
b2d95ffb21
Remove usage of NotFoundProjectItem
...
We're making this type internal in Razor, using a mock here is fine.
Also renamed some types with a generic name. The actual 'default'
RazorProject class lives in Razor and is internal.
2017-05-12 15:55:36 -07:00
8f52507e9d
Fix build break
2017-05-12 15:53:49 -07:00
d916cfeadd
Temporarily skipping error page middleware test
2017-05-12 14:39:19 -07:00
b758a86a38
Modify ViewComponent_CannotFindComponent error message ( #6263 )
2017-05-12 14:15:29 -07:00
5eabae55cb
Added PushWriter and PopWriter to RazorPageBase
...
- Removed WriteXYZTo methods
2017-05-11 15:21:42 -07:00
08965550ad
Re-enable error page runtime test.
...
- This was previously broken due to the shared framework not being able to find the file responsible for an exception.
#6120
2017-05-10 14:33:10 -07:00
cf64b335f6
Remove unnecessary package references ( #6252 )
2017-05-10 12:06:10 -07:00
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
debc3dd433
Functional test to show FSharpAsync works end-to-end ( #6240 )
2017-05-08 19:30:01 +01:00
3164046233
Merge branch 'rel/2.0.0-preview1' into dev
2017-05-05 20:00:12 -07:00
f0a26a7f08
Migration2
2017-05-05 19:59:45 -07:00
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
87bb1d0ff5
Refactor GenerateCheckBox ( #6229 )
...
Addresses #5981 and #5983
2017-05-05 11:53:53 -07:00
a80594d706
Add FSharpWebSite plus simple functional test against it ( #6231 )
2017-05-05 19:08:36 +01:00
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
525a479660
Fixing ExcludeBindingMetadataProvider unit test ( #6113 )
...
Fixes #6110
2017-04-27 11:42:06 -07:00
8bece90c83
Fix asp-page-handler to generate form tags correctly.
...
- Prior to this change using asp-page-handler on its own did not create correct `<form>` elements. There were multiple issues, one as that the `FormTagHelper` would purposefully drop into a no-op code path. Second is the `DefaultHtmlGenerator` didn't call through to the `UrlHelper` correctly.
- Added functional test cases to validate asp-page-handler can live on its own on a form tag. This also included adding a variant where method="post".
- Added a `FormTagHelper` unit test to validate the `PageHandler` property is consumed properly.
#6208
2017-04-27 10:32:04 -07:00
b1b3a816cc
Rename View() to Page()
...
This requires us to introduce another base class between RazorPageBase and
Page - you need this because you aren't allow to have Page.Page().
2017-04-27 09:27:14 -07:00
f165914b40
Update how `FormTagHelper` handles `get` method attributes.
...
- Added functional test to verify `asp-*` attributes on form taghelpers work as expected.
- Added a unit test to validate `FormTagHelper` behaves as expected.
- Moved `Method == "get"` checks into appropriate code paths. These include the one where a user specifies an empty or non-existent `action` attribute and where a user doesn't utilize any `asp-*` attributes. In the later, we default `Method` to `"get"` if it's not provided.
#6006
2017-04-25 15:17:15 -07:00
ce4e94c1ac
Use Bundled NETStandard.Library \ NETCoreApp versions instead of explicitly specifying one
2017-04-25 12:50:48 -07:00
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
ef0333ac6a
Add Antiforgery to the FormTagHelper pre-check for processing.
...
- Added a test case to the HtmlGeneration functional test (the one verifying complex FormTagHelpers).
- Added unit test verifying antiforgery behavior when it's the only provided parameter.
#6006
2017-04-24 21:46:54 -07:00
5c8a161ace
Change `FormTagHelper` to apply to all form tags.
...
- Added functional test to validate that non-attributed form tags have an antiforgery input generated. Re-generated baseline to reflect changes.
- Added a unit test to validate that parameterless `FormTagHelper`s behave as expected.
#6006
2017-04-24 18:39:01 -07:00
ccdaa5a729
Make /Pages the default root for pages.
...
Fixes #6184
2017-04-24 15:46:32 -07:00
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
cacee2a837
Break fix: Undo part of 141b637
...
- affected test using a test factory for `HttpResponseStreamWriter`s
2017-04-23 21:48:42 -07:00
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
68866f8716
Added functional tests for JsonPatch
2017-04-23 09:09:08 -07:00
ca017eced2
Add page to AnchorTagHelper and FormTagHelper
...
Fixes #6088
2017-04-21 18:12:54 -07:00
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
297196baa0
Design updates to handler methods and binding
...
Implements #6091 , #6072 , #6090 , #5927
2017-04-21 17:29:25 -07:00
908b4c8d62
FormAction from QueryString
2017-04-21 15:04:37 -07:00
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
83faaebdb6
Upgrade Roslyn dependency to 2.0.0.
...
- Added C# 7 unit and functional test to validate features work end-to-end.
#6149
2017-04-21 11:41:31 -07:00
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
5a184df808
Remove Binder from Page and PageModel
2017-04-20 17:54:50 -07:00
f4d84f50cd
Upgrading Moq to 4.7.1
2017-04-20 17:07:50 -07:00
681b798a2e
RedirectToPage doesn't trim /Index from URL
...
Fixes #6080
2017-04-20 11:15:45 -07:00
a975d7fa01
react to removal of PlatformAbstractions ( #6164 )
2017-04-20 11:09:18 -07:00
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
a8eb5bee70
Implement view search for pages
...
The View Engine now needs to know about pages :(. This isn't ideal but the
view engine needs to know what set of search paths to use. This was
already hardcoded for controllers vs controllers + areas. It felt right to
further hardcode instead of introduce a wierd abstraction that we only
use.
Additionally pages use a view location expander to implement an ascending
directory search.
2017-04-18 16:11:24 -07:00
c56b64fc41
Add factory methods
2017-04-17 16:11:34 -07:00
8ed55107e7
Add support for page precompilation
2017-04-17 10:43:50 -07:00
e766a259ed
Revert "Skip test `AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet`"
...
This reverts commit c69e48f06b
2017-04-14 18:41:31 -07:00
49628bca2e
Use case invariant lookups for DependencyModel to workaround CLI version differences
2017-04-14 17:03:20 -07:00
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
c69e48f06b
Skip test `AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet`
...
- Workaround for "Can not find compilation library location for package" (https://github.com/dotnet/cli/issues/6318 )
2017-04-14 15:37:54 -07:00
ed3aa4d918
Adding functional tests for @namespace
2017-04-14 14:47:29 -07:00
3eae7cc393
Add AggregateExceptionTest ( #6135 )
...
Test for aspnet/Common#215
2017-04-14 14:20:31 -07:00
d8a95c731b
Move RazorViewEngineOptionsSetup to internal namespace ( #6125 )
...
Addresses #6116
2017-04-13 13:35:35 -07:00
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
dfbf6d43ff
Temporarily skipping ReferenceAssemblies_ReturnsLoadableReferenceAssemblies
2017-04-12 14:31:21 -07:00
3474bdf776
RedirectToPage from a form-action handler includes the formaction
...
Fixes #6104
2017-04-12 09:27:08 -07:00
106b34867d
Temporarily skipping ErrorPageMiddleware functional test to unblock mirror
2017-04-11 17:40:01 -07:00
59a3aade9b
Fix [TempData] for PageModel's
2017-04-11 16:45:44 -07:00
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
36e272fdc2
React to Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore.Razor.Language.
...
aspnet/Razor#1169
2017-04-10 10:20:19 -07:00
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
1e7972bd8f
Add convenience methods for redirecting from a Razor Page back to itself
...
Fuxes #5953
2017-04-07 10:03:42 -07:00
4032de064e
Removing _PageStart.cshtml
...
Pages now also use _ViewStart.cshtml
Also contains some naming/text cleanup that was missed in the previous
commit.
2017-04-06 08:14:37 -07:00
c6e4609096
Getting rid of _PageImports
...
Pages will just use _ViewImports.
2017-04-06 08:14:37 -07:00
9e8d4db7d8
Move TempDataPropertyProvider into filter
2017-04-05 12:04:02 -07:00
3424e20c67
Re-enable skipped test
2017-04-04 19:25:50 -07:00
925ad75cdf
Add convenience methods for redirecting to another Razor Page
...
Fixes #5956
2017-04-04 14:36:22 -07:00
2d19a82678
Update more resource designer files
2017-04-04 13:54:20 -07:00
e5ccac8bf6
Add functional tests for RazorPage routes
2017-04-04 11:14:52 -07:00
3ab9feca3a
Temporarily skipping failing test
2017-04-03 23:24:09 -07:00
19cb15be54
Revert "Skipping model validation tests temporarily to unblock mirror"
...
This reverts commit e25bfa8919
2017-04-03 17:13:49 -07:00
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
fe3d45fad1
Adding AllowAnonymousToPage & AllowAnonymousToFolder
...
Fixes #5884
2017-03-31 20:17:31 -07:00
2cabd589ac
Add more `ExpressionHelper` tests
...
- #5792
2017-03-31 15:22:29 -07:00
e25bfa8919
Skipping model validation tests temporarily to unblock mirror
...
- A fix was already checked in f3d0e4d0dd
2017-03-31 12:38:10 -07:00
951341f612
Add a comment for our cool workaround
2017-03-31 11:19:22 -07:00
7904c7756d
Add a simple action selection benchmark
2017-03-31 11:19:22 -07:00
7d4ccd9c58
Add benchmark project and boilerplate
2017-03-31 11:19:22 -07:00
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
5fca8da665
React to razor changes
2017-03-29 16:45:37 -07:00
Hao Kung
Jass Bagga
Pranav K
Javier Calvarro Nelson
N. Taylor Mullen
Kiran Challa
Ryan Brandenburg
Ryan Nowak
Pavel Krymets
Nate McMaster
Chris R
Ajay Bhargav Baaskaran
Nate McMaster
Steve Sanderson
John Luo
Sébastien Ros
Doug Bunting
Christopher Dresel
Andrew Stanton-Nurse
Mike Harder
Hisham Bin Ateya