Commit Graph

17675 Commits

Author SHA1 Message Date
alewmt 90231e7290 Fix invalid test (#6654) 2019-08-23 18:32:00 -07:00
Nikolaj Jørgensen 20dd338b79 Use ModelOnly for Validation Summary (#6108)
Previously when Validation Summary used "All", it would append the property-related content to both the summary as well as the property specific span elements (= asp-validation-for="...").

By switching to ModelOnly would only show model-related messages in the summary (such as "Invalid login attempt.") which was most likely the original intention.
2019-08-23 18:30:59 -07:00
Brian Friesen 8b861ea7d7 Add CreateXmlReader overload - adds Type parameter (#13302)
* Add CreateXmlReader overload - adds Type parameter

This change allows inheritors of XmlSerializerInputFormatter to return a different XmlReader depending on the type being serialized. For example, an inheritor could return XSD-validating readers that validate against one schema or another (or perhaps not validate at all), depending on the value of the type parameter.
2019-08-23 15:32:25 -07:00
Mikael Mengistu 5c05b9288a
Fix User Agent on .NET Client (#13298) 2019-08-22 16:45:05 -05:00
Mikael Mengistu e0f95cfa6f
Set the user agent header in the Java client (#13168) 2019-08-21 16:15:39 -05:00
Ben Adams 5b2f3fb5f7 Betterize Hosting Log (#10102)
* Handle encoding
* Encode space only as +
2019-08-19 18:43:59 -07:00
Brennan 8987cca7c9
HubConnection implements IAsyncDisposable (#13179) 2019-08-19 09:36:43 -07:00
David Gardiner 7118601f4c Correct the spelling of 'EnableEndpointRouting'
Fixes #11467
2019-08-17 15:42:24 -07:00
Brennan 7795537181
Use relaxed encoder for Json (#12589) 2019-08-15 16:30:07 -07:00
Stafford Williams 6b4a101ca7 Crankier server (#12406)
* move server into Crankier
* added ConnectionCounter
* allow logging
2019-08-15 16:19:37 -07:00
N. Taylor Mullen 6699353dc6
Merge pull request #13177 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-15 16:14:18 -07:00
Stephen Halter 72925ecc19
Merge pull request #13079 from aspnet/halter73/13020
Throw NotSupportedException given FileHandleEndPoint
2019-08-15 14:58:49 -07:00
N. Taylor Mullen f890c9104c Improves further on Blazor reconnection experience.
- Expanded `ReconnectDisplay` to have a `rejected` method on it. This is the method that indicates we will never be able to reconnect to the server. By default we provide a nice little message letting users know that reconnection is no longer possible and that a refresh must take place.
- Added a logger to the `DefaultReconnectionDisplay` since part of its job is handling `Retry` clicks which indirectly call `reconnect()`. Therefore, it needed the ability to log information to the console to inform users why certain reconnects were not possible.
- Updated the `UserSpecifiedDisplay` to have a `refused` understanding. Added a new CSS class to represent the `refused` state as well.
- Updated existing tests to abide by the new `ReconnectDisplay` structure
- Added a new test to validate that the `refused``ReconnectDisplay` method results in proper behavior.

#12442
2019-08-15 14:17:35 -07:00
Brennan 3d9311a29f
Remove value span usage (#12990) 2019-08-15 14:09:05 -07:00
Pranav K 4144eeb459
Merge pull request #13169 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-15 10:44:07 -07:00
Pranav K b2a0b02e35
Update runtime compilation to target CSharpLang v8.0 by default (#13110)
Fixes https://github.com/aspnet/AspNetCore/issues/9129
2019-08-15 09:18:41 -07:00
Justin Kotalik 417cba2d50 Microsoft.AspNetCore.App =>Ref in the platform manifest (#13129) 2019-08-15 08:48:06 -07:00
Brennan 5e575a3e64
Merge pull request #13136 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-15 08:28:49 -07:00
Justin Kotalik f70eef0db1
I don't know how to write debug asserts (#13134) 2019-08-15 08:27:39 -07:00
N. Taylor Mullen 10452bf783 Improve Blazor reconnection experience.
- Updated text of reconnect dialog to be more clear.
- Added user feedback to the `Retry` event button click. The current flow is `Attempting to reconnect` -> `Failed to reconnect ... [Retry]` -> Click Retry -> `Attempting to reconnect`.
- Found that in cases where the server went away entirely the reconnect event would through unexpectedly preventing the reconnect display from handling a failed reconnect. Added a separate error flow to understand when the server went away/could not start a SignalR connection to.
- Could not find a great way to add tests for this scenario.

Addresses #12442
2019-08-14 16:27:00 -07:00
Ryan Nowak 13fc89ce49 Dispose DI scope with async support in circuit host
Fixes part of #12918

This fixes the part of this issue that we're going to be able to do in
3.0 safely.
2019-08-14 15:24:02 -07:00
N. Taylor Mullen e5a950de97 Re-enable reconnection failed invocation validation test.
- Relaxed the `maxRetries` and `retryIntervalMilliseconds` parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578
2019-08-14 14:47:33 -07:00
Ajay Bhargav Baaskaran c605d6cf63
Don't release SemaphoreSlim when it is canceled (#12818)
* Don't release SemaphoreSlim when it is cancelled

* fixed tests

* Rebased

* Updated ref

* mark test as flaky
2019-08-14 12:40:44 -07:00
Ryan Nowak 1f7d59d8f1 Remove IComponentContext
Fixes part of: #12553

We don't believe that this is needed anymore. We no longer call
OnAfterRender when you're prerendering, so the main use case of this
type is gone.
2019-08-14 12:06:05 -07:00
Pranav K a285e966e3
Mark InteropReliabilityTests flaky again (#13130) 2019-08-14 11:15:17 -07:00
John Luo ed360e171a fix npm flake (#13106) 2019-08-14 07:48:34 -07:00
Javier Calvarro Nelson 74c09470c6
[Blazor][Fixes #12056] Avoid producing warnings for bad inputs.
* Does not produce warnings when receiving invalid event arguments.
* Does not produce warnings when receiving an invalid event handler id.
* Does not produce warnings when receiving an ack for an unknown batch.
2019-08-14 13:01:53 +02:00
Mikael Mengistu e7a1dc620b
Update SignalR Sample (#13078) 2019-08-13 15:12:31 -07:00
N. Taylor Mullen 1f0641f5c0 Reset endpoint and route values during exception handling.
- We initially did this change as part of EndpointRouting but the impact of that change resulted in a variety of performance regressions. To mitigate the impact of resetting state for a request we now only reset the state when an exception has occurred in a way that does not require any additional state machines to be allocated.
- Added a test to validate that http context state gets reset on exception handling.

#12897
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 4f6022323b Revert "Fix endpoint routing statefulness."
This reverts commit 9a6881b0e8.
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 44431151c7 Revert "Addressed code review comments."
This reverts commit 479d5ed40a.
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 18391dd2e4 Revert "Clear route values after middleware invocation."
This reverts commit c54a7209d7.
2019-08-13 13:27:36 -07:00
Pranav K 44cfe01a89
Merge branch 'master' into merge/release/3.0-to-master 2019-08-13 13:03:17 -07:00
Steve Sanderson e8917fc92f [Blazor][Fixes #13056] Renderer use-after-disposal tweaks
* Improves Renderer handling use after disposal.
* Ensures RemoteRenderer skips resuming the render queue after ACK if it was since disposed
2019-08-13 21:51:39 +02:00
Pranav K 9bd027aa99
Make Partial on PageBase and PageModel work correctly (#13013)
* Make Partial on PageBase and PageModel work correctly

Fixes https://github.com/aspnet/AspNetCore/issues/10438
2019-08-13 12:49:10 -07:00
Pranav K c80f7d1dd9
Remove LangVersion from server-side Blazor project template (#13094)
Fixes https://github.com/aspnet/AspNetCore/issues/9168
2019-08-13 12:33:23 -07:00
Steve Sanderson 6b2d9f23f8
Prerender select elements with value; move HtmlRenderer into Mvc.ViewFeatures (#12996) 2019-08-13 09:34:28 +01:00
Javier Calvarro Nelson 826ed7504b
[ApiAuthorization] Update to latest oidc-client and IdentityServer4 versions
[ApiAuthorization] Updates dependency versions
* Updates to the latest version of Identity Server.
* Updates to the latest version of oidc-client.
* Removes unncessary code from the templates.
* Updates EF migrations.
* Removes unnecessary ref assembly.
2019-08-13 08:53:41 +02:00
Brennan eb966eb605
Complete upload streams on connection close (#13065) 2019-08-12 20:46:20 -07:00
Stephen Halter 4bb8a79efb
Update src/Servers/Kestrel/Transport.Sockets/src/SocketsStrings.resx 2019-08-12 19:28:29 -07:00
Ryan Nowak 1f4341a248 Add 'firstTime' parameter to OnAfterRender
Fixes: #11610

I took the approach here of building this into `ComponentBase` instead
of `IHandleAfterRender` - *because* my reasoning is that `firstTime` is
an opinionated construct. There's nothing fundamental about `firstTime`
that requires tracking by the rendering, it's simply an opinion that
it's going to be useful for component authors, and reinforces a common
technique.

Feedback on this is welcome.
2019-08-12 18:35:39 -07:00
Ryan Nowak 29cf7ecb80 Remove Blazor VSIX
This is no longer shipped, because the templates installed by `dotnet
new -i` show up in VS now. Removing it now so we don't have to keep it
around in servicing forever.
2019-08-12 18:32:02 -07:00
Stephen Halter d299dff853 Throw NotSupportedException given FileHandleEndPoint
- Kestrel's default socket transport does not support FileHandleEndPoint
- Throw a NotSupportedException instead of a NotImplementedException
2019-08-12 17:42:55 -07:00
Steve Sanderson a4ab9ffa05 Factor out auth and forms. Fixes #12950 (#12999)
* Add empty Authorization src and test projects

* Add references

* Move auth types into .Authorization project

* Move auth tests

* Fix Mvc.ViewFeatures

* Remove the reference from .Web to .Authorization, so it's truly optional

* Add empty Forms src and test projects

* Remove dependencies from Components.csproj

* Move forms sources and tests

* Reference .Forms from .Web (needed unless we also have .Forms.Web)

* Rebase on #12936

* Update reference assemblies

* CR: Add Authorization namespace

* Update ref sources

* Add missing using

* Add another missing using
2019-08-12 16:36:27 -07:00
Steve Sanderson c6f043cb98
Update Mono debug proxy code (#13053)
This is now equivalent to Mono's commit 612e064 and to the Mono binaries that we'll include in Preview 9
2019-08-12 17:10:30 +01:00
Brennan 7b7c13c0d5
Try to make test more reliable (#12989) 2019-08-11 20:23:18 -07:00
Ryan Nowak 5d4c4d648f Make WaitAssert report browser errors
It turns out we frequently have errors in the browser console in cases
where we're hitting a "timeout".
2019-08-11 10:49:14 -07:00
Ryan Nowak ab006e10b0 Harden ArrayBuilder
Since we're using the ArrayPool, it's really essential that we prevent
use-after-free bugs. I'm currently tracking one down.
2019-08-11 10:49:14 -07:00
Ryan Nowak 89bf58445f Use a ConcurrentDictionary
This is used from a bunch of static methods. Dictionary isn't thread
safe. Encountered this while debugging some other things.
2019-08-11 10:49:14 -07:00
Ryan Nowak 9b4ec6ec71 Add semaphore to selenium tests
This change prevents thread pool starvation when running a bunch of
selenium-based tests, by turning the blocking wait for a WebDriver to
start into an async wait.

This also seems to help with speed, and reliability since we're not
running too many browsers at once. I was experencing timeouts, and
seeing them in the debugger while running tests locally, this no longer
happens.
2019-08-11 10:49:14 -07:00