Commit Graph

20668 Commits

Author SHA1 Message Date
Steve Sanderson 8c23b53bef
Make timezone and ICU data available offline for PWA (#25954) 2020-09-16 16:49:09 -07:00
dotnet-maestro[bot] 9675fdb455
[release/5.0-rc2] Update dependencies from dotnet/arcade (#25963)
[release/5.0-rc2] Update dependencies from dotnet/arcade


 - Update create light/light command package drop task

 - Create output directory
2020-09-16 22:08:01 +00:00
Brennan ce76ae75f6
Fix Java packaging (#25838)
* Fix Java packaging

* fix flaky test
2020-09-15 10:20:43 -07:00
John Luo d14e273015
[5.0.0-rc2] Backport Fix chrome/selenium tests (#25330) (#25840)
* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f1504128a63431cb67830703922cdeefee525.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-14 18:43:42 -07:00
Kevin Pilch e3a52ee3de
Merge pull request #25881 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-14 15:24:14 -07:00
Pranav K a6f667bbb3
Add SkipAnalyzers=true to component declaration compilation (#25736)
* Update to latest SDK

* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes

* Add SkipAnalyzers=true to component declaration compilation
Fixes https://github.com/dotnet/aspnetcore/issues/25365

* Update eng/Version.Details.xml

* Update Versions.props

* Update Version.Details.xml

* Update Versions.props

* Update Version.Details.xml
2020-09-14 12:41:37 -07:00
Martin Costello a0ede85a61
Fix MSB4109 (#25880)
Fix MSB4109 error when the Microsoft.Extensions.ApiDescription.Server NuGet package is installed.
2020-09-14 12:07:15 -07:00
Doug Bunting 6c29f44a0b
Reduce references to Microsoft.AspNetCore.App.Runtime.csproj (#25836)
- dotnet-watch builds against runtime in the SDK
- other projects build after runtime project due to Ref.csproj reference
  - but, when the targeting packs aren't building, there's no reason to use Ref.csproj
- followup on 76fbd1a283 and 84962660a3, reducing parallelism in build
2020-09-14 11:34:07 -07:00
Steve Sanderson ccbc46c076
Fix RCL template to have correct filename for scoped CSS (#25870) 2020-09-14 09:13:49 -07:00
John Luo 472e8297a7
Update identity web templates (#25834)
* Update identity web templates

* Do not generate scopeRequiredByApi if not needed
2020-09-14 07:58:03 -07:00
Doug Bunting e3b632894d
Fix Helix testing issues with stable versions and local builds (#25865)
- include all shipping packages in Helix payloads that need runtime
  - remove hard-coded `-ci` that broke Helix tests with stable versions or local builds
  - for local builds, do not assume `$(Configuration)` is Release
- support `$(HelixTargetQueues)` property used in RunHelix.ps1
  - lost somewhere along the lines; script ran full matrix

nits:
- clean up redundant addition of runtime and ref/ packages
  - `@(HelixContent)` additions in `_CreateHelixWorkItem` target are ignored
- mention '+' separation of `-HelixQueues` argument to RunHelix.ps1
- allow `$(IsUnitTestProject)` override in case we need it in the future
2020-09-13 21:45:23 -07:00
Pranav K ab5dfe5374
Allow dotnet-watch to look for changes to .razor.css files (#25792)
Fixes https://github.com/dotnet/aspnetcore/issues/25483
2020-09-13 14:46:47 -07:00
Doug Bunting b760d35b54
Support override of PlatformManifest.txt content in servicing (#25849)
- copied from release/3.1; not sure why this wasn't merged forward
- doing now ensures we don't forget if we need to service targeting packs
2020-09-13 11:40:09 -07:00
Pranav K 99496b41a0
Nullability feedback for public types in Components (#25821)
* EventCallback.InvokeAsync can pass a null value
* Remove unused BindFormatterWithFormat
2020-09-13 10:01:21 -07:00
Javier Calvarro Nelson b1e1aabc9d [Mvc] Fix global state in controller and action endpoint data sources.
* Create data sources "per router" instance.
* Make a global shared order sequence "per router" for conventional and
  controller and page routes.
* Create DynamicControllerEndpointSelector and DynamicPageEndpointSelector
  instances per data source.
2020-09-12 10:03:32 -07:00
Javier Calvarro Nelson a17842a2e4 [Mvc] Add support for order in dynamic controller routes (#25073)
* Order defaults to 1 same as conventional routes
* An incremental order is applied to dynamic routes as they are defined.
2020-09-12 10:03:32 -07:00
James Newton-King 340ee72715
Update gRPC version in template to 2.32.0-pre1 (#25587)
* Update gRPC version in template to 2.32.0-pre1

* Log server timeout detail

* Only run interop tests on windows queues

Co-authored-by: John Luo <johluo@microsoft.com>
2020-09-11 20:23:16 -07:00
Doug Bunting 326507bb01
Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790)
* Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values
- Ensure `$(SharedFxVersion)` doesn't change in `$(NoSemVer20)` projects
- Ignore current project's `$(VersionSuffix)` in `$(TargetingPackVersion)`
    - Never assume `$(AspNetCoreBaselineVersion)` matches released targeting pack
- Stabilize both versions correctly
- Use these properties more widely
    - Remove other mechanisms to get the same values
    - Reduce use of the `_GetPackageVersionInfo` target
    - Reduce use of `$(SharedFxVersion)` for the targeting pack

nits:
- Correct comments about old RTMVersions.csproj project
- Fix or remove a few other comments

* Do not pass package filenames on Helix command Lines
- remove parsing of these command-line arguments from `RuntestOptions`
  - instead craft the names using passed `$(SharedFxVersion)`
- restore `$(DotNetRuntimeSourceFeedKey)` on Helix command line
  - lost somewhere along the line
- correct argument count in runtests.sh
  - treated 11th argument as both Helix timeout and feed credential
  - count was messed up somewhere alone the line

nits:
- update C# syntax in `RuntestOptions` e.g. remove unused `public` setters
- sort and group properties and their assignments
2020-09-11 19:17:28 -07:00
Chris Ross b5515a8dac IIS: Identify if a request has a body (#25381) 2020-09-11 17:43:36 -07:00
Pranav K 004cd1a9d9
PR feedback for platform compatibility update (#25815)
* PR feedback for platform compatibility update

Follow up to https://github.com/dotnet/aspnetcore/pull/25421

* Add SupportedOSPlatform attributes to a few more DataProtection API
* Update the SDK to rc2
* Clean up warning suppression in CertificateManager
* React to nit feedbacks

Fixes https://github.com/dotnet/aspnetcore/issues/25781

* Apply suggestions from code review
2020-09-11 14:32:02 -07:00
Stephen Halter 3932156a95
Improve Http1ContentLengthMessageBody's reset logic (#25799) 2020-09-11 13:57:23 -07:00
Brennan 9eb9de6c8c
[Java] Catch errors from user callbacks (#25513)
* [Java] Catch errors from user callbacks

* test logger

* rebase

* fb
2020-09-11 11:44:00 -07:00
Chris Ross 4383118ef8
IIS: Identify if a request has a body (#25381) 2020-09-11 11:40:25 -07:00
Brennan 83e31342a1
[Kestrel] Deflake app abort test (#25484)
* [Kestrel] Deflake app abort test

* better

* fb
2020-09-11 10:53:45 -07:00
William Godbe f7a76173e4
Re-enable Helix tests for signalR java client (#25783)
* Re-enable Helix tests for signalR java client

* Change path to test results
2020-09-11 10:26:49 -07:00
William Godbe 77be06a894
Support primitive type/classes in HubConnection.on() (#25773)
* Support primitive type/classes in HubConnection.on()

* Small refactor

* Spacing
2020-09-11 10:11:29 -07:00
William Godbe 84962660a3
Strip duplicates from BuiltProjectOutputGroupOutput (#25785) 2020-09-11 10:11:10 -07:00
Brennan c32089a5e2
Add SignalR Client on WASM smoke test (#25526)
* Add SignalR Client on WASM smoke test

* Move test into BasicTestApp

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-11 09:23:08 -07:00
Brennan 2ab6436cdd
Set ShutdownTimeout in Kestrel tests (#25743) 2020-09-11 09:21:18 -07:00
Brennan a7d129cc97
Send CloseMessage in more cases (#25693)
* Send CloseMessage in more cases

* fb
2020-09-11 09:21:02 -07:00
Chris Ross 11b85eb7e2
Add Windows.10.Amd64.Server20H1.Open helix queue (#25627) 2020-09-10 19:36:42 -07:00
Sayed Ibrahim Hashimi 118d6b2986
Updating titles in project templates because in Visual Studio the (#25630)
templates will be showing the templates directly in the New Project
Dialog instead in the One ASP.NET dialog.

In this PR I have updated the English titles. For localized strings we
will need to get those from the localization team. I believe we are not
setup for that to be automated here.

I think we should merge the English strings because they are the most
used, and for other locales we will show the old localized names for
now. If it's difficult to get those localized, I can work with @phenning
to see if we can localize those files this time.
2020-09-10 18:46:32 -07:00
Brennan 970d0f5d00
[SignalR] Copy cookies from negotiate to WebSockets (#24572) 2020-09-10 18:22:14 -07:00
Stephen Halter 327d55d01c
Prevent ODE when response body isn't reset (#25779) 2020-09-10 18:14:08 -07:00
Pranav K 5aa4a7cd41
Avoid using PATH to find dotnet.exe in RazorSDK tasks (#25750)
This pattern is pretty identical to what we have in other SDKs. It allows
using the SDK when dotnet isn't in the path such as the https://github.com/dotnet/aspnetcore/issues/25746.

Fixes #14432
2020-09-10 16:30:55 -07:00
Pranav K 18d261b20c
Use T? for unconstrained nullable types (#25772) 2020-09-10 15:15:11 -07:00
Pranav K 36f8642f0b
Use T? for unconstrained nullable types (#25261)
* Use T? for unconstrained nullable types

* Apply suggestions from code review
2020-09-10 15:14:30 -07:00
Pranav K 690c717314
Update to latest SDK (#25421)
* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes
2020-09-10 15:12:17 -07:00
Zachary Becknell fa2a5076e4
Add option to specify hostname in BrowserRefreshServer (#25572)
* Add option to specify hostName for refresh server

* Update env variable name per suggestion

Co-authored-by: Pranav K <prkrishn@hotmail.com>

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-10 15:10:47 -07:00
Ken Egozi cc0665cb6f
TypeReference usage clarification (#25719)
This change makes TypeReference usage a little bit easier

- Marking it abstract make it so that usages cannot "forget" subclassing (or omitting the { } part). Previously the error message would be confusing as the supertype would be Object.
- Removing the instanceof check and relying on exception since instantiating TypeReference without a type parameter (new TypeReference() ) *is* exceptional as it goes against the intention of this class altogether.
- Added some clarification to the javadoc regarding intended usage, and a link to prior art for further reading.
2020-09-10 15:02:21 -07:00
Kevin Pilch 3692e122ff
Add Public API baselines for Razor (#25637) 2020-09-10 13:27:09 -07:00
Pranav K 09160a779f
Use JsonSerializerDefaults instead of specifying individual options (#25747)
This lets MVC use the defaults as specified by System.Text.Json. Right now, these defaults are identical
to the two properties that were removed. However this allows MVC to pick up new S.T.J defaults in 6.0 including when
users attempt to use a 6.0 versioned package with 5.0
2020-09-10 11:54:00 -07:00
Kevin Pilch 848f42df8e
Add public API baselines for SiteExtensions, Testing, WebEncoders (#25654) 2020-09-10 11:45:01 -07:00
Kevin Pilch 158401f361
Add public API baselines to SignalR (#25653) 2020-09-10 11:44:04 -07:00
Juan Hoyos dda1d33f7b
Enable ARM64 installers build. (#25579)
Changes WiX toolset used to 3.14 to support ARM64
Generates targeting pack from the x86/x64 leg, as it gets produced using a zip that gets generated there.
The ARM64 leg now produces all the necessary msi's, exe, and wixlib needed for the installer to generate a bundle.
2020-09-10 10:59:37 -07:00
Javier Calvarro Nelson 31fcc8bd26
Update error page (#25706) 2020-09-10 10:20:19 -07:00
Javier Calvarro Nelson 0637599517
Update DfaMatcherBuilder to use the correct behavior (#25616) 2020-09-10 10:18:32 -07:00
Pranav K 2228c98b88
Use ICU sharding (#25521) 2020-09-10 10:17:02 -07:00
Kevin Pilch 6828192780
Add public API baselines for Servers (#25652) 2020-09-09 21:07:55 -07:00
Kevin Pilch 14a3862f5f
Add Public API baselines for Security (#25651) 2020-09-09 21:07:15 -07:00