Fixes#26301
As part of 5.0-preview8, we added Swashbuckle to ASP.NET Core's API project templates. Swashbuckle's developer
team has been active of late and has issued a new minor version that has enhancements and bug fixes. We'd like
to pick this up.
Users currently see a package update prompt on a brand new template. Missing useful bug fixes with the current version.
No
Low. This a minor version update that is recommended by Swashbuckle. I verified the update locally, our tests verify that the template builds and is usable with this change.
We have CTI coverage for end-to-end scenarios with Swashbuckle.
The package was marked as non-shipping but we continued to build and test it. This change
removes it. A copy of this code exists in asplabs so all is not lost.
- see dotnet/arcade#5866 discussion
- leaving redundant `[AssemblyMetadata("CommitHash", ...)]` because it's used in this repo
- e.g. src\Components\benchmarkapps\Wasm.Performance\Driver\Program.cs
- also consistent with native images
This change is prep for post build signing. When PostBuildSign=true, signing is not performed during the build. Instead, pass the top-level artifacts that are signable to PushToAzureDevOpsArtifacts (via Publish.proj).
Also fix up ArtifactsDir. As far as I can tell, it's been fixed up in Arcade to always include the trailing \, and Publish.proj should no longer be messed up.
- otherwise need to released previous packages; that's slower and less reliable
- left escape hatches but they're not currently used
- broke in servicing exercise because repo doesn't use its own isolated feeds
- also use latest package references for non-packable implementation projects
nits:
- copy some comment and spacing improvements from release/3.1
- correct Helix test failures with stable versions, where SDK's packs aren't enough
E.g. from https://dev.azure.com/dnceng/internal/_build/results?buildId=813814
``` text
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: The "ResolveTargetingPackAssets" task failed unexpectedly. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '...\.dotnet\packs\Microsoft.AspNetCore.App.Ref\5.0.0\data\FrameworkList.xml'. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
```
- set the package version of Extensions assemblies using NETCore.App version
- ignore Microsoft.Extensions.Internal.Transport package version
- transport package has a non-stable version and isn't shipped
- just got lucky this worked before versions stabilize
- update test expectations when checking PackageOverrides.txt
- use NuGet.Versioning to make this easier
dotnet-maestro[bot]
James Newton-King
John Luo
msftbot[bot]
Javier Calvarro Nelson
Pranav K
Doug Bunting
Matt Mitchell