dc997821cc
Added nuspec and symbols.nuspec files to Razor.Design
2018-04-17 11:07:34 -07:00
8985fee4b5
Merge
2018-04-17 20:39:19 +12:00
05d6bbb782
Flush first long poll immediately ( #2032 )
...
There was a race condition between the first poll and any other http request that was sent.
In particular, if you called StartAsync then StopAsync it was possible for the delete to happen before the poll started leading to 400 errors. This change fixes that by making the very first poll
return immediately so that the client can use that to determine if there was an error connecting.
2018-04-17 00:49:26 -07:00
d35bcea0a5
Move HubException and add serialization ctor ( #2049 )
2018-04-17 14:10:42 +12:00
52c45f2204
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 15:15:38 -07:00
c8d842c160
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 15:05:29 -07:00
3c40b9efd2
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 14:24:13 -07:00
6fd09af374
Improve logging of request drain timeout ( #2480 )
2018-04-16 11:53:10 -07:00
c05c5a6b2a
React to aspnet/KestrelHttpServer#2496: make IConnectionInherentKeepAliveFeature a boolean feature ( #2041 )
2018-04-16 11:34:12 -07:00
3a45136cc4
make IConnectionInherentKeepAliveFeature a boolean feature ( #2496 )
2018-04-16 11:34:06 -07:00
a426334018
Expose IList instead of List
2018-04-16 10:44:22 -07:00
a5d9930802
API review changes ( #2043 )
...
- Make SerializedHubMessage and SerializedMessage
public
- Made HubConnectionStore public
- Move SendUtils and Utils to the internal folder
- Make Microsoft.AspNetCore.Http.Connections.Common/Internal public.
- Move InvocationRequest to internal folder
2018-04-16 10:31:10 -07:00
0a876cece7
Make https redirect no-op if no port is available #318
2018-04-16 09:49:43 -07:00
4d151a599e
Dynamically expand timeout when waiting for Angular CLI to be ready. Fixes #1611
2018-04-16 14:54:52 +01:00
78f7dccfab
Performance fix
...
- Usage of resolved loopback IP address instead of 'localhost'
Addresses #1588
2018-04-16 14:45:16 +01:00
927b08f893
Cache property access ( #2030 )
2018-04-15 23:23:00 -07:00
4f4dfe1d23
Move RedisLog to Internal namespace ( #2038 )
2018-04-16 18:08:26 +12:00
b5d5f11ef8
Rename excludedIds to excludedConnectionIds ( #2037 )
2018-04-16 18:03:16 +12:00
7745fd748a
Extension methods for IHubClients methods ( #2016 )
2018-04-15 22:43:26 -07:00
0da06fb5d2
Microsoft.AspNetCore.SignalR.Redis API review ( #2036 )
2018-04-16 15:56:49 +12:00
b3a9011698
API review changes for Microsoft.AspNetCore.SignalR ( #2033 )
2018-04-16 15:54:42 +12:00
6eac7049ba
Update text and binary formatter helpers to be shared ( #2035 )
2018-04-16 15:19:34 +12:00
d8fc2d4009
Fix test failures
...
* Disable deps file generation in class library project. This workarounds known issue - https://github.com/dotnet/core-setup/issues/3726
* Update RazorProjectRouteModelProvider to not specify a trailing slash. This produces paths with a single slash as opposed to two slashes messing with route creation.
* React to Microsoft.AspNetCore.Mvc.Razor.Extensions.Reference that shows up in the deps file.
2018-04-15 16:31:41 -07:00
a17320221e
Derp
2018-04-16 10:43:06 +12:00
62f14054eb
Capture and log prematurely closed connections
2018-04-16 10:41:35 +12:00
fbb13c4c1f
Improve response status logging
2018-04-16 09:38:47 +12:00
f8e641d007
Merge
2018-04-15 19:21:07 +12:00
725bb33949
Lazy initialize HttpConnectionContext.Items ( #2027 )
2018-04-15 19:06:13 +12:00
9d033aa9f9
Blah
2018-04-15 18:16:23 +12:00
c835288e84
Suppress web socket closing without handshake
2018-04-15 17:51:31 +12:00
ddc905c219
Add VerifyNoErrorsScope ( #1972 )
2018-04-15 11:12:21 +12:00
b9e7113c01
Move types out of .Core namespace and make method virtual ( #2024 )
2018-04-15 09:58:33 +12:00
377ed1b834
JsonHubProtocol and MessagePackHubProtocol version fields now private ( #2023 )
2018-04-15 09:58:05 +12:00
cc5ae02b7d
Fix binding & validating dictionaries of non-simple types in jQuery requests
...
- #7423
- retry failed inner bindings with alternate syntax in `ModelStateDictionary`
- use property syntax if first attempt tried index syntax and visa versa
- instantiate `ShortFormDictionaryValidationStrategy` with full `ModelState` keys
- can now provide exact `ModelState` keys that `ModelStateDictionary` used in inner bindings
- normalize model names without a leading period in `JQueryKeyValuePairNormalizer`
nits:
- take a few VS suggestions
2018-04-14 10:41:00 -07:00
5a77c8be25
API review Microsoft.AspNetCore.SignalR.Internal ( #2022 )
2018-04-15 00:23:26 +12:00
d6395a52bc
Send delete request after poll ends ( #2020 )
...
* Added test and fixed other test
2018-04-14 04:45:16 -07:00
0f8485cafc
Renamed class to match the file ( #2019 )
2018-04-14 04:08:26 -07:00
e4d0f2980e
Microsoft.AspNetCore.SignalR.Client refactor ( #2000 )
2018-04-14 21:09:41 +12:00
e30a02cee5
Less StringValue struct copies for header checks ( #2488 )
2018-04-13 18:21:50 -07:00
3f0a6ebc0d
API Review Dependency Injection ( #2015 )
2018-04-13 17:21:48 -07:00
1fbb940b82
Remove MSG from SignalR ( #2006 )
2018-04-13 17:08:02 -07:00
4984dd2cdd
Revert "[ Fixes #7587 ] No easy way to change ASPNETCORE_ENVIRONMENT"
...
This reverts commit 22510e1377
2018-04-13 16:51:25 -07:00
86a036cf76
Revert "[ Fixes #7635 ] Provide a way to configure clients in WebApplicationFactory"
...
This reverts commit 1e26571ba6
2018-04-13 16:50:38 -07:00
c7f7f36210
API Review for Http.Connections ( #2010 )
2018-04-13 16:35:07 -07:00
95835d6c37
Continue generating RelatedAssemblyPart on assembly if GenerateAssemblyInfo=false
...
Fixes #2257
2018-04-13 16:14:37 -07:00
898b8cec84
Prepare for RazorAssemblyAttribute -> RazorTargetAssemblyAttribute rename
2018-04-13 16:13:44 -07:00
1e26571ba6
[ Fixes #7635 ] Provide a way to configure clients in WebApplicationFactory
2018-04-13 16:02:56 -07:00
22510e1377
[ Fixes #7587 ] No easy way to change ASPNETCORE_ENVIRONMENT
2018-04-13 16:02:56 -07:00
60b6ec047d
Don't fail the build when ExtensionDependencyChecker fails
2018-04-13 15:55:39 -07:00
d5e044f693
[ Fixes #7373 ] Assigning to the context's Result property, when implementing IPageFilter, causes an exception
2018-04-13 15:11:44 -07:00
faf2f3f065
Attempt to workaround issues with File.Move on NFS file shares ( aspnet/Home#2941 )
2018-04-13 15:08:28 -07:00
d0137a996c
Internalize Microsoft.AspNetCore.Http.Connections.Client.Internal ( #2014 )
2018-04-13 15:04:58 -07:00
021356bf27
Internalize classes in Http.Connections ( #2013 )
2018-04-13 14:57:37 -07:00
bfbd286ab6
Remove usages of obsolete APIs
2018-04-13 14:54:35 -07:00
2d51d23697
Add file logging to functional tests
2018-04-13 14:53:57 -07:00
8d1de6ec80
Make sure RazorSdk works when BuildingInVisualStudio \ BuildProjectReferences is disabled
...
Fixes #2247
2018-04-13 14:35:04 -07:00
a9c7c322cb
Add "webapp" alias to RazorPages template.json ( #467 )
...
Addresses #325
2018-04-13 14:01:20 -07:00
d995b0418a
Allow BindPropertyAttribute to be specified on controller classes
...
Fixes #7350
2018-04-13 13:58:44 -07:00
f8dc5c4702
Obsoleted IRazorEngineBuilder APIs
2018-04-13 12:35:53 -07:00
499d39b364
rename MsgPack assembly only ( #2005 )
2018-04-13 12:01:45 -07:00
0919914e56
Internalize more classes ( #2004 )
2018-04-13 11:28:52 -07:00
5d52701cd2
Add Error razor page to Spa templates ( #464 )
...
Addresses #332
2018-04-13 11:11:01 -07:00
a8c0970cde
Check for non-null RequestServices ( #1378 )
2018-04-13 09:45:38 -07:00
2e761415e4
Implement IDisposable for derived types for WebApplicationFactory<T> ( #7637 )
...
* Implement IDisposable for derived types for WebApplicationFactory<T>
Add a protected Dispose method and a finalizer to WebApplicationFactory<T> for use in classes that derive from it and want to dispose of their own resources.
Resolves #7631 .
* Address review feedback
Only dispose of fields if disposing is true.
2018-04-13 09:30:33 -07:00
3e69fdc4ad
Delegate disposable to the IConnectionFactory ( #1999 )
...
- Added DisposeAsync to the IConnectionFactory. It's responsible for disposing the connection after the pipe has closed.
- Added dispose callback to WithConnectionFactory
- Don't wait for poll request to end before unwinding from the transport
- Make sure all http requests are done before returning from StopAsync in both SSE and longpolling
2018-04-13 09:16:23 -07:00
f824751bb9
Added Razor class library project template
...
[Fixes #323 ] Add a Razor class library project template
2018-04-13 04:21:49 -07:00
abe139ee16
Make the protocol and messages public ( #1994 )
...
* Move types to a .Protocol namespace
2018-04-13 01:53:41 -07:00
198013bfa3
Microsoft.AspNetCore.Http.Connections.Client refactors ( #1995 )
2018-04-13 20:13:58 +12:00
83dec1093a
Fixed flaky longpolling tests ( #1993 )
...
- Wait for disposal and removal of the connection
2018-04-13 00:42:31 -07:00
4a568e90d2
API review changes ( #1992 )
...
- Changed GetMessageBytes to return ReadOnlyMemory
- Make HandshakeProtocol.SuccessHandshakeData a readonly field
2018-04-13 00:25:02 -07:00
70c63fe9e8
Http.Connections.Client API Review changes ( #1987 )
2018-04-13 06:52:27 +00:00
0ee4a86564
Collapse AsSpan().Slice(..) into AsSpan(..) ( #1991 )
2018-04-12 23:15:47 -07:00
0053124ca4
Make Proxies Internal ( #1982 )
2018-04-13 00:38:16 +00:00
df4d901ae7
Fix 5 param On extension method ( #1984 )
2018-04-13 00:37:13 +00:00
10f3b6863e
Avoid nullref in KestrelEventSource ( #2483 )
...
* Avoid nullref in KestrelEventSource
* Improve HostNameIsReachableAttribute to speed up test discovery
2018-04-12 17:29:34 -07:00
4188d2fe68
sttimer changes to V2 ( #773 )
2018-04-12 17:11:38 -07:00
5fd1f9e0e5
Merge remote-tracking branch 'origin/release/2.1' into dev
2018-04-12 16:33:29 -07:00
9c83280770
Fixing couple issues ( #763 )
...
adding more logs and fix memory leak in case of configuration change and then shutdown
2018-04-12 14:10:25 -07:00
24328b8e88
fix #1281 by adding support for DELETE endpoint on server ( #1925 )
2018-04-12 12:39:08 -07:00
0992db9fd2
fix #1914 by switching RedisProtocol to MsgPack ( #1968 )
2018-04-12 12:10:51 -07:00
4e1ba2a6c7
Delay process exit in ConsoleLifetime #1329
2018-04-12 10:07:44 -07:00
ee12c4fcf2
Downgrade HTTPs handshake failures to debug #1853
2018-04-12 09:25:44 -07:00
c6fa9793eb
Make Protocols internal
2018-04-12 08:53:27 -07:00
4184b2406d
Updated to make routing always use UrlEncoder.Default and not depend on DI to get it.
...
[Fixes #513 ] RedirectToAction with Non-English Characters in Parameters and Authentication Causes Error
2018-04-12 05:15:45 -07:00
8b1a7e9199
API review feedback ( #1974 )
...
- Remove SetHttpContext
- Remove HttpContextFeature
- Add and implement IHttpTransportFeature on HttpConnectionContext
- Remove ConnectionMetadataNames
2018-04-12 03:50:14 -07:00
d4773e831c
Set default transport and application buffer sizes ( #1964 )
2018-04-12 18:23:00 +12:00
7563ccae20
Always use TaskCreationOptions.RunContinuationsAsynchronously ( #1966 )
2018-04-12 18:21:20 +12:00
3c8c8ea8e1
React to Kestrel changes ( #1969 )
2018-04-11 20:29:17 -07:00
ca44b4adfc
Moved kestrel specific features into transport abstractions ( #2482 )
2018-04-11 20:23:48 -07:00
e34b4e8335
Use DependencyContext.CompileLibraries to determine dependency graph ( #7626 )
...
* Use DependencyContext.CompileLibraries to determine dependency graph
Fixes https://github.com/aspnet/Mvc/issues/7617
2018-04-11 15:57:11 -07:00
f6b2880369
Flow the ConnectionContext to the SNI callback ( #2478 )
2018-04-11 15:56:25 -07:00
08f9990c39
Ensure there's a redis connection earlier
2018-04-11 15:25:38 -07:00
9cea47fa7d
Remove root directory customization options for Razor Pages areas
...
Fixes #7608
2018-04-11 15:25:31 -07:00
9365fcd053
Don't publish the refs directory when the app does not have any Razor files
...
Fixes https://github.com/aspnet/Razor/issues/2246
2018-04-11 15:20:16 -07:00
b8c3273cae
Dont always copy handlers ( #1945 )
2018-04-11 22:19:51 +00:00
c3ac7629d1
WebAPI launchUrl; MVC _LoginPartial; F# AllowedHosts ( #463 )
...
Addresses #455 , #392 , #445
2018-04-11 15:01:32 -07:00
e8bb88cb58
Fixing typo ( #2477 )
2018-04-11 14:27:53 -07:00
6d9df1ef33
Noop Razor Sdk for F# projects
2018-04-11 14:18:19 -07:00
0b5cb8a8b8
Reload HostFilteringOptions on change
2018-04-11 12:23:14 -07:00
768cad8a8a
Reload HostFilter options on change #317
2018-04-11 11:44:58 -07:00
8cc851ff9b
Clean up timer code with custom awaitable ( #1935 )
...
- Gets rid of locks by using an event loop
2018-04-11 10:39:29 -07:00
cb5bba36fc
Get off the event loop before dispatch ( #1952 )
2018-04-11 10:39:09 -07:00
b7b6bd9533
React to updates in dependencies and removal of System.Runtime.CompilerServices.Unsafe from netcoreapp ( #429 )
2018-04-11 09:59:22 -07:00
62272ad56a
Round off file result's LastModifiedDate to whole seconds for correct comparison with http header dates
...
[Fixes #7572 ] PhysicalFileResult does not respond 304 Not Modified
2018-04-11 06:43:50 -07:00
12b69a0fdb
Refactor HttpOptions in client ( #1942 )
...
- Rename HttpOptions to HttpConfigurationOptions
- Remove HttpConfigurationOptions from SignalR client project
- Updated client HttpConnection ctors
2018-04-11 20:20:04 +12:00
e2fbff2bd5
Feedback
2018-04-10 23:00:18 -07:00
b30c2fecbf
SSE formatting refactor ( #1916 )
2018-04-11 17:13:15 +12:00
c83baf2b76
Remove params from message ctors ( #1931 )
2018-04-11 12:11:13 +12:00
13f7981010
Rename Callback to Configure in UseConnections ( #1939 )
2018-04-11 00:08:22 +00:00
e2169ceda6
Connect to Redis asynchronously ( #1922 )
2018-04-10 23:48:11 +00:00
46efcd9332
Move srwWrapper to right location
2018-04-10 14:43:05 -07:00
5c91dbe062
Get tests working
2018-04-10 14:21:23 -07:00
da513bd8d8
Get build.cmd working and cleanup ignored files.
2018-04-10 14:21:00 -07:00
df9efa0770
Code changes to get ANCM current working on github
2018-04-10 14:19:53 -07:00
b594130020
Adds source code from VSTS
2018-04-10 14:19:53 -07:00
157e7f4fdd
Creates two separate projects for ANCM V1 and V2.
2018-04-10 14:19:32 -07:00
bec259f976
#364 - Expose HTTP_503_RESPONSE_VERBOSITY option ( #447 )
2018-04-10 12:08:33 -07:00
6629236a0e
Merge pull request #767 from aspnet/pakrym/perf
...
Improve performance
2018-04-10 12:07:26 -07:00
da32f45f58
Do not set sslPort if HTTPS not configured ( #458 )
...
Addresses #457
2018-04-10 12:02:10 -07:00
d63e8c5558
CPP
2018-04-10 11:04:34 -07:00
5504374125
Preserve directive node diagnostics in document node
2018-04-10 10:24:21 -07:00
ee2e46a614
What about now?
2018-04-10 09:08:13 -07:00
6b18dea711
Replace Constants.CompletedTask with Task.CompletedTask ( #235 )
2018-04-10 08:58:39 -07:00
61f7c82d49
Replace Helpers.CompletedTask and Helpers.CanceledTask ( #446 )
2018-04-10 08:57:25 -07:00
80e799d17c
PR comments
2018-04-10 08:30:37 -07:00
8a3516284e
Add GetMessageBytes to IHubProtocol ( #1915 )
2018-04-10 07:14:09 -07:00
31dfe91962
Support async access token factory ( #1911 )
2018-04-10 05:34:10 -07:00
6bc2ebb4c5
Use invariant culture and ordinal comparisons ( #1928 )
2018-04-10 16:52:19 +12:00
b030ab7e49
Update Connections.Abstractions.csproj ( #2473 )
2018-04-09 17:55:14 -07:00
6d050140e5
Swtich to MessagePack-CSharp ( #1879 )
2018-04-09 17:04:32 -07:00
e32b51d6e6
ENdpoint
2018-04-09 16:47:01 -07:00
f0eab4410a
Cleanup
2018-04-09 15:20:28 -07:00
7a14be006d
Fast reads
2018-04-09 15:16:47 -07:00
39053a5e22
Corrects spelling of some comments
2018-04-09 14:37:20 -07:00
5e5aa90575
Remove continue with
2018-04-09 14:26:28 -07:00
0feb83b637
Dont format some things
2018-04-09 12:10:32 -07:00
ec31ff0c28
Throw if multiple Body bound parameters are discovered
...
Fixes #6963
2018-04-09 11:20:34 -07:00
dca31cc6f6
Perf
2018-04-09 10:34:44 -07:00
01089da84d
Use in for ReadOnlySequence ( #1900 )
2018-04-09 09:29:27 -07:00
95e868b68c
Remove JsonSerializer ( #1913 )
2018-04-09 02:56:46 -07:00
406d8f9a81
readonly readonly structs ( #1908 )
2018-04-08 23:28:37 -07:00
8f1781f7eb
Cleanup LogEvent calls
2018-04-08 19:21:55 -07:00
bd78785f8d
Minor DefaultHubLifetimeManager improvements ( #1904 )
2018-04-09 12:31:14 +12:00
9fd713c73a
Make MemoryBufferWriter a Stream ( #1907 )
...
- Get rid of LimitArrayPoolWriteStream and use MemoryBufferWriter in its place in the MessagePackProtocol implementation.
- Added tests for MemoryPoolBufferWriter and fixed a bug in CopyToAsync
- Added CopyTo(`IBufferWriter<byte>`)
- Changed MemoryBufferWriter to fill the underlying arrays that back segments, the segment size is now a minimum.
2018-04-08 16:11:17 -07:00
27d18578d0
Use expression body properties and implicit arrays where possible ( #1906 )
2018-04-08 21:40:01 +12:00
0f663cadc4
readonly all the things ( #1901 )
2018-04-08 15:47:01 +12:00
4760cce6aa
Remove IConnection ( #2472 )
2018-04-07 18:55:59 -07:00
a3337eb6bd
Remove traces of ASP.NET Core Sockets ( #1899 )
2018-04-07 17:51:12 -07:00
c1049b722d
The grand unification of ConnectionContext ( #1895 )
...
This change rationalizes the 2 very similar abstractions that exist in Connections.Abstractions, IConnection and ConnectionContext. It also introduces an IConnectionFactory to SignalR that is used to create a new ConnectionContext for a HubConnection.
- HubConnection just completes both ends of the transport pipe instead of calling DisposeAsync.
- Implemented ConnectionContext on HttpConnection and added HttpConnectionFactory
- Updated tests
2018-04-07 16:19:01 -07:00
e3da7feab4
Clean up client ITransport interface ( #1893 )
...
- Transports own the pipe creation. The fact they are 2 sides is an implementation detail.
2018-04-07 15:11:42 -07:00
86083c0302
Removing native support for IObservable<T> ( #1890 )
...
- There are too many issues and questions with respect to back pressure and the buffering policy we should use when the client being streamed to can't support the data being pushed via OnNext.
As a result, we're dropping support for IObservable but keeping ChannelReader and we'll eventually support IAsyncEnumerable when that makes it into the BCL.
- Add sample showing Observable -> ChannelReader adaption
2018-04-07 15:10:39 -07:00
acc0b7ad0d
Serialize NegotiateResponse with IBufferWriter ( #1881 )
2018-04-07 15:50:13 +12:00
f632330d7f
Allocate pipe writer stream per connection ( #1885 )
...
- Don't create the PipeWriterStream per operation, make it per Connection
- Reduce the buffer size for CopyToAsync operations to 4K where possible instead of 81K (the default)
2018-04-06 14:36:35 -07:00
e51676fb47
Policheck errors
2018-04-06 13:01:20 -07:00
e3d90bdf6a
Fix graceful closing of pipes ( #1882 )
...
- Closing pipes gracefully in most cases. The only case where we forcefully close the pipes is during application shutdown
- Return 404 if sending to connection after disposal
- Added tests
2018-04-06 10:59:40 -07:00
5e019bd707
Add Microsoft.AspNetCore.All
...
Fixes https://github.com/aspnet/Mvc/issues/7605
2018-04-06 10:57:59 -07:00
84d43cb2d8
Remove extra class ( #1884 )
...
- Merged 2 DI classes in SignalR
2018-04-06 08:16:19 -07:00
a6bdb9b1ec
Fix typos in code documentation ( #1012 )
...
* Fix typos in code documentation
* Add missing detail to code documentation
2018-04-06 08:09:48 -07:00
4ddf8664c0
Don't throw from Observer's OnNext ( #1872 )
2018-04-06 00:35:04 -07:00
36edadabb4
Lock when sending data to connection ( #1876 )
2018-04-06 16:25:47 +12:00
cb5ece8a24
HttpTransportType refactor ( #1873 )
...
- Rename file to HttpTransportType.cs
- Add HttpTransportType.None
- Move All to static readonly field
- Make TransportType on client and service HttpConnectionOptions consistent
- Move setting defaults into ctor
2018-04-06 16:18:47 +12:00
921986d561
Fix AccessTokenFactory not being called with each request ( #1880 )
2018-04-06 15:46:36 +12:00
b0c4e9d0f7
0 byte read in WebSockets ( #1878 )
2018-04-05 18:50:30 -07:00
6270c1f47e
Merge branch 'rel/vs15.7' into dev
2018-04-05 16:28:17 -07:00
4cd24a2b08
Add experimental flag to un-special-case data-
...
This change allows blazor to opt into treating data- attributes the same
way as normal attributes in the parser.
2018-04-05 15:27:04 -07:00
d1c0ab587c
Add support for type parameters to class nodes
...
This change will allow someone extending Razor to use generic type
parameters in generated classes.
There's no user-level extensibility provided here yet, as in there is no
language support for adding type parameters.
2018-04-05 15:26:42 -07:00
19b2fea0d8
Preserialize for all formats when sending through Redis ( #1843 )
2018-04-05 13:48:14 -07:00
39f693b9ed
Found these while looking at a flaky test ( #1871 )
...
- Fix crashing test
- Dispose the ClientWebsocket in StopAsync
2018-04-05 12:47:39 -07:00
b9e88923e7
Comment why we set X-Requested-With ( #1870 )
2018-04-05 11:38:15 -07:00
47c7c1ad8f
Disable global loading of RequestHandler for in-process ( #732 )
2018-04-05 10:36:15 -07:00
4236f0e51c
Fix AllowedHosts configuration ( #452 )
...
Addresses #451
2018-04-05 10:08:40 -07:00
11343ea15d
Add logging by default to HubConnectionBuilder ( #1867 )
...
- Use the AddLogging extension method by default in the HubConnection
- Removed WithConsoleLogger extension methods
- Removed WithLoggerFactory extension method (moved to test only)
- Added WithLogger that uses the new the new ILoggerBuilder
2018-04-05 10:05:07 -07:00
35b6d81f77
Don't dispose on cancellation ( #1859 )
...
- We're already disposing now at the end of enumeration
2018-04-05 09:22:46 -07:00
61c3d0c403
Added Microsoft.AspNetCore.SignalR.Protocols.Json ( #1861 )
...
- Fixed package descriptions
- Call AddJsonProtocol from both the SignalR.Core (client and server)
2018-04-05 01:32:10 -07:00
f7fc2647de
var all the things ( #1855 )
2018-04-05 18:41:13 +12:00
fccc9d1b50
fix #1815 by disposing linked cts ( #1849 )
2018-04-04 21:12:21 -07:00
8a368b5610
Add supportedAuthentication for NoAuth in templates which have NoAuth ( #443 )
...
* Add supportedAuthentication for NoAuth in templates which have NoAuth
This is to work around an issue in Visual Studio
* Remove spurious ,
* Add supportedAuthentications to F# Web API vs-2017.3.host.json
2018-04-04 18:10:04 -07:00
ae42d7599d
Show error if page directive is not at the top of file
2018-04-04 17:27:10 -07:00
32b4d5cc6c
Set X-Requested-With on all requests ( #1848 )
2018-04-04 17:12:50 -07:00
80f87e7730
Add Handshake timeout to C# Client ( #1840 )
2018-04-04 15:54:42 -07:00
490fd088f9
Merge branch 'release/2.1' into dev
2018-04-04 15:02:47 -07:00
924272ad1a
Revert "Merged release/2.1"
...
This reverts commit cf45fac634313772ef03
2018-04-04 15:02:20 -07:00
2ee0d6e337
Delay loading the dev cert #2422
2018-04-04 14:54:27 -07:00
cf45fac634
Merged release/2.1
2018-04-04 14:48:26 -07:00
1c7ca7fa3a
Remove lazily initialization of the pipes ( #1850 )
...
- This fixes race condition
2018-04-04 14:43:34 -07:00
953496a970
Merge branch 'release/2.1' into dev
2018-04-04 13:44:56 -07:00
5e190b404f
Remove lazily initialization of the pipes
...
- This fixes race condition
2018-04-04 13:00:20 -07:00
9ea2c50068
Add SNI support #2357
2018-04-04 12:49:29 -07:00
b1007744b0
Added PipeOptions.CurrentUserOnly option to the named pipe streams
...
Don't run on server if CurrentUserOnly is not available
2018-04-04 09:53:36 -07:00
afa56e3012
MsgPack perf ( #1845 )
2018-04-04 07:11:16 -07:00
e7b84b753b
Refactor HubConnectionBuilder ( #1830 )
2018-04-04 21:19:13 +12:00
7c2d9e87e9
Clean up pipe pair on transport start failure ( #1836 )
2018-04-03 17:08:04 -07:00
ba0131a731
Rename TransportTypes to HttpTransportTypes ( #1839 )
2018-04-03 16:00:20 -07:00
70ce044778
Corrects spelling of some comments ( #2461 )
2018-04-03 15:55:17 -07:00
52ffc89fef
Remove duplicated UseHttpsRedirection ( #437 )
...
Addresses #436
2018-04-03 14:02:52 -07:00
d23f2beafc
Merge release/2.1 into dev ( #1834 )
2018-04-03 10:45:44 -07:00
81bf9fb66b
Merge release/2.1 into dev ( #421 )
2018-04-03 10:45:34 -07:00
ba06c58bcb
Merge release/2.1 into dev ( #2460 )
2018-04-03 10:45:31 -07:00
6ee08a985d
React to Mvc changes
2018-04-03 10:11:52 -07:00
5210323385
Merge release/2.1 into dev
2018-04-03 10:11:36 -07:00
623c27ab01
Dispose SocketAsyncEventArgs when we dispose the Socket ( #2459 )
2018-04-02 19:48:17 -07:00
221c95e0af
Couple logging additions ( #1827 )
...
- Added logging in a couple more places in HubConnection
- Increase DEFAULT_TIMEOUT_INTERVAL to 20 seconds
2018-04-02 19:25:47 -07:00
6a1367ff70
Reaction to *Memory changes ( #1824 )
2018-04-02 16:44:31 -07:00
ba2b883db0
Reaction to *Memory changes ( #2446 )
2018-04-02 16:44:13 -07:00
f52359d202
Update AJAX CDN links ( #430 )
2018-04-02 16:25:24 -07:00
6b183c5ac0
Use 4K as the minimum segment size ( #2452 )
...
- This normalizes the behavior for kestrel no matter what memory pool implementation is used. The transports should behave the same (ask for 1/2 full blocks) across pool implementations.
- Declare the minimum segment size in KestrelMemoryPool
- Updated the AdaptedPipeline to use MinimumSegmentSize / 2
2018-04-02 16:14:40 -07:00
3460d44848
Fix non-serializable tests ( #1820 )
2018-04-03 09:31:52 +12:00
6e957e436a
Support inprocess hosting in IISExpressDeployer via switching the HostingModel property. ( #1368 )
2018-04-02 12:01:53 -07:00
5ce672dfe6
ThreadStatic MemoryBufferWriter ( #1821 )
2018-04-02 11:25:04 -07:00
6640f14e35
Detailed errors enabled for functional tests ( #1822 )
2018-04-02 10:42:26 -07:00
07a1907918
Introduce ViewDataAttribute
...
Allow properties on controllers, Razor Page and Razor Page models annotatted with [ViewDataAttribute]
to populate ViewDataDictionary
Fixes https://github.com/aspnet/Mvc/issues/6525
2018-04-02 10:31:16 -07:00
6d4a632b96
Fix race condition in test code waiting for dotnet-watch to restart
2018-04-02 10:10:57 -07:00
e9d58154ec
Added TCP client sample to HubSample ( #1805 )
...
- Ripped of Kestrel's SocketConnection to make a TcpConnection
IConnection implementation.
- Fixed issue with SignalR assuming there will always be a non-null user
on the ConnectionContext.
2018-04-02 09:50:50 -07:00
c515cece8e
Use ModelMetadataProvider to infer BindingSource on application model
2018-04-02 09:48:49 -07:00
a16504b941
Added failing test for #7546
2018-04-02 09:48:49 -07:00
56fc40dbca
Revert "Revert "Update jquery-validation-unobtrusive ( #421 )"" ( #426 )
...
This reverts commit e6112a0911
2018-04-01 23:29:52 -07:00
ef30e2e2df
Clean up the SSE client side transport ( #1816 )
...
- Renamed StreamPipeConnection to PipeReaderFactory
- Flow the transport cancellation token to the CopyToAsync routine
- Other small cleanup and nits to make the style consistent with the other pipe reader loops
- Return a cancelled ValueTask from PipeWriterStream.WriteAsync
- Move event stream request to start itself
- We no longer need to pass the tcs through.
- It also cleans up handling failure in start since the application pipe hasn't been read or written to
2018-04-01 21:11:59 -07:00
bb7cb14a1c
Clean up the logging style for HttpConnectionManager ( #1819 )
...
- Remove nameof usage
2018-04-01 19:34:11 -07:00
82bda4a9c8
Added micro benchmarks for SSE parsing and Writing ( #1818 )
2018-04-01 09:19:07 -07:00
a37fa83aee
Fixed a parser bug found when trying out the array pool ( #2450 )
...
- When using the array pool, we get terrible block density and as a result
the header parser was failing.
- This fixes the case where the parser needed to skip 2 blocks at the end
(which is unrealistic). Comparing the current index to the reader index is incorrect
since we may end up at the same index in another segment.
2018-04-01 00:04:02 -07:00
ca161e9bc8
Improve writing single characters with UTF8 text writer ( #1814 )
2018-04-01 17:34:19 +12:00
e6e45cea05
Change how HttpConnection sets headers ( #1806 )
...
- Removed SendUtils.PrepareRequst and instead used HttpClient.DefaultRequstHeaders to set the common headers to apply HttpOptions to all outbound requests
- Modified how we check for the user agent request testing
2018-03-31 22:23:09 -07:00
04a22f23dd
Deserializing ISO formatted strings in method arguments ( #1812 )
2018-04-01 12:26:30 +12:00
a76d51c46b
Revert "Update jquery-validation-unobtrusive ( #421 )"
...
This reverts commit ac9addabcc
2018-03-31 16:24:07 -07:00
ac5dfcf909
Merge pull request #1810 from aspnet/release/2.1
...
Change default handshake timeout (#1808 )
2018-03-31 12:27:46 -07:00
dc86690f04
Change default handshake timeout ( #1808 )
...
- 5 seconds seems to be too low for long polling's RTT. We often see super flaky tests and it seems like this is the best fix. Ideally, we would do something more sophisitcated than just timeout the entire time to parse.
2018-03-31 12:27:23 -07:00
7382198356
Copy connection middleware when using ListenLocalHost ( #2447 )
...
- Connection middleware got removed during Clone when using ListenLocalhost
2018-03-31 07:29:35 -07:00
90aa48c09f
Merge pull request #1798 from aspnet/release/2.1
...
Use IBufferWriter in IHubProtocol (#1791 )
2018-03-30 17:30:30 -07:00
903a9ea6a0
Use IBufferWriter in IHubProtocol ( #1791 )
2018-03-30 17:30:08 -07:00
6ca61a8fc7
Merge release/2.1 to dev
2018-03-30 16:33:44 -07:00
0293e53e11
Handle uninitialized connections in disposal ( #1786 ) ( #1794 )
...
- We made a change to not initialize pipes up front
on connection creation. That change make it null ref in disposal because we didn't check if the pipes were initialized.
- Added a test
- Also fixed the EchoConnectionHandler in the functional ts tests.
2018-03-30 15:51:48 -07:00
eb7dc14c39
Handle uninitialized connections in disposal ( #1786 )
...
- We made a change to not initialize pipes up front
on connection creation. That change make it null ref in disposal because we didn't check if the pipes were initialized.
- Added a test
- Also fixed the EchoConnectionHandler in the functional ts tests.
2018-03-30 15:44:30 -07:00
a92b3a7288
Merge branch 'release/2.1' into dev
2018-03-30 15:26:44 -07:00
2c2a8dae01
Merge pull request #2445 from aspnet/release/2.1
...
Add IConnection to Connections.Abstractions (#2444 )
2018-03-30 15:21:48 -07:00
67cb8a0e11
Add IConnection to Connections.Abstractions ( #2444 )
2018-03-30 15:20:31 -07:00
6b3a27e73c
Bedrock Renames ( #1777 )
2018-03-30 15:09:19 -07:00
ac9addabcc
Update jquery-validation-unobtrusive ( #421 )
...
Addresses #15
2018-03-30 15:04:50 -07:00
30f0883319
Target a lower TFM
2018-03-30 14:45:42 -07:00
fd6c217336
Revert "Build runtime specific metapackages"
...
This reverts commit ec184bc361
2018-03-30 13:02:45 -07:00
569fb79776
Merge pull request #1789 from aspnet/release/2.1
...
Re-enable ConnectionCanSendAndReceiveMessages + logging (#1778 )
2018-03-31 08:46:32 +13:00
0362905a70
Re-enable ConnectionCanSendAndReceiveMessages + logging ( #1778 )
2018-03-31 08:45:33 +13:00
6f03496448
Make Microsoft.AspNetCore.Mvc depend on Microsoft.AspNetCore.Mvc.Analyzers
2018-03-30 12:33:45 -07:00
ec66d236ac
Merge pull request #1785 from aspnet/release/2.1
...
Add detailed error option (#1763 )
2018-03-30 11:30:44 -07:00
44b667b3e6
Add detailed error option ( #1763 )
2018-03-30 11:30:07 -07:00
9eb41ca571
Remove buffer size argument ( #232 )
...
- We're removing the buffer arugment from the API as a result of a mini review. This is a pre-emptive reaction to avoid breakage when the change comes in.
2018-03-30 10:47:12 -07:00
c29c1b3ec6
Merge pull request #1783 from aspnet/release/2.1
...
Release/2.1
2018-03-30 02:33:28 -07:00
b5a2fcb96a
Dispose the http client in DisposeAsync ( #1780 )
...
- This layer of the stack is no longer reusable and
this disposable was removed (I assume by mistake) in the big refactoring
2018-03-30 01:57:14 -07:00
a26e6f5a30
Make shutdown logic for SSE and LongPolling more similar to WebSockets ( #1779 )
...
- Cancel reading from the application when initiating a transport stop
- Complete each side of the pipe in the place where the pipe is being consumed
- Errors from sending end up getting sent to the application
- The Running task never throws
- Removes ContinueWith
2018-03-30 01:50:30 -07:00
f20bf9ea02
Fix #7503 change to model name for IValidableObject
...
This change undoes a breaking change introduced by the 2.1 model
validation changes. Now an implementation of IValidableObject on a
top-level model will be called correctly with the 'empty' prefix instead
of the parameter name.
When fixing this we undid a workaround for another issue.
When validating a parameter that didn't bind we didn't correctly compute
the model name for 'fallback to empty prefix' cases.
(cherry picked from commit 7a1096a72b
2018-03-29 21:35:59 -07:00
264f9c871e
Add an analyzer to warn against the use of IHtmlHelper.Partial and IHtmlHelper.RenderPartial
...
Fixes https://github.com/aspnet/Mvc/issues/7417
2018-03-29 21:25:54 -07:00
5cfc03ffe9
Merge pull request #1775 from aspnet/release/2.1
...
Fix internal HubConnection state when handshake fails (#1774 )
2018-03-29 16:35:55 -07:00
46f27cdd0b
Fix internal HubConnection state when handshake fails ( #1774 )
2018-03-29 16:35:31 -07:00
cb7942abe4
Add no-https option for all templates ( #413 )
...
Addresses #322
2018-03-29 13:59:47 -07:00
aca30fe8a2
--no-https option for RazorPagesWeb-CSharp template ( #362 )
2018-03-29 13:49:20 -07:00
a2a920dde5
Normalize the tool assembly path before using it as the base for pipe name
2018-03-29 12:50:51 -07:00
80b842e987
Merge branch 'release/2.1' into dev
2018-03-29 10:05:30 -07:00
7a53e07623
Parse data as it comes in off the wire in the .NET client and server ( #1766 )
...
- Change websockets and the POST end point to send data unbuffered.
- Update tests to handle partial frames
2018-03-29 10:03:59 -07:00
d360886b78
Fix #7558 infer [FromRoute] with parameter in ANY route
...
This changes the logic for when we infer [FromRoute] on an action
parameter from *ALL* to *ANY*.
This means that if a parameter occurs in any route on an ApiController,
we will treat it as [FromRoute]. We think this is the best decision
because it's less ambiguous. If a parameter appears in a route, it won't
be eligible to be bound from query. I think that's good.
If for some reason you want this kind of behavior (route or query) then
we suggest breaking up the actions. This isn't very documentation
friendly (swagger) so we don't suggest it.
2018-03-29 07:54:39 -07:00
fc3a815e57
Restore `ModelMetadata.PropertyName != null` behaviour
...
- #7413 part 2 of 2
- add `ModelMetadata.Name` and `ParameterName`
- use `Name` instead of `PropertyName` in most cases
- update `ModelMetadata.ContainerType` and other property use
- choose using `MetadataKind` almost everywhere; support all possibilties
- usually parameter metadata was possible but not handled
- worst case was one or two potential NREs, especially `ContainerType.*` dereferences
- improve `MvcCoreLoggerExtensions` metadata handling
- add three new debug messages, one for type metadata and two for parameter metadata
- update `ModelMetadata.ContainerMetadata`, `ContainerType` and `PropertyName` doc comments
- no changes needed in Microsoft.AspNetCore.Mvc.ViewFeatures because parameters aren't viewed
nits:
- add missing `TestModelMetadataProvider.ForParameter(...)` method
- remove unused `EmptyModelMetadataProvider` instances in `ModelMetadataTest`
- refactor `ModelValidationResultComparer` out of DataAnnotationsModelValidatorTest`
- take VS suggestions, mostly related to variable inlining and object initializers
2018-03-29 07:22:00 -07:00
2f9942e1f2
Merge pull request #1765 from aspnet/release/2.1
...
Make HubConnection write messages directly to the PipeWriter (#1762 )
2018-03-29 20:27:14 +13:00
cddf46c0cd
Make HubConnection write messages directly to the PipeWriter ( #1762 )
2018-03-29 20:26:09 +13:00
a4dd4da7a2
Merge pull request #1760 from aspnet/release/2.1
...
Handshake and negotiation optimization (#1731 )
2018-03-29 17:51:40 +13:00
7f86b92f7e
Handshake and negotiation optimization ( #1731 )
2018-03-29 17:50:45 +13:00
03938dfd95
Handle Mutex creation exceptions
2018-03-28 18:23:30 -07:00
2bf962d362
Merge pull request #1757 from aspnet/release/2.1
...
Always flush in WebSocketsTransport (#1756 )
2018-03-28 18:12:31 -07:00
d5dafae2cc
Always flush in WebSocketsTransport ( #1756 )
2018-03-28 18:03:48 -07:00
6de4ac2880
Merge pull request #1754 from aspnet/release/2.1
...
Message writing optimization (#1683 )
2018-03-29 11:08:13 +13:00
8c84518ecc
Message writing optimization ( #1683 )
2018-03-29 11:03:40 +13:00
db3441cf93
Merged release/2.1
2018-03-28 14:10:45 -07:00
19b9dca268
Change IHubProtocol interface to support partial parsing ( #1745 )
...
- These are the finishing touches before we disable batching on the
C# client and on the server. We're changing the IHubProtocol interface to
modify the input buffer with what was consumed. We're also changing it
to parse a single message at a time to be match what output writing does.
- Added TryParseResponseMessage and made it look like TryParseRequestMessage
2018-03-28 12:08:16 -07:00
f8e315d03d
CompiledPageRouteModelProvider should de-dup descriptors
...
Fixes #7543
2018-03-28 11:24:49 -07:00
4c6c0aa8a4
Merge branch 'release/2.1' into dev
2018-03-27 23:12:00 -07:00
cfaa123eb8
IConnection refactoring ( #1718 )
...
- IConnection is now single-use and HubConnection creates a new instance
for reconnecting
- IConnection is just a Pipe now, no more events
2018-03-27 23:02:07 -07:00
ecafbe7f7a
[ Fixes #11 ] Add functional tests for the libraries
2018-03-27 21:33:13 -07:00
c93c168df3
Add mapping service for action results
...
This allows the use of custom 'envelope' types like ActionResult<> with
a corresponding API Explorer implementation.
Basically this PR services to decouple a bunch of infrastructure from
ActionResult<>.
2018-03-27 17:13:41 -07:00
62881a2cc4
Disable APICheck on precompilation to workaround failure
2018-03-27 16:54:27 -07:00
ad724f6b0a
Use x64 binaries when project's targeting AnyCPU ( #255 )
...
* Use x64 binaries when project's targeting AnyCPU
Fixes https://github.com/aspnet/MvcPrecompilation/issues/240
2018-03-27 12:27:46 -07:00
927af3125e
Use RazorCompiledItemMetadataAttribute to calculate route
2018-03-27 12:24:37 -07:00
f25f411b68
Add HostFiltering configuration to templates
2018-03-27 12:13:24 -07:00
62fec52a9f
Add a framework specific reference to Microsoft.DiaSymReader.Native
...
Fixes https://github.com/aspnet/Mvc/issues/7478
2018-03-27 12:08:46 -07:00
d598a909a2
Merge branch 'release/2.1' into dev
2018-03-27 10:26:57 -07:00
185453908f
Remove HubConnectionContext parameter from IHubProtocolResolver ( #1735 )
2018-03-27 10:25:00 -07:00
ade5ae534d
Set DebugType=full for .NET Framework projects
2018-03-27 08:59:54 -07:00
0c084fa28a
[ Fixes #7518 ] NullReferenceException thrown when Controller method uses Guid parameter default value
2018-03-27 05:22:20 -07:00
dcd773d10d
Merged release/2.1
2018-03-27 03:03:10 -07:00
46ab09ca36
Merge branch 'release/2.1' into dev
2018-03-27 02:08:35 -07:00
7a9160f3e0
React to https://github.com/aspnet/KestrelHttpServer/pull/2428 ( #1734 )
2018-03-27 02:02:29 -07:00
be04ccac6e
Move DuplexPipe into Kestrel.Core as internal ( #2428 )
2018-03-27 02:02:15 -07:00
434147fe8e
Merge branch 'release/2.1' into dev
2018-03-27 00:00:13 -07:00
b78e70fadb
Use more pooled Utf8BufferTextReaders ( #1728 )
...
- Use it in the HandshakeProtocol
- Move CreateJsonTextReader to JsonUtils
2018-03-26 23:32:43 -07:00
a8246e2a99
[ Fixes #327 ] Replace AAD template code with packages
...
* Add Microsoft.AspNetCore.Authentication.AzureAD.UI package.
* Add Microsoft.AspNetCore.Authentication.AzureADB2C.UI package.
* Remove AccountController.
* Remove Pages/Views related to authentication.
2018-03-26 20:37:46 -07:00
678265259d
Merge remote-tracking branch 'origin/release/2.1' into dev
2018-03-26 17:30:38 -07:00
79b51ad642
Added logging of .NET client HTTP requests ( #1723 )
2018-03-27 12:57:13 +13:00
804eeede11
Use the correct application part factory by default
...
Fixes https://github.com/aspnet/Mvc/issues/7543
2018-03-26 16:40:45 -07:00
e80d0b000a
Make BufferedReadString public and add doc ( #1011 )
2018-03-26 16:03:16 -07:00
68ff406862
Merge branch 'release/2.1' into dev
2018-03-26 14:51:21 -07:00
b8285b8356
Don't create the span on netstandard ( #1721 )
...
- Directly pin the char[]
- Changed Utf8BufferTextReader to use the Utf8Decoder
- It copies whatever it can into the char buffer allocated in a stateful way (it's more efficient).
- Added tests for unicode and ascii reading
- Added a thread static cache
2018-03-26 14:36:08 -07:00
1e11b5fa95
Make PreserveCompilationContext=true
2018-03-26 14:23:29 -07:00
5e245da326
Add compatibility switch controlling parameter metadata and top-level validation
...
- #7413 part 1 of 2
- made all `ModelMetadataProvider` and `ObjectModelValidator`-specific code conditional
- fortunately, `MvcOptions` easy to get; affected code is primarily `internal` or pub-`Internal`
- remove unnecessary `ModelMetadataProvider` use in `ApiBehaviorApplicationModelProvider`
- run integration and functional tests with `CompatibilityVersion.Version_2_1`
- functional test change depends on @javiercn's recent #7541 fix
- remove test code now redundantly turning compatibility switches on
nits:
- correct spelling errors in `CompatibilitySwitch`
- take VS suggestions, mostly in test code
- rename methods in `ControllerBinderDelegateProviderTest` to match current API
- slightly refactor in `ApiBehaviorApplicationModelProvider`
2018-03-26 12:29:04 -07:00
e1cb3f25ac
Switch to AddDefaultIdentity
2018-03-26 12:18:01 -07:00
Ajay Bhargav Baaskaran
James Newton-King
David Fowler
Ryan Brandenburg
Stephen Halter
Andrew Stanton-Nurse
Chris Ross (ASP.NET)
Steve Sanderson
Tadas Mazutis
BrennanConroy
Pranav K
Doug Bunting
Ben Adams
Javier Calvarro Nelson
Kiran Challa
Nate McMaster
John Luo
Jass Bagga
Martin Costello
Mikael Mengistu
Ahson Khan
Justin Kotalik
pan-wang
Sébastien Ros
Nate McMaster
Pavel Krymets
FabianMeiswinkel
Kristian Hellang
Vegard Løkken
flash2048
Nate Barbettini
Ryan Nowak
Phil Henning
Kristian Hellang
unknown
Tornhoof
Hao Kung