Commit Graph

20684 Commits

Author SHA1 Message Date
William Godbe c34d1dceac
Include all .xml files in targeting pack (#26147)
* Include all .xml files in targeting pack

* Better syntax

* Remove distinct
2020-09-22 12:54:28 -07:00
Steve Sanderson 7140f7cae7
Virtualize component: method to trigger data refresh (#26177)
* E2E test cases for Virtualize data refresh

* Expose public RefreshDataAsync API

* Optimize: don't instantiate CancellationTokenSource when it won't be used

* For in-memory data, refresh automatically on each render cycle

* Fix typo
2020-09-22 11:52:16 -07:00
Safia Abdalla 93f73c7764
Add support for debugging lazy-loaded assemblies (#25943)
* Add support for debugging lazy-loaded assemblies

* Address feedback from peer review

* Increase wait for output on tests
2020-09-22 08:23:39 -07:00
Sayed Ibrahim Hashimi d97ef5ccd4
Updated icons for projects that appear in VS with icons that have the (#25974)
* Updated icons for projects that appear in VS with icons that have the
language adornment.
This PR should fix #25973.

* updating icons for asp.net core templates in vs
2020-09-21 13:04:31 -07:00
Justin Kotalik 02d81add81
Increase Http2Timeout (#26075) 2020-09-21 10:55:08 -07:00
Hao Kung 6bfffda734
Remove ComponentsWebAssembly shared layout (#26078) 2020-09-19 11:12:38 -07:00
Pranav K bf91253cd3
Increase more SignalR Java client test timeouts (#26036)
Co-authored-by: Stephen Halter <halter73@gmail.com>
2020-09-18 17:00:43 -07:00
Pranav K 140f177d9e
Converge implementations of AwaitableProcess and ProcessEx (#26069)
* Converge implementations of AwaitableProcess and ProcessEx

* dotnet-watch tests are running in to the same issue as GRPC tests (https://github.com/dotnet/aspnetcore/pull/20341/files).
This change carries over some of the patterns from the other type to remedy this issue.

* Revive dotnet-watch tests on OSX

* Remove build artifacts that were accidentally commited to source.
2020-09-18 16:32:06 -07:00
Pranav K 611ee61e0e
Quarantine tests (#26062) 2020-09-18 13:08:30 -07:00
dotnet-maestro[bot] 7e0e801bb4
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/efcore (#26058)
[release/5.0-rc2] Update dependencies from dotnet/arcade dotnet/efcore


 - Update installers task location
2020-09-18 19:58:16 +00:00
Matt Mitchell b1b3d5474f
Enable PostBuildSign flag and include signing information in the manifest (#26033)
This change is prep for post build signing. When PostBuildSign=true, signing is not performed during the build. Instead, pass the top-level artifacts that are signable to PushToAzureDevOpsArtifacts (via Publish.proj).
Also fix up ArtifactsDir. As far as I can tell, it's been fixed up in Arcade to always include the trailing \, and Publish.proj should no longer be messed up.
2020-09-18 11:07:42 -07:00
Doug Bunting b592cf6610
Place ref/ layout where SDK can find it (#25987)
- correct Helix test failures with stable versions, where SDK's packs aren't enough

E.g. from https://dev.azure.com/dnceng/internal/_build/results?buildId=813814
``` text
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: The "ResolveTargetingPackAssets" task failed unexpectedly. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
...\.dotnet\sdk\5.0.100-rc.1.20379.10\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(318,5): error MSB4018: System.IO.DirectoryNotFoundException: Could not find a part of the path '...\.dotnet\packs\Microsoft.AspNetCore.App.Ref\5.0.0\data\FrameworkList.xml'. [...\src\ProjectTemplates\test\bin\Release\net5.0\TestTemplates\AspNet.m0yq3xrporu\AspNet.m0yq3xrporu.csproj]
```
2020-09-17 21:03:07 -07:00
Doug Bunting 6418c8f78a
Pin PackageOverrides.txt Extensions versions at Major.Minor.0 in servicing (#25986)
- set the package version of Extensions assemblies using NETCore.App version
  - ignore Microsoft.Extensions.Internal.Transport package version
    - transport package has a non-stable version and isn't shipped
    - just got lucky this worked before versions stabilize
- update test expectations when checking PackageOverrides.txt
  - use NuGet.Versioning to make this easier
2020-09-17 21:02:46 -07:00
Brennan 3ee23fb771
Refactor transient state in Java client (#24219)
* Refactor transient state in Java client

* some fb

* fix nullref

* fixup rebase

* fb

* apply some fb

* fix flaky

* lock

* check previous state
2020-09-17 17:59:27 -07:00
Brennan 899deacb22
Fix SignalR+WebSockets on WASM (#25922)
* Fix SignalR+WebSockets on WASM

* fb

* move stuff

* select
2020-09-17 11:30:31 -07:00
Pranav K 2921f5514a
dotnet-watch: continue printing output to console after the app is ready (#25984)
dotnet-watch redirects standard out to detect when the app is launched and
prints these redirected messages to the console. Unfortunately once the app
is launched, redirected messages are no longer printed. This wasn't caught earlier
since ASP.NET Core is very quiet by default.

ASP.NET Core apps launched via dotnet watch do not print output to the console.

Yes. This was introduced as part of changes to dotnet-watch to launch a browser in 5.0-preview8.

Low.
2020-09-16 18:53:59 -07:00
Steve Sanderson 8c23b53bef
Make timezone and ICU data available offline for PWA (#25954) 2020-09-16 16:49:09 -07:00
dotnet-maestro[bot] 9675fdb455
[release/5.0-rc2] Update dependencies from dotnet/arcade (#25963)
[release/5.0-rc2] Update dependencies from dotnet/arcade


 - Update create light/light command package drop task

 - Create output directory
2020-09-16 22:08:01 +00:00
Brennan ce76ae75f6
Fix Java packaging (#25838)
* Fix Java packaging

* fix flaky test
2020-09-15 10:20:43 -07:00
John Luo d14e273015
[5.0.0-rc2] Backport Fix chrome/selenium tests (#25330) (#25840)
* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f1504128a63431cb67830703922cdeefee525.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-14 18:43:42 -07:00
Kevin Pilch e3a52ee3de
Merge pull request #25881 from dotnet-maestro-bot/merge/release/5.0-to-release/5.0-rc2
[automated] Merge branch 'release/5.0' => 'release/5.0-rc2'
2020-09-14 15:24:14 -07:00
Pranav K a6f667bbb3
Add SkipAnalyzers=true to component declaration compilation (#25736)
* Update to latest SDK

* React to platform compatibility analyzer warnings
* React to new warnings
* Add platform compatibility attributes

* Add SkipAnalyzers=true to component declaration compilation
Fixes https://github.com/dotnet/aspnetcore/issues/25365

* Update eng/Version.Details.xml

* Update Versions.props

* Update Version.Details.xml

* Update Versions.props

* Update Version.Details.xml
2020-09-14 12:41:37 -07:00
Martin Costello a0ede85a61
Fix MSB4109 (#25880)
Fix MSB4109 error when the Microsoft.Extensions.ApiDescription.Server NuGet package is installed.
2020-09-14 12:07:15 -07:00
Doug Bunting 6c29f44a0b
Reduce references to Microsoft.AspNetCore.App.Runtime.csproj (#25836)
- dotnet-watch builds against runtime in the SDK
- other projects build after runtime project due to Ref.csproj reference
  - but, when the targeting packs aren't building, there's no reason to use Ref.csproj
- followup on 76fbd1a283 and 84962660a3, reducing parallelism in build
2020-09-14 11:34:07 -07:00
Steve Sanderson ccbc46c076
Fix RCL template to have correct filename for scoped CSS (#25870) 2020-09-14 09:13:49 -07:00
John Luo 472e8297a7
Update identity web templates (#25834)
* Update identity web templates

* Do not generate scopeRequiredByApi if not needed
2020-09-14 07:58:03 -07:00
Doug Bunting e3b632894d
Fix Helix testing issues with stable versions and local builds (#25865)
- include all shipping packages in Helix payloads that need runtime
  - remove hard-coded `-ci` that broke Helix tests with stable versions or local builds
  - for local builds, do not assume `$(Configuration)` is Release
- support `$(HelixTargetQueues)` property used in RunHelix.ps1
  - lost somewhere along the lines; script ran full matrix

nits:
- clean up redundant addition of runtime and ref/ packages
  - `@(HelixContent)` additions in `_CreateHelixWorkItem` target are ignored
- mention '+' separation of `-HelixQueues` argument to RunHelix.ps1
- allow `$(IsUnitTestProject)` override in case we need it in the future
2020-09-13 21:45:23 -07:00
Pranav K ab5dfe5374
Allow dotnet-watch to look for changes to .razor.css files (#25792)
Fixes https://github.com/dotnet/aspnetcore/issues/25483
2020-09-13 14:46:47 -07:00
Doug Bunting b760d35b54
Support override of PlatformManifest.txt content in servicing (#25849)
- copied from release/3.1; not sure why this wasn't merged forward
- doing now ensures we don't forget if we need to service targeting packs
2020-09-13 11:40:09 -07:00
Pranav K 99496b41a0
Nullability feedback for public types in Components (#25821)
* EventCallback.InvokeAsync can pass a null value
* Remove unused BindFormatterWithFormat
2020-09-13 10:01:21 -07:00
Javier Calvarro Nelson b1e1aabc9d [Mvc] Fix global state in controller and action endpoint data sources.
* Create data sources "per router" instance.
* Make a global shared order sequence "per router" for conventional and
  controller and page routes.
* Create DynamicControllerEndpointSelector and DynamicPageEndpointSelector
  instances per data source.
2020-09-12 10:03:32 -07:00
Javier Calvarro Nelson a17842a2e4 [Mvc] Add support for order in dynamic controller routes (#25073)
* Order defaults to 1 same as conventional routes
* An incremental order is applied to dynamic routes as they are defined.
2020-09-12 10:03:32 -07:00
James Newton-King 340ee72715
Update gRPC version in template to 2.32.0-pre1 (#25587)
* Update gRPC version in template to 2.32.0-pre1

* Log server timeout detail

* Only run interop tests on windows queues

Co-authored-by: John Luo <johluo@microsoft.com>
2020-09-11 20:23:16 -07:00
Doug Bunting 326507bb01
Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790)
* Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values
- Ensure `$(SharedFxVersion)` doesn't change in `$(NoSemVer20)` projects
- Ignore current project's `$(VersionSuffix)` in `$(TargetingPackVersion)`
    - Never assume `$(AspNetCoreBaselineVersion)` matches released targeting pack
- Stabilize both versions correctly
- Use these properties more widely
    - Remove other mechanisms to get the same values
    - Reduce use of the `_GetPackageVersionInfo` target
    - Reduce use of `$(SharedFxVersion)` for the targeting pack

nits:
- Correct comments about old RTMVersions.csproj project
- Fix or remove a few other comments

* Do not pass package filenames on Helix command Lines
- remove parsing of these command-line arguments from `RuntestOptions`
  - instead craft the names using passed `$(SharedFxVersion)`
- restore `$(DotNetRuntimeSourceFeedKey)` on Helix command line
  - lost somewhere along the line
- correct argument count in runtests.sh
  - treated 11th argument as both Helix timeout and feed credential
  - count was messed up somewhere alone the line

nits:
- update C# syntax in `RuntestOptions` e.g. remove unused `public` setters
- sort and group properties and their assignments
2020-09-11 19:17:28 -07:00
Chris Ross b5515a8dac IIS: Identify if a request has a body (#25381) 2020-09-11 17:43:36 -07:00
Pranav K 004cd1a9d9
PR feedback for platform compatibility update (#25815)
* PR feedback for platform compatibility update

Follow up to https://github.com/dotnet/aspnetcore/pull/25421

* Add SupportedOSPlatform attributes to a few more DataProtection API
* Update the SDK to rc2
* Clean up warning suppression in CertificateManager
* React to nit feedbacks

Fixes https://github.com/dotnet/aspnetcore/issues/25781

* Apply suggestions from code review
2020-09-11 14:32:02 -07:00
Stephen Halter 3932156a95
Improve Http1ContentLengthMessageBody's reset logic (#25799) 2020-09-11 13:57:23 -07:00
Brennan 9eb9de6c8c
[Java] Catch errors from user callbacks (#25513)
* [Java] Catch errors from user callbacks

* test logger

* rebase

* fb
2020-09-11 11:44:00 -07:00
Chris Ross 4383118ef8
IIS: Identify if a request has a body (#25381) 2020-09-11 11:40:25 -07:00
Brennan 83e31342a1
[Kestrel] Deflake app abort test (#25484)
* [Kestrel] Deflake app abort test

* better

* fb
2020-09-11 10:53:45 -07:00
William Godbe f7a76173e4
Re-enable Helix tests for signalR java client (#25783)
* Re-enable Helix tests for signalR java client

* Change path to test results
2020-09-11 10:26:49 -07:00
William Godbe 77be06a894
Support primitive type/classes in HubConnection.on() (#25773)
* Support primitive type/classes in HubConnection.on()

* Small refactor

* Spacing
2020-09-11 10:11:29 -07:00
William Godbe 84962660a3
Strip duplicates from BuiltProjectOutputGroupOutput (#25785) 2020-09-11 10:11:10 -07:00
Brennan c32089a5e2
Add SignalR Client on WASM smoke test (#25526)
* Add SignalR Client on WASM smoke test

* Move test into BasicTestApp

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
2020-09-11 09:23:08 -07:00
Brennan 2ab6436cdd
Set ShutdownTimeout in Kestrel tests (#25743) 2020-09-11 09:21:18 -07:00
Brennan a7d129cc97
Send CloseMessage in more cases (#25693)
* Send CloseMessage in more cases

* fb
2020-09-11 09:21:02 -07:00
Chris Ross 11b85eb7e2
Add Windows.10.Amd64.Server20H1.Open helix queue (#25627) 2020-09-10 19:36:42 -07:00
Sayed Ibrahim Hashimi 118d6b2986
Updating titles in project templates because in Visual Studio the (#25630)
templates will be showing the templates directly in the New Project
Dialog instead in the One ASP.NET dialog.

In this PR I have updated the English titles. For localized strings we
will need to get those from the localization team. I believe we are not
setup for that to be automated here.

I think we should merge the English strings because they are the most
used, and for other locales we will show the old localized names for
now. If it's difficult to get those localized, I can work with @phenning
to see if we can localize those files this time.
2020-09-10 18:46:32 -07:00
Brennan 970d0f5d00
[SignalR] Copy cookies from negotiate to WebSockets (#24572) 2020-09-10 18:22:14 -07:00
Stephen Halter 327d55d01c
Prevent ODE when response body isn't reset (#25779) 2020-09-10 18:14:08 -07:00