Commit Graph

668 Commits

Author SHA1 Message Date
John Luo e62bd65421
Lift OIDC and JwtBearer dependencies in templates (#26390)
Reimplementing the changes originally included in https://github.com/dotnet/aspnetcore/pull/24600

Co-authored-by: Safia Abdalla <safia@microsoft.com>
2020-09-29 11:11:56 -07:00
Safia Abdalla b925b2886a
Pass all scopes in token request and update IndividualLocalAuth template (#26232)
* Pass all scopes in token request and update IndividualLocalAuth template

* Fix build and address feedback from peer review
2020-09-23 20:42:44 -07:00
Sayed Ibrahim Hashimi d97ef5ccd4
Updated icons for projects that appear in VS with icons that have the (#25974)
* Updated icons for projects that appear in VS with icons that have the
language adornment.
This PR should fix #25973.

* updating icons for asp.net core templates in vs
2020-09-21 13:04:31 -07:00
Hao Kung 6bfffda734
Remove ComponentsWebAssembly shared layout (#26078) 2020-09-19 11:12:38 -07:00
Steve Sanderson 8c23b53bef
Make timezone and ICU data available offline for PWA (#25954) 2020-09-16 16:49:09 -07:00
John Luo d14e273015
[5.0.0-rc2] Backport Fix chrome/selenium tests (#25330) (#25840)
* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f1504128a63431cb67830703922cdeefee525.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-09-14 18:43:42 -07:00
Steve Sanderson ccbc46c076
Fix RCL template to have correct filename for scoped CSS (#25870) 2020-09-14 09:13:49 -07:00
John Luo 472e8297a7
Update identity web templates (#25834)
* Update identity web templates

* Do not generate scopeRequiredByApi if not needed
2020-09-14 07:58:03 -07:00
Doug Bunting 326507bb01
Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values (#25790)
* Correct `$(SharedFxVersion)` and `$(TargetingPackVersion)` values
- Ensure `$(SharedFxVersion)` doesn't change in `$(NoSemVer20)` projects
- Ignore current project's `$(VersionSuffix)` in `$(TargetingPackVersion)`
    - Never assume `$(AspNetCoreBaselineVersion)` matches released targeting pack
- Stabilize both versions correctly
- Use these properties more widely
    - Remove other mechanisms to get the same values
    - Reduce use of the `_GetPackageVersionInfo` target
    - Reduce use of `$(SharedFxVersion)` for the targeting pack

nits:
- Correct comments about old RTMVersions.csproj project
- Fix or remove a few other comments

* Do not pass package filenames on Helix command Lines
- remove parsing of these command-line arguments from `RuntestOptions`
  - instead craft the names using passed `$(SharedFxVersion)`
- restore `$(DotNetRuntimeSourceFeedKey)` on Helix command line
  - lost somewhere along the line
- correct argument count in runtests.sh
  - treated 11th argument as both Helix timeout and feed credential
  - count was messed up somewhere alone the line

nits:
- update C# syntax in `RuntestOptions` e.g. remove unused `public` setters
- sort and group properties and their assignments
2020-09-11 19:17:28 -07:00
Sayed Ibrahim Hashimi 118d6b2986
Updating titles in project templates because in Visual Studio the (#25630)
templates will be showing the templates directly in the New Project
Dialog instead in the One ASP.NET dialog.

In this PR I have updated the English titles. For localized strings we
will need to get those from the localization team. I believe we are not
setup for that to be automated here.

I think we should merge the English strings because they are the most
used, and for other locales we will show the old localized names for
now. If it's difficult to get those localized, I can work with @phenning
to see if we can localize those files this time.
2020-09-10 18:46:32 -07:00
Javier Calvarro Nelson 31fcc8bd26
Update error page (#25706) 2020-09-10 10:20:19 -07:00
Steve Sanderson ecc2ba16b8
Accessibility fixes (#25678)
* Fix header tab ordering issues. Fixes 1163117

* Ensure text can be zoomed to 200% without switching to mobile layout. Fixes 1163184.

* Ensure "Log out" link can show focus state. Fixes 1162890

* Use screen reader-friendly link text. Fixes 1163642

* Update template test
2020-09-09 11:08:10 -07:00
Artak 0d548f302b
Enable PlatformCompatibilityAnalyzer for RCL projects (#25636) 2020-09-09 09:57:42 -07:00
Steve Sanderson 9f5276d17a
Update RCL template to use 5.0 features (#25613)
* Update JS interop to use auto-loaded ES6 module

* Test update

* Make it lazy for compatibility with prerendering

* Update comment

* Code style: go back to .AsTask - it's probably easier to read
2020-09-09 08:25:26 -07:00
John Luo 0a33267c1c
Simplify blazorserver template for individual local auth support (#25523) 2020-09-08 15:42:19 -07:00
John Luo c902645115
Add MigrationsEndPoint when DatabaseDeveloperPageExceptionFilter is used (#25554) 2020-09-04 15:46:14 -07:00
Javier Calvarro Nelson 3d38d397ae
[Blazor] CSS isolation follow-ups (#25565)
This change includes several improvements to CSS isolation that we have gathered from validation and usage feedback.

We have switched from producing a single scoped CSS bundle file for the entire application with all the scoped css files from the current project, referenced projects and package projects to producing one bundle per referenced project/package and to include those bundles into an "application" bundle throught CSS @import statements.

We have cleaned up the bundle names to make them more unique by including the project name on them and we have also cleaned up the bundle extensions.

We have decided to put the individual bundles generated for the project scoped css assets into the static web assets base path of the project, so that when developers reference assets from their scoped css files (like using the CSS url function) the path they use matches what they have inside their library wwwroot folder.

We have decided to put the application bundle on the root path of the application provided that the developer has not overriden the default StaticWebAssetsBasePath.

This is so that the bundle location is consistent across templates, and can be found at ProjectName.styles.css independent of whether the app is a blazor webassembly app or a server side blazor app.

For cases where the default StaticWebAssetBasePath has been overriden, the value is respected and the bundle is placed at $(StaticWebAssetBasePath)/ProjectName.styles.css.

Packaged razor class libraries with scoped css files now package a "project" bundle instead of the individual files.
2020-09-04 10:54:44 -07:00
John Luo 6bdb4b95f9
Fix BlazorServer Identity templates (#25456)
Remove @using Microsoft.AspNetCore.Components.Web.Virtualization in blazorserver template.
2020-09-01 09:30:00 -07:00
John Luo 222dd67175
Fix Unhandled DBErrors in ComponentsWebAssembly and Spa templates (#25466)
* Add workaround for EF issue dotnet/efcore#22341
2020-09-01 07:26:33 -07:00
Safia Abdalla 50f739a4bc
Set supported platform on Shared project (#25376) 2020-08-31 10:17:33 -07:00
Jean-Marc Prieur 744e96b23d
Updating Web project templates to ms.id.web 0.3.0-preview (#25309)
* Updating Web project templates to ms.id.web 0.3.0-preview

* version bump
and quick fix to the Blasorwasm default values for
the Web api so that customers have a better experience

* Microsoft.Graph is brought in transitively by MS.ID.Web

Co-authored-by: John Luo <johluo@microsoft.com>
2020-08-28 19:56:37 -07:00
Safia Abdalla 97280fe5f6
Revert identity package workaround and bump versions (#24819)
* Revert "Add workaround for deprecated overload in authentication scenarios (#24600)"

This reverts commit 7eb58e045d.

* Update identity package versions
2020-08-28 09:00:09 -07:00
John Luo 7b8fe53234
Disable failing/hanging tests due to Chrome/Selenium issue (#25323) 2020-08-27 13:16:01 -07:00
Doug Bunting c2f0331805
Include project file in F# Worker Service template (#25180)
- add test of this project template
2020-08-25 10:47:37 -07:00
ar0311 f2c3c11a2d
Minor typos (#25140) 2020-08-24 15:51:09 -07:00
Pranav K 0960a7a0c5
Configure OpenAPI as part of webapi project template creation (#25110)
* Configure OpenAPI as part of webapi project template creation
Fixes https://github.com/dotnet/aspnetcore/issues/25080

* Update to default to WebAPI
2020-08-21 23:44:11 +00:00
Pranav K 3e8c5c48f0
Add support for views + SingleFileExe (#24925)
* Add support for views + SingleFileExe
2020-08-20 19:46:58 -07:00
Pranav K 6a9241b920
Skip test for now 2020-08-20 14:59:39 -07:00
Pranav K 57db5937f8
Fixup test 2020-08-19 11:23:02 -07:00
Javier Calvarro Nelson 38563dd8d1
[Blazor][Identity] Update to the latest identity server version (#25002)
* Updates to IdentityServer 4.0.4
* Updates templates with the new migrations.
* Fixes a small configuration bug that required the configuration for the key to be specified.
* Updates the error url in IdentityServer config to match our template defaults.
2020-08-19 02:12:35 -07:00
Pranav K ad8a927e85
Changes per discussion. Add a test 2020-08-18 17:56:59 -07:00
John Luo cfe158cbed
Convert DatabaseErrorPage to exception filter (#24588)
* Convert DatabaseErrorPage middleware to exception filter
2020-08-17 11:13:17 -07:00
msftbot[bot] d3eaa2f450
Merge pull request #24927 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-15 04:06:42 +00:00
John Luo 7acb96af5e
Align scope used by client and server in blazor wasm template (#24894) 2020-08-14 18:25:42 -07:00
Pranav K 8e5533f2a3
Use BlazorWebAssemblySDK (#24371)
* Use BlazorWebAssemblySDK

* Update projects to use the BlazorSDK
* Remove tasks and targets from RazorSDK
* Remove workarounds from BlazorSDK

* Fixup

* Fixup
2020-08-11 17:29:01 +00:00
Pranav K fd1a5c5a9c
Merge pull request #24641 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-08-10 17:13:51 -07:00
Pranav K 56be06bc7d
Update test runner to 2.4.3 (#24685) 2020-08-10 12:32:04 -07:00
Pranav K 6e006e3e2a
Merge remote-tracking branch 'origin/release/5.0-preview8' 2020-08-10 11:39:18 -07:00
Safia Abdalla 7eb58e045d
Add workaround for deprecated overload in authentication scenarios (#24600)
* Add workaround for deprecated overload in authentication scenarios

* Respond to feedback from peer review

* Use explicit version in Version.props

* Temporarily disable NU1065 warning

* Always use latest package version
2020-08-07 08:37:16 -07:00
Steve Sanderson d99644ef9c
Move reconnection delay mechanism into framework code (#24566) 2020-08-05 16:00:54 +01:00
Doug Bunting e13368391b
Keep `@(Reference)` metadata when creating `@(ProjectReference)` items (#21567)
- #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages
- make `@(Reference)` items much more broadly applicable
- emit an error when `@(ProjectReference)` is used instead of `@(Reference)`
    - then get rid of the errors (!!)
- rename a couple of projects to match their assembly names
    - then regenerate the `@(ProjectReferenceProvider)` items
- switch intersection approach from Exclude / Exclude to Copy / Update / Copy

Projects of particular interest:
- src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
    - honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged
    - removed redundant metadata after that confirmation
- src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/
    - content of this package unchanged but metadata avoids extra work
    - add a comment about the extra work
- src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/
    - success! removes Microsoft.Web.Xdt.Extensions dependency from the package
- src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
    - add a `Condition` to avoid an ordering issue I hit here
- src/Tools/Extensions.ApiDescription.Server/src/
    - avoid errors the new build ordering and timing caused

Separately, up the timeout in the `<DownloadFile />` task
- hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip

nits:
- remove dupe `@(Reference)` item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
- remove useless `%(ProjectReference.IsImplicitlyDefined)` metadata as well as its misspellings
- remove extra spaces from ProjectReferences.props
- clean up a few comments in ResolveReferences.targets

* !fixup! Correct other references to renamed projects
2020-08-04 10:05:55 -07:00
SQL-MisterMagoo 1be16fb4c9
Add delay before showing Reconnection UI (#24137)
* Add CSS delay before showing Reconnection UI

* rebuild yet again to try and get past the conflict
2020-08-04 04:14:46 +00:00
Mackinnon Buck 4ef5e10e6d
Virtualization support (#24179) 2020-08-03 17:02:12 -07:00
Daniel Roth e31998c94b
Update Blazor Server survey link for .NET 5 (#24507) 2020-08-03 13:46:09 -07:00
Daniel Roth 4bb01a5a43
Update Blazor WebAssembly in-product survey link for .NET 5. (#24508) 2020-08-02 09:59:30 -07:00
Safia Abdalla d6ed98044d
Merge branch 'master' into merge/release/5.0-preview8-to-master 2020-07-30 10:54:18 -07:00
John Luo fd9f17ddf9
Update blazor templates with Microsoft.Identity.Web APIs (#24268)
* Update blazor and components web templates

* Update Identity.Web version to 0.2.1-preview
2020-07-29 10:31:47 -07:00
Javier Calvarro Nelson 3cf39cf7e1
Update the templates CSS to leverage CSS isolation (#24380)
* Template changes

* Template changes + scope computation update

* Template updates

* tmp

* Fix style path

* Webassembly template changes

* Update tests

* Undo blazor.server.js changes

* WebAssembly cleanups

* Undo unwanted change

* Undo another unwanted change

* Fix server-side login combinator

* update tests, switch from app to div id=app
2020-07-28 15:29:57 -07:00
msftbot[bot] 8de0c7386c
Merge pull request #24373 from dotnet-maestro-bot/merge/release/5.0-preview8-to-master
[automated] Merge branch 'release/5.0-preview8' => 'master'
2020-07-28 18:21:05 +00:00
Phil Henning 28d5d49c21
Support SSO for Blazor WASM template (#23815)
Thanks @phenning and @javiercn !
2020-07-28 10:05:09 -07:00