384a518bda
Implement MaxRequestHeadersTotalSize for HTTP/2 #2812
2018-09-06 09:07:16 -07:00
edc1935475
Flow the cancellation tokens to ReadAsync and WriteAsync ( #2865 )
2018-09-06 09:04:39 -07:00
991cfa8bd8
Remove limits on SETTINGS_HEADER_TABLE_SIZE #2874
2018-09-04 12:01:13 -07:00
153020ef8a
Allow UTF8 encoded header values
2018-08-30 16:21:34 -07:00
1a43e67542
Remove workaround for dotnet/corefx#24562 ( #2863 )
...
This issue caused a bind to a recently used endpoint to fail on macOS and Linux.
Addresses #2820
2018-08-28 15:59:17 -07:00
5ea537fbc4
Don't advance examined in Http1MessageBody.PumpAsync for canceled reads ( #2847 )
2018-08-28 11:28:17 -07:00
89f4850883
Avoid throwing the same exception instances in parallel ( #2859 )
2018-08-28 10:56:46 -07:00
6dc55a0462
Don't preserve the ExecutionContext when dispatching callbacks ( #2861 )
...
* Don't preserve the ExecutionContext when dispatching callbacks
- The layers up stack already preserve and restore the ExecutionContext, there's no need to capture and run for the scheduler callback and cancellation token callback
2018-08-28 09:32:33 -07:00
f70ba53253
Fix race when SystemClock is accessed before first heartbeat ( #2851 )
2018-08-27 10:59:29 -07:00
64127e6c76
Implement MaxFrameSize and HeaderTableSize for HTTP/2
2018-08-24 11:07:41 -07:00
d318d7b94d
Make tests less flaky ( #2848 )
...
- Re-order logs with completing the task
2018-08-23 22:29:56 -07:00
fc3c2eef5e
Handle SocketError.ProtocolType as a connection reset on macOS ( #2845 )
...
* Handle SocketError.ProtocolType as a connection reset on macOS
* Make IsConnectionResetError and IsConnectionAbortError stricter
2018-08-23 19:16:44 -07:00
e5a1101239
Improve exception handling in SocketConnection ( #2844 )
...
- Avoid race where a connection reset observed by both DoSend() and DoReceive()
resulted in a ConnectionAbortedException being thrown from the input Pipe
instead of a ConnectionResetException.
2018-08-23 16:59:02 -07:00
68a0863524
General connection management ( #2834 )
...
This change makes the handling of graceful shutdown work for more than just http scenarios. This should allow us to move TLS further out and should also allow us to start moving things to connection middleware instead of connection adapters.
Summary of the things changed/added:
- Added IConnectionLifetimeNotificationFeature that represents an attempt to gracefully close the connection that isn't being aborted. This feels pretty awful but we may have to do it.
- Moved connection management to the ConnectionDispatcher and out of the HttpConnectionMiddleware
- Removed Http from the names of the ConnectionManager and Heartbeat
2018-08-22 20:35:28 -07:00
0b471f2b2f
Sockets: do 0 byte reads to avoid allocating memory for idle connections
...
- Do not do 0 byte reads on OSX due to potential sockets bug
2018-08-21 18:07:15 -07:00
6f7a841374
Fire OnStreamCompleted after all pipes are closed
2018-08-17 17:45:47 -07:00
aa9dde2457
Extract bitshift helper code, Frame cleanup #2773
2018-08-17 15:48:16 -07:00
83488886e0
Clean up some remants of the past ( #2827 )
...
- Remove Application from HttpConnectionContext and Http*ConnectionContext (it's no longer required)
2018-08-15 23:41:32 -07:00
5becb72107
Improve test logs ( #2826 )
...
- Include hosting logs in some tests that where previously missing them
- Prevent duplicate logs from Mock CallBase an CompositeKestrelTrace
- Log ports used by transport functional tests
- Add file logging to HTTP/2 "unit" tests
2018-08-15 18:31:56 -07:00
0c2923135b
Limit concurrent HTTP/2 Streams per connection #2815
2018-08-15 15:58:57 -07:00
43398482a5
Implement MaxRequestBodySize for HTTP/2 #2810
2018-08-13 12:06:21 -07:00
cd6de2fa18
Improve HTTP/2 stream abort logic ( #2819 )
...
- Fix race where headers frame could be written after an abort was observed
- Fix Http2StreamTests to verify expected abort-related exceptions
2018-08-13 11:45:17 -07:00
62a30a731d
Fix bug in graceful shutdown
2018-08-10 00:17:29 -07:00
cef46fdaa7
Merge branch 'johluo/more-graceful' into release/2.2
2018-08-09 12:00:36 -07:00
7c9e234457
Gracefully wait for streams to complete when pipe completes
2018-08-09 11:59:47 -07:00
c8418c6de8
Derive SocketAwaitable from SocketAsyncEventArgs ( #2592 )
...
* SocketSenderReceiverBase as baseclass for SocketSender and SocketReceiver
* Made SocketAwaitable.GetResult inlineable
* SocketAwaitable renamed to SocketAwaitableEventArgs and inherited from SocketAsyncEventArgs
Thus saving an extra object (`SocketAwaitable`) and two int-fields, so less allocations.
2018-08-09 11:24:06 -07:00
c0557cfca7
Improve exception handling in Http2Connection.ProcessRequestsAsync ( #2787 )
2018-08-08 11:20:49 -07:00
5378900e0c
Ack settings before window updates #2772
2018-08-08 11:19:23 -07:00
c73d513289
Add Http2 frame logging
2018-08-08 09:46:42 -07:00
0e99235d59
Add in-memory functional test project ( #2780 )
...
- Run AddressRegistrationTests independently to avoid port conflicts
- Only run tests that verify transport behavior for each transport
2018-08-07 15:34:11 -07:00
8a74cf3ed5
Gracefully shutdown HTTP/2 connections on server and client initiated shutdown
2018-08-07 10:59:29 -07:00
ea7e53cab0
Send Resets for unhandled app exceptions #2733
2018-08-06 11:35:42 -07:00
beca0259c2
Verify request Content-Length #2733
2018-08-02 13:23:57 -07:00
6d46410a76
Don't ACK ACKs ( #2767 )
2018-07-30 12:25:32 -07:00
647e7c3266
Add new ConfigureKestrel extensions #2760
2018-07-27 15:25:18 -07:00
c7dd9ff68a
Enable Http/2 by default #2720
2018-07-27 12:51:12 -07:00
94cfc01fbf
Implement HTTP/2 input flow control ( #2740 )
2018-07-27 10:47:27 -07:00
1f3524787e
Merge branch 'release/2.1' into release/2.2
2018-07-24 11:43:13 -07:00
612fcca729
Validate Http/2 pseudo headers #2205 #2263 #2659
2018-07-19 16:25:10 -07:00
603cd03bfa
Stop writing responses after the unexpected end of request content ( #2734 )
2018-07-19 14:18:57 -07:00
b934e46161
Complete the transport pipes after connection middleware runs ( #2735 )
2018-07-19 11:49:46 -07:00
429bcfe216
Sending and receiving RST frames. #2462
2018-07-16 09:13:11 -07:00
6551eae321
Consolidate HTTP charset validation logic
2018-07-13 16:47:28 -07:00
f179339a79
Combine BufferWriter and CountingBufferWriter
2018-07-12 11:58:49 -07:00
864cfeb2aa
Merge branch 'release/2.1' into release/2.2
2018-07-12 11:18:41 -07:00
128eefdef3
Remove usage of the Microsoft.Extensions.Buffers.Sources package, copy the source into Kestrel
...
This moves source code that used to be in aspnet/Common. It was only used here, so this simplifies the process of working with these internal-only APIs.
cref https://github.com/aspnet/Common/pull/386
2018-07-11 22:31:23 -07:00
a826f478ad
Implement HTTP/2 output flow control ( #2690 )
2018-07-10 14:11:59 -07:00
1d9db7c25f
Merge 2.1.2 into release/2.1
2018-07-10 10:34:35 -07:00
2ab22ac55a
Merge branch 'release/2.1' into dev
2018-06-28 11:27:11 -07:00
ac31e5ab30
[2.1.3] Consistently handle connection aborts ( #2619 )
...
* Decouple connection objects from the server (#2535 )
- Making progress towards being able to use the connection objects on the client side.
* Wait for input writer to complete before calling OnConnectionClosed (#2566 )
* Wait for the ConnectionClosed token to stop tracking connections (#2574 )
- The prior strategy of waiting for the pipe completed callbacks doesn't work
because blocks are returned to the memory pool after the callbacks are fired.
* Consistently handle connection resets (#2547 )
* Provide better connection abort exceptions and logs
* void IConnectionDispatcher.OnConnection
2018-06-28 10:51:22 -07:00
423d5432be
Add test for ensuring HPACK lowercase header names
...
- ensure lowercase mask only applied to uppercase letters
2018-06-26 10:44:21 -07:00
61e16e2b31
Automation for h2spec functional tests #2640
2018-06-21 11:17:16 -07:00
324565772c
Prevent app code from blocking the connection loop #2657
2018-06-20 11:06:49 -07:00
c498f03cb4
Expose Tls details as a feature. #2661
...
Limit Http/2 to TLS 1.2 #2251
Bootstrap functional tests #2238
2018-06-18 16:25:18 -07:00
14f020cf11
Improve tracking of connection lifetime ( #2646 )
2018-06-15 11:10:38 -07:00
13663e1e15
Convert to using definitions from HeaderNames
2018-06-13 11:24:24 -07:00
ff3f0e905d
Merge branch 'release/2.1' into release/2.1.2
2018-06-12 14:16:29 -07:00
a217206f1f
Enforce max frame size #2651
2018-06-11 14:20:43 -07:00
810a302e66
Disable AllowRenegotiation for HTTP/2
2018-06-11 13:51:23 -07:00
00827e38bb
Harden TFM checks #2624
2018-06-07 14:56:23 -07:00
0aff4a0440
Handle client and server aborts differently from eachhother ( #2612 )
...
* Trace when app aborts connection
* Improve exception messages
* Always abort connection with ConnectionAbortedException
* Add ConnectionContext.Abort(Exception)
2018-06-01 14:42:30 -07:00
aa9b9ca724
Merge branch 'release/2.1' into dev
2018-05-31 16:29:14 -07:00
e4d290b601
Fix Json regression in Socket Transport ( #2578 )
2018-05-31 16:28:25 -07:00
d1416e679b
[2.1.1] Provide clearer exception message for breaking change ( #2623 )
...
- In 2.1, the default transport (Sockets) can no longer bind to certain
endpoint types (Unix domain sockets and open socket handles).
- The new message recommends manually selecting the libuv transport
to work around this issue.
2018-05-31 15:45:26 -07:00
af177c5adc
Add Memory<byte> overloads to HttpUpgradeStream ( #2622 )
2018-05-31 15:44:39 -07:00
9e15b2bca4
Fix PipeReader consumption pattern [2.1]
2018-05-31 11:27:38 -07:00
7e43d35049
Make ListenOptions.Protocols public again for HTTP/2 work
2018-05-30 12:25:38 -07:00
f80091a328
Merge branch 'release/2.1' into dev
2018-05-29 16:37:16 -07:00
5ec7bacdfe
Lower severity of AuthenticationException logs from SslStream handshake ( #2614 )
2018-05-29 16:27:16 -07:00
a9d6cf13eb
Consistently handle connection resets ( #2547 )
2018-05-22 16:38:21 -07:00
27799b5acb
Enable pubternability analyzer ( #2560 )
2018-05-16 13:42:56 -07:00
f8f6f39f55
Wait off the ConnectionClosed token to stop tracking ConnectionCallback ( #2574 )
...
- The prior strategy of waiting for the pipe completed callbacks doesn't work
because blocks are returned to the memory pool after the callbacks are fired.
2018-05-15 12:38:35 -07:00
c683316253
Generate repetitive TransportConnection FeatureCollection code ( #2548 )
2018-05-14 17:20:48 -07:00
04f2101696
Reenable api check
2018-05-14 13:36:39 -07:00
514917b9a8
Wait for input writer to complete before calling OnConnectionClosed ( #2566 )
2018-05-14 11:51:49 -07:00
b040e33b1b
Merge branch 'release/2.1' into dev
2018-05-10 23:47:51 -07:00
da21fc89cf
Handle exception in SocketConnection.Shutdown() ( #2562 )
2018-05-10 23:39:06 -07:00
e6a88c1b9c
Relieve response backpressure immediately when closing socket ( #2557 )
...
* Relieve response backpressure immediately when closing socket
2018-05-10 17:13:57 -07:00
f04118fca1
Merge branch 'halter73/merge-2.1-dev' into dev
2018-05-09 17:27:47 -07:00
80fa1d699d
Upgrade to netcoreapp2.2
...
This reverts commit fe9da3c57b
2018-05-09 16:43:15 -07:00
fe9da3c57b
Revert "Don't touch product repos"
...
This reverts commit 8e9f05b902
2018-05-08 16:52:48 -07:00
8e9f05b902
Don't touch product repos
2018-05-08 15:38:20 -07:00
350310aa96
Handle netcoreapp cases
2018-05-08 15:38:20 -07:00
c8d374af64
Merge branch 'release/2.1' into dev
...
# Conflicts:
# build/dependencies.props
# korebuild-lock.txt
# src/Kestrel.Transport.Libuv/Internal/LibuvConnectionContext.cs
2018-05-07 15:47:20 -07:00
05d68efbae
Merge branch 'release/2.1.0-rc1' into release/2.1
2018-05-07 14:35:41 -07:00
5c17bff55d
Don't throw on FIN from upgraded connections ( #2533 )
...
* Allow app to drain request buffer after FIN
2018-05-04 16:21:07 -07:00
8b1fbad10e
Don't complete KestrelServer.StopAsync task inline ( #2534 )
2018-05-03 17:01:36 -07:00
b23d9b7679
Decouple connection objects from the server ( #2535 )
...
- Making progress towards being able to use the connection objects on the client side.
2018-05-01 12:01:24 -07:00
2f2a0047a1
React to pool cleanup ( #2526 )
2018-04-30 08:37:15 -07:00
6f2f496c3d
React to splitting memory pool ( #2521 )
2018-04-24 14:11:47 -07:00
b0e1fa5e30
Fix connection abort
2018-04-23 17:01:49 -07:00
6fd09af374
Improve logging of request drain timeout ( #2480 )
2018-04-16 11:53:10 -07:00
3a45136cc4
make IConnectionInherentKeepAliveFeature a boolean feature ( #2496 )
2018-04-16 11:34:06 -07:00
e30a02cee5
Less StringValue struct copies for header checks ( #2488 )
2018-04-13 18:21:50 -07:00
2d51d23697
Add file logging to functional tests
2018-04-13 14:53:57 -07:00
10f3b6863e
Avoid nullref in KestrelEventSource ( #2483 )
...
* Avoid nullref in KestrelEventSource
* Improve HostNameIsReachableAttribute to speed up test discovery
2018-04-12 17:29:34 -07:00
ee12c4fcf2
Downgrade HTTPs handshake failures to debug #1853
2018-04-12 09:25:44 -07:00
c6fa9793eb
Make Protocols internal
2018-04-12 08:53:27 -07:00
ca44b4adfc
Moved kestrel specific features into transport abstractions ( #2482 )
2018-04-11 20:23:48 -07:00
f6b2880369
Flow the ConnectionContext to the SNI callback ( #2478 )
2018-04-11 15:56:25 -07:00
Chris Ross (ASP.NET)
David Fowler
John Luo
Gert Driesen
Stephen Halter
Günther Foidl
Nate McMaster
Pavel Krymets
Pranav K
Ryan Brandenburg
Andrew Stanton-Nurse
Ben Adams