ivano
6e5187c1ae
Using new StringRouteConstraint for area constraint
2016-08-08 08:47:04 -07:00
Kiran Challa
ac98417398
ModelBinding: Remove IsReadOnly checks and add/update tests
2016-08-04 14:20:23 -07:00
ivano scifoni
be5deef584
Created option for RequireHttpsAttribute.Permanent
...
Fixes #4650
2016-08-04 11:43:16 -07:00
jacalvar
b56cab6414
Merge branch 'rel/1.0.1' into dev
2016-08-01 14:16:58 -07:00
jacalvar
f0732e9e21
[ Fixes #5038 ] HTTP Verbs mapping error GET and DELETE
...
When an action contained an attribute derived from HttpMethodAttribute,
doesn't specify an attribute route and there is also another attribute
extending HttpMethodAttribute that has a route defined on it; we ignored
the HttpMethodAttribute attribute without a defined route when building
the set of action selectors for the method.
This caused the resulting action to be unbounded and to accept requests
for other verbs not associated with it. The root cause of the problem was
that attributes override equality and do a field by field comparison but
ignore fields in the base classes of the type, so if an attribute is part
of a class hierarchy (like Http*Attributes) there might be two different
attributes that get considered equal.
The fix for the problem has been to change using Contains on a couple of
collections (that uses the equals method on the underlying object) and
check for the existence of the attribute on the collection directly by
using reference equality.
2016-08-01 12:49:23 -07:00
Ryan Nowak
e77dc3af6a
Implement manual state machine
2016-08-01 10:38:46 -07:00
N. Taylor Mullen
d60ed06c19
Add link tag attributes to generated fallback tags.
...
- Updated functional tests and link tag script to include modified extra attributes content.
#4084
2016-07-29 16:30:56 -07:00
Ryan Brandenburg
27a641f4bf
Only create filters for models that need them ( #5044 )
2016-07-27 16:36:26 -07:00
jacalvar
7a3f24d49d
[ Fixes #4960 ] Action results returned from controller actions rendered as json instead of executed
2016-07-27 14:42:46 -07:00
BrennanConroy
0a5f8e013e
AppDomain safety
2016-07-27 09:26:06 -07:00
Pranav K
5092e75387
Pin repo version to 1.0.1
2016-07-26 12:09:57 -07:00
Ajay Bhargav Baaskaran
4600100695
Added a test to verify ReflectionTypeLoadException
2016-07-25 12:06:16 -07:00
Ryan Nowak
fb514d7ef8
Update versions to 1.0.1-*
...
Also adding a version number to TestConfiguration. This is not a leaf node
so it should have a version.
2016-07-21 09:55:28 -07:00
Ryan Nowak
b80f4d31f3
Add a test to verify our service lifetimes
...
This test uses the new features in the service provider to verify that we
don't reference any scoped services from singletons.
Note that this can't really cover the cases where we have optional
services or where we replace default services (like DI for controllers).
You'll just have to be careful.
2016-07-20 17:10:52 -07:00
Doug Bunting
8a6e99c7c0
Always render antiforgery tokens if `!CanRenderAtEndOfForm`
...
- #5005
- also add `FormContext` doc comments
2016-07-20 15:25:08 -07:00
ivano scifoni
581a5ea573
column attribute for <textarea> is incorrect ( #5049 )
...
- Modify tagBuilder.MergeAttribute key to cols
2016-07-20 09:22:39 -07:00
Pranav K
6bdcf35670
Pin the version of dotnet-test-xunit to 1.0.0-rc3-00000-01
2016-07-19 11:14:56 -07:00
Kiran Challa
52a7c112e8
[ Fixes #4876 ] ContentResult forcing chunked encoding
2016-07-18 16:10:01 -07:00
Doug Bunting
e5cb6f9595
Add `null` check for `ModelStateEntry.Children`
...
- #4989
2016-07-18 14:02:17 -07:00
Kiran Challa
26b3b5ea7b
[ Fixes #4766 ] Remove disable buffering feature from our action result classes
2016-07-18 13:07:54 -07:00
Doug Bunting
52e4ca7232
Put `ModelBindingHelper` on a diet
...
- remove extra argument checks
- remove two test-only `ConvertTo()` overloads
- this relates to #4521
2016-07-15 11:53:32 -07:00
Pranav K
b7a0393311
Register DependencyContextRazorViewEngineOptionsSetup after RazorViewEngineOptionsSetup
...
Fixes #4902
2016-07-15 10:33:59 -07:00
zhangmm
ea73434979
Fix typo in test name
2016-07-15 10:01:39 -07:00
Doug Bunting
0ec2a3131f
Restore `[Fact]` and `[Theory]` attributes
...
- removed in 310ab25
2016-07-14 15:25:45 -07:00
Ryan Brandenburg
310ab25347
Make tests resilient to Localization ( #5011 )
2016-07-14 09:28:01 -07:00
ivano scifoni
b4677a44da
#4847 Fix MapAreaRoute override existing area constraint ( #4954 )
...
* #4847 Fix MapAreaRoute override existing area constraint
Modify Test project
Modify web test routing
* wrong field tested
* IntRouteConstraint expected
* Default for area route on Travel area
* Removed commented code
simplify constraintsDictionary area assign
renamed test method
* test name
* renamedd test to MapAreaRoute_DoesNotReplaceValuesForAreaIfAlreadyPresentInConstraintsOrDefaults
2016-07-11 10:53:33 -07:00
ivano scifoni
3d2bb673ee
Add IMvcCoreBuilder.AddJsonOptions extension method
...
Fixes #4967
2016-07-08 09:00:59 -07:00
Doug Bunting
7430efa8cc
One build to rule them all
...
- well, at least VS and command-line builds will share output
- part of aspnet/Coherence-Signed#277
2016-07-06 16:21:18 -07:00
Ajay Bhargav Baaskaran
e7de647c10
[ Fixes #453 ] Added unit tests for Display and Value Extensions
...
- Added more HtmlHelper tests
- Added some tests to cover complex expressions
2016-07-06 15:39:26 -07:00
Pranav K
7ce344270a
Show message about preserveCompilationContext when a Roslyn diagnostic error says a reference
...
could not be found.
Fixes #4911
2016-07-06 15:09:54 -07:00
Pranav K
ccff37126f
Removing extra imports from projects
2016-07-06 08:59:58 -07:00
Pranav K
222165e145
Updating to RTM builds of xunit and Moq ( #4946 )
2016-07-05 20:58:16 -07:00
Medeni Baykal
4fe758240f
Added `ViewResultTest`s. ( #4939 )
...
* Added `ViewResultTest`s.
* Fixed the namespace and folder of `PartialViewResultTest `; and some minor fixes.
2016-07-05 15:25:20 -07:00
Ryan Nowak
3ed0d01eae
Fix #4929 - Move IActionInvokerFactory from .Internal
...
Also added a wealth of doc comments to an area that's not currently super
well documented.
2016-07-05 13:18:34 -07:00
Doug Bunting
42cea41737
Fail more gracefully when option collections cleared
...
- #4690
- move `ModelBindingMessageProvider` init from `DefaultBindingMetadataProvider` to `DefaultModelMetadata`
- in addition to avoiding error cases, this removes some boilerplate
- add specific errors to `BodyModelBinderProvider`, `CompilerCache`, `CompositeViewEngine`, `ModelBinderFactory`,
and `ObjectResultExecutor`
- `DefaultRazorViewEngineFileProviderAccessor.FileProvider` now a `NullFileProvider` in empty case
2016-06-30 14:52:50 -07:00
Medeni Baykal
a852352223
Fix for https://github.com/aspnet/Mvc/issues/4903 . ( #4907 )
...
Fix for https://github.com/aspnet/Mvc/issues/4903 .
- `HtmlHelperTextAreaTest` added
- fix up `HtmlHelperTextBoxTest`
2016-06-29 10:11:54 -07:00
Crystal Qian
e51a118a9d
Added consistent model property to view result variants ( #4901 )
...
* Added consistent model property/tests to ViewResult, PartialViewResult, ViewComponentResult. This resolves #4813 .
* Removed unnecessary model asserts
* Removed redundant model checking
2016-06-28 09:38:37 -07:00
Pranav K
a1f4786695
Updating json files to pin versions and build files to pin KoreBuild
2016-06-27 13:51:10 -07:00
Crystal Qian
c319ae51a5
Changed min/max parameter order in StringLengthAttributeAdapter ( #4899 )
...
Changed min/max parameter order in StringLengthAttributeAdapter. This fixes #4864 .
2016-06-27 10:21:50 -07:00
Crystal Qian
dad6374258
Revert "Changed min/max parameter order in StringLengthAttributeAdapter"
...
This reverts commit d19765802b .
2016-06-22 15:34:53 -07:00
Crystal Qian
d19765802b
Changed min/max parameter order in StringLengthAttributeAdapter
2016-06-22 15:33:33 -07:00
Doug Bunting
f8c7f1ab78
Add more tests using `[ViewComponent(Name = "...")]`
...
- #4851
2016-06-19 13:52:59 -07:00
Shahriar Gholami
94fa34ca41
TempData convenience property added to ViewComponent ( #4873 )
...
* TempData convenience property added to ViewComponent
#4728
* PR feedback
2016-06-17 10:15:50 -07:00
Pranav K
cd7954a164
Updating to dev versions
2016-06-16 10:40:11 -07:00
N. Taylor Mullen
8499e3d6bb
Remove direct Microsoft.NETCore.Platforms dependency.
...
- Microsoft.NETCore.App now pulls this package in.
aspnet/Coherence-Signed#344
2016-06-13 15:30:27 -07:00
N. Taylor Mullen
0501531ec4
React to namespace changes in Razor.
...
aspnet/Razor#779
2016-06-13 11:22:56 -07:00
Doug Bunting
68974b2d1f
Add tests covering more JSON serialization cases
...
- #4844
2016-06-10 15:25:53 -07:00
Ryan Brandenburg
5339a3e0ce
Add ExceptionHandled to ExceptionContext ( #4825 )
2016-06-09 15:22:11 -07:00
Pranav K
8c8fd6446b
Use regular PDBs on full desktop when possible
...
Add a test to verify exceptions thrown from views is pretty printed by diagnostics middleware
Fixes https://github.com/aspnet/Diagnostics/issues/293
Fixes #4737
2016-06-09 14:59:38 -07:00
Kiran Challa
f1982bd987
Suppress default status code response type in api descriptions when explicit response types have been provided
...
[Fixes #4823 ] How to override the default (200) status code with ProducesResponseType
2016-06-09 12:07:52 -07:00