Commit Graph

331 Commits

Author SHA1 Message Date
Pranav K 3ce497f20d Avoid restoring RID specific packs that don't exist.
\n\nCommit migrated from 1826963086
2020-01-17 10:35:11 -08:00
Pranav K 427ec8a4c7 Rely on regular restores for RID-specific package restores (dotnet/aspnetcore-tooling#1502)
* Rely on regular restores for RID-specific package restores

* Pin the runtime to a previously shippped version in SDK tests

* Update src/Razor/test/testapps/Directory.Build.targets
\n\nCommit migrated from b0a60a0231
2020-01-16 17:49:21 -08:00
Justin Kotalik 18830cb2fe Update BuildIntrospectionTest.cs\n\nCommit migrated from 6712efc3af 2020-01-15 10:31:41 -08:00
Justin Kotalik 97c847b5f0 Merge branch 'release/3.1'
\n\nCommit migrated from 0ef68536ee
2020-01-15 10:01:46 -08:00
Artak c0bf414494 Merge pull request dotnet/aspnetcore-tooling#1383 from dotnet/javiercn/update-manifest-generation
[StaticWebAssets] Updates manifest generation to allow multiple content roots under the same base path for a single project\n\nCommit migrated from 5e957b4c3b
2020-01-15 09:02:47 -08:00
Artak c2cfbc87ab Merge pull request dotnet/aspnetcore-tooling#1442 from dotnet/javiercn/swa-publish-no-build
[StaticWebAssets][Fixes #AspNetCore/17426] Publish no build doesn't copy static web assets from referenced projects\n\nCommit migrated from 45a6c10276
2020-01-14 18:46:50 -08:00
Artak 631578fd74 Merge pull request dotnet/aspnetcore-tooling#1394 from dotnet/prkrishn/17308
Load the netcoreapp3.1 compiled task when running in Core MSBuild\n\nCommit migrated from a661e043e3
2020-01-14 18:46:22 -08:00
N. Taylor Mullen 8ea0f36d39 Remove Test variant Newtonsoft.Json.
- Our Newtonsoft.Json versions are now aligned.
\n\nCommit migrated from e7a506b1f4
2020-01-14 14:35:13 -08:00
Kevin Pilch 52b9fd85a2 Update links for repo moves/renames (dotnet/aspnetcore-tooling#1474)
\n\nCommit migrated from fae9a5fdbc
2020-01-08 16:51:55 -08:00
Ryan Brandenburg 91efa9310f TagHelper QuickInfo (dotnet/aspnetcore-tooling#1443)
Add Hover support for TagHelpers and Components\n\nCommit migrated from c7815ea4f2
2019-12-13 16:58:27 -08:00
Javier Calvarro Nelson 541323631f [StaticWebAssets] Updates manifest generation to allow multiple content
roots under the same base path for a given project.
\n\nCommit migrated from 5e68cb88e4
2019-12-13 05:30:38 -08:00
Javier Calvarro Nelson 3ff767b3d3 [StaticWebAssets][Fixes #AspNetCore/17426] Publish no build doesn't copy static web assets from referenced projects
\n\nCommit migrated from 6685cd6105
2019-12-10 12:22:09 -08:00
Javier Calvarro Nelson 0c907a8225 [Static web assets][Fixes #AspNetCore/17079] PublishSingleFile results in 404 errors for Nuget components
\n\nCommit migrated from 53dd89a41d
2019-12-05 07:52:49 -08:00
Pranav K 6ec0c445ce Load the netcoreapp3.1 compiled task when running in Core MSBuild
Fixes https://github.com/aspnet/AspNetCore/issues/17308
\n\nCommit migrated from 51e2a0ee64
2019-12-02 10:51:32 -08:00
William Godbe c5fce0fce2 Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migrated from a0b7461a65 2019-11-22 12:53:28 -08:00
William Godbe 9328e4723e Merge branch 'release/3.1' into merge/release/3.0-to-release/3.1\n\nCommit migrated from 7e480a52e3 2019-11-22 11:12:31 -08:00
William Godbe 6942c1c7e3 Switch to Arcade model for PackageIcon (dotnet/aspnetcore-tooling#1325)
* Update dependencies from Arcade
* Switch to dotnet-eng\n\nCommit migrated from e37c190d7d
2019-11-20 19:27:17 -08:00
Ajay Bhargav Baaskaran fefb8a56ae Rename support in VS Code and other fixes (dotnet/aspnetcore-tooling#1336)
* Rename support in VS Code and other fixes

* feedback

* more feedback
\n\nCommit migrated from 5e2a8c7924
2019-11-20 11:05:30 -08:00
dotnet-maestro[bot] da085ad36d [release/3.1] Update dependencies from aspnet/Extensions (dotnet/aspnetcore-tooling#1347)
* Update dependencies from https://github.com/aspnet/Extensions build 20191118.3

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.1.0-rtm.19568.3
- Microsoft.AspNetCore.Testing - 3.1.0-rtm.19568.3
- Microsoft.Extensions.CommandLineUtils.Sources - 3.1.0-rtm.19568.3
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.1.0-rtm.19568.3
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.1.0-rtm.19568.3
- Microsoft.Extensions.Logging - 3.1.0

Dependency coherency updates

- Microsoft.NETCore.App.Runtime.win-x64 - 3.1.0 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.DependencyModel - 3.1.0 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Ref - 3.1.0 (parent: Microsoft.Extensions.Logging)

* Update flaky test

* another test
\n\nCommit migrated from b6f8920b2e
2019-11-19 21:28:03 +00:00
Ryan Brandenburg d5bf4f3f93 PR feedback
\n\nCommit migrated from 2c43ce1688
2019-11-15 10:31:46 -08:00
Ryan Brandenburg 075c91176e Razor GoToImplementation
\n\nCommit migrated from 12d1eae488
2019-11-14 14:55:48 -08:00
Ryan Brandenburg db9b8526d9 Go to definition (dotnet/aspnetcore-tooling#1313)
Go to definition
\n\nCommit migrated from 6ad962ea1a
2019-11-13 15:36:20 -08:00
Brennan 6d0088d446 Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migrated from 348db011b7 2019-11-01 09:15:24 -07:00
Pranav K 7f36d6e5f0 Associate inputs and outputs for .Views dll with a set in FastUpToDate check (dotnet/aspnetcore-tooling#1277)
Follow up to https://github.com/dotnet/project-system/issues/5596

FastUpToDateCheck now has a way to associate inputs and outputs using the Set attribute.
This change prevents FastUpToDateCheck from rebuilding a project when a *.cshtml file is
newer than the project's dll output.

Fixes https://github.com/aspnet/AspNetCore/issues/13204\n\nCommit migrated from 2bf9c12490
2019-10-31 12:31:50 -07:00
Brennan 668e7b3051 Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migrated from 94fd1eaa85 2019-10-31 11:58:31 -07:00
N. Taylor Mullen e2dc96c7b9 Fix runtime preventDefault / stopPropagation break.
- The Blazor runtime doesn't support adding attributes prior to any sort of content frames being applied. This change ensures that `ComponentAttributes` (how preventDefault / stopPropagation are represented) are handled like other HTML attributes (applied first).
- Updated existing tests and their baselines.

aspnet/AspNetCoredotnet/aspnetcore-tooling#16611
\n\nCommit migrated from 1513cd2a5b
2019-10-28 12:41:44 -07:00
Pranav K 739f7228aa Merge branch 'master' into merge/release/3.1-to-master\n\nCommit migrated from f088a6e121 2019-10-23 16:30:55 -07:00
dotnet-maestro[bot] 18457ddc85 [release/3.1] Update dependencies from dotnet/arcade (dotnet/aspnetcore-tooling#1257)
* Update dependencies from https://github.com/dotnet/arcade build 20191017.3

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19517.3

* Remove duplicate icon element
\n\nCommit migrated from ce261e9953
2019-10-23 18:12:55 +00:00
N. Taylor Mullen f998cdc5f2 Updated PR with merge conflict resolution changes.
\n\nCommit migrated from 3f8e5452ed
2019-10-18 13:09:14 -07:00
Pranav K 054c1c5e59 Retarget rzc.dll to netcoreapp3.0 (dotnet/aspnetcore-tooling#1253)
Based on the discussions here: https://github.com/aspnet/AspNetCore-Internal/issues/3201#issuecomment-539631557

rzc.dll targeting netcoreapp3.1 causes shared fx version conflicts when consumed as a package in the AspNetCore repo.
A fairly trivial workaround is to have it target it netcoreapp3.0 and allow it to roll-forward to the available shared fx.
This follows csc.dll's behavior, as well as solves the version conflict.

Fixes https://github.com/aspnet/AspNetCore-Internal/issues/3201\n\nCommit migrated from 3807c6a6c1
2019-10-18 11:23:05 -07:00
Ajay Bhargav Baaskaran 7f126d5694 Addressed minor comments
\n\nCommit migrated from c170fd9837
2019-10-18 10:55:45 -07:00
Ajay Bhargav Baaskaran 5badd94182 Add support for PreventDefault and StopPropagation in event handlers
\n\nCommit migrated from ae5be3efc0
2019-10-18 10:55:45 -07:00
N. Taylor Mullen 163c09f984 Add support for partial component class editing -> refresh components.
- We now do aggressive detection on the type of C# class that's being edited. In order to not impact C# scenarios we only do work if C# assets are available to us. Meaning, we inspect the old document and if that document has its' semantic model available we spend cycles to determine if it's a component. In the case that we find a C# component class that wasn't previously caught we enqueue an update.
- Added several tests to ensure we enqueue and that we properly detect component classes.

aspnet/AspNetCoredotnet/aspnetcore-tooling#14646
\n\nCommit migrated from d8b62e121f
2019-10-16 15:10:39 -07:00
Pranav K 82e62cb34f Add a flag to prevent config, json files from being copied to the build output directory (dotnet/aspnetcore-tooling#1240)
Fixes https://github.com/aspnet/AspNetCore/issues/14017\n\nCommit migrated from 8a99b91799
2019-10-16 14:34:59 -07:00
N. Taylor Mullen 49f8ae28cf Add support for using a 3.0 SDK on VS 16.4.
- The 3.0 SDK adds RazorDeclaration files to the compile list if they exist. If a user builds in VS and then does a project level operation (adding a property group or item group to their project file) a design time build will trigger for unrelated reasons and declaration files will be included as part of the C# compilation resulting in duplicate member errors. This change ensures that even if declaration files are added we then remove them to ensure we avoid those declaration additions.
- One unfortunate aspect of this change is that declarations are added to the compile list for a brief moment resulting in errors and then are instantly removed in some situations. I say "some situations" because when this happens it is highly dependent on how / when the project system decides to perform a design time build.

aspnet/AspNetCoredotnet/aspnetcore-tooling#14646
\n\nCommit migrated from b64c9317c4
2019-10-16 13:16:23 -07:00
Ajay Bhargav Baaskaran abef940002 Merge pull request dotnet/aspnetcore-tooling#1221 from dotnet-maestro-bot/merge/release/3.1-preview1-to-release/3.1
[automated] Merge branch 'release/3.1-preview1' => 'release/3.1'\n\nCommit migrated from b19a3f70a7
2019-10-09 13:29:22 -07:00
Ajay Bhargav Baaskaran 4281704bf6 Pass through the correct LangVersion to csc
\n\nCommit migrated from ce09369eb4
2019-10-08 15:55:17 -07:00
Ryan Nowak 73877e9c2f Allow expressions with @bind:event
Fixes aspnet/AspNetCoredotnet/aspnetcore-tooling#13181

The big change here is that we have to allow an HtmlAttributeIRNode to have
a dynamically computed attribute name. This isn't something that exists
anywhere else in the system.
\n\nCommit migrated from 559f0f5e52
2019-10-07 18:08:13 -07:00
Ryan Nowak dcc4084af8 Merge branch 'release/3.1' into merge/release/3.0-to-release/3.1\n\nCommit migrated from f9ac723b29 2019-10-07 12:10:26 -07:00
Ryan Nowak f19dc08305 Fix dotnet/aspnetcore-tooling#10498 - void elements with directive attributes
This change updates tag helper binding logic to allow directive
attributes (when they appear alone) to bind to any kind of tag
(start/end, void, self-closing).

Tag Helpers don't have a semantic that allows this level of flexibility
- using StartTagOnly as suggested in the issue means that this would
*only* work for void elements.

There's no change to any of the directive attribute implementations
because this is a global change in the tag helper infra.
\n\nCommit migrated from fd72afc1c6
2019-10-04 13:46:01 -07:00
wtgodbe 371f2c246b Switch to embedded package icon
\n\nCommit migrated from fba50fdcd4
2019-10-02 12:56:34 -07:00
wtgodbe 3ce7953fec One more missed convention location
\n\nCommit migrated from 1e6b4887c4
2019-10-02 12:33:27 -07:00
wtgodbe 7a61205024 Add workaround to one more project
\n\nCommit migrated from 381138fc72
2019-10-02 12:21:01 -07:00
wtgodbe 1d789575ae Embedded resource convention workaround
\n\nCommit migrated from 6e6faf5aaa
2019-10-02 12:17:01 -07:00
Ajay Bhargav Baaskaran ef8830ffec Update baselines to unbreak tests (dotnet/aspnetcore-tooling#1184)
\n\nCommit migrated from 0d1e0d6eba
2019-10-01 13:59:41 -07:00
N. Taylor Mullen 1e9c0f01af Add Blazor partial class support in Visual Studio. (dotnet/aspnetcore-tooling#1182)
- No longer mark declaration files as single file generators. Prior to this we relied on SingleFileGenerators to dynamically update the declaration files when .razor files changed. However, to make partial classes work we can no longer depend on declaration files being available because their existence causes us to have to mangle class names for opened documents; otherwise you get two files with same name and result in ambiguous definition errors.
- Stopped including declaration files as part of the users compilation. This was intended to make the design time experience operate more similar to how Blazor apps function at runtime (directly access each component instead of their declarations). We now rely on the background code generation effort built from the find all references work to supply users with strongly typed component names.
- Stop mangling class names for Visual Studio. Razor.VSCode has its own set of configurations which i'm not addressing as part of this changeset.
- Start generating components with the partial modifier to their class name to enable partial class support.
- Updated existing tests to expect partial modifier.

aspnet/AspNetCoredotnet/aspnetcore-tooling#5487\n\nCommit migrated from 73858cdd37
2019-10-01 13:59:33 -07:00
Ajay Bhargav Baaskaran 3dcc779659 Prefer child content over a matching component (dotnet/aspnetcore-tooling#1180)
* Prefer child content over a matching component

* feedback
\n\nCommit migrated from 9c83a09944
2019-09-27 14:27:10 -07:00
Ajay Bhargav Baaskaran 39d8e322d1 Fix misc attribute content sometimes getting ignored (dotnet/aspnetcore-tooling#1176)
\n\nCommit migrated from 8108f50021
2019-09-27 14:22:21 -07:00
Ryan Brandenburg 287b183189 Responding to Pranav's feedback
\n\nCommit migrated from 353a27828e
2019-09-26 13:58:03 -07:00
Ryan Brandenburg eda9503177 RazorSDK doesn't overwrite ErrorLog
\n\nCommit migrated from aed7bc8ec6
2019-09-26 13:58:03 -07:00