Commit Graph

17115 Commits

Author SHA1 Message Date
Dylan Dmitri Gray c24c4cac01
Dylan/request queue di (#11167)
Decoupled Middleware from QueuePolicy
2019-06-13 16:36:21 -07:00
Chris Ross 82d2b4f4d0
Fail on startup for Http/2 HTTPS on Mac #11061 (#11120)
* Use automatic resx #11054
2019-06-13 15:42:45 -07:00
John Luo 8e4825fd6b
Set rollForward to LatestPatch (#11150) 2019-06-13 12:57:17 -07:00
David Fowler b0be780f1b
Remove dependency on pipe events in HttpConnection (#11132)
- Refactored the HttpConnection to not depend on OnReaderCompleted and OnWriterCompleted. Instead we use ConnectionClosed to detect the FIN that we propagate via ConnectedAborted.
- Fire ConnectionClosed when a FIN is received from both transports.
- Remove pipe completion from Http1Connection and Http1OutputProducer. Instead just return from request processing.
- Cancel the transport input on RawStream to yield the pending read. This is much more efficient than passing a cancellation token into everything (and more reliable)
- Fixed the RequestTests to not depend on inline scheduling
- Properly dispose things in the LibuvOutputConsumerTests
- Skipped flaky test
2019-06-13 10:30:23 -07:00
N. Taylor Mullen 874050f1dd Headless Blazor client (#11112)
* Add Ignitor
* Finish headless Blazor client.
* Added support for click events.
* Move Ignitor into testassets folder.
- Also added Ignitor to the no deps solution.
* Add Ignitor tests to validate RenderBatchReader stays consistent.
2019-06-13 10:05:40 -07:00
Javier Calvarro Nelson 38bc43bad7 Move extension method out of Microsoft.AspNetCore (#11148)
* Move extension method out of Microsoft.AspNetCore

* Empty commit
2019-06-13 08:14:58 -07:00
Brennan f989daca4b Target netstandard2.1 for SignalR client (#10540) 2019-06-12 21:59:56 -07:00
Mikael Mengistu 79326220b4
Add ability to change url in TS client (#11102) 2019-06-12 20:01:41 -07:00
Justin Kotalik 14e7aca2ed
React to changes in Microsoft.NETCore.App (#11153) 2019-06-12 17:51:40 -07:00
Dylan Dmitri Gray 844530dd54
Overhead Benchmark for Request Throttling (#10907)
* initial implementation; no tests

* benchmark project

* Better benchmarks

* overhead test for congested queue

* Addressed feedback
2019-06-12 17:22:14 -07:00
Kahbazi 402394347d Add parameters for Microsoft Account Authentication (#11059)
Co-Authored-By: campersau <buchholz.bastian@googlemail.com>
2019-06-12 13:07:44 -07:00
Chris Ross 639e3dd07b
Fix Negotiate tests downlevel #11009 (#11101) 2019-06-12 11:48:21 -07:00
Chris Ross 4fa5a228cf
Add error details for OAuth and OIDC remote errors #4682 (#11002) 2019-06-12 11:32:40 -07:00
Doug Bunting 2ea746f37d Add metadata needed for tooling of service reference features
- #10789
2019-06-12 11:16:40 -07:00
Ben Adams 396c54d874 Use correct examined (#11124)
Merging to unblock benchmarks quickly.
2019-06-12 10:44:27 -07:00
Nate McMaster bbff308d22
Unmark System_UsesProvidedDirectoryAndCertificate as flaky (#11125) 2019-06-12 09:35:49 -07:00
Thiez db72ea04a2 Fix incorrect documentation, parameter check for HttpMethodAttribute (#11133)
The second constructor of the `HttpMethodAttribute` class claims that the `template` parameter may not be `null`, and no such claim is present about the `httpMethods` parameter. However, when `httpMethods` is `null`, an exception is thrown, while `template` *is* allowed to be null (as can be seen in the `HttpMethodAttribute(IEnumerable<string>)` constructor, which passes `null`.

In addition, the `HttpMethodAttribute(IEnumerable<string>)` constructor contains a `null`-check for the `httpMethods` parameter, but since this check is *also* in the `HttpMethodAttribute(IEnumerable<string>, string)` constructor this check is dead code.
2019-06-12 09:33:52 -07:00
Nate McMaster 6c806f91b1
Add option for only packing runtime-specific packages (#11116)
* Add option for only packing runtime-specific packages
* Remove Microsoft.AspNetCore.Blazor.Templates.dll from the Blazor VSIX
* Cleanup implementation of ANCMSymbols packaging
2019-06-11 20:47:10 -07:00
Brennan dd2e2186db Fix typo in condition for Windows Auth with LongPolling (#11051)
Co-Authored-By: Stephen Halter <halter73@gmail.com>
2019-06-11 17:02:54 -07:00
Jeff Weiner bc91bd0308 Fix _LoginPartial.OrgAuth.cshtml referencing non-existent CSS classes (#10781) 2019-06-11 16:51:40 -07:00
Ben Adams d5f4f26437 Update Platform for api change (#11110) 2019-06-11 16:46:02 -07:00
Hao Kung f8bd011d85
Don't strip amr and auth_time in OIDC by default (#11076) 2019-06-11 14:53:32 -07:00
Justin Kotalik 92b90fd986
Deflaking a lot of tests (#10960) 2019-06-11 14:10:06 -07:00
John Luo 7a8487e2bd
Add PlatformManifest to runtime package (#11046) 2019-06-11 12:46:01 -07:00
WuYafeng 40f0c28261 Resolve Kestrel default certificate store is invalid (#11074) 2019-06-11 11:58:16 -07:00
Mikael Mengistu eeaba9252f
Update HubConnection url in Java client (#11010) 2019-06-11 11:00:26 -07:00
Justin Kotalik 7e92e4c280
Remove warning for content files issues (#11073) 2019-06-11 09:59:47 -07:00
Pranav K 1ffc2351b8
Make the test input a bit more reasonable (#11067) 2019-06-11 09:29:38 -07:00
Jacques Eloff 147f5afb1e Re-enable setup localization (#11094) 2019-06-11 09:21:06 -07:00
Javier Calvarro Nelson c7a9da58b4
[Identity] Disable polling on file providers (#11048)
* Disable polling on file file providers.
* Use in-memory SQL lite database always on the test project.
2019-06-11 17:42:04 +02:00
Jacques Eloff 85feca7a12
Merge pull request #10932 from aspnet/joeloff/LocUpdate
Localization handback for missing strings
2019-06-11 07:43:40 -07:00
dotnet-maestro[bot] a6bc6ce23d [master] Update dependencies from 3 repositories (#10939)
* Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190610.7
- Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview7.19310.7
- Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview7.19310.7
- dotnet-ef - 3.0.0-preview7.19310.7
- Microsoft.EntityFrameworkCore - 3.0.0-preview7.19310.7
- Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview7.19310.7
- Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview7.19310.7
- Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview7.19310.7

Dependency coherency updates
- Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview7.19309.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview7.19309.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview7.19309.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview7.19309.2 (parent: Microsoft.EntityFrameworkCore)
- et cetera

* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190610.2
- Microsoft.NET.Sdk.Razor - 3.0.0-preview7.19310.2
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview7.19310.2
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview7.19310.2
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview7.19310.2

* Update dependencies from https://github.com/aspnet/Blazor build 20190610.1
- Microsoft.AspNetCore.Blazor.Mono - 0.10.0-preview7.19310.1
2019-06-10 23:12:23 -07:00
Justin Kotalik d7fc06af5e
Move IServerVariablesFeature to Http.Features (#11007) 2019-06-10 21:16:36 -07:00
Sébastien Ros 5561338cfe React to System.Text.Json namespace changes (#11053) 2019-06-10 20:42:24 -07:00
Günther Foidl 90ab2cb965 Spanified Webencoders.Base64UrlEncode (#11047) 2019-06-10 18:18:31 -07:00
Arthur Vickers 4d1262c39b Small fixes for DatabaseErrorPageMiddleware
The main change here is to also allow public `HasTables` to be found. This will be removed once we get the new EF merged.

The change to the migration makes it align with what we would generate, but I don't think has any functional impact on the tests.

See also https://github.com/aspnet/EntityFrameworkCore/pull/16024 which (I really hope!)fixes the other failures once it makes it here.
2019-06-10 16:09:13 -07:00
Mikael Mengistu ecd709eb9a
Make sure to release connection lock (#11049) 2019-06-10 15:38:07 -07:00
John Luo f76be64e5d
Only run selenium tests when build java is specified (#11018) 2019-06-10 14:35:27 -07:00
David Fowler d4a982fefa
Reduce allocations when Activity is enabled (#11020)
- Remove string allocations caused by DiagnosticSource.Stop/StartActivity
- Pass the HttpContext directly as the object for StartActivity and StopActivity to avoid the anonymous object allocation.
- Though it's a bit ugly, added an HttpContext property to DefaultHttpContext to avoid breaking back-compat (which had to do reflection to get the HttpContext property anyways)
2019-06-10 13:37:15 -07:00
Ryan Brandenburg 0b340bd70c
Merge pull request #10915 from aspnet/rybrande/BlazorAccessibility
Improve Blazor accessibility
2019-06-10 11:08:53 -07:00
Ben Adams 37e6ad7e12 Improve HostFiltering perf (#9359) 2019-06-10 09:32:00 -07:00
Pranav K 7ee7f5ddee
Unskip tests (#11024)
Fixes https://github.com/aspnet/AspNetCore/issues/4417
2019-06-10 09:02:21 -07:00
Kahbazi b4b3aa9c94 Return an empty list instead of null for IHeaderDictionary extensions #3486 (#10972) 2019-06-09 09:45:36 -07:00
Pranav K d935ea2d25
Guarantee ordering for SignalR client HttpConnection.send #10780 (#10987)
Fixes https://github.com/aspnet/AspNetCore/issues/9901
2019-06-08 14:35:29 -07:00
Nate McMaster 936d4dcf09
Add back DevelopmentDependency to ApiDescription projects 2019-06-07 17:38:11 -07:00
Mikael Mengistu f4e3c0a171
Don't remove auth header when stopping HubConnection (#10635) 2019-06-07 17:27:38 -07:00
Nate McMaster 41ce223c1c
Replace Internal.AspNetCore.Sdk with Microsoft.DotNet.Arcade.Sdk (#10674)
* Update build.cmd to install .NET Core into $repoRoot/.dotnet instead of $repoRoot/.dotnet/x64
* Move restore sources from build/sources.props into eng/Versions.props (following arcade conventions)
* Remove usages of RuntimeFrameworkVersion in tests and build
* Update Blazor VSIX to use Arcade VSIX tools
* Rename Common.Tests to IIS.Common.TestLib and make it a test asset
* Remove custom versions props for ANCM installer code
* Remove duplicate references to xunit and remove usages of IsTestProject
* Remove duplicate references to Internal.AspNetCore.Analyzers
* Import Arcade.Sdk props and targets and remove custom versioning props
* Remove references to Internal.AspNetCore.Sdk
* Rename PackageLicenseType => PackageLicenseExpression
* Remove dependency on tasks in Internal.AspNetCore.Sdk, add ref to Internal.AspNetCore.BuildTasks as a temporary workaround
* Use Arcade's nuspec support
* Rename SignalR.Client.FunctionalTests to SignalR.Client.FunctionalTestApp
* Fixes for changes to property evaluation order
* Update BaseLineGenerator to netcoreapp3.0
* React to changes in evaluation order in RPM files and quirks in using <Exec> instead of <Run>
* Update Microsoft.Extensions.ApiDescription.Server to react to changes in Arcade packaging
* Workaround aspnet/AspNetCore#11009
2019-06-07 17:19:41 -07:00
Arthur Vickers b5adc6b156 Move Database Error Page tests to SQLite
In an attempt to make them more reliable.

See also https://github.com/aspnet/EntityFrameworkCore/issues/15997
2019-06-07 16:31:29 -07:00
Kahbazi d3d6e0e709 Ensure MaxConcurrentRequests is a positive number (#11003) 2019-06-07 15:42:09 -07:00
Brennan 3259a2c9f6
Prefer File.Move for DataProtection key creation + Fallback (#10990) 2019-06-07 15:32:08 -07:00
Artak 5918ac7e8c
Removed the HSTS middleware (#10998) 2019-06-07 15:27:16 -07:00
Ryan Brandenburg 72d1578b16 Add eplanitory comment 2019-06-07 15:26:57 -07:00
Ben Adams f10680a37a Use one SequenceReader+Rewind rather than 2 (#8076) 2019-06-07 13:15:27 -07:00
Chris Ross 3dc2be22c5
Static Files cleanup (#10996) 2019-06-07 12:46:10 -07:00
Ryan Brandenburg 2f1da8c128 Test script and gitignore 2019-06-07 12:00:35 -07:00
Ryan Brandenburg a45f8ee596 Improve Blazor accessability 2019-06-07 12:00:35 -07:00
Kahbazi 1b5db12d3f Indicates that SaveTokens is not supported for WsFederation (#10763) 2019-06-07 11:44:22 -07:00
Chris Ross 75e0115de9
Add PKCE support in OIDC & OAuth #7734 (#10928) 2019-06-07 11:27:44 -07:00
Nate McMaster 4300f498c7
[automated] Merge branch 'release/3.0-preview6' => 'master' (#10936) 2019-06-07 11:21:00 -07:00
Kahbazi 1dff8cbdbc Add OnRejected to Request Throttling middleware (#10817)
* Add OnRejected to Request Throttling middleware

* Remove IApplicationBuilder extension with option

* Add test

* Add summary for OnRejected
2019-06-07 11:15:48 -07:00
Daniel Roth d058e0f495 Fix inconsistent casing of LoginDisplay component (#10966) 2019-06-07 10:10:59 -07:00
Ryan Brandenburg aeeb16c6c2
Merge pull request #10950 from isaac2004/10332-work
Update all our activated types to take ILogger<T> in Templates - 10332
2019-06-07 10:03:08 -07:00
Jacques Eloff c5f85986e6 Disable bundle localization (#10976) 2019-06-07 09:54:59 -07:00
David Fowler b34acc9e86
Removed BufferSegment (#10982)
- This was leftover from the old StreamPipeReader impl
2019-06-07 08:51:46 -07:00
Isaac Levin af5c1eed67
Update SampleDataController.cs 2019-06-07 10:23:20 -04:00
Isaac Levin 86dde596b8
Update Error.cshtml.cs 2019-06-07 10:22:59 -04:00
Isaac Levin 7b8d34243a
Update Error.cshtml.cs 2019-06-07 10:22:41 -04:00
Isaac Levin 01d10ab08e
Update SampleDataController.cs 2019-06-07 10:22:26 -04:00
Isaac Levin 6c0dcf3e6f
Update OidcConfigurationController.cs 2019-06-07 10:22:06 -04:00
Javier Calvarro Nelson 5d091df908
Move identity functional test website to generic host (#10974) 2019-06-06 22:01:33 -07:00
Andrew Stanton-Nurse f7f80fdbaa
Fix AuthenticationService summary (#10969)
Fix AuthenticationService summary
2019-06-06 15:57:48 -07:00
Javier Calvarro Nelson 0a25c28173
[Mvc] Undo MVC breaking change (#10962)
* Undo MVC breaking change
2019-06-06 15:57:10 -07:00
Kahbazi ba8c6ccf6f Inject ILogger to RequestLocalization Middleware (#10946) 2019-06-06 15:38:02 -07:00
Javier Calvarro Nelson 7e162096a9
[Static Web Assets] Various fixes (#10937)
* [Static Web Assets] Various fixes
* Remove support for the embedded manifest.
* Move static web assets directly into hosting
2019-06-06 14:13:57 -07:00
Kahbazi 69e4a566b3
Fix AuthenticationService summary 2019-06-07 01:35:38 +04:30
Ryan Brandenburg 9336a6acd6
React to removed link (#10957)
React to removed link
2019-06-06 13:39:25 -07:00
John Luo 67b665208c Remove 2.x workaround for BindModel_ReturnsModel_IfAttemptedValueIsValid_FrenchThirtyTwoThousandPointOne failure 2019-06-06 11:46:22 -07:00
dotnet-maestro-bot 8627096084 Skip model binding test due to environment changes (#10923) (#10931) 2019-06-06 11:46:22 -07:00
David Fowler fcda7fd7d0
Added more logs to unix domain sockets test (#10943)
- The current theory is that the tests are experiencing starvation so add more logs to see if if anything in the application is running between the FIN being received on the server side and application code receiving the notification that the pipe was completed.
- Detect OperationAborted to avoid the connection reset log.
2019-06-06 10:46:37 -07:00
Ryan Brandenburg 27b00fe95f
Merge branch 'master' into 10332-work 2019-06-06 10:26:34 -07:00
YPTopMan c18fc3d7ca Use throws expressions and expression bodied members (#10764) 2019-06-06 09:56:12 -07:00
Mikael Mengistu b08577342d
Lazy-init formatter resolvers in MessagePackHubProtocolOptions (#10929) 2019-06-06 08:33:32 -07:00
Isaac Levin ea55f8db71
Update OidcConfigurationController.cs 2019-06-06 10:57:03 -04:00
Isaac Levin 6410d4e761
Update OidcConfigurationController.cs 2019-06-06 10:56:28 -04:00
Isaac Levin 018800ed41
Update Privacy.cshtml.cs 2019-06-06 10:55:26 -04:00
Isaac Levin 8c5800a94c
Update Index.cshtml.cs 2019-06-06 10:55:02 -04:00
Isaac Levin 9468e2dfed
Update _ValidationScriptsPartial.cshtml 2019-06-06 10:54:10 -04:00
Isaac Levin 7983924871 Added ILogger and cleanup 2019-06-06 10:42:09 -04:00
Justin Kotalik fdba8a91f9
Add versioning to dotnet-dev-certs (#10908) 2019-06-05 22:04:27 -07:00
Brennan 5b56de966e
Change case-insensitive Json default in SignalR (#10814) 2019-06-05 21:57:18 -07:00
Stephen Halter 81f2d46660
Unify C# and TS SignalR client auto-reconnect APIs (#10678) 2019-06-05 21:32:47 -07:00
Andrew Stanton-Nurse 915cc74df8 fix #7548 by updating to v142 toolset (again) (#10904)
* fix #7548 by updating to v142 toolset (again)

* small note

* it's a compiler bug. let's just try

* you get a pass vc++... THIS TIME

* should no longer need v141 toolset!
2019-06-05 21:31:36 -07:00
Stephen Halter 511761627a
Improve shutdown of SignalR .NET client sample (#10675) 2019-06-05 21:31:04 -07:00
Brennan c518cff370
Add missing log to hub method failure (#10903) 2019-06-05 20:17:40 -07:00
Cory Nelson bc6f4b6034 Fix a write past the end of buffer when IntegerEncoder encodes to multi-bytes and does not have sufficient room to do so. (#10914)
Add some basic asserts to constrain parameters to HPACK spec.
Add some additional tests.
2019-06-05 20:15:16 -07:00
Justin Kotalik d3e90a7c07
Guarantee that ANCM package dlls are used for back compat tests (#10858) 2019-06-05 20:11:47 -07:00
Justin Kotalik f080c89e89
Add better error message when someone does single file publish in ANCM (#10871) 2019-06-05 20:10:43 -07:00
Steve Sanderson 3697b4704b Workaround Chrome navigation issue (#10839)
Thanks @javiercn and @SteveSandersonMS!
2019-06-05 17:43:20 -07:00
Arthur Vickers a86a811f7b Cleanup in Identity tests
Fixes #10671 by using updated EF API
Fixes #5812 so tests are re-enabled for PRs
Also part of #10668 since one of the changed EF queries is now working

Finally, I removed all remaining platform skips since with SQLite these tests should now run anywhere.
2019-06-05 15:49:49 -07:00
Jacques Eloff 5af0dd5b38 Localization handback for missing strings 2019-06-05 15:38:34 -07:00
Pranav K 23d1d11dda Revert "Guarantee ordering for SignalR client HttpConnection.send (#10780)" (#10916)
This reverts commit b1a29281ba.
2019-06-05 14:26:44 -07:00
Ryan Brandenburg 177ad2b966
Merge pull request #10917 from saluce65/patch-1
Remove gender-specific terminology from comments
2019-06-05 14:16:21 -07:00
Ryan Brandenburg 1c9d7e4671
Merge pull request #10918 from saluce65/patch-2
Update logout.component.ts
2019-06-05 14:08:01 -07:00
David Fowler bba6b44044
Added basic event counters for hosting (#10884)
- Added Request Rate counter (RPS), Total Requests counter, current requests and failed requests.
- Counters do nothing until enabled
- Added tests for counters and improved tests to use unique event source names
- Renamed EventSource to match the convention in the runtime Microsoft.AspNetCore.Hosting
2019-06-05 14:06:34 -07:00
Ryan Brandenburg f066f7c32f
Merge pull request #10808 from isaac2004/master
Simplify web project templates #10347
2019-06-05 13:47:27 -07:00
Isaac Levin 99a0e98464
merge (#4)
merge

Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: dotnet bot <dotnet-bot@microsoft.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: dotnet-maestro <@dotnet-maestro>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Mikael Mengistu <mikaelm12@users.noreply.github.com>
2019-06-05 16:45:00 -04:00
Mikael Mengistu 61e689471f
Propagate cancellation token IAsyncEnumerators (#10901) 2019-06-05 13:06:36 -07:00
saluce65 7f204a0bad
Update logout.component.ts 2019-06-05 14:53:42 -05:00
saluce65 48dee6a36f
Remove gender-specific terminology from comments 2019-06-05 14:48:32 -05:00
Brennan f3f99ebd70
Merge pull request #10906 from aspnet/brecon/mergePreview6
Merge preview6 into master
2019-06-05 12:46:07 -07:00
Isaac Levin 887872dac0
Merge branch 'master' into master 2019-06-05 15:00:49 -04:00
Ryan Brandenburg 9ed49994ab
Merge pull request #10841 from isaac2004/10346-work
Remove Cookie Consent UI from all templates and move into docs #10346
2019-06-05 11:56:58 -07:00
Pranav K b1a29281ba Guarantee ordering for SignalR client HttpConnection.send (#10780)
* Revert "Revert "Add an option to SignalR to guarantee ordering of send events… (#10807)"
  - This reverts commit 39a9d63c10.
* Fixup build
2019-06-05 11:18:53 -07:00
Michal Strehovský 9cd2ad15ff Remove use of GetRuntimeInterfaceMap in IsTypeAwaitable (#10572)
`GetRuntimeInterfaceMap` is a rather expensive API and it doesn't look like the use here is warranted.

The replacement should have equivalent behavior.
2019-06-05 10:58:54 -07:00
Brennan Conroy 224ff4412c Merge branch 'release/3.0-preview6' into brecon/mergePreview6 2019-06-05 10:57:11 -07:00
Nate McMaster d1138f2cde
Merge branch 'release/3.0-preview6' 2019-06-05 10:09:37 -07:00
Justin Kotalik 214ca07b6c
Start using runtime properties to set StartupHook and EntrypointFilter (#10121) 2019-06-05 09:01:05 -07:00
Brennan c9724896e2 [Preview 6] Use JsonReader interop with JsonSerializer (#10733) 2019-06-04 21:51:08 -07:00
Doug Bunting 379f28edc8
Merge branch 'master' into merge/release/3.0-preview6-to-master 2019-06-04 20:44:48 -07:00
dotnet-maestro[bot] 4c9e19e061 [release/3.0-preview6] Update dependencies from 2 repositories (#10856)
* Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190604.2

- Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview6.19304.2
- Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview6.19304.2
- dotnet-ef - 3.0.0-preview6.19304.2
- Microsoft.EntityFrameworkCore - 3.0.0-preview6.19304.2
- Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview6.19304.2
- Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview6.19304.2
- Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview6.19304.2

Dependency coherency updates

- Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Binder - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Ini - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Json - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Xml - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Http - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Configuration - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Console - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Debug - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventSource - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventLog - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Testing - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ObjectPool - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Primitives - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.WebEncoders - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Internal.Extensions.Refs - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.JSInterop - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Mono.WebAssembly.Interop - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.CSharp - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Win32.Registry - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.ComponentModel.Annotations - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Diagnostics.EventLog - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.IO.Pipelines - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Net.Http.WinHttpHandler - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Net.WebSockets.WebSocketProtocol - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Reflection.Metadata - 1.7.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Runtime.CompilerServices.Unsafe - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Security.Cryptography.Cng - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Security.Cryptography.Pkcs - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Security.Cryptography.Xml - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Security.Permissions - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Security.Principal.Windows - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.ServiceProcess.ServiceController - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Text.Encodings.Web - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Text.Json - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- System.Threading.Channels - 4.6.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- NETStandard.Library.Ref - 2.1.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19303.8 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.App - 3.0.0-preview6-27803-13 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Internal.AspNetCore.Analyzers - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.Testing - 3.0.0-preview6.19304.2 (parent: Microsoft.EntityFrameworkCore)

* fix tests

* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190604.1

- Microsoft.NET.Sdk.Razor - 3.0.0-preview6.19304.1
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview6.19304.1
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview6.19304.1
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview6.19304.1

* fix mvc test

* virtual test
2019-06-04 18:45:02 -07:00
Ryan Nowak 5af8e170bc
Add support for TypeConverter (#10730)
* Add support for TypeConverter

Fixes: #8493
Fixes: #9632
Fixes: #9339
Fixes: #8385
Fixes: 10077

This fix adds support for type converters as well as a few other minor
things we were missing from binding. The key thing about supporting
conversions is that we new can support arbitrary types with `@bind`.
This means you can use it with generics, which is something many users
have tried.

Along with type converters we get Guid and TimeSpan from the BCL. The
BCL also includes converters for types we're less interested in like
`short`.

* Use correct NumberStyles

* Fix culture

* Core check
2019-06-04 17:31:01 -07:00
Chris Ross 03d94e0ee6 Mark ShutdownTestRun as Flaky (#10852) 2019-06-04 16:59:17 -07:00
Nate McMaster 0ed9e4e629
Merge branch 'release/3.0-preview6' 2019-06-04 16:34:17 -07:00
Nate McMaster 7245b83942
Mark BindModel_ReturnsModel_IfAttemptedValueIsValid_FrenchThirtyTwoThousandPointOne as flaky (#10857) 2019-06-04 16:01:18 -07:00
Isaac Levin 9b11e486fd
merge (#3)
merge 

Co-authored-by: Kahbazi <a.kahbazi@gmail.com>
Co-authored-by: Pranav K <prkrishn@hotmail.com>
Co-authored-by: null <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Co-authored-by: Justin Kotalik <jukotali@microsoft.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Jeow Li Huan <huan086@users.noreply.github.com>
Co-authored-by: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
Co-authored-by: Nate McMaster <natemcmaster@users.noreply.github.com>
Co-authored-by: Smit Patel <smitpatel@users.noreply.github.com>
2019-06-04 16:47:56 -04:00
Smit Patel bb9ba122c1 Target netstandard2.1 in HealthChecks.EFCore 2019-06-04 13:26:20 -07:00
Isaac Levin 14436d4cf6 add removed section 2019-06-04 12:47:00 -04:00
David Fowler b6d8c96a98
Collect dumps for tests that seem to be flaky (#10830) 2019-06-04 09:16:08 -07:00
Nate McMaster be2f0cf8f2
Merge branch 'release/3.0-preview6' 2019-06-04 08:52:09 -07:00
Steve Sanderson 55b310d16b Blazor template fixes (#10770)
* Invert UseLocalDB condition in template

* Replace UseBlazorClientSideFiles with UseClientSideBlazorFiles

* Add NotFoundContent to client-side templates, and make all consistent

* In client-side templates, remove references to MyGet feeds as they are no longer updated

* Workaround for lack of conditionals in .razor: Two separate versions of MainLayout.razor

* Workaround for lack of conditionals in .razor: Four variants of LoginDisplay.*.razor

* Fix launchSettings for Windows auth
2019-06-04 08:38:41 -07:00
Isaac Levin 4298f63b2a remove cookie consent from templates 2019-06-04 11:03:09 -04:00
Andrew Stanton-Nurse b9afd4a3b3
Merge pull request #6517 from Kahbazi/LogEventName#5
Remove nameof for event name
2019-06-04 07:56:14 -07:00
Jeow Li Huan 544a01ae0a Add no-store to OpenIdConnectHandler cache-control response headers (#10318). (#10741) 2019-06-04 07:52:16 -07:00
Isaac Levin 241de2306f
Update _ValidationScriptsPartial.cshtml 2019-06-04 09:50:54 -04:00
Isaac Levin d1b9d14eef remove cdn tests 2019-06-04 09:37:34 -04:00
David Fowler 851a1eeb39
If libuv doesn't unwind gracefully log a warning (#10823)
- We added 3 critical logs to see if there was a resource leak happeing during the loop thread shutdown, turns out that during testing its very common for the thread to not end immediately because of the latency of thread pool dispatching (the latency between queuing and execution of the work item). As a result, we log a warning instead of an error.
2019-06-04 01:20:03 -07:00
Justin Kotalik 45b0d0d0de
Save condition backcollection between runs (#10776) 2019-06-03 22:31:38 -07:00
Doug Bunting b3ddd65a15
Add Microsoft.Extensions.ApiDesription.Server project and package (#10669)
- #8242 2 of 2, # #4912
- add missing project reference provider
  - remove incorrect `$(IsImplementationProject)` settings in `dotnet-getdocument` and `GetDocumentInsider`
  - re-run .\eng\scripts\GenerateProjectList.ps1
2019-06-03 18:57:53 -07:00
Pranav K 39a9d63c10 Revert "Add an option to SignalR to guarantee ordering of send events… (#10807)
This reverts commit 4646c4a5e4.
2019-06-03 15:49:55 -07:00
Isaac Levin 13ebb41fa9 remove cdn from templates 2019-06-03 17:06:47 -04:00
Isaac Levin 34a68d5f48 #10333 Template Updates (#10395)
#10333 Template Updates
2019-06-03 10:18:32 -07:00
David Fowler d001f5c519
Use the defaults that existed in Kestrel before (#10740) 2019-06-03 10:00:53 -07:00
Kahbazi c7cb8467bf Use GetEndpoint extension method (#10745) 2019-06-03 09:23:43 -07:00
Ryan Nowak 670865d2a8
Make JSON case-insensitive (#10727)
* Make JSON case-insensitive

Fixes: #10724

The rationale for this change is that existing .NET client code for the
most part uses JSON.NET with its default settings (preserve property
casing). This includes the WebAPI client - which we're encouraging
everyone to use. It's not really reasonable for us to break everyone
using webapi client.

* Make separate options and add extension method

* fixit

* fix build

* fix text
2019-06-03 09:16:58 -07:00
Pranav K 1ed5febf93
Application restarts on changes to Razor files (#10716)
* Remove Razor versioning number from DotNetWatch.targets

Application restarts on changes to Razor files

* .cshtml and .razor files cause dotnet-watch to reload by default
* .cshtml files do not cause VS or dotnet-watch to reload when using RuntimeCompilation

Fixes https://github.com/aspnet/AspNetCore/issues/9644
2019-06-03 07:48:23 -07:00
Pranav K 4646c4a5e4
Add an option to SignalR to guarantee ordering of send events (#10506)
* Add an option to SignalR to guarantee ordering of send events

Fixes https://github.com/aspnet/AspNetCore/issues/9901
2019-06-03 04:29:42 -07:00
Brennan f0df10f211
AuthorizeHelper will no-op if endpoint routing is used (#10471) 2019-06-02 22:35:45 -07:00
Doug Bunting 25672336f9
Add more properties controlling service reference code generation (#10641)
- `$(OpenApiGenerateCodeOnBuild)` controls if targets run before compile targets
  - #4924
  - also correct multiple invocations when project has multiple target frameworks
- `$(OpenApiBuildReferencedProjects)` controls whether `@(OpenApiProjectReference)` items build automatically
  - #6582
- rename a few other properties and targets

also:
- add symbols for Microsoft.Extensions.ApiDescription.Client task assembly
  - #10508
- unconditionally run `OpenApiGetDocuments` target in referenced projects
  - corrects compilation in design-time builds
  - no longer uses `@(ProjectReferenceWithConfiguration)`; referenced project chooses all property values

nits:
- consolidate into a single `$(GenerateOpenApiCodeDependsOn)` property
- rename task assembly and namespaces in Microsoft.Extensions.ApiDesription.Client to match the project
- allow `OpenApiGetDocuments` targets to run in parallel if `$(BuildInParallel)` is enabled
- remove `$(OpenApiCodeDirectory)` normalization; never concatenated with anything else
2019-06-02 22:09:42 -07:00
Doug Bunting 4c8ca0b080
Rewrite dotnet-getdocument and GetDocument.Insider to retrieve all documents in one go (#10667)
- #8242 1 of 2
- save a cache file listing all retrieved documents
- remove .NET Core App 2.0 support
- remove ServiceProjectReferenceMetadata.targets, related `Project` class, and searches for a project
  - tools will run within a project and get needed information from project on command line
- roll framework forward in both tools to expand their applicability when using .NET Core
- use Microsoft.Extensions.HostFactoryResolver.Sources (part of #4923)
  - remove Microsoft.AspNetCore.Hosting.Abstractions dependency

nits:
- refactor methods in `GetDocumentCommandWorker`
- reorder option addition for consistency and to place `--help` at the top of help output
- consolidate information about method signatures at top of `GetDocumentCommandWorker`
- consolidate `try` / `catch` blocks in `GetDocumentCommandWorker`
- shorten the lifespan of a `Task`
- ensure GetDocument.Insider exit codes are unique
- make a few more `string`s `const`
- fold a few expressions over fewer lines
2019-06-02 21:58:08 -07:00
Ryan Nowak 91e6839c8d
Adds inferred [Required] for non-null ref types (#9978)
* Adds inferred [Required] for non-null ref types

Follow up from #9194

This change adds the automatic inference of [Required] for non-nullable
properties and parameters. This means that if you opt into nullable
context in C#8, we'll start treating those types as-if you put
[Required] on them.

This provides a nice invariant to rely on, namely that MVC will honor
your declared nullability contract OR report a validation error. This
reinforces the guidance already published by the C# team for using
POCOs/DTOs with nullability. See
https://github.com/aspnet/specs/blob/master/notes/3_0/nullable.md for my
analysis on the topic.

* preemptively fix PR feedback xD

* PR feedback and functional test

* more

* Fix test failures

* fix

* more

* Do a barrel roll
2019-06-02 17:11:43 -07:00