Commit Graph

17582 Commits

Author SHA1 Message Date
James Newton-King 4841d5f019
Update gRPC template dependency for preview 8 and link to macOS docs 2019-07-31 13:50:06 +12:00
Phil Henning b2e11d77e8 Insert seed localization for templates. (#11040)
* Insert seed localization for templates.

* Updated loc strings for Worker for some langs

* Update en string.json for Blazor project template

* Refresh strings for initial seeding
2019-07-30 16:00:08 -07:00
Ryan Nowak 6045c08072 Blazor API Review: Built-in components
Fixes: #12548

Renaming properties to drop 'Content' as a suffix. We haven't been
consistent in using this, and we're removing it instead of adding it
elsewhere.
2019-07-30 09:35:49 -07:00
Ryan Nowak bef01f3e9a Blazor API Review: UIEventArgs types
Fixes: #12550

Removes UIEventArgs in favor of EventArgs as the base class.

Moving Type into all of our event args types - this is important because
many of the events types are used for multiple events.

The only think about this that isn't perfect is that we have keep
special casing change because of how binding works. I renamed the type
to drop the `UI` prefix. It's not possible to define a subclass in the
Web project because of the way covariance works (or doesn't work) in
.NET.
2019-07-29 22:40:28 -07:00
Ryan Nowak 3919dd55c6 Fix globalization for `@bind-value`
Fixes: #12631

These mappings were missing and adding them restores the correct
behaviour. Mixing up the usage of `@bind` vs `@bind-value` so we have
more coverage of this.
2019-07-29 22:39:56 -07:00
Ryan Nowak 82478eac6b Blazor API Review: Forms
Fixes: #12549
2019-07-29 22:37:12 -07:00
Brennan ad533b76fb Limit max handshake size (#12678) 2019-07-29 16:34:25 -07:00
Stephen Halter 75f4159e5a
Accurately count only newly examined bytes (#12639)
- Ensure Kestrel count all bytes read using TryRead
- Ensure Kestrel doesn't double count examined but
  not consumed bytes
2019-07-29 10:14:14 -07:00
John Luo 4debc9c455 Update SDK to preview7 (#12682)
- react to SDK changes (Microsoft.NETCore.App.Ref assemblies grouping)
- update `dotnet new -u` logic
2019-07-29 10:06:07 -07:00
John Luo e2d57e2806
Revert "Improve components infrastructure (#12145)" (#12679)
* Revert "Improve components infrastructure (#12145)"

This reverts commit e149f9c0aa.

* Update JS file
2019-07-29 09:03:57 -07:00
David Fowler ad94d41a7f Fixed parameter name casing (#12681) 2019-07-29 07:25:28 -07:00
Alessio Franceschelli c23b9feb19 HeaderPropagation: reworded registration exception for clarity (#12636)
* HeaderPropagation: reworded registration exception for clarity

* feedback
2019-07-27 12:59:17 -07:00
Brennan a1e77a2c09
Set transport handlers earlier in Typescript client (#12524) 2019-07-26 21:54:07 -07:00
James Newton-King 2d4fd05adf
Add host caution to MVC GetUri extension methods (#12629) 2019-07-27 15:39:25 +12:00
Brennan 98abd9e256
Cleanup exception message (#12623) 2019-07-26 15:54:27 -07:00
Justin Kotalik 4aebd29abc
Increase Http2 Header limit size to the MaxFrameSize (#12625) 2019-07-26 14:31:48 -07:00
John Luo e149f9c0aa
Improve components infrastructure (#12145)
* Remove generated Web.JS javascript files files

* Build NodeJS project referenced by managed projects by default

* Build Web.JS before other CI jobs

- We can't build Web.JS on Linux Musl for example

* Make BuildAll not override explicit BuildJava/NodeJS/Native/Managed settings

* Capture CodeCheck logs for debugging

* Skip NodeJS projects when generation ref assemblies

* Do not build dependent projects if NodeJS is not built

* Make build fail immediately if BuildNodeJS is true but NodeJS is not installed

* Do not build nodejs in installer builds
2019-07-26 13:31:01 -07:00
Chris Ross 922fd9cb0d React to kestrel merge conflict (#12624) 2019-07-26 11:55:37 -07:00
Hao Kung a0e0338d7e
Add missing area in link generation for identity UI (#12590) 2019-07-26 11:04:08 -07:00
Javier Calvarro Nelson 0d553f7147
Fix small issue in Identity UI (#12607)
The logic for selecting the views assembly had a small bug.
Added an E2E test to cover the scenario.
2019-07-26 19:37:13 +02:00
Justin Kotalik 51497f72a6
Check length for pipe test rather than byte content (#12612) 2019-07-26 09:59:08 -07:00
Ryan Nowak bfd4305fd8
Blazor API Review: Parameters (#12547)
* Blazor API Review: Parameters

Part of #11610
2019-07-26 09:46:47 -07:00
Chris Ross 5631b97d12
Kestrel HttpClient Http2 interop tests #4763 (#11869) 2019-07-26 09:45:45 -07:00
Justin Kotalik 2a35f8ee4c
Merge pull request #12444 from dotnet-maestro-bot/merge/release/2.2-to-master
[automated] Merge branch 'release/2.2' => 'master'
2019-07-26 08:02:12 -07:00
David Fowler e78d17e07b
Update HubProtocol.md (#12509)
* Update HubProtocol.md

Updated the code sample in the protocol doc to reflect the actual programming API

* Update src/SignalR/docs/specs/HubProtocol.md

Co-Authored-By: Brennan <brecon@microsoft.com>
2019-07-25 19:12:14 -07:00
Brennan 331ff2404d
Send HttpOnly (if applicable) when deleting cookies (#12593) 2019-07-25 17:42:23 -07:00
Pranav K d7bfbb5824
Add formatter mapping for JSON (#12592)
Fixes https://github.com/aspnet/AspNetCore/issues/12414
2019-07-25 16:50:54 -07:00
Martin Stenhoff b13f2614de Changing Analzyer to Analyzer 2019-07-25 16:38:24 -07:00
Dylan Dmitri Gray 1aebfa681a
Dylan/resettable tcs (#12453)
* renames, resettable tcs; custom awaitable now dispatches
2019-07-25 16:38:13 -07:00
Chris Ross 080660967b
Unified response body features (#12328) 2019-07-25 16:27:08 -07:00
John Luo 2884ef6e1f
Update default project names (#12431) 2019-07-25 14:56:51 -07:00
Harley Adams a07ad16e4d IIS - Skip setting a header if the value is empty #11032 (#12486) 2019-07-25 14:39:52 -07:00
Brennan 648bdf706e
Avoid unobserved tasks in WebSocketsTransport (#12315) 2019-07-25 14:25:00 -07:00
Andrew Stanton-Nurse cac51846e9
fix #12516 by cleaning up Hosting error page (#12545)
* fix #12516 by cleaning up error page

* add a Diagnostics.slnf because I was there

* missed the IIS update

* update WebHost's error page

* Fix slnf path
2019-07-25 13:01:00 -07:00
Javier Calvarro Nelson e0d522e1f7
Remove flaky mark from E2E templates tests (#12450)
* Removes the [Flaky] mark for the React_IndividualAuth test.
* Removes the [Flaky] mark for all the blazorserverside template tests.
2019-07-25 21:59:51 +02:00
Justin Kotalik 8cbc76f1ec Merge remote-tracking branch 'origin/release/2.2' 2019-07-25 11:41:11 -07:00
Justin Kotalik d463dc7721
Update CorsMiddlewareFunctionalTest.cs (#12571) 2019-07-25 11:28:30 -07:00
Pranav K a181fc2b67
Clean up MvcSandbox (#12542) 2019-07-25 10:25:07 -07:00
Ryan Nowak 6526022f6c Blazor API Review: RenderTreeBuilder
Fixes: #12415
2019-07-25 09:45:26 -07:00
N. Taylor Mullen c76cb9248d Add support for increment/decrement [Parameter] usage detection.
- Didn't realize there was an increment or decrement operation kind.
- Added tests to cover this scenario

#12543
2019-07-25 08:47:13 -07:00
Javier Calvarro Nelson 143c101693
[Identity] Move to use static web assets support. (#11029)
* Moves Identity UI to use Static Web Assets
  * Removes the static files as embedded content.
  * Stops plugging the static assets through the embedded file provider.
  * Selects the UI framework at build time instead of runtime.
2019-07-25 17:34:45 +02:00
Justin Kotalik 9a6d4af9d6 Merge release/2.1 into release/2.2 (#12290) 2019-07-24 18:01:57 -07:00
Justin Kotalik 69feac2633
Catch all exceptions from Exit shutdown (master). (#12522) 2019-07-24 14:56:04 -07:00
Stephen Halter 34903da1e9
Fix ConcurrentPipeWriterTests (#12383) 2019-07-24 14:51:31 -07:00
N. Taylor Mullen c54a7209d7 Clear route values after middleware invocation.
#11233
2019-07-24 14:12:06 -07:00
N. Taylor Mullen 479d5ed40a Addressed code review comments. 2019-07-24 14:12:06 -07:00
N. Taylor Mullen 9a6881b0e8 Fix endpoint routing statefulness.
- In the case that other middleware change the path of an `HttpContext` and cause middleware to re-invoke we used to short-circuit on second time through the middleware pipeline, now we allow routing to occur.
- Added unit tests to validate the clearing of state.

#11233
2019-07-24 14:12:06 -07:00
Steve Sanderson 54da777b7c
Reset scroll position after navigation. Fixes #10482 (#12423) 2019-07-24 10:25:59 -07:00
Steve Sanderson 8b7fcf1f76
Update user on reconnect. Fixes #12051 (#12421) 2019-07-24 10:23:38 -07:00
Artak 9b6f10d20c
Marked the RunClientTests as flaky (#12497) 2019-07-24 09:51:55 -07:00
Steve Sanderson dd0d483f7d
Fix Web.JS tests (#12513) 2019-07-24 09:48:12 -07:00
Hisham Bin Ateya 28678ee430 Change unsupported culture log level (#12153)
* Change unsupported culture log level to Debug

* Fix unit tests
2019-07-23 20:05:10 -07:00
Andrew Stanton-Nurse 4928eb3de0
fix #12445 by migrating dotnet-sql-cache to new SqlClient (#12447) 2019-07-23 14:40:18 -07:00
Ryan Nowak 3e2f88497d Remove manual ref-assembly generation for Components 2019-07-23 14:39:14 -07:00
Alessio Franceschelli 14c6abafda Test PageActionInvoker logs and fix declaring type name for handler in logs (#12326)
* Test PageActionInvoker logs and fix declaring type name for handler
2019-07-23 10:38:39 -07:00
Andrew Stanton-Nurse 48b44dbb92
Add clarifying comment to HttpMethods.cs (#12441)
To help prevent well-meaning (but not actually desirable) changes like https://github.com/aspnet/AspNetCore/pull/12439
2019-07-23 08:09:16 -07:00
Ben Adams 2e0d7889ad Kestrel code tidyups (#11896) 2019-07-22 12:57:52 -07:00
Javier Calvarro Nelson c918d72f36
[Blazor] [Fixes #11847] Renderer.DispatchEventAsync throws null reference exception if event handler throws synchronously (#12393)
[Blazor] [Fixes #11847] Renderer.DispatchEventAsync throws null
reference exception if event handler throws synchronously
* Returns after handling the exception.
* Adds a unit test and an E2E test to validate expected behavior.
2019-07-22 19:14:30 +02:00
Javier Calvarro Nelson d846cb4b97
[Blazor] Update typescript dependencies (#12395)
* [Blazor] Update npm dependencies to fix security vulnerabilities
* Update to latest typescript compiler
2019-07-22 19:10:45 +02:00
Pranav K a99ab25700
Add converters for ProblemDetails and ValidationProblemDetails (#12216)
* Add converters for ProblemDetails and ValidationProblemDetails

ProblemDetails & ValidationProblemDetails require IgnoreNullValues to be
applied on the types. We'll use a converter to workaround the absence of this
feature

Fixes https://github.com/aspnet/AspNetCore/issues/11522
2019-07-22 09:40:04 -07:00
David Fowler f8c22859a0
Complete the reader in Dispose (#12430)
- This should avoid issues about completing while still reading.
- Dispose the HttpResponseMessage in some tests that use ResponseHeadersRead);
2019-07-22 09:23:22 -07:00
Andrew Stanton-Nurse fd5517f301
Be more defensive in BufferingDisabled test (#12278)
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2826

We [use `?.` in `master`](f56cb72b7f/src/Hosting/Server.IntegrationTesting/src/Deployers/ApplicationDeployer.cs (L103)) and it seems like the test can end up in this state (by the linked issue) so back-porting that defensive measure seems reasonable.
2019-07-22 09:20:40 -07:00
Steve Sanderson 077df0e3ca
Support more types of redirection during prerendering. Fixes #11591 (#12418)
* E2E test to show current behavior

* Actually support base-relative, root-relative, and absolute redirections during prerendering

* Fix MVC functional test
2019-07-22 08:14:10 -07:00
Steve Sanderson 178374d228
Make reconnection work more realistically (#12420)
* Support reconnection even if an earlier attempt failed

* Add "reload" button to reconnect dialog on failure

* Update blazor.*.js
2019-07-22 07:52:20 -07:00
Artak Mkrtchyan 330a7708c0 Dependency updates 2019-07-22 06:59:25 -07:00
David Fowler 9851e01688
Track connection earlier (#12387)
- We made a change to dispatch connection execution but that also ended up dispatching the tracking of those connections in the connection manager. While it's not a huge deal most of the time it can affect graceful shutdown as there can be queued connections that are delayed in the thread pool queue which are untracked. This change makes it so we track the KestrelConnection before dispatching.
2019-07-21 21:14:03 -07:00
Steve Sanderson 2c3a44371a
Clear unused routing params. Fixes #7419 (#12407) 2019-07-21 20:00:03 -07:00
Steve Sanderson 22fbeac336
Clarify IUriHelper GetAbsoluteUrl behavior. Fixes #9717 (#12422)
* E2E test showing it already works when navigating inside the app

* E2E test showing expected behavior around both sides of prerendering
2019-07-21 17:22:26 -07:00
Steve Sanderson e043f9317f
Make server-side Blazor template logout use POST. Fixes #11981 (#12419) 2019-07-21 17:20:46 -07:00
Pranav K 36a651e29a
Support fewer data types in BlazorPackHubProtocol (#11662)
These are data types not used \ required by Blazor.
2019-07-21 16:39:45 -07:00
Ryan Nowak 6421c41d30 Update refs 2019-07-21 14:28:41 -07:00
Ryan Nowak f00a6e9c50 Move UIEventArgs types 2019-07-21 14:28:41 -07:00
Ryan Nowak 53c76c70fe Move NavLink to Web
Also undid the use of ref assemblies in our tests. This is kinda wierd
and breaks dev inner-loop.
2019-07-21 14:28:41 -07:00
Ryan Nowak 2aa9933e54 Move Forms to Web 2019-07-21 14:28:41 -07:00
David Fowler ac7f30e63b
Small cleanup to HttpConnection (#12346)
- Remove code that detects the Initializing state. We're already selected before any of those callbacks can run.
- Added asserts
2019-07-21 00:27:58 -07:00
Ben Adams 09dfe83aa9 Remove infinite loop from Email.cshtml.cs (#12400) 2019-07-20 17:37:58 -07:00
Ben Adams 65ca72c420 Better context pooling (#12385)
- This change goes from pooling just the HttpContext to pooling the entire TContext. In the past this was a huge struct that got copied around and now it can be a class. Servers can provide the storage for the TContext via a new `IHostContextContainer<TContext>` interface. 
- Removed IDefaultHttpContextContainer since it's been superseded by IHostContextContainer
- Move DefaultHttpContextFactory to Hosting to take advantage of internal methods
- Also handle a null FeatureCollection and null HttpContext and throw a better exception
2019-07-20 13:07:20 -07:00
Ryan Nowak 4ac6a4ad35 Fix second part of #12286
We used to be inconsistent between what we'd do when formatting a value
based on whether or not you specified a format.

This change brings us back into consistency.

For a `default` DateTime/DateTimeOffset we will just call ToString on
it. For a `default` nullable of these types we will return the empty
string.
2019-07-20 10:26:31 -07:00
Ryan Nowak 3e10688d12 Attempt to fix bind tests for non-en-US
While it's definitly intended for `@bind` to have culture-sensitive
output for most cases, we want the tests to behave consistently for all
developers.

So this is an attempt to use a fixed culture for all of our testing.
2019-07-20 10:26:31 -07:00
Ryan Nowak d96f444a6b Add support for type="number" and type="date" 2019-07-20 10:26:31 -07:00
Ryan Nowak af7ac7ff29 Add ability to specify culture and format
This lets us specify the associations between the HTML5 field types and
these settings.
2019-07-20 10:26:31 -07:00
Ryan Nowak 3aeee00899 Unskip weakly-typed component bind tests 2019-07-20 10:26:31 -07:00
Ryan Nowak 3f02894057 Add workaround for current tooling
We don't want to put this in one of the product assemblies because that
would undo the API review xD
2019-07-20 10:26:31 -07:00
Javier Calvarro Nelson 7bf660947b
[ApiAuth] Switches back to use code+PKCE (#12375)
* Move SPA flows to use code + pkce
* Updates OIDC dependency to 1.9-beta1
2019-07-20 13:06:53 +02:00
Ryan Brandenburg 3a590b4324 Endpoint routing in SPA templates (#11621)
* Endpoint routing in SPA templates

* Revert "More doc comment additions"

This reverts commit ef2c042ec73f221a07d369e0c5f9ddd22298a632.

* PR feedback

* PR feedback

* Don't make the same mistake twice

* Resolve rebase problems

* Remove missing variable

* MapRazorPages

* Conditionalize

* Use variables that exist

* Fix variable names
2019-07-20 00:21:02 -07:00
Artak 789b8f1366
Updated the ThirdPartyNotices link (#12382)
* Updated the ThirdPartyNotices link for 3.0
2019-07-19 21:28:18 -07:00
Doug Bunting fcb6575f19
Address immediate issues in service reference feature (#12366)
- #12363
- correct a few VS issues
- void silent failures
- improve documentation
- support the `clean` target
- stop using experimentatal package version
2019-07-19 19:14:30 -07:00
Javier Calvarro Nelson 470bfddf92
[Blazor][Fixes #8003] Improves reconnects when the client doesn't perform graceful disconnects (#12327)
* Allows the server to accept acks with a higher sequence number than the first queued pending render and caches up to it.
* Makes the client send acks for previous render batches.
* Makes the client repeat acks for errored render batches if it keeps receiving new render batches.
* Client awaits sending acks to ensure that they get send in order.
2019-07-20 02:16:32 +02:00
Hao Kung 79283cf2de
Identity UI fixes (#11768) 2019-07-19 16:23:43 -07:00
Hao Kung 775314b142
Update identity migrations to 3.0.0 (#12258) 2019-07-19 16:13:00 -07:00
Pranav K 533ed4240c
Code review feedback for transcoding Streams (#12142) 2019-07-19 16:01:53 -07:00
Ryan Nowak d992a1e2ef Blazor API Review: Server-side startup code
Fixes: #12220

Just some small tweaks here, it's already great.
2019-07-19 15:34:44 -07:00
Ryan Brandenburg e69d378442
RazorClassLibrary Components (#12134)
RazorLibrary components
2019-07-19 13:38:29 -07:00
Ben Adams 5a0a7aa088 Capture Edi at Abort not throw (#11875) 2019-07-19 13:34:19 -07:00
Steve Sanderson e6a4d9f19e Update reconnection E2E tests 2019-07-19 13:29:31 -07:00
Pranav K a77738e52f
Combine attributes specified on Page and PageModel (#12332)
Fixes https://github.com/aspnet/AspNetCore/issues/11296
2019-07-19 13:15:02 -07:00
Ryan Nowak b23ea5b668 Improvements to MVC EventData typess
Improvments to names
- Using EventData suffix
- More clarity for events assocated with filters

Fixes: #12263

We have to report the BeforeActionMethod using its old signature because
it's used by Intellitrace. I added a new pair of events with a better
name to use with strong types since there's no practical way to update
the old ones.
2019-07-19 12:53:40 -07:00
Artak 39c3ca2d9f
Updated the template per #12245 (#12325) 2019-07-19 12:35:39 -07:00
Brennan 7b65a32b8b
Fix flaky test (#12365) 2019-07-19 12:33:38 -07:00
Steve Sanderson 1950e59714
Make static prerendering support auth. Fixes #11799 (#12318)
* Make E2E prerendering test use static prerendering (we no longer need coverage for stateful prerendering)

* Use authentication state during static prerendering. This replicates issue #11799 in the E2E test

* Initialize the authentication state provider during static prerendering

* Update ref assembly

* Update unit test
2019-07-19 19:26:33 +01:00