f7fc2647de
var all the things ( #1855 )
2018-04-05 18:41:13 +12:00
fccc9d1b50
fix #1815 by disposing linked cts ( #1849 )
2018-04-04 21:12:21 -07:00
32b4d5cc6c
Set X-Requested-With on all requests ( #1848 )
2018-04-04 17:12:50 -07:00
80f87e7730
Add Handshake timeout to C# Client ( #1840 )
2018-04-04 15:54:42 -07:00
490fd088f9
Merge branch 'release/2.1' into dev
2018-04-04 15:02:47 -07:00
1c7ca7fa3a
Remove lazily initialization of the pipes ( #1850 )
...
- This fixes race condition
2018-04-04 14:43:34 -07:00
e7b84b753b
Refactor HubConnectionBuilder ( #1830 )
2018-04-04 21:19:13 +12:00
7c2d9e87e9
Clean up pipe pair on transport start failure ( #1836 )
2018-04-03 17:08:04 -07:00
ba0131a731
Rename TransportTypes to HttpTransportTypes ( #1839 )
2018-04-03 16:00:20 -07:00
d23f2beafc
Merge release/2.1 into dev ( #1834 )
2018-04-03 10:45:44 -07:00
416b27c6d6
Fix build ( #1825 )
2018-04-03 11:45:05 +12:00
6a1367ff70
Reaction to *Memory changes ( #1824 )
2018-04-02 16:44:31 -07:00
3460d44848
Fix non-serializable tests ( #1820 )
2018-04-03 09:31:52 +12:00
5ce672dfe6
ThreadStatic MemoryBufferWriter ( #1821 )
2018-04-02 11:25:04 -07:00
6640f14e35
Detailed errors enabled for functional tests ( #1822 )
2018-04-02 10:42:26 -07:00
e6e45cea05
Change how HttpConnection sets headers ( #1806 )
...
- Removed SendUtils.PrepareRequst and instead used HttpClient.DefaultRequstHeaders to set the common headers to apply HttpOptions to all outbound requests
- Modified how we check for the user agent request testing
2018-03-31 22:23:09 -07:00
04a22f23dd
Deserializing ISO formatted strings in method arguments ( #1812 )
2018-04-01 12:26:30 +12:00
903a9ea6a0
Use IBufferWriter in IHubProtocol ( #1791 )
2018-03-30 17:30:08 -07:00
eb7dc14c39
Handle uninitialized connections in disposal ( #1786 )
...
- We made a change to not initialize pipes up front
on connection creation. That change make it null ref in disposal because we didn't check if the pipes were initialized.
- Added a test
- Also fixed the EchoConnectionHandler in the functional ts tests.
2018-03-30 15:44:30 -07:00
6b3a27e73c
Bedrock Renames ( #1777 )
2018-03-30 15:09:19 -07:00
0362905a70
Re-enable ConnectionCanSendAndReceiveMessages + logging ( #1778 )
2018-03-31 08:45:33 +13:00
313133131f
Check for Websockets in Fallback functional tests ( #1772 )
2018-03-30 12:33:42 -07:00
44b667b3e6
Add detailed error option ( #1763 )
2018-03-30 11:30:07 -07:00
a26e6f5a30
Make shutdown logic for SSE and LongPolling more similar to WebSockets ( #1779 )
...
- Cancel reading from the application when initiating a transport stop
- Complete each side of the pipe in the place where the pipe is being consumed
- Errors from sending end up getting sent to the application
- The Running task never throws
- Removes ContinueWith
2018-03-30 01:50:30 -07:00
46f27cdd0b
Fix internal HubConnection state when handshake fails ( #1774 )
2018-03-29 16:35:31 -07:00
7a53e07623
Parse data as it comes in off the wire in the .NET client and server ( #1766 )
...
- Change websockets and the POST end point to send data unbuffered.
- Update tests to handle partial frames
2018-03-29 10:03:59 -07:00
7f86b92f7e
Handshake and negotiation optimization ( #1731 )
2018-03-29 17:50:45 +13:00
eb2fa9bacd
Fix more flaky tests ( #1750 )
2018-03-28 15:27:40 -07:00
8c84518ecc
Message writing optimization ( #1683 )
2018-03-29 11:03:40 +13:00
890c8566d6
Fix WebSocketsSupportedConditionAttribute version check ( #1751 )
2018-03-28 14:56:03 -07:00
19b9dca268
Change IHubProtocol interface to support partial parsing ( #1745 )
...
- These are the finishing touches before we disable batching on the
C# client and on the server. We're changing the IHubProtocol interface to
modify the input buffer with what was consumed. We're also changing it
to parse a single message at a time to be match what output writing does.
- Added TryParseResponseMessage and made it look like TryParseRequestMessage
2018-03-28 12:08:16 -07:00
c631b87c6d
Check for Websockets to fix flaky tests ( #1740 )
2018-03-28 00:49:37 -07:00
cfaa123eb8
IConnection refactoring ( #1718 )
...
- IConnection is now single-use and HubConnection creates a new instance
for reconnecting
- IConnection is just a Pipe now, no more events
2018-03-27 23:02:07 -07:00
5b85e8309e
Adding File Header ( #1741 )
2018-03-27 21:54:11 -07:00
185453908f
Remove HubConnectionContext parameter from IHubProtocolResolver ( #1735 )
2018-03-27 10:25:00 -07:00
7a9160f3e0
React to https://github.com/aspnet/KestrelHttpServer/pull/2428 ( #1734 )
2018-03-27 02:02:29 -07:00
79b51ad642
Added logging of .NET client HTTP requests ( #1723 )
2018-03-27 12:57:13 +13:00
b8285b8356
Don't create the span on netstandard ( #1721 )
...
- Directly pin the char[]
- Changed Utf8BufferTextReader to use the Utf8Decoder
- It copies whatever it can into the char buffer allocated in a stateful way (it's more efficient).
- Added tests for unicode and ascii reading
- Added a thread static cache
2018-03-26 14:36:08 -07:00
4f5bc7046e
Add conditional test attribute for WebSockets ( #1709 )
2018-03-25 18:53:49 +13:00
cb05ce4e0b
Progress towards deleting Sockets.Abstractions ( #1705 )
...
* Progress towards deleting Sockets.Abstractions
- Moved our custom DefaultConnectionContext to Sockets.Http and renamed it to HttpConnectionContext.
- Renamed ConnectionManager to HttpConnectionManager
- Use DefaultConnection in tests and benchmarks
- Delete ConnectionMetadata
2018-03-24 04:21:47 -07:00
2e63e5afe3
The rename games part 1 of many ( #1696 )
...
- React to rename of EndPoint to ConnectionHandler
- Rename UseSockets to UseConnections
- Rename MapEndPoint to MapConnectionHandler
- Rename HttpSocketOptions to HttpConnectionOptions
2018-03-22 22:35:55 -07:00
a47e1051e8
Add protocol version to handshake ( #1666 )
2018-03-22 15:54:35 -07:00
f1a3775247
Copy HttpContext properties for long polling transport ( #1684 )
...
- The long polling transport simulates a persistent connection
over multiple http requests. In order to expose common http request
properties, we need to copy them to a fake http context on the first poll
and set that as the HttpContext exposed via the IHttpContextFeature.
2018-03-22 15:24:35 -07:00
b5c46f35b3
Check for actual start in SSE ( #1681 )
2018-03-22 19:03:48 +00:00
3f84eee116
Detect availability of web sockets on client and server ( #1682 )
2018-03-22 12:35:31 +13:00
6053a34cf3
Don't expose HubConnectionContext on the Hub ( #1674 )
...
- Made HubCallerContext an abstract class
- Made DefaultHubCallerContext that gets data from the HubConnectionContext.
- Removed IP address
- Removed Connection property
2018-03-21 10:07:41 -07:00
e889175c0e
Properly wait for process exit for docker helper and log errors ( #1667 )
2018-03-21 09:21:33 -07:00
6583e5fb47
Improved allocations and throughput for broadcast scenarios ( #1660 )
...
- Don't allocate when enumerating connections
- Don't allocate tasks unless we truly go async
- Don't get the timestamp, just write the pings always (if there's no ongoing write)
- Track the time since last keep alive write instead of the last write
- ValueTask all the things!
- Renamed HubConnectionList to HubConnectionStore
2018-03-21 09:03:36 -07:00
885679c8bd
Made HubEndPoint derive from EndPoint ( #1658 )
...
* Made HubEndPoint derive from EndPoint
2018-03-20 08:31:35 -07:00
4f10560087
Rename negotiate to handshake, add handshake response, add close frame ( #1591 )
2018-03-20 17:40:22 +13:00
b792fcb4ef
Reduce the per message read allocations ( #1635 )
...
- Introduced Utf8BufferTextReader that writes buffers directly into
the char[] allocated by JSON.NET when reading via the JsonReader.
- Use IArrayPool implementation over ArrayPool<char> when reading
incomming messages.
- Replaced JToken parsing with manual parsing using JsonTextReader.
- Added tests for parsing incoming JSON messages with out of order
properties.
- Make access to message headers lazy
- Changed IHubProtocol.TryParseMessage to be ReadOnlyMemory<byte> instead of ReadOnlySpan<byte>
2018-03-18 15:16:03 -07:00
db0dc0f960
Ignore writeasync failures when sending to multiple connections ( #1589 )
2018-03-16 16:48:05 -07:00
0e38ee3e63
Create connectionIds using RNGCrypto ( #1606 )
2018-03-16 16:16:34 -07:00
2d6077db4a
Removed params from proxy's SendAsync and rename to SendCoreAsync ( #1605 )
2018-03-16 14:05:22 +13:00
d27844dfef
ConnectionMetadata is now ConnectionItems ( #1604 )
...
* ConnectionMetadata is now ConnectionItems
2018-03-14 20:57:40 -07:00
2b68db873a
add AddRedis overload that takes connection string ( #1588 )
2018-03-14 16:24:28 -07:00
6a8ede0770
Further making Microsoft.AspNetCore.Sockets "not a thing" ( #1599 )
...
- This PR attempts to move things where they are needed instead of where they
happened to be used. As a result we should now have Sockets.Abstractions and
Sockets down to the minimal set of things required to make them run.
Sockets.Abstractions should go away in favor of Protocol.Abstractions and
Sockets contains the EndPoint abstraction and related types.
- Moved ConnectionManager and friends to
Sockets.Http.
-Removed Sockets and moved everything into Sockets.Abstractions.
- Moved DefaultConnection and put it in Sockets.Abstractions.
2018-03-14 15:37:24 -07:00
dc0567690d
Use features from Protocol.Abstractions ( #1594 )
...
- This is part of the grand unification of the connection layer between SignalR and Kestrel
2018-03-14 08:17:07 -07:00
62956530ae
Rename StreamAsync to StreamAsChannelAsync ( #1587 )
2018-03-13 15:04:11 -07:00
fb6121399c
Remove support for binary over SSE and add transfer format to negotiation ( #1564 )
2018-03-13 14:29:32 -07:00
d816c6ef60
Add additional properties to HttpOptions ( #1557 )
2018-03-13 09:46:34 +13:00
0b81658850
Add SignalR Marker Service ( #1573 )
2018-03-10 00:58:57 +00:00
d6178f2482
Fixed streaming hub method with ValueTask ( #1572 )
2018-03-10 12:31:38 +13:00
4a4efe0f39
Update to new corefx ( #1561 )
2018-03-08 14:23:20 -08:00
99aa25e4d8
Add Missing File Header ( #1560 )
2018-03-08 19:49:32 +00:00
adbd964efd
Transport Fallback ( #1455 )
2018-03-08 06:49:03 +00:00
a41bf6228f
Client sends user agent with version based on assembly version ( #1551 )
2018-03-08 10:25:12 +13:00
1c44e8febf
Fix streaming hub methods combined with async ( #1544 )
2018-03-07 20:07:06 +13:00
1b9313287b
Restrict HubProtocol on Server + HubOptions<THub> ( #1492 )
2018-03-07 01:31:56 +00:00
846432c9ac
Improve unexpected server error message to client ( #1532 )
...
* Improve unexpected server error message to client
* Separated expected vs unexpected errors in error message. Fixed broken tests
* Fix ts functional tests
2018-03-06 22:11:46 +13:00
9c74991ad6
set the RID for tests in netfx ( #1516 )
2018-02-28 14:09:11 -08:00
8908eec6e7
Pipelines in corefx ( #1501 )
2018-02-28 12:42:01 -08:00
1790d6bdf0
Serialize once per format to increase perf in broadcasting scenarios ( #1498 )
2018-02-27 14:55:00 -08:00
0e4731e480
Expose Transport and Application Max Buffer Sizes ( #1473 )
2018-02-25 08:47:14 +00:00
f7da0edcb2
Skip ConnectionCanSendAndReceiveMessages
2018-02-23 11:45:24 -08:00
6a2d41cc9f
Fix #924 by introducing HubDispatcher abstraction ( #1479 )
2018-02-22 20:59:34 -08:00
32baa655b9
Do over the websocket transport ( #1481 )
...
* Do over the websocket transport
- Unify client and server logic (no code sharing yet)
- Removed use of cancellation tokens to communicate shutdown and instead used the pipe reader and socket abort.
- Added CloseTimeout to HttpOptions
2018-02-22 15:19:25 -08:00
7d035f48bc
Revert "Add timeout back to hanging test ( #1480 )" ( #1482 )
...
This reverts commit 09adc4a847
2018-02-22 00:44:06 -08:00
09adc4a847
Add timeout back to hanging test ( #1480 )
...
- Increase timeout to 60 seconds
2018-02-21 21:50:50 -08:00
b3a33efeae
Update MsgPack-Cli version
...
* Fixes #1301
* Fixes #1058
* Fixes #1422
2018-02-20 13:57:42 -08:00
c8d4cf689f
Tackling some low hanging performance fruit ( #1470 )
...
* Tackling some low hanging performance fruit
- Use native Memory/Span APIs on Stream and WebSocket in .NET Core 2.1
- Remove double copying in formatters
- Implemented custom HttpContent over ReadOnlyBuffer<byte>
2018-02-20 13:50:31 -08:00
bfa2df1fc6
Remove timeout from receive tcs. ( #1471 )
...
* Remove timeout from receive tcs.
- This test echos a large message and it fails sometimes before the entire thing is delivered. Just drop the timeout.
- Avoid creating timers for already completed tasks
2018-02-19 20:15:47 -08:00
e1bb2215e5
Remove the Channel<HubMessage> from the HubConnectionContext ( #1468 )
...
* Remove the Channel<HubMessage> from the HubConnectionContext
- Replace the channel with a single lock around the pipewriter. Since writes are always synchronous, the lock is held for a very short time.
- We were only using them in this scenario for handling multiple producers (the hub output, the keep alive ping and the broadcast).
- Handle the scenario where there's back pressure (when we use pipes that are bounded) and give callers a single task representing when back pressure is released.
- Handle synchronous exceptions in RedisHubLifetimeManager
- Fixed benchmarks
2018-02-17 10:22:11 -08:00
3acd29ec6f
Revert "Fix flaky SSE test ( #1279 )"
...
This reverts commit 6fcf554c23
2018-02-16 19:01:54 -08:00
6fcf554c23
Fix flaky SSE test ( #1279 )
2018-02-15 09:56:02 -08:00
d9b32ee323
Logging invocations with errors would throw inside logger ( #1445 )
2018-02-13 14:57:21 -08:00
6c22f25818
Client pipelines ( #1435 )
...
- Reworked the Client to be based on pipelines instead of Channels
- SendAsync no longer fails if the http request itself fails but the connection is closed as a result.
- Updated tests
- Base64Encoder needed to support multiple messages in the same span of data
2018-02-12 22:27:43 -08:00
75efe025c3
Skipping flaky tests
2018-02-10 22:17:07 -08:00
9589775f3d
Run tests outside of xunit synccontext ( #1427 )
2018-02-10 20:58:27 -08:00
94155b0e89
Use protocol.abstractions primitives instead of socket abstractions ( #1432 )
2018-02-10 18:10:09 -08:00
01f4bf01cc
Disambiguate between protocol abstractions and sockets (this is temporary)
2018-02-10 13:59:46 -08:00
3e568588d2
Revert "Use protocol.abstractions primitives instead of socket abstractions ( #1429 )" ( #1431 )
...
This reverts commit e3f197cef0
2018-02-10 11:30:41 -08:00
e3f197cef0
Use protocol.abstractions primitives instead of socket abstractions ( #1429 )
2018-02-10 10:45:07 -08:00
2ed78d5762
Don't expose Channel from HubConnectionContext ( #1428 )
...
- Change HubEndPoint to call WriteAsync
- Fixed assert for protocol reader writer
2018-02-09 22:00:28 -08:00
28439d1441
Initial changes to move to pipelines ( #1424 )
...
- Change the Sockets abstraction from Channel<byte[]> to pipelines.
#615
2018-02-09 17:45:21 -08:00
0435b6dc6e
add headers and revamp msgpack tests ( #1382 )
2018-02-07 09:36:29 -08:00
4f7b8f5cf3
Unskip Tests ( #1410 )
2018-02-06 09:40:57 -08:00
a0c47c0c66
Increase ServerFixture startup timeout ( #1409 )
2018-02-06 08:41:16 -08:00
5ccc9e3a0e
Remove some test flakiness and add logging ( #1402 )
2018-02-02 15:04:48 -08:00
5ade419c53
Fix flaky test ( #1397 )
2018-02-01 15:13:40 -08:00
b61dc35ee6
fix #1199 by suppressing ODE in received callback ( #1395 )
2018-02-01 15:08:52 -08:00
9e03075f65
Skip Flaky tests
2018-02-01 11:59:36 -08:00
9482b4976e
Merget release/2.1
2018-01-30 09:48:13 -08:00
e214d5cdfa
Reduce LongPolling timeout to accommodate Cloudflare's timeout ( #1368 )
...
* Reduce LongPolling timeout to accommodate Cloudflare's timeout
2018-01-29 23:55:08 -08:00
ac9db5dc7b
React to pipeline changes ( #1365 )
2018-01-29 14:36:03 -08:00
1cc4098d3a
Defensively stop redis container before starting ( #1356 )
2018-01-25 21:15:15 -08:00
67c76287ed
Return stream method error to client ( #1331 )
...
* Return correct error to client from failing stream method
2018-01-24 09:08:27 -08:00
40e906f23a
Expose IHttpConnectionFeature properties ( #1338 )
2018-01-23 18:25:53 -08:00
b088eaa91f
Rename JwtBearer to AccessToken in C# Client ( #1333 )
2018-01-22 16:05:51 -08:00
a449345436
Clean up logging ( #1308 )
2018-01-22 09:37:53 -08:00
d38764a8f0
Rename InvokeAsync to SendAsync on the server ( #1312 )
2018-01-19 11:32:50 -08:00
0311f9b415
Throw InvalidDataException instead of FormatException in NegotationProtocol ( #1246 )
...
* Throw InvalidDataException instead of FormatException in NegotationProtocol
- Modify NegotiationProtocol to throw InvalidDataException
- Update NegotiationProtocolTests expectations
- Remove test case for InlineData "Missing required property 'protocol'"
- Update JsonHubProtocol & JsonUtils to throw InvalidDataException
- Update corresponding test expectations
- Add back removed test
Addresses #1203
2018-01-11 13:23:30 -08:00
144984e599
Split MsgPack into separate assembly ( #1274 )
2018-01-10 14:20:57 -08:00
89b532c985
Invoke Users ( #1257 )
2018-01-08 17:58:42 -08:00
8b34b7f2ae
Invoke Multiple Groups ( #1254 )
2018-01-05 13:57:19 -08:00
e1f9a65083
MultipleClients -> Clients ( #1269 )
2018-01-05 12:07:26 -08:00
8a4adf1cb6
React to pipeline changes ( #1250 )
...
React to pipeline changes
2018-01-04 09:56:39 -08:00
738617266e
Invoke Multiple Connections ( #1242 )
2017-12-21 15:19:43 -08:00
ac236efdae
Refactoring HubEndpointTests ( #1231 )
2017-12-19 15:01:49 -08:00
3bb71255d4
clean up HttpConnectionTests ( #1208 )
2017-12-19 11:12:39 -08:00
00a6dc983a
Fix #1170 by removing invocationId from non-blocking calls ( #1218 )
2017-12-19 10:40:58 -08:00
c8bd72be36
Others in Group ( #1230 )
2017-12-18 15:27:56 -08:00
eb2668e74e
AllExcept for Groups - GroupExcept ( #1204 )
2017-12-15 17:34:08 -08:00
31ef3c49df
Makes MapHub and MapEndpoint consistent with other ASP.NET Core APIs using PathString. #1188
2017-12-13 09:14:36 -08:00
66ab939cff
Making HttpConnection restartable (C#) ( #1147 )
...
🎉
2017-12-12 10:08:42 -08:00
75e102f97a
Support for Others and Caller Client Subsets( #1192 )
2017-12-11 17:30:53 -08:00
7246e58189
Skip WebSockets on win7 and 2008 ( #1194 )
2017-12-08 10:07:49 -08:00
a8330067c4
Implement #1157 by adding client timeout for C# client ( #1165 )
2017-12-07 14:54:41 -08:00
15c3bca8e6
Change log names in testing and assembly logs are from ( #1182 )
2017-12-05 17:05:22 -08:00
ae9c3cf04d
expand ping test expectations to avoid flakiness ( #1181 )
2017-12-05 10:46:12 -08:00
c1d2024864
Implement #1156 by having the server send Ping messages ( #1161 )
2017-12-04 14:43:27 -08:00
e4671392ec
Fix #1140 by plumbing WebSocketOptions up to HttpOptions ( #1174 )
2017-12-02 17:01:53 -08:00
3005337a9c
fix #625 by implementing HubMethodNameAttribute ( #1173 )
2017-12-01 09:48:26 -08:00
531c7cfba1
More micro benchmarks ( #1158 )
...
- Hub Protocol benchmark
- Broadcast benchmark
- Run benchmarks validation during builds
2017-11-28 15:39:58 -08:00
4394b57143
JWT C# Sample
2017-11-21 16:32:56 -08:00
0bafb304c2
Adding support for JWT in the C# client
...
Fixes : #1018
(Bonus: also enabling passing headers)
2017-11-21 16:32:56 -08:00
fadd6f89fd
Start Redis first in tests ( #1146 )
2017-11-21 14:03:54 -08:00
93cbf4dbef
Change negotiate to POST ( #1122 )
2017-11-17 15:31:47 -08:00
046553cfe4
Avoiding serializing to MemoryStream
2017-11-17 15:02:21 -08:00
75274c76d5
Give redis docker image time to download ( #1131 )
2017-11-17 10:32:15 -08:00
439f2a7892
Update samples and tests to target netcoreapp2.1
2017-11-16 13:38:46 -08:00
cb3124be17
First pass at Keep Alive ( #1119 )
...
This adds the Ping message type and support for sending/receiving it in the Hub Protocols. It does not add the logic to transmit keep-alive frames.
2017-11-16 09:45:13 -08:00
379160707f
Switching to new base64 APIs ( #1127 )
2017-11-16 09:20:40 -08:00
3a8f512fa7
Couple more reaction changes for Hosting ( #1126 )
2017-11-15 13:31:17 -08:00
34b0445dd8
React to delayed Configure in Hosting ( #1118 )
2017-11-14 14:43:56 -08:00
ff43390ed2
[Redis] Add functional test support ( #1051 )
2017-11-14 09:32:14 -08:00
792745ad98
React to CoreFxLab packages ( #998 )
2017-11-13 15:05:35 -08:00
f21d107766
Use different ports in ServerFixture for testing ( #1112 )
2017-11-13 11:32:38 -08:00
ff12b9b20c
Replacing StreamCompletion with StreamInvocation
2017-11-13 10:50:15 -08:00
1a21fd49b1
Changing the Closed Event to be a Task ( #1080 )
2017-11-09 17:51:13 -08:00
James Newton-King
Andrew Stanton-Nurse
BrennanConroy
David Fowler
Mikael Mengistu
Pavel Krymets
Ryan Brandenburg
Josh Williams
Geovanny Alzate Sandoval
Pawel Kadluczka
Pawel Kadluczka
Pawel Kadluczka
Pranav K