Commit Graph

1746 Commits

Author SHA1 Message Date
Ryan Nowak 67b9414ccf Fix IModelBinder docs 2015-12-28 08:56:48 -08:00
Pranav K 43226fe54d Modify FileVersionProvider to cache missing file info.
Fixes #3765
2015-12-23 14:32:39 -08:00
Pranav K 399e516065 Modify IViewComponentHelper to remove method selection ambiguity.
Fixes #612
2015-12-23 10:02:51 -08:00
damianedwards ce0e35ff75 Make ViewLocalizer base name generation more efficient:
- Because @pranavkm made me do it
- And it is actually faster and less allocating than the old code (~25% faster)
- Added some more test cases
2015-12-21 16:25:35 -08:00
Hao Kung 0e8113e393 OptionsModel => Options rename 2015-12-21 15:00:31 -08:00
damianedwards 1529c868f2 Improve ViewLocalizer resource look-up semantics:
- Always prepend with application name and let underlying `IStringLocalizerFactory` do the name gymnastics
- Use ExecutingFilePath instead of view name
- Trim off the file extension (so your resource doesn't have to have ".cshtml" in its name)
- Improved doc comments
- Added tests to cover ViewLocalizer behavior
- #3718
- #2767
2015-12-21 14:22:32 -08:00
Kiran Challa d77655fb73 MVC Controller Response - Wrong ContentType #3245 2015-12-21 11:25:45 -08:00
Ryan Nowak 8fb187bf09 Use system.buffers for our reader/writer 2015-12-18 09:27:36 -08:00
Pranav K 5f66403248 Remove TextWriter.ToString from RazorPage
Fixes #3668
2015-12-18 09:12:28 -08:00
Pranav K c5b6efd6bf Move buffer types to ViewFeatures
Use buffer pooling in more places
2015-12-17 21:05:18 -08:00
damianedwards 0c3e7b5a75 Improve usability of IHtmlLocalizer & associated API:
- IHtmlLocalizer no longer derives from IStringLocalizer
- IHtmlLocalizer indexer now returns LocalizedHtmlString
- IHtmlLocalizer has GetString methods now that act the same as IStringLocalizer.GetString
- Made LocalizedHtmlString a struct to match LocalizedString
- Updated samples in response to aspnet/Localization#167
- Rename "ancestor" to "parent" for loc API
- Fixes some doc comments
- Fixed tests
- #3716
2015-12-17 16:35:19 -08:00
Pranav K 0720d23a19 More reactions to DI 2015-12-17 14:11:58 -08:00
N. Taylor Mullen 2b77744f96 React to aspnet/Razor#630.
- `TagHelperDescriptorFactory` is no longer static.
2015-12-17 12:13:52 -08:00
Pranav K a036ff4738 Reacting to DI changes 2015-12-17 12:03:29 -08:00
Doug Bunting 3d8225502f Change `HtmlString` to inherit from `HtmlEncodedString`
- part of aspnet/HtmlAbstractions#5 fix
- also extend existing special cases to more general `HtmlEncodedString`
2015-12-16 12:42:13 -08:00
Ajay Bhargav Baaskaran 232b27ad5d [Fixes #3430] Removed RouteKeyHandling.CatchAll 2015-12-16 11:57:22 -08:00
Pranav K 7c40759e32 Reacting to Routing changes 2015-12-16 11:49:20 -08:00
javiercn c61cc65db3 [Fixes #3705] Bring back render partial 2015-12-15 12:20:06 -08:00
Ajay Bhargav Baaskaran bbba9dcde6 [Fixes #3524] Handle negative long values in TempData correctly 2015-12-15 00:17:37 -08:00
Doug Bunting 1b7e67211f Do not override default `Layout` value
- #3745
2015-12-14 19:09:57 -08:00
N. Taylor Mullen 29ea696c5a Add `Model` assessor to `ViewResult` for MVC5 portability.
#3495
2015-12-14 16:16:41 -08:00
Ryan Nowak 1126d47b3e React to breaking changes in RouteBuilder 2015-12-14 14:40:38 -08:00
Ryan Nowak a2393f21be Adds ControllerBase to Mvc.Core
This change adds a base class for controllers to Mvc.Core that can be used
without a dependency on views, json, etc.

Most of the functionality on Controller moves to ControllerBase. I kept
the IActionFilter and IDisposable functionality on Controller since it's
not really a fit with the 'minimal' philosophy.
2015-12-14 10:29:55 -08:00
Ryan Nowak ad3c460500 React to breaking in IRouteConstraint 2015-12-14 10:08:09 -08:00
Ryan Nowak ee6ef3f25f Last part of #3676
Uses the correct IEnumerable<> in validation strategies
2015-12-14 08:52:44 -08:00
ryanbrandenburg 3393ba43c2 * Parameters into the messages 2015-12-11 12:05:44 -08:00
Ryan Nowak ed93a6c812 React to routing breaking changes 2015-12-11 09:30:51 -08:00
Kiran Challa f2bb90fa55 Fix localization tests 2015-12-10 22:37:20 -08:00
Ryan Nowak 96de1dbe4b Remove IExcludeTypeFilter
- Removes IExcludeTypeFilter
- Replaced with a property 'ValidateChildren' on ModelMetadata
- Teach ValidationVisitor to respect 'ValidateChildren' for enumerable
  types.
2015-12-09 12:30:13 -08:00
Sebastien Ros 774ee05508 Clean up ViewStartPages usage in RazorView
Fixes #3682
2015-12-09 10:55:59 -08:00
Ryan Nowak cf6662d0c3 Partial fix for #3676 - fix race in ElementMetadata
The accessor for ElementMetadata can sometimes return null when
concurrently accessed.

This change solves this issue and simplified a bunch of lazy-computed
properties, by precomputing all type-related facets of ModelMetadata.

This also adds a ElementType property to ModelMetadata to maintain
the current separation of concerns as ModelMetadata is unaware of the
metadata provider.
2015-12-09 08:21:18 -08:00
Pranav K c6f8ced9a2 Fixing CoreCLR package versions 2015-12-08 16:40:03 -08:00
Pranav K 8c4b5c6c9a Fixing build break 2015-12-08 15:57:19 -08:00
Pranav K be46c7602e Add IAssemblyLoadContextAccessor to the service collection 2015-12-08 15:42:09 -08:00
Pranav K 218613bc0a Reacting to Diagnostics changes 2015-12-08 15:10:59 -08:00
David Fowler 6467d0d475 Add ILibraryManager explicitly 2015-12-07 18:00:03 -08:00
John Luo f9f59fe58b Reacting to verbose rename 2015-12-07 14:50:54 -08:00
Ryan Nowak 09a293afe9 React to routing cleanup 2015-12-07 13:08:13 -08:00
David Fowler 99f501152b Remove dependency on ICompilationOptionsProvider
- Removed Configuration from RazorViewEngineOptions
- Added ParseOptions and CompilationOptions to RazorViewEngineOptions
2015-12-07 12:29:52 -08:00
Ryan Nowak aa48f79816 Use Routing.Abstractions 2015-12-03 18:07:14 -08:00
Pranav K ff34c5404a Implement a backing-buffer for Razor using pooled memory
Fixes #3532
2015-12-03 17:42:20 -08:00
Doug Bunting 1f76b3c7b7 Clean up remaining `HtmlString` usage
- #3122 and #3123 (5 of 5)
- avoid concatenating values and wrapping them in an `HtmlString`
  - switch from `string.Format()` to `AppendHtml()` in `LinkTagHelper`
  - simplify `RazorPage` and `TagHelperContentExtensions` e.g. don't use a `TagHelperContentWrapperTextWriter`
  - add some special cases in `UrlResolutionTagHelper`
- add `TagBuilder` and `StringHtmlContent` special cases to avoid `StringWriter` use when value is an `HtmlString`
- move `HtmlTextWriter` optimizations a bit lower and add missing checks for that type

nits:
- correct comments that incorrectly mention `HtmlString`s
- update comments in `JavaScriptStringArrayEncoder`
2015-12-03 15:37:44 -08:00
Pavel Krymets 046dcefd14 Add extensibility point to Razor compilation 2015-12-03 12:04:07 -08:00
Doug Bunting 42f3e764b0 Move logic from `HtmlLocalizer` to `LocalizedHtmlString`
- part of #3123 (4 of 5)
- `LocalizedHtmlString` should not subclass `HtmlString`; now implements `IHtmlContent`

nits:
- clean up a few doc comments
- remove duplicate tests reported while testing these fixes in VS
2015-12-02 18:39:37 -08:00
Ryan Nowak 9fc3a80056 Remove IActionContextAccessor from UrlHelper
This change removes the IActionContextAccessor as a dependency of
UrlHelper, and shifts UrlHelper to use a factory pattern. Consumers of
IUrlHelper should create an instance using the factory when needed.

This is the last part of MVC that has a dependency on IActionContext
accessor. As part of this change we no longer register it by default, and
treat it as an optional component.
2015-12-02 17:09:43 -08:00
Brennan 3062eea7d0 Dispose FileWatcher, MvcRazorHost, and ChunkTree 2015-12-02 13:07:45 -08:00
Pranav K a424e3e278 React to namespace rename part 3 2015-12-02 11:56:38 -08:00
Pranav K 7e2eb16960 React to Microsoft.AspNet.Html namespace rename 2015-12-02 11:15:54 -08:00
Ryan Nowak 07085ca69b Remove IHttpContextAccessor from TempData
This change removes the dependency of TempData on the IHttpContextAccessor
by creating an ITempDataDictionaryFactory abstraction. In general, no one
will replace the factory, it's just indirection.

This allows us to drop our dependency on IHttpContextAccessor, and move it
to the functional tests where we specifically depend on it.

The bulk of code churn here is to update tests that use TempData.
2015-12-02 08:18:57 -08:00
Pranav K 70bdb6eb3e Removing CopyTo from RazorTextWriter 2015-12-01 12:37:11 -08:00