Commit Graph

3 Commits

Author SHA1 Message Date
Ryan Nowak 2ff8f45193
Optimize namespace comparisons (#17119)
Fixes: #16922

Improves the performance significantly by avoiding allocations for the
purpose of comparing the namespace.
2019-11-15 14:41:33 -08:00
Ryan Nowak a159473c57
Use operations in our analyzers that need symbols (#17001)
Fixes: #16922

This change updates our analyzers that need access to the symbols to use
`IOperation` where possible. Using syntax analysis for this kind of
analyzer has worse performance. These analyzers run on generated code,
which can include EF migrations, the design of which amplifies these
effects.

On the path to this, I also added support for a few more cases that
operations make easy. Since we're doing this anyway, I want to have
confidence that we're checking everything (within reason). In some cases
the diagnostic experience changed a bit (including more of the
declaration/code) - I felt like all of these were OK changes. Given the
kinds of error message reported by the analyzers "don't use that type"
it seems like it's still a good enough experience without
micro-optimizing all of the locations.
2019-11-12 17:48:12 -08:00
Adrian Wright c74e9efd0e Fix spelling and grammar in Components (#14137) 2019-09-19 10:11:28 -07:00