288da1a405
RedirectToPage(page, handler) does not work ( #6503 )
...
Fixes #6436
2017-07-06 14:12:57 -07:00
a15c2afe85
React to auth
2017-07-06 13:42:05 -07:00
b9541be20d
React to ISession cancellation changes
2017-07-05 14:34:48 -07:00
8963b83dd3
Remove ParseOptions and CompilationOptions from RazorViewEngineOptions ( #6487 )
...
* Remove ParseOptions and CompilationOptions from RazorViewEngineOptions
Fixes #6009
2017-07-05 14:18:49 -07:00
1eb7f9e032
Add CookieBuilder to CookieTempDataProviderOptions and obsolete duplicate API ( #6472 )
2017-07-05 10:19:13 -07:00
8d9c16132a
Fix #6479 - remove IFileProvider constructor
...
The RazorProject implementation used by MVC at runtime has a constructor
that takes an IFileProvider (used by tests). This causes ambiguities
when a user registers an IFileProvider in DI.
Cleaning up tests to use a mock instead of the file provider directly
2017-07-04 13:48:56 -07:00
a23307e2b1
Check for properties that can't befound
...
If you give ModelExpressionProvider a lambda with a private property
you'll end up here. This wasn't common before, but it seems like users
are more likely to try it with pages.
Model Metadata and Model Binding don't handle private properties, so
supporting it in Model Expressions seems less than useful.
This isn't a breaking change because this case would have resulted in a
null-ref. Addresses #6400
2017-07-04 13:26:17 -07:00
c351712419
Add `FloatingPointTypeModelBinderProvider` and related binders
...
- #5502
- support thousands separators for `decimal`, `double` and `float`
- add tests demonstrating `SimpleTypeModelBinder` does not support thousands separators for numeric types
- add tests demonstrating use of commas (not thousands separators) with `enum` values
2017-07-03 17:55:04 -07:00
c50f55d1de
Add a default sliding expiration of 30 seconds on Memory and Distributed Cache Tag Helpers.
2017-07-03 17:06:47 -07:00
13e76c24d3
Dispose CancellationTokenSource created in CacheTagHelper ( #6293 )
...
Fixes #5649
2017-07-03 14:59:48 -07:00
728b96344d
[ Fixes #6274 ] Fix and re-enable skiped test
2017-07-03 13:00:38 -07:00
eeee3ef731
Add SignOut overload + Use new auth api ( #6476 )
2017-07-03 12:32:11 -07:00
d917504c14
[ Fixes #6468 ] Clean up the productionized testing infrastructure
2017-07-03 10:15:06 -07:00
7c5a16c105
Add RemoveType methods of PageConventionCollection
2017-06-30 16:27:51 -07:00
948982ebff
Create custom collection for model binder providers
...
Fixes #6161
2017-06-30 15:44:07 -07:00
bc86ea4e47
Move convention extensions from RazorPagesOptions to PageConventionCollectionsExtensions
...
Fixes #6462
2017-06-30 14:25:10 -07:00
f76a390a4e
Fall back to linear search for prefix matches
...
- #6469
2017-06-30 10:59:07 -07:00
293ac81fe1
Use ordinal comparisons in `ExpressionTextCache`
...
- #6349
- C# field and property names are case-sensitive
- it's not important (where this cache is used) that HTML field names are case-insenstive
2017-06-29 14:59:06 -07:00
17f6b17a6d
Add RequestSizeLimitAttribute ( #6453 )
...
Addresses #6352
2017-06-29 13:04:27 -07:00
579aca0121
Define semantics for pagemodels
...
Fixes #6210
Now a pagemodel requires a [PageModel] somewhere in it's hierarchy. We
don't do a guess at whether or not your model class is a PageModel.
2017-06-29 09:24:57 -07:00
a90f4118ad
Do not include type names in `ModelState` error messages
...
- #6076
- add resources and accessors specifically for the element / parameter cases
- avoid `metadata.GetDisplayName()` where possible
- fill in the `ValidationContext` that `ValidatorObjectAdapter` uses
- e.g. `Validate_NestedComplexType_IValidatableObject_Invalid()` test fails without this
Possible future work:
- improve error message used for `ModelMetadata.IsRequired` elements and parameters
- use something besides the type for `ValidationContext.DisplayName` of elements and parameters
nits:
- trailing whitespace
- use more `out var`
2017-06-28 15:16:23 -07:00
8df3032540
Add support for specifying filters on page models.
...
Fixes #6334
2017-06-28 14:43:02 -07:00
7166dfecd7
Add generic overloads on FilterCollection
2017-06-28 09:03:48 -07:00
1886d53d89
Remove [BindProperty] on class
...
This isn't a good fit with consistency with controllers. Discussed with
@DamianEdwards and we agreed to remove this for now and bring it back in
the future if there's a real need for it.
2017-06-28 08:18:42 -07:00
12ea28af5c
React to API change in HttpAbstractions
2017-06-27 17:33:46 -07:00
9acfc8d221
Watch _ViewImports outside the pages root for changes
...
Fixes #6428
2017-06-27 09:30:07 -07:00
d1813a7cd7
Normalize paths returned by view location expanders
...
Fixes #6448
2017-06-27 08:48:07 -07:00
0ad9c7d4eb
Making Pages Binding Consistent
...
This changeset reckonciles the binding work we did for pages with
controllers.
A quick summary:
- Moves [BindProperty] to the MVC namespace (#6401 )
- Makes [FromRoute] and friends behave consistently (#6402 )
- Makes [BindProperty] work with controllers (untracked)
2017-06-26 18:11:44 -07:00
cf09af52eb
Remove duplicate type
2017-06-26 16:32:51 -07:00
4e004c22ba
React to options
2017-06-26 15:49:23 -07:00
f4a86f5511
Add DiagnosticSource to RazorView ( #6386 )
...
Addresses #6222
2017-06-26 15:35:31 -07:00
e5da44a82f
Generate full pdbs for views on desktop and re-enable runtime error tests ( #6442 )
...
* Generate full pdbs for views on desktop and re-enable runtime error tests
StackTraceHelper \ PortablePdbReader used by Diagnostics is only useful for
reading portable pdbs on disk. However pdbs produced by views are entirely
in memory and therefore cannot be read. Consequently
we choose to generate full pdbs for views on Windows (when possible).
2017-06-26 10:46:12 -07:00
052db40567
Fix documentation and target files issues
2017-06-23 19:09:45 -07:00
35152d5933
[ Fixes #6233 ] Productionize and harden our functional testing infrastructure
2017-06-23 18:12:41 -07:00
aa5a348385
_ViewStart.cshtml not picked up when added to the root of the app
...
Fixes #6308
2017-06-23 08:25:58 -07:00
0dfffd45c2
RazorPages page directives missing quotes should alert user
...
Fixes #5868
2017-06-22 15:13:38 -07:00
9d138affa2
Suppress JsonPatchDocument validation ( #6429 )
...
Addresses aspnet/JsonPatch#80
2017-06-22 14:14:11 -07:00
53fb676069
React to new page directive expectations.
...
- This will be reverted once https://github.com/aspnet/Razor/issues/1448 has been completed.
2017-06-20 12:53:23 -07:00
c89f0a1e43
Allow AddPageRoute to route to pages root. ( #6412 )
...
* Allow AddPageRoute to route to pages root.
Fixes #6338
2017-06-20 12:33:33 -07:00
3fc3d8d060
Merge branch 'rel/2.0.0-preview2' into dev-gate
2017-06-15 03:48:49 -07:00
0c6460ab64
Changed WebApiCompatShim projects to use PackageTargetFallback
2017-06-14 16:08:04 -07:00
8832014516
PackageTarget->AssetTarget
2017-06-14 15:03:43 -07:00
dfe04bc917
Fix #5979 - Remove hardcoding of tempdata for pages
2017-06-12 15:05:36 -07:00
6961cf9211
Cleanup unused precompilation code
2017-06-09 16:45:43 -07:00
b1b7252ddc
Merge pull request #6383 from aspnet/rel/2.0.0-preview2
...
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 15:11:23 -07:00
d92d8cddeb
Modify ControllerBase.RedirectToPageResult to call the correct overload
2017-06-09 14:40:29 -07:00
a5f3a6425e
Remove TaskCache and TaskCacheOfT
2017-06-08 08:19:20 -07:00
8662422e18
Merge pull request #6376 from aspnet/rel/2.0.0-preview2
...
Perform case insensitive lookups for precompiled views
2017-06-07 15:19:42 -07:00
1124eb5016
Perform case insensitive lookups for precompiled views
2017-06-07 15:19:21 -07:00
8f883e8e13
Use RazorViewAttribute \ RazorPageAttribute for view discovery
2017-06-07 13:49:24 -07:00
4bf20035e4
Merge remote-tracking branch 'origin/rel/2.0.0-preview2' into dev
2017-06-07 13:48:27 -07:00
2845e9b7d4
Add configuration package reference because Logging dropped it ( #6375 )
2017-06-07 13:47:39 -07:00
945661ad0e
Remove unused test sample project ( #6368 )
2017-06-06 15:56:31 -07:00
e51d3c262c
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 13:13:11 -07:00
3448b6a74e
Re-enable net461 functional tests.
...
aspnet/Coherence-Signed#540
2017-06-06 13:10:29 -07:00
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
f1dd475eae
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 09:35:33 -07:00
af91b58bd3
Enabled a way to buffer request body in formatters
2017-06-06 09:33:32 -07:00
628dfc39c1
Remove model type from RazorPageAttribute
2017-06-05 16:07:14 -07:00
20c04d099e
Update to use Razor parser to parse page directive
2017-06-05 14:02:24 -07:00
b796bc0f39
Add Page filters
2017-06-05 08:05:49 -07:00
06ca0d1e9c
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-02 12:29:33 -07:00
dbd340a5e0
Fix test
2017-06-02 12:28:56 -07:00
03e696a05e
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-01 15:19:13 -07:00
0f0cfdfe94
Removed unnecessary package references
2017-06-01 12:02:05 -07:00
a0d9b08f58
Set Content-Length and increase BufferSize ( #6347 )
...
Addresses #6045
2017-06-01 11:27:49 -07:00
597a0c9a11
Add support for friendly routes in pages
...
FIxes #6325
2017-05-26 14:29:00 -07:00
688e518991
Add result filters to pages
2017-05-26 12:33:46 -07:00
84e007a2a7
Move exception and result filters in base
2017-05-26 12:33:46 -07:00
e7bd6cfc06
Refactor invoker tests for reuse
2017-05-26 12:33:46 -07:00
b7db6dbc8e
Remove pass-through activator for pages
...
This change removes a 'pass through' IRazorPageActivator that we were
using to avoid the default one initializing the Page twice.
The fix is to add an adapter so that the IRazorPage that the RazorView has
isn't the *real* page, it's the adapter. The adapter doesn't have anything
interesting to activate :).
2017-05-26 12:29:10 -07:00
c3f7613725
Make RazorReferenceManage public
...
Fix for #4938 . This change makes the reference manager public and
documented so that it can be replaced.
2017-05-26 10:58:45 -07:00
ad6b029443
Temporarily disable MVC functional tests on net461
2017-05-25 21:10:01 -07:00
4c2d727e38
React to Auth + switch to Policy Evaluator
2017-05-25 18:23:41 -07:00
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
452578e4a8
Revisit the architecture of CompilerCache
...
Fixes #5912
2017-05-25 08:54:15 -07:00
c1dd95be2a
Add a test for #6294
...
This case was fixed by 2992f8e
2017-05-24 16:53:30 -07:00
2992f8e38a
Separate PageContext and ViewContext
...
This change decouples PageContext and ViewContext completely.
2017-05-24 16:01:52 -07:00
a6d97d35e3
Add back support for AddTagHelpersAsServices
...
This doesn't go through the Razor tag helper discovery pipeline because
this can really only ever work for ITagHelper based taghelpers. So
there's really no point in reusing that logic, which would be hard
anyway.
2017-05-23 14:04:42 -07:00
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
3c7a2dc847
Revert "Temporarily skipping error page middleware test"
...
This reverts commit d916cfeadd
2017-05-23 13:23:52 -07:00
e681c23d5c
Add ITagHelperComponentManager ( #6302 )
...
Addresses #6282
2017-05-23 13:22:15 -07:00
04f74edd85
Revert "Disable building and testing FSharpWebSite to unblock the mirror when using latest CLI"
...
This reverts commit b28002a9e5
2017-05-23 13:20:36 -07:00
39f1f5c933
Move Pages filter creation to application model provider
...
Fixes #6198
2017-05-23 11:03:19 -07:00
083f55e337
Delete pranav's test logs :)
2017-05-22 17:38:27 -07:00
c5f771d96d
Use factory pattern for caching in ControllerActionInvoker
2017-05-22 13:05:55 -07:00
9d38e2523c
Add methods to TagBuilder ( #6287 )
...
Addresses #5689
2017-05-19 12:23:16 -07:00
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
c8614e9aa8
Fix build break due to Razor changes
2017-05-18 10:58:43 -07:00
51c142ae91
Modify GetProperties overload ( #6276 )
...
Addresses https://github.com/aspnet/Common/issues/219
2017-05-16 13:34:14 -07:00
5662717983
Add null check in WriteLiteral
2017-05-15 15:08:50 -07:00
d70bfdd1ea
Upgrade test framework versions and fix test issues
2017-05-15 14:11:27 -07:00
b28002a9e5
Disable building and testing FSharpWebSite to unblock the mirror when using latest CLI
2017-05-13 19:32:51 -07:00
cf4742735d
Fix Build Break
2017-05-12 20:06:51 -07:00
b2d95ffb21
Remove usage of NotFoundProjectItem
...
We're making this type internal in Razor, using a mock here is fine.
Also renamed some types with a generic name. The actual 'default'
RazorProject class lives in Razor and is internal.
2017-05-12 15:55:36 -07:00
8f52507e9d
Fix build break
2017-05-12 15:53:49 -07:00
d916cfeadd
Temporarily skipping error page middleware test
2017-05-12 14:39:19 -07:00
b758a86a38
Modify ViewComponent_CannotFindComponent error message ( #6263 )
2017-05-12 14:15:29 -07:00
5eabae55cb
Added PushWriter and PopWriter to RazorPageBase
...
- Removed WriteXYZTo methods
2017-05-11 15:21:42 -07:00
08965550ad
Re-enable error page runtime test.
...
- This was previously broken due to the shared framework not being able to find the file responsible for an exception.
#6120
2017-05-10 14:33:10 -07:00
cf64b335f6
Remove unnecessary package references ( #6252 )
2017-05-10 12:06:10 -07:00
014a786b45
Replace IModelBindingMessageProvider with new highly-virtual base class ( #6241 )
...
Replace IModelBindingMessageProvider with new highly-virtual base class. Fixes #6069
2017-05-10 16:02:18 +01:00
debc3dd433
Functional test to show FSharpAsync works end-to-end ( #6240 )
2017-05-08 19:30:01 +01:00
3164046233
Merge branch 'rel/2.0.0-preview1' into dev
2017-05-05 20:00:12 -07:00
f0a26a7f08
Migration2
2017-05-05 19:59:45 -07:00
e2cb8e8ac8
A new and exciting implementation of action selection
...
This is an improved implementation of the ActionSelector for conventional
routing. This will do fewer dictionary lookups than the decision tree, and
will avoid OrdinalIgnoreCase hashing in the common case.
2017-05-05 17:54:09 -07:00
87bb1d0ff5
Refactor GenerateCheckBox ( #6229 )
...
Addresses #5981 and #5983
2017-05-05 11:53:53 -07:00
a80594d706
Add FSharpWebSite plus simple functional test against it ( #6231 )
2017-05-05 19:08:36 +01:00
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
525a479660
Fixing ExcludeBindingMetadataProvider unit test ( #6113 )
...
Fixes #6110
2017-04-27 11:42:06 -07:00
8bece90c83
Fix asp-page-handler to generate form tags correctly.
...
- Prior to this change using asp-page-handler on its own did not create correct `<form>` elements. There were multiple issues, one as that the `FormTagHelper` would purposefully drop into a no-op code path. Second is the `DefaultHtmlGenerator` didn't call through to the `UrlHelper` correctly.
- Added functional test cases to validate asp-page-handler can live on its own on a form tag. This also included adding a variant where method="post".
- Added a `FormTagHelper` unit test to validate the `PageHandler` property is consumed properly.
#6208
2017-04-27 10:32:04 -07:00
b1b3a816cc
Rename View() to Page()
...
This requires us to introduce another base class between RazorPageBase and
Page - you need this because you aren't allow to have Page.Page().
2017-04-27 09:27:14 -07:00
f165914b40
Update how `FormTagHelper` handles `get` method attributes.
...
- Added functional test to verify `asp-*` attributes on form taghelpers work as expected.
- Added a unit test to validate `FormTagHelper` behaves as expected.
- Moved `Method == "get"` checks into appropriate code paths. These include the one where a user specifies an empty or non-existent `action` attribute and where a user doesn't utilize any `asp-*` attributes. In the later, we default `Method` to `"get"` if it's not provided.
#6006
2017-04-25 15:17:15 -07:00
ce4e94c1ac
Use Bundled NETStandard.Library \ NETCoreApp versions instead of explicitly specifying one
2017-04-25 12:50:48 -07:00
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
ef0333ac6a
Add Antiforgery to the FormTagHelper pre-check for processing.
...
- Added a test case to the HtmlGeneration functional test (the one verifying complex FormTagHelpers).
- Added unit test verifying antiforgery behavior when it's the only provided parameter.
#6006
2017-04-24 21:46:54 -07:00
5c8a161ace
Change `FormTagHelper` to apply to all form tags.
...
- Added functional test to validate that non-attributed form tags have an antiforgery input generated. Re-generated baseline to reflect changes.
- Added a unit test to validate that parameterless `FormTagHelper`s behave as expected.
#6006
2017-04-24 18:39:01 -07:00
ccdaa5a729
Make /Pages the default root for pages.
...
Fixes #6184
2017-04-24 15:46:32 -07:00
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
cacee2a837
Break fix: Undo part of 141b637
...
- affected test using a test factory for `HttpResponseStreamWriter`s
2017-04-23 21:48:42 -07:00
141b637d20
Bump `MemoryPoolHttpResponseStreamWriter` buffer size up to 16K `char`s
...
- #3516
- fix tests that relied on otherwise-unused `HttpResponseStreamWriter.DefaultBufferSize`
2017-04-23 16:15:58 -07:00
68866f8716
Added functional tests for JsonPatch
2017-04-23 09:09:08 -07:00
ca017eced2
Add page to AnchorTagHelper and FormTagHelper
...
Fixes #6088
2017-04-21 18:12:54 -07:00
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
297196baa0
Design updates to handler methods and binding
...
Implements #6091 , #6072 , #6090 , #5927
2017-04-21 17:29:25 -07:00
908b4c8d62
FormAction from QueryString
2017-04-21 15:04:37 -07:00
8eac7c2d6c
[ Fixes #6117 ] Added RedirectToPage overloads to Controller
2017-04-21 12:19:35 -07:00
83faaebdb6
Upgrade Roslyn dependency to 2.0.0.
...
- Added C# 7 unit and functional test to validate features work end-to-end.
#6149
2017-04-21 11:41:31 -07:00
025870e8b9
Fix #6159 - Fix deep copy for ControllerModel and ActionModel
2017-04-21 07:41:14 -07:00
5a184df808
Remove Binder from Page and PageModel
2017-04-20 17:54:50 -07:00
f4d84f50cd
Upgrading Moq to 4.7.1
2017-04-20 17:07:50 -07:00
681b798a2e
RedirectToPage doesn't trim /Index from URL
...
Fixes #6080
2017-04-20 11:15:45 -07:00
a975d7fa01
react to removal of PlatformAbstractions ( #6164 )
2017-04-20 11:09:18 -07:00
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
3e8cd1e7c9
MVC => Auth 2.0
2017-04-19 11:57:04 -07:00
a8eb5bee70
Implement view search for pages
...
The View Engine now needs to know about pages :(. This isn't ideal but the
view engine needs to know what set of search paths to use. This was
already hardcoded for controllers vs controllers + areas. It felt right to
further hardcode instead of introduce a wierd abstraction that we only
use.
Additionally pages use a view location expander to implement an ascending
directory search.
2017-04-18 16:11:24 -07:00
c56b64fc41
Add factory methods
2017-04-17 16:11:34 -07:00
8ed55107e7
Add support for page precompilation
2017-04-17 10:43:50 -07:00
e766a259ed
Revert "Skip test `AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet`"
...
This reverts commit c69e48f06b
2017-04-14 18:41:31 -07:00
49628bca2e
Use case invariant lookups for DependencyModel to workaround CLI version differences
2017-04-14 17:03:20 -07:00
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
c69e48f06b
Skip test `AssemblyPartTest.GetReferencePaths_ReturnsReferencesFromDependencyContext_IfPreserveCompilationContextIsSet`
...
- Workaround for "Can not find compilation library location for package" (https://github.com/dotnet/cli/issues/6318 )
2017-04-14 15:37:54 -07:00
ed3aa4d918
Adding functional tests for @namespace
2017-04-14 14:47:29 -07:00
3eae7cc393
Add AggregateExceptionTest ( #6135 )
...
Test for aspnet/Common#215
2017-04-14 14:20:31 -07:00
d8a95c731b
Move RazorViewEngineOptionsSetup to internal namespace ( #6125 )
...
Addresses #6116
2017-04-13 13:35:35 -07:00
c8a1bb6914
React to deps file casing change
...
Fixes #6122
2017-04-13 13:09:00 -07:00
dfbf6d43ff
Temporarily skipping ReferenceAssemblies_ReturnsLoadableReferenceAssemblies
2017-04-12 14:31:21 -07:00
3474bdf776
RedirectToPage from a form-action handler includes the formaction
...
Fixes #6104
2017-04-12 09:27:08 -07:00
106b34867d
Temporarily skipping ErrorPageMiddleware functional test to unblock mirror
2017-04-11 17:40:01 -07:00
59a3aade9b
Fix [TempData] for PageModel's
2017-04-11 16:45:44 -07:00
1a8ac88da7
Add PreserveMethod ( #6075 )
...
Addresses #5609
2017-04-10 17:31:59 -07:00
36e272fdc2
React to Microsoft.AspNetCore.Razor.Evolution => Microsoft.AspNetCore.Razor.Language.
...
aspnet/Razor#1169
2017-04-10 10:20:19 -07:00
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
1e7972bd8f
Add convenience methods for redirecting from a Razor Page back to itself
...
Fuxes #5953
2017-04-07 10:03:42 -07:00
4032de064e
Removing _PageStart.cshtml
...
Pages now also use _ViewStart.cshtml
Also contains some naming/text cleanup that was missed in the previous
commit.
2017-04-06 08:14:37 -07:00
c6e4609096
Getting rid of _PageImports
...
Pages will just use _ViewImports.
2017-04-06 08:14:37 -07:00
9e8d4db7d8
Move TempDataPropertyProvider into filter
2017-04-05 12:04:02 -07:00
3424e20c67
Re-enable skipped test
2017-04-04 19:25:50 -07:00
925ad75cdf
Add convenience methods for redirecting to another Razor Page
...
Fixes #5956
2017-04-04 14:36:22 -07:00
2d19a82678
Update more resource designer files
2017-04-04 13:54:20 -07:00
e5ccac8bf6
Add functional tests for RazorPage routes
2017-04-04 11:14:52 -07:00
3ab9feca3a
Temporarily skipping failing test
2017-04-03 23:24:09 -07:00
19cb15be54
Revert "Skipping model validation tests temporarily to unblock mirror"
...
This reverts commit e25bfa8919
2017-04-03 17:13:49 -07:00
d37b1548f8
Update to new resx format
2017-04-03 16:37:22 -07:00
fe3d45fad1
Adding AllowAnonymousToPage & AllowAnonymousToFolder
...
Fixes #5884
2017-03-31 20:17:31 -07:00
2cabd589ac
Add more `ExpressionHelper` tests
...
- #5792
2017-03-31 15:22:29 -07:00
e25bfa8919
Skipping model validation tests temporarily to unblock mirror
...
- A fix was already checked in f3d0e4d0dd
2017-03-31 12:38:10 -07:00
951341f612
Add a comment for our cool workaround
2017-03-31 11:19:22 -07:00
7904c7756d
Add a simple action selection benchmark
2017-03-31 11:19:22 -07:00
7d4ccd9c58
Add benchmark project and boilerplate
2017-03-31 11:19:22 -07:00
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
c47825944d
Remove Microsoft.AspNetCore.Mvc.Razor.Host
2017-03-29 16:50:39 -07:00
5fca8da665
React to razor changes
2017-03-29 16:45:37 -07:00
1672820e4e
Add functional test covering an `IList<T>` property
...
- #5656
2017-03-29 12:32:06 -07:00
eda5028cf4
Add TagHelperComponentTagHelper
...
Addresses #5728
2017-03-29 11:29:24 -07:00
c18f0780c1
[ Fixes #5413 ] JsonOutputFormatter adds all closing brackets when exceptions are thrown
2017-03-28 23:09:18 -07:00
b22326323a
Add properties to Page and PageModel
...
Fixes #6008
2017-03-28 13:26:38 -07:00
58317b18ce
Fixing NRE when CacheTagHelper throws and exception ( #5989 )
...
Fixes #5988
2017-03-27 12:45:22 -07:00
575fe68b2b
Order enum values by DisplayAttribute.Order
...
Fixes #4297
2017-03-27 12:22:35 -07:00
824d65ca3d
Remove `ValueProviderResultExtensions`
...
- #5063
- update tests that used one extension method to instead use `ModelBindingHelper` directly
nit: `mbc` -> `context`
2017-03-24 22:17:34 -07:00
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
f3ee4064a2
React to Razor changes
2017-03-22 19:58:46 -07:00
705c36921a
Use alternate workaround for #6005
2017-03-22 19:14:46 -07:00
18785dbed6
Add System.Reflection.TypeExtensions to fix net46 tests
2017-03-22 06:33:04 -07:00
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
66deaf0b3f
Make test of @page/@model whitespace
2017-03-20 10:36:58 -07:00
e6cb639cc0
Add handler functional test
2017-03-20 10:05:29 -07:00
270f66198f
Remove Razor from projects
2017-03-17 15:00:39 -07:00
1fdc5132cb
React to TagHelper descriptors api cleanup
2017-03-17 10:51:02 -07:00
1197657e5b
TempData property attribute
...
Addresses #5600
2017-03-16 16:34:35 -07:00
ce28117b8b
Normalize line endings in RazorEngine tests
2017-03-16 15:51:10 -07:00
74889c8f99
Modified MvcRazorHost tests to use new Razor
2017-03-16 11:13:42 -07:00
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
bee1a55cff
Use RazorPagesOptions.RootDirectory when looking for page hierarchies.
...
Fixes #5915
2017-03-14 18:56:50 -07:00
de25357c28
Do not throw if a library does not have a runtime component
...
Fixes #5690
2017-03-14 15:07:50 -07:00
82d87df166
Fix warning as error
2017-03-14 12:44:57 -07:00
2ffaa88830
Using NullLogger types from Logging.Abstractions
2017-03-14 12:24:18 -07:00
365ae19c8b
Add InvalidTagHelperIndexerAssignment to RazorPageBase
2017-03-14 10:04:15 -07:00
e44d875df4
Adding AuthorizePage & AuthorizeFolder without requiring a policy
...
Refactoring
2017-03-13 16:39:52 -07:00
f7fd5114b3
Introduce MvcRazorTemplateEngine
2017-03-13 16:33:13 -07:00
4faef7afaf
Cache more things in HandlerMethodDescriptor
...
Add tests for DefaultPageHandlerMethodSelector
2017-03-13 13:15:26 -07:00
7b53ba1f6b
Reacting to https://github.com/aspnet/Razor/issues/1063
2017-03-13 09:46:36 -07:00
cd9899363f
React to new ctor for TagHelperContext
...
Razor issue: aspnet/Razor#1065
Razor PR: aspnet/Razor#1066
2017-03-10 13:45:14 -08:00
1c74e31715
Add tests for PageActionInvokerProvider ( #5882 )
2017-03-09 16:19:20 -08:00
7f3f6957be
Set path in DefaultPageFactory ( #5911 )
2017-03-09 16:15:43 -08:00
015dafc25f
[Feature] String should be an acceptable value for a checkbox if it can be parsed as a boolean ( #5845 )
...
- `string` should be an acceptable value for a checkbox if it can be parsed as a `bool`
- `throw` with different resources when `ModelType` isn't `bool` or `string` and when `string` value is not acceptable
2017-03-08 14:22:28 -08:00
d9d280d1ef
Make CookieTempDataProvider the default ITempDataProvider ( #5892 )
2017-03-07 16:04:47 -08:00
4a20c849cb
Add functional test for Page.View() ( #5896 )
2017-03-06 16:19:41 -08:00
5c96a7cdef
Use an alternate workaround for #5873
...
- use specific workaround for Microsoft/vstest#428
- generating an executable for a test project is a bit too weird
- also work around dotnet/sdk#926
- generating an executable covered this as well
nit: add and update comments about other workarounds in the functional tests project
2017-03-06 14:05:21 -08:00
3fe0b569d6
Fix tests on Windows with `core.autocrlf=input`
...
- #5907
2017-03-06 13:59:06 -08:00
145d27f9b3
Add a PagesOption type that allows configuring the root for Page file discovery
...
Fixes #5785
2017-03-03 17:20:07 -08:00
85e28ae478
Trim quotes from template ( #5838 )
2017-03-03 09:52:36 -08:00
7cadb58e12
Add convenience extension methods for IPageApplicationModelConvention
2017-03-02 17:38:04 -08:00
9b3b3e91bd
Re-enable functional tests on full .NET Framework
...
- #5873
- creating an EXE for the test project seems to work around #5873
- also avoids dotnet/sdk#926 when building in Visual Studio
nit: clean up duplicate test data
2017-03-01 23:08:46 -08:00
f7c2e5bffc
[ Fixes #5844 ] Using ExtensionIRNode for Inject directive
2017-03-01 09:45:47 -08:00
acfad83aa6
Migrate to MSBuild
...
- thanx to @NTaylorMullen for initial conversion
- e.g. AssemblyInfo.cs files were already minimized or removed :)
- allow `>=` RC3 CLI's to build and run MVC
- work around several dotnet migration issues; see #5482
- disable full .NET Framework runs of functional tests; see #5873
- remove `Microsoft.DotNet.InternalAbstractions` and `System.Xml.XmlDocument` dependencies
- remove project.json (!!), *.xproj, .notest, and web.config files
Redo earlier changes:
- apply test migration to .NET 4.5.2 in *.csproj world
- see 63507c80097e40#5768
- work around Microsoft/vstest#392
- rename tests to avoid duplicates
- work around Microsoft/vstest#419
- set up created `AppDomain`s with current `ApplicationBase`
2017-02-28 21:20:39 -08:00
de30c5822a
* Cache ExecutorFactory as part of CompiledActionDescriptor
...
* Add tests for ExecutorFactory
2017-02-24 11:56:13 -08:00
498c1c570d
Update error message
...
Update error message based on PR feedback to less C# specific.
2017-02-23 14:21:58 -08:00
9950325269
Update view compilation error message
...
Update view compilation error message for csproj instead of
project.json.
2017-02-23 14:21:58 -08:00
e11e6b3be7
Add TempData property and some functional tests
2017-02-22 08:14:02 -08:00
ed9025cc5b
React to aspnet/Razor#1030 - Enable skipped test
2017-02-21 17:32:44 -08:00
19331f9532
Adding some basic functional tests
...
I ran into a blocking issue where page handlers aren't picked up, so I
fixed it. Logging another issue to follow up with better tests for this.
2017-02-21 16:41:25 -08:00
36e4dbe941
Adding a functional test project for Razor Pages
2017-02-21 08:25:30 -08:00
63507c8da9
Bump test projects up to .NET 4.5.2
...
- aspnet/Testing#248
- xUnit no longer supports .NET 4.5.1
- update AppVeyor config so this framework version is available
- build tests for desktop .NET only on Windows
2017-02-21 07:15:36 -08:00
11d747fc33
React to CSharpTokenIRNode being removed
2017-02-17 19:31:33 -08:00
0f5d5ff3b5
React to aspnet/Razor#1017
2017-02-17 16:01:54 -08:00
927e75870d
Add BindingSourceMetadataProvider
...
Addresses #5673
2017-02-17 13:22:10 -08:00
366dbde378
Add culture constructor to RouteValueProvider
2017-02-16 14:47:34 -08:00
0097e40e46
Downgrade to stable packages
2017-02-15 14:23:48 -08:00
a00acceaa9
Merge branch 'rel/1.1.2' into dev
2017-02-15 12:43:37 -08:00
29647fda33
[ Fixes #5801 ] Move call to validate constructor in ComplexTypeModelBinder into CreateModel
2017-02-15 12:33:01 -08:00
38e1e7d14e
React to aspnet/Razor#996
2017-02-14 15:11:39 -08:00
eb820106e2
Generate the class name from relative path
2017-02-14 09:41:05 -08:00
44048331e9
Make `ViewComponent.View()` overloads respect explicitly passed in model even when `null`
2017-02-13 17:08:48 -08:00
35edc299d7
Fix test failures
...
Fixes #5794
2017-02-13 12:03:10 -08:00
2cdd84f437
Remove pranav's hack
...
This is part 1 of the right fix for the directive getting removed. This
pass has the wrong order, an it should be running sooner before the
directive is processed by the default processor.
2017-02-13 09:23:58 -08:00
af5648c1f7
Merge branch 'rel/1.1.2' into dev
2017-02-13 08:34:18 -08:00
531c11df2a
Fix 5594 - ExceptionHandled + Result is broken
...
This change ensures that setting ExceptionContext.Result will always
execute if set. The problem with 1.1.0 is that when we had a real short
circuit the wrong set of conditions were checked. I suspect that when you
set ExceptionFilter.Result and didn't short circuit that result filters
were also running (which is a bug).
Added a few tests that verify that the result doesn't trigger result
filters.
I did some general cleanup on this code path to make the state transitions
more clear.
No exception was thrown -> BeginResult
Exception was handled -> ExceptionHandled
Exception was not handled -> gets rethrown
2017-02-13 07:58:32 -08:00
a5c7a7e491
Bring tests from fa710e6 (rel/1.0.3) into dev
...
- relates to #5595 which was a 1.0.x-only problem
2017-02-11 13:48:21 -08:00
fc40985412
Merge branch 'rel/1.1.2' into dev
2017-02-10 14:55:32 -08:00
8ee3d45ef1
Do not cache expressions containing method calls
...
- #5655
- also make `ExpressionTextCache` more robust for defence-in-depth
nits:
- two `null` expression nodes are equal
- declare data properties as `TheoryData<T>`
2017-02-10 14:50:09 -08:00
842d661ac2
[ Fixes #5698 ] Regression in 1.1 model binding for model types without default constructor
...
- Also reverts "Check for default constructor in ComplexTypeModelBinderProvider" commit d09e921c4a
2017-02-10 11:10:02 -08:00
bc3a741eee
Use DocumentClassifierPassBase
...
Workaround issue with the model directive disappearing
2017-02-09 20:30:31 -08:00
bd9e431873
Order IgnoreAntiforgeryTokenAttribute and add test ( #5765 )
2017-02-08 09:37:43 -08:00
f474d8bc52
React to optional Razor directive token feature
2017-02-07 21:58:31 -08:00
Pranav K
Hao Kung
Chris R
Nate McMaster
Ryan Nowak
Doug Bunting
Javier Calvarro Nelson
Sébastien Ros
Hao Kung
Henk Mollema
Jass Bagga
Nate McMaster
N. Taylor Mullen
Kiran Challa
Ryan Brandenburg
Pavel Krymets
Ajay Bhargav Baaskaran
Steve Sanderson
John Luo
Christopher Dresel
Andrew Stanton-Nurse
Mike Harder
Hisham Bin Ateya
twirpx
Derek Gray
Nick Chapsas
martincostello