Commit Graph

19231 Commits

Author SHA1 Message Date
Pranav K 48261fdada
Undo use of pipewriter in FileBufferingWriteStream (#21833) 2020-05-14 12:38:49 -07:00
Pranav K 0e652d1aba
Ensure dotnet run uses build output, not publish (#21720)
Fixes https://github.com/dotnet/aspnetcore/issues/17710
2020-05-14 12:38:04 -07:00
Justin Kotalik d99e7fecb0
Merge pull request #21806 from dotnet-maestro-bot/merge/release/5.0-preview5-to-master 2020-05-14 12:14:47 -07:00
Artyom Tarasov 17c90a7e17
Fix for https://github.com/dotnet/aspnetcore/issues/17277 (#21819)
Fixed adding a string with a large number of trailing zeros to StringBuilder, which sometimes caused the thread to hang
2020-05-14 10:47:26 -07:00
dotnet-maestro[bot] b67d161e03
[release/5.0-preview5] Update dependencies from dotnet/aspnetcore-tooling (#21710)
* Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200511.4

- Microsoft.AspNetCore.Mvc.Razor.Extensions: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
- Microsoft.AspNetCore.Razor.Language: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
- Microsoft.CodeAnalysis.Razor: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
- Microsoft.NET.Sdk.Razor: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4

Dependency coherency updates

- Microsoft.Extensions.Caching.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Caching.Memory: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Binder: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.CommandLine: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.EnvironmentVariables: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.FileExtensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Ini: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.UserSecrets: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Xml: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyInjection.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyInjection: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Composite: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Physical: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileSystemGlobbing: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Hosting.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Hosting: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Http: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Configuration: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Console: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Debug: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.EventSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.EventLog: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.TraceSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options.ConfigurationExtensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options.DataAnnotations: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Primitives: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Internal.Transport: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Win32.Registry: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Win32.SystemEvents: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.ComponentModel.Annotations: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Diagnostics.EventLog: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Drawing.Common: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.IO.Pipelines: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Net.Http.WinHttpHandler: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Net.WebSockets.WebSocketProtocol: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Reflection.Metadata: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Runtime.CompilerServices.Unsafe: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Cryptography.Cng: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Cryptography.Pkcs: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Cryptography.Xml: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Permissions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Principal.Windows: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.ServiceProcess.ServiceController: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Text.Encodings.Web: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Text.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Threading.Channels: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Windows.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.App.Internal: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.Platforms: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Net.Compilers.Toolset: 3.7.0-1.20254.1 -> 3.7.0-2.20259.1 (parent: Microsoft.AspNetCore.Razor.Language)

* Try BuildPool.Windows.10.Amd64.VS2019.Pre queues

- do not merge into 'master' branch

* Update RuntimeExtensionsReferenceDirectory with new tfm

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Co-authored-by: John Luo <johluo@microsoft.com>
2020-05-14 01:49:47 +00:00
Brennan db864981d5
Do not ship SiteExtension in previews (#21786)
* Do not ship SiteExtension in previews
  - We've generally avoided shipping the SiteExtension in preview releases.
* fb
2020-05-13 17:51:42 -07:00
Pranav K b3c6c43789
Remove the need for a global lock when building or publishing a project (#21753)
* Change template test build and publish to not perform dotnet restore
* Remove locking requirements for build and publish
* Increase timeout for dotnet new operations since it's network bound
2020-05-13 11:40:42 -07:00
Pranav K 572c6fa4ce
Add retries when initial connection fails (#21711)
* Add retries when initial connection fails
2020-05-13 07:59:34 -07:00
William Godbe 7c58b8b767
Add .version file to shared framework zip (#21587)
* Add .version file to shared framework zip

* Fix test

* Test for proper version file depending on env
2020-05-12 17:10:02 -07:00
N. Taylor Mullen 9a5d3c7640 Quarantine all ProjectTemplate tests until dotnet new lock issue is resolved.
- Investigation pending in https://github.com/dotnet/aspnetcore/issues/21748
2020-05-12 15:31:11 -07:00
N. Taylor Mullen b419ec07d6 Quarantine Microsoft.Extensions.SecretManager.Tools.Tests.SecretManagerTests.Clear_Secrets
- https://dev.azure.com/dnceng/public/_build/results?buildId=640828&view=ms.vss-test-web.build-test-results-tab&runId=19910360&resultId=108857&paneView=debug
2020-05-12 15:29:41 -07:00
David Fowler 5a0c097ad4
Added some kestrel event counters (#21649)
* Added some kestrel event counters
- Connection queue length - This is the amount of connections accepted and queued in the thread pool.
- Connection count - The number of connections
- Total connections - The total number of connections ever connected.
- Connection Rate - Connections per second

* Added TLS counters
- Current TLS handshakes
- Total TLS handshakes
- Failed TLS handshakes
- TLS handshake per second

* Added HTTP/2 queue length counter

* Improve the event information
- Add TLS version to handshake events
- Add HTTP version to request queue events
- Renamed HTTP/2 request queue length to http request queue


Contributes to #4769
2020-05-12 11:04:37 -07:00
John Luo dfb126da17
Quarantine flagged tests (#21723) 2020-05-12 09:00:20 -07:00
Pranav K 4b88074e30
Add a simplified version of ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext (#21633)
ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext is quarantined but since it's not running on Helix there isn't any history available for it. With all the moving
parts in the server test, it's unclear if it's a product vs test setup issue.

Authoring a more simplified test so we can track test history. Note that it's starting off as quarantined because there's no evidence that the product code isn't broken

Fixes https://github.com/dotnet/aspnetcore/issues/19413
2020-05-11 12:54:01 -07:00
Ben Adams a410ed4601
Use Pinned Object Heap for MemoryPool (#21614) 2020-05-09 15:26:35 -07:00
John Luo 81d269d6f3
Merge branch 'master' into merge/release/5.0-preview4-to-master 2020-05-08 14:48:06 -07:00
Pranav K 5d96b5de10
Template test infrastructure fixups (#21558)
* Template test infrastructure fixups

* Add timeouts to process launches and lock acquisitions
* Dispose launched processes
* Remove unused code
2020-05-08 13:27:17 -07:00
Javier Calvarro Nelson a67c14f5b0
[SPA] Fix register/profile paths (#21625) 2020-05-08 13:17:25 -07:00
Pranav K cacabfdaba
Fixups 2020-05-08 11:38:14 -07:00
Pranav K d0677559b7
Template test infrastructure fixups
* Add timeouts to process launches and lock acquisitions
* Dispose launched processes
* Remove unused code
2020-05-08 11:38:13 -07:00
Javier Calvarro Nelson 95a2208530
[Templates] Unquarantine some tests that have been passing for the past month (#21613)
Unquarantine some tests that have been passing for the past month
2020-05-08 09:57:23 -07:00
David Fowler 6aa13dde98
Use a dedicated thread for timers in rather than a Timer (#21490)
* Use a dedicated thread for timers in rather than a Timer
- This make it possible to still timeout various operations when there's thread pool starvation occurring.
- Print heartbeat slow if duration > interval
2020-05-08 01:07:36 -07:00
Javier Calvarro Nelson cdfa43bbe0
Avoid trying to fix the trusted root certificates (#21599) 2020-05-07 18:41:52 -07:00
Christian Wenz 64a0d0396e
Upgrade jQuery in samples to version 3.5.1 (#21577)
Fixes #21572
2020-05-07 14:42:14 -07:00
Andrew J Said b328f501fa
Log type of ObjectResult in ObjectResultExecutor (#21425)
* Log type of ObjectResult in ObjectResultExecutor

* Log only class name of FileResult, ObjectResult types
2020-05-07 12:55:57 -07:00
Pranav K 51f18b5652
Use Encoding.CreateTranscodingStream (#21509)
* Use Encoding.CreateTranscodingStream

Fixes https://github.com/dotnet/aspnetcore/issues/21243
2020-05-06 16:59:39 -07:00
Brennan 5fd4f87977
Avoid crashing in PollingFileWatcher (#21544) 2020-05-06 15:47:50 -07:00
Javier Calvarro Nelson a9d702624a
[Fixes #19666] [Components] Improve reliability of component quarantined tests (take 2) (#21499)
* Tries to increase the reliability of the tests by:
  * Trying to ensure that the server is up and running before connecting.
  * Retrying a connection attempt multiple times.
2020-05-06 10:12:06 -07:00
Doug Bunting fdb0372a67
Upgrade to more recent .NET SDK (#21017)
* Update SDK to preview.5.20251.2
  - includes support for the `net5.0` TFM
  - includes fix for `$(PublishDepsFilePath)`
  - includes fix for incorrect NU5118 warnings when `'$(PackAsTool)' == 'true'`
* !!temporary!! Suppress NU5129 warnings
  - build/ and buildTransitive/ naming conventions do not treat TFMs as equivalent
* Run `InjectRequestHandlerOnPublish` later
  - late enough for .deps file to exist i.e. after the `CopyFilesToPublishDirectory` target
  - `AfterTargets` is a bit flaky; use `BeforeTargets` with empty targets instead
* Always add `@(AssemblyAttribute)` items before they are processed
  - use `BeforeTargets="GetAssemblyAttributes"` for consistently throughout the repo
2020-05-05 21:59:15 -07:00
Brennan c9cdc4891a
Deflake TimeAwaitable finalizer test (#21523) 2020-05-05 19:45:08 -07:00
Javier Calvarro Nelson d6409371ae
[Templates] Diagnostics improvements and certificate fixes (#21493)
* Move template specific helpers out of shared and into templates
* More debug info, fix casing issues
* Keep test skipped
* Undo lock changes
* Standarize retry logic
* Tweak certificate validation code
2020-05-05 19:39:51 -07:00
Brennan 88dbfaa2ab
Set certificate in some Kestrel tests to avoid global machine state (#21516) 2020-05-05 19:18:37 -07:00
Chris Ross 32b2894610
Revert "Handle IIS OnCompleted callbacks later #17268 (#17756)" (#21525)
This reverts commit 11ecc62ea9.
2020-05-05 19:06:54 -07:00
Javier Calvarro Nelson 8be526a11b
[SPA] Updates SPA dependencies to make npm audit happy (#21324)
* Update react dependencies

* Update angular dependencies

* Update react-redux dependencies
2020-05-05 12:17:48 -07:00
Stephen Halter 4ebf695a98
Fix NRE in KestrelServerOptions.Listen*() (#21467)
* Fix NRE in KestrelServerOptions.Listen*()

* Fix tests
2020-05-05 03:04:28 +00:00
Kahbazi a4c45262fb
Add AuthenticationDisplayName to HttpSys (#21410)
* Add AuthenticationDisplayName to HttpSys

* update reference assembly

* Update Microsoft.AspNetCore.Server.HttpSys.netcoreapp.cs

* Trigger build
2020-05-02 09:11:51 -07:00
Ajay Bhargav B 3eb812a3f5
Quarantined dotnet user-secrets test (#21412) 2020-05-01 17:49:48 -07:00
Safia Abdalla 37da482969
Move Blazor Server template tests to new project (#21345) 2020-05-01 11:47:52 -07:00
Stephen Halter 100823af0d
Kestrel reloadable endpoint config (#21072) 2020-04-30 20:42:19 -07:00
Artak 9025f63fc3
Marked the Mono.WebAssembly.Interop package as non-shipping (#21367)
* Marked the Mono.WebAssembly.Interop package as non-shipping
2020-04-30 14:56:59 -07:00
John Luo 2fa0212285
Fix package overrides (#21329)
* Fix package overrides

* Add a test
2020-04-30 13:59:32 -07:00
Julius 63415b7dd2
Jfheins/improve error message (#21295)
* Add test for empty URL

* Throw if URL is empty, adjust test
2020-04-30 12:46:31 -07:00
Safia Abdalla 8271204317
De-quarantine BlazorServerTemplateWorks_IndividualAuth test (#21286) 2020-04-30 12:17:48 -07:00
Stephen Halter 49b4f418d5
Quarantine dotnet-user-secrets InitCommandTests (#21338) 2020-04-29 20:56:43 -07:00
Ben Adams 3af92e29b5
Make connection options parsing "safe" (#21004) 2020-04-29 16:23:56 -07:00
Artak 5d88e3365b
Disable documentation generation for a test project (#21340) 2020-04-29 15:33:36 -07:00
Javier Calvarro Nelson c10fea055c Revert "[Blazor] Unquarantine ComponentHubReliabilityTests (#21319)"
This reverts commit f36adf0805.
2020-04-29 11:09:38 -07:00
Javier Calvarro Nelson f36adf0805
[Blazor] Unquarantine ComponentHubReliabilityTests (#21319)
Fixes #19666
2020-04-29 10:04:26 -07:00
David Fowler 0fbf919d50
Use the RequestContext as the threadpool workitem (#21294)
- Avoids a task allocation (reuses the existing RequestContext allocation)
- Side benefit is that it's easier to see what things are queued into the threadpool for diagnostics!
2020-04-29 00:06:42 -07:00
David Fowler 5c6f97b9ef
Made changes to FileBufferWriteStream (#21223)
* Made changes to FileBufferWriteStream
- Make the internal FileStream write only
- Make a new readable stream over the same file in DrainBufferAsync to copy data to the buffer.
- Added an overload to DrainBufferAsync into a PipeWriter and use this overload in the 2 formatters in MVC. This should reduce the amount of copying from the internal buffer and reduces pinning (since these buffers are already pinned)
- Improved formatter tests
2020-04-28 23:22:39 -07:00