- Changing HtmlHelper and HelperResult to implement IHtmlContent.
- Introducing BufferedHtmlContent.
- Making RazorPage handle only IHtmlContent and clearing out other types.
- Making StringCollectionTextWriter use BufferedHtmlContent so that it can be returned where necessary.
- Updating places which involve Write/Copy to pass in encoders.
- The encoders are currently not being used during write. But when HtmlString is modified to carry encode metadata, the encoder can be used for writing. This is a perf optimization and hence not a part of this change.
- Making TagHelperContent implement IHtmlContent.
This change removes the validation that forces an OutputFormatter to set
an encoding, so that you can use the OutputFormatter base class for
non-text.
The check that we had would pretty much only be hit when you
didn't have any SupportedEncodings. If you have anything in
SupportedEncodings, then one of them will be picked as a default. So
removing the check is to do, because for a text-based formatter you'd
never run into this issue in the first place.
Added the following MIME types which I have found to be missing:
.json - application/json (This one is pretty unbelievable)
.ttc - application/x-font-ttf
.webp - image/webp
.appcache - text/cache-manifest
.manifest - text/cache-manifest
Also the following MIME types need updating:
.ttf should be application/x-font-ttf and not application/octet-stream
- Tested with a page containing 33% of invalid Ids which go through TagBuilder.CreateSanitizedId.
- Ran 10,000 requests with 20 in parallel and measured perf.
- Data before the change:
System.String allocated by CreateSanitizedId: 1.84 mb
System.Text.StringBuilder allocated by CreateSanitizedId: 1.68 mb
- Data after the change:
System.String allocated by CreateSanitizedId: 0.720 mb
System.Text.StringBuilder allocated by CreateSanitizedId: 0.560 mb
Around 60% improvement from the original case.
Hao Kung
tushar gupta
Peter Hsu
Brice Lambson
Ryan Nowak
Steve Smith
markrendle
sornaks
Mugdha Kulkarni
N. Taylor Mullen
Chris R
Troy Dai
Wei Wang
Kiran Challa
unknown
KevinDockx
mikary
RehanSaeed
Arthur Vickers
Stephen Halter
Eilon Lipton
ASP.NET Push Bot
Eilon Lipton
Hisham Abdullah Bin Ateya