3f7ee338d4
Change SelfHostDeployer to use dynamic ports by default ( #1383 )
...
* Should significantly reduce flaky test failures due to AddressInUse exceptions
* Addresses https://github.com/aspnet/Hosting/issues/1296
2018-09-19 12:35:51 -07:00
f70df60435
Move RazorGenerate and RazorTagHelper tasks in to the Sdk
...
Loading multiple versions of a task assembly result results in MSBuild on .NET Core to fail.
Addressing this by moving the tasks in to the Sdk and renaming it. This should avoid
immediate issues for a 2.1 and 2.2 project co-existing and future proofs 2.2 and later.
Fixes https://github.com/aspnet/Razor/issues/2553
2018-09-19 10:09:56 -07:00
7144add4ad
Check for ITagHelper in tag helper feature provider ( #2602 )
...
Fixes #2482
2018-09-18 16:52:34 -07:00
b6c311c14d
Add client disconnect and connection abort support ( #1388 )
2018-09-18 16:36:52 -07:00
f63412f1bb
Update package verions
2018-09-18 14:34:39 -07:00
ece5ad36e2
Implement ITlsConnectionFeature ( #1390 )
2018-09-18 14:22:56 -07:00
fc86cc3ca1
Allow Invoke \ InvokeAsync methods for a ViewComponent to be defined in base types
...
Fixes https://github.com/aspnet/Mvc/issues/8397
2018-09-18 13:38:48 -07:00
47d6d4e82c
Update `FormFileModelBinder` to re-add prefix `ParameterBinder` removed incorrectly
...
- #7562 part 2
- add `OriginalModelName` to `ModelBindingContext`
nit: take VS suggestions, mostly to inline collection initialization in `FormFileModelBinderTest`
2018-09-18 11:44:48 -07:00
c13e2498a8
Create model in `ComplexTypeModelBinder` if ANY property has a greedy binding source
...
- #7562 part 1
2018-09-18 11:44:37 -07:00
f3b6430aab
Initialize Heartbeat in KestrelServer.StartAsync ( #2939 )
...
Fixes #2850 again
2018-09-17 16:43:30 -07:00
a7e412ec80
Fix category logger for HttpsConnectionAdapter and LoggingConnectionAdapter. #2929 ( #2935 )
2018-09-17 16:01:14 -07:00
4a4dde182f
replacing string interpolation with proper logging syntax ( #363 )
2018-09-17 15:33:17 -07:00
b8423b8530
Change how HTTP/2 frames are parsed and generated #2858
2018-09-17 14:48:43 -07:00
2999aa54cd
Remove calls to MemoryMarshal.GetReference ( #2931 )
...
- Spans can be pinned natively in C# 7.3
2018-09-17 14:47:04 -07:00
69ff195f66
Enable hpack/4.2 - Maximum Table Size test
...
- Ensure dynamic tables size updates occur at the beginning of the header block
2018-09-17 12:46:51 -07:00
025aca52df
Port long Huffman encoding bug fix
...
https://github.com/dotnet/corefx/pull/32043
2018-09-17 12:41:36 -07:00
5e896ca506
Implement IHttpBufferingFeature ( #1391 )
2018-09-17 12:04:12 -07:00
2cd6ad6d50
Add windows auth tests for inproc ( #1385 )
2018-09-17 11:57:46 -07:00
060698a52f
Update to use non-capturing timer
2018-09-17 11:08:06 -07:00
4b83f7b510
Make FileVersionProvider repleacable
...
Fixes #6371
2018-09-14 09:14:02 -07:00
233140c33a
Allow IFormFile parameters annotated with [FromForm] to be correctly … ( #8452 )
...
* Allow IFormFile parameters annotated with [FromForm] to be correctly bound in ApiControllers
Fixes #8311
2018-09-14 09:06:32 -07:00
412944e1f5
Transform parameters before lower casing in link generation ( #793 )
2018-09-14 17:19:43 +12:00
48b3f18642
Improve the handshake request parsing errors ( #2953 )
...
- Print out the raw handshake payload as utf8 text if it fails to parse as JSON or if we're missing properties. This should help flesh out potentially buggy clients.
2018-09-13 22:11:17 -07:00
426a48a65a
Performance improvments to LinkGenerator and TemplateBinder
2018-09-13 19:11:28 -07:00
5e083c371b
Don't capture asynclocals onto Timer
2018-09-13 17:28:30 -07:00
35597db277
Fix #8451
...
Change tokens can call into your code IMMEDIATELY when you subscribe. I
reviewed our other usage of ChangeToken.OnChange in MVC and everything
looks good.
2018-09-13 15:38:42 -07:00
9a68f48a5c
Minor improvments to RVD perf
2018-09-13 14:55:00 -07:00
b8f7f967ce
Normalize FSharp templates and don't check in site.min.js
2018-09-13 14:41:32 -07:00
d0ddb068be
Return FormCollection.Empty when Content-Length is 0 ( #1038 )
...
* Return FormCollection.Empty when Content-Length is 0
Fixes https://github.com/aspnet/Mvc/issues/5631
2018-09-13 13:35:31 -07:00
55e5e56422
Dispatch Http/2 write callbacks #2878
2018-09-13 11:53:30 -07:00
3649f5bb81
Add OutOfProc logging tests/ merge all inproc test sites into a single site ( #1384 )
2018-09-12 23:20:52 -07:00
cb88e906b2
Allow ProducesAttribute to apply along with conventions
...
Fixes #8389
2018-09-12 13:58:02 -07:00
a73d073eea
Allow ApiControlelrAttribute to be applied to assemblies
...
Fixes #7343
2018-09-12 13:42:22 -07:00
13281613a5
Refactor DefaultPageApplicationModel to use conventions
2018-09-12 12:28:16 -07:00
b9452868db
Update IdentityServiceCollectionExtensions.cs docs ( #1962 )
2018-09-12 12:04:28 -07:00
43d4416a1d
Fix typos ( #8413 )
2018-09-12 09:34:45 -07:00
dfae9c208a
Add IParameterTransformer support ( #8329 )
2018-09-12 21:46:41 +12:00
cee960f3c5
Add IParameterTransformer ( #750 )
2018-09-12 21:45:25 +12:00
105f8b47a1
Fix endpoint support for area/controller/action in attribute route ( #8447 )
2018-09-12 21:16:50 +12:00
8dffc68cea
Cancel previous request on close ( #2923 ) ( #2942 )
2018-09-11 15:50:00 -07:00
e5cc4564cb
add docs for constructor
2018-09-10 16:55:39 -07:00
5f172efa9d
Add support Endpoint Name endpoint finding
2018-09-10 16:50:46 -07:00
57cc8aea96
Various improvments to route values link APIs
...
- Add docs
- Add support for templates
- Remove undesirable constructor parameter
- misc cleanup
2018-09-10 16:50:46 -07:00
f38f60f8ce
Map ListenOptions.Protocols from IConfiguration #2903
2018-09-10 16:27:51 -07:00
c683844817
Fix #553 - Add logging for new LinkGenerator
...
Adds logging for all of the failure cases of link generation.
2018-09-10 16:11:43 -07:00
6e27a04bf3
No HttpContext to route constraints in MvcEndpointDataSource ( #8436 )
2018-09-11 10:12:09 +12:00
399ac267ca
Cancel previous request on close ( #2923 )
2018-09-10 15:09:05 -07:00
de5ccb5c78
PR feedback for https://github.com/aspnet/KestrelHttpServer/pull/2838
2018-09-10 13:58:46 -07:00
14b1432481
Fix min.css files
2018-09-10 12:25:27 -07:00
adc5706bcb
Add more redis logs ( #2936 )
2018-09-10 11:51:27 -07:00
f573b8840a
Fix aspnet/Routing#782
...
Currently MVC is still running the IActionConstraint implementations for
features that we've already moved into the routing layer. This has a
significant perf cost associated with, and so we want to skip it because
it's redundant. However if anyone has implemented their own
`IActionConstraint`-based features, they still need to just work.
This change takes the approach of skipping the action constraint phase
at runtime unless we see something 'unknown'. This is an all or nothing
choice, and will run action constraints if **any** action constraint we
don't special case exists. This is the most compatible behavior (running
redundant constraints) when the application is using constraints that
the developer implemented.
Another approach I considered was to eliminate these constraints as part
of the process of building ADs. I don't think that's ideal because
people have written code that introspects action constraints. We should
consider something like this in 3.0.
2018-09-09 15:17:05 -07:00
013697ad89
Remove experimental analyzers
2018-09-07 16:03:06 -07:00
4bcfbe4d40
[REPL] Help improvements for repl ( #478 )
...
* Beginning of help additions. Fixed a nullref.
* Standardized help with options displayed as appropriate.
2018-09-07 15:21:42 -07:00
72f7e52e1e
Remove blank line
2018-09-07 14:48:17 -07:00
db99baac35
Don't capture AsyncLocals onto Timers ( #2904 )
2018-09-07 14:08:08 -07:00
d36dcca713
Handle IPv4ToIPv6 Mapped Addresses when checking known proxies/networks ( #359 )
...
* Un-Map IPv4-to-IPv6-Mapped ips before comparing to known proxies/networks. Addresses #358
* Checking both mapped and unmapped versions of IPv4toIPv6 ips. Addresses #358
* Confirm IPv4toIPv6 mapping/unmapping. Addresses #358
2018-09-07 14:02:31 -07:00
aa93edcee2
Remove Microsoft.DotNet.GlobalTools.Sdk
...
These targets are now part of Microsoft.NET.Sdk
2018-09-07 10:01:52 -07:00
fd80509fef
LocalizedHtmlString.Value doesn't include arguments ( #8376 )
...
* Clarify that Value is prior to formatting with any constructor arguments
2018-09-07 08:58:52 -07:00
e3ba165baa
Update build.ps1
2018-09-06 23:04:43 -07:00
74ba9898f4
[ Fixes #8250 ] Improve the error message when TEntryPoint is not in an entry point assembly
...
Validates that the type used as a generic argument in WebApplicaitonFactory is contained within the entry point to assembly and throws InvalidOperationException otherwise
2018-09-06 18:02:21 -07:00
2597a2e009
Merge QueryStatus and CreateHandler calls to make them atomic ( #1359 )
2018-09-06 15:42:18 -07:00
863b1c2c97
Action endpoint metadata contains attributes from action and controller ( #8395 )
2018-09-07 10:01:40 +12:00
2cc108b2e1
Write wide strings to stdout; cleanup logging providers; test utf8 ( #1332 )
2018-09-06 11:57:00 -07:00
d3d7c55198
fix some spelling ( #2888 )
2018-09-06 11:48:25 -07:00
c2f15f4199
Don't use depricated constructor
2018-09-06 11:39:34 -07:00
1fca011674
Fix output location for lib files ( #1373 )
2018-09-06 10:32:49 -07:00
07cc9e66c6
Add a feature to disable file watching in Razor pages ( #8369 )
...
* Add a feature to disable file watching in Razor pages
Fixes https://github.com/aspnet/Mvc/issues/8362
2018-09-06 10:16:31 -07:00
b1f0f173aa
Use ConnectionResetException with 'The client disconnected' message ( #1364 )
2018-09-06 10:10:07 -07:00
b8e56691cb
Implement MaxRequestLineSize for HTTP/2 #2813
2018-09-06 10:01:28 -07:00
384a518bda
Implement MaxRequestHeadersTotalSize for HTTP/2 #2812
2018-09-06 09:07:16 -07:00
edc1935475
Flow the cancellation tokens to ReadAsync and WriteAsync ( #2865 )
2018-09-06 09:04:39 -07:00
cfb0d732b0
fix some spelling ( #1035 )
2018-09-06 08:46:34 -07:00
b156dee4f1
Fix some spelling ( #8378 )
2018-09-06 07:39:01 -07:00
c0f3a46ffe
Don't call GetValidity method twice.
2018-09-06 07:33:48 -07:00
e174d277bd
Inline
2018-09-05 20:53:06 -07:00
337bc462de
Fast-path async in PagedBufferedTextWriter
2018-09-05 20:53:06 -07:00
fabe189470
React to LinkGenerator changes
2018-09-05 20:52:37 -07:00
e3b704095b
Revisions to LinkGenerator ( #770 )
...
* Revisions to LinkGenerator
* PR feedback
2018-09-05 20:52:09 -07:00
dcfb63a768
Avoid RoutePattern allocating empty dictionaries ( #772 )
2018-09-06 14:00:52 +12:00
1c74973c6a
Minor matcher builder allocation optimization ( #771 )
2018-09-06 13:47:34 +12:00
dbebdbecd6
Add flag for including label with DfaNodes ( #769 )
2018-09-06 13:38:17 +12:00
fe8c633224
Optimize builder and HTTP policy allocations ( #768 )
2018-09-06 13:25:35 +12:00
abc378d3dc
Avoid resizing large struct arrays ( #767 )
2018-09-06 13:10:17 +12:00
0f5d471dfd
Create collections on DfaNode as needed ( #779 )
2018-09-06 12:58:57 +12:00
a777a4cdd5
Reuse collections in DfaMatcherBuilder ( #778 )
2018-09-06 12:25:45 +12:00
3a281b8f58
Allow TagHelpers to occur after unclosed C# blocks without assert failures.
...
- This scenario wasn't considered previously.
#2566
2018-09-05 17:22:17 -07:00
71b7bb50b2
Ensure external processes are killed when test process exits ( #1371 )
...
- Prevents locked files when stop debugging unit test
- Addresses #1279
2018-09-05 17:21:59 -07:00
88d8571474
Add Trace level for request events, allow logging to eventlog ( #1337 )
2018-09-05 17:15:04 -07:00
bca3160190
Remove redundant check
...
fixed https://github.com/aspnet/Mvc/issues/8374
2018-09-05 17:04:20 -07:00
18a718d1f0
Catch all exception in native callbacks ( #1369 )
2018-09-05 16:48:10 -07:00
613fbcc349
Enable code analysis on shim project ( #1361 )
2018-09-05 16:47:51 -07:00
e23e8fff95
Install MicroBuild code signing plugin and set SignType = real ( #1376 )
2018-09-05 12:50:34 -07:00
1b87f1e913
Merge branch 'merge/release/2.1-to-release/2.2' into release/2.2
2018-09-04 14:10:35 -07:00
991cfa8bd8
Remove limits on SETTINGS_HEADER_TABLE_SIZE #2874
2018-09-04 12:01:13 -07:00
0459b6d0d4
Fix dotnet.exe abort exception and startup/shutdown timeouts ( #1352 )
2018-08-31 09:05:46 -07:00
db01ae3717
Remove FreeConsole calls. ( #1358 )
2018-08-31 08:16:07 -07:00
7520ffa0ef
Fix up service scoping in the EF Core xml repository and update package version to 2.2
2018-08-30 16:22:43 -07:00
153020ef8a
Allow UTF8 encoded header values
2018-08-30 16:21:34 -07:00
525fbf495b
Fix #468 - all UseHealthChecks without a path
2018-08-30 15:33:49 -07:00
a6a21351b6
Merge branch 'release/2.1' into release/2.2
2018-08-30 15:28:26 -07:00
bb1cd5ec09
Stop building dependent projects
2018-08-30 15:23:55 -07:00
d8b7dbd1f3
Avoid null refs when IStatusCodeActionResult cannot be discovered
2018-08-30 15:17:09 -07:00
945e798ca7
[Design] Set the endpoint feature only on success
2018-08-30 14:52:35 -07:00
f42f4c56e6
Initialize HttpConnectionManager before registering callbacks ( #2878 )
2018-08-30 14:42:16 -07:00
3dfa26f7e3
Resolve virtual ViewContext max once per method
2018-08-30 14:04:08 -07:00
8395ad8340
remove references to ref emit packages
2018-08-30 13:26:22 -07:00
729a98adfc
Call AllocConsole ( #1351 )
2018-08-30 12:20:53 -07:00
e7f3c7c62e
Remove bad rc files ( #1355 )
2018-08-30 12:18:30 -07:00
922298bc90
Add rc file as an include for ANCMV1 ( #1284 ) ( #1344 )
2018-08-30 12:00:13 -07:00
f90a47c5af
Introduce ProducesErrorResponseTypeAttribute
...
Fixes https://github.com/aspnet/Mvc/issues/8288
2018-08-30 11:24:03 -07:00
3e4a3d0b90
Allow health checks to use any DI lifetime ( #466 )
...
* Allow health checks to use any DI lifetime
This change allows registered IHealthCheck implementations to use any DI
lifetime. This is necessary for scenarios like using EF which requires a
scope.
The works by having the health check service create a scope for each
time it queries health checks. This scope does not overlap or share
state with other scopes (the request scope) so there is no crosstalk
between processing going on per-request in ASP.NET Core and the health
check operation.
* PR feedback and some logging cleanup
2018-08-30 10:51:48 -07:00
927e7c8bfc
Support route data tokens with Endpoint Routing ( #8360 )
2018-08-30 15:14:34 +12:00
8d053853bb
Address PR feedback, I hit merge too soon.
2018-08-29 19:46:25 -07:00
3511c8cef0
Add vectorized il-emit trie jump table
...
Add new futuristic jump table. Remove old experimental jump tables since
this is much much better.
2018-08-29 19:30:02 -07:00
ffdbea9dc1
Add analyzer support for status code methods and constructors
2018-08-29 18:23:52 -07:00
2a426dfea5
Make ViewBuffer methods more inlinable ( #8339 )
...
* Make ViewBuffer methods more inlinable
2018-08-29 17:07:45 -07:00
afccb085a2
Fix links and formating
2018-08-29 16:22:42 -07:00
22a40b6f2b
Use Pages as List
2018-08-29 16:18:25 -07:00
7bd9f9cc3e
Reduce IList interface calls
2018-08-29 16:18:25 -07:00
26710080fe
Set AspNetCoreHostingModel in templates ( #716 )
2018-08-29 16:08:58 -07:00
82a01a414d
Set trace id in ProblemDetalsClientErrorFactory
2018-08-29 16:03:08 -07:00
852ad8df87
Allow content to be written after caught exception from child TagHelper.
...
- The issue was that the `executeChildContentAsync` call was stopping the invocation of the `_endTagHelperWritingScope`. Therefore, we'd never finish the TagHelper content scope and all following content would be ignored.
- Added two tests to validate the new functionality.
#2561
2018-08-29 16:00:15 -07:00
75fa0cd6e8
Remove SpaServices where they're un-needed
2018-08-29 15:24:12 -07:00
ccb2c006aa
Merge branch 'merge/release/2.1-to-release/2.2' into release/2.2
2018-08-29 15:21:15 -07:00
e38a307307
Allow cookie validation when stores don't support security stamp ( #1941 )
2018-08-29 14:41:51 -07:00
8f7d995508
Added Entity Framework Core backed IXmlRepository with tests and sample ( #303 )
2018-08-29 14:04:37 -07:00
b649133eec
Refactor KnownRouteValueConstraint to not require HttpContext ( #8352 )
2018-08-30 08:57:53 +12:00
cf3d2f1299
Minor tweaks to meta-package descriptions ( #1343 )
...
Per feedback on #1320 which came in post-merge.
2018-08-29 12:03:24 -07:00
208f6ff568
Fix #574 : Set NoDefaultLaunchSettingsFile
...
When a project is created with ExcludeLaunchSettings enabled, set the
NoDefaultLaunchSettingsFile property to prevent Visual Studio from
creating a launchSettings.json.
2018-08-29 11:35:16 -07:00
99c4f2f36a
Support policy arguments and resolving services by constructors ( #753 )
2018-08-29 14:51:34 +12:00
d09c3c9e28
Polish ProblemDetails
...
* Add ability to set extended members on ProblemDetails
* Skip empty valued properties when serializing ProblemDetails
Fixes #8296
Fixes #8317
2018-08-28 16:21:39 -07:00
1a43e67542
Remove workaround for dotnet/corefx#24562 ( #2863 )
...
This issue caused a bind to a recently used endpoint to fail on macOS and Linux.
Addresses #2820
2018-08-28 15:59:17 -07:00
667ad4daff
Use ClientErrorData to configure ClientErrorResultFilter
...
Fixes #8289
2018-08-28 13:35:32 -07:00
17d72c2b94
Fix msbuild targets to correctly copy deps.json
2018-08-28 13:32:48 -07:00
96b77c8663
Fix aspnet/Routing#721
2018-08-28 12:26:13 -07:00
5ea537fbc4
Don't advance examined in Http1MessageBody.PumpAsync for canceled reads ( #2847 )
2018-08-28 11:28:17 -07:00
89f4850883
Avoid throwing the same exception instances in parallel ( #2859 )
2018-08-28 10:56:46 -07:00
5f89835420
Merge branch 'release/2.1' into release/2.2
2018-08-28 10:33:12 -07:00
afa93f1852
Merge branch 'release/2.1' into release/2.2
2018-08-28 10:14:24 -07:00
04c606d55f
LongPolling: Setting connection to inactive while there is still an active poll ( #2769 )
2018-08-28 09:44:50 -07:00
9c28f95b12
Add Microsoft.AspNetCore.Razor.Design to templates ( #674 )
2018-08-28 09:41:15 -07:00
037482829d
Add commit hash to V1 description ( #1281 )
2018-08-28 09:36:21 -07:00
5f20f2a2dd
Update schema for ANCMv1 ( #1276 )
2018-08-28 09:35:49 -07:00
cc26d973ba
Remove early dereference of ASPNETCORE_PORT env var ( #1274 )
2018-08-28 09:34:54 -07:00
338af6f07d
Reduce probability of startup port collisions ( #1273 )
2018-08-28 09:34:10 -07:00
6dc55a0462
Don't preserve the ExecutionContext when dispatching callbacks ( #2861 )
...
* Don't preserve the ExecutionContext when dispatching callbacks
- The layers up stack already preserve and restore the ExecutionContext, there's no need to capture and run for the scheduler callback and cancellation token callback
2018-08-28 09:32:33 -07:00
42fa04aa87
Add the latest version of Microsoft.AspNetCore.Razor.Design to the offline package cache ( #1316 )
2018-08-28 09:19:56 -07:00
6b1d22c581
Add package descriptions for Microsoft.AspNetCore.{App, All} ( #1320 )
2018-08-28 09:19:37 -07:00
b206d59612
Prepare 2.1.5 patch
2018-08-28 09:14:43 -07:00
0fcf2448c3
Fix aspnet/Routing#722
...
Exposes a separate change token that will be triggered after action
descriptors have been updated.
2018-08-27 17:24:21 -07:00
2605b943f3
Use only one log file for stdout ( #1334 )
2018-08-27 16:50:16 -07:00
8ed9d0aac2
Use Endpoint instead of RouteEndpoint where possible ( #8331 )
2018-08-28 11:00:11 +12:00
cb0627b28a
Addressing a skipped test
...
I think something that was meant to be revisited in a PR got left
behing. I found this while fixing aspnet/Routing#772 and it seems worth
addressing.
This change removes the hardcoding of action/controller/area in the
data source, and corrects the behavior of required route values when
they aren't in that set.
2018-08-27 15:34:37 -07:00
04b365a22f
Don't hold onto the HttpContext in the HostingLogScope ( #1531 )
...
- Multiple things capture the ExecutionContext, reduce the changes of improperly rooting the HttpContext when we only need a few properties from the request.
2018-08-27 11:59:56 -07:00
f70ba53253
Fix race when SystemClock is accessed before first heartbeat ( #2851 )
2018-08-27 10:59:29 -07:00
9652fbd2b4
Fix default None items not being removed from ClientApp directory
...
Content MSBuild items from the ClientApp directory are removed from
the project using an MSBuild and then all files are added as None
items. None items that were added by the .NET Core SDK default MSBuild
items were not being removed from the ClientApp directory. This
resulted in duplicate files shown in Visual Studio for Mac. This
affected all the SPA project templates.
Fixes #559
2018-08-27 09:59:00 -07:00
a3b20c57ea
Add appsettings.json to EmptyWeb
2018-08-27 09:52:47 -07:00
9b68c5ce89
Add tests for processpath and arguments ( #1331 )
2018-08-24 22:20:28 -07:00
6ddbfb64b9
Improve configuration file handling logic ( #1317 )
2018-08-24 20:20:26 -07:00
2cbf5bd84e
Query event logs when verifying event log messages. ( #1323 )
2018-08-24 16:02:04 -07:00
a7301120b1
Unwrap filter factories in TypeFilterAttribute & ServiceFilterAttribute
...
Fixes #7855
2018-08-24 14:15:40 -07:00
64127e6c76
Implement MaxFrameSize and HeaderTableSize for HTTP/2
2018-08-24 11:07:41 -07:00
d318d7b94d
Make tests less flaky ( #2848 )
...
- Re-order logs with completing the task
2018-08-23 22:29:56 -07:00
fc3c2eef5e
Handle SocketError.ProtocolType as a connection reset on macOS ( #2845 )
...
* Handle SocketError.ProtocolType as a connection reset on macOS
* Make IsConnectionResetError and IsConnectionAbortError stricter
2018-08-23 19:16:44 -07:00
e5a1101239
Improve exception handling in SocketConnection ( #2844 )
...
- Avoid race where a connection reset observed by both DoSend() and DoReceive()
resulted in a ConnectionAbortedException being thrown from the input Pipe
instead of a ConnectionResetException.
2018-08-23 16:59:02 -07:00
dfb579d45c
[ Fixes #8021 ] Copy the request headers before sending the request on the RedirectHandler
...
If another handler modifies the request headers the modified headers get
applied on subsequent requests, which is not correct. This change copies
the headers before sending the request and uses the original headers for
the redirect request instead of the potentially modified ones.
2018-08-23 16:09:05 -07:00
b3a6bda45a
Sync Identity UI default layout with the templates layout
2018-08-23 15:15:54 -07:00
40fb13a021
Fix DfaMatcher to work with non-RouteEndpoint ( #739 )
2018-08-24 09:11:13 +12:00
1d4d882c0d
Spelling mistake in debug log
2018-08-23 13:45:10 -07:00
8eea0ad44c
Update tests to latest compat switch
2018-08-23 08:09:02 -07:00
e2de54a92d
Update MvcEndpointDataSource to use RoutePattern ( #8249 )
2018-08-23 21:42:42 +12:00
15e46ad323
Change RoutePattern to not throw when inline and arg default value are the same ( #747 )
2018-08-23 21:39:23 +12:00
68a0863524
General connection management ( #2834 )
...
This change makes the handling of graceful shutdown work for more than just http scenarios. This should allow us to move TLS further out and should also allow us to start moving things to connection middleware instead of connection adapters.
Summary of the things changed/added:
- Added IConnectionLifetimeNotificationFeature that represents an attempt to gracefully close the connection that isn't being aborted. This feels pretty awful but we may have to do it.
- Moved connection management to the ConnectionDispatcher and out of the HttpConnectionMiddleware
- Removed Http from the names of the ConnectionManager and Heartbeat
2018-08-22 20:35:28 -07:00
a0aa61fd10
Improvements for IEndpointSelectorPolicy
...
These changes are based on our discussion earlier this week. Adding
async, and making it possible to short circuit, which should be better
aligned with the requirments of versioning.
2018-08-22 19:26:13 -07:00
3b3f128306
Enable app verifier on VSTS; Fix debug log handle use ( #1291 )
2018-08-22 15:39:59 -07:00
03da30f3bf
Replace remaining references to global routing ( #8312 )
2018-08-23 10:23:29 +12:00
de0932961b
Default Identity UI to Bootstrap4
2018-08-22 13:40:38 -07:00
110d835434
Fix layout and login partial issues
2018-08-22 13:33:01 -07:00
3ed89516ba
Update precedence for 2.2 templates
2018-08-22 13:31:59 -07:00
eebbb6a602
Support portable.exe apps and better error reporting ( #1287 )
2018-08-22 12:04:04 -07:00
11c6ebea2e
Add comments regarding HSTS max age
2018-08-22 11:45:56 -07:00
d9e71527e8
Fix copyright year
2018-08-22 11:44:46 -07:00
f8a46faf9d
Detect ASP.NET SignalR server connection attempt ( #2820 )
2018-08-22 11:17:04 -07:00
db3f3f2a53
Tweak some Redis log levels ( #2838 )
2018-08-22 10:35:43 -07:00
36e5aceb3c
Serve 503 if server process is shutting down ( #1293 )
2018-08-22 09:53:25 -07:00
e26231b613
Cleanup application manager ( #1250 )
2018-08-22 08:23:40 -07:00
1680b9f4fc
Change endpoint invoker to RequestDelegate, Endpoint/EndpointMetadataCollection namespaces, split out IRouteValuesFeature ( #712 )
2018-08-22 17:15:57 +12:00
cbe1526763
React to routing changes ( #8303 )
2018-08-22 17:15:09 +12:00
08a0a7fadb
Remove MatchProcessor, add IParameterPolicy ( #734 )
2018-08-22 15:24:34 +12:00
0b471f2b2f
Sockets: do 0 byte reads to avoid allocating memory for idle connections
...
- Do not do 0 byte reads on OSX due to potential sockets bug
2018-08-21 18:07:15 -07:00
ac744d8adb
Support Bootstrap 3 and Bootstrap 4 on idenity UI
2018-08-21 17:46:13 -07:00
5bd818bd64
Introduce ProblemDetailsFilter
...
Fixes https://github.com/aspnet/Mvc/issues/6786
2018-08-21 17:29:12 -07:00
e23d9cb4ac
Fix a few leaked handles ( #1260 )
2018-08-21 15:45:42 -07:00
4f33362ab5
Minor RVD and EndpointMetadataCollection refactors ( #708 )
2018-08-22 10:30:25 +12:00
967afc3b0f
Optimize RoutePattern allocations ( #706 )
2018-08-22 10:01:52 +12:00
9ccd3addc3
Synchronizes copyrights between V1 and V2. ( #1283 )
2018-08-21 14:13:33 -07:00
135da118d1
Add rc file as an include for ANCMV1 ( #1284 )
2018-08-21 14:12:15 -07:00
26964b2687
Macrosify out-of-proc ( #1268 )
2018-08-21 14:11:34 -07:00
2778570f0b
Redirect native logs into stdout and pipe ( #1154 )
2018-08-21 14:03:26 -07:00
2d61889e5e
Support empty value for ASPNETCORE_PORT ( #1280 )
...
- Addresses #1264
2018-08-21 13:44:34 -07:00
28d4064cba
Add a build definition for compiling Universe in VSTS
2018-08-20 16:02:43 -07:00
b67a141263
Add code for building the Windows Hosting Bundle and ASP.NET Core runtime installers into this repo
...
This code previously was in private repos because it had references to internal locations and drop shares. This code has been modified to remove these internal-only pieces.
2018-08-20 15:56:22 -07:00
6da64c6d55
Fix process start error message ( #1267 )
...
- Addresses #1261
2018-08-20 14:13:55 -07:00
de32a08ae7
Fix typo in process start error message ( #1266 )
2018-08-20 14:11:51 -07:00
cc4bbd1cef
Fix typos in portsetup error message ( #1265 )
2018-08-20 14:11:18 -07:00
86b7d5162a
Merge branch 'release/2.1' into release/2.2
2018-08-20 08:28:58 -07:00
e85c36fa8c
Clarify CORS policy result log messages ( #177 )
...
Fixes https://github.com/aspnet/Home/issues/3419
2018-08-20 08:25:45 -07:00
6f7a841374
Fire OnStreamCompleted after all pipes are closed
2018-08-17 17:45:47 -07:00
a1e8b3a9af
Free environment variable table in inprocess application ( #1254 )
2018-08-17 16:29:30 -07:00
aa9dde2457
Extract bitshift helper code, Frame cleanup #2773
2018-08-17 15:48:16 -07:00
84d4627b8b
Upgrade build tools to use the 2.1.400 SDK ( #1249 )
2018-08-17 15:23:18 -07:00
5fc59b2331
Free ALLOC_CACHE_HANDLER on dll unload ( #1253 )
2018-08-17 14:26:53 -07:00
d040dabc03
Allow QR AuthenticatorIssuer to be configurable
2018-08-17 12:56:49 -07:00
b4538831b7
Add package descriptions for Microsoft.AspNetCore.{App, All}
2018-08-17 12:06:25 -07:00
16164689dc
Update documentation on the various package archive formats ( #1324 )
2018-08-17 10:42:26 -07:00
731767837a
Introducing new **catchAll parameter to allow generating links with unencoded values
2018-08-16 15:52:09 -07:00
522006d2c8
[Design] Add a MaxValidationDepth option to ValidationVisitor
...
Fixes #7357
2018-08-16 15:01:18 -07:00
373a9c5eb2
Update default UI and samples to use provider display name
2018-08-16 13:40:10 -07:00
fec946759c
Fix SignInManager to return correct external provider display name
2018-08-16 13:38:23 -07:00
87cfd540ce
Fixed documentation typo ( #1862 )
...
Corrected a typo on the XML documentation of the UserId property that made it read "... sets the of the ..."
2018-08-16 13:38:09 -07:00
83488886e0
Clean up some remants of the past ( #2827 )
...
- Remove Application from HttpConnectionContext and Http*ConnectionContext (it's no longer required)
2018-08-15 23:41:32 -07:00
730646c301
Perf for EMC
2018-08-15 22:08:58 -07:00
4fa0b068b8
Fix #710 - add support for data tokens
2018-08-15 21:43:50 -07:00
97f54c532b
Support supression of matching for endpoints
2018-08-15 21:36:08 -07:00
5becb72107
Improve test logs ( #2826 )
...
- Include hosting logs in some tests that where previously missing them
- Prevent duplicate logs from Mock CallBase an CompositeKestrelTrace
- Log ports used by transport functional tests
- Add file logging to HTTP/2 "unit" tests
2018-08-15 18:31:56 -07:00
6440545c4a
Add hosting model switch tests ( #1245 )
2018-08-15 16:47:47 -07:00
0c2923135b
Limit concurrent HTTP/2 Streams per connection #2815
2018-08-15 15:58:57 -07:00
60ca38ab56
Fix deployment parameters override ( #1241 )
2018-08-15 12:15:21 -07:00
085a0b808e
Use RoutePattern in TemplateBinder
2018-08-15 12:12:52 -07:00
af770ede87
Ignore parameters that specify a model binder type
2018-08-15 12:12:04 -07:00
200a70bb86
Update doc comments
2018-08-15 11:42:50 -07:00
1328162052
Remove early dereference of ASPNETCORE_PORT env var ( #1225 )
...
- Addresses #1119
- Includes workaround for #1237
2018-08-14 16:53:13 -07:00
7e25d7908a
Warn when the parameter name for a model bound complex parameter has the same name as a top level property
...
Fixes #7753
2018-08-14 15:44:48 -07:00
e09b88ebd6
Tokenize Less
2018-08-14 15:31:38 -07:00
1104564797
Throw when web config action is added without publish ( #1234 )
2018-08-14 15:08:20 -07:00
0d91dde270
Dynamically link ucrt for release builds ( #1230 )
2018-08-14 12:32:39 -07:00
8dbe564263
Add commit hash to V1 description ( #1229 )
2018-08-14 12:24:49 -07:00
5e20c313d9
Array or List in query string does not get parsed #7712 ( #7967 )
...
- exclude collections when detecting complex types in `ApiBehaviorApplicationModelProvider`
- add test cases
2018-08-14 12:06:27 -07:00
04e58d6ee4
Changed /* */ style comments to // style comments
2018-08-14 11:21:51 -07:00
a431f8efa1
Don't publish too much of ClientApp ( #672 )
...
* Don't publish too much of ClientApp
* Fix scripts and remove extra publish items
2018-08-13 16:21:50 -07:00
2421ae8c83
Add IStatusCodeActionResult ( #8265 )
...
* Add IStatusCodeActionResult
* Add unit test for explicitly implemented property on StatusCodeResult
2018-08-13 15:39:20 -07:00
585e6cd3fe
Introduces a 'formatter' for formatting the IR
...
The new Formatter is used in debugger display, to resolve #2264
The next iteration (assuming we like this) will be to replat our testing
baseline infrastructure on top of this, and then start sharing that with
Blazor - related to #2265 .
I found when implementing debugger display that I was duplicating a lot
of details between testing and this.
I also want to convert the Blazor tests to use shared infrastructure.
Right now the Blazor tests use a modified version of the Razor
infrastructure that has different features.
2018-08-13 13:09:49 -07:00
d725972355
Start adding configuration reload tests ( #1212 )
2018-08-13 13:02:57 -07:00
43398482a5
Implement MaxRequestBodySize for HTTP/2 #2810
2018-08-13 12:06:21 -07:00
cd6de2fa18
Improve HTTP/2 stream abort logic ( #2819 )
...
- Fix race where headers frame could be written after an abort was observed
- Fix Http2StreamTests to verify expected abort-related exceptions
2018-08-13 11:45:17 -07:00
f1c1f82e8b
Fix is_regular_file again ( #1218 )
2018-08-13 10:32:39 -07:00
36add746d7
General cleanup
2018-08-13 08:51:03 -07:00
a8be2bf25b
Add common retry helper for SeverManager ( #1207 )
2018-08-10 14:52:29 -07:00
b029f79b4d
Import styles in correct order ( #668 )
...
In the `angular-cli.json` file, the styles.css file should be imported last in the styles section, so the developer can override styles from third party libraries (bootstrap, in this case).
2018-08-10 14:45:12 -07:00
af616d9b99
Remove KoreBuild-isms from project templates ( #667 )
...
Removing MSBuild properties and items are for our build infrastructure, not for customers.
2018-08-10 11:01:56 -07:00
9da8e2c908
Ensure UnsupportedContentTypeFilter runs before ModelStateInvalidFilter
...
Both UnsupportedContentTypeFilter and ModelStateInvalidFilter use ModelState to
determine the response. UnsupportedContentTypeFilter returns a more specific
response and should execute earlier than the latter filter.
Fixes #8236
2018-08-10 10:39:13 -07:00
ecb353ab2a
Merge branch 'release/2.1' into release/2.2
2018-08-10 09:49:37 -07:00
b82fcc0b21
log when WebSocketTransport has started ( #2752 )
2018-08-10 09:49:17 -07:00
9534c08142
Change versioning of Microsoft.AspNetCore.DataProtection.Redis to 2.2 ( #320 )
2018-08-10 09:13:02 -07:00
a85d99ab8e
Add the 2.1.3 archive baselines and a target to ensure this test is run on PR builds
2018-08-10 09:08:55 -07:00
62a30a731d
Fix bug in graceful shutdown
2018-08-10 00:17:29 -07:00
4628525301
Start W3SVC if it is stopped ( #1197 )
2018-08-09 17:30:26 -07:00
b078521f17
Hold open the nginx dynamic port
2018-08-09 12:30:32 -07:00
cef46fdaa7
Merge branch 'johluo/more-graceful' into release/2.2
2018-08-09 12:00:36 -07:00
7c9e234457
Gracefully wait for streams to complete when pipe completes
2018-08-09 11:59:47 -07:00
8361b8cfa9
Split handler resolution from application info ( #1177 )
2018-08-09 11:32:51 -07:00
c8418c6de8
Derive SocketAwaitable from SocketAsyncEventArgs ( #2592 )
...
* SocketSenderReceiverBase as baseclass for SocketSender and SocketReceiver
* Made SocketAwaitable.GetResult inlineable
* SocketAwaitable renamed to SocketAwaitableEventArgs and inherited from SocketAsyncEventArgs
Thus saving an extra object (`SocketAwaitable`) and two int-fields, so less allocations.
2018-08-09 11:24:06 -07:00
e6330ab19b
Fix win7 test again ( #1187 )
2018-08-09 10:08:44 -07:00
dd429e9597
Catch exceptions thrown by is_regular_file ( #1179 )
2018-08-09 09:45:28 -07:00
d6f410bf42
Add locked app_oflline file test and remove retrying client ( #1178 )
...
* Add locked app_oflline file test and remove retrying client
* Write bytes to file
2018-08-09 09:21:02 -07:00
12cb35894e
Add support for GraphViz
...
Adds **internal** support for dumping a route table to GraphViz DOT
notation. This allows us to dump the DFA graph for a route table and
visualize it.
Example:
https://gist.github.com/rynowak/2b24e4a6a602ca6f9c4de3ec227d621b
2018-08-08 21:36:39 -07:00
433dd42909
Use web.config for ASPNETCORE_DETAILEDERRORS
2018-08-08 17:14:46 -07:00
a550ae6cc3
Provide a better error message when invoking a non-existant hub method ( #2768 )
2018-08-08 15:55:33 -07:00
da1189e6f1
Use StatusCodes constants instead of literals in the ProducesResponseType code fix ( #8234 )
...
* Use StatusCodes constants instead of literals
2018-08-08 14:41:30 -07:00
2265acde78
Don't start stream if already canceled ( #2764 )
2018-08-08 14:04:05 -07:00
d153bab4a1
Use configurationRedirection for IIS Deployer ( #1170 )
2018-08-08 11:25:44 -07:00
c0557cfca7
Improve exception handling in Http2Connection.ProcessRequestsAsync ( #2787 )
2018-08-08 11:20:49 -07:00
5378900e0c
Ack settings before window updates #2772
2018-08-08 11:19:23 -07:00
f868277373
Experience review feedback
2018-08-08 10:57:45 -07:00
c73d513289
Add Http2 frame logging
2018-08-08 09:46:42 -07:00
5e7f63b096
Make un-graceful shutdown a bit more graceful ( #2748 )
...
* Make un-graceful shutdown a bit more graceful
- Change how graceful shutdown is done to ensure there are no errors on shutdown.
- Avoid closing pipes from under other components that own those pipes.
- Close the application output so that the application's read loop ends gracefully. For websockets, we cancel the token, for other transports, we close the output directly.
2018-08-07 21:39:09 -07:00
7431892e64
Replace "std::experimental::filesystem" with "std::filesystem" ( #1153 )
...
* Continuation of #1082
2018-08-07 16:37:11 -07:00
b53d50f6f0
Fix incorrectly resolved cross-document pointers
2018-08-07 16:16:33 -07:00
0e99235d59
Add in-memory functional test project ( #2780 )
...
- Run AddressRegistrationTests independently to avoid port conflicts
- Only run tests that verify transport behavior for each transport
2018-08-07 15:34:11 -07:00
0cf53e7d34
Show HTTP/2 status on requests #106
2018-08-07 14:39:27 -07:00
9585084258
Using Routing feature branch versions
2018-08-07 13:38:36 -07:00
8a74cf3ed5
Gracefully shutdown HTTP/2 connections on server and client initiated shutdown
2018-08-07 10:59:29 -07:00
dce72c9553
Remove public extension methods for registering endpoint routing ( #697 )
2018-08-07 17:49:31 +12:00
e403de7fbf
Solve LongPolling races by moving Cts disposal to connection disposal ( #2731 )
2018-08-06 19:17:29 -07:00
39c5700148
Add docs to RouteValuesAddress ( #695 )
2018-08-07 13:14:35 +12:00
c6830afa55
Add default debug log file name and dll information to debug log ( #1149 )
2018-08-06 17:20:44 -07:00
647f0f81c2
CompatibilityVersion -> 2.2
2018-08-06 16:22:05 -07:00
e47a08612b
JQuery-validate-unobtrusive version 3.2.10
2018-08-06 15:21:46 -07:00
60a559719f
Reduce probability of startup port collisions ( #1136 )
...
- GetTickCount() is limited to the resolution of the system timer, which is typically 10-16 ms. If two apps in separate app pools are started within this time window, it's possible GetTickCount() will return the same value, which causes the apps to try the same random port(s).
- Addresses #1124
2018-08-06 14:41:11 -07:00
47f2f451e3
EnableEndpointRouting documentation ( #8220 )
2018-08-07 09:22:33 +12:00
4e7cbb1931
Initialize logging under exclusive lock ( #1161 )
2018-08-06 12:30:58 -07:00
c5a5134e46
Revert "Rename Web Application to Starter Web Application"
...
This reverts commit 01ce77da56
2018-08-06 12:10:14 -07:00
41d648fcc1
Fully-qualify model name
2018-08-06 12:03:22 -07:00
ea7e53cab0
Send Resets for unhandled app exceptions #2733
2018-08-06 11:35:42 -07:00
e78e3db6f4
Honor InherentKeepAliveFeature for server timeout ( #2727 )
2018-08-06 10:37:12 -07:00
3ee57ff81a
Merge pull request #659 from aspnet/dev/mkArtakMSFT/issue579
...
Removed the `layout=null` assignment from the page
2018-08-06 10:35:26 -07:00
71c15fb76a
Use bootstrap4 for templates
2018-08-06 10:16:35 -07:00
959771e73a
Fix incrementality checks for test projects ( #1145 )
2018-08-06 09:46:40 -07:00
c2f5101b73
Split managed application status and IApplication status ( #1148 )
...
Split managed application status and IApplication status
2018-08-06 09:41:56 -07:00
14512a714f
Removed the `layout=null` assignment from the page
2018-08-06 08:55:51 -07:00
d95f971693
Fix broken tests
2018-08-06 07:22:55 -07:00
43c74cfa53
Respond to much of the feedback from review
...
Default to requerying swagger for each exec
Auto-set the content-type if not yet set for requests based on swagger
Fix swagger UI command
Make error and warning colors configurable
Allow aliases to be specified in structured input based commands
Have delete not require a body
Show allowed methods for . and ..
Show verbs on the announced path after CD
Issue a request on set base and warn if there's a socket error
2018-08-03 20:58:07 -07:00
e53a9f57db
adding more docs
2018-08-03 18:55:57 -07:00
5ee3ae9002
Add XML docs to data sources and metadata ( #692 )
2018-08-04 13:34:25 +12:00
16a933a0a4
Update static content
2018-08-03 17:18:32 -07:00
c16f86f0ef
React to Routing repo's api changes
2018-08-03 16:25:41 -07:00
d199de2c80
Revert "Replace "std::experimental::filesystem" with "std::filesystem" ( #1153 )"
...
This reverts commit 2a761d635c
2018-08-03 15:44:35 -07:00
d4472f08ed
Remove legacy EnableGlobalRouting option ( #8214 )
2018-08-04 09:58:00 +12:00
ebafbcdae3
Add filtering by port
...
This adds UseHealthChecks overloads that configure the health checks
middleware to listen on a preconfigured port.
This is sugar for MapWhen, but it's important because a significant set
of users will want to use Health Checks in this way.
2018-08-03 14:37:27 -07:00
2a761d635c
Replace "std::experimental::filesystem" with "std::filesystem" ( #1153 )
...
* Continuation of #1082
2018-08-03 14:04:32 -07:00
f867367b56
Use V2 schema for V1 outputs, do not pack pdb's ( #1152 )
2018-08-03 13:55:25 -07:00
4b2dc59979
[ Fixes #1835 ] Move the default Identity UI to use Bootstrap 4
2018-08-03 13:48:30 -07:00
4d706f045f
rebase changes
2018-08-03 12:45:31 -07:00
09ce9c3041
Api clean up
2018-08-03 12:37:37 -07:00
091cb94094
Change metadata namespace
...
Change EndpointOptions visibility to internal
Add IRequiredValuesMetadata
2018-08-03 12:37:37 -07:00
c8946a40e4
Created LinkGenerationTemplate and friends
2018-08-03 12:33:34 -07:00
8a9b407761
Use netcoreapp2.1 instead of 2.2
2018-08-03 12:27:02 -07:00
a375cba359
Copy action constraints and EndPointMetadata when setting up a PageActionDescriptor ( #8208 )
...
* Copy action constraints and EndPointMetadata when setting up a PageActionDescriptor
Fixes #8207
2018-08-03 12:04:44 -07:00
4549b84cb5
Remove JSON output ( #457 )
...
* Remove JSON output and convert to sample
GlennC and I made the decisison to turn the JSON output into a sample
rather than something we support out of the box. We wouldn't tell
customers to definitely use it and we don't want to introduce more
coupling to JSON.NET.
2018-08-03 09:40:45 -07:00
af5d8a8244
Address most code review comments
...
Pagination hasn't been dealt with yet
mac keybindings may be able to be simplified, pending some additional verification
Fix 3rd party signing cert
Bind a few common bash/zsh mappings
Check for output redirection
Make package version variable name consistent
Add --help option for the command line
Remove regions
Remove old pointer resolution code
Make command not found message more friendly
Fix issue where base address was required for requests to absolute URIs
Add options to suppress response formatting and streaming
Turn off packing for the REPL project
2018-08-03 09:18:39 -07:00
ac410b76d9
Change MvcEndpointInfo to internal ( #8210 )
2018-08-03 16:30:57 +12:00
05eb6a7f7c
Add ERROR_SHARING_VIOLATION to retry list for IISDeployer.Start ( #1147 )
2018-08-02 16:51:00 -07:00
bc13fd5450
Write websocket header directly to the repsonse headers ( #253 )
2018-08-02 16:45:29 -07:00
ce8fc29728
ConsumesAttribute accepts requests without content type
...
Fixes #8174
2018-08-02 16:27:23 -07:00
b177ba5309
Changed api of LinkGenerator
2018-08-02 16:10:56 -07:00
0989231ed5
Make structs readonly
2018-08-02 15:44:09 -07:00
810c7cf9ad
Fix ODE race with cancellationtokensource ( #2721 )
2018-08-02 15:24:26 -07:00
9cea167cfa
Add docs - EndpointFeature and related types ( #687 )
...
* Add docs - EndpointFeature and related types
* Add docs for route patterns
2018-08-02 15:24:00 -07:00
90606338fb
Log when closing connection due to timeout ( #2722 )
2018-08-02 15:21:24 -07:00
e2b6f07778
Respect LowercaseUrls in ApiExplorer
...
Fixes #8006
2018-08-02 14:58:41 -07:00
768d2a023e
Add Origin validation to WebSockets middleware ( #252 )
2018-08-02 14:43:11 -07:00
5a20037965
Move API convention analyzers to Microsoft.AspNetCore.Mvc.Api.Analyzers
...
Fixes #8153
2018-08-02 13:53:33 -07:00
6d9aa281c5
Render `maxlength` attribute for an input tag, when MaxLength or StringLength validation attributes are applied to the model class.
2018-08-02 13:44:19 -07:00
beca0259c2
Verify request Content-Length #2733
2018-08-02 13:23:57 -07:00
477fd1d90d
Aquire exclusive lock when creating application info ( #1142 )
2018-08-02 13:17:17 -07:00
b7335ac768
Add a code fix that applies ProducesResponseTypeAttributes
2018-08-02 09:40:18 -07:00
1d1b2155c4
Merge pull request #1117 from aspnet/shirhatti/updatemodulename
...
Update module version property to match exact name of the module
2018-08-02 08:57:10 -07:00
64124e9c85
Add filtering to Health Checks middleware
...
This allows each middleware to be configured with a specific set of
checks (by name). See the comments in the sample for how this is
frequently used.
This is also addresses aspnet/Home#2575 - or at least the part that we
plan to do. We think that any sort of built-in system of metadata or
tags is vast overkill, and doesn't really align with the primary usage
of health checks.
We're providing building blocks, and these can be put together to
build more complicated things like what's described in aspnet/Home#2575 .
2018-08-01 19:07:58 -07:00
2b289d2f2c
Use MatcherPolicy for Consumes
2018-08-01 19:05:04 -07:00
47f427d5ac
Updating Health Checks for 2.2
...
A bunch of small changes and updates for 2.2 focused at making our main
scenarios more streamlined and focused. Also adds samples for
extensibility we support so far.
A list of changes:
Clearing baselines for these projects. We didn't ship anything in 2.1 so
there should be nothing in the baselines.
--
The middleware now uses Map for path matching. This makes the actual
`HealthCheckMiddleware` more standalone. This will make it easy to use
with Dispatcher/Endpoint Routing in the future.
This also manifests by removing Path from HealthCheckOptions - the path
is an explicit argument to the UseHealthChecks middelware - this
streamlines the design for 3.0.
--
Added extensibility for customizing the status codes (aspnet/Home#2584 )
--
Added extensibility for writing the textual output (aspnet/Home#2583 )
--
Changed the default output to be `text/plain`. The most common use cases
for health checks don't include a detailed status.
The existing output format is still available as an option.
2018-08-01 18:49:44 -07:00
8c4f187c22
Endpoint routing rename and API review changes ( #684 )
2018-08-02 13:38:08 +12:00
44f5b54f5f
React to routing API review ( #8194 )
2018-08-02 13:37:43 +12:00
a080301b89
Removed CorsConstats.Simple* variables
2018-08-01 16:02:13 -07:00
2db11051d8
Removed Simple request filtering
2018-08-01 16:02:13 -07:00
8ea2cd9081
Ship shim with integration testing ( #1129 )
2018-08-01 15:40:45 -07:00
7487da155f
Switch signing certificate for Newtonsoft.JSON to Microsoft3rdPartyAppComponentDual
2018-08-01 12:42:16 -07:00
7f8f210a24
Add license headers to all files
...
Bump version of JSON.NET to 11.0.2
2018-08-01 12:37:35 -07:00
89ab0cfde8
Initial commit of the HTTP REPL
2018-08-01 12:37:34 -07:00
814a803ed8
Use local instances of MemoryCache in script, link and image tag helper
2018-08-01 10:14:31 -07:00
f4ff537a31
Fix flaky test by using a different instance of contract resolver
...
[Fixes #8175 ] FlakyTest: ExecuteAsync_ErrorDuringSerialization_DoesNotCloseTheBrackets
2018-08-01 07:33:37 -07:00
046af405b6
Rename global routing to endpoint routing ( #8179 )
2018-08-01 15:05:49 +12:00
ff0a5bbbdf
Update resources.h ( #1134 )
2018-07-31 19:21:32 -07:00
c8eedb3540
Fix race when connection is canceled and new poll comes in ( #2697 )
2018-07-31 16:36:54 -07:00
658906bf7c
Add TestApplication to allow publish output caching ( #1511 )
2018-07-31 16:36:31 -07:00
651b39bc90
Revert "Merge branch 'master' into release/2.2"
...
This reverts commit 785200877a3d6e1e69fd
2018-07-31 15:24:33 -07:00
e19b0b738c
PR Feedback
2018-07-31 14:51:55 -07:00
85c7bd8fac
Discard ambient values during link generation if the values do not match explicit values
...
[Fixes #544 ] Link generation: Discard ambient values unless routing to the same address
2018-07-31 14:50:04 -07:00
ef2c127459
Show route name
2018-07-31 14:08:24 -07:00
f62877b9db
Show default values in CompositeEndpointDataSource's debugger display string
2018-07-31 12:39:37 -07:00
a4b91d6dce
Flatten AggregateExceptions in rzc
2018-07-31 11:11:43 -07:00
0726b8b98b
Make publicly exposed Roslyn types internal
2018-07-31 11:08:22 -07:00
e094d2579e
Suppress obsolete warnings
2018-07-31 11:06:30 -07:00
785200877a
Merge branch 'master' into release/2.2
2018-07-31 10:22:09 -07:00
3d6e1e69fd
Close LongPolling connection on poll exception ( #2701 )
2018-07-31 09:52:10 -07:00
ddde149792
Cleanup some IDE warnings
2018-07-30 15:06:43 -07:00
b2a1a7c9de
Ensure parent is a MethodDeclarationSyntax
2018-07-30 14:59:27 -07:00
5d4fedaeac
Remove extra logic from file watcher ( #1107 )
2018-07-30 14:37:33 -07:00
d346255db6
Add analyzer and codefix that suggests removing unnecessary invalid model state validity checks
...
Fixes #8146
2018-07-30 13:14:20 -07:00
7a4a945fd6
Stop site and app pool before restoring config ( #1112 )
2018-07-30 12:58:48 -07:00
6d46410a76
Don't ACK ACKs ( #2767 )
2018-07-30 12:25:32 -07:00
367717760b
Handle subtype with suffix being a subtype without a suffix ( #8170 )
2018-07-30 12:05:41 -07:00
80b6ae4eb4
Handle subtype with suffix being a subtype without a suffix ( #1027 )
2018-07-30 12:05:35 -07:00
0102d4efab
Introduce ApiConventionMethodAttribute
...
Fixes #8147
2018-07-30 11:13:25 -07:00
cb557cf771
Changed `GetDesiredIndentation` to be resilient to our SyntaxTree which occasionally has gaps.
...
- Added a test to cover the scenario.
#2489
2018-07-30 10:45:18 -07:00
132a382838
Update Microsoft.AspNetCore.Server.IISIntegration.targets
2018-07-30 09:51:17 -07:00
6a29b5296b
Update Microsoft.AspNetCore.Server.IIS.targets
2018-07-30 09:50:14 -07:00
41493f01e3
Don't stop redirect stdout/stderr after startup is done. ( #1067 )
2018-07-29 23:25:32 -07:00
fbae57cde1
React to the removal of EndpointConstraint
2018-07-28 19:03:16 -07:00
f8b3b73ca7
Remove EndpointConstraints
...
Adds IEndpointSelectorPolicy so that MVC can plug in to the
EndpointSelector to run action constraints.
2018-07-28 19:03:12 -07:00
c01c7075be
Add EndpointMetadata to ActionDescriptor and hookup CORS ( #8158 )
2018-07-28 16:12:54 +12:00
0af3bef0fe
Fix win7 test failures. ( #1109 )
2018-07-27 17:32:01 -07:00
f870503cdd
Fix HttpMethodMetadata debug string ( #666 )
2018-07-28 11:13:30 +12:00
647e7c3266
Add new ConfigureKestrel extensions #2760
2018-07-27 15:25:18 -07:00
f901bca8a7
Fixing jenkins agents. ( #1106 )
2018-07-27 15:00:04 -07:00
38e145389e
Fix BackgroundDocumentGenerator flaky tests.
...
- Some time spans were too aggressive for parsing a Razor file on a slow environment.
- Fixed an obvious race where we'd expect 0 pending notifications when it was possible to be in the process of clearing notifications.
#2506
2018-07-27 14:49:12 -07:00
c7dd9ff68a
Enable Http/2 by default #2720
2018-07-27 12:51:12 -07:00
6efdf78fb5
IIS ANCM support in test matrix ( #1509 )
2018-07-27 11:48:57 -07:00
94cfc01fbf
Implement HTTP/2 input flow control ( #2740 )
2018-07-27 10:47:27 -07:00
5875ff40b1
Add UseIIS to CreateDefaultBuilder ( #278 )
2018-07-27 10:18:56 -07:00
54e5370e8f
Add CORS support to HttpMethodMatcherPolicy
...
Also removes HttpMethodEndpointConstraint, since it's been fully
replaced.
2018-07-26 23:01:11 -07:00
fed2eb1cdf
More robust username discovery on Linux in NginxDeployer ( #1508 )
...
VSTS does not have the LOGNAME env var set. This adds some fallbacks (USER and USERNAME) and `whoami` if they are not present.
2018-07-26 17:07:24 -07:00
7067d92c75
Limit RH native assets to netcoreapp2.2 ( #1105 )
2018-07-26 14:15:50 -07:00
556880872d
Ensure later validations of `null` models do not overwrite `Invalid` state
...
- #8078
2018-07-26 13:49:22 -07:00
afa5d60821
Add content/webroot and currect directory tests ( #1103 )
2018-07-26 12:12:12 -07:00
8e23eb38b4
Honor NoBuild flag during publish
2018-07-26 11:40:38 -07:00
498fa2d72f
Avoid `InvalidOperationException` when serializing `SerializableError`
...
- #8055
- provide unique name (`<Empty-Key>`) for XML elements that would otherwise be nameless
nits:
- remove now-useless Mono special case in updated test class
- extend updated tests to involve square brackets as well as empty keys
2018-07-26 08:56:02 -07:00
61b4473abe
Fix another shutdown race and appofline race ( #1071 )
2018-07-26 08:12:08 -07:00
c4e8dd3664
Rename WebHostBuilderFactory ( #1505 )
2018-07-25 16:44:20 -07:00
c68c5befc7
Remove ChangeToken from EndpointDataSource ( #662 )
2018-07-26 11:06:54 +12:00
f31ab716ee
Change MvcEndpointDataSource to use GetChangeToken ( #8137 )
2018-07-26 09:20:26 +12:00
34a7fc4d99
Merge branch 'merge/release/2.2-to-master'
2018-07-25 11:45:32 -07:00
2e96271e69
Merge branch 'release/2.1' into release/2.2
2018-07-25 09:29:48 -07:00
10ce77b9ca
Updated MvcEndpointDataSource to create endpoints with SuppressLinkGenerationMetadata
2018-07-25 06:41:57 -07:00
19f24cad16
fix silly constructor
2018-07-24 21:54:24 -07:00
1340f9c26b
Add EndpointSelectorCandidate ctor to not break MVC ( #661 )
2018-07-25 16:03:26 +12:00
fdff66054f
Missing ChangeToken -> GetChangeToken updates ( #660 )
2018-07-25 14:35:41 +12:00
c08504b08a
MVC startup experience ( #8131 )
2018-07-25 14:30:51 +12:00
147c9527f3
Implement EndpointSelector and MatcherPolicy ( #646 )
...
Implement EndpointSelector and MatcherPolicy
This change makes the EndpointSelector API more concrete, and is the
beggining of removing EndpointConstraint by making it obsolete.
To that end, I'm introducing MatcherPolicy, which is a
feature-collection API for registering policies that interact with the
DfaMatcher. The two policies that we'll need to start are:
- ability to order endpoints
- ability to append 'policy' nodes to the graph
These two concepts together replace EndpointConstraint. Extending our
graph representation is a really efficient way to processing most common
scenarios.
---
In general this helps with common cases where 4 or so endpoints match
the URL, but with different HTTP methods supported on each. Today we
have to process route values and call into some 'policy' to make a
decision about which one is the winner. This change pushes this
knowledge down into the graph so that it's roughly as cheap as a
dictionary lookup, and can be done allocation-free.
The big savings here is ability to remove more candidates *before*
collecting route data.
---
Along with this change, I also built 'rejection' into the DFA node
model, you can see an example with the HTTP Method handling that I
implemented. I implemented a policy that can treat failure to resolve an
HTTP method as a 405 response by returning a failure endpoint. This is
at the heart of much of the feedback we've gotten in this area around
versioning and http method handling. We also have a version of this
feature in MVC for [Consumes].
2018-07-24 17:31:51 -07:00
f37ca0d2e9
Show list of endpoints in CompositeEndpointDataSource's DebuggerDisplayString
...
[Fixes #633 ] Show list of registered endpoints as debugger display string
2018-07-24 17:22:43 -07:00
6f4c10a664
PR feedback
2018-07-24 17:17:08 -07:00
71cb933a08
Show a flattened tree in LinkGenerationDecisionTree's DebuggerDisplayString
...
[Fixes #636 ] Flatten the LinkGenerationDecisionTree to show as debugger display string
2018-07-24 17:11:53 -07:00
34499dbe24
Added support for suppressing link generation for endpoints
2018-07-24 16:47:34 -07:00
5bd475ef90
Add event logs for some startup failure cases ( #1081 )
2018-07-24 13:17:05 -07:00
0435add47a
Merge branch 'release/2.1' into release/2.2
2018-07-24 11:59:30 -07:00
1f3524787e
Merge branch 'release/2.1' into release/2.2
2018-07-24 11:43:13 -07:00
31eaaac4a8
Merge branch 'release/2.1' into release/2.2
2018-07-24 10:34:53 -07:00
7da1baf9d8
Do not use decision tree for named routes in RouteValuesBasedEndpointFinder
2018-07-24 05:33:19 -07:00
3df34dbbfe
React to Routing repo's LinkGenerator api changes
2018-07-24 05:20:53 -07:00
5f1631ab46
Added support for configuring route options with LinkGenerator
2018-07-24 04:45:33 -07:00
684e7855a6
Handle `null` entries correctly for `IsEmptyOrWhiteSpace`
...
- #2497
nits:
- take VS suggestions
- un-scramble `IsEmptyOrWhiteSpaceCore(...)` for readability
2018-07-23 15:25:41 -07:00
feceb3ddea
Lowercase scheme and host to better align with RFC 6454.
2018-07-23 12:22:15 -07:00
52c1e942c6
Added UseCamelCasing and UseMemberCasing extension methods to MvcJsonOptions ( #7256 )
2018-07-23 10:11:04 -07:00
fba4e3ec4e
Switch to non-experimental filesystem ( #1082 )
2018-07-23 08:57:43 -07:00
2c325440de
Remove AddDispatcher/UseDispatcher
2018-07-22 20:35:10 -07:00
196e3f109f
React to Routing branding
...
This is a reaction PR for the branding changes in progress in Routing.
This can be merged after the changes to in to Routing.
2018-07-22 19:47:15 -07:00
1e807240ea
Add GetChangeToken to EndpointDataSource ( #649 )
2018-07-23 13:46:22 +12:00
b9df95831d
Change Branding
...
For preview one the branding is:
new thing = UseGlobalRouting/UseEndpoint
old thing = UseRouter
We're going to drop the name Dispatcher everywhere and make sure that we
position our new work as 'new and improved routing' instead of
introducing a new product/concept name.
We're not totally sure of the term Global yet, but it's what we're doing
for preview 1. Suggestions welcome for dicussion after we do the first
preview :)
2018-07-22 16:41:59 -07:00
c0ba374549
Custom error messages with validation message tag helper #8035
...
#8035
PR #8087
https://github.com/aspnet/Razor/issues/2497
2018-07-22 17:55:06 +05:30
c3545c18eb
Add api sets to IntegrationTesting.IIS ( #1083 )
2018-07-20 17:32:57 -07:00
28c0c4d128
Add ability to override the testing web content root using environment variables
2018-07-20 16:56:24 -07:00
d4beab5d09
CompositeValidationAttribute
...
- Add abstract CompositeValidationAttribute.
- Change DataAnnotationsMetadataProvider.CreateValidationMetadata to
populate ValidatorMetadata with validation attributes from CompositeValidationAttribute.
2018-07-20 15:31:14 -07:00
f1c060bf3d
RoutePattern everywhere
2018-07-20 13:04:34 -07:00
5c488bf09c
make feature branch build
2018-07-20 12:57:43 -07:00
3ba6f35495
React to RoutePattern changes in Routing
2018-07-20 12:57:43 -07:00
90395c933d
Implement IRoutingFeature on EndpointFeature for back-compat ( #641 )
2018-07-20 18:23:14 +12:00
256aed8369
Make IISExpress shutdown gracefully. ( #1066 )
2018-07-19 23:20:13 -07:00
53930af0e3
Set ProblemDetails status field during ObjectResult formatting
2018-07-19 17:57:55 -07:00
f1e66b5a6f
Reset LZMA to only include the implicit package version ( #1266 )
2018-07-19 16:50:53 -07:00
612fcca729
Validate Http/2 pseudo headers #2205 #2263 #2659
2018-07-19 16:25:10 -07:00
433eeb6943
Abort connection on protocol error ( #2654 )
2018-07-19 14:50:14 -07:00
603cd03bfa
Stop writing responses after the unexpected end of request content ( #2734 )
2018-07-19 14:18:57 -07:00
b934e46161
Complete the transport pipes after connection middleware runs ( #2735 )
2018-07-19 11:49:46 -07:00
89fda83bbd
Move config operations from helpers to functions on the deployment parameters ( #1063 )
2018-07-19 11:14:07 -07:00
41f56dbbed
Minor fix to DefaultLinkGenerator and enabled constraint related tests in DefaultLinkGeneratorTest
2018-07-19 09:11:50 -07:00
ec8976ffaf
Update MvcEndpointDataSource on raised change token ( #8108 )
2018-07-19 16:43:24 +12:00
01ce77da56
Rename Web Application to Starter Web Application
2018-07-18 16:18:49 -07:00
21d9ec64f0
Add copy constructor to deployment parameters ( #1497 )
2018-07-18 14:28:48 -07:00
55b697ab05
Revert "Add package version to Microsoft.AspNetCore.App in project templates"
...
This reverts commit 727bd52b64
2018-07-18 13:11:01 -07:00
477296a3cc
Make DFA matcher the default
2018-07-18 07:50:27 -07:00
0634e1183e
React to hosting changes ( #1072 )
2018-07-17 21:06:03 -07:00
19839ed308
Revert "Merge pull request #1494 from aspnet/revert-1493-pakrym/useiis" ( #1496 )
...
This reverts commit 7a0a1ee50bec0b7ab2cd
2018-07-17 21:05:59 -07:00
badbcb9437
Add MvcEndpointDataSource benchmarks ( #8104 )
2018-07-18 15:48:18 +12:00
54471a2930
Add client abort tests ( #1051 )
2018-07-17 20:26:57 -07:00
400d243f42
Fix remaining feature gaps in DfaMatcher ( #621 )
...
* Fix remaining feature gaps in DfaMatcher
* addressed minor feedback
* missed one
2018-07-17 19:22:46 -07:00
7f6b05149d
Generate deterministic unique ids for tag helpers
2018-07-17 14:01:42 -07:00
65f8cfc55b
Revert "Remove IISExpress deployer ( #1493 )"
...
This reverts commit ec0b7ab2cd
2018-07-17 12:07:42 -07:00
21f2edce16
Generate and verify baselines for ClassifiedSpans and TagHelperSpans
...
- Moved GetClassifiedSpans and GetTagHelperSpans logic to Razor.Language
2018-07-17 10:54:42 -07:00
ec0b7ab2cd
Remove IISExpress deployer ( #1493 )
2018-07-17 10:16:50 -07:00
074264cd3a
Use less global variables ( #1064 )
2018-07-17 08:56:18 -07:00
1196349bf4
[ Fixes #583 ] Handle change events in RouteValueBaseEndpointFinder
2018-07-17 05:54:11 -07:00
0caacb8217
React to LinkGenerator api changes
2018-07-17 05:24:27 -07:00
aed2e24483
Allow to pass in HttpContext when generating links
2018-07-17 05:16:57 -07:00
42218d5fb5
Versioning with endpoint constraint ( #8098 )
2018-07-17 16:37:45 +12:00
02e1d78319
Minor fixes for MatchProcessorFactory
...
Fixing minor issues found doing DFA integration.
2018-07-16 21:06:35 -07:00
b62499e02c
Ensure PageContext.ViewData and ViewContext.ViewData are the same instance
...
Fixes #7675
2018-07-16 11:16:03 -07:00
9d951325b2
Re-organize shared src packages so we can do true IVT between src assemblies
2018-07-16 11:15:58 -07:00
429bcfe216
Sending and receiving RST frames. #2462
2018-07-16 09:13:11 -07:00
b2e4743c7d
Change benchmarks ( #612 )
...
Add benchmarks that include some HTTP method matching.
Clean up names and name like-kinded benchmarks alphabetically.
Matcher*Benchmark -> E2E including HTTP method selection
MatcherSelectCandidates*Benchmark -> Focused on just URL path processing
2018-07-14 17:21:05 -07:00
497a38035d
Add application startup check that dispatcher is added to request pipeline ( #614 )
2018-07-15 11:50:55 +12:00
73e4d55d7b
Check dispatcher services registered ( #610 )
2018-07-14 18:20:42 +12:00
c657e31b94
Fix Console invalid handle issues. ( #1029 )
2018-07-13 21:32:20 -07:00
9e114b547d
Introduce RoutePattern ( #585 )
...
* Introduce RoutePattern
Introduces RoutePattern - a new parser and representation for routing
templates, defaults, and constraints.
This is a new representation for all of the 'inputs' to routing that is
immutable and captures 'out of line' information for defaults and
constraints.
This will allow us to unify the handling of constraints and values from
attribute style routes and conventional style routes.
2018-07-13 18:01:46 -07:00
cfd63e1e2e
Change HTML splitting logic to not split on surrogate pairs.
...
- When a surrogate pair is about to be split down the middle we reduce the size of our split by 1 character. This way we split right before a surrogate pair. In the case of zero width joiners, if we split on a zero width joiner we still render valid bytes because the zero width joiner by itself can stand alone.
- Added tests for the various split cases.
#2470
2018-07-13 17:18:56 -07:00
6551eae321
Consolidate HTTP charset validation logic
2018-07-13 16:47:28 -07:00
bc79a47959
Temporary change to prevent cross repo breaking change: Added ooverload for MatcherEndpoint
2018-07-13 14:24:11 -07:00
42708bec91
Added support for route constraints in Dispatcher world
2018-07-13 14:18:54 -07:00
35fad0881b
Mark unused `ParameterBinder.BindModelAsync(...)` overloads as `[Obsolete]`
...
- #7660
- also addresses part of #7317 , only in `ComplexTypeModelBinderIntegrationTest`
2018-07-13 13:26:56 -07:00
f2608c2ff4
Do not suppress `ModelValidationState.Invalid` entries
...
- #7992 , #7963
2018-07-13 13:21:43 -07:00
dfbdb37979
Refactorings for codefix ( #8067 )
...
* Refactorings for codefix
- Move some common code in SymbolApiResponseMetadataProvider
- Don't run diagnostics for 1006 if we are unable to parse a return type
2018-07-13 13:05:49 -07:00
b359d6bed1
Fix CI test failures ( #1045 )
2018-07-13 11:35:52 -07:00
1c7f53ae39
Fix TemplateBinder to consider null and empty string values the same
2018-07-13 10:21:55 -07:00
7209cab5e9
Productize JumpTable ( #594 )
...
* Productize JumpTable
2018-07-12 23:28:51 -07:00
f12f9b46ed
Add startup filter to set MiddlewareFilterBuilder.ApplicationBuilder
2018-07-13 12:23:30 +12:00
36d7c8ec42
Add startup event log for ANCM inproc ( #1047 )
2018-07-12 16:03:06 -07:00
a5083d525b
Fix regression with Authorize + IPolicyProvider ( #8068 )
2018-07-12 15:36:03 -07:00
0cf972cc43
Error message on no dispatcher middleware in endpoint middleware ( #600 )
2018-07-13 10:16:21 +12:00
46189abda7
Refactoring for ApiConvention analyzers
2018-07-12 14:26:27 -07:00
c9122a8428
Include AuthenticationTicket.Properties in AuthenticationTicket success result handling #1765 ( #1767 )
2018-07-12 13:58:49 -07:00
74667eda9c
Don't specify MainEntryPoint when compiling Razor assembly
2018-07-12 13:05:10 -07:00
174c5eaa6c
Make fewer public API changes
2018-07-12 12:46:49 -07:00
4f1b7ccca6
Use ModelMetadata from actual types for validation
...
Fixes https://github.com/aspnet/Mvc/issues/7952
2018-07-12 12:46:49 -07:00
f179339a79
Combine BufferWriter and CountingBufferWriter
2018-07-12 11:58:49 -07:00
6bed0b7206
Add Microsoft.AspNetCore.Server.IntegrationTesting.IIS package ( #1037 )
2018-07-12 11:56:33 -07:00
864cfeb2aa
Merge branch 'release/2.1' into release/2.2
2018-07-12 11:18:41 -07:00
e5dfea5725
Adds project properties and project capabilities to IIS and IISIntegration ( #969 )
2018-07-12 11:00:01 -07:00
c81f379045
Normalize file extensions and project structures ( #1038 )
2018-07-12 09:30:50 -07:00
3a022107dc
Revert "Added support for route constraints in Dispatcher world"
...
This reverts commit 85e92ab3cc
2018-07-12 06:24:37 -07:00
85e92ab3cc
Added support for route constraints in Dispatcher world
2018-07-12 05:06:22 -07:00
128eefdef3
Remove usage of the Microsoft.Extensions.Buffers.Sources package, copy the source into Kestrel
...
This moves source code that used to be in aspnet/Common. It was only used here, so this simplifies the process of working with these internal-only APIs.
cref https://github.com/aspnet/Common/pull/386
2018-07-11 22:31:23 -07:00
11ca4e46f6
Remove unused .Sources packages
2018-07-11 21:36:50 -07:00
a67d9363e2
Consumes endpoint constraint ( #8057 )
2018-07-12 16:35:33 +12:00
e5c501099a
Remove unused .Source packages
2018-07-11 21:33:51 -07:00
385f647215
Allow debug log file to be specified in handler settings; move tests from IISExpress to shared. ( #1033 )
2018-07-11 18:29:36 -07:00
2a454c5aa8
Update js packages
2018-07-11 14:59:55 -07:00
dbc930cc78
ResponseCache attribute on RazorPages Error handler method should be moved to model
...
Fixes #553
2018-07-11 14:50:40 -07:00
672974c25b
Merge fix from release/2.1
2018-07-11 13:18:34 -07:00
d2a8d3a61c
Fix cookie regression ( #1811 )
2018-07-11 13:14:51 -07:00
b2cca31774
Fix issue with role claim missing in AddIdentityCore ( #1832 )
2018-07-11 12:39:51 -07:00
9635d4fd8d
Cleanup compilation warnings and re-enable asserts ( #1035 )
2018-07-11 11:47:22 -07:00
183ecd85d6
Fix MVC integration with UseEndpoint ( #8047 )
2018-07-11 11:47:33 +12:00
a826f478ad
Implement HTTP/2 output flow control ( #2690 )
2018-07-10 14:11:59 -07:00
0ab8e15f05
[ Fixes #1866 ] Fix ActivePage declarations
...
* Fix missing activepage declarations
* Change activepage declarations to correct values
* Add missing ActivePage
2018-07-10 13:00:52 -07:00
3e27f18127
Merge branch 'release/2.1' into release/2.2
2018-07-10 12:52:50 -07:00
767b3efa04
Add Brotli compression provider ( #342 )
...
* Added failing test for Brotli compression
* Added Brotli compression provider
* Add Brotli to existing test cases
* Add failing test for accept encoding order
* Use compression provider order when selecting provider
* Some test cleanup
* PR feedback
* Added benchmarks for GetCompressionProvider
* Added Brotli configuration order test
* PR feedback
* Switch Brotli and Gzip priority
2018-07-10 12:44:01 -07:00
51c94337d7
/systray:false ( #1486 )
2018-07-10 11:29:39 -07:00
1d9db7c25f
Merge 2.1.2 into release/2.1
2018-07-10 10:34:35 -07:00
11b83dc2b3
Rename reg keys from IIS ANCM V1 to V2 ( #1017 )
2018-07-10 10:32:01 -07:00
3eae93082f
Merge 2.1.2 into release/2.1
2018-07-10 10:29:05 -07:00
86fed4de5f
Fix shutdown race ( #1031 )
2018-07-10 10:18:32 -07:00
1e7be641ae
Add some common aliases for conventions
...
Fixes #8015
2018-07-09 18:25:29 -07:00
f7936ac062
Finish up appoffline refactoring ( #1018 )
2018-07-09 16:17:33 -07:00
0812279464
Merge branch 'release/2.1' into kichalla/21.to.22.mergecommit
...
# Conflicts:
# build/dependencies.props
# korebuild-lock.txt
# src/Microsoft.AspNetCore.Mvc.ApiExplorer/DefaultApiDescriptionProvider.cs
# test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ApiBehaviorApplicationModelProviderTest.cs
# version.props
2018-07-09 13:00:10 -07:00
bd995d4cb1
[ Fixes #7959 ] Conventional routing with custom templates not working when you have area attributes
2018-07-09 12:35:14 -07:00
dc2ae93c3f
Add fallback attribute to partial tag helper.
...
Addresses #7515
2018-07-09 12:24:26 -07:00
dee479fda7
Add partial helper to Razor Page \ PageModel
...
Fixes #7885
2018-07-09 11:01:15 -07:00
d2bb674b0a
Add support for default response ( #8028 )
...
* Add support for default response
Fixes #6828
2018-07-06 16:44:07 -07:00
ce4780a830
Renamed symbol to token everywhere
...
- Updated Resources
- Updated test code
- Regenerated baselines
- Added exclusions for apicheck (See https://github.com/aspnet/BuildTools/issues/704 )
2018-07-06 16:29:36 -07:00
99ec23097e
Merge pull request #1015 from aspnet/pakrym/flush-sync
...
Sync native calls
2018-07-06 15:09:46 -07:00
5f02de1e2c
Test
2018-07-06 14:43:33 -07:00
c1fb4479a3
Update LZMA to restore netcoreapp2.2 packages
2018-07-06 13:45:30 -07:00
9276602279
Merge branch 'release/2.1' into release/2.2
2018-07-06 13:43:43 -07:00
bf03fee4be
Refactor LZMA generation to support Docker and Antares usage
...
List explicitly as .csproj files the scenarios for which the offline package cache is important
Produces new artifacts designed for various scenarios, such as:
* Docker (where xml doc files are not needed)
* Azure web apps (where 1.x SDKs must still be supported, but xml docs are not needed)
2018-07-06 13:15:23 -07:00
748e992865
Dygray/handshake versioning ( #2520 )
...
* set minor versions on the protocols
2018-07-05 16:42:42 -07:00
36ea388e9b
Remove doc about unshipped default configuration ( #274 )
2018-07-05 16:13:28 -07:00
fa702ff6ef
Update AddSignalRCore to respect user registered services ( #2434 )
2018-07-05 12:52:33 -07:00
2af13658fc
Unprotect key material with the local cache of certificates before checking the cert store
...
In some cases, private keys for certificates is not completely available. When attempting to decrypt key material,
this can cause 'CryptographicException: Keyset does not exist'. This changes the order in which key material
decryption looks up private keys to first key the certificate options provided explicitly to the API, and then
falling back to the cert store for decryption keys.
2018-07-05 11:31:46 -07:00
73867a086c
IIS-Inproc new project cap ( #1238 )
2018-07-05 10:10:39 -07:00
b280597c68
fb
2018-07-05 09:01:47 -07:00
263e369b2e
Merge branch 'release/2.1' into release/2.2
2018-07-03 17:21:16 -07:00
e7db3f840b
Handle pipe name with whitespace properly
2018-07-03 16:55:55 -07:00
727bd52b64
Add package version to Microsoft.AspNetCore.App in project templates
...
As discussed in aspnet/Home#3292 , we're reversing course on the implicit package version feature. This adds a package version for Microsoft.AspNetCore.App to the `dotnet new` and VS templates.
2018-07-03 16:53:46 -07:00
724cc3ce88
Only run fallback logic for dotnet and dotnet.exe ( #1004 )
2018-07-03 16:49:24 -07:00
3bdb33ccd4
Sync native calls
2018-07-03 16:46:39 -07:00
3efc1eede4
Set correct event providers for ANCM V2 ( #1009 )
2018-07-02 18:21:22 -07:00
9b7ee92028
Check thread invalid handle and remove extra dup2 call. ( #1008 )
2018-07-02 17:18:05 -07:00
dfd75e939d
Add full IIS tests ( #979 )
2018-07-02 12:15:15 -07:00
335500ab0e
Use ModelMetadata from actual types for validation
...
Fixes https://github.com/aspnet/Mvc/issues/7952
2018-07-02 11:23:16 -07:00
c2fcfabdf3
Add optional property to PartialTagHelper ( #7991 )
...
* Add optional to PartialTagHelper
Addresses #7268
2018-06-29 16:02:38 -07:00
f6befb9ed3
Added ObjectResult implementation for Unauthorized response
2018-06-29 14:27:34 -07:00
133d49c57e
Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute
2018-06-29 13:55:30 -07:00
7f2a64e32b
Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
...
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies
Fixes #7969
2018-06-29 13:55:22 -07:00
65d3787fc4
Pass parameters to createapplication method ( #998 )
2018-06-29 12:42:00 -07:00
82f7f2aab8
Fix Api Explorer not returning type with ActionResult<T> and no type in ProducesResponseTypeAttribute
2018-06-29 12:00:16 -07:00
2d5a1737a2
Update Razor SDK packing logic to not include Pack at properties layer.
...
- Added test to verify that no-build scenarios work as expected.
#2378
2018-06-29 11:45:59 -07:00
c4d5ef94a9
Razor runtime compilation produces errors if running on a shared runtime that's rolled forward
...
Do not provide compilation references from runtime MVC assemblies. This avoids cases where the app is compiled
against an older MVC but running against a newer one (e.g. shared fx roll forward) resulting in compiling against multiple
versions of MVC assemblies
Fixes #7969
2018-06-29 11:17:25 -07:00
dfed3d7563
Add and use GetEnvironmentVariableValue ( #997 )
2018-06-29 11:17:22 -07:00
9273759dca
[2.1]: Remove unused project capability from Microsoft.AspNetCore.App ( #1237 )
...
Removing this from .App in 2.1.3 because this was unused, and the capability is not actually supported by VS. This will be re-added in the future versions of .App when we land the VS integration for in-process hosting.
cref https://github.com/aspnet/IISIntegration/pull/969
2018-06-29 11:02:39 -07:00
f5f0988baf
Make handlerSettings optional ( #989 )
2018-06-29 08:44:03 -07:00
54c14b8782
Reacting to Routing repo's EndpointFinder changes
2018-06-28 12:40:04 -07:00
b84a233d39
Add ability to print debug logs to a file ( #954 )
2018-06-28 11:52:53 -07:00
2ab22ac55a
Merge branch 'release/2.1' into dev
2018-06-28 11:27:11 -07:00
1009705283
Added a RouteValuesBasedEndpointFinder
2018-06-28 10:53:10 -07:00
ac31e5ab30
[2.1.3] Consistently handle connection aborts ( #2619 )
...
* Decouple connection objects from the server (#2535 )
- Making progress towards being able to use the connection objects on the client side.
* Wait for input writer to complete before calling OnConnectionClosed (#2566 )
* Wait for the ConnectionClosed token to stop tracking connections (#2574 )
- The prior strategy of waiting for the pipe completed callbacks doesn't work
because blocks are returned to the memory pool after the callbacks are fired.
* Consistently handle connection resets (#2547 )
* Provide better connection abort exceptions and logs
* void IConnectionDispatcher.OnConnection
2018-06-28 10:51:22 -07:00
4a09d4795e
Use HandleWrapper and initialize variables for FileOutputManager ( #986 )
2018-06-28 09:09:34 -07:00
27780c28ba
Do not override error responses ( #985 )
2018-06-27 22:53:30 -07:00
91a1d2de50
Add unit tests for the shared framework ( #1228 )
...
Changes:
* Add a test project with simple unit tests for the shared framework
* Add root-level Directory.Build.props/targets files
* Cleanup .csproj files to reduce duplication
2018-06-27 14:56:10 -07:00
4dd4e5ef3e
Shorten names so MVC repo can be cloned on Windows benchmarks server
2018-06-27 14:33:31 -07:00
32e0d136f2
Fix null handle issue on full IIS ( #973 )
2018-06-27 11:54:32 -07:00
af1bf0e1c3
caching handlers to avoid heap fregamentation ( #967 )
...
caching handlers to avoid heap fregamentation
2018-06-27 11:46:24 -07:00
d4b8fee39f
Upgraded AngularJS to 6.0
2018-06-27 10:27:39 -07:00
a92089d2f9
Converted CSharpDirectivesTest to use baselines
2018-06-26 15:17:36 -07:00
bc5f02444b
Benchmarks and improvements to route value dictionary ( #577 )
...
* Add benchmarks for RVD
There are the scenarios that are critical for URL matching performance.
* Reimplement RouteValueDictionary
Improves the scenarios with benchmarks by about 30%
* Fix benchmark
* PR feedback
* More feedback and tests
2018-06-26 13:41:49 -07:00
0f4f1950f1
Attempt to make it easier to detect when the request is done ( #1021 )
...
- Today the async local reference to the HttpContext flows when the execution context is captured. When the http request has ended, the HttpContext property will return the reference to an invalid HttpContext instead of returning null. This change stores both the request id and the HttpContext and makes sure both match before returning anything valid.
- This is still racy but should catch more cases of people doing bad things.
- There will still be issue if people store the context in a local and use that reference instead of accessing it through the property getter but we can live with that.
- Set the TraceIdentifier to null in the default HttpContextFactory
- Added tests
2018-06-26 11:49:12 -07:00
e1af5b8b6d
Array or List in query string does not get parsed #7712 ( #7967 )
...
- exclude collections when detecting complex types in `ApiBehaviorApplicationModelProvider`
- add test cases
2018-06-26 11:43:46 -07:00
fac42c78a1
Re-enable flaky logging tests, add logs to output redirection providers, fix potential race condition in closing pipe output. ( #971 )
2018-06-26 11:28:56 -07:00
423d5432be
Add test for ensuring HPACK lowercase header names
...
- ensure lowercase mask only applied to uppercase letters
2018-06-26 10:44:21 -07:00
7101953c1e
Update TagHelperBlockRewriter.cs
2018-06-26 08:24:02 -07:00
331f0b15cd
Update ServerConnection.cs
2018-06-26 07:54:07 -07:00
0d96354eef
Return static 500.30 file on startup fails for in-process ( #934 )
2018-06-25 17:12:30 -07:00
e7e2ca50e9
Ping Cleanup ( #2530 )
...
Tidied up some comments, to make the ResetPing client behavior easier to understand.
Will ping in debug mode for consistency. If this becomes a problem when debugging, developers can disable the pings manually. It's easier to fix something noisy, than try to diagnose inconsistently missing behavior.
2018-06-25 17:09:05 -07:00
4a0691a36c
Remove where.exe timeout ( #970 )
2018-06-25 15:14:59 -07:00
554855cab3
No CORS headers sent if Exception is thrown
...
- Normally headers are added however if a controller throws an exception then CORS headers not be present.
Addresses aspnet/Home#3220
2018-06-25 14:00:30 -07:00
999c24d78d
Converted more parser tests to baselines
...
- Converted CSharpAutoCompleteTest
2018-06-25 11:43:17 -07:00
bc345bc8e7
Reduce usage of static inprocess application ( #962 )
2018-06-25 08:46:16 -07:00
d3d257b90e
Add tracing to shimconfig ( #964 )
2018-06-25 08:44:02 -07:00
aeebcdefc1
Switch to tracing macros in application info ( #965 )
2018-06-25 08:38:46 -07:00
94a7c83998
Change DefaultApiConventions ( #7939 )
...
* Change DefaultApiConventions
* Introduce attributes for matching by name and type.
* Move discovery of ApiConventionAttribute to ApiBehaviorApplicationModelProvider. This is required
for us to detect during startup if the convention is incorrectly authored.
2018-06-25 08:24:30 -07:00
32121abde3
Fixes exit(0) with hostable webcore ( #966 )
2018-06-22 15:29:28 -07:00
b12c9b33f7
Cleanup where.exe invocation ( #958 )
2018-06-22 07:36:46 -07:00
6911e192e4
Add IsRequired and DefaultValue to ApiParameterDescription
2018-06-22 06:51:58 -07:00
30fcfb65ea
Productionize Path tokenization
2018-06-21 17:13:03 -07:00
306ab78b88
Fix App_offline and start adding tests ( #953 )
2018-06-21 16:35:11 -07:00
6efd679ce3
Fix TreeMatcher with route constraints ( #576 )
2018-06-22 10:33:44 +12:00
cd81cfc243
Remove extra arguments from CreateApplication ( #952 )
2018-06-21 15:29:03 -07:00
e5505ceefc
Fixing build issues ( #957 )
2018-06-21 12:32:13 -07:00
93de3f83ce
Reenable precompiled headers in AspNetCore project ( #937 )
2018-06-21 11:32:56 -07:00
61e16e2b31
Automation for h2spec functional tests #2640
2018-06-21 11:17:16 -07:00
17d2545b55
Throw if the type parameter for ActionResult<T> is an action result ( #7942 )
...
Fixes #7931
2018-06-21 07:51:12 -07:00
77693ccdc5
Use partial tag helper instead of Html.Partial to avoid analyzer warning
2018-06-20 16:51:51 -07:00
ed1fa44a3d
Add diagnostics to hostfxrutil ( #951 )
2018-06-20 16:22:19 -07:00
Mike Harder
Pranav K
Pavel Krymets
Ryan Brandenburg
Justin Kotalik
Doug Bunting
Stephen Halter
tiago-soczek
Daniel A. White
Chris Ross (ASP.NET)
David Fowler
John Luo
Ryan Nowak
James Newton-King
Ben Adams
Rick Anderson
Simon Cropp
BrennanConroy
Glenn Condron
Joni
Sebastian
Nate McMaster
gqqnbig
Nate McMaster
Casey O'Brien
Takaaki Suzuki
N. Taylor Mullen
Hassan Hashemi
Javier Calvarro Nelson
Kristian Hellang
Hao Kung
dan.s.ward
Patrick Westerhoff
Gert Driesen
Massimiliano Donini
Matt Ward
Christer van der Meeren
Kiran Challa
Thomas Levesque
Wilson
kishanAnem
Marcin Burak
Ryan Nowak
Günther Foidl
Mike Lorbetske
Artak
Kiran Challa
Artak Mkrtchyan
Wraptor
Ajay Bhargav Baaskaran
Mikael Mengistu
Sourabh Shirhatti
Sindhudweep Sarkar
Alexej Timonin
kishan.anem
Remco
Tim Hess
Anthony Stivers
hishamco
Dylan Dmitri Gray
Zbginiew Dobras
Nathanael Marchand
pan-wang
Daniel Eisterhold
Daniel Little