MikaelMengistu
83b5abbfcd
Merge branch 'release/2.2'
2018-10-16 14:39:02 -07:00
David Fowler
defbadb26b
Various timer cleanup ( #3129 )
...
This change does 2 things:
- It disables the websocket keep alive since SignalR has its own bidirectional pings. This should remove a significant timer overhead per WebSocket connection that we end up with today. We have a single timer that sends to all connection on an interval.
- Don't pass the CancellationToken to ReadAsync in the handshake since the Pipe implementation holds onto the token for longer than it
needs to which keeps Timer objects alive (see dotnet/corefx#32806 )
I found this when reading the source code and looking at dumps of a couple of SignalR applications.
2018-10-13 11:43:20 -07:00
BrennanConroy
af62105cc6
Merge branch 'release/2.2'
2018-10-11 10:25:47 -07:00
BrennanConroy
286e4bebf7
Add StackExchange.Redis 2.X.X package ( #3089 )
2018-10-10 16:40:27 -07:00
MikaelMengistu
c6a1c7463a
Merge branch 'release/2.2'
2018-10-01 16:19:06 -07:00
Brian Chavez
78a0a68cd1
Typos/spelling errors in XML doc comments and source. #Hacktoberfest ( #3039 )
2018-10-01 14:41:05 -07:00
BrennanConroy
370702f1a2
Merge pull request #3023 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-09-27 21:41:42 -07:00
BrennanConroy
1f91b523f7
Add error to negotiate ( #2998 )
2018-09-27 20:27:06 -07:00
MikaelMengistu
a260d44fe2
Merge branch 'release/2.2'
2018-09-26 12:37:17 -07:00
BrennanConroy
4dfd93c1d7
[TS] Wait for handshake response ( #2983 )
2018-09-20 14:23:43 -07:00
MikaelMengistu
a2e5e8755f
Merge branch 'release/2.2'
2018-09-20 13:48:33 -07:00
BrennanConroy
f0a34a4ca4
Clone Windows Identity in LongPolling connections ( #2985 )
2018-09-20 13:39:25 -07:00
BrennanConroy
e683b81dfe
Merge branch 'release/2.2'
2018-09-20 12:29:13 -07:00
BrennanConroy
6ba5e87b45
Allow CancellationToken in streaming hub methods ( #2818 )
2018-09-19 15:21:07 -07:00
BrennanConroy
8be051ce34
Idempotentize AddSignalR ( #2972 )
2018-09-19 13:39:34 -07:00
BrennanConroy
7af3472ef4
Merge pull request #2950 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-09-14 11:37:05 -07:00
David Fowler
48b3f18642
Improve the handshake request parsing errors ( #2953 )
...
- Print out the raw handshake payload as utf8 text if it fails to parse as JSON or if we're missing properties. This should help flesh out potentially buggy clients.
2018-09-13 22:11:17 -07:00
BrennanConroy
b423313e5c
Merge branch 'release/2.2'
2018-09-12 09:48:39 -07:00
BrennanConroy
8dffc68cea
Cancel previous request on close ( #2923 ) ( #2942 )
2018-09-11 15:50:00 -07:00
BrennanConroy
adc5706bcb
Add more redis logs ( #2936 )
2018-09-10 11:51:27 -07:00
Andrew Stanton-Nurse
5092cc3115
Merge pull request #2929 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-09-07 19:19:27 -07:00
Ben Adams
db99baac35
Don't capture AsyncLocals onto Timers ( #2904 )
2018-09-07 14:08:08 -07:00
BrennanConroy
23154629a9
Merge branch 'release/2.2'
2018-09-06 09:41:00 -07:00
BrennanConroy
f42f4c56e6
Initialize HttpConnectionManager before registering callbacks ( #2878 )
2018-08-30 14:42:16 -07:00
BrennanConroy
9d4c76c173
Merge pull request #2850 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-08-22 13:49:05 -07:00
BrennanConroy
f8a46faf9d
Detect ASP.NET SignalR server connection attempt ( #2820 )
2018-08-22 11:17:04 -07:00
BrennanConroy
db3f3f2a53
Tweak some Redis log levels ( #2838 )
2018-08-22 10:35:43 -07:00
unknown
f62f96eb37
Merge branch 'release/2.2'
2018-08-10 11:23:46 -07:00
BrennanConroy
b82fcc0b21
log when WebSocketTransport has started ( #2752 )
2018-08-10 09:49:17 -07:00
unknown
d32a5c14e1
Merge branch 'release/2.2'
2018-08-08 18:06:19 -07:00
BrennanConroy
a550ae6cc3
Provide a better error message when invoking a non-existant hub method ( #2768 )
2018-08-08 15:55:33 -07:00
BrennanConroy
2265acde78
Don't start stream if already canceled ( #2764 )
2018-08-08 14:04:05 -07:00
Andrew Stanton-Nurse
556a234c45
Merge pull request #2755 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-08-08 08:17:40 -07:00
David Fowler
5e7f63b096
Make un-graceful shutdown a bit more graceful ( #2748 )
...
* Make un-graceful shutdown a bit more graceful
- Change how graceful shutdown is done to ensure there are no errors on shutdown.
- Avoid closing pipes from under other components that own those pipes.
- Close the application output so that the application's read loop ends gracefully. For websockets, we cancel the token, for other transports, we close the output directly.
2018-08-07 21:39:09 -07:00
BrennanConroy
cba79d1687
Merge branch 'release/2.2'
2018-08-07 10:56:03 -07:00
BrennanConroy
e403de7fbf
Solve LongPolling races by moving Cts disposal to connection disposal ( #2731 )
2018-08-06 19:17:29 -07:00
unknown
beb546e8df
Merge branch 'release/2.2'
2018-08-06 11:07:16 -07:00
BrennanConroy
e78e3db6f4
Honor InherentKeepAliveFeature for server timeout ( #2727 )
2018-08-06 10:37:12 -07:00
Andrew Stanton-Nurse
d709fa62b9
Merge pull request #2719 from dotnet-maestro-bot/merge/release/2.2-to-master
...
[automated] Merge branch 'release/2.2' => 'master'
2018-08-03 10:59:01 -07:00
BrennanConroy
810c7cf9ad
Fix ODE race with cancellationtokensource ( #2721 )
2018-08-02 15:24:26 -07:00
BrennanConroy
90606338fb
Log when closing connection due to timeout ( #2722 )
2018-08-02 15:21:24 -07:00
Dylan Dmitri Gray
76706144a5
Add support for streaming arguments to clients using Channel ( #2441 )
2018-08-01 09:31:43 -07:00
BrennanConroy
d7c696f51f
Merge branch 'release/2.2'
2018-07-31 16:44:50 -07:00
BrennanConroy
c8eedb3540
Fix race when connection is canceled and new poll comes in ( #2697 )
2018-07-31 16:36:54 -07:00
BrennanConroy
651b39bc90
Revert "Merge branch 'master' into release/2.2"
...
This reverts commit 785200877a , reversing
changes made to 3d6e1e69fd .
2018-07-31 15:24:33 -07:00
Mikael Mengistu
785200877a
Merge branch 'master' into release/2.2
2018-07-31 10:22:09 -07:00
BrennanConroy
3d6e1e69fd
Close LongPolling connection on poll exception ( #2701 )
2018-07-31 09:52:10 -07:00
BrennanConroy
34a7fc4d99
Merge branch 'merge/release/2.2-to-master'
2018-07-25 11:45:32 -07:00
BrennanConroy
433eeb6943
Abort connection on protocol error ( #2654 )
2018-07-19 14:50:14 -07:00
Dylan Dmitri Gray
748e992865
Dygray/handshake versioning ( #2520 )
...
* set minor versions on the protocols
2018-07-05 16:42:42 -07:00