Commit Graph

17623 Commits

Author SHA1 Message Date
N. Taylor Mullen 44431151c7 Revert "Addressed code review comments."
This reverts commit 479d5ed40a.
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 18391dd2e4 Revert "Clear route values after middleware invocation."
This reverts commit c54a7209d7.
2019-08-13 13:27:36 -07:00
Steve Sanderson e8917fc92f [Blazor][Fixes #13056] Renderer use-after-disposal tweaks
* Improves Renderer handling use after disposal.
* Ensures RemoteRenderer skips resuming the render queue after ACK if it was since disposed
2019-08-13 21:51:39 +02:00
Pranav K 9bd027aa99
Make Partial on PageBase and PageModel work correctly (#13013)
* Make Partial on PageBase and PageModel work correctly

Fixes https://github.com/aspnet/AspNetCore/issues/10438
2019-08-13 12:49:10 -07:00
Pranav K c80f7d1dd9
Remove LangVersion from server-side Blazor project template (#13094)
Fixes https://github.com/aspnet/AspNetCore/issues/9168
2019-08-13 12:33:23 -07:00
Steve Sanderson 6b2d9f23f8
Prerender select elements with value; move HtmlRenderer into Mvc.ViewFeatures (#12996) 2019-08-13 09:34:28 +01:00
Javier Calvarro Nelson 826ed7504b
[ApiAuthorization] Update to latest oidc-client and IdentityServer4 versions
[ApiAuthorization] Updates dependency versions
* Updates to the latest version of Identity Server.
* Updates to the latest version of oidc-client.
* Removes unncessary code from the templates.
* Updates EF migrations.
* Removes unnecessary ref assembly.
2019-08-13 08:53:41 +02:00
Brennan eb966eb605
Complete upload streams on connection close (#13065) 2019-08-12 20:46:20 -07:00
Ryan Nowak 1f4341a248 Add 'firstTime' parameter to OnAfterRender
Fixes: #11610

I took the approach here of building this into `ComponentBase` instead
of `IHandleAfterRender` - *because* my reasoning is that `firstTime` is
an opinionated construct. There's nothing fundamental about `firstTime`
that requires tracking by the rendering, it's simply an opinion that
it's going to be useful for component authors, and reinforces a common
technique.

Feedback on this is welcome.
2019-08-12 18:35:39 -07:00
Ryan Nowak 29cf7ecb80 Remove Blazor VSIX
This is no longer shipped, because the templates installed by `dotnet
new -i` show up in VS now. Removing it now so we don't have to keep it
around in servicing forever.
2019-08-12 18:32:02 -07:00
Steve Sanderson a4ab9ffa05 Factor out auth and forms. Fixes #12950 (#12999)
* Add empty Authorization src and test projects

* Add references

* Move auth types into .Authorization project

* Move auth tests

* Fix Mvc.ViewFeatures

* Remove the reference from .Web to .Authorization, so it's truly optional

* Add empty Forms src and test projects

* Remove dependencies from Components.csproj

* Move forms sources and tests

* Reference .Forms from .Web (needed unless we also have .Forms.Web)

* Rebase on #12936

* Update reference assemblies

* CR: Add Authorization namespace

* Update ref sources

* Add missing using

* Add another missing using
2019-08-12 16:36:27 -07:00
Steve Sanderson c6f043cb98
Update Mono debug proxy code (#13053)
This is now equivalent to Mono's commit 612e064 and to the Mono binaries that we'll include in Preview 9
2019-08-12 17:10:30 +01:00
Brennan 7b7c13c0d5
Try to make test more reliable (#12989) 2019-08-11 20:23:18 -07:00
Ryan Nowak 5d4c4d648f Make WaitAssert report browser errors
It turns out we frequently have errors in the browser console in cases
where we're hitting a "timeout".
2019-08-11 10:49:14 -07:00
Ryan Nowak ab006e10b0 Harden ArrayBuilder
Since we're using the ArrayPool, it's really essential that we prevent
use-after-free bugs. I'm currently tracking one down.
2019-08-11 10:49:14 -07:00
Ryan Nowak 89bf58445f Use a ConcurrentDictionary
This is used from a bunch of static methods. Dictionary isn't thread
safe. Encountered this while debugging some other things.
2019-08-11 10:49:14 -07:00
Ryan Nowak 9b4ec6ec71 Add semaphore to selenium tests
This change prevents thread pool starvation when running a bunch of
selenium-based tests, by turning the blocking wait for a WebDriver to
start into an async wait.

This also seems to help with speed, and reliability since we're not
running too many browsers at once. I was experencing timeouts, and
seeing them in the debugger while running tests locally, this no longer
happens.
2019-08-11 10:49:14 -07:00
Ryan Nowak 18f5ec71ed Terminate circuit on error
Fixes: #11845

See: https://github.com/aspnet/AspNetCore/pull/12857 for detailed notes.
2019-08-11 10:49:14 -07:00
John Luo 88a3a74dbb
Multitarget packages to remove dependencies for source build (#12936) 2019-08-09 19:25:48 -07:00
Mikael Mengistu 8ef285620c
Remove references to OnReaderCompleted and OnWriterCompleted (#13018) 2019-08-09 19:04:33 -07:00
Pratik Sanglikar 09db3ebbae Enable Docker Support checkbox for Blazor Server apps and gRPC apps. (#13016)
* Enable the checkbox "Add Docker Support" for Blazor apps. 

Enable the checkbox "Add Docker Support" for Blazor apps.

* Enable "Enable Docker Support" checkbox for gRPC projects. 

Enable "Enable Docker Support" checkbox for gRPC projects.
2019-08-09 18:55:52 -07:00
Daniel Roth 920d8018e8
Update Blazor survey link for preview 9 (#13008) 2019-08-09 14:44:19 -07:00
Ryan Brandenburg 391806283a
Don't serve angular static files in dev mode (#12885)
Don't serve angular static files in dev mode
2019-08-09 14:30:46 -07:00
Ryan Brandenburg afcfeaf0ac
Improve template Accessibility (#12891)
Add aria-label to table to give title
2019-08-09 14:25:25 -07:00
Ryan Brandenburg 14f17fa7cd
Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.No… (#12892)
Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.NodeServices
2019-08-09 13:47:51 -07:00
Ryan Brandenburg 3ab8ebff42
Extend timeout and enforce usings (#12952)
Extend timeout and enforce usings
2019-08-09 13:38:09 -07:00
Doug Bunting b1fdf27f61 Clean up #12854 a bit
- remove incorrect comment
- do not completely overwrite `$(RestoreAdditionalProjectSources)` values
2019-08-09 12:07:54 -07:00
Stephen Halter 92977140ac
Timeout all top-level awaits in TestUnixDomainSocket (#12986) 2019-08-09 11:40:38 -07:00
Chris Ross 6e25a9fc53
Granular error handling for Negotiate #12566 (#12958) 2019-08-09 11:28:39 -07:00
Pranav K dda84bc7fc
Use TValue as the generic type parameter (#12953)
* Use TValue as the generic type parameter

Fixes https://github.com/aspnet/AspNetCore/issues/12926
2019-08-09 10:19:33 -07:00
Brennan ecd6c11c46
Remove unused SignalR benchmarks app (#12954) 2019-08-09 09:14:12 -07:00
Justin Kotalik 8dd3cd4129
Merge pull request #12877 from dotnet-maestro-bot/merge/release/3.0-preview8-to-release/3.0
[automated] Merge branch 'release/3.0-preview8' => 'release/3.0'
2019-08-09 08:37:19 -07:00
Javier Calvarro Nelson 5c71742e4a
[Identity] Add warnings when using Bootstrap3 and errors when using an unknown framework version (#12988)
* [Identity] Add warnings when using Bootstrap3 and errors when using an unknown framework version
2019-08-09 15:56:09 +02:00
Mikael Mengistu e4b4476b37
Add test for canceling start in transport (#12846) 2019-08-08 20:14:56 -07:00
Justin Kotalik a00bafd70f
Fix retries with port selection (#12984) 2019-08-08 16:28:34 -07:00
Steve Sanderson d716ca9d62
Remove .Web IVTs and refactor. Fixes #12713 (#12967)
* Remove IVTs from Microsoft.AspNetCore.Components.Web to .Blazor/.Server

* Eliminate RendererRegistry from .Web, as it's not needed for server-side Blazor

* Reintroduce RendererRegistry as a WebAssembly-specific concept. Refactor event data parsing.

* Remove redundant guard

* Corresponding test updates

* Update ref sources

* CR: Remove renderer ID fully from server-side Blazor code

* CR: Make WebEventData internal and shared-source

* Hub test updates

* Clean whitespace

* Update binaries

* Regenerate binaries AGAIN

* Update Jest test

* CR: Replace constructor with static parse

* Yet again attempt to refresh the .js binaries

* Fix ref assembly

* Fix test
2019-08-09 00:03:40 +01:00
Ryan Nowak fc2d3e588f Fix dynamic routes with no route values
Fixes: #12915

This was just missing a null check.

Also added unit tests that were missing for these types.
2019-08-08 14:38:59 -07:00
Brennan 5adeaddfe6
Test ValueTask hub methods (#12898) 2019-08-08 14:04:43 -07:00
Brennan bd01c67e88
Add test for supported scenario (#12931) 2019-08-08 14:04:16 -07:00
Justin Kotalik 0574a3fc94 Merge branch 'release/3.0-preview8' into release/3.0 2019-08-08 13:35:15 -07:00
Stephen Halter 55632872eb Timeout all top-level awaits in TestUnixDomainSocket 2019-08-08 13:21:58 -07:00
Justin Kotalik c6e1bcb66c
Fix Max Request Body Size test (#12981) 2019-08-08 13:17:36 -07:00
Artak 4ca819ec99
Update localized strings for templates (#12927) (#12982) 2019-08-08 12:55:09 -07:00
Pranav K d6d4bb2772
Ensure IFormFile binding for nested properties works (#12847)
* Ensure IFormFile binding for nested properties works

Fixes https://github.com/aspnet/AspNetCore/issues/9510
2019-08-08 12:28:54 -07:00
Steve Sanderson 3bd838f9d4 Making InteropReliabilityTests as flaky 2019-08-08 11:37:58 +01:00
Steve Sanderson ebd02cdb71 Fix building Components solution in VS 2019-08-08 11:37:58 +01:00
Ryan Brandenburg 22df034ae6 Allow retries of SSL exceptions 2019-08-07 10:41:49 -07:00
Javier Calvarro Nelson 1b477405ca
[Blazor][Fixes #12940] Make interop tests timeouts more conservative to fix flakiness.
Increases the implicit timeout for each operation from 500 milliseconds to 5 seconds.
2019-08-07 17:41:28 +02:00
Javier Calvarro Nelson 25c240bef5
[Blazor] Graceful disconnection
* Adds a new API endpoint to trigger graceful disconnection from blazor clients.
* Uses the sendBeacon API on the Blazor client to trigger graceful disconnections on the client when the document gets unloaded, which happens when closing the window, navigating away from the page or refreshing the page.
2019-08-07 17:40:02 +02:00
Steve Sanderson 92869c677f
Revalidating auth improvement. Fixes #12692 (#12909) 2019-08-07 15:15:26 +01:00