huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
39,689 Commits 1 Branch 0 Tags 251 MiB
Commit Graph

17725 Commits

Author SHA1 Message Date
Pratik Sanglikar 09db3ebbae Enable Docker Support checkbox for Blazor Server apps and gRPC apps. (#13016) 
* Enable the checkbox "Add Docker Support" for Blazor apps. 

Enable the checkbox "Add Docker Support" for Blazor apps.

* Enable "Enable Docker Support" checkbox for gRPC projects. 

Enable "Enable Docker Support" checkbox for gRPC projects.
 2019-08-09 18:55:52 -07:00
Justin Kotalik 8c02467b4a
Merge pull request #13007 from dotnet-maestro-bot/merge/release/3.0-to-master 
[automated] Merge branch 'release/3.0' => 'master'
 2019-08-09 17:41:48 -07:00
Daniel Roth 920d8018e8
Update Blazor survey link for preview 9 (#13008) 2019-08-09 14:44:19 -07:00
Ryan Brandenburg 391806283a
Don't serve angular static files in dev mode (#12885) 
Don't serve angular static files in dev mode
 2019-08-09 14:30:46 -07:00
Ryan Brandenburg afcfeaf0ac
Improve template Accessibility (#12891) 
Add aria-label to table to give title
 2019-08-09 14:25:25 -07:00
Ryan Brandenburg 14f17fa7cd
Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.No… (#12892) 
Obsolete Microsoft.AspNetCore.SpaServices and Microsoft.AspNetCore.NodeServices
 2019-08-09 13:47:51 -07:00
Ryan Brandenburg 3ab8ebff42
Extend timeout and enforce usings (#12952) 
Extend timeout and enforce usings
 2019-08-09 13:38:09 -07:00
Doug Bunting b1fdf27f61 Clean up #12854 a bit 
- remove incorrect comment
- do not completely overwrite `$(RestoreAdditionalProjectSources)` values
 2019-08-09 12:07:54 -07:00
Stephen Halter 92977140ac
Timeout all top-level awaits in TestUnixDomainSocket (#12986) 2019-08-09 11:40:38 -07:00
Chris Ross 6e25a9fc53
Granular error handling for Negotiate #12566 (#12958) 2019-08-09 11:28:39 -07:00
Pranav K dda84bc7fc
Use TValue as the generic type parameter (#12953) 
* Use TValue as the generic type parameter

Fixes https://github.com/aspnet/AspNetCore/issues/12926
 2019-08-09 10:19:33 -07:00
Brennan ecd6c11c46
Remove unused SignalR benchmarks app (#12954) 2019-08-09 09:14:12 -07:00
Isaac Levin c53e177ea3
Update SpaTemplateTestBase.cs 2019-08-09 12:01:33 -04:00
Justin Kotalik 8dd3cd4129
Merge pull request #12877 from dotnet-maestro-bot/merge/release/3.0-preview8-to-release/3.0 
[automated] Merge branch 'release/3.0-preview8' => 'release/3.0'
 2019-08-09 08:37:19 -07:00
Javier Calvarro Nelson 5c71742e4a
[Identity] Add warnings when using Bootstrap3 and errors when using an unknown framework version (#12988) 
* [Identity] Add warnings when using Bootstrap3 and errors when using an unknown framework version
 2019-08-09 15:56:09 +02:00
Mikael Mengistu e4b4476b37
Add test for canceling start in transport (#12846) 2019-08-08 20:14:56 -07:00
Justin Kotalik a00bafd70f
Fix retries with port selection (#12984) 2019-08-08 16:28:34 -07:00
Steve Sanderson d716ca9d62
Remove .Web IVTs and refactor. Fixes #12713 (#12967) 
* Remove IVTs from Microsoft.AspNetCore.Components.Web to .Blazor/.Server

* Eliminate RendererRegistry from .Web, as it's not needed for server-side Blazor

* Reintroduce RendererRegistry as a WebAssembly-specific concept. Refactor event data parsing.

* Remove redundant guard

* Corresponding test updates

* Update ref sources

* CR: Remove renderer ID fully from server-side Blazor code

* CR: Make WebEventData internal and shared-source

* Hub test updates

* Clean whitespace

* Update binaries

* Regenerate binaries AGAIN

* Update Jest test

* CR: Replace constructor with static parse

* Yet again attempt to refresh the .js binaries

* Fix ref assembly

* Fix test
 2019-08-09 00:03:40 +01:00
Ryan Nowak fc2d3e588f Fix dynamic routes with no route values 
Fixes: #12915

This was just missing a null check.

Also added unit tests that were missing for these types.
 2019-08-08 14:38:59 -07:00
Justin Kotalik e504edb38d Remove merge conflict 2019-08-08 14:12:34 -07:00
Justin Kotalik 0193983327 Merge branch 'release/3.0' 2019-08-08 14:10:43 -07:00
Brennan 5adeaddfe6
Test ValueTask hub methods (#12898) 2019-08-08 14:04:43 -07:00
Brennan bd01c67e88
Add test for supported scenario (#12931) 2019-08-08 14:04:16 -07:00
Justin Kotalik 0574a3fc94 Merge branch 'release/3.0-preview8' into release/3.0 2019-08-08 13:35:15 -07:00
Stephen Halter 55632872eb Timeout all top-level awaits in TestUnixDomainSocket 2019-08-08 13:21:58 -07:00
Justin Kotalik c6e1bcb66c
Fix Max Request Body Size test (#12981) 2019-08-08 13:17:36 -07:00
Artak 4ca819ec99
Update localized strings for templates (#12927) (#12982) 2019-08-08 12:55:09 -07:00
Pranav K d6d4bb2772
Ensure IFormFile binding for nested properties works (#12847) 
* Ensure IFormFile binding for nested properties works

Fixes https://github.com/aspnet/AspNetCore/issues/9510
 2019-08-08 12:28:54 -07:00
Phil Henning 2e0cf080df Update localized strings for templates (#12927) 2019-08-08 10:00:21 -07:00
Steve Sanderson 3bd838f9d4 Making InteropReliabilityTests as flaky 2019-08-08 11:37:58 +01:00
Steve Sanderson ebd02cdb71 Fix building Components solution in VS 2019-08-08 11:37:58 +01:00
dotnet-maestro[bot] c79002bf38
[master] Update dependencies from aspnet/AspNetCore-Tooling (#12941) 
* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190806.4

- Microsoft.NET.Sdk.Razor - 5.0.0-alpha1.19406.4
- Microsoft.CodeAnalysis.Razor - 5.0.0-alpha1.19406.4
- Microsoft.AspNetCore.Razor.Language - 5.0.0-alpha1.19406.4
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 5.0.0-alpha1.19406.4

* React to RenderTreeBuilder namespace change
 2019-08-07 20:14:57 +00:00
Ryan Brandenburg 22df034ae6 Allow retries of SSL exceptions 2019-08-07 10:41:49 -07:00
Javier Calvarro Nelson 1b477405ca
[Blazor][Fixes #12940] Make interop tests timeouts more conservative to fix flakiness. 
Increases the implicit timeout for each operation from 500 milliseconds to 5 seconds.
 2019-08-07 17:41:28 +02:00
Javier Calvarro Nelson 25c240bef5
[Blazor] Graceful disconnection 
* Adds a new API endpoint to trigger graceful disconnection from blazor clients.
* Uses the sendBeacon API on the Blazor client to trigger graceful disconnections on the client when the document gets unloaded, which happens when closing the window, navigating away from the page or refreshing the page.
 2019-08-07 17:40:02 +02:00
Steve Sanderson 92869c677f
Revalidating auth improvement. Fixes #12692 (#12909) 2019-08-07 15:15:26 +01:00
Ryan Nowak 15e4b605eb
Blazor API Review: RenderTree types (#12869) 
* Add analzyer for pubternal

This is based on some existing code from EF. I'm having a discussion
with them right now on the best way to share this logic.

I also added support for parameters here which was missing. We might
want to make this code converge with `BannedApiAnalyzer` which is much
more thorough than this.

This is using our existing package for testing analyzers thats the
*official* way to do it in our repo. Filed #12868 to track that.

* Add S C A R Y warnings to render tree types

* PR feedback
 2019-08-06 22:41:02 -07:00
Pranav K 7e59a26846
Ignore line-ending differences in test (#12921) 2019-08-06 15:01:26 -07:00
Steve Sanderson 08349aba69
Ensure render batches aren't started from inside each other (#12917) 2019-08-06 22:40:02 +01:00
dotnet-maestro[bot] 594916344d [release/3.0] Update dependencies from 4 repositories (#12854) 
* Update dependencies from https://github.com/dotnet/arcade build 20190804.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19404.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19404.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19404.1

* React to RenderTreeBuilder namespace change

* Correct builds and tests needing additonal feeds
- use `$(RestoreAdditionalProjectSources)` properties instead of generated NuGet.config files
  - this is closer to the previous approach but avoids `$(RestoreSources)` for the common feeds
  - also remove few remaining `$(RestoreSources)` mentions from SiteExtension.targets
- no need to copy NuGet.config or add feeds in dotnet-watch tests
  - test projects restore within the repo (not in `$env:Temp`) and need no additional feeds

nits:
- $(NuGetConfigFile) hack in eng\Workarounds.props was getting in the way of previous approach and wasn't necessary

* Update dependencies from https://github.com/aspnet/Blazor build 20190805.1
- Microsoft.AspNetCore.Blazor.Mono - 3.0.0-preview9.19405.1

* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190805.6
- Microsoft.NET.Sdk.Razor - 3.0.0-preview9.19405.6
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview9.19405.6
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview9.19405.6
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview9.19405.6

* Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190805.13
- Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview9.19405.13
- dotnet-ef - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview9.19405.13
- Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview9.19405.13

Dependency coherency updates
- Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Binder - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Ini - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Json - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration.Xml - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Configuration - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DependencyInjection - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Hosting - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Http - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Localization - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Configuration - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Console - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Debug - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventSource - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.EventLog - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging.Testing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ObjectPool - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Options - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Primitives - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.WebEncoders - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Internal.Extensions.Refs - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.JSInterop - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Mono.WebAssembly.Interop - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Logging - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Internal.AspNetCore.Analyzers - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.Testing - 3.0.0-preview9.19405.2 (parent: Microsoft.EntityFrameworkCore)

* !fixup! close tag properly
 2019-08-06 11:05:09 -07:00
Justin Kotalik 94856d049f
Use target architecture for building ANCM symbol packages. (#12816) 2019-08-06 10:57:06 -07:00
Beffyman e7398ca25d Blazor _LinkBlazorApplication changed to use DOTNET_HOST_PATH (#12849) 
* change to use host path

* default to path dotnet in cases where it is using desktop msbuild
 2019-08-06 07:51:37 -07:00
Ryan Nowak 2b0a1686c3
Improve SetParametersAsync docs (#12826) 
* Improve SetParametersAsync docs

Fixes: #12820

* Clarify semantics of clashing cascading parameters

This change attempts to lock down the semantics of how cascading
parameters behave inside ParameterView.SetParameterProperties.

Previously a cascading value could be used to set a non-cascading
parameter, and vice-versa. We were just missing tests in general for how
cascading values are interpreted by the parameter set logic.
 2019-08-06 07:37:49 -07:00
Javier Calvarro Nelson 31cfa2e305
[Blazor][Fixes #11964] Limit the amount of pending renders (#12763) 
[Blazor][Fixes #11964] Limit the amount of pending renders
* Adds a default limit of 10 queued pending renders per application.
* Stops producing new render batches after that limit is hit.
* Resumes producing render batches as soon as the client acknowledges a batch.
 2019-08-06 16:22:07 +02:00
John Luo 43350b57b9
Revert "Revert "Improve components infrastructure (#12145)" (#12679)" (#12744) 
* Revert "Revert "Improve components infrastructure (#12145)" (#12679)"

This reverts commit e2d57e2806. The improvement to components infrastructure is now reinstated with the following changes:

* Check in release JS artifacts and use them as a fallback when it's not possible to build npmproj.
* Dont' build nodejs in source build.
 2019-08-05 15:17:55 -07:00
Pranav K 397f924e8d
Ensure SystemTextJsonHelper always HTML encodes output. (#12808) 
* Ensure JsonSerializer always HTML encodes output.

* Update JsonOptions.JsonSerializerOptions to use encoder scheme that does not encode non-ASCII
  characters by default. This makes the encoding comparable to Json.NET's defaults
* In SystemTextJsonHelper, ensure that the content is always HTML-encoded
* Unskip skipped test

Fixes https://github.com/aspnet/AspNetCore/issues/9946
Fixes https://github.com/aspnet/AspNetCore/issues/11459
 2019-08-05 13:34:32 -07:00
Pranav K 709b390157
Add helper methods on ControllerBase to return ProblemDetails (#12298) 
* Add helper methods on ControllerBase to return ProblemDetails

* Introduce ControllerBase.Problem and ValidationProblem overload
  that accepts optional parameters
* Consistently use ClientErrorData when generating ProblemDetails
* Clean-up InvalidModelStateResponseFactory initialization.

Fixes https://github.com/aspnet/AspNetCore/issues/8537
 2019-08-05 11:28:28 -07:00
Isaac Levin 9e48a49be3
Update angular.json 2019-08-05 11:03:10 -05:00
Justin Kotalik 8d68062cc4 Always load hostfxr.dll by absolute path (#12807) 2019-08-05 08:51:55 -07:00
Steve Sanderson 2ff6a5c0f8
Components router refactoring. Fixes #10493 #10445 (#12800) 2019-08-05 13:52:01 +01:00
Doug Bunting b6f1a50583
Merge branch 'release/3.0' => 'master' (#12855) 2019-08-03 18:50:51 -07:00
Doug Bunting 3148acfb10
Merge branch 'release/3.0' => 'master' (#12805) 2019-08-03 13:36:57 -07:00
Doug Bunting 0dc822a6ad
Merge branch 'release/3.0' into merge/release/3.0-preview8-to-release/3.0 2019-08-03 13:31:00 -07:00
Ryan Nowak 352df35864 Re-enable components E2E tests on the CI 2019-08-03 08:52:03 -07:00
Javier Calvarro Nelson 521cabc545
[Blazor][Fixes #12283] Prevent HtmlRenderer from calling OnAfterRender by default (#12684) 
[Blazor] Prevents HtmlRenderer from calling OnAfterRender by default
 2019-08-03 13:03:48 +02:00
Ryan Nowak d52d7e3284
Harden StartCircuit (#12825) 
* Harden StartCircuit

Fixes: #12057

Adds some upfront argument validation as well as error handling for
circuit intialization failures.
 2019-08-02 20:35:29 -07:00
Ryan Nowak 7f924dd599 fix outlying namespace 2019-08-02 17:23:46 -07:00
Ryan Nowak 3cc6e8373b Fail faster in Blazor E2E tests 
This change adds a fail-fast mechanism to our E2E tests based on
the browser console. This will fail super hard if an unhandled exception
is thrown.

I think it would be interesting to also see if we could do the same
thing for 404s.

The goal of this change is to make it so that the E2E tests can fail
faster (3-4s) than the 30s timeout in the case that something
catastrophic happens. As a nice side benefit you get to see the
exception message.
 2019-08-02 17:23:46 -07:00
Ryan Nowak 40e268f59e Skip failing tests 2019-08-02 17:23:46 -07:00
Ryan Nowak da49e0e0f6 Fix broken test 
These parameters are declared incorrectly.
 2019-08-02 17:23:46 -07:00
Steve Sanderson 8a1cf8386f
Stricter key clash detection. Fixes #12691 (#12837) 2019-08-02 22:16:47 +01:00
Paul Buonopane 698a343128 Fix #12834: Wrong order of params to ArgumentNullException ctor (#12839) 
Fixes #12834
 2019-08-02 12:21:35 -07:00
Brennan c15f1e145f
[SignalR] Change log levels (#12742) 2019-08-02 10:51:23 -07:00
N. Taylor Mullen d312d797fc Change non-public [Parameter] warning severities to error. 
- In preview8 we warned users for non-public `[Parameter]`s and `[Parameter]` setters. For preview9 this is now an error because things will not work as they expect.
- Updated existing tests to reflect the new error expectation.

#12294
 2019-08-02 10:25:26 -07:00
Artak 45f9a2a44e
Updated dependencies (#12836) 2019-08-02 09:57:10 -07:00
Ryan Brandenburg 27996712af
Merge pull request #12775 from Reptarsrage/master 
Adding optional PackageManagerName Option to use alternative Package Managers like Yarn
 2019-08-02 09:57:06 -07:00
Justin Kotalik 02d28e1c54
Only use read Pipe when running on Http2. (#12737) 2019-08-02 08:02:59 -07:00
Doug Bunting 8dd1be9474 Fix XML escaping 
- #12786
- escape `'<'` chars in attribute values to make the .targets file valid XML
- escape `'\''` chars nested within single-quoted values to make `msbuild` conditions valid
 2019-08-01 22:04:52 -07:00
Ryan Nowak 9b888e9df5
Blazor API Review: IUriHelper (#12425) 
* Rename IUriHelper -> NavigationManager

- Remove IUriHelper interface
- Rename to NavigationManager
- Remove all traces of old naming

There's no functional or design change in this commit - just removing
all traces of the old name. The next few iterations will try to improve
the design.

* Minor API tweaks to NavigationManager

Making Initialize protected causes problems because right now the
server-side code needs to deal with one of two different
implementations, hence an exchange type is used. I followed the same
pattern that was used for auth for symmetry but I have some *cool*
thoughts.

- We can remove this when we remove stateful prerendering
- I have another idea to banish this pattern to the land of wind and
ghosts

If this ends up sticking around longer than a week in the code, lets
discuss other ideas and try to improve the pattern.

* Use hub method for server-side navigation

* Get rid of async local

* Add hub method test

* Misc bikeshedding

* Update src/Components/Server/src/Circuits/DefaultCircuitFactory.cs

Co-Authored-By: campersau <buchholz.bastian@googlemail.com>

* PR feedback
 2019-08-01 17:11:09 -07:00
Chris Ross 59f6b852c2
HPACK circular overflow #12190 (#12782) 2019-08-01 14:30:32 -07:00
Justin Robb 9adf27409e Regenerating reference assemblies for Microsoft.AspNetCore.SpaServices.Extensions 2019-08-01 13:46:56 -07:00
Justin Robb 102bcf6739 Reverting breaking changes with npmScript parameter name 2019-08-01 12:13:37 -07:00
Ryan Nowak 001b54f42e Add component for managing a DI scope 
Fixes: #5496
Fixes: #10448

This change adds a *utility* base class that encourages you to do the
right thing when you need to interact with a disposable scoped or
transient service.

This solution ties the lifetime of a DI scope and a service to a
component instance. Note that this is not recursive - we expect users to
pass services like this around (or as cascading values) if the design
dictates it.
 2019-08-01 12:03:34 -07:00
Chris Ross 0559d39746
Fix form pipe parser #12381 (#12749) 2019-08-01 11:28:35 -07:00
John Luo 9459b73972
Merge pull request #12752 from aspnet/jamesnk/grpc-dep-preview8 
Update gRPC template dependency for preview 8 and link to macOS docs
 2019-08-01 11:25:57 -07:00
Justin Robb c398361412 Renaming packageManagerCommand variables, fixing comment 2019-08-01 10:14:51 -07:00
Ryan Nowak 45f50905d5 Remove stateful prerendering 
Fixes: #12245
Fixes: #12630

This change removes stateful pre-rendering from Server-Side Blazor. This
means that when you render a component during the initial HTTP request,
we we will no longer preserve the component instances and their
parameters. While this feature was useful, it cause serious scalability
concerns.

This means that it will now be required to register "entry-point"
components in startup similar to client-side Blazor.
 2019-08-01 07:44:14 -07:00
John Luo e2fbe452d6 Merge branch 'release/3.0' 2019-07-31 16:57:21 -07:00
Ryan Brandenburg 5c11687506 SPA template precedence (#12781) 
Merging this as there are no actual code-changes here.
 2019-07-31 16:43:40 -07:00
Ryan Nowak b42ebf119d Fix incrementalism of Blazor solution 2019-07-31 13:31:26 -07:00
James Newton-King 1434e239d6
Change OSX to macOS in error message (#12756) 2019-08-01 08:30:56 +12:00
Justin Robb 7c7dd6569f Renaming some SPA Middleware variables to be package manager agnostic 2019-07-31 13:15:07 -07:00
Justin Robb 751882cf3c Add optional packageManagerName to allow alternative package managers 2019-07-31 13:06:54 -07:00
Javier Calvarro Nelson 2969001a75
[Identity] Fix flaky test (#12771) 2019-07-31 21:58:10 +02:00
Pranav K 9e6924235e
Add logging to RemoteRenderer to time a round-trip (#12638) 2019-07-31 12:18:31 -07:00
Justin Kotalik aab75e8dda
Decrement activeStreamCount earlier s.t. client view matches the server. (#12704) 2019-07-31 07:45:36 -07:00
Javier Calvarro Nelson 7a0a286ce6
[Blazor][Fixes #12197] Dispose the circuit on graceful disconnections (#12449) 
* Immediately releases the circuit when the client disconnects gracefully.
* This functionality is limited to websockets.
* We are able to release the circuit in the following situations:
  * The user closes the browser.
  * The user navigates away.
  * The user reloads the page.
 2019-07-31 13:17:00 +02:00
James Newton-King ccfa7f13ea
Clean up 2019-07-31 13:58:18 +12:00
James Newton-King 10b9c338f2
Clean up 2019-07-31 13:57:16 +12:00
James Newton-King 4841d5f019
Update gRPC template dependency for preview 8 and link to macOS docs 2019-07-31 13:50:06 +12:00
Phil Henning b2e11d77e8 Insert seed localization for templates. (#11040) 
* Insert seed localization for templates.

* Updated loc strings for Worker for some langs

* Update en string.json for Blazor project template

* Refresh strings for initial seeding
 2019-07-30 16:00:08 -07:00
Mateusz Wójcik c703093346 Add option to disable adding trailing slash #2449 (#12669) 
Middlewares affected:
- DefaultFilesMiddleware
- DirectoryBrowserMiddleware
 2019-07-30 10:55:00 -07:00
bashdx 1bff37bec1 Issue #11559: Show meaningful error message for TLS over HTTP endpoint. (#12697) 2019-07-30 10:26:54 -07:00
Ryan Nowak 6045c08072 Blazor API Review: Built-in components 
Fixes: #12548

Renaming properties to drop 'Content' as a suffix. We haven't been
consistent in using this, and we're removing it instead of adding it
elsewhere.
 2019-07-30 09:35:49 -07:00
Ryan Nowak bef01f3e9a Blazor API Review: UIEventArgs types 
Fixes: #12550

Removes UIEventArgs in favor of EventArgs as the base class.

Moving Type into all of our event args types - this is important because
many of the events types are used for multiple events.

The only think about this that isn't perfect is that we have keep
special casing change because of how binding works. I renamed the type
to drop the `UI` prefix. It's not possible to define a subclass in the
Web project because of the way covariance works (or doesn't work) in
.NET.
 2019-07-29 22:40:28 -07:00
Ryan Nowak 3919dd55c6 Fix globalization for `@bind-value` 
Fixes: #12631

These mappings were missing and adding them restores the correct
behaviour. Mixing up the usage of `@bind` vs `@bind-value` so we have
more coverage of this.
 2019-07-29 22:39:56 -07:00
Ryan Nowak 82478eac6b Blazor API Review: Forms 
Fixes: #12549
 2019-07-29 22:37:12 -07:00
John Luo ef99d81d68
Update branding to 5.0.0-alpha1 (#12671) 
* Update branding to 5.0.0-alpha1

* Preserve baseline reference overrides for 5.0

* Skip framework tests
 2019-07-29 20:32:24 -07:00
Brennan ad533b76fb Limit max handshake size (#12678) 2019-07-29 16:34:25 -07:00
Stephen Halter 75f4159e5a
Accurately count only newly examined bytes (#12639) 
- Ensure Kestrel count all bytes read using TryRead
- Ensure Kestrel doesn't double count examined but
  not consumed bytes
 2019-07-29 10:14:14 -07:00
John Luo 4debc9c455 Update SDK to preview7 (#12682) 
- react to SDK changes (Microsoft.NETCore.App.Ref assemblies grouping)
- update `dotnet new -u` logic
 2019-07-29 10:06:07 -07:00
John Luo e2d57e2806
Revert "Improve components infrastructure (#12145)" (#12679) 
* Revert "Improve components infrastructure (#12145)"

This reverts commit e149f9c0aa.

* Update JS file
 2019-07-29 09:03:57 -07:00
David Fowler ad94d41a7f Fixed parameter name casing (#12681) 2019-07-29 07:25:28 -07:00
Alessio Franceschelli c23b9feb19 HeaderPropagation: reworded registration exception for clarity (#12636) 
* HeaderPropagation: reworded registration exception for clarity

* feedback
 2019-07-27 12:59:17 -07:00
Brennan a1e77a2c09
Set transport handlers earlier in Typescript client (#12524) 2019-07-26 21:54:07 -07:00
James Newton-King 2d4fd05adf
Add host caution to MVC GetUri extension methods (#12629) 2019-07-27 15:39:25 +12:00
Brennan 98abd9e256
Cleanup exception message (#12623) 2019-07-26 15:54:27 -07:00
Justin Kotalik 4aebd29abc
Increase Http2 Header limit size to the MaxFrameSize (#12625) 2019-07-26 14:31:48 -07:00
John Luo e149f9c0aa
Improve components infrastructure (#12145) 
* Remove generated Web.JS javascript files files

* Build NodeJS project referenced by managed projects by default

* Build Web.JS before other CI jobs

- We can't build Web.JS on Linux Musl for example

* Make BuildAll not override explicit BuildJava/NodeJS/Native/Managed settings

* Capture CodeCheck logs for debugging

* Skip NodeJS projects when generation ref assemblies

* Do not build dependent projects if NodeJS is not built

* Make build fail immediately if BuildNodeJS is true but NodeJS is not installed

* Do not build nodejs in installer builds
 2019-07-26 13:31:01 -07:00
Chris Ross 922fd9cb0d React to kestrel merge conflict (#12624) 2019-07-26 11:55:37 -07:00
Hao Kung a0e0338d7e
Add missing area in link generation for identity UI (#12590) 2019-07-26 11:04:08 -07:00
Javier Calvarro Nelson 0d553f7147
Fix small issue in Identity UI (#12607) 
The logic for selecting the views assembly had a small bug.
Added an E2E test to cover the scenario.
 2019-07-26 19:37:13 +02:00
Justin Kotalik 51497f72a6
Check length for pipe test rather than byte content (#12612) 2019-07-26 09:59:08 -07:00
Ryan Nowak bfd4305fd8
Blazor API Review: Parameters (#12547) 
* Blazor API Review: Parameters

Part of #11610
 2019-07-26 09:46:47 -07:00
Chris Ross 5631b97d12
Kestrel HttpClient Http2 interop tests #4763 (#11869) 2019-07-26 09:45:45 -07:00
Justin Kotalik 2a35f8ee4c
Merge pull request #12444 from dotnet-maestro-bot/merge/release/2.2-to-master 
[automated] Merge branch 'release/2.2' => 'master'
 2019-07-26 08:02:12 -07:00
David Fowler e78d17e07b
Update HubProtocol.md (#12509) 
* Update HubProtocol.md

Updated the code sample in the protocol doc to reflect the actual programming API

* Update src/SignalR/docs/specs/HubProtocol.md

Co-Authored-By: Brennan <brecon@microsoft.com>
 2019-07-25 19:12:14 -07:00
Brennan 331ff2404d
Send HttpOnly (if applicable) when deleting cookies (#12593) 2019-07-25 17:42:23 -07:00
Pranav K d7bfbb5824
Add formatter mapping for JSON (#12592) 
Fixes https://github.com/aspnet/AspNetCore/issues/12414
 2019-07-25 16:50:54 -07:00
Martin Stenhoff b13f2614de Changing Analzyer to Analyzer 2019-07-25 16:38:24 -07:00
Dylan Dmitri Gray 1aebfa681a
Dylan/resettable tcs (#12453) 
* renames, resettable tcs; custom awaitable now dispatches
 2019-07-25 16:38:13 -07:00
Chris Ross 080660967b
Unified response body features (#12328) 2019-07-25 16:27:08 -07:00
John Luo 2884ef6e1f
Update default project names (#12431) 2019-07-25 14:56:51 -07:00
Harley Adams a07ad16e4d IIS - Skip setting a header if the value is empty #11032 (#12486) 2019-07-25 14:39:52 -07:00
Brennan 648bdf706e
Avoid unobserved tasks in WebSocketsTransport (#12315) 2019-07-25 14:25:00 -07:00
Andrew Stanton-Nurse cac51846e9
fix #12516 by cleaning up Hosting error page (#12545) 
* fix #12516 by cleaning up error page

* add a Diagnostics.slnf because I was there

* missed the IIS update

* update WebHost's error page

* Fix slnf path
 2019-07-25 13:01:00 -07:00
Javier Calvarro Nelson e0d522e1f7
Remove flaky mark from E2E templates tests (#12450) 
* Removes the [Flaky] mark for the React_IndividualAuth test.
* Removes the [Flaky] mark for all the blazorserverside template tests.
 2019-07-25 21:59:51 +02:00
Justin Kotalik 8cbc76f1ec Merge remote-tracking branch 'origin/release/2.2' 2019-07-25 11:41:11 -07:00
Justin Kotalik d463dc7721
Update CorsMiddlewareFunctionalTest.cs (#12571) 2019-07-25 11:28:30 -07:00
Pranav K a181fc2b67
Clean up MvcSandbox (#12542) 2019-07-25 10:25:07 -07:00
Ryan Nowak 6526022f6c Blazor API Review: RenderTreeBuilder 
Fixes: #12415
 2019-07-25 09:45:26 -07:00
N. Taylor Mullen c76cb9248d Add support for increment/decrement [Parameter] usage detection. 
- Didn't realize there was an increment or decrement operation kind.
- Added tests to cover this scenario

#12543
 2019-07-25 08:47:13 -07:00
Javier Calvarro Nelson 143c101693
[Identity] Move to use static web assets support. (#11029) 
* Moves Identity UI to use Static Web Assets
  * Removes the static files as embedded content.
  * Stops plugging the static assets through the embedded file provider.
  * Selects the UI framework at build time instead of runtime.
 2019-07-25 17:34:45 +02:00
Justin Kotalik 9a6d4af9d6 Merge release/2.1 into release/2.2 (#12290) 2019-07-24 18:01:57 -07:00
Justin Kotalik 69feac2633
Catch all exceptions from Exit shutdown (master). (#12522) 2019-07-24 14:56:04 -07:00
Stephen Halter 34903da1e9
Fix ConcurrentPipeWriterTests (#12383) 2019-07-24 14:51:31 -07:00
N. Taylor Mullen c54a7209d7 Clear route values after middleware invocation. 
#11233
 2019-07-24 14:12:06 -07:00
N. Taylor Mullen 479d5ed40a Addressed code review comments. 2019-07-24 14:12:06 -07:00
N. Taylor Mullen 9a6881b0e8 Fix endpoint routing statefulness. 
- In the case that other middleware change the path of an `HttpContext` and cause middleware to re-invoke we used to short-circuit on second time through the middleware pipeline, now we allow routing to occur.
- Added unit tests to validate the clearing of state.

#11233
 2019-07-24 14:12:06 -07:00
Steve Sanderson 54da777b7c
Reset scroll position after navigation. Fixes #10482 (#12423) 2019-07-24 10:25:59 -07:00
Steve Sanderson 8b7fcf1f76
Update user on reconnect. Fixes #12051 (#12421) 2019-07-24 10:23:38 -07:00
Artak 9b6f10d20c
Marked the RunClientTests as flaky (#12497) 2019-07-24 09:51:55 -07:00
Steve Sanderson dd0d483f7d
Fix Web.JS tests (#12513) 2019-07-24 09:48:12 -07:00
Hisham Bin Ateya 28678ee430 Change unsupported culture log level (#12153) 
* Change unsupported culture log level to Debug

* Fix unit tests
 2019-07-23 20:05:10 -07:00
Andrew Stanton-Nurse 4928eb3de0
fix #12445 by migrating dotnet-sql-cache to new SqlClient (#12447) 2019-07-23 14:40:18 -07:00
Ryan Nowak 3e2f88497d Remove manual ref-assembly generation for Components 2019-07-23 14:39:14 -07:00
Alessio Franceschelli 14c6abafda Test PageActionInvoker logs and fix declaring type name for handler in logs (#12326) 
* Test PageActionInvoker logs and fix declaring type name for handler
 2019-07-23 10:38:39 -07:00
Andrew Stanton-Nurse 48b44dbb92
Add clarifying comment to HttpMethods.cs (#12441) 
To help prevent well-meaning (but not actually desirable) changes like https://github.com/aspnet/AspNetCore/pull/12439
 2019-07-23 08:09:16 -07:00
Ben Adams 2e0d7889ad Kestrel code tidyups (#11896) 2019-07-22 12:57:52 -07:00
Javier Calvarro Nelson c918d72f36
[Blazor] [Fixes #11847] Renderer.DispatchEventAsync throws null reference exception if event handler throws synchronously (#12393) 
[Blazor] [Fixes #11847] Renderer.DispatchEventAsync throws null
reference exception if event handler throws synchronously
* Returns after handling the exception.
* Adds a unit test and an E2E test to validate expected behavior.
 2019-07-22 19:14:30 +02:00