Commit Graph

43954 Commits

Author SHA1 Message Date
N. Taylor Mullen 6699353dc6
Merge pull request #13177 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-15 16:14:18 -07:00
Ajay Bhargav Baaskaran 2873952822 Set LangVersion the same way as roslyn (dotnet/aspnetcore-tooling#979)
* Set LangVersion the same way as roslyn

* Update commit link
\n\nCommit migrated from b82d4f9583
2019-08-15 15:27:12 -07:00
Stephen Halter 72925ecc19
Merge pull request #13079 from aspnet/halter73/13020
Throw NotSupportedException given FileHandleEndPoint
2019-08-15 14:58:49 -07:00
Ajay Bhargav Baaskaran c32e2a5969 Set LangVersion the same way as roslyn (dotnet/aspnetcore-tooling#978)
* Set LangVersion the same way as roslyn

* Update commit link
\n\nCommit migrated from 7da15da123
2019-08-15 14:42:21 -07:00
N. Taylor Mullen f3536ca403 Revert "Fix: dotnet/aspnetcore-tooling#11197 automatic backing-field for @ref (dotnet/aspnetcore-tooling#707)"
This reverts commit dadf9fa.
\n\nCommit migrated from afddfcb49e
2019-08-15 14:35:26 -07:00
N. Taylor Mullen 9584c7e34f Revert "Fix a bug with ref and declaration phase"
This reverts commit dotnet/aspnetcore-tooling@09b50151ef.

# Conflicts:
#	src/Razor/test/RazorLanguage.Test/IntegrationTests/ComponentDeclarationIntegrationTest.cs
\n\nCommit migrated from c0e934ed7c
2019-08-15 14:35:26 -07:00
N. Taylor Mullen f890c9104c Improves further on Blazor reconnection experience.
- Expanded `ReconnectDisplay` to have a `rejected` method on it. This is the method that indicates we will never be able to reconnect to the server. By default we provide a nice little message letting users know that reconnection is no longer possible and that a refresh must take place.
- Added a logger to the `DefaultReconnectionDisplay` since part of its job is handling `Retry` clicks which indirectly call `reconnect()`. Therefore, it needed the ability to log information to the console to inform users why certain reconnects were not possible.
- Updated the `UserSpecifiedDisplay` to have a `refused` understanding. Added a new CSS class to represent the `refused` state as well.
- Updated existing tests to abide by the new `ReconnectDisplay` structure
- Added a new test to validate that the `refused``ReconnectDisplay` method results in proper behavior.

#12442
2019-08-15 14:17:35 -07:00
Brennan 3d9311a29f
Remove value span usage (#12990) 2019-08-15 14:09:05 -07:00
Pranav K 248326e670 Merge branch 'master' into merge/release/3.0-to-master\n\nCommit migrated from 5eb94ddb0f 2019-08-15 13:37:48 -07:00
dotnet-maestro[bot] 781743fa30 [release/3.0] Update dependencies from aspnet/Extensions (dotnet/aspnetcore-tooling#975)
* Update dependencies from https://github.com/aspnet/Extensions build 20190815.2

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview9.19415.2
- Microsoft.AspNetCore.Testing - 3.0.0-preview9.19415.2
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview9.19415.2
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview9.19415.2
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview9.19415.2
- Microsoft.Extensions.Logging - 3.0.0-preview9.19415.2

Dependency coherency updates

- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview9-19414-17 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview9-19414-17 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Ref - 3.0.0-preview9-19414-17 (parent: Microsoft.Extensions.Logging)
- Microsoft.Net.Compilers.Toolset - 3.3.0-beta3-19415-01 (parent: Microsoft.Extensions.Logging)

* Update dependencies from https://github.com/aspnet/Extensions build 20190814.4

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview9.19414.4
- Microsoft.AspNetCore.Testing - 3.0.0-preview9.19414.4
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview9.19414.4
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview9.19414.4
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview9.19414.4
- Microsoft.Extensions.Logging - 3.0.0-preview9.19414.4

* Update dependencies from https://github.com/aspnet/Extensions build 20190815.2

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview9.19415.2
- Microsoft.AspNetCore.Testing - 3.0.0-preview9.19415.2
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview9.19415.2
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview9.19415.2
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview9.19415.2
- Microsoft.Extensions.Logging - 3.0.0-preview9.19415.2

* React to namespace removal
\n\nCommit migrated from 543a1ae2a3
2019-08-15 20:12:47 +00:00
Pranav K 4144eeb459
Merge pull request #13169 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-15 10:44:07 -07:00
Pranav K b2a0b02e35
Update runtime compilation to target CSharpLang v8.0 by default (#13110)
Fixes https://github.com/aspnet/AspNetCore/issues/9129
2019-08-15 09:18:41 -07:00
Justin Kotalik 9898a0eb71 Cleanup to skip/flaky attributes (#2186) 2019-08-15 09:12:53 -07:00
Justin Kotalik ce392fa4f7 Cleanup to skip/flaky attributes (#2186) 2019-08-15 09:12:53 -07:00
Justin Kotalik c717230b13 Cleanup to skip/flaky attributes (dotnet/extensions#2186)
\n\nCommit migrated from cfef5e07fb
2019-08-15 09:12:53 -07:00
Justin Kotalik 417cba2d50 Microsoft.AspNetCore.App =>Ref in the platform manifest (#13129) 2019-08-15 08:48:06 -07:00
Brennan 5e575a3e64
Merge pull request #13136 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-15 08:28:49 -07:00
Justin Kotalik f70eef0db1
I don't know how to write debug asserts (#13134) 2019-08-15 08:27:39 -07:00
N. Taylor Mullen 91c0b06d89 Merge pull request dotnet/aspnetcore-tooling#972 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from 6e349d1786
2019-08-14 16:58:01 -07:00
N. Taylor Mullen 10452bf783 Improve Blazor reconnection experience.
- Updated text of reconnect dialog to be more clear.
- Added user feedback to the `Retry` event button click. The current flow is `Attempting to reconnect` -> `Failed to reconnect ... [Retry]` -> Click Retry -> `Attempting to reconnect`.
- Found that in cases where the server went away entirely the reconnect event would through unexpectedly preventing the reconnect display from handling a failed reconnect. Added a separate error flow to understand when the server went away/could not start a SignalR connection to.
- Could not find a great way to add tests for this scenario.

Addresses #12442
2019-08-14 16:27:00 -07:00
Ryan Nowak 13fc89ce49 Dispose DI scope with async support in circuit host
Fixes part of #12918

This fixes the part of this issue that we're going to be able to do in
3.0 safely.
2019-08-14 15:24:02 -07:00
N. Taylor Mullen e5a950de97 Re-enable reconnection failed invocation validation test.
- Relaxed the `maxRetries` and `retryIntervalMilliseconds` parameters to enable the test to complete quicker. Couldn't reproduce a failure even as the test is originally on my own Mac.

#12578
2019-08-14 14:47:33 -07:00
Pranav K 778246c674 Add tooling support for TypeScript files to RazorSDK (dotnet/aspnetcore-tooling#971)
Fixes https://github.com/aspnet/AspNetCore/issues/12840\n\nCommit migrated from 304cafcffe
2019-08-14 14:22:46 -07:00
Ajay Bhargav Baaskaran c605d6cf63
Don't release SemaphoreSlim when it is canceled (#12818)
* Don't release SemaphoreSlim when it is cancelled

* fixed tests

* Rebased

* Updated ref

* mark test as flaky
2019-08-14 12:40:44 -07:00
Pranav K 9372816b7c API Review: JSRuntime (dotnet/extensions#2166)
* API Review: JSRuntime

* Rename JSRuntimeBase -> JSRuntime
* Rename JSInProcessRuntimeBase -> JSInProcessRuntime
* Rename DotNetObjectRef -> DotNetObjectReference
* Update JSRuntime to return ValueTask
* Make InvokeAsync APIs that explicitly cancels and API that default cancels more crisp
* Introduce void invoking APIs
* Fixup method names on DotNetDispatcher

\n\nCommit migrated from 93d3ae4485
2019-08-14 12:24:35 -07:00
Ryan Nowak 1f7d59d8f1 Remove IComponentContext
Fixes part of: #12553

We don't believe that this is needed anymore. We no longer call
OnAfterRender when you're prerendering, so the main use case of this
type is gone.
2019-08-14 12:06:05 -07:00
John Luo 057ec9cfae
Merge pull request #13019 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'
2019-08-14 11:32:09 -07:00
Pranav K a285e966e3
Mark InteropReliabilityTests flaky again (#13130) 2019-08-14 11:15:17 -07:00
Pranav K edd5f54bc3 Special case Disposing DotNetObjectReferences (dotnet/extensions#2176)
* Special case Disposing DotNetObjectReferences

This removes a public JSInvokable method required for disposing DotNetObjectReferences


\n\nCommit migrated from d6bfc28e21
2019-08-14 09:44:33 -07:00
Pranav K 30f518e0c9 Merge branch 'master' into merge/release/3.0-to-master\n\nCommit migrated from ad8ba0cbe4 2019-08-14 08:23:10 -07:00
John Luo ed360e171a fix npm flake (#13106) 2019-08-14 07:48:34 -07:00
dotnet-maestro-bot 8d23c27cb3 [automated] Merge branch 'release/3.0' => 'master' (dotnet/aspnetcore-tooling#968)
* Give "builder" a less discoverable name

Fixes https://github.com/aspnet/AspNetCore/issues/12991

* Fixup tests

* [Blazor][Fixes dotnet/aspnetcore-tooling#12933] Remove the need for a custom property when resolving static web assets from referenced projects

* Removes the need for a custom property when resolving static web assets from referenced projects
* Rolls in several improvements suggested by the MSBuild folks to improve performance.
\n\nCommit migrated from 112f72da6b
2019-08-14 16:27:16 +02:00
Javier Calvarro Nelson 70268e7c82 [Blazor][Fixes dotnet/aspnetcore-tooling#12933] Remove the need for a custom property when resolving static web assets from referenced projects
* Removes the need for a custom property when resolving static web assets from referenced projects
* Rolls in several improvements suggested by the MSBuild folks to improve performance.\n\nCommit migrated from 5335245b08
2019-08-14 15:59:44 +02:00
Javier Calvarro Nelson 74c09470c6
[Blazor][Fixes #12056] Avoid producing warnings for bad inputs.
* Does not produce warnings when receiving invalid event arguments.
* Does not produce warnings when receiving an invalid event handler id.
* Does not produce warnings when receiving an ack for an unknown batch.
2019-08-14 13:01:53 +02:00
Andrew Stanton-Nurse 2a6c96a684 Merged PR 2630: Fix patch config for SpaServices MSRC
I'll merge this ASAP once I'm confident it will fix the issue.
2019-08-13 22:13:40 +00:00
Mikael Mengistu e7a1dc620b
Update SignalR Sample (#13078) 2019-08-13 15:12:31 -07:00
Andrew Stanton-Nurse be0a4a7f4c Merged PR 2631: Fix patch config in 2.2
I'll merge this ASAP once I'm confident it will resolve the issue
2019-08-13 22:10:56 +00:00
Justin Kotalik 2217be2826 Skip/disable tests in 2.2 for IIS (#12985)
* Skip/disable tests in 2.2 for IIS

* Update ServicesTests.cs
2019-08-13 14:00:33 -07:00
John Luo a980601d83 Merge pull request dotnet/extensions#2155 from dotnet-maestro-bot/merge/release/3.0-to-master
[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from 3f8ee552a0
2019-08-13 13:52:44 -07:00
Ryan Brandenburg aa34cf3212
Update debian arm64 Helix queue image (#13009)
Update debian arm64 Helix queue image
2019-08-13 13:42:20 -07:00
N. Taylor Mullen 1f0641f5c0 Reset endpoint and route values during exception handling.
- We initially did this change as part of EndpointRouting but the impact of that change resulted in a variety of performance regressions. To mitigate the impact of resetting state for a request we now only reset the state when an exception has occurred in a way that does not require any additional state machines to be allocated.
- Added a test to validate that http context state gets reset on exception handling.

#12897
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 4f6022323b Revert "Fix endpoint routing statefulness."
This reverts commit 9a6881b0e8.
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 44431151c7 Revert "Addressed code review comments."
This reverts commit 479d5ed40a.
2019-08-13 13:27:36 -07:00
N. Taylor Mullen 18391dd2e4 Revert "Clear route values after middleware invocation."
This reverts commit c54a7209d7.
2019-08-13 13:27:36 -07:00
Pranav K 44cfe01a89
Merge branch 'master' into merge/release/3.0-to-master 2019-08-13 13:03:17 -07:00
Steve Sanderson e8917fc92f [Blazor][Fixes #13056] Renderer use-after-disposal tweaks
* Improves Renderer handling use after disposal.
* Ensures RemoteRenderer skips resuming the render queue after ACK if it was since disposed
2019-08-13 21:51:39 +02:00
Pranav K 9bd027aa99
Make Partial on PageBase and PageModel work correctly (#13013)
* Make Partial on PageBase and PageModel work correctly

Fixes https://github.com/aspnet/AspNetCore/issues/10438
2019-08-13 12:49:10 -07:00
Pranav K 2317fc9687 Fixup tests
\n\nCommit migrated from 5707808e9f
2019-08-13 12:39:55 -07:00
Pranav K 80d6dfea89 Give "builder" a less discoverable name
Fixes https://github.com/aspnet/AspNetCore/issues/12991
\n\nCommit migrated from 7e974693b6
2019-08-13 12:39:55 -07:00
Pranav K 32196f8023 Use globally qualified type name when generating TypeInference (dotnet/aspnetcore-tooling#946)
The code-generated TypeInference type resides in a custom namespace.
Any types that it refers to in user code must be qualified using the "global::" prefix
to avoid type \ namespace conflicts.

Fixes https://github.com/aspnet/AspNetCore/issues/12116\n\nCommit migrated from f0e09e4a97
2019-08-13 12:35:37 -07:00