- use SignalR.Npm.FunctionalTests.npmproj to get non-stable version
- not Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj (avoid C# and F# projects)
- add `_GetPackageVersionInfo` target to all `*.npmproj` projects
- make `_GetPackageVersionInfo` target work when `yarn` is not installed
- switch codesign-xplat.yml to use `dotnet msbuild`
- above change also fixes Code-sign jobs but they're slightly faster using `dotnet msbuild`
[master] Update dependencies from dotnet/arcade
- Updates:
- Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20374.1 to 5.0.0-beta.20403.5
- Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20374.1 to 5.0.0-beta.20403.5
[master] Update dependencies from dotnet/efcore dotnet/runtime
- Updates:
- System.ComponentModel.Annotations: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Diagnostics.DiagnosticSource: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Diagnostics.EventLog: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.Abstractions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.Configuration: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.Console: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.Debug: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.EventLog: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.EventSource: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Logging.TraceSource: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Options: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Options.ConfigurationExtensions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Options.DataAnnotations: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Primitives: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Internal.Transport: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Http: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Hosting: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Caching.Abstractions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Caching.Memory: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.Abstractions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.Binder: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.CommandLine: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.EnvironmentVariables: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.FileExtensions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.Ini: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.Json: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.UserSecrets: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Configuration.Xml: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.DependencyInjection: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.DependencyInjection.Abstractions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.DependencyModel: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.FileProviders.Abstractions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.FileProviders.Composite: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.FileProviders.Physical: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.FileSystemGlobbing: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.HostFactoryResolver.Sources: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Extensions.Hosting.Abstractions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.NETCore.Platforms: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Win32.Registry: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.Win32.SystemEvents: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.NETCore.App.Internal: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Microsoft.NETCore.App.Ref: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Drawing.Common: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Text.Encodings.Web: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Text.Json: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Threading.Channels: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Windows.Extensions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.ServiceProcess.ServiceController: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Security.Principal.Windows: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.IO.Pipelines: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Net.Http.Json: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Net.Http.WinHttpHandler: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Net.WebSockets.WebSocketProtocol: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Reflection.Metadata: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Resources.Extensions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Runtime.CompilerServices.Unsafe: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Security.AccessControl: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Security.Cryptography.Cng: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Security.Cryptography.Pkcs: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Security.Cryptography.Xml: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- System.Security.Permissions: from 5.0.0-rc.1.20404.16 to 5.0.0-rc.1.20406.11
- Updates:
- Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- dotnet-ef: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- Microsoft.EntityFrameworkCore: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.1.20405.3 to 5.0.0-rc.1.20406.4
- #20818, fix e.g. references to Microsoft.Web.Xdt.Extensions in our packages
- make `@(Reference)` items much more broadly applicable
- emit an error when `@(ProjectReference)` is used instead of `@(Reference)`
- then get rid of the errors (!!)
- rename a couple of projects to match their assembly names
- then regenerate the `@(ProjectReferenceProvider)` items
- switch intersection approach from Exclude / Exclude to Copy / Update / Copy
Projects of particular interest:
- src/DefaultBuilder/src/Microsoft.AspNetCore.csproj
- honouring metadata left e.g. Microsoft.AspNetCore.Components.WebAssembly.DevServer package unchanged
- removed redundant metadata after that confirmation
- src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/
- content of this package unchanged but metadata avoids extra work
- add a comment about the extra work
- src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/
- success! removes Microsoft.Web.Xdt.Extensions dependency from the package
- src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj
- add a `Condition` to avoid an ordering issue I hit here
- src/Tools/Extensions.ApiDescription.Server/src/
- avoid errors the new build ordering and timing caused
Separately, up the timeout in the `<DownloadFile />` task
- hit repeated timeouts downloading dotnet-runtime-5.0.0-rc.1.20370.4-win-x64.zip
nits:
- remove dupe `@(Reference)` item in Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
- remove useless `%(ProjectReference.IsImplicitlyDefined)` metadata as well as its misspellings
- remove extra spaces from ProjectReferences.props
- clean up a few comments in ResolveReferences.targets
* !fixup! Correct other references to renamed projects
Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.Arcade.Sdk
From Version 5.0.0-beta.20364.3 -> To Version 5.0.0-beta.20374.1
- downgrade of the Arcade SDK should be fine
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Net.Compilers.Toolset
From Version 3.8.0-1.20367.11 -> To Version 3.8.0-2.20379.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Use Microsoft.CodeAnalysis.PublicApiAnalyzers
- #4259 1/2
- followup 2/3 for 5266918ed2
- includes baselines for 16 MVC projects
- will automated further additions in another PR
- suppress warnings that may cause back-compat problems if fixed
nit: sort `@(LatestPackageReference)` a bit better
* Simplify ref/ assembly generation
- followup 1/2 for 5266918ed2
- correct the Razor.Tools project
- `%(Reference.Version)` metadata does not bleed through into `@(PackageReference)` items
- much more work to do so than to add this special case
- remove `$(Razor_NewtonsoftJsonPackageVersion)`
- remove RTMVersions project and use RepoTasks instead
- make it an error if RepoTasks is not restored before anything else builds
- add items and properties for System.Security.AccessControl
nits:
- remove invalid (ignored) metadata in Directory.Build.props and AzureAppServices.SiteExtension project
- improve / extend a couple of comments
- move `@(Reference)` items together in Microsoft.AspNetCore.Razor.Tools
* Remove all ref/ projects
* Remove GenAPI infrastructure
* Remove notion of a reference assembly project
- remove `$(IsReferenceAssemblyProject)`, `$(ReferenceReferenceAssemblies)` and `$(ReferenceImplementationAssemblies)`
- remove unnecessary `$(NoWarn)` settings
nits:
- remove a few misleading comments
- wrap some long lines
* Move .0 package version workaround into Versions.props
- touch up SharedFramework.External.props
* Expose `%(LatestPackageReference.RTMVersion)` metadata
- automate use of properties in the `@(LatestPackageReference)` item group to make this maintainable
- add a couple of special cases at the bottom of eng/Dependencies.props
- add one more `$(...PackageVersion)` property to avoid yet-another special case
* Enable Roslyn reference assemblies
- exclude ref/ assembly from packages other than targeting pack
- update Microsoft.AspNetCore.App.Ref.csproj
- `%(IsReferenceAssembly)` and `%(ReferenceGrouping)` metadata no longer relevant
- only ref/ assemblies are in `@(ReferencePathWithRefAssemblies)` item group
nits:
- remove now-unnecessary workaround
- issues with TFM transition are behind us
- clean up Microsoft.AspNetCore.App.Runtime.csproj slightly
- use `GeneratePathProperty="true"`
- reorder item / property settings for meta-expansion
- correct spelling errors and phrasing in comments
* Update documentation to reflect recent changes
- remove CrossRepoBreakingChanges.md; was tied to old TeamCity infrastructure
- also much less relevant given repo merges
- adjust details and examples in ReferenceResolution.md
- reflect repo merges, Dependencies.props changes, and current Maestro++ channels
- add a few more details e.g. specific files where Version.Details.xml versions are used
* !fixup! Remove another irrelevant doc file
* !fixup! Address PR review suggestions
- convert a couple of warnings to errors
- use consistent casing for Microsoft.NETCore.App.Runtime.* packages
- reduce `%(LatestPackageReference.Version)` metadata special cases
- add and improve comments e.g.
- improve comments about `$(*V0PackageVersion)` properties
- improve placement of comments about item removal in ResolveReferences.targets
- confirmed `$(*V0PackageVersion)` property list is complete
nits:
- fix solution example in ReferenceResolution.md
- remove item group definition for `@(LatestPackageReference)`
- remove `%(LatestPackageReference.VersionName)` metadata after use; large item group
- similarly, remove `%(LatestPackageReference.RTMVersion)` when not needed; just complicates `Condition`s
When I squash, I must remember this fixes
- #14801
- dotnet/aspnetcore-internal#2693
* Actually use `%(LatestPackageReference.RTMVersion)` metadata
- gather RTM package references in a new project
- a (very) separate project to work around package conflict resolution
- empty `Test` target works around Arcade's testing approach
- new target in ResolveReferences.targets updates relevant assembly paths to use the RTM packages
- done as soon as possible after `ResolvePackageAssets` determines the paths
- done for all compilation inputs, not just ref/ assemblies
* Move to latest NuGet.exe
- 5.3.0 -> 5.6.0
- should improve performance and may improve reliability
* Also switch from NuGet.Build.Tasks to NuGet.Packaging
- move to 5.6.0 version here too
- reduce transitive dependencies; we don't need them all
* Migrated protected browser storage.
* Added E2E tests.
* Added safeguard against using ProtectedBrowserStorage in wasm.
* Added TryGetValue.
* Added Microsoft.AspNetCore.Components.Web.Extensions
* Minor cleanup
* Moved ProtectedBrowserStorage out of Web.JS.
* Delete Microsoft.AspNetCore.Components.Web.Extensions.netcoreapp.cs
* Updated ProjectReferences.props
* Improvements and cleanup.
* Update Microsoft.AspNetCore.Components.Web.Extensions.csproj
* Added Web.Extensions to the VS solution.
* Prepare for strict coherency
Strict coherency means that if your repo declares a dependency with a CPD attribute, the CPD parent must have a direct dependency on that dependency.
This means for aspnetcore that it should add a dependency on System.Resources.Extensions because aspnetcore-tooling needs it.
Reasons for this approach over the current approach:
- This eliminates some ambiguous tie-breaking scenarios that are very problematic and dangerous in servicing
- Those tie breaking scenarios require the use of BAR to break the ties. If the DB data were to be lost then the tie-breaking would do unexpected things.
All rules are currently disabled, except for one that I enabled for
src/Http via a new ".editorconfig" file I added there.
Other changes:
* Allow editorconfigs in MVC and Razor to flow to the root
* Consolidate a few editorconfig settings
* Tweak Ruleset config in Azure/AzureAD where it clashed.
Addresses the beginning of #9620, but it's a fair chunk of work to
enable most rules through the whole repo. That can be done directory by
directory and rule by rule by dropping .editorconfig files though.
dotnet-maestro[bot]
Pranav K
Doug Bunting
juanam
Hao Kung
Safia Abdalla
John Luo
Anirudh Agnihotry
Tanay Parikh
William Godbe
Mackinnon Buck
Matt Mitchell
Kevin Pilch
Steve Sanderson