0bb3f18049
Add support for BadRequest in RazorPages ( #7097 )
...
Addresses #7095
2017-12-01 12:03:24 -08:00
6b2a702ff4
Handle line ending differences in a few tests
...
- #6205
- combine `TagHelpers_SupportsPathNavigation()` and `TagHelpers_SupportsRelativeNavigation()` into one
nit: remove a few unnecessary `.Trim()` calls
2017-11-30 21:18:42 -08:00
e6c716444d
Add a <partial /> tag helper
...
Fixes #5916
2017-11-30 17:08:47 -08:00
9dc9381ae4
Re-order execution in CacheTagHelper to avoid setting the result too early
...
Re-enable skipped tests
Fixes #7042
2017-11-20 10:03:47 -08:00
5fffd464cd
Support input type "week" ( #7045 )
2017-11-16 16:00:15 -08:00
b6144142fe
Update samples and tests to target netcoreapp2.1
2017-11-13 14:58:40 -08:00
a01e23250f
Preparing to update to 2.2 SDK
2017-11-09 16:25:51 -08:00
bcaee8df4e
Disable broken Anti-forgery tests
2017-11-09 09:46:59 -08:00
d9825d1547
Better JSON deserialization errors. Implements #4607 , #4862
2017-11-06 23:02:13 +00:00
ab4c519dd5
Infer multipart/form-data for FromFile parameters
2017-11-02 09:36:31 -07:00
2e4bc548f5
Pin tool and package versions to make builds more repeatable ( #7013 )
2017-10-31 19:18:14 -07:00
8946a68923
Infer binding sources for ApiController parameters
...
Fixes #6847
2017-10-16 15:20:43 -07:00
b992ef0ced
Add tests to ApplicationModelTest ( #6932 )
...
Addresses #756
2017-10-10 11:24:03 -07:00
7ba167fcd8
Add 'default response' to API Response Type
...
Also some cleanup and unit tests.
2017-10-09 19:48:52 -07:00
3bfb023679
Update how PackageReference versions are set
...
Changes:
- Remove floating versions
- Disable myget feeds during a Universe build
- Use package-specific MSBuild variables. Pattern = `packageId.Pascalize() + "PackageVersion"`, with a few exceptions.
2017-10-09 11:11:24 -07:00
9fbb2f1141
Simplify collection initialization ( #6897 )
...
- Addresses VS message "IDE0028 Collection initialization can be simplified"
2017-10-04 14:12:43 -07:00
2fcfc6be7c
Add EnableRangeProcessing ( #6895 )
...
Addresses #6780
2017-09-29 18:39:45 -07:00
83c3ac62fb
Updated formatters to wrap exceptions in InputFormatException for invalid input
2017-09-22 14:33:17 -07:00
5d1603c37f
Replace ProblemDetailsAttribute with ApiControllerAttribute
2017-09-22 10:26:13 -07:00
197ef139d6
Provide a way within the Page/PageModel to run code before any handler runs
...
Fixes #6606
2017-09-22 09:25:22 -07:00
236ef5d1d1
Support validation and BindBehavior on top-level action parameters and bound properties. Fixes #6790
2017-09-22 10:13:48 +01:00
7f214492b8
Introduce a filter to send bad request results with details when ModelState is invalid ( #6849 )
...
* Introduce a filter to send bad request results with details when ModelState is invalid
Fixes #6789
2017-09-21 11:09:32 -07:00
85f3c841f1
Revert "Revert "Improvements to the testing package.""
...
This reverts commit 7b28334c41
2017-09-19 21:45:05 -07:00
7b28334c41
Revert "Improvements to the testing package."
...
This reverts commit 96bd2769d0
2017-09-19 18:02:53 -07:00
96bd2769d0
Improvements to the testing package.
...
* Detect a ConfigureDefaultBuilder static method on Program.cs of the test site
and use it to initialize the IWebHostBuilder instance that we configure for testing.
* Make use of the new service configuration extensibility points in Hosting to override
services for testing.
* Get rid of MvcWebApplicationBuilder and move MVC specific methods into extension methods.
2017-09-18 18:12:01 -07:00
fd9cb08790
Add Switch.Microsoft.AspNetCore.Mvc.UseDateTimeTypeForDateTimeOffset quirks mode
...
- patch recipients can use switch to undo the #6648 fix
2017-09-18 15:13:43 -07:00
6041c6b966
Auto-select `type="text"` for `DateTimeOffset` values
...
- cherry-picked from 7e4a8fe#6648
- a different take on #4871
- `DateTime` can also round-trip `DateTimeKind.UTC` with `[DataType("datetimeoffset")]` or `[UIHint("datetimeoffset")]`
- since they're now handled differently by default, add more `DateTime` tests
- expand tests involving `Html5DateRenderingMode.CurrentCulture`
nits: make VS-suggested changes to files updated in this PR
2017-09-18 15:13:33 -07:00
9f5e4eb483
Allow "page" route parameter to be used in Mvc controllers
...
Fixes #6660
2017-09-18 15:02:13 -07:00
23b7d8f62a
Added RequestFormLimits filter.
...
[Fixes #5128 ] Overriding Request Form max upload limit
2017-09-18 13:48:15 -07:00
b3aa691549
Add EnableRangeProcessingSwitch for FileContentResult and Fil… ( #6839 )
...
Addresses #6792
2017-09-18 10:57:49 -07:00
c13cef6a74
Injecting IViewLocalizer into Razor Page causing IndexOutOfRangeException
...
Fixes #6694
2017-09-15 15:58:32 -07:00
776c2604f8
Introduce opinionated API defaults.
...
* Introduce ProblemDescriptionAttribute to enhance some 4xx messages and produce better API description.
* Introduce IErrorDescriptionProvider to modify the shape of error response.
Fixes #6785 , Fixes #6786
2017-09-14 17:07:34 -07:00
037c1ec47d
Make @inherit + Razor Pages + _ViewImports work
...
Fixes #6769
2017-09-14 12:34:00 -07:00
4f18d99d02
Added RedirectToAction overload with no arguments
2017-09-12 17:17:48 -07:00
06f6de6c11
Changed RequestSizeLimitAttribute to create an authorization filter rather than a resource filter.
...
[Fixes #6777 ] RequestSizeLimit is ignored
2017-09-12 17:03:24 -07:00
de38922601
Allow BindPropertyAttribute to be applied on PageModel
...
Fixes #6653
2017-09-12 10:34:19 -07:00
63397653fa
Make DefaultApiDescriptionProvider understand ActionResult<T>
...
Fixes #6784
2017-09-11 14:20:38 -07:00
6bf165f22f
Update default Razor search paths to include ~/[PagesRoot]/Shared
...
Fixes #6604
2017-09-11 14:11:39 -07:00
3beb310866
Avoid saving TempData in case of unhandled exceptions. [ Fixes #6598 ] BUG? Accessing TempData prevent response to have content on error.
2017-09-07 13:13:27 -07:00
717f1e6f7d
Normalize paths in RazorViewEngine prior to invoking page factory
...
Fixes #6672
2017-09-07 11:36:31 -07:00
151cf44607
Introduce ActionResult<T>
2017-09-06 18:46:06 -07:00
bac68ba3c2
Injecting IViewLocalizer into Razor Page causing IndexOutOfRangeException
...
Fixes #6694
2017-09-06 13:54:38 -07:00
7e4a8fe479
Auto-select `type="text"` for `DateTimeOffset` values
...
- #6648
- a different take on #4871
- `DateTime` can also round-trip `DateTimeKind.UTC` with `[DataType("datetimeoffset")]` or `[UIHint("datetimeoffset")]`
- since they're now handled differently by default, add more `DateTime` tests
- expand tests involving `Html5DateRenderingMode.CurrentCulture`
nits: make VS-suggested changes to files updated in this PR
2017-09-05 16:05:13 -07:00
16c267d95e
House Cleaning - Spelling and grammar 🚿
2017-08-30 14:58:44 -07:00
b811e69d00
Use PackageLineup to manage PackageReference versions
...
- Move the Mvc.Performance project from test/ to benchmarks/.
- Remove the Version attribute on PackageReference.
- Add a reference to two PackageLineup's.
- Add snippet to README explaining the additional requirement to run build.cmd /t:restore.
- Add a target to check that packages have been pinned.
2017-08-30 12:14:11 -07:00
b2f9ad1b67
Changed CookieTempDataProvider's CookieSecurePolicy from SameAsRequest to None
2017-08-29 14:55:52 -07:00
ca6c76c358
Add a test where [Ignore..] gets overridden
...
Fixing a small gap in our AF functional tests.
2017-08-25 13:55:27 -07:00
7b2a4ff465
Allow "page" route parameter to be used in Mvc controllers
...
Fixes #6660
2017-08-24 15:44:37 -07:00
900a5c7c4c
Add support for ResponseCache in Razor Pages
...
Fixes #6437
2017-08-18 16:25:40 -07:00
3e8da43279
Pinning versions for 2.0.0
2017-08-17 15:00:47 -07:00
3a710c3d64
Upgrade to xunit 2.3.0-beta4
2017-08-17 10:45:03 -07:00
b43b244830
Use Directory.Build.props/targets
2017-08-16 12:30:13 -07:00
5fee1cac83
Merge pull request #6655 from aspnet/rel/2.0.0
...
Refactor CORS support out of MVC Core
2017-08-14 16:50:14 -07:00
f2a8c1cea7
Refactor CORS support out of MVC Core
2017-08-14 11:40:56 -07:00
6eba0e2128
Merge pull request #6578 from aspnet/rel/2.0.0
...
Rel/2.0.0
2017-07-21 10:51:10 -07:00
a5b55edb93
Fix filter order ( #6577 )
...
* Fix filter order
2017-07-21 10:50:34 -07:00
1810925b13
Add _ViewStart and _ViewImports to embedded view test
2017-07-14 10:34:29 -07:00
9e2f8b7cb5
Comment on remaining PackageTargetFallbacks
2017-07-07 15:01:07 -07:00
e1c1682065
Testing infrastructure cleanup
2017-07-07 13:18:42 -07:00
fc106ab793
Revive call to FormattingUtilities in XmlDataContractSerializerOutputFormatter
...
Fixes #6235
2017-07-07 10:11:28 -07:00
a23307e2b1
Check for properties that can't befound
...
If you give ModelExpressionProvider a lambda with a private property
you'll end up here. This wasn't common before, but it seems like users
are more likely to try it with pages.
Model Metadata and Model Binding don't handle private properties, so
supporting it in Model Expressions seems less than useful.
This isn't a breaking change because this case would have resulted in a
null-ref. Addresses #6400
2017-07-04 13:26:17 -07:00
d917504c14
[ Fixes #6468 ] Clean up the productionized testing infrastructure
2017-07-03 10:15:06 -07:00
579aca0121
Define semantics for pagemodels
...
Fixes #6210
Now a pagemodel requires a [PageModel] somewhere in it's hierarchy. We
don't do a guess at whether or not your model class is a PageModel.
2017-06-29 09:24:57 -07:00
8df3032540
Add support for specifying filters on page models.
...
Fixes #6334
2017-06-28 14:43:02 -07:00
d1813a7cd7
Normalize paths returned by view location expanders
...
Fixes #6448
2017-06-27 08:48:07 -07:00
0ad9c7d4eb
Making Pages Binding Consistent
...
This changeset reckonciles the binding work we did for pages with
controllers.
A quick summary:
- Moves [BindProperty] to the MVC namespace (#6401 )
- Makes [FromRoute] and friends behave consistently (#6402 )
- Makes [BindProperty] work with controllers (untracked)
2017-06-26 18:11:44 -07:00
e5da44a82f
Generate full pdbs for views on desktop and re-enable runtime error tests ( #6442 )
...
* Generate full pdbs for views on desktop and re-enable runtime error tests
StackTraceHelper \ PortablePdbReader used by Diagnostics is only useful for
reading portable pdbs on disk. However pdbs produced by views are entirely
in memory and therefore cannot be read. Consequently
we choose to generate full pdbs for views on Windows (when possible).
2017-06-26 10:46:12 -07:00
052db40567
Fix documentation and target files issues
2017-06-23 19:09:45 -07:00
35152d5933
[ Fixes #6233 ] Productionize and harden our functional testing infrastructure
2017-06-23 18:12:41 -07:00
aa5a348385
_ViewStart.cshtml not picked up when added to the root of the app
...
Fixes #6308
2017-06-23 08:25:58 -07:00
9d138affa2
Suppress JsonPatchDocument validation ( #6429 )
...
Addresses aspnet/JsonPatch#80
2017-06-22 14:14:11 -07:00
c89f0a1e43
Allow AddPageRoute to route to pages root. ( #6412 )
...
* Allow AddPageRoute to route to pages root.
Fixes #6338
2017-06-20 12:33:33 -07:00
3fc3d8d060
Merge branch 'rel/2.0.0-preview2' into dev-gate
2017-06-15 03:48:49 -07:00
0c6460ab64
Changed WebApiCompatShim projects to use PackageTargetFallback
2017-06-14 16:08:04 -07:00
8832014516
PackageTarget->AssetTarget
2017-06-14 15:03:43 -07:00
e51d3c262c
Merge branch 'rel/2.0.0-preview2' into dev
2017-06-06 13:13:11 -07:00
3448b6a74e
Re-enable net461 functional tests.
...
aspnet/Coherence-Signed#540
2017-06-06 13:10:29 -07:00
7ffd88757d
Respond to RangeHelper refactor ( #6348 )
...
Respond to https://github.com/aspnet/StaticFiles/pull/200
2017-06-06 11:22:35 -07:00
597a0c9a11
Add support for friendly routes in pages
...
FIxes #6325
2017-05-26 14:29:00 -07:00
ad6b029443
Temporarily disable MVC functional tests on net461
2017-05-25 21:10:01 -07:00
9ea37a1bbb
Fix TFM build breaks
2017-05-25 13:12:39 -07:00
03404cd3df
Return to NetStandard
2017-05-25 10:34:16 -07:00
c1dd95be2a
Add a test for #6294
...
This case was fixed by 2992f8e
2017-05-24 16:53:30 -07:00
a6d97d35e3
Add back support for AddTagHelpersAsServices
...
This doesn't go through the Razor tag helper discovery pipeline because
this can really only ever work for ITagHelper based taghelpers. So
there's really no point in reusing that logic, which would be hard
anyway.
2017-05-23 14:04:42 -07:00
53c56f558b
React to StringSegment changes
2017-05-23 14:01:44 -07:00
3c7a2dc847
Revert "Temporarily skipping error page middleware test"
...
This reverts commit d916cfeadd
2017-05-23 13:23:52 -07:00
e681c23d5c
Add ITagHelperComponentManager ( #6302 )
...
Addresses #6282
2017-05-23 13:22:15 -07:00
04f74edd85
Revert "Disable building and testing FSharpWebSite to unblock the mirror when using latest CLI"
...
This reverts commit b28002a9e5
2017-05-23 13:20:36 -07:00
9aff0a67c1
Range support for FileResult( #6150 )
...
Addresses #3702
2017-05-19 10:51:46 -07:00
d70bfdd1ea
Upgrade test framework versions and fix test issues
2017-05-15 14:11:27 -07:00
b28002a9e5
Disable building and testing FSharpWebSite to unblock the mirror when using latest CLI
2017-05-13 19:32:51 -07:00
d916cfeadd
Temporarily skipping error page middleware test
2017-05-12 14:39:19 -07:00
08965550ad
Re-enable error page runtime test.
...
- This was previously broken due to the shared framework not being able to find the file responsible for an exception.
#6120
2017-05-10 14:33:10 -07:00
debc3dd433
Functional test to show FSharpAsync works end-to-end ( #6240 )
2017-05-08 19:30:01 +01:00
87bb1d0ff5
Refactor GenerateCheckBox ( #6229 )
...
Addresses #5981 and #5983
2017-05-05 11:53:53 -07:00
a80594d706
Add FSharpWebSite plus simple functional test against it ( #6231 )
2017-05-05 19:08:36 +01:00
64ffcfaa89
Merge pull request #6236 from aspnet/rel/2.0.0-preview1
...
Change TFM to netcoreapp2.0 (#6234 )
2017-05-04 22:18:48 -07:00
1c5e417606
Change TFM to netcoreapp2.0 ( #6234 )
...
* Change TFM to netcoreapp2.0
2017-05-04 18:11:26 -07:00
6f3a295041
React to new ObjectMethodExecutor in Common
2017-05-03 15:40:02 +01:00
8bece90c83
Fix asp-page-handler to generate form tags correctly.
...
- Prior to this change using asp-page-handler on its own did not create correct `<form>` elements. There were multiple issues, one as that the `FormTagHelper` would purposefully drop into a no-op code path. Second is the `DefaultHtmlGenerator` didn't call through to the `UrlHelper` correctly.
- Added functional test cases to validate asp-page-handler can live on its own on a form tag. This also included adding a variant where method="post".
- Added a `FormTagHelper` unit test to validate the `PageHandler` property is consumed properly.
#6208
2017-04-27 10:32:04 -07:00
f165914b40
Update how `FormTagHelper` handles `get` method attributes.
...
- Added functional test to verify `asp-*` attributes on form taghelpers work as expected.
- Added a unit test to validate `FormTagHelper` behaves as expected.
- Moved `Method == "get"` checks into appropriate code paths. These include the one where a user specifies an empty or non-existent `action` attribute and where a user doesn't utilize any `asp-*` attributes. In the later, we default `Method` to `"get"` if it's not provided.
#6006
2017-04-25 15:17:15 -07:00
42b988ad88
./ paths relative on page.
2017-04-25 11:57:58 -07:00
649ee4d28d
Add support for page handler to URL generating APIs.
2017-04-24 22:56:58 -07:00
ef0333ac6a
Add Antiforgery to the FormTagHelper pre-check for processing.
...
- Added a test case to the HtmlGeneration functional test (the one verifying complex FormTagHelpers).
- Added unit test verifying antiforgery behavior when it's the only provided parameter.
#6006
2017-04-24 21:46:54 -07:00
5c8a161ace
Change `FormTagHelper` to apply to all form tags.
...
- Added functional test to validate that non-attributed form tags have an antiforgery input generated. Re-generated baseline to reflect changes.
- Added a unit test to validate that parameterless `FormTagHelper`s behave as expected.
#6006
2017-04-24 18:39:01 -07:00
ccdaa5a729
Make /Pages the default root for pages.
...
Fixes #6184
2017-04-24 15:46:32 -07:00
04fd762943
Rename form-action -> handler
2017-04-24 14:15:35 -07:00
68866f8716
Added functional tests for JsonPatch
2017-04-23 09:09:08 -07:00
ca017eced2
Add page to AnchorTagHelper and FormTagHelper
...
Fixes #6088
2017-04-21 18:12:54 -07:00
f568d3c2bc
Support finding "sibling" pages when using RedirecToPage
...
Fixes #6083
2017-04-21 18:12:52 -07:00
297196baa0
Design updates to handler methods and binding
...
Implements #6091 , #6072 , #6090 , #5927
2017-04-21 17:29:25 -07:00
908b4c8d62
FormAction from QueryString
2017-04-21 15:04:37 -07:00
83faaebdb6
Upgrade Roslyn dependency to 2.0.0.
...
- Added C# 7 unit and functional test to validate features work end-to-end.
#6149
2017-04-21 11:41:31 -07:00
681b798a2e
RedirectToPage doesn't trim /Index from URL
...
Fixes #6080
2017-04-20 11:15:45 -07:00
4bf518b09b
Fix #6140 - Allow linking between controller and page
...
The issue here is that route values used for action selection are
'global'. That means that pages need to have a 'null' route value for
'action' and controllers need to have a 'null' route value for pages. This
is the same way that areas work.
The fix is to move the 'merge' of route values up to a level where pages
and controllers can work together. Since ADPs use the russian-doll
pattern, the fix is to run this 'merge' in the controller ADP, but after
all of the ADs have been created.
2017-04-19 16:48:38 -07:00
c9bfd2296d
Parity between Controller and Page/PageModel
2017-04-19 15:02:06 -07:00
a8eb5bee70
Implement view search for pages
...
The View Engine now needs to know about pages :(. This isn't ideal but the
view engine needs to know what set of search paths to use. This was
already hardcoded for controllers vs controllers + areas. It felt right to
further hardcode instead of introduce a wierd abstraction that we only
use.
Additionally pages use a view location expander to implement an ascending
directory search.
2017-04-18 16:11:24 -07:00
8fa95d66d4
Add support for suppressing inbound and outbound routing
2017-04-14 17:02:45 -07:00
ed3aa4d918
Adding functional tests for @namespace
2017-04-14 14:47:29 -07:00
3eae7cc393
Add AggregateExceptionTest ( #6135 )
...
Test for aspnet/Common#215
2017-04-14 14:20:31 -07:00
3474bdf776
RedirectToPage from a form-action handler includes the formaction
...
Fixes #6104
2017-04-12 09:27:08 -07:00
106b34867d
Temporarily skipping ErrorPageMiddleware functional test to unblock mirror
2017-04-11 17:40:01 -07:00
59a3aade9b
Fix [TempData] for PageModel's
2017-04-11 16:45:44 -07:00
90acd055fe
Make [FromBody] treat empty request bodies as invalid ( #4750 )
2017-04-10 16:55:14 +01:00
1e7972bd8f
Add convenience methods for redirecting from a Razor Page back to itself
...
Fuxes #5953
2017-04-07 10:03:42 -07:00
4032de064e
Removing _PageStart.cshtml
...
Pages now also use _ViewStart.cshtml
Also contains some naming/text cleanup that was missed in the previous
commit.
2017-04-06 08:14:37 -07:00
3424e20c67
Re-enable skipped test
2017-04-04 19:25:50 -07:00
925ad75cdf
Add convenience methods for redirecting to another Razor Page
...
Fixes #5956
2017-04-04 14:36:22 -07:00
e5ccac8bf6
Add functional tests for RazorPage routes
2017-04-04 11:14:52 -07:00
3ab9feca3a
Temporarily skipping failing test
2017-04-03 23:24:09 -07:00
fe3d45fad1
Adding AllowAnonymousToPage & AllowAnonymousToFolder
...
Fixes #5884
2017-03-31 20:17:31 -07:00
4f351bd37c
Add support for media type suffixes ( #5273 , #6032 )
2017-03-31 10:20:43 +01:00
1672820e4e
Add functional test covering an `IList<T>` property
...
- #5656
2017-03-29 12:32:06 -07:00
eda5028cf4
Add TagHelperComponentTagHelper
...
Addresses #5728
2017-03-29 11:29:24 -07:00
b22326323a
Add properties to Page and PageModel
...
Fixes #6008
2017-03-28 13:26:38 -07:00
e7101f248a
Support model binding to Razor Pages properties on page and PageModel classes
...
Fixes #5952
2017-03-24 07:45:19 -07:00
badb6ce8e5
Remove net451 as a cross-compile target
2017-03-22 06:32:50 -07:00
e6cb639cc0
Add handler functional test
2017-03-20 10:05:29 -07:00
1197657e5b
TempData property attribute
...
Addresses #5600
2017-03-16 16:34:35 -07:00
6f7717a381
Unify dependency versions to one file
2017-03-15 16:54:32 -07:00
bee1a55cff
Use RazorPagesOptions.RootDirectory when looking for page hierarchies.
...
Fixes #5915
2017-03-14 18:56:50 -07:00
82d87df166
Fix warning as error
2017-03-14 12:44:57 -07:00
365ae19c8b
Add InvalidTagHelperIndexerAssignment to RazorPageBase
2017-03-14 10:04:15 -07:00
1c74e31715
Add tests for PageActionInvokerProvider ( #5882 )
2017-03-09 16:19:20 -08:00
7f3f6957be
Set path in DefaultPageFactory ( #5911 )
2017-03-09 16:15:43 -08:00
d9d280d1ef
Make CookieTempDataProvider the default ITempDataProvider ( #5892 )
2017-03-07 16:04:47 -08:00
4a20c849cb
Add functional test for Page.View() ( #5896 )
2017-03-06 16:19:41 -08:00
5c96a7cdef
Use an alternate workaround for #5873
...
- use specific workaround for Microsoft/vstest#428
- generating an executable for a test project is a bit too weird
- also work around dotnet/sdk#926
- generating an executable covered this as well
nit: add and update comments about other workarounds in the functional tests project
2017-03-06 14:05:21 -08:00
145d27f9b3
Add a PagesOption type that allows configuring the root for Page file discovery
...
Fixes #5785
2017-03-03 17:20:07 -08:00
85e28ae478
Trim quotes from template ( #5838 )
2017-03-03 09:52:36 -08:00
Jass Bagga
Doug Bunting
Pranav K
Chris Ross (ASP.NET)
Steve Sanderson
Nate McMaster
Ryan Nowak
Nate McMaster
Mike Harder
Kiran Challa
Javier Calvarro Nelson
Ryan Brandenburg
bchavez
N. Taylor Mullen
Chris R
Steve Sanderson
Ajay Bhargav Baaskaran
Hisham Bin Ateya