Commit Graph

19194 Commits

Author SHA1 Message Date
Javier Calvarro Nelson 8e1e81ae78
[HTTPS] Update certificate strategy for Mac OS (#20022)
* Fixes and improvements for dotnet-dev-certs:
* Revamps the HTTPS developer certificate tool implementation.
  * It accumulated a lot of cruft during the past few years and that has made making changes harder.
* Separated the CertificateManager implementation into different classes per platform.
  * This centralizes the decision point of choosing a platform in a single place.
  * Makes clear what the flow is for a given platform.
  * Isolates changes needed for a given platform in the future.
* Moved CertificateManager to a singleton
  * No more statics!
* Updates logging to use EventSource
  * We didn't have a good way of performing logging as the code is shared and must run in multiple contexts and the set of dependencies need to be kept to a minimum.
  * Adding ETW allow us to log/monitor the the tool execution and capture the logs with `dotnet trace` without having to invent our own logging.
  * We can decide to write an EventListener in `dotnet-dev-certs` to write the results to the console output.
* Updates the way we handle the dev-cert in Mac OS to use the security tool to import the certificate into the store instead of using the certificate store.
2020-04-16 13:52:10 -07:00
Ryan Brandenburg 820b0b20c0
Remove SPA project template tests (#20863) 2020-04-16 09:19:05 -07:00
Sébastien Ros 5b5784d950
Merge pull request #20873 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-04-15 15:50:25 -07:00
Sébastien Ros b243ae1615
Fixing QueryCollection property documentation (#20044)
* Fixing QueryCollection property documentation

* Update src/Http/Http/src/QueryCollection.cs

Co-Authored-By: Chris Ross <Tratcher@Outlook.com>

Co-authored-by: Sourabh Shirhatti <shirhatti@outlook.com>
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
2020-04-15 22:28:43 +00:00
Sébastien Ros 998ebad707
Merge branch 'master' into merge/release/3.1-to-master 2020-04-15 13:01:24 -07:00
David Fowler 1b99352ec7
Don't re-use DefaultHttpContext if IHttpContextAccessor is in use (#15049) (#20844)
* Don't re-use DefaultHttpContext if IHttpContextAccessor is in use
- Consumers may still get null or an ODE but will never end up with data from a different request.
- Make sure an ODE is thrown from all properties on HttpContext after the request is over.
2020-04-15 12:41:59 -07:00
Brennan 5353ce9509
Use SemVer1 for SiteExtension (#20839) 2020-04-15 12:26:21 -07:00
WuYafeng 377b9e5e09
Inconsistency between file `BuildServiceProviderAnalyzer.cs` and type `BuildServiceProviderValidator` (#20804) 2020-04-15 09:38:53 -07:00
Stephen Halter ea555458dc
Always flush HTTP/2 headers despite flow control (#20831) 2020-04-15 09:22:27 -07:00
BrennanConroy 260de2c10b Add BuildNumber to SiteExtension build 2020-04-14 13:42:25 -07:00
William Godbe 01429973ee
[release/3.1] Pass access token as query string when running SignalR in the browser (#20466)
* Pass access token as query string when running SignalR in the browser

* WEBASSEMBLY -> BROWSER
2020-04-14 12:59:06 -07:00
Alessio Franceschelli 970c9244c7
ModelValidation: Fixed MaxDepth exception when there are more items left then MaxValidationDepth after reaching MaxAllowedErrors (#18212)
* Consolidated similar tests in a theory

* Fix for InvalidOperationException when reached maxAllowedErrors and there are more items left then max depth

* Refactored Visitor logic to reduce the risk of a missing Pop.

* Added comment on when it can throw

* Updated reference assembly

* Reverted publid API change
2020-04-14 12:45:20 -07:00
William Godbe 8218d6e0e7
Fix various "Type or namespace not found" errors (#20736)
* Add manual packageReferences where needed

* Add more explicit packageRefs

* Fix typo

* undo changes to blazor.server.js

* Fix typo

* Don't gen ref assemblies in CodeCheck
2020-04-14 10:57:26 -07:00
N. Taylor Mullen e7df020906 Quarantine AppCanHandleClientAbortingConnectionMidRequest. 2020-04-14 10:39:31 -07:00
Wayne Adams 75c779773f
Add missing OffsetX and OffsetY events to MouseEventArgs. (#20478)
* Add missing OffsetX and OffsetY events to MouseEventArgs.
* Update public interfaces
* Generate Reference Assemblies
2020-04-14 10:00:32 -07:00
Thomas Levesque 5d914d4d2d
Implement HttpRequestStreamReader.ReadToEndAsync (#18232) 2020-04-13 23:40:21 -07:00
Helgevold Consulting, LLC 70daed535a
Allow access to msgpack configuration options (#20438) 2020-04-13 21:58:03 -07:00
Ben Adams 6016e70285
Make header parsing "safe" (#20562)
* OnHeadersComplete improve speculation and memory ordering (VTune)
2020-04-13 09:46:43 -07:00
Alessio Franceschelli e3d3da3546
HttpRequestStreamReader overrides for Read Span, ReadAsync Memory, ReadLine and ReadLineAsync (#18802) 2020-04-13 08:18:12 -07:00
Brennan 2b7b79f4db
Fix flaky HealthCheck test (#20741) 2020-04-11 17:22:22 -07:00
Pranav K 3c1bd093e9
Print disk usage (#20704)
* Print disk usage
* Try again
* Disk util part3
* dont look at /tmp
* Remove max-depth
* Add disk usage stats to all non-windows platforms
* Disable Ubuntu quarantined test step
* Apply suggestions from code review
  - Make thingies worky on macOS
* Update .azure/pipelines/jobs/default-build.yml
* Undo skip of qurantined test run
* Update .azure/pipelines/jobs/default-build.yml
  - do not reference directory that doesn't exist
* Update .azure/pipelines/jobs/default-build.yml
  - reduce noise in Mac disk utilization output

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
2020-04-11 12:59:18 -07:00
Günther Foidl 810969084a
Replaced Span<T>.Fill(0) with Span<T>.Clear() (#20023) 2020-04-10 15:18:37 -05:00
Stephen Halter 5607ea1e0c
Remove workaround in HeaderPropagationMiddleware (#20533)
Fixed by #14146 which starts each request on a fresh ExecutionContext
2020-04-09 16:43:18 -07:00
Hao Kung 200f2c49be
Reenable sharedfx with arm64 queue skipped (#20659) 2020-04-09 12:24:03 -07:00
Javier Calvarro Nelson 5f7e1a0004
[Static web assets] Add comment about static web assets in CreateDefaultBuilder (#20653)
Updates the existing comment to indicate that we plug-in static web assets in development
2020-04-09 01:28:19 -07:00
Hao Kung 1bbca1502b
Revert "Reenable framework unit tests on helix (#19975)" (#20657)
This reverts commit 9a792f2a27.
2020-04-09 05:00:26 +00:00
John Luo 84a04c9df1
Quarantining tests (#20631)
* Quarantining tests

* Namespace collision
2020-04-08 12:53:53 -07:00
Brennan 8e50db65f3
Cleanup resources in Java client (#20473) 2020-04-08 12:48:50 -07:00
Jan Joneš 1d56c516f8 Implement `EmptyOrWhiteSpaceWriter.Encoding` 2020-04-08 11:59:18 -07:00
TeBeCo f3963e7cb7
Applying suggesting fix from https://github.com/dotnet/aspnetcore/issues/10422 and use "CopyToOutputDirectory" rather than "CopyToPublishDirectory" (#20274) 2020-04-08 09:57:32 -07:00
Michiel van Wessem ada3bdf45d
Fix max redirect count (#20428)
Without this change, RedirectHandler always follows MaxRedirects + 1. If MaxRedirects was initially set to 1, the body of the while statement is executed twice. This defect expresses itself when calling WebApplicationFactory<Startup>.CreateClient() with WebApplicationFactoryClientOptions.MaxAutomaticRedirections >= 1 and .AllowAutoRedirects = true in integration tests.
2020-04-08 09:50:43 -07:00
Alexey Ananyev f9ee790d02
Fix typo in a private method name (#20589)
`ApplicationPartManager` has a private method named `GetAsemblyClosure` containing a typo. It should be named `GetAssemblyClosure`.
2020-04-08 09:48:24 -07:00
github-actions[bot] f05b5c8576
Sync shared code from runtime (#20640)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-04-08 13:44:24 +00:00
Hao Kung 9a792f2a27
Reenable framework unit tests on helix (#19975) 2020-04-07 23:39:27 -07:00
John Luo 270013880d
Merge pull request #20484 from dotnet/johluo/remove-extensions-deps
Migrate analyzers from dotnet/extensions.
Pin Microsoft.Extensions.DiagnosticAdapter.
2020-04-06 14:48:41 -07:00
Chris Oliver b463e049b6
Move BadHttpRequestException to Http.Abstractions (#20339) 2020-04-06 14:42:16 -07:00
Kahbazi 1f76cce14a
Add overloads to CookieAuthentication to config options with services (#19268)
* Add overloads to CookieAuthentication to config options with services

* Update reference assembly

* Use the new method in sampple

* Add overloads for other authentication providers

* Update ref assemblies

* Change IServiceProvider to TService
2020-04-06 21:23:49 +00:00
John Luo 1cc6171b0a Fix tests 2020-04-06 11:56:22 -07:00
John Luo 6ad0d5849c
Merge branch 'master' into johluo/remove-extensions-deps 2020-04-06 11:17:56 -07:00
John Luo 3ec1676ac6
Ingest updated packages from dotnet/runtime (#20300) 2020-04-06 01:06:22 -07:00
Hao Kung cc79bcc67b
Reenable cert tests on helix (#20372) 2020-04-04 13:02:22 -07:00
John Luo 75bdd71ebc
Re-enable project template tests (#20529) 2020-04-03 17:48:15 -07:00
John Luo 59adb88839 Don't reference analyzer in framework projects since there's no code 2020-04-03 17:13:30 -07:00
Ryan Nowak 8e66833886
Merge pull request #20523 from dotnet-maestro-bot/merge/release/5.0-preview3-to-master
[automated] Merge branch 'release/5.0-preview3' => 'master'
2020-04-03 15:53:41 -07:00
Kevin Pilch f4be244fd1
More updates docs (#20513) 2020-04-03 22:09:36 +00:00
Ryan Nowak 27df28fada Skipping a Blazor template test
This test is causing hangs in quarantine. Adding an explicit skip.
2020-04-03 14:46:04 -07:00
John Luo 87c0f3e2cf Migration fixups 2020-04-03 14:41:31 -07:00
Ryan Nowak 2883a47542 Quarantine a hosting test that failed
This test failed overnight on linux. The part that failed was checking the exit code
of `kill` which is a little surprising. This implies that `kill` itself was also
forcibly killed - so we're increasing the timeout before we kill `kill`. 👍
2020-04-03 13:27:03 -07:00
Ryan Nowak 66ae2ba817
Merge branch 'master' into merge/release/5.0-preview3-to-master 2020-04-03 13:13:40 -07:00
Javier Calvarro Nelson 39a24220cf Use pfx file instead of cert from the store 2020-04-03 11:56:22 -07:00
John Luo 8fac70750e
Merge pull request #20421 from dotnet/johluo/migrate-more-extensions-logging
Johluo/migrate more extensions logging
2020-04-03 11:49:22 -07:00
John Luo 5e81b276a7 Use migrated analyzers 2020-04-03 11:46:49 -07:00
John Luo 52d0f31c3f Merge branch 'master' of ..\Extensions\ into johluo/remove-extensions-deps 2020-04-03 11:40:13 -07:00
Ryan Brandenburg cb523d73e2
Remove test that hits HTTP (#20476) 2020-04-03 11:28:27 -07:00
Adam Sitnik 54b4a0ffa2
add micro benchmark for parsing Json TechEmpower request (#20505) 2020-04-03 11:09:17 -07:00
Scott Addie e75ff49869
Preserve new lines and whitespace when adding secret (#19504) 2020-04-03 17:37:46 +00:00
Andrew Stanton-Nurse dee14b7eb5
fix #13651 by logging serialization failures as error (#20116) 2020-04-02 23:41:34 -07:00
TeBeCo c01c8dd476
Changing msgpack options (#20031) 2020-04-02 17:41:40 -07:00
Ben Adams f17520c6f0
Start each request on fresh ExecutionContext (#14146) 2020-04-02 17:26:22 -07:00
James Newton-King 746ac6bc8f
Fix flaky StreamPool_MultipleStreamsInSequence_PooledStreamReu… (#20434) 2020-04-03 10:10:46 +13:00
Ryan Nowak 2c1de1621e Social distancing for tests that are symptomatic
These tests failed in official builds last night.
2020-04-02 12:52:51 -07:00
James Newton-King 53eaa8f106
Fix flaky StreamPool_StreamIsInvalidState_DontReturnedToPool (#20433) 2020-04-03 08:23:13 +13:00
John Luo f4a4346298 Because jkotalik told me to 2020-04-02 11:58:26 -07:00
Ryan Nowak 5f8bb71608
Merge pull request #20456 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-04-02 11:18:00 -07:00
Ryan Nowak 7bb31301d2
Merge pull request #20384 from dotnet-maestro-bot/merge/release/5.0-preview3-to-master
[automated] Merge branch 'release/5.0-preview3' => 'master'
2020-04-02 10:55:15 -07:00
William Godbe 39b9c7baf9
Merge pull request #20396 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-04-02 09:19:09 -07:00
John Luo fcb23108b6 Relocate Logging.Testing to AspNetCore.Testing 2020-04-02 00:16:01 -07:00
John Luo 5f6fbed915
Merge branch 'master' into johluo/migrate-more-extensions-logging 2020-04-01 23:35:01 -07:00
Doug Bunting 0518cb5107
Suppress a warning (#20390)
- Suppress a warning

- Clarify a comment
2020-04-01 22:14:41 -07:00
William Godbe 2d6827a678
Always generate checksums as last part of publish job (#20367)
* Always generate checksums as last part of publish job

* Initialize props correctly

* Fix wildcard

* Import Arcade SDK

* Add NoWarn MSB4011

* Make import conditional on GenerateChecksums

* Select specific files to checksum

* Respond to feedback

* AfterTargets -> BeforeTargets
2020-04-01 16:25:37 -07:00
James Newton-King 0e4bcf602c
Add HPack dynamic compression (#20058) 2020-04-02 12:22:20 +13:00
Justin Kotalik b8743fc454 merging 2020-04-01 16:05:38 -07:00
Justin Kotalik 8460de4033 Merging 2020-04-01 16:04:02 -07:00
James Newton-King f1145fb6d7
Fix flaky ClientStreaming_ResponseCompletesWithoutResponseBody… (#20338) 2020-04-02 09:02:09 +13:00
Ryan Brandenburg 7d450bba80
OpenAPI Flaky fix (#20383)
Don't use network in tests unless we have to
2020-04-01 12:52:33 -07:00
Justin Kotalik bc140e8722
Unskip IIS Tests (#20417) 2020-04-01 12:26:02 -07:00
John Luo 4294861945 Migration cleanup 2020-04-01 12:02:53 -07:00
John Luo 5c6c7813a8 Merge branch 'master' of ..\Extensions\ 2020-04-01 11:19:24 -07:00
John Luo 71327c03ca
Try synchronizing dispose and output (#20341) 2020-04-01 10:03:30 -07:00
Justin Kotalik 85b1a73f65
Update BlazorServerTemplateTest.cs (#20377) 2020-04-01 09:56:14 -07:00
Brennan ca5cd91d68
Replace RunTests scripts with .NET app (#20337) 2020-04-01 09:01:34 -07:00
Andrew Stanton-Nurse 3f683916bc
unquarantine negotiate tests (#20378)
these were quarantined because of the runtime JIT bug that caused DI failures, they can come out of the box now that the runtime issue is fixed
2020-03-31 23:56:45 +00:00
Justin Kotalik 14032eae01
Quarantine identity test (#20373)
https://dev.azure.com/dnceng/public/_build/results?buildId=580722&view=ms.vss-test-web.build-test-results-tab&runId=18259416&resultId=108224&paneView=debug
2020-03-31 16:40:00 -07:00
Brennan 4cc328aff4
Pass CancellationToken to WaitAsync in client (#20210) 2020-03-31 15:36:24 -07:00
James Newton-King 2f04721ff8
Fix flaky FlowControl_ParallelStreams_FirstInFirstOutOrder (#20342) 2020-04-01 11:08:27 +13:00
Justin Kotalik 1b3e8e1117
Quarantine GracefulTurnsAbortiveIfRequestsDoNotFinish (#20375)
https://dev.azure.com/dnceng/public/_build/results?buildId=581206&view=ms.vss-test-web.build-test-results-tab&runId=18274506&paneView=debug&resultId=119581
2020-03-31 14:46:17 -07:00
Justin Kotalik fa4600f5fa
Skip stream pool test (#20371) 2020-03-31 14:44:20 -07:00
Kevin Pilch f34033a415 Add .vsconfig files in root and beside slns 2020-03-31 14:25:44 -07:00
Brennan 58db57be4c
Plumb a clock interface through SignalR for testing (#19311) 2020-03-31 13:52:10 -07:00
Miroslav Jezik d1d9b97f77 Add tags to HealthReportEntry if an exception occurs 2020-03-31 12:37:40 -07:00
Hao Kung 15d5ffebca
Reeanble dataprotection test (#20319) 2020-03-31 11:36:50 -07:00
William Godbe 24619b8594
Merge pull request #20250 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-03-31 11:33:48 -07:00
Franklin Tse 9249a95286
Improve support to the dictionary returned by ParseQuery (#20133) 2020-03-31 10:27:51 -07:00
huysentruitw 16e2586724
Use Backchannel.DefaultRequestVersion in OAuth & OIDC requests #20096 (#20295) 2020-03-30 20:12:54 +00:00
Roman Marusyk 28de202a3b
Use the custom token endpoint if it's available in OIDC Handler (#20230) 2020-03-30 19:52:33 +00:00
Chris Pickford 3eb778fb41
Added null check to CorsPolicyBuilder (#19831)
* Added null check to CorsPolicyBuilder

* Replaced string.IsNullOrEmpty with null check

* Added inner null check + updated unit test

#19830

* Unit Tests: Reverted Theory to separate Facts

* Strongly typed args

Co-authored-by: Chris Pickford <chris.pickford@aldautomotive.com>
2020-03-30 19:32:30 +00:00
Safia Abdalla a57943a443
Add support for optional parameters in Blazor routes (#19733) 2020-03-30 12:30:28 -07:00
Chris Ross e35eb1211a
Quarantined DATA_Sent_TooSlowlyDueToOutputFlowControlOnLargeWrite_AbortsConnectionAfterRateTimeout (#20317) 2020-03-30 18:03:27 +00:00
John Luo 306ef044cf
Conditionally enable/disable targeting pack tests (#20255) 2020-03-28 18:04:20 -07:00
Brennan a421a31095
Quarantine flaky tests (#20261) 2020-03-28 11:03:12 -07:00