Commit Graph

105 Commits

Author SHA1 Message Date
Pranav K f70df60435 Move RazorGenerate and RazorTagHelper tasks in to the Sdk
Loading multiple versions of a task assembly result results in MSBuild on .NET Core to fail.
Addressing this by moving the tasks in to the Sdk and renaming it. This should avoid
immediate issues for a 2.1 and 2.2 project co-existing and future proofs 2.2 and later.

Fixes https://github.com/aspnet/Razor/issues/2553
2018-09-19 10:09:56 -07:00
Ryan Nowak 1e8e541f65 Clean up timeout reporting
This was sometimes reporting a null when the timeout takes place. We
need to throw with a timeout for real
2018-09-13 15:40:37 -07:00
Ajay Bhargav Baaskaran f93f67a53a
Better logging to help debug test failure (#2576) 2018-09-10 14:17:53 -07:00
Ajay Bhargav Baaskaran d097adee5f
Unblock VSTS linux builds (#2526)
* Unblock VSTS linux builds

* Updated yml
2018-08-08 10:48:16 -07:00
Pranav K 3ff064cea3 Lock when reading \ writing process output
Fixes #2516
2018-07-30 16:21:42 -07:00
Pranav K 676543b8c9 Skip BuildIncremental_SimpleMvc_PersistsTargetInputFile on xplat
For some inexplicable reason timestamps returned as part of the test often show up
as being different resulting in test flakiness. We've manually verified that this
is not a product issue and builds are correctly incremental on xplat. See #2219
for past discussions.

Fixes https://github.com/aspnet/Razor/issues/2503
2018-07-27 14:22:23 -07:00
Ajay Bhargav Baaskaran 8e23eb38b4 Honor NoBuild flag during publish 2018-07-26 11:40:38 -07:00
Ajay Bhargav Baaskaran 7f6b05149d Generate deterministic unique ids for tag helpers 2018-07-17 14:01:42 -07:00
N. Taylor Mullen 9b000397b3 Add NoBuild test that includes content.
- Also fixed wording of existing nobuild test.
2018-06-21 14:36:07 -07:00
N. Taylor Mullen fc17ee0749 Update Razor SDK packing logic to not include Pack at properties layer.
- Added test to verify that no-build scenarios work as expected.

#2378
2018-06-20 15:20:01 -07:00
Ajay Bhargav Baaskaran 17e3aa8ee4 Handle pipe name with whitespace properly 2018-06-19 15:10:49 -07:00
Pranav K 9677553a33 Don't specify MainEntryPoint when compiling Razor assembly 2018-06-19 13:31:49 -07:00
Ajay Bhargav Baaskaran 590d9f65f6 Corrected a typo 2018-06-06 01:59:42 -07:00
Pranav K a1ba1f0f86 Add more diagnostics to FileThumbPrint 2018-06-05 21:18:06 -07:00
Pranav K 754d7ba64e Pass versions using MSBuild template instead of importing dependencies.props 2018-06-05 11:33:46 -07:00
Pranav K 1b6ca7f55a Allow publish to work when BuildProjectReferences=false
Fixes #2363
2018-05-25 11:13:26 -07:00
Ajay Bhargav Baaskaran 78f698db96 Fix test failure on MacOS 2018-05-24 10:59:47 -07:00
Ajay Bhargav Baaskaran 4bad5adc24 Don't run build server when building testapps in-place 2018-05-23 18:04:10 -07:00
Ryan Nowak a412299881 Add a Razor design time build
This allows Razor to know what files belong to the project.
2018-05-14 09:41:15 -07:00
Pranav K 0f2b315fe4 Fixup Razor Sdk tests to work on netcoreapp2.2 2018-05-08 15:22:54 -07:00
Ryan Brandenburg efaaec6546 Upgrade to netcoreapp22 2018-05-08 15:22:54 -07:00
Pranav K 1a2ca58eba
Merge pull request #2324 from aspnet/release/2.1
Merge release/2.1
2018-05-01 19:31:26 -07:00
Pranav K a94323499b Change CopyToPublishDirectory on Content items instead of explicitly removing this from publish items
Fixes #2295
2018-05-01 16:50:49 -07:00
Pranav K 05c84f008a Ensure Views dll are copied during P2P builds
FastUpToDateCheck in VS doesn't account for changes solely to .Views.dll. This causes referencing projects to be treated as
up to date even though a referenced project rebuilt. Touch the marker file to cause referenced projects to rebuild.

Fixes https://github.com/aspnet/Razor/issues/2306

to cause it to treat
2018-05-01 16:50:49 -07:00
Pranav K 8d99ba53ce Make incremental build in VS copy output files
Fixes #2306
2018-05-01 16:50:49 -07:00
Pranav K 2081663635 Re-enable desktop msbuild tests
Fixes #2208
2018-05-01 15:00:03 -07:00
Pranav K 813e50087c Specify RuntimeFrameworkVersion \ NSLibraryVersion when running tests 2018-04-26 17:42:01 -07:00
Ajay Bhargav Baaskaran bd871ef9e9 Handle Travis failure on ubuntu 2018-04-25 13:24:53 -07:00
Pranav K 1e2a1405e5
Update tests to target netcoreapp2.1 2018-04-25 10:27:07 -07:00
Pranav K a9f818bf82 Disable node-reuse to allow rebuilding
Recent builds of msbuild have node reuse enabled by default. This locks up the
task dlls after the test's completed preventing rebuilds untill you kill the process.
2018-04-23 12:50:38 -07:00
Ajay Bhargav Baaskaran 3adb7c9661 Handle Travis failure on ubuntu 2018-04-18 15:46:06 -07:00
Ajay Bhargav Baaskaran d2fe76be21 Write process and pipe information to a pid file 2018-04-18 14:51:28 -07:00
Pranav K 95835d6c37 Continue generating RelatedAssemblyPart on assembly if GenerateAssemblyInfo=false
Fixes #2257
2018-04-13 16:14:37 -07:00
Pranav K 8d1de6ec80 Make sure RazorSdk works when BuildingInVisualStudio \ BuildProjectReferences is disabled
Fixes #2247
2018-04-13 14:35:04 -07:00
Pranav K 6130eb0ec5 Is 1888 fixed 2018-04-13 11:19:07 -07:00
Pranav K 9365fcd053 Don't publish the refs directory when the app does not have any Razor files
Fixes https://github.com/aspnet/Razor/issues/2246
2018-04-11 15:20:16 -07:00
Ajay Bhargav Baaskaran 6d9df1ef33 Noop Razor Sdk for F# projects 2018-04-11 14:18:19 -07:00
Ajay Bhargav Baaskaran b1007744b0 Added PipeOptions.CurrentUserOnly option to the named pipe streams
Don't run on server if CurrentUserOnly is not available
2018-04-04 09:53:36 -07:00
Ajay Bhargav Baaskaran a2a920dde5 Normalize the tool assembly path before using it as the base for pipe name 2018-03-29 12:50:51 -07:00
Ajay Bhargav Baaskaran 03938dfd95 Handle Mutex creation exceptions 2018-03-28 18:23:30 -07:00
Ajay Bhargav Baaskaran d1215d8fa1 Skip checking thumbprint of file in osx 2018-03-27 10:46:49 -07:00
Pranav K 1e11b5fa95 Make PreserveCompilationContext=true 2018-03-26 14:23:29 -07:00
Pranav K 954a62c075 Remove EnableDefaultCompiledViewAssemblyLoadBehavior and add a switch to disable generating application part factory attribute 2018-03-22 17:09:53 -07:00
Pranav K ac3065a9e1
Temporary workaround to make Razor Windows build on dotnet-ci 2018-03-22 12:17:06 -07:00
Pranav K 8631f287d9 Add a few more Razor Sdk fixes
* UseSharedCompilation to determine the default value of UseRazorBuildServer
* Generate AssemblyDescriptionAttribute
2018-03-21 08:44:55 -07:00
Pranav K 2bc3466e3d Do not write generated files to disk if the input has parser errors
Fixes #2169
2018-03-19 21:30:47 -07:00
Ryan Nowak 6e4a968e12 Fix #2149 give generated files distinct extension
Gives our generated a files an extension that isn't used for any other
purpose (that we know of). This is handy for tooling to be able to
quickly know if a file is 'ours'. This comes up in places like
IVsSymbolicNavigationNotify (go to definition).
2018-03-19 12:59:16 -07:00
Ajay Bhargav Baaskaran 767e5a12c3 Display errors from build server as part of MsBuild output 2018-03-19 10:49:00 -07:00
Pranav K b74582e101 Ensure PreserveCompilationContext is set if we're targeting precompilation tool
PreserveCompilationContext must be set for precompilation tool to work, even when
the app has no views.

Fixes #2168
2018-03-15 12:49:56 -07:00
Pranav K 5f69a01cc5
RazorSdk - Attribute code generation fixes
* Allow the type name for ProvideApplicationPartFactoryAttribute to be specified.

* Generate ReleatedAssemblyAttribute in class library projects
2018-03-14 23:09:28 -07:00