Commit Graph

15757 Commits

Author SHA1 Message Date
NTaylorMullen 237a7a65d6 Seal RestrictChildrenAttribute.
Addresses #5041
2019-01-16 15:03:30 -08:00
Ajay Bhargav Baaskaran 4c1a375a2c Merge branch 'release/2.1' into release/2.2 2019-01-16 14:52:13 -08:00
Justin Kotalik dabd3463ba few extra conflicts 2019-01-16 14:46:39 -08:00
Ajay Bhargav Baaskaran ad31f9429d
Fix failing Razor file comparison tests (#6757) 2019-01-16 14:41:50 -08:00
Ajay Bhargav Baaskaran 18425ed192
Merge branch release/2.1 to release/2.2 (#6754)
* Put Razor.Design.Test and Razor.Language.Test in a different test group (#6725)

* Move dotnet watch to a seperate test group (#6730)

* Reuse root `version.props` in Templating
- do not let Templating get behind branding changes

* Revert "Put Razor.Design.Test and Razor.Language.Test in a different test group (#6725)" (#6753)

This reverts commit 563ff7c639.

* Revert file watch test changes
2019-01-16 14:40:45 -08:00
Justin Kotalik e6d547a923 Merge branch 'jkotalik/22temp' into jkotalik/masterMerge 2019-01-16 14:39:10 -08:00
Pavel Krymets ae9b3992b2
Merge pull request #6759 from aspnet/pakrym/merge22
Merge 2.2 into master
2019-01-16 14:04:56 -08:00
Nate McMaster 5a70f5312f
Convert Components projects to use ProjectRef (#6698)
This addresses #4246 for src/Components/. A few other changes were necessary because components had been using stale dependencies.
2019-01-16 12:28:04 -08:00
Justin Kotalik 5b56de94fd
Allow disabling shared configuration check from hosting bundle. (#6498) 2019-01-16 12:04:36 -08:00
Pavel Krymets f08f2af8bc Merge commit '852d890' into pakrym/merge22 2019-01-16 11:56:50 -08:00
Pavel Krymets 6cac028716
Switch IIS tests to Hosted queue (#6746) 2019-01-16 11:47:52 -08:00
John Luo 1bd5845b4c
Merge pull request #6735 from aspnet/johluo/merge22
Johluo/merge22
2019-01-16 11:43:35 -08:00
Ajay Bhargav Baaskaran 9831238b7c
Revert "Put Razor.Design.Test and Razor.Language.Test in a different test group (#6725)" (#6753)
This reverts commit 563ff7c639.
2019-01-16 11:06:44 -08:00
Justin Kotalik 8119c57669
Always copy nuget package output to build directory (#6631) 2019-01-16 10:45:45 -08:00
John Luo e1c4d150f5 Merge fix 2019-01-16 10:31:10 -08:00
Steve Sanderson 9020ab6386
No need to register .wasm media type since ASP.NET Core 2.2 (#6731) 2019-01-16 09:50:42 -08:00
Doug Bunting 99eba6972f Reuse root `version.props` in Templating
- do not let Templating get behind branding changes
2019-01-16 09:24:28 -08:00
Pavel Krymets f44c175ec6
Enable logging branch SiteExtension (#6715) 2019-01-16 08:56:12 -08:00
Justin Kotalik dce7a3a1b6
Merge pull request #6723 from dotnet-maestro-bot/merge/release/2.1-to-release/2.2 2019-01-16 08:55:34 -08:00
Justin Kotalik 959445b271 Target netcoreapp2.2 2019-01-15 22:29:08 -08:00
Chris Ross d838165642
Fix up how OIDC errors flow (#4520)
* Add regression test for #4384
* Fix up how OIDC errors flow #4384
2019-01-15 20:59:40 -08:00
John Luo 17b6ce8bd6 Merge branch 'release/2.2' 2019-01-15 18:49:54 -08:00
Pranav K 86071c9db4
Add Components packages to shared fx (#6722)
* Add Components packages to shared fx

* Add Microsoft.AspNetCore.Components \ Microsoft.AspNetCore.Components.Browser to shared fx
* Update build to use Microsoft.InteropJS package produced from Extensions repo
* Remove some package references from components template

Fixes https://github.com/aspnet/AspNetCore/issues/6442
2019-01-15 18:05:42 -08:00
Pavel Krymets 12a479d1f6
Move dotnet watch to a seperate test group (#6730) 2019-01-15 17:18:28 -08:00
James Newton-King df7bfe5243
Unit test route name with RouteUrl and ambient values (#6719) 2019-01-16 13:57:13 +13:00
Ryan Nowak 3e5b37f22c Fix #6102 - Intense CPU utilization on page change (#6542)
* Fix #6102 - Intense CPU utilization on page change

The issue here was that every time a Razor Page changed, we would
subscribe an additional time to the endpoint change notifications. This
means that if you tweaked a page 30 times, we would update the address
table 31 times when you save the file. If you were doing a lot of editing
then this would grow to a really large amount of computation.

The fix is to use DataSourceDependentCache, which is an existing utility
type we developed for this purpose. I'm not sure why it wasn't being
used for this already. We're already using DataSourceDependentCache in a
bunch of other places, and it's well tested.

I also tweaked the stucture of this code to be more similar to
EndpointNameAddressScheme. This involved some test changes that all
seemed like good cleanup. The way this was being tested was a little
wonky.

(cherry picked from commit a5658a8c95)
2019-01-15 16:55:27 -08:00
BrennanConroy 17616a5dba
Use bounded channel for streaming (#6625) 2019-01-15 16:51:31 -08:00
Justin Kotalik 4a2a8942d4 Cleanup 2019-01-15 16:44:10 -08:00
Justin Kotalik eacffd56b7 Merge branch 'release/2.1' into release/2.2 2019-01-15 16:37:34 -08:00
Ajay Bhargav Baaskaran 563ff7c639
Put Razor.Design.Test and Razor.Language.Test in a different test group (#6725) 2019-01-15 15:49:13 -08:00
Pranav K d74833c2d7
Update Razor Sdk version (#6713)
* Update Razor Sdk version

* Use Razor SDK version with workaround for https://github.com/aspnet/AspNetCore/issues/6500
* Remove package reference to Razor SDK in template
2019-01-15 15:46:21 -08:00
BrennanConroy 3dcb382741
Fix Java package version (#6724) 2019-01-15 15:44:03 -08:00
Pavel Krymets 41c1490468
Add an event log message when loading hostfxr fails (#6670) 2019-01-15 15:07:51 -08:00
James Newton-King cd308e7a8b
Fix HttpContext not being passed to constraints in link generation (#6644) 2019-01-16 12:00:57 +13:00
James Newton-King 92680b355f
Change consumes behavior to ignore requests with no content type (#6645) 2019-01-16 11:55:54 +13:00
Stephen Halter 0622513058
Wait to dispose RequestAborted CTS (#4447) 2019-01-15 14:54:10 -08:00
Pranav K b56c589773
Dispose components on client disconnects (#6693)
* Dispose components on client disconnects
Fixes https://github.com/aspnet/AspNetCore/issues/4047
2019-01-15 14:52:40 -08:00
James Newton-King 180f735ac8
Fix non-parameter route constraints not called with endpoint routing for 2.2 (#6587) 2019-01-16 11:16:35 +13:00
Pavel Krymets 4c956d4767
Add SkipIfNotAdminAttribute to StartsWithDotnetInstallLocation (#6718) 2019-01-15 13:25:07 -08:00
Justin Kotalik e751db0739
Make Auth Samples Project Ref (#6557) 2019-01-15 13:12:54 -08:00
Chris Ross 1f892d798d
Add AllowSynchronousIO to TestServer and IIS, fix tests (#6404) 2019-01-15 11:48:17 -08:00
Mikael Mengistu 852d890cd6
Check HubConnection state before running invoke logic (#4400) 2019-01-15 11:15:21 -08:00
Stephen Halter 0defbf74f8
Fix flakiness in Kestrel ungraceful shutdown test (#6637) 2019-01-15 11:10:44 -08:00
Pavel Krymets 437baf6f5e
Port Handle EOF HResult from async callback to 2.2 (#6483) 2019-01-15 10:33:26 -08:00
Steve Sanderson 0fff8bbd04 Fix signing error related to Microsoft.JSInterop.dll (#6705) 2019-01-15 10:00:28 -08:00
Pavel Krymets 5fd9435392
Port ANCM current directory changes to 2.2 (#6150) 2019-01-15 09:00:50 -08:00
Justin Kotalik cdd38d70cf
Implement Stream Adapters (and minor nitpics) (#6583) 2019-01-15 09:00:06 -08:00
Chris Ross 6a44aca6a2
React to WebHostBuilderFactory changes (#6460) 2019-01-15 08:09:27 -08:00
James Newton-King 09b50850bc
Update AuthorizeFilter to no-op when AuthorizationMiddleware has run (#6346) 2019-01-15 20:29:23 +13:00
David Fowler 0e1cb6d6c2
Removed WebSocketProtocol from the shared framework (#6699) 2019-01-14 21:38:31 -08:00
Mikael Mengistu 86a0becd59
Mark Java client as Product Package (#6697) 2019-01-14 21:24:52 -08:00
John Luo 38c0d5a50c
Use object indirection in HttpContextAccessor (#1066) (#6036) 2019-01-14 20:31:36 -08:00
Doug Bunting 63ee551b6b
Merge `release/2.2` to `master` 2019-01-14 20:23:51 -08:00
John Luo 8f1eedf5a9 Merge branch 'release/2.1' into release/2.2 2019-01-14 19:04:39 -08:00
BrennanConroy a9b737b793
Fix broken definitions file (#6343) 2019-01-14 18:46:07 -08:00
Pranav K d93f4527b3 Fix typo
Fixes https://github.com/aspnet/AspNetCore/issues/6535
2019-01-14 17:15:19 -08:00
Steve Sanderson 864f76b2c0
Update Razor Components and Blazor templates (#6682) 2019-01-14 15:23:49 -08:00
Travis Illig f072523780 Minor argument check fixes
Fixed `nameof()` reference to be consistent with arg being checked. Added null check for port to be consistent with earlier overload.
2019-01-14 15:00:20 -08:00
Kahbazi 5b8d93c9c6 Check iss in odic sign-out (#6378) 2019-01-14 14:45:45 -08:00
David Fowler 3f1760c52b
Reduce copies for WebSocket reads (#6656)
- Change the upgrade message body to use the transport pipe instead of the request body pipe.
- Remove some logic from the base type (more can be removed but this is a conservative change)
- Improve performance of the ReadAsync call
2019-01-14 14:14:02 -08:00
John Luo c2aa2957f6 Merge fixes 2019-01-14 14:13:40 -08:00
John Luo 90a9fa7aac Merge branch 'release/2.1' into release/2.2 2019-01-14 12:57:34 -08:00
Stephen Halter cd0eab88ea
Lower log severity for opening internal libuv pipe (#6636)
Addresses #4741
2019-01-14 12:29:49 -08:00
Chris Ross 87af0c3f1f
Update Google Auth UserInfo endpoint (#6338)
* Update Google Auth UserInfo endpoint #6069

* Add Google to PatchConfig
2019-01-14 12:28:25 -08:00
Nate McMaster 7f7723bdf2
Consume dependencies updates automatically via darc (#6676)
This refactors the list of dependency versions to support consuming updates automatically via darc and maestro.
2019-01-14 12:01:31 -08:00
Doug Bunting 970bced25c
Update branding to 2.2.2 (#6608)
- pin System.Net.WebSockets.WebSocketProtocol to version 4.5.3
- update Directory.Build.targets files to correct build issues
- fix duplicate metadata during static analysis
2019-01-14 11:40:01 -08:00
Ivan Zlatanov c560edee28 Fixed the bug in the windows service host where if application stop is requested, the service wouldn't know about it. (#4553)
* Fixed the bug in the windows service host where if application stop is requested, the service wouldn't know about it.

* Fixed a typo.

* Update src/Hosting/WindowsServices/test/Microsoft.AspNetCore.Hosting.WindowsServices.Tests.csproj

* Removed unneeded EditorBrowsable for internal API.

* Fixed tests to ignore Linux and MacOS.

* Added new line to end of file.

* Using [ConditionalFact] instead of [Fact].
2019-01-14 10:26:15 -08:00
Nate McMaster 089912cd1b
Switch queues used during Windows builds (#6667) 2019-01-14 10:07:12 -08:00
Pavel Krymets 8aa8c6b2b0
Build branch logging SE in main build (#6312) 2019-01-14 08:42:53 -08:00
Justin Kotalik 3f4622ffe0
Fix StartupTests.StartsWithDotnetInstallLocation (#6589) 2019-01-14 08:16:48 -08:00
Steve Sanderson cbbdeaefd4
Enforce correct sync context on render, and allow explicit dispatch to sync context. Fixes #5639 (#6604)
* Only use async marshalling to renderer sync context when necessary

Note that the lifecycle methods already take care of capturing the correct sync context, so continuations will already be serialized.
Avoiding an extra layer of asynchrony keeps the semantics of rendering closer to the WebAssembly cases, and will fix a range of intermittent errors in the wild.

* Add E2E test of triggering rendering from outside the sync context

* Actually throw if attempting to render from incorrect sync context

* Add "Dispatch" API

* Handle dispatch within dispatch. Also test Dispatch on WebAssembly.

* Avoid heap allocation

* Simplify E2E test

* Replace Dispatch() with Invoke() and InvokeAsync()

* Add E2E test to validate async execution order

* Clean up
2019-01-14 15:31:53 +00:00
Chris Baudin 0b8e16f10a Detatch CancelKeyPress and ProcessExit event handlers when IWebHost.RunAsync is completed. (#6638) 2019-01-13 22:44:25 -08:00
Ryan Nowak a5658a8c95
Fix #6102 - Intense CPU utilization on page change (#6542)
* Fix #6102 - Intense CPU utilization on page change

The issue here was that every time a Razor Page changed, we would
subscribe an additional time to the endpoint change notifications. This
means that if you tweaked a page 30 times, we would update the address
table 31 times when you save the file. If you were doing a lot of editing
then this would grow to a really large amount of computation.

The fix is to use DataSourceDependentCache, which is an existing utility
type we developed for this purpose. I'm not sure why it wasn't being
used for this already. We're already using DataSourceDependentCache in a
bunch of other places, and it's well tested.

I also tweaked the stucture of this code to be more similar to
EndpointNameAddressScheme. This involved some test changes that all
seemed like good cleanup. The way this was being tested was a little
wonky.
2019-01-13 21:03:26 -08:00
David Fowler 71ce37ee91 Remove WebSocketProtocol dependencies (#6651) 2019-01-13 18:22:11 -08:00
BrennanConroy 6d28c44408
Fix SignalR perf app path (#6650) 2019-01-13 17:11:25 -08:00
David Fowler c528892560
Use the WebSocket factory method instead of WebSocketProtocol (#6646)
- WebSocketProtocol.CreateFromStream makes the netstandard ManagedWebSocket which uses the inefficient versions of Stream overloads.
- Updated the samples to use the new Memory<byte> overloads
2019-01-13 11:05:04 -08:00
Ben Adams b27739ad3f Shrink ParseRequestLine inner loop (#6594) 2019-01-11 20:34:30 -08:00
James Newton-King c7f05c614a
Remove Microsoft.AspNetCore.Testing dependency from SignalR spec tests (#6629) 2019-01-12 16:01:07 +13:00
James Newton-King accbcebac0
Support multiple policies for a key with RoutePatternFactory.Pattern (#6593) 2019-01-12 16:00:42 +13:00
Nate McMaster b4f869b2ff
Switch agent queues used on Windows builds (#6627) 2019-01-11 16:23:13 -08:00
Chris Ross 7d5067519f
Move templates to generic web host #4187 (#5706) 2019-01-11 16:21:23 -08:00
BrennanConroy ee6ba671fa
Fixup SignalR sln (#6622) 2019-01-11 16:05:31 -08:00
Nate McMaster a9132ad26c
Switch agent queues used during Windows builds 2019-01-11 15:16:57 -08:00
Nate McMaster 676cbee9d0
Merge branch 'release/2.2' 2019-01-11 14:52:01 -08:00
Kahbazi 7883eb65a2 Replace Cosnsole.WriteLine with Debug.WriteLine (#6618) 2019-01-11 14:24:10 -08:00
Justin Kotalik 2f6ff70dd4
Disable a set of flaky IIS tests (#6606) 2019-01-11 13:32:27 -08:00
Nate McMaster 5810af5ce7
Fix code-signing metadata for the SignalR java client (#6607) 2019-01-11 11:27:04 -08:00
Steve Sanderson 70cdf11f76
Make Razor Components apps not use Blazor build (#6562)
* Replace UseServerSideBlazor with UseRazorComponents, which doesn't require Blazor build artifacts

* Make UseRazorComponents serve blazor.server.js from embedded resource

... so we don't need a build step to put it on disk somewhere.

* Fix TestServer

* Update ComponentsApp not to use Blazor build targets

* Update ComponentsApp.App sample to use new build package

* Update string constant in test

* Rename blazor.*.js to components.*.js

* Ensure correct build order

* Update nav menu title in Components sample app

* Fix remaining paths

* Switch ComponentsApp.App to use Sdk="Microsoft.NET.Sdk.Razor"

* Update mono.cecil version

* CR: Replace FrameworkFilesProvider with EmbeddedFileProvider

* CR: Use ManifestEmbeddedFileProvider
2019-01-11 16:14:11 +00:00
Nate McMaster 3cd5054eb5
Merge branch 'release/2.2' 2019-01-11 07:20:00 -08:00
Rick Anderson 820304cfca Update src/Security/README.md (#6592) 2019-01-11 07:07:54 -08:00
Steve Sanderson 827ace6100
Factor WebAssembly debugging infrastructure out of Microsoft.AspNetCore.Components.Server (#6519)
* Add empty Blazor.Server project

* Move debugging middleware to Blazor.Server

* Use debugging middleware in Blazor standalone CLI

* Use debugging middleware in Blazor "hosted" sample

* Update artifacts.props
2019-01-11 10:29:43 +00:00
Javier Calvarro Nelson 5ff7e20c59
[Identity] Fix broken test (#6563) 2019-01-11 02:08:13 -08:00
BrennanConroy 364018238a
Refactor streaming from client to server (#4559) 2019-01-10 21:52:28 -08:00
Ben Adams 31c8423df1 Devirtualize HttpHeaders.Reset (#5950)
* Use Inlining to devirtualize
2019-01-10 20:34:41 -08:00
Ajay Bhargav Baaskaran 3b67abecbf
Add an MSBuild target to set MsBuild.exe path (#6401)
* Add an MSBuild target to set MsBuild.exe path

* Added a warning message

* Don't build Razor.Tasks twice

* Compile include inside the target
2019-01-10 17:34:25 -08:00
Mikael Mengistu 1677ed2073
Package Archive Baseline for the 2.1.8 Patch (#6578) 2019-01-10 15:54:13 -08:00
Ryan Nowak 14e606997f Fix #5116 Remove support for 2.0 precompilation
Obsoletes RazorViewAttribute and RazorPageAttribute and removes all of
our usage of them. I've already made the changes to have the SDK stop
generating these.
2019-01-10 15:38:10 -08:00
Pavel Krymets 5299eff616
Use hostfxr error callback support (#6043) 2019-01-10 14:07:47 -08:00
James Newton-King 90511e6039
Add HostPolicyMatcher (#6214) 2019-01-11 10:46:09 +13:00
Pranav K 55ec35bb80
Cleanup MvcJsonHelper (#6529)
* Cleanup MvcJsonHelper

* Remove dependency on JsonOutputFormatter
* Cache JsonSerializer for the default case
2019-01-10 12:34:27 -08:00