BrennanConroy
8c7f33a6d7
Port C# client perf fix to release ( #2189 )
2018-05-02 21:53:39 -07:00
Ajay Bhargav Baaskaran
41c0a69c5b
Allow build server to run on net46
2018-05-02 16:17:09 -07:00
Andrew Stanton-Nurse
622e133a8a
fix #2134 by disposing httpconnection if start fails ( #2137 ) ( #2188 )
2018-05-02 13:10:58 -07:00
Nate McMaster
d6f15759fd
Add property to allow the SDK to disable shared framework trimming ( #1130 )
...
The MicrosoftNETPlatformLibrary property instructs the .NET Core SDK to treat a particular package as the shared framework platform. This affects how the SDK will trim references and publish output, determines how the runtimeconfig files are generated, and may affect how optimizations are preformed by other tools. In some installations of .NET Core, the ASP.NET Core shared framework is not available. This change adds properties to let the SDK determine on which platforms ASP.NET Core is enabled.
2018-05-02 08:49:03 -07:00
James Newton-King
41c8dcf449
Fix not setting HttpConnection.ConnectionId ( #2154 )
2018-05-01 21:48:57 -07:00
James Newton-King
3e906fb64a
Minor API cleanup ( #2147 )
2018-05-01 17:51:08 -07:00
James Newton-King
555c1fd720
Fix not detecting marker service ( #2149 )
2018-05-01 17:42:00 -07:00
Nate McMaster
e0e9eb0b36
Add pre-generated shims to dotnet tool packages
2018-05-01 16:57:36 -07:00
Pranav K
a94323499b
Change CopyToPublishDirectory on Content items instead of explicitly removing this from publish items
...
Fixes #2295
2018-05-01 16:50:49 -07:00
Pranav K
05c84f008a
Ensure Views dll are copied during P2P builds
...
FastUpToDateCheck in VS doesn't account for changes solely to .Views.dll. This causes referencing projects to be treated as
up to date even though a referenced project rebuilt. Touch the marker file to cause referenced projects to rebuild.
Fixes https://github.com/aspnet/Razor/issues/2306
to cause it to treat
2018-05-01 16:50:49 -07:00
Pranav K
8d99ba53ce
Make incremental build in VS copy output files
...
Fixes #2306
2018-05-01 16:50:49 -07:00
Andrew Stanton-Nurse
d711916ad6
fix #2140 by ensuring the access token flows to WebSocketTransport ( #2173 )
2018-05-01 16:14:24 -07:00
James Newton-King
295801ac50
XML documentation ( #2106 )
2018-05-01 16:08:09 -07:00
Chris Ross (ASP.NET)
2c1376c95f
Add a AddHostedService extension #1402
2018-05-01 14:07:24 -07:00
Kiran Challa
601f41026a
Updated icon for RazorClassLibrary
2018-05-01 13:34:51 -07:00
Kiran Challa
19c41c0494
Revert "[ Fixes #6902 ] Added an overload for StatusCode that takes in System.Net.HttpStatusCode"
...
This reverts commit c567a690bc .
[Fixes #7709 ] Revert https://github.com/aspnet/Mvc/pull/6902
2018-05-01 13:27:57 -07:00
Chris Ross (ASP.NET)
1717b97444
Run self-host tests with no-build. #1399
2018-05-01 12:22:36 -07:00
Stephen Halter
b0e1fa5e30
Fix connection abort
2018-04-23 17:01:49 -07:00
Nate McMaster
0d047d64f3
Remove explicit reference to NETStandard.Library when using .NET Framework
2018-04-23 13:32:50 -07:00
Nate McMaster
0f131ac245
Disambiguate /p from -p on dotnet-run
2018-04-21 08:13:29 -07:00
Nate McMaster
ed7e6db79e
Attempt to fix more failing tests in prodcon builds
2018-04-21 08:01:30 -07:00
Andrew Stanton-Nurse
47eafca4d8
CancellationToken EVERYWHERE ( #2101 )
2018-04-20 16:21:51 -07:00
Ajay Bhargav Baaskaran
2a10e6fe1d
Added nuspec file for Mvc.Razor.ViewCompilation to include symbols
2018-04-20 15:26:34 -07:00
Ajay Bhargav Baaskaran
aa181128ac
Generate symbol nupkgs for tools
2018-04-20 15:10:03 -07:00
Ajay Bhargav Baaskaran
595e83d0eb
Added nuspec file to Mvc.Analyzers assembly
2018-04-20 14:53:46 -07:00
Pranav K
5d5222cdd8
Introduce BindPropertiesAttribute
...
* Allow controller and Razor Page models to be annotated with BindPropertiesAttribute
* Disallow BindPropertyAttribute from being declared on types.
* Do not allow arbitrary binding attributes to be applied to Razor Page models.
Fixes #7686
2018-04-20 14:32:14 -07:00
Andrew Stanton-Nurse
058830c9df
fix #2116 by requiring task return values from typed client ( #2117 )
2018-04-20 13:49:12 -07:00
BrennanConroy
9101ab636b
Always check for WebSockets close ( #2100 )
2018-04-20 08:21:04 -07:00
James Newton-King
5516a969e3
Change Hub and friends to abstract ( #2108 )
2018-04-20 20:53:01 +12:00
Andrew Stanton-Nurse
ace9a0d414
fix #2097 by adding GetHttpContext to HubConnectionContext ( #2099 )
2018-04-19 19:14:39 -07:00
BrennanConroy
1957655653
Run hub invocations serially ( #2086 )
2018-04-19 16:59:06 -07:00
John Luo
a8c3615df4
React to implicit Microsoft.AspNetCore.App reference
2018-04-19 16:49:13 -07:00
Andrew Stanton-Nurse
6b6d890c8f
fix #2078 by adding locking ( #2079 )
2018-04-19 15:32:04 -07:00
Nate McMaster
53c25198fd
Revert "Produce the Microsoft.AspNetCore.AzureAppServices.SiteExtension package on normal builds ( #188 )"
...
This reverts commit 0921e5b60f .
2018-04-19 15:08:17 -07:00
Ajay Bhargav Baaskaran
44e282e8d4
Generate symbols.nupkg for Mvc.Razor
2018-04-19 12:32:36 -07:00
Nate McMaster
30928ba944
Disable implicit package version verification when --no-restore is used
...
Workaround an error when building in ProdCon where the RuntimeFrameworkVersion is overridden externally. Generally, the error is good, but when --no-restore is specified, we are okay ignoring this verification.
2018-04-19 12:24:10 -07:00
Nate McMaster
0921e5b60f
Produce the Microsoft.AspNetCore.AzureAppServices.SiteExtension package on normal builds ( #188 )
2018-04-19 11:00:10 -07:00
David Fowler
676bf179f3
Reduce redundant dependencies ( #2091 )
2018-04-19 00:18:52 -07:00
BrennanConroy
e9937ffb66
Split lock into WriteLock and StateLock to prevent deadlocks and unneeded lock contention ( #2081 )
2018-04-18 17:44:05 -07:00
Ajay Bhargav Baaskaran
d2fe76be21
Write process and pipe information to a pid file
2018-04-18 14:51:28 -07:00
David Fowler
903fe1e902
Added support for negotiate response to redirect the client to another SignalR endpoint ( #2070 )
...
- Add a SkipNegotiation flag to the .NET and ts client
to allow skipping the negotiation phase. Don't infer it based on the transport type.
- Updated the negotiate protocol to support returning a redirect url
- Added support to .NET client to handle redirect negotiations
- Handle poorly written endpoints that sends infinite redirects
- Added access token support and an infinite redirect guard
- Add delete handler for stopping the transport
2018-04-18 14:22:45 -07:00
Pranav K
60a9810268
Allow PartialTagHelper to specify a null model. Fixes #7667
2018-04-18 14:16:44 -07:00
Kiran Challa
faca3da42f
Ensure ViewData is set on PageResult after a handler method executes
...
[Fixes #7665 ] Initializing PageResult.Page as part of result execution breaks Identity UI
2018-04-18 11:44:04 -07:00
Kiran Challa
4f7d53f4e7
[ Fixes #7658 ] FileStreamResultExecutor fails to Dispose FileStream
2018-04-18 11:43:09 -07:00
Kiran Challa
6e4bd1eb46
Fixed PageFilter docs
2018-04-18 11:42:40 -07:00
Javier Calvarro Nelson
1cede88f26
[ Fixes #7656 ] Deps file for netstandard2.0 targeting projects copied by Microsoft.AspNetCore.Mvc.Testing does not play well with Mvc
2018-04-18 11:03:52 -07:00
David Fowler
5c9b64244a
Expose the IHubProtocol on HubConnectionContext ( #2073 )
2018-04-18 10:35:55 -07:00
Jass Bagga
13e746c289
Update THIRD-PARTY-NOTICES link and remove Package Management panel from carousel ( #474 )
...
Addresses #330 and #469
2018-04-18 09:42:27 -07:00
Andrew Stanton-Nurse
b4046b5ed8
Fix #1989 by adding a 'binding failure' pseudo-message ( #2064 )
2018-04-17 20:08:07 -07:00
Javier Calvarro Nelson
e781cd38cf
[ Fixes #7635 ] Provide a way to configure HTTP Client instances
2018-04-17 12:52:56 -07:00
Javier Calvarro Nelson
e0b4c13895
[ Fixes #7587 ] Default to Development environment in tests
2018-04-17 12:52:51 -07:00
Doug Bunting
e0e96ce53b
Include parameter type's attributes in ModelMetadata
...
- #7595
- #7595 relates to #7350 but does not have the same root cause
- did _not_ revert the src changes in #7350 fix (d995b0418a )
- make non-`[Obsolete]` `ModelAttributes` constructor overload `internal`
- should generally use `static` methods and not any constructor
- change some unit tests to use `[Obsolete]` constructor overloads (with suppressions)
- fix test `ParameterBinderExtensions` to use current `ParameterBinder.BindModelAsync(...)` overload
- found some tests updated `IModelMetadataProvider`, `MvcOptions`, etc. instances but didn't register them in DI
- extend `ModelBindingTestHelper` and `ModelBindingTestContext`
- reorder some tests to use correct `MvcOptions` and `IModelMetadataProvider` everywhere
- fixes above issues
nits:
- take a few VS suggestions
- remove an old comment indended only for PR "Reviewers:"
2018-04-17 12:40:38 -07:00
Javier Calvarro Nelson
e06b1fd690
[ Fixes #1242 ] Moves IStartupConfigureServicesFilter and IStartupConfigureContainerFilter interfaces to the internal namespace
2018-04-17 12:31:09 -07:00
Ajay Bhargav Baaskaran
dc997821cc
Added nuspec and symbols.nuspec files to Razor.Design
2018-04-17 11:07:34 -07:00
James Newton-King
8985fee4b5
Merge
2018-04-17 20:39:19 +12:00
David Fowler
05d6bbb782
Flush first long poll immediately ( #2032 )
...
There was a race condition between the first poll and any other http request that was sent.
In particular, if you called StartAsync then StopAsync it was possible for the delete to happen before the poll started leading to 400 errors. This change fixes that by making the very first poll
return immediately so that the client can use that to determine if there was an error connecting.
2018-04-17 00:49:26 -07:00
James Newton-King
d35bcea0a5
Move HubException and add serialization ctor ( #2049 )
2018-04-17 14:10:42 +12:00
Ryan Brandenburg
52c45f2204
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 15:15:38 -07:00
Ryan Brandenburg
c8d842c160
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 15:05:29 -07:00
Ryan Brandenburg
3c40b9efd2
Merge remote-tracking branch 'origin/release/2.1' into rybrande/MergeRelease21IntoDev
2018-04-16 14:24:13 -07:00
Stephen Halter
6fd09af374
Improve logging of request drain timeout ( #2480 )
2018-04-16 11:53:10 -07:00
Andrew Stanton-Nurse
c05c5a6b2a
React to aspnet/KestrelHttpServer#2496: make IConnectionInherentKeepAliveFeature a boolean feature ( #2041 )
2018-04-16 11:34:12 -07:00
Andrew Stanton-Nurse
3a45136cc4
make IConnectionInherentKeepAliveFeature a boolean feature ( #2496 )
2018-04-16 11:34:06 -07:00
David Fowler
a426334018
Expose IList instead of List
2018-04-16 10:44:22 -07:00
David Fowler
a5d9930802
API review changes ( #2043 )
...
- Make SerializedHubMessage and SerializedMessage
public
- Made HubConnectionStore public
- Move SendUtils and Utils to the internal folder
- Make Microsoft.AspNetCore.Http.Connections.Common/Internal public.
- Move InvocationRequest to internal folder
2018-04-16 10:31:10 -07:00
Steve Sanderson
4d151a599e
Dynamically expand timeout when waiting for Angular CLI to be ready. Fixes #1611
2018-04-16 14:54:52 +01:00
Tadas Mazutis
78f7dccfab
Performance fix
...
- Usage of resolved loopback IP address instead of 'localhost'
Addresses #1588
2018-04-16 14:45:16 +01:00
BrennanConroy
927b08f893
Cache property access ( #2030 )
2018-04-15 23:23:00 -07:00
James Newton-King
4f4dfe1d23
Move RedisLog to Internal namespace ( #2038 )
2018-04-16 18:08:26 +12:00
James Newton-King
b5d5f11ef8
Rename excludedIds to excludedConnectionIds ( #2037 )
2018-04-16 18:03:16 +12:00
BrennanConroy
7745fd748a
Extension methods for IHubClients methods ( #2016 )
2018-04-15 22:43:26 -07:00
James Newton-King
0da06fb5d2
Microsoft.AspNetCore.SignalR.Redis API review ( #2036 )
2018-04-16 15:56:49 +12:00
James Newton-King
b3a9011698
API review changes for Microsoft.AspNetCore.SignalR ( #2033 )
2018-04-16 15:54:42 +12:00
James Newton-King
6eac7049ba
Update text and binary formatter helpers to be shared ( #2035 )
2018-04-16 15:19:34 +12:00
Pranav K
d8fc2d4009
Fix test failures
...
* Disable deps file generation in class library project. This workarounds known issue - https://github.com/dotnet/core-setup/issues/3726
* Update RazorProjectRouteModelProvider to not specify a trailing slash. This produces paths with a single slash as opposed to two slashes messing with route creation.
* React to Microsoft.AspNetCore.Mvc.Razor.Extensions.Reference that shows up in the deps file.
2018-04-15 16:31:41 -07:00
James Newton-King
a17320221e
Derp
2018-04-16 10:43:06 +12:00
James Newton-King
62f14054eb
Capture and log prematurely closed connections
2018-04-16 10:41:35 +12:00
James Newton-King
fbb13c4c1f
Improve response status logging
2018-04-16 09:38:47 +12:00
James Newton-King
f8e641d007
Merge
2018-04-15 19:21:07 +12:00
James Newton-King
725bb33949
Lazy initialize HttpConnectionContext.Items ( #2027 )
2018-04-15 19:06:13 +12:00
James Newton-King
9d033aa9f9
Blah
2018-04-15 18:16:23 +12:00
James Newton-King
c835288e84
Suppress web socket closing without handshake
2018-04-15 17:51:31 +12:00
James Newton-King
ddc905c219
Add VerifyNoErrorsScope ( #1972 )
2018-04-15 11:12:21 +12:00
James Newton-King
b9e7113c01
Move types out of .Core namespace and make method virtual ( #2024 )
2018-04-15 09:58:33 +12:00
James Newton-King
377ed1b834
JsonHubProtocol and MessagePackHubProtocol version fields now private ( #2023 )
2018-04-15 09:58:05 +12:00
Doug Bunting
cc5ae02b7d
Fix binding & validating dictionaries of non-simple types in jQuery requests
...
- #7423
- retry failed inner bindings with alternate syntax in `ModelStateDictionary`
- use property syntax if first attempt tried index syntax and visa versa
- instantiate `ShortFormDictionaryValidationStrategy` with full `ModelState` keys
- can now provide exact `ModelState` keys that `ModelStateDictionary` used in inner bindings
- normalize model names without a leading period in `JQueryKeyValuePairNormalizer`
nits:
- take a few VS suggestions
2018-04-14 10:41:00 -07:00
James Newton-King
5a77c8be25
API review Microsoft.AspNetCore.SignalR.Internal ( #2022 )
2018-04-15 00:23:26 +12:00
David Fowler
d6395a52bc
Send delete request after poll ends ( #2020 )
...
* Added test and fixed other test
2018-04-14 04:45:16 -07:00
David Fowler
0f8485cafc
Renamed class to match the file ( #2019 )
2018-04-14 04:08:26 -07:00
James Newton-King
e4d0f2980e
Microsoft.AspNetCore.SignalR.Client refactor ( #2000 )
2018-04-14 21:09:41 +12:00
Ben Adams
e30a02cee5
Less StringValue struct copies for header checks ( #2488 )
2018-04-13 18:21:50 -07:00
BrennanConroy
3f0a6ebc0d
API Review Dependency Injection ( #2015 )
2018-04-13 17:21:48 -07:00
Andrew Stanton-Nurse
1fbb940b82
Remove MSG from SignalR ( #2006 )
2018-04-13 17:08:02 -07:00
Javier Calvarro Nelson
4984dd2cdd
Revert "[ Fixes #7587 ] No easy way to change ASPNETCORE_ENVIRONMENT"
...
This reverts commit 22510e1377 .
2018-04-13 16:51:25 -07:00
Javier Calvarro Nelson
86a036cf76
Revert "[ Fixes #7635 ] Provide a way to configure clients in WebApplicationFactory"
...
This reverts commit 1e26571ba6 .
2018-04-13 16:50:38 -07:00
Andrew Stanton-Nurse
c7f7f36210
API Review for Http.Connections ( #2010 )
2018-04-13 16:35:07 -07:00
Pranav K
95835d6c37
Continue generating RelatedAssemblyPart on assembly if GenerateAssemblyInfo=false
...
Fixes #2257
2018-04-13 16:14:37 -07:00
Pranav K
898b8cec84
Prepare for RazorAssemblyAttribute -> RazorTargetAssemblyAttribute rename
2018-04-13 16:13:44 -07:00
Javier Calvarro Nelson
1e26571ba6
[ Fixes #7635 ] Provide a way to configure clients in WebApplicationFactory
2018-04-13 16:02:56 -07:00
Javier Calvarro Nelson
22510e1377
[ Fixes #7587 ] No easy way to change ASPNETCORE_ENVIRONMENT
2018-04-13 16:02:56 -07:00
Ajay Bhargav Baaskaran
60b6ec047d
Don't fail the build when ExtensionDependencyChecker fails
2018-04-13 15:55:39 -07:00
Kiran Challa
d5e044f693
[ Fixes #7373 ] Assigning to the context's Result property, when implementing IPageFilter, causes an exception
2018-04-13 15:11:44 -07:00
Nate McMaster
faf2f3f065
Attempt to workaround issues with File.Move on NFS file shares ( aspnet/Home#2941 )
2018-04-13 15:08:28 -07:00
BrennanConroy
d0137a996c
Internalize Microsoft.AspNetCore.Http.Connections.Client.Internal ( #2014 )
2018-04-13 15:04:58 -07:00
BrennanConroy
021356bf27
Internalize classes in Http.Connections ( #2013 )
2018-04-13 14:57:37 -07:00
Ajay Bhargav Baaskaran
bfbd286ab6
Remove usages of obsolete APIs
2018-04-13 14:54:35 -07:00
John Luo
2d51d23697
Add file logging to functional tests
2018-04-13 14:53:57 -07:00
Pranav K
8d1de6ec80
Make sure RazorSdk works when BuildingInVisualStudio \ BuildProjectReferences is disabled
...
Fixes #2247
2018-04-13 14:35:04 -07:00
Jass Bagga
a9c7c322cb
Add "webapp" alias to RazorPages template.json ( #467 )
...
Addresses #325
2018-04-13 14:01:20 -07:00
Pranav K
d995b0418a
Allow BindPropertyAttribute to be specified on controller classes
...
Fixes #7350
2018-04-13 13:58:44 -07:00
Ajay Bhargav Baaskaran
f8dc5c4702
Obsoleted IRazorEngineBuilder APIs
2018-04-13 12:35:53 -07:00
Andrew Stanton-Nurse
499d39b364
rename MsgPack assembly only ( #2005 )
2018-04-13 12:01:45 -07:00
BrennanConroy
0919914e56
Internalize more classes ( #2004 )
2018-04-13 11:28:52 -07:00
Jass Bagga
5d52701cd2
Add Error razor page to Spa templates ( #464 )
...
Addresses #332
2018-04-13 11:11:01 -07:00
David Fowler
a8c0970cde
Check for non-null RequestServices ( #1378 )
2018-04-13 09:45:38 -07:00
Martin Costello
2e761415e4
Implement IDisposable for derived types for WebApplicationFactory<T> ( #7637 )
...
* Implement IDisposable for derived types for WebApplicationFactory<T>
Add a protected Dispose method and a finalizer to WebApplicationFactory<T> for use in classes that derive from it and want to dispose of their own resources.
Resolves #7631 .
* Address review feedback
Only dispose of fields if disposing is true.
2018-04-13 09:30:33 -07:00
David Fowler
3e69fdc4ad
Delegate disposable to the IConnectionFactory ( #1999 )
...
- Added DisposeAsync to the IConnectionFactory. It's responsible for disposing the connection after the pipe has closed.
- Added dispose callback to WithConnectionFactory
- Don't wait for poll request to end before unwinding from the transport
- Make sure all http requests are done before returning from StopAsync in both SSE and longpolling
2018-04-13 09:16:23 -07:00
Kiran Challa
f824751bb9
Added Razor class library project template
...
[Fixes #323 ] Add a Razor class library project template
2018-04-13 04:21:49 -07:00
David Fowler
abe139ee16
Make the protocol and messages public ( #1994 )
...
* Move types to a .Protocol namespace
2018-04-13 01:53:41 -07:00
James Newton-King
198013bfa3
Microsoft.AspNetCore.Http.Connections.Client refactors ( #1995 )
2018-04-13 20:13:58 +12:00
David Fowler
83dec1093a
Fixed flaky longpolling tests ( #1993 )
...
- Wait for disposal and removal of the connection
2018-04-13 00:42:31 -07:00
David Fowler
4a568e90d2
API review changes ( #1992 )
...
- Changed GetMessageBytes to return ReadOnlyMemory
- Make HandshakeProtocol.SuccessHandshakeData a readonly field
2018-04-13 00:25:02 -07:00
Mikael Mengistu
70c63fe9e8
Http.Connections.Client API Review changes ( #1987 )
2018-04-13 06:52:27 +00:00
Ahson Khan
0ee4a86564
Collapse AsSpan().Slice(..) into AsSpan(..) ( #1991 )
2018-04-12 23:15:47 -07:00
Mikael Mengistu
0053124ca4
Make Proxies Internal ( #1982 )
2018-04-13 00:38:16 +00:00
Mikael Mengistu
df4d901ae7
Fix 5 param On extension method ( #1984 )
2018-04-13 00:37:13 +00:00
Stephen Halter
10f3b6863e
Avoid nullref in KestrelEventSource ( #2483 )
...
* Avoid nullref in KestrelEventSource
* Improve HostNameIsReachableAttribute to speed up test discovery
2018-04-12 17:29:34 -07:00
Justin Kotalik
4188d2fe68
sttimer changes to V2 ( #773 )
2018-04-12 17:11:38 -07:00
Justin Kotalik
5fd1f9e0e5
Merge remote-tracking branch 'origin/release/2.1' into dev
2018-04-12 16:33:29 -07:00
pan-wang
9c83280770
Fixing couple issues ( #763 )
...
adding more logs and fix memory leak in case of configuration change and then shutdown
2018-04-12 14:10:25 -07:00
Andrew Stanton-Nurse
24328b8e88
fix #1281 by adding support for DELETE endpoint on server ( #1925 )
2018-04-12 12:39:08 -07:00
Andrew Stanton-Nurse
0992db9fd2
fix #1914 by switching RedisProtocol to MsgPack ( #1968 )
2018-04-12 12:10:51 -07:00
Chris Ross (ASP.NET)
4e1ba2a6c7
Delay process exit in ConsoleLifetime #1329
2018-04-12 10:07:44 -07:00
Chris Ross (ASP.NET)
ee12c4fcf2
Downgrade HTTPs handshake failures to debug #1853
2018-04-12 09:25:44 -07:00
Chris Ross (ASP.NET)
c6fa9793eb
Make Protocols internal
2018-04-12 08:53:27 -07:00
Kiran Challa
4184b2406d
Updated to make routing always use UrlEncoder.Default and not depend on DI to get it.
...
[Fixes #513 ] RedirectToAction with Non-English Characters in Parameters and Authentication Causes Error
2018-04-12 05:15:45 -07:00
David Fowler
8b1a7e9199
API review feedback ( #1974 )
...
- Remove SetHttpContext
- Remove HttpContextFeature
- Add and implement IHttpTransportFeature on HttpConnectionContext
- Remove ConnectionMetadataNames
2018-04-12 03:50:14 -07:00
James Newton-King
d4773e831c
Set default transport and application buffer sizes ( #1964 )
2018-04-12 18:23:00 +12:00
James Newton-King
7563ccae20
Always use TaskCreationOptions.RunContinuationsAsynchronously ( #1966 )
2018-04-12 18:21:20 +12:00
David Fowler
3c8c8ea8e1
React to Kestrel changes ( #1969 )
2018-04-11 20:29:17 -07:00
David Fowler
ca44b4adfc
Moved kestrel specific features into transport abstractions ( #2482 )
2018-04-11 20:23:48 -07:00
Pranav K
e34b4e8335
Use DependencyContext.CompileLibraries to determine dependency graph ( #7626 )
...
* Use DependencyContext.CompileLibraries to determine dependency graph
Fixes https://github.com/aspnet/Mvc/issues/7617
2018-04-11 15:57:11 -07:00
David Fowler
f6b2880369
Flow the ConnectionContext to the SNI callback ( #2478 )
2018-04-11 15:56:25 -07:00
David Fowler
08f9990c39
Ensure there's a redis connection earlier
2018-04-11 15:25:38 -07:00
Pranav K
9cea47fa7d
Remove root directory customization options for Razor Pages areas
...
Fixes #7608
2018-04-11 15:25:31 -07:00
Pranav K
9365fcd053
Don't publish the refs directory when the app does not have any Razor files
...
Fixes https://github.com/aspnet/Razor/issues/2246
2018-04-11 15:20:16 -07:00
Mikael Mengistu
b8c3273cae
Dont always copy handlers ( #1945 )
2018-04-11 22:19:51 +00:00
Jass Bagga
c3ac7629d1
WebAPI launchUrl; MVC _LoginPartial; F# AllowedHosts ( #463 )
...
Addresses #455 , #392 , #445
2018-04-11 15:01:32 -07:00
Sébastien Ros
e8bb88cb58
Fixing typo ( #2477 )
2018-04-11 14:27:53 -07:00
Ajay Bhargav Baaskaran
6d9df1ef33
Noop Razor Sdk for F# projects
2018-04-11 14:18:19 -07:00
Chris Ross (ASP.NET)
0b5cb8a8b8
Reload HostFilteringOptions on change
2018-04-11 12:23:14 -07:00
David Fowler
8cc851ff9b
Clean up timer code with custom awaitable ( #1935 )
...
- Gets rid of locks by using an event loop
2018-04-11 10:39:29 -07:00
David Fowler
cb5bba36fc
Get off the event loop before dispatch ( #1952 )
2018-04-11 10:39:09 -07:00
Nate McMaster
b7b6bd9533
React to updates in dependencies and removal of System.Runtime.CompilerServices.Unsafe from netcoreapp ( #429 )
2018-04-11 09:59:22 -07:00
Kiran Challa
62272ad56a
Round off file result's LastModifiedDate to whole seconds for correct comparison with http header dates
...
[Fixes #7572 ] PhysicalFileResult does not respond 304 Not Modified
2018-04-11 06:43:50 -07:00
James Newton-King
12b69a0fdb
Refactor HttpOptions in client ( #1942 )
...
- Rename HttpOptions to HttpConfigurationOptions
- Remove HttpConfigurationOptions from SignalR client project
- Updated client HttpConnection ctors
2018-04-11 20:20:04 +12:00
Justin Kotalik
e2fbff2bd5
Feedback
2018-04-10 23:00:18 -07:00
James Newton-King
b30c2fecbf
SSE formatting refactor ( #1916 )
2018-04-11 17:13:15 +12:00
James Newton-King
c83baf2b76
Remove params from message ctors ( #1931 )
2018-04-11 12:11:13 +12:00
Mikael Mengistu
13f7981010
Rename Callback to Configure in UseConnections ( #1939 )
2018-04-11 00:08:22 +00:00
Mikael Mengistu
e2169ceda6
Connect to Redis asynchronously ( #1922 )
2018-04-10 23:48:11 +00:00
Justin Kotalik
46efcd9332
Move srwWrapper to right location
2018-04-10 14:43:05 -07:00
Justin Kotalik
5c91dbe062
Get tests working
2018-04-10 14:21:23 -07:00
Justin Kotalik
da513bd8d8
Get build.cmd working and cleanup ignored files.
2018-04-10 14:21:00 -07:00
Justin Kotalik
df9efa0770
Code changes to get ANCM current working on github
2018-04-10 14:19:53 -07:00
Justin Kotalik
b594130020
Adds source code from VSTS
2018-04-10 14:19:53 -07:00
Pavel Krymets
157e7f4fdd
Creates two separate projects for ANCM V1 and V2.
2018-04-10 14:19:32 -07:00
FabianMeiswinkel
bec259f976
#364 - Expose HTTP_503_RESPONSE_VERBOSITY option ( #447 )
2018-04-10 12:08:33 -07:00
Pavel Krymets
6629236a0e
Merge pull request #767 from aspnet/pakrym/perf
...
Improve performance
2018-04-10 12:07:26 -07:00
Jass Bagga
da32f45f58
Do not set sslPort if HTTPS not configured ( #458 )
...
Addresses #457
2018-04-10 12:02:10 -07:00
Pavel Krymets
d63e8c5558
CPP
2018-04-10 11:04:34 -07:00
Ajay Bhargav Baaskaran
5504374125
Preserve directive node diagnostics in document node
2018-04-10 10:24:21 -07:00
Pavel Krymets
ee2e46a614
What about now?
2018-04-10 09:08:13 -07:00
Kristian Hellang
6b18dea711
Replace Constants.CompletedTask with Task.CompletedTask ( #235 )
2018-04-10 08:58:39 -07:00
Kristian Hellang
61f7c82d49
Replace Helpers.CompletedTask and Helpers.CanceledTask ( #446 )
2018-04-10 08:57:25 -07:00
Pavel Krymets
80e799d17c
PR comments
2018-04-10 08:30:37 -07:00
Ben Adams
8a3516284e
Add GetMessageBytes to IHubProtocol ( #1915 )
2018-04-10 07:14:09 -07:00
Vegard Løkken
31dfe91962
Support async access token factory ( #1911 )
2018-04-10 05:34:10 -07:00
James Newton-King
6bc2ebb4c5
Use invariant culture and ordinal comparisons ( #1928 )
2018-04-10 16:52:19 +12:00
David Fowler
b030ab7e49
Update Connections.Abstractions.csproj ( #2473 )
2018-04-09 17:55:14 -07:00
BrennanConroy
6d050140e5
Swtich to MessagePack-CSharp ( #1879 )
2018-04-09 17:04:32 -07:00
Pavel Krymets
e32b51d6e6
ENdpoint
2018-04-09 16:47:01 -07:00
Pavel Krymets
f0eab4410a
Cleanup
2018-04-09 15:20:28 -07:00
Pavel Krymets
7a14be006d
Fast reads
2018-04-09 15:16:47 -07:00
flash2048
39053a5e22
Corrects spelling of some comments
2018-04-09 14:37:20 -07:00
Pavel Krymets
5e5aa90575
Remove continue with
2018-04-09 14:26:28 -07:00
Pavel Krymets
0feb83b637
Dont format some things
2018-04-09 12:10:32 -07:00
Pranav K
ec31ff0c28
Throw if multiple Body bound parameters are discovered
...
Fixes #6963
2018-04-09 11:20:34 -07:00
Pavel Krymets
dca31cc6f6
Perf
2018-04-09 10:34:44 -07:00
David Fowler
01089da84d
Use in for ReadOnlySequence ( #1900 )
2018-04-09 09:29:27 -07:00
David Fowler
95e868b68c
Remove JsonSerializer ( #1913 )
2018-04-09 02:56:46 -07:00
Ben Adams
406d8f9a81
readonly readonly structs ( #1908 )
2018-04-08 23:28:37 -07:00
Pavel Krymets
8f1781f7eb
Cleanup LogEvent calls
2018-04-08 19:21:55 -07:00
James Newton-King
bd78785f8d
Minor DefaultHubLifetimeManager improvements ( #1904 )
2018-04-09 12:31:14 +12:00
David Fowler
9fd713c73a
Make MemoryBufferWriter a Stream ( #1907 )
...
- Get rid of LimitArrayPoolWriteStream and use MemoryBufferWriter in its place in the MessagePackProtocol implementation.
- Added tests for MemoryPoolBufferWriter and fixed a bug in CopyToAsync
- Added CopyTo(`IBufferWriter<byte>`)
- Changed MemoryBufferWriter to fill the underlying arrays that back segments, the segment size is now a minimum.
2018-04-08 16:11:17 -07:00
James Newton-King
27d18578d0
Use expression body properties and implicit arrays where possible ( #1906 )
2018-04-08 21:40:01 +12:00
James Newton-King
0f663cadc4
readonly all the things ( #1901 )
2018-04-08 15:47:01 +12:00
David Fowler
4760cce6aa
Remove IConnection ( #2472 )
2018-04-07 18:55:59 -07:00
David Fowler
a3337eb6bd
Remove traces of ASP.NET Core Sockets ( #1899 )
2018-04-07 17:51:12 -07:00
David Fowler
c1049b722d
The grand unification of ConnectionContext ( #1895 )
...
This change rationalizes the 2 very similar abstractions that exist in Connections.Abstractions, IConnection and ConnectionContext. It also introduces an IConnectionFactory to SignalR that is used to create a new ConnectionContext for a HubConnection.
- HubConnection just completes both ends of the transport pipe instead of calling DisposeAsync.
- Implemented ConnectionContext on HttpConnection and added HttpConnectionFactory
- Updated tests
2018-04-07 16:19:01 -07:00
David Fowler
e3da7feab4
Clean up client ITransport interface ( #1893 )
...
- Transports own the pipe creation. The fact they are 2 sides is an implementation detail.
2018-04-07 15:11:42 -07:00
David Fowler
86083c0302
Removing native support for IObservable<T> ( #1890 )
...
- There are too many issues and questions with respect to back pressure and the buffering policy we should use when the client being streamed to can't support the data being pushed via OnNext.
As a result, we're dropping support for IObservable but keeping ChannelReader and we'll eventually support IAsyncEnumerable when that makes it into the BCL.
- Add sample showing Observable -> ChannelReader adaption
2018-04-07 15:10:39 -07:00
James Newton-King
acc0b7ad0d
Serialize NegotiateResponse with IBufferWriter ( #1881 )
2018-04-07 15:50:13 +12:00
David Fowler
f632330d7f
Allocate pipe writer stream per connection ( #1885 )
...
- Don't create the PipeWriterStream per operation, make it per Connection
- Reduce the buffer size for CopyToAsync operations to 4K where possible instead of 81K (the default)
2018-04-06 14:36:35 -07:00
David Fowler
e51676fb47
Policheck errors
2018-04-06 13:01:20 -07:00
David Fowler
e3d90bdf6a
Fix graceful closing of pipes ( #1882 )
...
- Closing pipes gracefully in most cases. The only case where we forcefully close the pipes is during application shutdown
- Return 404 if sending to connection after disposal
- Added tests
2018-04-06 10:59:40 -07:00
Pranav K
5e019bd707
Add Microsoft.AspNetCore.All
...
Fixes https://github.com/aspnet/Mvc/issues/7605
2018-04-06 10:57:59 -07:00
David Fowler
84d43cb2d8
Remove extra class ( #1884 )
...
- Merged 2 DI classes in SignalR
2018-04-06 08:16:19 -07:00
Nate Barbettini
a6bdb9b1ec
Fix typos in code documentation ( #1012 )
...
* Fix typos in code documentation
* Add missing detail to code documentation
2018-04-06 08:09:48 -07:00
Mikael Mengistu
4ddf8664c0
Don't throw from Observer's OnNext ( #1872 )
2018-04-06 00:35:04 -07:00
James Newton-King
36edadabb4
Lock when sending data to connection ( #1876 )
2018-04-06 16:25:47 +12:00
James Newton-King
cb5ece8a24
HttpTransportType refactor ( #1873 )
...
- Rename file to HttpTransportType.cs
- Add HttpTransportType.None
- Move All to static readonly field
- Make TransportType on client and service HttpConnectionOptions consistent
- Move setting defaults into ctor
2018-04-06 16:18:47 +12:00
James Newton-King
921986d561
Fix AccessTokenFactory not being called with each request ( #1880 )
2018-04-06 15:46:36 +12:00
BrennanConroy
b0c4e9d0f7
0 byte read in WebSockets ( #1878 )
2018-04-05 18:50:30 -07:00
Ajay Bhargav Baaskaran
6270c1f47e
Merge branch 'rel/vs15.7' into dev
2018-04-05 16:28:17 -07:00
Ryan Nowak
4cd24a2b08
Add experimental flag to un-special-case data-
...
This change allows blazor to opt into treating data- attributes the same
way as normal attributes in the parser.
2018-04-05 15:27:04 -07:00
Ryan Nowak
d1c0ab587c
Add support for type parameters to class nodes
...
This change will allow someone extending Razor to use generic type
parameters in generated classes.
There's no user-level extensibility provided here yet, as in there is no
language support for adding type parameters.
2018-04-05 15:26:42 -07:00
Andrew Stanton-Nurse
19b2fea0d8
Preserialize for all formats when sending through Redis ( #1843 )
2018-04-05 13:48:14 -07:00
David Fowler
39f693b9ed
Found these while looking at a flaky test ( #1871 )
...
- Fix crashing test
- Dispose the ClientWebsocket in StopAsync
2018-04-05 12:47:39 -07:00
BrennanConroy
b9e88923e7
Comment why we set X-Requested-With ( #1870 )
2018-04-05 11:38:15 -07:00
Justin Kotalik
47c7c1ad8f
Disable global loading of RequestHandler for in-process ( #732 )
2018-04-05 10:36:15 -07:00
Jass Bagga
4236f0e51c
Fix AllowedHosts configuration ( #452 )
...
Addresses #451
2018-04-05 10:08:40 -07:00
David Fowler
11343ea15d
Add logging by default to HubConnectionBuilder ( #1867 )
...
- Use the AddLogging extension method by default in the HubConnection
- Removed WithConsoleLogger extension methods
- Removed WithLoggerFactory extension method (moved to test only)
- Added WithLogger that uses the new the new ILoggerBuilder
2018-04-05 10:05:07 -07:00
David Fowler
35b6d81f77
Don't dispose on cancellation ( #1859 )
...
- We're already disposing now at the end of enumeration
2018-04-05 09:22:46 -07:00
David Fowler
61c3d0c403
Added Microsoft.AspNetCore.SignalR.Protocols.Json ( #1861 )
...
- Fixed package descriptions
- Call AddJsonProtocol from both the SignalR.Core (client and server)
2018-04-05 01:32:10 -07:00
James Newton-King
f7fc2647de
var all the things ( #1855 )
2018-04-05 18:41:13 +12:00
Andrew Stanton-Nurse
fccc9d1b50
fix #1815 by disposing linked cts ( #1849 )
2018-04-04 21:12:21 -07:00
Phil Henning
8a368b5610
Add supportedAuthentication for NoAuth in templates which have NoAuth ( #443 )
...
* Add supportedAuthentication for NoAuth in templates which have NoAuth
This is to work around an issue in Visual Studio
* Remove spurious ,
* Add supportedAuthentications to F# Web API vs-2017.3.host.json
2018-04-04 18:10:04 -07:00
Ajay Bhargav Baaskaran
ae42d7599d
Show error if page directive is not at the top of file
2018-04-04 17:27:10 -07:00
BrennanConroy
32b4d5cc6c
Set X-Requested-With on all requests ( #1848 )
2018-04-04 17:12:50 -07:00
BrennanConroy
80f87e7730
Add Handshake timeout to C# Client ( #1840 )
2018-04-04 15:54:42 -07:00
David Fowler
490fd088f9
Merge branch 'release/2.1' into dev
2018-04-04 15:02:47 -07:00
David Fowler
924272ad1a
Revert "Merged release/2.1"
...
This reverts commit cf45fac634 , reversing
changes made to 313772ef03 .
2018-04-04 15:02:20 -07:00
Chris Ross (ASP.NET)
2ee0d6e337
Delay loading the dev cert #2422
2018-04-04 14:54:27 -07:00
David Fowler
cf45fac634
Merged release/2.1
2018-04-04 14:48:26 -07:00
David Fowler
1c7ca7fa3a
Remove lazily initialization of the pipes ( #1850 )
...
- This fixes race condition
2018-04-04 14:43:34 -07:00
Chris Ross (ASP.NET)
953496a970
Merge branch 'release/2.1' into dev
2018-04-04 13:44:56 -07:00
David Fowler
5e190b404f
Remove lazily initialization of the pipes
...
- This fixes race condition
2018-04-04 13:00:20 -07:00
Chris Ross (ASP.NET)
9ea2c50068
Add SNI support #2357
2018-04-04 12:49:29 -07:00
Ajay Bhargav Baaskaran
b1007744b0
Added PipeOptions.CurrentUserOnly option to the named pipe streams
...
Don't run on server if CurrentUserOnly is not available
2018-04-04 09:53:36 -07:00
BrennanConroy
afa56e3012
MsgPack perf ( #1845 )
2018-04-04 07:11:16 -07:00
James Newton-King
e7b84b753b
Refactor HubConnectionBuilder ( #1830 )
2018-04-04 21:19:13 +12:00
Mikael Mengistu
7c2d9e87e9
Clean up pipe pair on transport start failure ( #1836 )
2018-04-03 17:08:04 -07:00
Mikael Mengistu
ba0131a731
Rename TransportTypes to HttpTransportTypes ( #1839 )
2018-04-03 16:00:20 -07:00
Andrei Amialchenia
70ce044778
Corrects spelling of some comments ( #2461 )
2018-04-03 15:55:17 -07:00
Jass Bagga
52ffc89fef
Remove duplicated UseHttpsRedirection ( #437 )
...
Addresses #436
2018-04-03 14:02:52 -07:00
Pavel Krymets
d23f2beafc
Merge release/2.1 into dev ( #1834 )
2018-04-03 10:45:44 -07:00
Pavel Krymets
81bf9fb66b
Merge release/2.1 into dev ( #421 )
2018-04-03 10:45:34 -07:00
Pavel Krymets
ba06c58bcb
Merge release/2.1 into dev ( #2460 )
2018-04-03 10:45:31 -07:00
Pranav K
6ee08a985d
React to Mvc changes
2018-04-03 10:11:52 -07:00