Commit Graph

171 Commits

Author SHA1 Message Date
Chris Ross 1dc31a7613
Sync script changes from the runtime repo (#19062)
* Sync script changes from the runtime repo #18943

* Additional change
2020-02-14 19:59:35 +00:00
Chris Ross e9e6b53526
Restructure shared http code (#18967)
* Restructure shared runtime code

* More qpack

* Header field

* HttpSys tests

* Casing
2020-02-12 18:07:32 +00:00
Justin Kotalik 9733704aea
Update shared code for HTTP/2 and HTTP/3 (#18958) 2020-02-11 14:25:46 -08:00
Justin Kotalik 6042fab581
Replat on HTTP/3 changes, fixing up minor nits to be compatible with h3-25 (#18912) 2020-02-11 11:17:42 -08:00
Günther Foidl aa7804c247
Don't mutate strings in Kestrel (#17556)
* Removed mutating of string-contents in BCryptHandle

* Revert "Removed mutating of string-contents in BCryptHandle"

This reverts commit 5ae80c2834471baf34d1e5a05a42e3cce1ff02d7.

This is a .NET STandard 2.0 project, so no span is available by default. I think it's not worth it to add a reference to System.Memory-package just for this change.

* Better perf for StringUtilities.TryGetAsciiString

* Removed mutating of created string from HttpUtilities

* Use static readonly span-actions as this gives a boost due to not having a null check for the compiler generated cached delegate

* Debug Asserts

* PR Feedback
2020-02-10 22:21:07 +00:00
Justin Kotalik 1daebd1722
Replat on System.Net.Quic (#18689) 2020-02-07 10:43:08 -08:00
Edward Neal e7ea31b1c7
Allow opt-out from client certificate root checking (#15029)
* Added a new property, ValidateCertificateChain

This aligns the code with README.md, and enables chained certificate authentication to work in Azure App Service (which won't have the client certificate's root in its trust store)

* Updated reference assemblies

New ValidateCertificateChain property was missing from /ref - hadn't updated it, so automatic test was failing

* Replaced the broad property which disables certificate chain validation with a granular list of trusted issuers

Also updated documentation to remove the unused property and to indicate that it isn't possible to validate half of the chain from the OS' trust store, and half from the private root store

* Swapped property access for an AddRange call

* Updated reference assembly

* Added certificate tests

Three test cases:
- Untrusted client certificate should fail, as it does now.
- Client certificate which is part of a chain with an untrusted root but a trusted issuer should fail, since the chain as a whole isn't trusted.
- Client certificate which is part of a fully-trusted chain should pass.

Also noticed that there were a couple of issues in CreateServer, where the certificate revocation flags weren't being set properly.

Finally, the csproj was referring to a folder name ("test\Certificates") which didn't exist. It looks like the folder was renamed to "TestCertificates", so I've update the project to match.

* Update Microsoft.AspNetCore.Authentication.Certificate.netcoreapp.cs

* Reverting change of Tests csproj, which was blocking certificate tests

* Forgot to add certificates to the shared source root, so tests were failing

* Updating following code review

Replaced custom logic with a new ChainTrustValidationMode property. Updated reference assemblies

* Changed tests to account for new property

* Updated certificates for PR tests

* Updated certificates

Updating all new certificates to avoid using the alternate signature algorithm

* Dummy checkin

Compilation errors coming from CertificateTests.cs, performing this checkin to test whether or not they're limited to a specific build.

* Following up typo corrections

Commit 116799fa70 in upstream repo changed a variable name, causing compile errors on PR build. Fixing that

Co-authored-by: Hao Kung <HaoK@users.noreply.github.com>
2020-02-06 15:15:38 -08:00
Pranav K 6d83fee518
Only download chrome driver for selenium (#18676)
* Only download chrome driver
2020-01-31 16:09:07 -08:00
Nick Kirby d6cb79e64a
Use FirstSpan instead of calling First.Span (#18615) 2020-01-31 12:51:40 -08:00
Kevin Pilch 91d17f6c2d
Update links from aspnet/AspNetCore-Internal -> dotnet/aspnetcore-internal (#18540) 2020-01-23 12:21:06 -08:00
James Newton-King df712cc4a9
Add HttpProtocol (#18049) 2020-01-16 13:35:47 +13:00
Maher Jendoubi 116799fa70 Contributing: Fixed some typos (#18331) 2020-01-14 08:58:52 -08:00
Chris Ross 17094a33c1 Suppress unused code warning in the shared test project (#18249) 2020-01-10 17:56:37 +00:00
Kevin Pilch 0517745c08 aspnet/AspNetCore -> dotnet/aspnet
Except aspnet/AspNetCore-Internal.
2020-01-08 16:40:11 -08:00
Kevin Pilch f3215fd881 aspnet/AspNetCore-Tooling -> dotnet/aspnetcore-tooling 2020-01-08 16:40:11 -08:00
Martin Costello b6b5319bab Use UnixEpoch for cookie deletion (#18126)
Use the DateTimeOffset.UnixEpoch field instead of a new DateTime value when deleting cookies.
2020-01-04 12:39:53 -08:00
Kahbazi adb12f23d0 Use AppendJoin(...) instead of Append(string.Join(...)) on StringBuilder (#18007) 2020-01-02 08:05:54 -08:00
Kahbazi b56f84131a Use Count instead of Any() on List (#18022) 2020-01-02 07:55:29 -08:00
Erhan Atesoglu b028b51e3d Update ReadMe.SharedCode.md (#17889)
This commit reflects the changes made to the runtime libraries version.
2019-12-14 21:17:56 -08:00
Brennan efd765e970
Update wording (#17757) 2019-12-10 21:18:41 -08:00
Chris Ross b719a799ae
Update h2 sync scripts (#17720) 2019-12-10 11:17:16 -08:00
Chris Ross aca5f04922
Expose Http.Sys's Http/2 Reset error code API #17276 #16988 (#17645) 2019-12-09 06:17:38 -08:00
Chris Ross bd7c89aa20
Pubternal IHttpHeadersHandler (#17573) 2019-12-04 09:40:17 -08:00
Chris Ross 3b7cdc166a
Generalize Http2Cat #14894 (#17438) 2019-12-03 16:16:52 -08:00
Günther Foidl 9e67b7b22e Use C#'s ReadOnlySpan static data optimization in more places (#14447) 2019-11-24 18:04:26 -08:00
Chris Ross ca23b1a325
Pool HttpSys request buffers (#17314) 2019-11-22 15:35:47 -08:00
Chris R ab0ba0b9c0 React to change in LambdaCompiler #17061 2019-11-14 10:08:42 -08:00
Günther Foidl 20f2168869 HTTP/2 code sharing shell sync-script (#16885) 2019-11-12 08:17:58 -08:00
Chris Ross f8f60cd42e
HttpSys HTTP/2 Response Trailers #13893 (#16877) 2019-11-08 17:12:37 -08:00
Kamron Batman d4f7a199c7 [Low Risk Cleanup] Removes double semicolons (#16794) 2019-11-05 11:33:58 -08:00
Justin Kotalik 3ecdc40318 Synchronize Http/2 HPack implementation between CoreFx and ASP.NET Core (#13931) 2019-11-01 17:32:21 -07:00
Brennan Conroy 433a5a0f97 Merge branch 'merge/release/3.1-to-master' of https://github.com/dotnet-maestro-bot/AspNetCore into release/3.1 2019-10-31 16:15:52 -07:00
Javier Calvarro Nelson 3ceca46c5b
[Platform] Provide a better error message when the developer certificate can't be used (#16659)
Improves the error message Kestrel gives when the developer certificate key is not available for some reason.
2019-10-31 21:50:26 +01:00
Pranav K 882df6003f
Merge remote-tracking branch 'origin/release/3.1' 2019-10-23 16:23:13 -07:00
Brennan Conroy 859c1e085e Merge branch 'master' into merge/release/3.1-to-master 2019-10-23 14:06:23 -07:00
Pranav K c298c94fe1
Validation fixes for Blazor (#14972)
* Validation fixes for Blazor

* Ensure validation result that are not associated with a member are recorded. Fixes https://github.com/aspnet/AspNetCore/issues/10643
* Add support for showing model-specific errors to ValidationSummary
* Add support for nested validation and a more suitable CompareAttribute. Fixes https://github.com/aspnet/AspNetCore/issues/10526
2019-10-18 11:26:17 -07:00
David Fowler 9098a47dbf
Some minor clean up of Stream implementations (#14986)
* Some minor clean up of Stream implementations
- Use TaskToApm from corefx to implement Begin/End in streams
- Use PipeReader.CopyToAsync(Stream) to implement CopyToAsync
- Add more overrides on derived Streams in IIS
2019-10-16 22:04:29 -07:00
Doug Bunting 0dedfa95d4
Merge branch 'release/3.1' -> 'master' 2019-10-14 09:32:59 -07:00
John Doe 288bedd9a3 Fixes spell across test classes and comments (#14958) 2019-10-13 20:46:20 -07:00
Ryan Brandenburg a68c961a58
Dev exception notifications (#14636)
Blazor dev exception notification
2019-10-09 16:37:57 -07:00
Chris Ross f3b0fbe207
Allow opt out of HttpSys client cert negotiation #14806 (#14839) 2019-10-09 15:57:11 -07:00
Günther Foidl 53a54d9f91 Tests for GetHttpProtocolVersion (#14477) 2019-10-08 10:48:58 -07:00
Kristian Hellang d4a2fa1ceb Handle exceptions thrown by PEReader (#14612)
* Catch and log exceptions from PortablePdbReader.PopulateStackFrame
2019-10-08 08:45:25 -07:00
Doug Bunting 0a79d34f62
Merge branch 'release/3.1' => 'master' (#14674) 2019-10-06 15:51:41 -07:00
Javier Calvarro Nelson cca42d9624 [Blazor][Fixes #13357] input type=time reseting value (#14379)
* [Blazor] input type=time reseting value
* Normalizes values on the client and sends proper dates and times to
  the server.
* Normalizes values applied from the server to the client.
* Introduces @bind and @bind-value support for inputs of types
  datetime-local, month, time.

Fixes #13357

* Update JS
2019-10-02 15:21:00 -07:00
Adrian D. Alvarez d053361151 Add visual cue to highlighted code when exception is thrown 2019-10-02 15:11:48 -04:00
Doug Bunting a3ac1ce895
Merge branch 'master' into merge/release/3.1-to-master 2019-10-02 10:25:59 -07:00
Javier Calvarro Nelson 6bc4d27bfa Support parameters on server-side rendered components
Fixes https://github.com/aspnet/AspNetCore/issues/14433
2019-10-01 16:09:06 -07:00
bkatms 51ae61baca Support attaching to an existing request queue in HTTP.SYS (#14182) 2019-10-01 16:05:52 -07:00
Chris Ross 5df258ae5b HttpSys GoAway (#14522) 2019-10-01 16:05:22 -07:00