Pranav K
164d14064c
Use casing for ProblemDetails that specified by RFC
...
* Use JsonProperty.MemberName to specify lowercase casing for ProblemDetails properties -
https://tools.ietf.org/html/rfc7807#section-3
* Use XML NS and lowercase for Xml elements specified by RFC -
https://tools.ietf.org/html/rfc7807#appendix-A
Fixes https://github.com/aspnet/Mvc/issues/8501
2018-10-12 14:15:28 -07:00
Pranav K
f6fc34aff9
React to CORS changes
2018-10-11 12:23:43 -07:00
James Newton-King
9daf5ff7a4
Fix PageRouteTransformerConvention with custom page routes ( #8576 )
2018-10-10 18:33:30 +13:00
Doug Bunting
5bddd226a3
Use Internal.AspNetCore.Sdk as an MSBuild SDK
...
- should resolve issues with occasional strange MSBuild caching issues in this repo
- modeled after aspnet/Scaffolding#905
- follows aspnet/BuildTools#729 recommendation to check in global.config file
- see also Microsoft/msbuild#2914
- use newer KoreBuild
- `.\build.cmd -update /t:noop`
2018-10-04 15:12:38 -07:00
Pranav K
153165f9ad
Handle OPTIONS requests without a handler in Razor Pages ( #8528 )
...
* Handle OPTIONS requests without a handler in Razor Pages
Fixes #7438
2018-10-04 12:25:36 -07:00
James Newton-King
94101a9cde
Add PageRouteTransformerConvention ( #8541 )
2018-10-04 17:34:26 +13:00
James Newton-King
7854d65c11
Support page parameter in attribute route ( #8530 )
2018-10-04 14:39:40 +13:00
Ryan Nowak
cb1393cbb1
Adding functional tests for LinkGenerator
2018-09-29 20:34:48 -07:00
Doug Bunting
5c8dfef15e
Change `CollectionModelBinder` and `ComplexTypeModelBinder` to enforce `[BindRequired]`
...
- #8180
- add an error when binding fails for top-level model
- same case as when MVC creates "default" / empty model i.e. `ParameterBinder` can't detect this
- update `CollectionModelBinder` subclasses and the various providers as well
- controlled by existing `MvcOptions.AllowValidatingTopLevelNodes` option
smaller issue:
- change `ModelBinding_MissingBindRequiredMember` resource to mention parameters too
2018-09-21 11:08:16 -07:00
Pranav K
9c424b7b02
Use content-type specified by ProducesAttribute if no formatter supports it
...
This allows users to use `ProducesAttribute` to specify the content-type
for action results such as FileStreamResult where the result determines the content type
and the specified value is informational.
Fixes https://github.com/aspnet/Mvc/issues/5701
2018-09-19 13:51:31 -07:00
Pranav K
c73b13f544
Cherry-pick @pranavkm's functional test for #7562
...
- 30a5eda508 / origin/prkrishn/form-file-value-provider
Was:
Design: Use a value provider to allow nested form files
Fixes https://github.com/aspnet/Mvc/issues/7562
2018-09-18 11:44:48 -07:00
James Newton-King
8791f9ad0d
Change test parameter transformer to slugify values ( #8453 )
2018-09-15 09:14:48 +12:00
Pranav K
cb88e906b2
Allow ProducesAttribute to apply along with conventions
...
Fixes #8389
2018-09-12 13:58:02 -07:00
Simon Cropp
43d4416a1d
Fix typos ( #8413 )
2018-09-12 09:34:45 -07:00
James Newton-King
dfae9c208a
Add IParameterTransformer support ( #8329 )
2018-09-12 21:46:41 +12:00
Ryan Brandenburg
9895593926
Include diagnosticMessages from xunit for Functional tests
2018-09-07 15:00:33 -07:00
Casey O'Brien
74ba9898f4
[ Fixes #8250 ] Improve the error message when TEntryPoint is not in an entry point assembly
...
Validates that the type used as a generic argument in WebApplicaitonFactory is contained within the entry point to assembly and throws InvalidOperationException otherwise
2018-09-06 18:02:21 -07:00
Pranav K
07cc9e66c6
Add a feature to disable file watching in Razor pages ( #8369 )
...
* Add a feature to disable file watching in Razor pages
Fixes https://github.com/aspnet/Mvc/issues/8362
2018-09-06 10:16:31 -07:00
Simon Cropp
b156dee4f1
Fix some spelling ( #8378 )
2018-09-06 07:39:01 -07:00
Ryan Nowak
1128bd572c
Add a functional test for middleware after routing
...
It came up during routing discussions that we don't have any tests for
this scenario.
2018-08-30 14:51:56 -07:00
Pranav K
f90a47c5af
Introduce ProducesErrorResponseTypeAttribute
...
Fixes https://github.com/aspnet/Mvc/issues/8288
2018-08-30 11:24:03 -07:00
James Newton-King
927e7c8bfc
Support route data tokens with Endpoint Routing ( #8360 )
2018-08-30 15:14:34 +12:00
Pranav K
82a01a414d
Set trace id in ProblemDetalsClientErrorFactory
2018-08-29 16:03:08 -07:00
Ryan Brandenburg
234b003b31
Set longRunningTestSeconds for Functional tests
2018-08-29 11:02:43 -07:00
Pranav K
d09c3c9e28
Polish ProblemDetails
...
* Add ability to set extended members on ProblemDetails
* Skip empty valued properties when serializing ProblemDetails
Fixes #8296
Fixes #8317
2018-08-28 16:21:39 -07:00
Pranav K
667ad4daff
Use ClientErrorData to configure ClientErrorResultFilter
...
Fixes #8289
2018-08-28 13:35:32 -07:00
Ryan Nowak
96b77c8663
Fix aspnet/Routing#721
2018-08-28 12:26:13 -07:00
Ryan Nowak
0fcf2448c3
Fix aspnet/Routing#722
...
Exposes a separate change token that will be triggered after action
descriptors have been updated.
2018-08-27 17:24:21 -07:00
Javier Calvarro Nelson
dfb579d45c
[ Fixes #8021 ] Copy the request headers before sending the request on the RedirectHandler
...
If another handler modifies the request headers the modified headers get
applied on subsequent requests, which is not correct. This change copies
the headers before sending the request and uses the original headers for
the redirect request instead of the potentially modified ones.
2018-08-23 16:09:05 -07:00
Pranav K
8eea0ad44c
Update tests to latest compat switch
2018-08-23 08:09:02 -07:00
James Newton-King
03da30f3bf
Replace remaining references to global routing ( #8312 )
2018-08-23 10:23:29 +12:00
Pranav K
5bd818bd64
Introduce ProblemDetailsFilter
...
Fixes https://github.com/aspnet/Mvc/issues/6786
2018-08-21 17:29:12 -07:00
N. Taylor Mullen
f624c9aa7b
Add flaky test logging for `CacheTagHelper_VaryByCultureComposesWithOtherVaryByOptions`.
...
#8281
2018-08-21 15:07:31 -07:00
Pranav K
522006d2c8
[Design] Add a MaxValidationDepth option to ValidationVisitor
...
Fixes #7357
2018-08-16 15:01:18 -07:00
Ikebe Shodai
253ac7c143
Ignore line ending diff
2018-08-10 11:09:49 -07:00
Pranav K
9da8e2c908
Ensure UnsupportedContentTypeFilter runs before ModelStateInvalidFilter
...
Both UnsupportedContentTypeFilter and ModelStateInvalidFilter use ModelState to
determine the response. UnsupportedContentTypeFilter returns a more specific
response and should execute earlier than the latter filter.
Fixes #8236
2018-08-10 10:39:13 -07:00
Pranav K
ce8fc29728
ConsumesAttribute accepts requests without content type
...
Fixes #8174
2018-08-02 16:27:23 -07:00
Ryan Nowak
2b289d2f2c
Use MatcherPolicy for Consumes
2018-08-01 19:05:04 -07:00
Kiran Challa
ab84d17bb3
Unskip endpoint routing functional tests
2018-08-01 07:22:42 -07:00
James Newton-King
046af405b6
Rename global routing to endpoint routing ( #8179 )
2018-08-01 15:05:49 +12:00
Pranav K
0102d4efab
Introduce ApiConventionMethodAttribute
...
Fixes #8147
2018-07-30 11:13:25 -07:00
Ryan Nowak
fbae57cde1
React to the removal of EndpointConstraint
2018-07-28 19:03:16 -07:00
James Newton-King
c01c7075be
Add EndpointMetadata to ActionDescriptor and hookup CORS ( #8158 )
2018-07-28 16:12:54 +12:00
Doug Bunting
0d427a60e5
Use `TheoryData` properties to avoid duplicate test data
...
- couldn't just remove duplicate `[TheoryData]` in `GlobalRoutingTest`
- xUnit analyzers don't understand `[InlineData]` is inherited (though runtime certainly does)
2018-07-26 10:12:50 -07:00
Ryan Nowak
b71d5da05e
Fix test break due to 405 returned from routing
2018-07-24 22:15:32 -07:00
James Newton-King
c08504b08a
MVC startup experience ( #8131 )
2018-07-25 14:30:51 +12:00
Ryan Nowak
196e3f109f
React to Routing branding
...
This is a reaction PR for the branding changes in progress in Routing.
This can be merged after the changes to in to Routing.
2018-07-22 19:47:15 -07:00
Kiran Challa
e1e7ec0f28
Enable couple of skipped Dispatching functional tests
2018-07-21 04:44:38 -07:00
Alexej Timonin
d4beab5d09
CompositeValidationAttribute
...
- Add abstract CompositeValidationAttribute.
- Change DataAnnotationsMetadataProvider.CreateValidationMetadata to
populate ValidatorMetadata with validation attributes from CompositeValidationAttribute.
2018-07-20 15:31:14 -07:00
Ryan Nowak
5c488bf09c
make feature branch build
2018-07-20 12:57:43 -07:00