Commit Graph

20084 Commits

Author SHA1 Message Date
Pranav K 126f14dbd2
Component package updates (#23371)
* Stop cross-compiling Component packages
* Remove Microsoft.JSInterop reference from M.A.Components
* Update RCL template

Fixes https://github.com/dotnet/aspnetcore/issues/23124
Fixes https://github.com/dotnet/aspnetcore/issues/23351
2020-06-29 11:36:59 -07:00
Stephen Halter b446ab7c6f
Add custom request header decoder API to Kestrel (#23233) 2020-06-26 19:49:35 -07:00
Pranav K 23a3e845e5
Add RazorLangVersion 5.0 (#23408)
* Add RazorLangVersion 5.0

* Fixup more tests. Add a test for 3.1
2020-06-26 17:49:29 -07:00
Pranav K 65d9429a7d
Add workaround for https://github.com/mono/linker/issues/1298 (#23368) 2020-06-26 08:54:38 -07:00
Eric Erhardt 4891eadbbc
Remove the file extension in CreateBlazorTrimmerRootDescriptorFile (#23330)
The linker doesn't resolve assemblies correctly if the file extension (.dll) is included in the assembly name in the descriptor xml file.

See also https://github.com/mono/linker/issues/1294
2020-06-26 08:34:03 -07:00
Pranav K 1f56e82732
Annotate Components.Forms \ Components.Web \ Component.Server with nullable attributes (#23204) (#23355)
* Annotate Components.Forms \ Components.Web with nullable attributes
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Fixup

* Fixup rebase

* Undo nullable

* Fixup
2020-06-25 14:32:43 -07:00
Hao Kung be0b9e48b5
Update System.IdentityModel.Tokens.Jwt to 6.6 (#22846)
* Update System.IdentityModel.Tokens.Jwt to 6.6

* Update Versions.props

* Add newtonsoft refs

* Update OIDC instructions

* Fixup JwtBearerSample TFM

Co-authored-by: John Luo <johluo@microsoft.com>
2020-06-25 14:25:59 -07:00
Pranav K a93ff60904
SDK fixes (#23317)
* Fix up Blazor ILLink Descriptor files

1. Add the typegranularity file to TrimmerRootDescriptor.
2. Remove the application assembly descriptor file, since the application assembly is passed in as a RootAssembly already.

* Razor SDK fixups for blazor

* Only include dlls when generating type granular assemblies
* Write server-worker to the obj directory

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
2020-06-25 08:52:53 -07:00
Safia Abdalla 4465a8efc8
Disconnect circuit on `beforeunload` event (#23224) 2020-06-24 11:35:28 -07:00
Pranav K f6a6e4bd07
Replat blazor on net5 (#23078)
* Replat blazor on net5

* Make all e2e tests pass

* Fixup

* Update js files

* Fixups

* Fixup

* Fixup

* Skip globalization tests

* Undo workarounds

* PR feedback

* Update dependencies from https://github.com/dotnet/runtime build 20200622.6

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
 From Version 5.0.0-preview.7.20321.2 -> To Version 5.0.0-preview.7.20322.6

* Update js file

* Fix version

* Fixup

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-06-23 18:19:55 -07:00
Pranav K baf7e6c4d6
Add support for optional FromBody parameters (#22634) (#23246)
* Add support for optional FromBody parameters (#22634)

* Add support for optional FromBody parameters

Fixes https://github.com/dotnet/aspnetcore/issues/6878

* Fixup nullable

* Changes per API review

* Fixup doc comment (#23229)
2020-06-23 08:06:14 -07:00
Sourabh Shirhatti c97a0020d8
Use implicit logging scope for Activity (#22376)
* Revert "Hoist activity fields to the logging scope (#11211)"

This reverts commit f7a2d3c26c.

* Remove tests with Activity

* Remove ActivityId from HostingLogScope

* Enable propogation in CreateDefaultBuilder

* Clean up

* s/logging/loggingBuilder

* Enable Activity propogation for generichost

* Replace with runtime/pull/37892
2020-06-22 10:12:22 -07:00
Steve Sanderson 36be16b640
Fix binding <select> to a null value (#23221) 2020-06-22 17:27:02 +01:00
Artak adbedd2cfb
Render aria-invalid if the state is invalid (#23131)
* Render aria-invalid if the state is invalid

Co-authored-by: Pranav K <prkrishn@hotmail.com>
2020-06-21 21:43:29 -07:00
Hao Kung 8541bf6c98
Flow endpoint and httpcontext always from authz middleware (#22672) 2020-06-19 18:14:47 -07:00
Chris Ross 4d7a79ad64
Change HttpSys default client cert mode to Allow Cert #14840 (#23162) 2020-06-19 16:34:56 -07:00
Pranav K 724c2e75a7
Add nullable annotations to Microsoft.AspNetCore.Components (#22944)
* Add nullable for Microsoft.AspNetCore.Components
Contributes to https://github.com/dotnet/aspnetcore/issues/5680

* Fixup
2020-06-19 18:38:37 +00:00
Safia Abdalla 52de5ee4df
Fix up rendering for select elements with options component (#22978)
* Fix up rendering for select  elements with options component
* Commit updated compiled JS
* Update test case with more scenarios
2020-06-19 08:43:05 -07:00
Filip Staffa a77e68f1c5
Kestrel Endpoints' "SslProtocols" settable via config (#22663) (#22910) 2020-06-19 08:09:56 -07:00
John Luo bb92c602d8
Fix Windows 7/8 Kestrel tests (#23069) 2020-06-19 00:24:21 -07:00
Pranav K f3b370c1ac
Annotate Authorization.Core, Authorization.Policy with nullable (#22990)
Contributes to https://github.com/dotnet/aspnetcore/issues/5680
2020-06-18 23:43:35 +00:00
Safia Abdalla a173be28fb
Add support for <BlazorWebAssemblyLazyLoad /> item group (#23071)
* Add support for <BlazorLazyLoad /> item group
* Respond to feedback from peer review
2020-06-18 16:05:34 -07:00
Doug Bunting ab7f3f2018
Enable `/warnAsError` (#23072)
* Enable `/warnAsError` in Windows builds
  - already enabled in non-Windows builds because override existed only in build.ps1
* Allow some warnings related to closed issues
  - common `<NoWarn>$(NoWarn);CS1591</NoWarn>` case unchanged
    - /Directory.Build.props ensures that warning remains a warning but doesn't hide it
* !fixup! Root build.sh _does_ disable warnings as errors
  - variable eng/common/tools.sh uses named `warn_as_error`
2020-06-18 15:59:34 -07:00
Stephen Halter 6abc3c759f
Fix Kestrel HTTP/2 debug assert failure (#23062) 2020-06-18 15:13:18 -07:00
Safia Abdalla f627352387
Fix authorization setup in Razor pages template (#23029) 2020-06-18 13:30:08 -07:00
Doug Bunting 214df1c8ef
Merge pull request #22902 from dotnet-maestro-bot/merge/release/3.1-to-master
[automated] Merge branch 'release/3.1' => 'master'
2020-06-18 12:24:36 -07:00
Pranav K a44c1ad78c
Fix null reference errors in tests (#23091)
Fixes https://github.com/dotnet/aspnetcore/issues/22992
2020-06-18 11:05:54 -07:00
Justin Kotalik cbb8c6d915
Update FormsTest.cs 2020-06-18 09:48:40 -07:00
John Luo c83fd8951a
Add sharedfx and targeting pack tests (#23045)
* Add test for assembly versions

* Add test for framework list

* Add some hardcoded lists for sharedfx and targeting pack content
2020-06-17 17:06:04 -07:00
John Luo 45e6571649
Downgrade or throw when HTTP/2 over TLS is configured on older Windows versions (#22859)
HTTP/2 over TLS is not compatible with Windows versions strictly older than Windows 10 or Windows Server 2016. Update kestrel to:
- Downgrade to HTTP/1.1 when Http1AndHttp2 is configured.
- Throw NotSupportedException when Http2 is configured.
- Allow HTTP/2 over TLS to be enabled if AppContext switch Microsoft.AspNetCore.Server.Kestrel.EnableWindows81Http2 is set. This allows users who have configured cipher suites on Windows 8.1 and Windows Server 2012 R2 to continue using HTTP/2 over TLS.
2020-06-17 16:50:48 -07:00
Safia Abdalla 7a82a48a20
Fix build issues in Blazor WASM template tests (#23052) 2020-06-17 15:31:00 -07:00
Justin Kotalik 855a73816d
Update Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.csproj 2020-06-17 13:54:53 -07:00
Justin Kotalik c5b7eab345
Update Microsoft.AspNetCore.Server.HttpSys.csproj 2020-06-17 13:53:19 -07:00
Doug Bunting c4c6e25a06
Add missing doc files and cleanup nits (#22931)
* nit: Remove useless `$(HasReferenceAssembly)` settings
  - set in /Directory.Build.targets
    - `true` only in `$(IsAspNetCoreApp)` projects
* nit: Remove useless `$(CompileUsingReferenceAssemblies)` settings
  - no current versioning differences between ref/ and src/ assemblies when targeting default TFM
* Add more `$(GenerateDocumentationFile)` settings
  - increases the number of generated doc files, mostly without problems
- !fixup! correct typo in `DebugProxyHost` doc comments
    - was not generating a doc file before
  - remove previous (ineffective) src/Components/Directory.Build.targets setting
  - nit: remove a duplicate `$(GenerateDocumentationFile)` setting
* nit: Remove useless `$(IsPackable)` settings
  - only analyzers and implementation projects are packable by default
    - main use case for explicit setting is projects shipping only in shared framework
  - conditional setting in src/Mvc/Directory.Build.props just subset logic in /Directory.Build.targets
* nit: Remove useless `$(IsProjectReferenceProvider)` settings
  - only implementation projects are providers by default
* nit: Remove useless `$(IsTestAssetProject)` settings
  - set in src/Mvc/test/WebSites/Directory.Build.props
* !fixup! Looks like `InProcessNewShimWebSite` must compile w/o ref/ assemblies
  - restore `$(CompileUsingReferenceAssemblies)` in this one project
2020-06-17 13:04:45 -07:00
N. Taylor Mullen 538c462c05 Enable Helix tests for Microsoft.AspNetCore.Mvc.Razor.Extensions.* projects.
- Enabled Helix for:
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Test`
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.Test`
    - `Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X.Test`
- These tests depended on our MVC shim project's deps.json's to exist in the test bin directory during publish. Therefore added an additional target copy over those assets at publish time.
- There were some tests that were relying on source positions from a string to match a runtime generated source position. In Helix dll's are built on Windows (string's get compiled with \r\n) and then deployed to potentially non-Windows boxes resulting in mismatches of expectations. To address this I changed the test that had this dependency to dynamically generate the input string.
- Our common language test project used to rely on test files being on disk. At some point in the past those test files started being embedded in the assembly but we maintained directory checking logic to ensure various directories existed on disk (no longe required). Changed the logic to not enforce directories to be on disk (they aren't in Helix) and instead only rely on the embedded TestFiles.

dotnet/aspnetcore#22100
2020-06-17 11:49:49 -07:00
Safia Abdalla 952a19682d
Quarantine failing test (#23044) 2020-06-17 18:49:43 +00:00
dotnet-maestro[bot] 632aa8a95c
[master] Update dependencies from dotnet/runtime (#23040)
* Update dependencies from https://github.com/dotnet/runtime build 20200617.2

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Configuration.Xml , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.Security.Principal.Windows , System.Security.Permissions , System.Security.Cryptography.Xml , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Runtime.CompilerServices.Unsafe , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs
 From Version 5.0.0-preview.7.20315.3 -> To Version 5.0.0-preview.7.20317.2

* null

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: BrennanConroy <brecon@microsoft.com>
2020-06-17 18:46:34 +00:00
Justin Kotalik b8de65dbac
Update Microsoft.AspNetCore.Shared.Tests.csproj 2020-06-17 11:18:22 -07:00
Justin Kotalik bccaa41ca8
Update Http2Utilities.cs 2020-06-17 11:17:35 -07:00
ZeBobo5 b8d090b983
Fix #23038 (#23039) 2020-06-17 06:50:31 -07:00
David Melendez d1ae0e6e3e
adding community identity providers (#17051)
Adding Azure Table Storage and CosmosDB SQL providers to the list.
2020-06-17 06:23:48 -07:00
Ken Dale 28ed208022
Add SetIsOriginAllowedToAllowWildcardSubdomains_DoesNotAllowRootDomain test (#23001)
This test makes it clear root domains are not included in CORS subdomain wildcards
2020-06-17 06:22:20 -07:00
Dan Friedman f6fee9b4b8
Link to maintained identity provider (#21015) 2020-06-17 06:21:35 -07:00
Artak 2434047663
Quarantined tests which were not running (skipped on Helix) (#23023) 2020-06-17 04:22:17 +00:00
Adam Sitnik 580a6cce0f
BDN workaround for netcoreapp5.0->net5.0 moniker rebranding (#23000) 2020-06-17 13:43:40 +12:00
James Newton-King 29bbf06c77
Turn off gRPC interop test console color logging (#22923) 2020-06-17 12:38:32 +12:00
Pranav K 65e933ec70
Update PhoneNumberTokenProvider.cs (#22766)
* Update PhoneNumberTokenProvider.cs

Add license header.
Hyphenate two-factor authentication in documentation.
Add line breaks before return statements.
Use string interpolation instead of string concatenation.
2020-06-16 17:22:26 -07:00
Safia Abdalla 51f977db2f
Unquarantine tests that have passed for 30+ days (#23011) 2020-06-16 16:23:50 -07:00
Safia Abdalla ac0b0ee063
Quarantine failing E2E circuit test (#23016) 2020-06-16 22:01:40 +00:00
Hao Kung c330c0b37d
Cookie renew ticket if it already exists (#22732) 2020-06-16 14:51:57 -07:00