e7f3941b1b
Revert "Quarantine all ProjectTemplate tests until dotnet new lock issue is resolved."
...
This reverts commit 9a5d3c7640
2020-05-14 09:41:40 -07:00
8fba9b0c90
Use ActivatorUtilities shared source
2020-05-13 22:23:30 -07:00
b67d161e03
[release/5.0-preview5] Update dependencies from dotnet/aspnetcore-tooling ( #21710 )
...
* Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200511.4
- Microsoft.AspNetCore.Mvc.Razor.Extensions: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
- Microsoft.AspNetCore.Razor.Language: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
- Microsoft.CodeAnalysis.Razor: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
- Microsoft.NET.Sdk.Razor: 5.0.0-preview.5.20258.1 -> 5.0.0-preview.5.20261.4
Dependency coherency updates
- Microsoft.Extensions.Caching.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Caching.Memory: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Binder: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.CommandLine: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.EnvironmentVariables: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.FileExtensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Ini: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.UserSecrets: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Xml: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyInjection.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyInjection: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Composite: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Physical: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileSystemGlobbing: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Hosting.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Hosting: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Http: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Abstractions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Configuration: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Console: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Debug: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.EventSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.EventLog: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.TraceSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options.ConfigurationExtensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options.DataAnnotations: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Primitives: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Internal.Transport: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Win32.Registry: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Win32.SystemEvents: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.ComponentModel.Annotations: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Diagnostics.EventLog: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Drawing.Common: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.IO.Pipelines: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Net.Http.WinHttpHandler: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Net.WebSockets.WebSocketProtocol: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Reflection.Metadata: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Runtime.CompilerServices.Unsafe: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Cryptography.Cng: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Cryptography.Pkcs: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Cryptography.Xml: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Permissions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Security.Principal.Windows: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.ServiceProcess.ServiceController: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Text.Encodings.Web: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Text.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Threading.Channels: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- System.Windows.Extensions: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.App.Internal: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.NETCore.Platforms: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20260.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Net.Compilers.Toolset: 3.7.0-1.20254.1 -> 3.7.0-2.20259.1 (parent: Microsoft.AspNetCore.Razor.Language)
* Try BuildPool.Windows.10.Amd64.VS2019.Pre queues
- do not merge into 'master' branch
* Update RuntimeExtensionsReferenceDirectory with new tfm
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Co-authored-by: John Luo <johluo@microsoft.com>
2020-05-14 01:49:47 +00:00
db864981d5
Do not ship SiteExtension in previews ( #21786 )
...
* Do not ship SiteExtension in previews
- We've generally avoided shipping the SiteExtension in preview releases.
* fb
2020-05-13 17:51:42 -07:00
f9b4101852
Merge remote-tracking branch 'origin/release/3.1'
2020-05-13 17:27:44 -07:00
d782a06462
Decrease allocations from using method groups ( dotnet/aspnetcore-tooling#1896 )
...
* Previous optimization didn't help as much as intended.
By specifying a method group as the arguments to method like ReadWhile, an allocation was still occurring. Instead, cache the Func as a member in the class and use it instead of the method group.\n\nCommit migrated from 2e6aa150bc
2020-05-13 16:00:34 -07:00
016e3d6e20
[release/3.1] Move SDL validation to ringed release ( #21153 )
...
* Move SDL validation to ringed release
* Remove unneeded stuff
* Add back variables
* fixup
* Add missing param
2020-05-13 12:35:53 -07:00
b3c6c43789
Remove the need for a global lock when building or publishing a project ( #21753 )
...
* Change template test build and publish to not perform dotnet restore
* Remove locking requirements for build and publish
* Increase timeout for dotnet new operations since it's network bound
2020-05-13 11:40:42 -07:00
de38479e5f
Improve build reliability ( #20760 )
...
* Improve build reliability
- ensure `ResolveCustomReferences` target executes before packages are used
- `ResolveAssemblyReferences` and `ResolveAssemblyReferencesDesignTime` targets run too late
- e.g. failed builds of Microsoft.AspNetCore.WebUtilities or Microsoft.AspNetCore.Hosting when building from root
- add `GetReferenceProjectTargetPathMetadata` for ease of use as well as reliability
- avoids extra work to get existing metadata (ref/ projects execute no tasks in this target)
nit: rename `@(ReferenceProjectMetadata)` -> `@(ReferenceProjectTargetPathMetadata)`
* Ensure `GetTargetPathMetadata` target runs with `$(TargetFramework)` set
- ref/ projects all multi-target and otherwise no-op this target
* Revert "Fix various "Type or namespace not found" errors (#20736 )"
- change is no longer needed with other fixes in this PR
This reverts commit 8218d6e0e7
2020-05-13 11:31:09 -07:00
b194b6c90a
Fix use of precedence in endpoint routing DFA ( #20801 ) ( #21200 )
...
* Fix use of precedence in endpoint routing DFA
Fixes : #18677
Fixes : #16579
This is a change to how sorting is use when building endpoint routing's graph of
nodes that is eventually transformed into the route table. There were
bugs in how this was done that made it incompatible in some niche
scenarios both with previous implementations and how we describe the
features in the abstract.
There are a wide array of cases that might have been impacted by this
bug because routing is a pattern language. Generally the bugs will involve a
catch-all, and some something that changes ordering of templates.
Issue #18677 has the simplest repro for this, the following templates
would not behave as expected:
```
a/{*b}
{a}/{b}
```
One would expect any URL Path starting with `/a` to match the first
route, but that's not what happens.
---
The change supports an opt-in via the following AppContext switch:
```
Microsoft.AspNetCore.Routing.UseCorrectCatchAllBehavior
```
Set to true to enable the correct behavior.
---
The root cause of this bug was an issue in how the algorithm used to be
build the DFA was designed. Specifically that it uses a BFS to build the
graph, and it uses an up-front one-time sort of endpoints in order to
drive that BFS.
The building of the graph has the expectation that at each level, we
will process **all** literal segments (`/a`) and then **all** parameter
segments (`/{a}`) and then **all** catch-all segments (`/{*a}`). Routing
defines a concept called *precedence* that defines the *conceptual*
order in while segments types are ordered.
So there are two problems:
- We sort based on criteria other than precedence (#16579 )
- We can't rely on a one-time sort, it needs to be done at each level
(#18677 )
---
The fix is to repeat the sort operation at each level and use precedence
as the only key for sorting (as dictated by the graph building algo).
We do a sort of the matches of each node *after* building the
precedence-based part of the DFA, based on the full sorting criteria, to
maintain compatibility.
* Add test
2020-05-13 11:12:14 -07:00
8ff1cb906d
Set certificate in some Kestrel tests to avoid global machine state ( #21516 ) ( #21542 )
2020-05-13 11:11:02 -07:00
9e2a480925
[release/3.1] Add .version file to shared framework zip ( #21548 )
...
* Add .version file to shared framework zip
* Fix test
2020-05-13 10:59:55 -07:00
f0e8ccf2c8
Merge pull request #21760 from dotnet/wtgodbe/315
...
Update branding to 3.1.5
2020-05-13 10:55:53 -07:00
f87c1fc8c2
Merge pull request #21742 from dotnet-maestro-bot/merge/release/3.1-to-master
...
[automated] Merge branch 'release/3.1' => 'master'
2020-05-13 10:25:28 -07:00
ca52b8faf2
Update baselines
2020-05-13 09:30:19 -07:00
572c6fa4ce
Add retries when initial connection fails ( #21711 )
...
* Add retries when initial connection fails
2020-05-13 07:59:34 -07:00
1abf560f17
Update dependencies from https://github.com/dotnet/efcore build 20200512.5 ( #21774 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
- dotnet-ef: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
- Microsoft.EntityFrameworkCore: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.6.20262.4 -> 5.0.0-preview.6.20262.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-13 09:52:35 +00:00
327b9d2f43
Update dependencies from https://github.com/dotnet/efcore build 20200512.4 ( #21769 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
- dotnet-ef: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
- Microsoft.EntityFrameworkCore: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.6.20262.3 -> 5.0.0-preview.6.20262.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-13 08:15:54 +00:00
d12515f4b4
Merge branch 'master' into merge/release/3.1-to-master
2020-05-13 00:18:56 -07:00
919451b7ca
Update dependencies from https://github.com/dotnet/efcore build 20200512.3 ( #21766 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
- dotnet-ef: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
- Microsoft.EntityFrameworkCore: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.6.20262.2 -> 5.0.0-preview.6.20262.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-13 06:00:37 +00:00
2c7c9ba92f
Update dependencies from https://github.com/dotnet/efcore build 20200512.2 ( #21765 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
- dotnet-ef: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
- Microsoft.EntityFrameworkCore: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.6.20262.1 -> 5.0.0-preview.6.20262.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-13 03:05:28 +00:00
e662bb86e2
Update dependencies from https://github.com/dotnet/efcore build 20200512.1 ( #21763 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
- dotnet-ef: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
- Microsoft.EntityFrameworkCore: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.6.20261.6 -> 5.0.0-preview.6.20262.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-13 01:33:56 +00:00
7c58b8b767
Add .version file to shared framework zip ( #21587 )
...
* Add .version file to shared framework zip
* Fix test
* Test for proper version file depending on env
2020-05-12 17:10:02 -07:00
58bb85a1b0
Update branding to 3.1.5
2020-05-12 16:04:46 -07:00
736e57f402
Remove int feeds from nuget.config
2020-05-12 16:03:04 -07:00
a14119a308
Merge remote-tracking branch 'internal/internal/release/3.1' into wtgodbe/315
2020-05-12 16:02:32 -07:00
9a5d3c7640
Quarantine all ProjectTemplate tests until dotnet new lock issue is resolved.
...
- Investigation pending in https://github.com/dotnet/aspnetcore/issues/21748
2020-05-12 15:31:11 -07:00
b419ec07d6
Quarantine Microsoft.Extensions.SecretManager.Tools.Tests.SecretManagerTests.Clear_Secrets
...
- https://dev.azure.com/dnceng/public/_build/results?buildId=640828&view=ms.vss-test-web.build-test-results-tab&runId=19910360&resultId=108857&paneView=debug
2020-05-12 15:29:41 -07:00
f56c61b812
Capture dump of hanging test process in Helix ( #21659 )
2020-05-12 13:55:09 -07:00
5a0c097ad4
Added some kestrel event counters ( #21649 )
...
* Added some kestrel event counters
- Connection queue length - This is the amount of connections accepted and queued in the thread pool.
- Connection count - The number of connections
- Total connections - The total number of connections ever connected.
- Connection Rate - Connections per second
* Added TLS counters
- Current TLS handshakes
- Total TLS handshakes
- Failed TLS handshakes
- TLS handshake per second
* Added HTTP/2 queue length counter
* Improve the event information
- Add TLS version to handshake events
- Add HTTP version to request queue events
- Renamed HTTP/2 request queue length to http request queue
Contributes to #4769
2020-05-12 11:04:37 -07:00
bf9fbc02a2
Merge pull request #21227 from dotnet/johluo/win-arm64-3.1
...
Build aspnetcore for win-arm64 (#19317 )
2020-05-12 09:04:01 -07:00
dfb126da17
Quarantine flagged tests ( #21723 )
2020-05-12 09:00:20 -07:00
a278ef6304
Update dependencies from https://github.com/dotnet/efcore build 20200511.6 ( #21727 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
- dotnet-ef: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
- Microsoft.EntityFrameworkCore: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.6.20261.4 -> 5.0.0-preview.6.20261.6
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-12 04:45:09 +00:00
f427cfa4b7
Update dependencies from https://github.com/dotnet/efcore build 20200511.4 ( #21721 )
...
- Microsoft.EntityFrameworkCore.Tools: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
- Microsoft.EntityFrameworkCore.SqlServer: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
- dotnet-ef: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
- Microsoft.EntityFrameworkCore: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
- Microsoft.EntityFrameworkCore.Relational: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
- Microsoft.EntityFrameworkCore.Sqlite: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
- Microsoft.EntityFrameworkCore.InMemory: 5.0.0-preview.5.20227.5 -> 5.0.0-preview.6.20261.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2020-05-12 00:26:57 +00:00
e3ffee82a9
Update branding to Preview6
2020-05-11 16:03:49 -07:00
4434cf43ce
Don't throw on dotnet exit codes ( #21639 )
...
Operation can succeed for purposes of the tests, the tests will fail if things aren't setup properly, so we can safely ignore the errors
2020-05-11 15:08:42 -07:00
4b88074e30
Add a simplified version of ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext ( #21633 )
...
ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext is quarantined but since it's not running on Helix there isn't any history available for it. With all the moving
parts in the server test, it's unclear if it's a product vs test setup issue.
Authoring a more simplified test so we can track test history. Note that it's starting off as quarantined because there's no evidence that the product code isn't broken
Fixes https://github.com/dotnet/aspnetcore/issues/19413
2020-05-11 12:54:01 -07:00
016fd1ee9e
Improve CSharpLanguageCharacteristics.MapKeyword performance ( dotnet/aspnetcore-tooling#1879 )
...
* Improve CSharpLanguageCharacteristics.MapKeyword performance
The razor typing perf test profile I'm looking at has 156 ms of CPU cycles spent in this method, mostly in Enum.ToString()
\n\nCommit migrated from e821a4642e
2020-05-11 12:42:39 -07:00
a70de6b67b
Small perf improvement in TokenizerBackedParser.Accept and ReadWhile. ( dotnet/aspnetcore-tooling#1882 )
...
In the razor perf typing test, Accept was showing 27 ms allocating enumerators. Additionally, modified ReadWhile to only allocate if it would return a non-empty collection (and to not use the complexity introduced by using yield enumerators)\n\nCommit migrated from 27a14af36a
2020-05-11 10:28:31 -07:00
485924edd2
Improve Annotation and SpanContext performance. ( dotnet/aspnetcore-tooling#1881 )
...
The razor perf test shows about 70 ms CPU of WithSpanContext is in allocation. GetAnnotation similarly is showing about 60 ms in allocation (of which this only partly improves)\n\nCommit migrated from a060f129ff
2020-05-11 10:27:40 -07:00
d1e7d8e466
Improve HtmlTokenizer.AtToken performance. ( dotnet/aspnetcore-tooling#1880 )
...
Our razor typing test measured 153 CPU ms in this method. Optimized by fewer calls to CurrentCharacter, not checking '<' twice, and uswing a switch stmt.\n\nCommit migrated from c601c2f11e
2020-05-11 10:26:56 -07:00
f701a188c2
[master] Update dependencies from dotnet/arcade dotnet/runtime ( dotnet/aspnetcore-tooling#1873 )
...
* Update dependencies from https://github.com/dotnet/runtime build 20200507.11
- Microsoft.Extensions.Logging: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.Extensions.Configuration.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.Platforms: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.App.Internal: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- System.Diagnostics.DiagnosticSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- System.Text.Encodings.Web: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
- System.Reflection.Metadata: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20257.11
* Update dependencies from https://github.com/dotnet/arcade build 20200506.5
- Microsoft.DotNet.Arcade.Sdk: 5.0.0-beta.20228.4 -> 5.0.0-beta.20256.5
* Update SDKs and TFMs
* Try fixing SDK target
* Try removing reference to xunit?
* Try again?
* Revert test tfm
* Remove more xunit references
* Update dependencies from https://github.com/dotnet/runtime build 20200508.3
- Microsoft.Extensions.Logging: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.Extensions.Configuration.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.Platforms: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.App.Internal: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- System.Diagnostics.DiagnosticSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- System.Text.Encodings.Web: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
- System.Reflection.Metadata: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20258.3
* Use `dotnet msbuild` in CI builds
* Update dependencies from https://github.com/dotnet/runtime build 20200509.5
- Microsoft.Extensions.Logging: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.Extensions.Configuration.Json: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.Extensions.DependencyModel: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.App.Runtime.win-x64: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.Platforms: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.App.Internal: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- Microsoft.NETCore.App.Ref: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- System.Diagnostics.DiagnosticSource: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- System.Text.Encodings.Web: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
- System.Reflection.Metadata: 5.0.0-preview.5.20253.7 -> 5.0.0-preview.5.20259.5
* Try undoing `$(EnableFrameworkPathOverride) workaround
* Fix windows builds
* Fix NET.sdk.Razor.Test
* Try fix codecheck
* Skip tests failing with CS1701
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: John Luo <johluo@microsoft.com>
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>\n\nCommit migrated from a60b721dbb
2020-05-11 02:32:33 +00:00
cb83d5d155
Adds instruction for creating JAVA_HOME env variable ( #21371 )
2020-05-10 17:58:22 -07:00
a410ed4601
Use Pinned Object Heap for MemoryPool ( #21614 )
2020-05-09 15:26:35 -07:00
b0d819f1e8
Several changes targeted to improving perf of RazorSyntaxTree.Parse ( dotnet/aspnetcore-tooling#1874 )
...
* Several changes targeted to improving perf of RazorSyntaxTree.Parse
1) Modify ParserHelpers.IsNewLine to use a switch instead of Array.IndexOf
2) Modify Tokenizer.CreateToken to take in an array of RazorDiagnostics rather than an IReadOnlyList as that was causing a ToArray call on an empty diagnostics very often (during a SyntaxFactory.Token call)
3) Modify TokenizerBackedParser.Putback to allow an IReadOnlyList as a parameter to not require creation of a reverse enumerator.
4) Cut down allocations in HtmlMarkupParser.GetParserState by:
a) Using an IReadOnlyList instead of IEnumerable to get rid of the allocations from the .any calls
b) Don't allocate while reading initial spacing
c) Inline the IsSpacingToken code so cut down on code executed and need to allocate a separate Func
5) Modify CSharpCodeParser.IsSpacingToken to now be a set of methods instead of a single method that allocates a Func. This is a very high traffic method.
6) Implement a fairly rudimentary Whitespace token cache, as they can be reused. This was based off Roslyn's SyntaxNodeCache, but simplified significantly. It's probably worth investigating whether you should more fully embrance token caching outside of whitespace.
* PR feedback and added one more optimization in LocateOwner that's been bugging me for years. Assuming all chidlren are contained within a nodes span, we can short-circuit the DFS this code was doing significantly cutting time in this method which is important as it's exercised on the main thread during typing.
* missed a space
* StringTextToSnapshot's switch to IsNewLine needed to use start as the index to begin the search, not zero.\n\nCommit migrated from 45411f7526
2020-05-09 06:06:13 -07:00
b062d1bbc3
[Helix] Reenable win8 helix queue ( #21552 )
2020-05-08 20:34:48 -07:00
c4f6e14f15
Fix build on clean CMD
...
Wthout that fix following error on clean cmd without MBuild on path
```
eng\tools\RepoTasks\RepoTasks.csproj : error : Version 5.0.100-preview.5.20251.2 of the .NET Core SDK requires at least version 16.5.0 of MSBuild. The current available version of MSBuild is 16.3.0.463.05. Change the .NET Core SDK specified in global.json to an older version that requires the MSBuild version currently available.
```
2020-05-08 19:44:23 -07:00
1b6f13d2ed
Add docs on HelixContent property ( #21595 )
...
* Add docs on HelixContent property
* Add content on Link and LinkBase attributes
2020-05-08 17:39:10 -07:00
ed7338c15a
Remove RazorDeveloperTools because they were infrequently used and caused problems.
...
\n\nCommit migrated from c2d717bc98
2020-05-08 16:52:27 -07:00
72bfa8fda7
Merge pull request #21605 from dotnet-maestro-bot/merge/release/5.0-preview4-to-master
...
[automated] Merge branch 'release/5.0-preview4' => 'master'
2020-05-08 16:50:06 -07:00
Justin Kotalik
John Luo
dotnet-maestro[bot]
Brennan
N. Taylor Mullen
Todd Grunke
William Godbe
Pranav K
Doug Bunting
Ryan Nowak
David Fowler
Hao Kung
sanyam142mittal
Ben Adams
Andrii Kurdiumov
Safia Abdalla