Commit Graph

16295 Commits

Author SHA1 Message Date
BrennanConroy 2aa6c01b58
C++11 compliant (#8457) 2019-03-12 22:48:23 -07:00
Justin Kotalik 17d072fa30
Send window updates based on examined rather than consumed. (#8200) 2019-03-12 22:00:47 -07:00
Justin Kotalik 16cd69f164
Disable framework exception on back compat tests (#8460) 2019-03-12 21:59:29 -07:00
Justin Kotalik 899fc117c6
Disable flaky music store test (#8461) 2019-03-12 21:59:13 -07:00
Pavel Krymets afeb139a5c
Consume Microsoft.Internal.Extensions.Refs (#8261) 2019-03-12 12:47:06 -07:00
Andrew Stanton-Nurse 61a9964a15
[BRT] Mitigating flaky SignalR tests (#8423)
* add the ability to skip c++ tests and skip signalr one (mitigates #8421)
2019-03-12 12:33:54 -07:00
Mikael Mengistu 5efa1ba0b9
Fix SignalR transport test (#8424) 2019-03-12 12:22:02 -07:00
David Fowler 107e1862b7
Add HubMetdata (#8425)
- Added HubMetadata to detect the hub type on Endpoints
- Added a test
2019-03-12 11:33:55 -07:00
James Newton-King 21b20afb1d
Add friendly error message for when healthchecks services not registered (#8146) 2019-03-12 11:32:58 -07:00
BrennanConroy e4f5fef7ac
Fix race in LongPolling causing flaky tests (#8114) 2019-03-12 10:24:54 -07:00
Ben Adams a95c4b6fd0 ReadOnlySpan goodness (#8392) 2019-03-11 22:28:20 -07:00
Chris Baudin 77948feeba Update reference assemblies for health checks. 2019-03-11 20:56:08 -07:00
Chris Baudin 484978fe59 Update the health check endpoint route builder extensions to make the endpoint display name configurable. (#8359) 2019-03-11 20:56:08 -07:00
Mikael Mengistu 96764d27eb
Returning rejected promises in HttpConnection (#8315) 2019-03-11 16:33:09 -07:00
Andrew Stanton-Nurse c9c2bf6ea5
even more skipping! (#8286) 2019-03-11 14:50:35 -07:00
Pranav K 0d10c49823
Make IApiBehaviorMetadata public (#8410)
Fixes https://github.com/aspnet/AspNetCore/issues/8403

The analyzer expects the type to be present. However since it's listed
as internal, it is not present when compiling against the ref assembly \ targeting pack.

It was left as internal so we could evolve it later, but we haven't found a need for it as yet.
2019-03-11 14:25:45 -07:00
Pranav K 4a5f2d16bb
Make pubinternal types in Antiforgery internal (#8340)
* Make pubinternal types in Antiforgery internal
Adresses https://github.com/aspnet/AspNetCore/issues/8308
2019-03-11 14:18:17 -07:00
Ryan Brandenburg 8250442159
Add tests for identity UI (#8351) 2019-03-11 11:21:43 -07:00
Javier Calvarro Nelson d7a9606040
[Templating][Components] Unify and improve E2E testing infrastructure (#8188)
* Unify the Templating and Components testing infrastructure.
* Enable test project discovery in the components E2E tests.
* Enable selectively disabling Selenium tests through build properties.
2019-03-11 18:40:18 +01:00
Andrew Stanton-Nurse 8759aa2fc0
SignalR additional xml docs (#7980)
Reviewed our xml docs as both ramping back up after leave and docathon. Things look pretty good, added a few things to some public methods.
2019-03-11 09:29:41 -07:00
Pavel Krymets b2a58ab8de
Skip IIS Express on Windows 7 (#8330)
https://github.com/aspnet/AspNetCore/issues/8329
2019-03-11 08:44:28 -07:00
Eilon Lipton 17344cd37f Improvements to Worker.cs project template item
Fixes #8354
2019-03-10 22:43:54 -07:00
Stephen Halter 1ac6f3d4fd Properly update examined when parsing chunked requests (part 2) (#8360) 2019-03-08 22:24:02 -08:00
sprelog bc009fc0f1 fixing possible NRE, when viewContext is null 2019-03-08 15:02:02 -08:00
Hao Kung f4c80ca99f
EF UserStore FindByEmail will throw on dupes (#8220) 2019-03-08 11:39:26 -08:00
Hao Kung a53accfd75
[Helix] Reenable dotnet-watch on helix (#8258) 2019-03-08 11:32:02 -08:00
John Luo 2cf67cb7c0
Update template icons (#7931) 2019-03-08 10:44:32 -08:00
Andrew Stanton-Nurse 6a73d75688
fix skipped test to actually be skipped (#8238) 2019-03-08 10:24:48 -08:00
BrennanConroy aef62d9ff8 Backport SSR fix (#8174) 2019-03-08 10:00:18 -08:00
David Fowler bd6faa5ca1
Chunked request parsing does not properly update examined (#8318)
- The chunked parsing logic didn't properly update the examined position when parsing the chunked prefix. This started to throw because Pipe now throws if examined is set to the position before the previous.
2019-03-08 09:42:02 -08:00
Chris Ross ce04a1a723
Allow sync IO for NewtonsoftJsonOutputFormatter #8302 (#8303) 2019-03-07 19:11:35 -08:00
Justin Kotalik bae2f2280a
Make StartAsync not throw if we haven't started the response (#8199) 2019-03-07 18:32:19 -08:00
Mikael Mengistu c0c2bb3049
Skip flaky transport test (#8295) 2019-03-07 18:26:38 -08:00
Justin Kotalik c79b2413cc
Swap installer order (#8266) 2019-03-07 15:45:31 -08:00
Ryan Brandenburg e0ce17bc3f
Update IDs for RazorComponents (#8301) 2019-03-07 14:43:44 -08:00
Pranav K 41e6fc8ab0 Use ApplicationPartFactory when adding application parts
Fixes https://github.com/aspnet/AspNetCore/issues/8288
2019-03-07 13:38:31 -08:00
Pranav K 8aa02180fb
Skip tests until we can diagnose failures (#8298) 2019-03-07 13:13:23 -08:00
Doug Bunting 4cbc33da74 Update branding to 2.2.4 2019-03-07 11:53:17 -08:00
Chris Ross 6db129a588
Support conditional compression #6925 (#8239) 2019-03-07 11:09:48 -08:00
Andrew Stanton-Nurse 7fb3d57f54
Skip some more flaky tests (#8194) 2019-03-07 09:40:26 -08:00
Mikael Mengistu b1f828e161
Client to Sever Streaming Java Edition (#8222) 2019-03-07 09:34:28 -08:00
Chris Ross 5170c31b23
Add details to the JwtBearer error messages #4679 (#8259) 2019-03-07 08:15:16 -08:00
Hao Kung 435867e8c5
Add ability to skip tests on specific helix queues (#8231) 2019-03-06 23:53:18 -08:00
Doug Bunting e497f4101f
Update branding to 2.1.10 (#8265) 2019-03-06 19:45:46 -08:00
Doug Bunting 697a1009d2
Merge branch 'release/2.2' => 'master' (#7630)
- barely [automated]
2019-03-06 14:42:33 -08:00
Kevin Ransom (msft) 35ac392fb6 Fix F# template (#7637) 2019-03-06 12:47:28 -08:00
Justin Kotalik 02dbe55466
Fix StartsWithPortableAndBootstraperExe (#8219) 2019-03-06 11:59:42 -08:00
Ryan Brandenburg 706b8345dc Regenerate package-lock.json 2019-03-06 11:55:05 -08:00
Ryan Brandenburg 7573597577 Merge branch 'merge/release/2.2-to-master' of github.com:dotnet-maestro-bot/AspNetCore into merge/release/2.2-to-master 2019-03-06 11:36:41 -08:00
Ryan Nowak a1ec03e1e6 Add fallback routing for controllers and pages 2019-03-06 09:48:07 -08:00
Ryan Nowak bb28db6fb2 Generalize Action Selection logic
Allows us to use the "select action via route values" logic for
endpoints.
2019-03-06 09:48:07 -08:00
Ryan Nowak 8a46e8cd93 Update SpaDefaultPageMiddleware for endpoints
This change makes the SpaDefaultPageMiddleware noop when an endpoint has
been chosen. This is a problem today because this usually runs after
routing, but its always terminal.

So even if endpoint routing selected something, this would still serve
the default file. We're adding more things that fill this niche, but it
seems like a good idea to fix the existing stuff.
2019-03-06 09:48:07 -08:00
Ryan Nowak 089f64c528 Add fallback routing to file
This is a new routing feature that integrates static files to serve a
static file when routing doesn't match anything else.

This is a scenario that's covered by SPA services today, but given the
improvements to routing it makes much more sense to move lower in the
stack.
2019-03-06 09:48:07 -08:00
Ryan Nowak 7e63e2da43 Make StaticFiles Noop for middleware
Teaches all of the static files middleware (incl default files,
directory browser) to noop when an endpoint is selected. This is
desirable so you can place them after routing if you want with no ill
effect.
2019-03-06 09:48:07 -08:00
Ryan Nowak f150e89125 Add file/non-file and generic fallback
Adds new constraints for checking if a route value is a file or not.

Added a new set of builder methods that specify what it means to be a
'fallback'. This is really similar to what the older SPA fallback routes
do, but this is lower in the stack and directly integrated with
endpoints.
2019-03-06 09:48:07 -08:00
David Fowler 4c79e7fdc0
Rename Pipe properties (#8227)
* Rename Pipe properties
- Rename BodyPipe to BodyReader and BodyWriter on the request and response directly
2019-03-06 07:33:24 -08:00
Mikael Mengistu 563a488f3b Add baseline test (#7988)
- mostly matching what's in `release/2.2`
2019-03-05 15:50:25 -08:00
Andrew Stanton-Nurse 303a354993
skip another flaky kestrel test in helix (#8216)
related #8215
2019-03-05 15:09:56 -08:00
Jeremy Lawrence a1f544b62f Correct doc comment for ApiConventionTypeMatchBehavior (#7861) 2019-03-05 14:43:59 -08:00
Pranav K b90220ad05
Improve NullHtmlEncoder perf (#7987)
Fixes #7987
2019-03-05 14:41:55 -08:00
shnja 4c3996f824 Use Request.Scheme instead of Protocol (#7911) 2019-03-05 14:39:37 -08:00
Hao Kung 4e271ac124
Send email confirmation after register via external login (#8013) 2019-03-05 13:53:15 -08:00
Chris Ross def25cb3de
Document the change policy for FileExtensionContentTypeProvider #2454 (#8213) 2019-03-05 13:50:48 -08:00
BrennanConroy 58ad7b7550
Fix build flakiness (#8211) 2019-03-05 12:59:21 -08:00
Pranav K b41959ac32 Add additional logging to TempDataInCookiesTest to diagnose test failure
Diagnosis for https://github.com/aspnet/AspNetCore-Internal/issues/1803
2019-03-05 12:33:49 -08:00
Pranav K 44c66c8314 Revert "Skipping flaky test"
This reverts commit 680c069554fd2a184b8a3030711aed35d4293c4b.
2019-03-05 12:33:49 -08:00
Ryan Brandenburg 0add673139
Include more template baselines (#4186)
Include more template baselines
2019-03-05 12:02:34 -08:00
Mikael Mengistu 9b4f8d79fd
Fix Java Client transport select (#8143) 2019-03-05 11:31:56 -08:00
Pavel Krymets 2665f6d238
Isolate message compiler output files (#8197) 2019-03-05 11:27:09 -08:00
Ryan Brandenburg 414d8a514f
Add missing doc comments (#8035) 2019-03-05 10:01:20 -08:00
David Fowler d1ee93b94b
Allow disabling automatic MVC reference (#8167) 2019-03-05 09:19:28 -08:00
Andrew Stanton-Nurse 98a49e332f
skip flaky SignalR test: ErrorDuringPollWillCloseConnection (#8171)
see #8138 for discussion on test priority and re-enabling
2019-03-05 08:30:40 -08:00
Andrew Stanton-Nurse e0dbc21ccc
skip flaky Kestrel ValidationFailureRejectsConnection test on Helix (#8170)
See #8168 for details on the failure and discussions on priority of unskipping.
2019-03-05 08:23:58 -08:00
BrennanConroy c8c12cda9b
Fix test discovery (#8201) 2019-03-04 23:11:16 -08:00
Pranav K 33839dc66a
Client reconnects when state's available on the server (#7395)
Reconnect if we have state on the server

Fixes #7537
2019-03-04 17:27:51 -08:00
Justin Kotalik d09c6e8576
Disable ConfigurationChange Test (#8113) 2019-03-04 16:58:28 -08:00
Ben Adams 19b52bdc8b Elide bounds check for MethodToString (#7887) 2019-03-04 16:44:21 -08:00
Chris Ross b9fda976c0
Update Worker template for Worker SDK (#7965)
* Update Worker template for Worker SDK

* Change template order

* Remove servergc
2019-03-04 16:17:25 -08:00
Pranav K 39e52578d3
Make page load async when using endpoint routing (#7938)
* Make page load async

Fixes #8016
2019-03-04 14:45:59 -08:00
Hao Kung 48a67cfd18
Fix for external logins disappearing after failed login (#7002)
Also adds external logins to register page
2019-03-04 12:46:18 -08:00
BrennanConroy 508256d028
Always load NodeHttpClient to fix SSR (#8047) 2019-03-04 09:16:52 -08:00
Steve Sanderson 7111c8ffd7 Handle async exceptions when not rendering root component. Fixes #8151 2019-03-04 16:44:42 +00:00
Andrew Stanton-Nurse 7b24304739
skip flaky SecureDataFormatTest in Helix (#8129)
related #7366
2019-03-04 07:50:53 -08:00
Nikita Potapenko 83cb05d83c Rename DataProtectorTokenProvider (#8027) 2019-03-04 02:03:31 -08:00
David Fowler 9cb1185a5c
Add option to restrict the maximum hub message size (#8135)
- This change moves the limit checking from the transport layer to the protocol parsing layer. One nice side effect is that it gives us better control over error handling.
2019-03-03 15:18:32 -08:00
BrennanConroy 67d339ee3b
C++ client: string_t to string (#8063) 2019-03-02 22:11:18 -08:00
Ben Adams ddce32a791 Use C#8 (#8128) 2019-03-02 19:48:43 -08:00
Andrew Stanton-Nurse 4aad7548c1
skip Libuv.FunctionalTests RemoteIPv6Address on Helix (#8111) 2019-03-01 18:37:51 -08:00
Andrew Stanton-Nurse 6e8a9f6d6a
Skip flaky clientcert test in Kestrel (#8112)
related #7265

flaked out in https://github.com/aspnet/AspNetCore/pull/7987
2019-03-01 18:37:23 -08:00
Pranav K db3795b368
Put MVC's functional tests in a separate test group (#8118)
Possible fix to https://github.com/aspnet/AspNetCore/issues/7313
One of the characteristics of these failures were that the
test took long to run. The build log has warnings for
several long running tests. This might be a result of CPU
contention since mondo-ification that make MVC's functional tests
run with nearly every other test project in the solution
2019-03-01 17:52:50 -08:00
Chris Ross 93b195e566
Change SameSite default to None #2675 #4661 (#8043) 2019-03-01 16:22:12 -08:00
Ryan Brandenburg 4a5720beba Updated PR with my changes 2019-03-01 15:25:58 -08:00
Chris Ross 1830f4f0dd
Avoid race in FileWatcher test Internal/1710 (#8095) 2019-03-01 15:03:21 -08:00
Justin Kotalik fc9e48877c
Add FormPipeReader (#7964) 2019-03-01 14:41:05 -08:00
Andrew Stanton-Nurse 22e706cdc3 pr feedback 2019-03-01 13:55:45 -08:00
Andrew Stanton-Nurse 8c2c458891 some little xml doc changes 2019-03-01 13:55:45 -08:00
Andrew Stanton-Nurse 9a61275fa6
skipping ReactRedux test due to flakiness (#8100)
related #7377
2019-03-01 13:54:57 -08:00
Pranav K 85c051d8da
Skipping flaky test (#8101) 2019-03-01 13:37:19 -08:00
Damian Edwards bec911d8b4
Merge pull request #7993 from zbecknell/patch-1
Update Blazor NDC video link
2019-03-01 12:26:14 -08:00
Andrew Stanton-Nurse 8cd36953ef
skip flaky HttpSys test in helix (#8092)
Related to #8091
2019-03-01 12:20:59 -08:00