Pranav K
0a2b6205c9
Reacting to Routing changes
2016-01-05 12:05:20 -08:00
Ryan Nowak
4141fcae69
Optimize MvcRouteHandler
...
- Check MVC services once at startup
- Make action selector sync
We've never really had a scenario for the action selector being async, it
just ended up that way. None of our extensibility here lets you do
anything async without replacing it wholesale, which we don't
recommend.
2016-01-05 11:31:43 -08:00
Ajay Bhargav Baaskaran
47a3aee2c1
[ Fixes #3361 ] Changed the value provider preference to be backwards compatible
2016-01-04 12:55:35 -08:00
Ajay Bhargav Baaskaran
1f87442092
[ Fixes #3749 ] Expose ActionContext on IUrlHelper
2016-01-04 10:33:42 -08:00
Doug Bunting
568b061441
Mock `HttpContext`, not `DefaultHttpContext`
...
- build break
- recent HttpAbstractions changes made `DefaultHttpContext` harder to mock (would need `CallBase=true`)
2016-01-03 14:25:42 -08:00
Pranav K
7d5a68b9ae
Reacting to IHtmlContentBuilder changes
2015-12-31 11:52:26 -08:00
Ryan Nowak
51564d04c0
Remove a test that tests Dictionary
...
This test is coupled to Dictionary<>'s error message. We don't need this.
2015-12-30 16:55:51 -08:00
Kiran Challa
7a955bcbc0
FormatFilter overrides content type set explicitly by the developer
2015-12-30 13:20:56 -08:00
Pranav K
aab051a20f
Rename DictionaryBasedValueProvider to RouteValueProvider
...
Fixes #3629
2015-12-29 18:51:47 -08:00
Pranav K
2b9dd76535
Make RazorViewEngineOptions.FileProvider a list instead of a single item
...
Fixes #3806
2015-12-29 14:47:15 -08:00
Ryan Nowak
d222900662
Optimize allocations in argument binder
...
This change avoids a state machine allocation and a dictionary allocation
on the common case (no bound properties). Ugly? You bet. Worth it? Yeah,
seems worthwhile.
This is worth about 200 bytes/request - about 3% of allocated bytes in a
smallish API scenario.
2015-12-29 09:26:59 -08:00
Ryan Nowak
0a9804056e
Use System.Buffers for JSON.NET
2015-12-29 08:26:55 -08:00
Ryan Nowak
85a4c7edc5
React to changes in routing
2015-12-28 10:15:50 -08:00
Pranav K
43226fe54d
Modify FileVersionProvider to cache missing file info.
...
Fixes #3765
2015-12-23 14:32:39 -08:00
John Luo
b7d95d813d
Reacting to middleware configureOptions updates
2015-12-23 12:27:57 -08:00
Pranav K
399e516065
Modify IViewComponentHelper to remove method selection ambiguity.
...
Fixes #612
2015-12-23 10:02:51 -08:00
damianedwards
ce0e35ff75
Make ViewLocalizer base name generation more efficient:
...
- Because @pranavkm made me do it
- And it is actually faster and less allocating than the old code (~25% faster)
- Added some more test cases
2015-12-21 16:25:35 -08:00
Hao Kung
9364f896b3
Options renames for functionals
2015-12-21 16:18:22 -08:00
Hao Kung
0e8113e393
OptionsModel => Options rename
2015-12-21 15:00:31 -08:00
damianedwards
1529c868f2
Improve ViewLocalizer resource look-up semantics:
...
- Always prepend with application name and let underlying `IStringLocalizerFactory` do the name gymnastics
- Use ExecutingFilePath instead of view name
- Trim off the file extension (so your resource doesn't have to have ".cshtml" in its name)
- Improved doc comments
- Added tests to cover ViewLocalizer behavior
- #3718
- #2767
2015-12-21 14:22:32 -08:00
Kiran Challa
d77655fb73
MVC Controller Response - Wrong ContentType #3245
2015-12-21 11:25:45 -08:00
Pranav K
f56cf97805
Simplifying MvcTestFixture
2015-12-19 21:57:51 -08:00
N. Taylor Mullen
00722ce91a
Remove `FilesWebSite` webroot.
2015-12-18 16:04:22 -08:00
Pranav K
7dac5c711b
Reacting to Hosting changes
2015-12-18 15:59:42 -08:00
N. Taylor Mullen
aa7ebb343a
Update half of the test websites to use new Hosting API conventions.
...
https://github.com/aspnet/KestrelHttpServer/pull/496
2015-12-18 15:35:13 -08:00
Ryan Nowak
8fb187bf09
Use system.buffers for our reader/writer
2015-12-18 09:27:36 -08:00
Pranav K
5f66403248
Remove TextWriter.ToString from RazorPage
...
Fixes #3668
2015-12-18 09:12:28 -08:00
Pranav K
c5b6efd6bf
Move buffer types to ViewFeatures
...
Use buffer pooling in more places
2015-12-17 21:05:18 -08:00
damianedwards
0c3e7b5a75
Improve usability of IHtmlLocalizer & associated API:
...
- IHtmlLocalizer no longer derives from IStringLocalizer
- IHtmlLocalizer indexer now returns LocalizedHtmlString
- IHtmlLocalizer has GetString methods now that act the same as IStringLocalizer.GetString
- Made LocalizedHtmlString a struct to match LocalizedString
- Updated samples in response to aspnet/Localization#167
- Rename "ancestor" to "parent" for loc API
- Fixes some doc comments
- Fixed tests
- #3716
2015-12-17 16:35:19 -08:00
Pranav K
a036ff4738
Reacting to DI changes
2015-12-17 12:03:29 -08:00
ryanbrandenburg
70f9431e7f
* Fix test failure
2015-12-16 17:21:25 -08:00
ryanbrandenburg
6a16681ed4
* Replace MvcMinimalSample with functional test
2015-12-16 15:18:25 -08:00
Ajay Bhargav Baaskaran
43eb621d19
[ Fixes #2743 ] Removed ErrorReporterMiddleware in some places
2015-12-16 14:39:35 -08:00
Doug Bunting
3d8225502f
Change `HtmlString` to inherit from `HtmlEncodedString`
...
- part of aspnet/HtmlAbstractions#5 fix
- also extend existing special cases to more general `HtmlEncodedString`
2015-12-16 12:42:13 -08:00
Ajay Bhargav Baaskaran
232b27ad5d
[ Fixes #3430 ] Removed RouteKeyHandling.CatchAll
2015-12-16 11:57:22 -08:00
Pranav K
7c40759e32
Reacting to Routing changes
2015-12-16 11:49:20 -08:00
javiercn
c61cc65db3
[ Fixes #3705 ] Bring back render partial
2015-12-15 12:20:06 -08:00
Ajay Bhargav Baaskaran
bbba9dcde6
[ Fixes #3524 ] Handle negative long values in TempData correctly
2015-12-15 00:17:37 -08:00
Doug Bunting
900663bfdd
Make `project.json` formatting consistent
2015-12-14 21:51:04 -08:00
Doug Bunting
59824dc7be
MVC functional test cleanup (part 1)
...
- #3612 subpart 2 of 2
- merge `ActionConstraintsWebSite`, `AntiforgeryTokenWebSite` and `ContentNegotiationWebSite` into `BasicWebSite`
- remove tests depending on `ErrorReporterMiddleware` in merged sites; not used in `BasicWebSite`
- delete `CompositeViewEngineWebSite`, `Microsoft.AspNet.Mvc.ViewEngines.CompositeViewEngineTest` covers cases
- delete `CorsMiddlewareWebsite`, soon to be in Cors repo (see aspnet/CORS#57 )
- remove `SendFileMiddleware` from FilesWebSite, unused there
2015-12-14 21:50:55 -08:00
Doug Bunting
1b7e67211f
Do not override default `Layout` value
...
- #3745
2015-12-14 19:09:57 -08:00
N. Taylor Mullen
29ea696c5a
Add `Model` assessor to `ViewResult` for MVC5 portability.
...
#3495
2015-12-14 16:16:41 -08:00
Ryan Nowak
1126d47b3e
React to breaking changes in RouteBuilder
2015-12-14 14:40:38 -08:00
Ryan Nowak
a2393f21be
Adds ControllerBase to Mvc.Core
...
This change adds a base class for controllers to Mvc.Core that can be used
without a dependency on views, json, etc.
Most of the functionality on Controller moves to ControllerBase. I kept
the IActionFilter and IDisposable functionality on Controller since it's
not really a fit with the 'minimal' philosophy.
2015-12-14 10:29:55 -08:00
Ryan Nowak
ad3c460500
React to breaking in IRouteConstraint
2015-12-14 10:08:09 -08:00
Ryan Nowak
ee6ef3f25f
Last part of #3676
...
Uses the correct IEnumerable<> in validation strategies
2015-12-14 08:52:44 -08:00
Doug Bunting
8a310b35a4
Update to latest `UseRequestLocalization()` signature
...
- build break
nit: add more trailing commas in init syntax
2015-12-11 22:58:13 -08:00
Pranav K
56c6975a21
Tweak CacheTagHelper sample to use a token provider service for
...
cache expiration.
Fixes #3573
2015-12-11 15:23:34 -08:00
Doug Bunting
19e6fb5719
MVC functional test cleanup part 1
...
- #3612 (subpart 1 of 2)
- delete six sites and associated tests entirely
- `ActionResultsWebSite`
- `ActivatorWebSite`
- `ControllerDiscoveryConventionsWebSite`
- `LoggingWebSite`
- `LowercaseUrlsWebSite`
- `ModelBindingWebSite`, now covered in integration tests
- remove now-unused `FilteredDefaultAssemblyProviderFixture`, `LoggingAssert` and `LoggingExtensions`
- move six test web sites into `./samples`
- `CustomRouteWebSite` -> `CustomRouteSample.Web`
- `FormatFilterWebSite` -> `FormatFilterSample.Web`
- `InlineConstraintsWebSite` -> `InlineConstraintSample.Web` (now singular)
- `JsonPatchWebSite` -> `JsonPatchSample.Web`
- `LocalizationWebSite` -> `LocalizationSample.Web`
- `RazorEmbeddedViewsWebSite` -> `EmbeddedViewSample.Web` (no longer "Razor" and now singular)
- do some cleanup: remove test dependencies, shorten sample controller names, use more attribute routing
- correct "license" spelling in `ApplicationModelWebSite`
2015-12-11 13:13:41 -08:00
ryanbrandenburg
3393ba43c2
* Parameters into the messages
2015-12-11 12:05:44 -08:00