Commit Graph

17063 Commits

Author SHA1 Message Date
Brennan 0648edf7c2 Temporarily skip SignalR TS client tests (#11398) 2019-06-19 15:40:37 -07:00
Pranav K a093059fce
Use the right data type for mouse event args (#11332)
* Use the right data type for mouse event args

Fixes https://github.com/aspnet/AspNetCore/issues/11224
2019-06-19 13:56:50 -07:00
Stephen Halter 5f2760e9bc
The TaskCompletionSource ctor takes Task*Creation*Options (#11294) 2019-06-19 11:44:43 -07:00
Javier Calvarro Nelson 2287abcc3e
Move SPA flows to use code (#11227)
* Move SPA flows to use code
2019-06-19 19:57:01 +02:00
Chris Ross 2df72072ad
Update facebook APIs to v3.3 #4684 (#11238)
Update Google error message
2019-06-19 10:16:20 -07:00
Nate McMaster 4fde84a7ad Replace KoreBuild with Arcade (#11122)
* Replace usages of $(CI) with $(ContinuousIntegrationBuild)

* Move RepoTasks to eng/tools/

* Remove dead code

* Update build.sh/ps1 to invoke Arcade instead of KoreBuild

* build/repo.props => eng/Build.props

* build/CodeSign.{props,targets} => eng/Signing.props

* build/repo.targets => eng/Build.props, eng/CodeGen.proj, and eng/AfterSolutionBuild.targets

* Remove AddAllProjectRefsToSolution.ps1

* Put selenium process tracking into artifacts/tmp/

* build/docker => eng/docker

* Move content from korebuild.json to global.json

* Remove cibuild.{sh,cmd} and update ci.yml

* Ensure vswhere detects BuildTools installations

* Remove sign check exclusions (Arcade does not support)

* list VS required components in global.json

* Update CodeCheck.ps1

* Update arcade (#11143)

* Fixups to broken build

* capture test results in xunit form
* attempt to fix code check
* restore before linux build
* remove duplicate signinfos

* More build fixes

* exclude node_modules from unique project check
* fixup signing props

* More build fixes

* Remove unused NoWarns
* Skip building site extension
* Suppress xunit color in console output
* Install x86 runtime

* Run KillProcesses.ps1 at end of build on CI

* activate env vars in codecheck.ps1

* Fix signing and generate build manifests

* Fixup code check and linux installers build

* Remove custom restore targets

* Import flaky test props

* Restore original manifest generation code and set warnAsErrors=false

* Alwasy restore the toolset

* More attempts at build fixes

* run restore before building deb/rpm packages
* pre-install Yarn.MSBuild
* Remove WIX workaround

* Attempt to fix RPM installers and x86 build

* Fix helix tests, java auto-detection, and code gen steps

* Globally disable MSBuild node resuse and capture MSbuild crash logs

* Cleanup build invocation for installers

* Set max time on xunit tests to 15 min

* Update helix-test.yml

* Fix Hosting tests

* Fix TestHost

* Fix Negotiate.Test

* Fix Mvc tests

* Capture results

* Fix Hosting tests

* Fix Kestrel tests

* Fix ServerComparison tests

* Fix DefaultBuilder functional tests

* Skip template tests

Need to run pack before running tests on mac/linux now

* Fix Identity test

* Fix ServerComparison tests

* Verify nginx installation on ubuntu

* Verify nginx installation?

* Try adding to path

* Try symlink

* Sudo?

* Woot it works

* Disable timeout

Template tests require more than 15 mins

* list env vars

* Use correct dotnet_home

* Prepent path instead

* Fix npmproj tests

* Fix CORS tests

* Debug signalr tests

* Debug signalr

* Capture bin

* Try building templates sequentially

* Debug signalr

* Cleanup

* Disable signalr npm tests

* Debug template test

* Try to fix templates again and make steps more reliable

* Cleanup

* Feedback
2019-06-19 10:03:38 -07:00
Arthur Vickers 730c3e0053 Update DatabaseErrorPageMiddleware to use HasTables 2019-06-19 09:58:39 -07:00
David Fowler 9ea20ddef3
Increase timeout to 30 seconds (#11358) 2019-06-19 17:43:33 +02:00
Javier Calvarro Nelson 75c95c56bf
Complete and make ignitor more extensible (#11289)
* Add support for sending dotnet calls from "JS"
* Add support for acknowledging render batches.
* Extract logic into a separate BlazorClient class so that it can be reused.
* Support non prerendered pages.
* Allow reacting to incoming JSInterop calls.
* Allow reacting to incoming RenderBatch.
2019-06-19 10:45:49 +02:00
Hao Kung b56108fc94
Make incorrect password error message consistent (#9556) (#11346) 2019-06-18 23:33:06 -07:00
Hao Kung ee0c9dcf35
Get rid of Authentication.Internal (#11341) 2019-06-18 23:31:41 -07:00
Hao Kung 51919cb631
Improve error message when no auth scheme specified (#11348) 2019-06-18 23:30:47 -07:00
Justin Kotalik a4bd1308ca Skip CORS tests (#11355) 2019-06-18 16:05:38 -07:00
Arthur Vickers 839cf89252 Update MusicStore and Identity to remove workarounds
Fixes #10714
Fixes #10668
2019-06-18 15:09:38 -07:00
Javier Calvarro Nelson f56c4c1c33
Fix yarn audit issues by lifting dependency versions (#11318) 2019-06-18 22:24:52 +02:00
Hao Kung 2191f073d7
Turn on new confirmation flow in templates (#9003) 2019-06-18 13:20:09 -07:00
Kahbazi bff78bdd11 Remove use of null-conditional operator for logger (#6579) 2019-06-18 11:18:43 -07:00
Chris Ross 9077b38805
Implement IHttpResetFeature in Kestrel #10886 (#11300) 2019-06-18 11:14:40 -07:00
Brennan 8984144db4
Update dev deps for SignalR (#11330) 2019-06-18 10:58:53 -07:00
Mikael Mengistu 04c3192d3c
Clean up Pubternal Types in SignalR (#11162) 2019-06-18 10:32:38 -07:00
Justin Kotalik 213f6efd30 Make CORS functional tests select different ports (#11063)
* fxup some slns
- remove samples
2019-06-18 10:00:16 -07:00
Balint Farkas 793559af98 Corrected spelling of "canceled". Put .OrTimeout() on every await call. 2019-06-18 09:40:40 -07:00
Balint Farkas 9bb59b2ec6 Added CanCancelStartingConnectionAfterNegotiate (#10432) 2019-06-18 09:40:40 -07:00
Justin Kotalik c288baf967 mark test as flaky (#11306) 2019-06-17 19:52:46 -07:00
Justin Kotalik cbafafa188 Reduce logging branch path size. (#11297)
* Working on debugging issues with logging site extension
* rename logging branch

- aspnet/AspNetCore-Internal/#2665
2019-06-17 16:51:40 -07:00
David Fowler f7a2d3c26c
Hoist activity fields to the logging scope (#11211)
- Expose SpanId, TraceId and ParentId to logging scope properties
- Added tests to verify the Hierarchical ID format
- Store the activity and lazily compute the various properties
2019-06-18 00:17:17 +02:00
Mikael Mengistu 4235dd2999
Allow sending null params in Java client (#11272) 2019-06-17 14:32:02 -07:00
Javier Calvarro Nelson 9c4faf86e5
Update oidc dependency on the react and angular templates
Updates oidc-client to the latest 1.8 version.
2019-06-17 23:20:14 +02:00
Pranav K 8fd85ec8ce
Ensure CircuitRegistry evicts CircuitHost entries after configured (#11157)
* Ensure CircuitRegistry evicts CircuitHost entries after configured
duration

* Use an active expiration token to trigger expiration
* Add logging during host state transitions

Fixes https://github.com/aspnet/AspNetCore/issues/9893
2019-06-17 13:15:15 -07:00
Brennan 9136d27127
[TS] Remove extra negotiates from common scenarios (#11191) 2019-06-17 13:09:00 -07:00
Martin Costello cc96e988f4 More read interface IList.Count once rather than per iteration + miscellany (#11253)
* Read interface IList.Count once rather than per iteration

Inspired by #9962, read .Count once rather than once per loop iteration.

* Use nameof() instead of ToString()

Use constant nameof() on enum value, rather than runtime ToString().

* Right-size dictionary

Initialize dictionary with a fixed number of elements to the number of elements it contains.

* Use DisposeAsync()

Use DisposeAsync() on FileBufferingReadStream in input formatters.

* Override DisposeAsync()

Override DisposeAsync() to call DisposeAsync() on the inner stream.

* Use GetValueOrDefault() for content-length

Use GetValueOrDefault() to read the content length once instead of checking HasValue once and Value up to three times.

* Update Microsoft.AspNetCore.WebUtilities.netcoreapp3.0.cs

Add DisposeAsync().

* Use DisposeAsync()

Use DisposeAsync() on transcoding streams as other formatters do.
2019-06-17 11:22:45 -07:00
Doug Bunting 4f67ff9216 Deploy Microsoft.Web.Xdt.Extensions.pdb
- #10495
- add a general mechanism to publish "loose" PDBs

also, correct a typo from af2f647d635d: always publish the log artifacts
2019-06-17 11:13:12 -07:00
Martin Costello 87ea03daf1 Register SystemTextJsonResultExecutor (#11247)
Register SystemTextJsonResultExecutor as part of MVC core services so that JsonResult works without Newtonsoft.Json.
Addresses #11246.
2019-06-17 09:33:45 -07:00
Pranav K 730db07d29
Allow PostAsJsonAsync to accept Json with any case (#11254) 2019-06-17 09:00:59 -07:00
Pranav K 17c7ea95a2
Add API to configure CircuitOptions (#11166)
* Add API to configure CircuitOptions
2019-06-17 09:00:45 -07:00
David Fowler b47b3e5ac6
Wait for server connection to end (#11256) 2019-06-17 17:42:16 +02:00
David Fowler ab52a1d3ed
Kestrel API clean up based on review (#11257)
- Make most of the sockets transport internal.
- Remove EndPoint from ListenOptions
2019-06-17 08:10:42 +02:00
dotnet-maestro[bot] 169b7db307 [master] Update dependencies from 2 repositories (#11201)
* Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190613.2
- Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview7.19313.2
- Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview7.19313.2
- dotnet-ef - 3.0.0-preview7.19313.2
- Microsoft.EntityFrameworkCore - 3.0.0-preview7.19313.2
- Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview7.19313.2
- Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview7.19313.2
- Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview7.19313.2

Dependency coherency updates
- Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.Memory - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- …
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19312.3 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview7-27812-08 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 3.0.0-preview7.19312.4 (parent: Microsoft.EntityFrameworkCore)
- Microsoft.CSharp - 4.6.0-preview7.19312.3 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview7-27812-08 (parent: Microsoft.Extensions.Logging)
- …

* Ignore nullable check

* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190615.2
- Microsoft.NET.Sdk.Razor - 3.0.0-preview7.19315.2
- Microsoft.CodeAnalysis.Razor - 3.0.0-preview7.19315.2
- Microsoft.AspNetCore.Razor.Language - 3.0.0-preview7.19315.2
- Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview7.19315.2
2019-06-16 21:28:14 -07:00
dannyBies 1521e6fa72 Update StartupAnalyzer.Diagnostics.cs (#11245) 2019-06-15 19:01:52 -07:00
Chris Ross bc5bee7477
Implement Http/2 CompleteAsync #10886 (#11193) 2019-06-15 09:01:45 -07:00
Brennan 5872814a64
Allow null arguments from HubConnection (#11241) 2019-06-14 20:37:13 -07:00
Javier Calvarro Nelson f652c22202
[Fixes #11183] Race condition in RouteBase.EnsureLoggers (#11218)
[Fixes #11183] Race condition in RouteBase.EnsureLoggers
2019-06-15 00:54:14 +02:00
Andrew Stanton-Nurse a79bb2a79d
fix #11114 by setting DesignerCategory for WebHostService (#11123) 2019-06-14 13:48:20 -07:00
Pranav K cd7eda9a33
Use a valid canceled task (#11161) 2019-06-14 13:13:53 -07:00
Nate McMaster 87106707d6
Always produce a .zip and .tar.gz for the targeting pack (#11230) 2019-06-14 11:50:34 -07:00
David Fowler 9466ec702f
Move TransportConnection to shared source (#11215)
- Remove it from Connection.Abstractions and make it shared source.
2019-06-14 11:48:41 -07:00
Stephen Halter e727101957
Work around potential race in PipeWriter Redux (#11065)
- Make sure we always await the last flush task before calling FlushAsync
  again instead of preemptively calling FlushAsync and checking to see
  if the ValueTask is incomplete before bothering to acquire the _flushLock
- This now acquires the _flushLock fore every call to Response.Body.Write
  whereas this only happened for truly async writes before.
- I don't think this is a big concern since this should normally be uncontested,
  and DefaultPipeWriter.FlushAsync/GetResult already acquire a lock.
2019-06-13 20:03:29 -07:00
Brennan 902369610a Convert SignalR EventSource usage to new pattern (#11130) 2019-06-13 18:40:00 -07:00
Dylan Dmitri Gray c24c4cac01
Dylan/request queue di (#11167)
Decoupled Middleware from QueuePolicy
2019-06-13 16:36:21 -07:00
Chris Ross 82d2b4f4d0
Fail on startup for Http/2 HTTPS on Mac #11061 (#11120)
* Use automatic resx #11054
2019-06-13 15:42:45 -07:00