Jacques Eloff
eb1ce947c5
Fix up property group, preprocessor statement
2019-03-19 11:50:13 -07:00
Jacques Eloff
eb8ca48e77
Remove duplicate inputs
2019-03-19 11:50:12 -07:00
Jacques Eloff
2aabd9f847
Fix inputs for UpgradeCode
2019-03-19 11:50:11 -07:00
Jacques Eloff
f87c75a90d
Fix for #7729 to ensure upgradable bundles
2019-03-19 11:50:11 -07:00
Justin Kotalik
9f724f6ac4
Revert "Publish MusicStore as part of build ( #8578 )" ( #8655 )
...
This reverts commit f3eaa73c1a .
2019-03-19 11:03:48 -07:00
Mikael Mengistu
6038621630
Update acessTokenProvider selecting logic for restarting connection ( #8569 )
2019-03-19 10:55:53 -07:00
Justin Kotalik
26c487b0c0
Use examined rather than consumed for content length of body. ( #8223 )
2019-03-19 08:25:57 -07:00
Pranav K
f3eaa73c1a
Publish MusicStore as part of build ( #8578 )
...
* Publish MusicStore as part of build
* Add a target to publish MusicStore as part of E2E tests
* Publishing for x86 causes unit tests in MusicStore to have weird
reference issues. Removing these since they are very pretty low value.
2019-03-19 07:17:55 -07:00
Doug Bunting
bcead68f0c
React to EntityFrameworkCore and AspNetCore-Tooling breaking changes
...
- avoid `[Obsolete]` EF Core method
- mirror recent `RazorIntegrationTestBase` changes in this repo
2019-03-18 19:36:09 -07:00
Doug Bunting
1d1d664ea1
Merge branch 'release/2.2' into master
...
- no-ops except for
- Update PatchConfig.props (2835f85b6c )
- Add some additional logging to ErrorPageMiddlewareWebSite (#8049 ) (aka 1ca6202e7e )
- Put MVC's functional tests in a separate test group (#8118 ) (aka db3795b368 )
- ignore the build queue (4f2a0edc97 ) change because we're not hitting Linux resource issues in `master` branch
- ignore baseline test changes (5661c41909 and d2a4435ac8 ) because they're not applicable in `master`
2019-03-18 12:36:01 -07:00
Ryan Nowak
f303a55a8e
Add skeleton to use components + prerendering
...
This adds the skeleton needed for components + prerendring development
in the MVC sandbox. We don't currently have a sample app for quick and
dirty testing.
2019-03-18 10:18:04 -07:00
Justin Kotalik
a3c8bd16f7
Make Kestrels Internals truly internal. ( #8517 )
2019-03-18 10:15:39 -07:00
Matheus Marques
5c6e1aa1d9
[Templating] Fix react template typos ( #8592 )
2019-03-18 09:42:56 +01:00
Justin Kotalik
8349109647
Atomic swap the request drained handler when shutting down. ( #8529 )
2019-03-17 10:09:04 -07:00
Alexey Malinin
2eb0692434
Change name of argument in "WebHostExtensions" ( #8411 )
2019-03-16 12:16:27 -04:00
Hao Kung
95ab2fa4af
Split ILookupNormalizer.Normalize into Name/Email methods ( #8412 )
2019-03-15 14:00:40 -07:00
Pavel Krymets
22623b905f
Add dependency from AspNetCore targeting pack to dotnet Core targeting pack ( #8490 )
...
Fixes https://github.com/aspnet/AspNetCore/issues/8284
2019-03-15 11:28:42 -07:00
James Newton-King
47fab927a1
Add friendly error message to UrlHelper for when there is no IRouter ( #8145 )
2019-03-15 10:14:07 -07:00
Mikael Mengistu
694dcae53e
Make ResetSendPing and ResetTimeout private methods ( #8525 )
2019-03-14 22:05:07 -07:00
Mikael Mengistu
cfe0cc38ec
Resolve deadlock with `InvokeAsync` in `On` handler ( #8334 )
...
- Use a channel to unblock the dispatch loop
- Added tests
2019-03-14 22:04:36 -07:00
Pavel Krymets
a673be3b9a
Log all event log entries when assert fails ( #8491 )
2019-03-14 11:59:45 -07:00
Stephen Halter
1338973212
Better handle HttpConnectionContext state transitions ( #8225 )
2019-03-14 11:33:32 -07:00
Pranav K
7557cb916b
Merge remote-tracking branch 'origin/release/2.1' into prkrishn/merge/2.1
2019-03-14 10:04:38 -07:00
Mikael Mengistu
a5e20fdc90
Fix SignalR build from VS ( #8492 )
2019-03-14 10:04:04 -07:00
Ryan Nowak
30d0afca05
Remove DisplayName overload from health checks
...
The builder now provides this directly.
2019-03-13 20:12:53 -07:00
Ryan Nowak
0dc14a61ce
Simplify Map methods
2019-03-13 20:12:53 -07:00
Ryan Nowak
4b4614635f
Change template -> pattern for MVC
2019-03-13 20:12:53 -07:00
Ryan Nowak
e78a6521b9
Make naming of IEndpointRouteBuilderConsistent across usages.
2019-03-13 20:12:53 -07:00
Doug Bunting
0c6591baea
Merge release/2.1 up to commit d2a4435ac8 => release/2.2
...
- remove updates about baseline test (5661c41909 and d2a4435ac8 )
- already done (differently) in release/2.2
- add JDK installation -- missing in these images but not needed in `release/2.1`
- add packages needed to run Chrome
2019-03-13 19:17:05 -07:00
Justin Kotalik
1679ba7844
Fix AppOfflineDroppedWhileSiteStarting_SiteShutsDown_InProcess ( #8419 )
2019-03-13 14:59:41 -07:00
Ryan Nowak
d329cca17d
Change APIs to internal in Diagnostics
...
These types are still used, but we don't want them to be public.
2019-03-13 13:15:06 -07:00
Pranav K
55e9bfe78f
Skip functional tests until https://github.com/aspnet/AspNetCore/issues/8439 is resolved ( #8481 )
...
* Skip functional tests until https://github.com/aspnet/AspNetCore/issues/8439 is resolved
2019-03-13 12:29:22 -07:00
Arthur Vickers
a8fd7f4ec9
Add MemoryCache services where needed
...
Previously the tests were relying on EF adding the services. See https://github.com/aspnet/EntityFrameworkCore/issues/14756 and https://github.com/aspnet/AspNetCore/issues/7728
2019-03-13 11:38:56 -07:00
Justin Kotalik
9791f5e244
Refresh process ( #8459 )
2019-03-13 10:14:07 -07:00
Hao Kung
721efd2d48
Try removing ref to identity in EF stores ( #8357 )
2019-03-13 10:06:57 -07:00
BrennanConroy
2aa6c01b58
C++11 compliant ( #8457 )
2019-03-12 22:48:23 -07:00
Justin Kotalik
17d072fa30
Send window updates based on examined rather than consumed. ( #8200 )
2019-03-12 22:00:47 -07:00
Justin Kotalik
16cd69f164
Disable framework exception on back compat tests ( #8460 )
2019-03-12 21:59:29 -07:00
Justin Kotalik
899fc117c6
Disable flaky music store test ( #8461 )
2019-03-12 21:59:13 -07:00
Pavel Krymets
afeb139a5c
Consume Microsoft.Internal.Extensions.Refs ( #8261 )
2019-03-12 12:47:06 -07:00
Andrew Stanton-Nurse
61a9964a15
[BRT] Mitigating flaky SignalR tests ( #8423 )
...
* add the ability to skip c++ tests and skip signalr one (mitigates #8421 )
2019-03-12 12:33:54 -07:00
Mikael Mengistu
5efa1ba0b9
Fix SignalR transport test ( #8424 )
2019-03-12 12:22:02 -07:00
David Fowler
107e1862b7
Add HubMetdata ( #8425 )
...
- Added HubMetadata to detect the hub type on Endpoints
- Added a test
2019-03-12 11:33:55 -07:00
James Newton-King
21b20afb1d
Add friendly error message for when healthchecks services not registered ( #8146 )
2019-03-12 11:32:58 -07:00
BrennanConroy
e4f5fef7ac
Fix race in LongPolling causing flaky tests ( #8114 )
2019-03-12 10:24:54 -07:00
Ben Adams
a95c4b6fd0
ReadOnlySpan goodness ( #8392 )
2019-03-11 22:28:20 -07:00
Chris Baudin
77948feeba
Update reference assemblies for health checks.
2019-03-11 20:56:08 -07:00
Chris Baudin
484978fe59
Update the health check endpoint route builder extensions to make the endpoint display name configurable. ( #8359 )
2019-03-11 20:56:08 -07:00
Mikael Mengistu
96764d27eb
Returning rejected promises in HttpConnection ( #8315 )
2019-03-11 16:33:09 -07:00
Andrew Stanton-Nurse
c9c2bf6ea5
even more skipping! ( #8286 )
2019-03-11 14:50:35 -07:00
Pranav K
0d10c49823
Make IApiBehaviorMetadata public ( #8410 )
...
Fixes https://github.com/aspnet/AspNetCore/issues/8403
The analyzer expects the type to be present. However since it's listed
as internal, it is not present when compiling against the ref assembly \ targeting pack.
It was left as internal so we could evolve it later, but we haven't found a need for it as yet.
2019-03-11 14:25:45 -07:00
Pranav K
4a5f2d16bb
Make pubinternal types in Antiforgery internal ( #8340 )
...
* Make pubinternal types in Antiforgery internal
Adresses https://github.com/aspnet/AspNetCore/issues/8308
2019-03-11 14:18:17 -07:00
Ryan Brandenburg
8250442159
Add tests for identity UI ( #8351 )
2019-03-11 11:21:43 -07:00
Javier Calvarro Nelson
d7a9606040
[Templating][Components] Unify and improve E2E testing infrastructure ( #8188 )
...
* Unify the Templating and Components testing infrastructure.
* Enable test project discovery in the components E2E tests.
* Enable selectively disabling Selenium tests through build properties.
2019-03-11 18:40:18 +01:00
Andrew Stanton-Nurse
8759aa2fc0
SignalR additional xml docs ( #7980 )
...
Reviewed our xml docs as both ramping back up after leave and docathon. Things look pretty good, added a few things to some public methods.
2019-03-11 09:29:41 -07:00
Pavel Krymets
b2a58ab8de
Skip IIS Express on Windows 7 ( #8330 )
...
https://github.com/aspnet/AspNetCore/issues/8329
2019-03-11 08:44:28 -07:00
Eilon Lipton
17344cd37f
Improvements to Worker.cs project template item
...
Fixes #8354
2019-03-10 22:43:54 -07:00
Stephen Halter
1ac6f3d4fd
Properly update examined when parsing chunked requests (part 2) ( #8360 )
2019-03-08 22:24:02 -08:00
sprelog
bc009fc0f1
fixing possible NRE, when viewContext is null
2019-03-08 15:02:02 -08:00
Hao Kung
f4c80ca99f
EF UserStore FindByEmail will throw on dupes ( #8220 )
2019-03-08 11:39:26 -08:00
Hao Kung
a53accfd75
[Helix] Reenable dotnet-watch on helix ( #8258 )
2019-03-08 11:32:02 -08:00
John Luo
2cf67cb7c0
Update template icons ( #7931 )
2019-03-08 10:44:32 -08:00
Andrew Stanton-Nurse
6a73d75688
fix skipped test to actually be skipped ( #8238 )
2019-03-08 10:24:48 -08:00
BrennanConroy
aef62d9ff8
Backport SSR fix ( #8174 )
2019-03-08 10:00:18 -08:00
David Fowler
bd6faa5ca1
Chunked request parsing does not properly update examined ( #8318 )
...
- The chunked parsing logic didn't properly update the examined position when parsing the chunked prefix. This started to throw because Pipe now throws if examined is set to the position before the previous.
2019-03-08 09:42:02 -08:00
Chris Ross
ce04a1a723
Allow sync IO for NewtonsoftJsonOutputFormatter #8302 ( #8303 )
2019-03-07 19:11:35 -08:00
Justin Kotalik
bae2f2280a
Make StartAsync not throw if we haven't started the response ( #8199 )
2019-03-07 18:32:19 -08:00
Mikael Mengistu
c0c2bb3049
Skip flaky transport test ( #8295 )
2019-03-07 18:26:38 -08:00
Justin Kotalik
c79b2413cc
Swap installer order ( #8266 )
2019-03-07 15:45:31 -08:00
Ryan Brandenburg
e0ce17bc3f
Update IDs for RazorComponents ( #8301 )
2019-03-07 14:43:44 -08:00
Pranav K
41e6fc8ab0
Use ApplicationPartFactory when adding application parts
...
Fixes https://github.com/aspnet/AspNetCore/issues/8288
2019-03-07 13:38:31 -08:00
Pranav K
8aa02180fb
Skip tests until we can diagnose failures ( #8298 )
2019-03-07 13:13:23 -08:00
Doug Bunting
4cbc33da74
Update branding to 2.2.4
2019-03-07 11:53:17 -08:00
Chris Ross
6db129a588
Support conditional compression #6925 ( #8239 )
2019-03-07 11:09:48 -08:00
Andrew Stanton-Nurse
7fb3d57f54
Skip some more flaky tests ( #8194 )
2019-03-07 09:40:26 -08:00
Mikael Mengistu
b1f828e161
Client to Sever Streaming Java Edition ( #8222 )
2019-03-07 09:34:28 -08:00
Chris Ross
5170c31b23
Add details to the JwtBearer error messages #4679 ( #8259 )
2019-03-07 08:15:16 -08:00
Hao Kung
435867e8c5
Add ability to skip tests on specific helix queues ( #8231 )
2019-03-06 23:53:18 -08:00
Doug Bunting
e497f4101f
Update branding to 2.1.10 ( #8265 )
2019-03-06 19:45:46 -08:00
Doug Bunting
697a1009d2
Merge branch 'release/2.2' => 'master' ( #7630 )
...
- barely [automated]
2019-03-06 14:42:33 -08:00
Kevin Ransom (msft)
35ac392fb6
Fix F# template ( #7637 )
2019-03-06 12:47:28 -08:00
Justin Kotalik
02dbe55466
Fix StartsWithPortableAndBootstraperExe ( #8219 )
2019-03-06 11:59:42 -08:00
Ryan Brandenburg
706b8345dc
Regenerate package-lock.json
2019-03-06 11:55:05 -08:00
Ryan Brandenburg
7573597577
Merge branch 'merge/release/2.2-to-master' of github.com:dotnet-maestro-bot/AspNetCore into merge/release/2.2-to-master
2019-03-06 11:36:41 -08:00
Ryan Nowak
a1ec03e1e6
Add fallback routing for controllers and pages
2019-03-06 09:48:07 -08:00
Ryan Nowak
bb28db6fb2
Generalize Action Selection logic
...
Allows us to use the "select action via route values" logic for
endpoints.
2019-03-06 09:48:07 -08:00
Ryan Nowak
8a46e8cd93
Update SpaDefaultPageMiddleware for endpoints
...
This change makes the SpaDefaultPageMiddleware noop when an endpoint has
been chosen. This is a problem today because this usually runs after
routing, but its always terminal.
So even if endpoint routing selected something, this would still serve
the default file. We're adding more things that fill this niche, but it
seems like a good idea to fix the existing stuff.
2019-03-06 09:48:07 -08:00
Ryan Nowak
089f64c528
Add fallback routing to file
...
This is a new routing feature that integrates static files to serve a
static file when routing doesn't match anything else.
This is a scenario that's covered by SPA services today, but given the
improvements to routing it makes much more sense to move lower in the
stack.
2019-03-06 09:48:07 -08:00
Ryan Nowak
7e63e2da43
Make StaticFiles Noop for middleware
...
Teaches all of the static files middleware (incl default files,
directory browser) to noop when an endpoint is selected. This is
desirable so you can place them after routing if you want with no ill
effect.
2019-03-06 09:48:07 -08:00
Ryan Nowak
f150e89125
Add file/non-file and generic fallback
...
Adds new constraints for checking if a route value is a file or not.
Added a new set of builder methods that specify what it means to be a
'fallback'. This is really similar to what the older SPA fallback routes
do, but this is lower in the stack and directly integrated with
endpoints.
2019-03-06 09:48:07 -08:00
David Fowler
4c79e7fdc0
Rename Pipe properties ( #8227 )
...
* Rename Pipe properties
- Rename BodyPipe to BodyReader and BodyWriter on the request and response directly
2019-03-06 07:33:24 -08:00
Mikael Mengistu
563a488f3b
Add baseline test ( #7988 )
...
- mostly matching what's in `release/2.2`
2019-03-05 15:50:25 -08:00
Andrew Stanton-Nurse
303a354993
skip another flaky kestrel test in helix ( #8216 )
...
related #8215
2019-03-05 15:09:56 -08:00
Jeremy Lawrence
a1f544b62f
Correct doc comment for ApiConventionTypeMatchBehavior ( #7861 )
2019-03-05 14:43:59 -08:00
Pranav K
b90220ad05
Improve NullHtmlEncoder perf ( #7987 )
...
Fixes #7987
2019-03-05 14:41:55 -08:00
shnja
4c3996f824
Use Request.Scheme instead of Protocol ( #7911 )
2019-03-05 14:39:37 -08:00
Hao Kung
4e271ac124
Send email confirmation after register via external login ( #8013 )
2019-03-05 13:53:15 -08:00
Chris Ross
def25cb3de
Document the change policy for FileExtensionContentTypeProvider #2454 ( #8213 )
2019-03-05 13:50:48 -08:00
BrennanConroy
58ad7b7550
Fix build flakiness ( #8211 )
2019-03-05 12:59:21 -08:00
Pranav K
b41959ac32
Add additional logging to TempDataInCookiesTest to diagnose test failure
...
Diagnosis for https://github.com/aspnet/AspNetCore-Internal/issues/1803
2019-03-05 12:33:49 -08:00