diff --git a/src/Microsoft.AspNet.Mvc.ViewFeatures/Rendering/TagBuilder.cs b/src/Microsoft.AspNet.Mvc.ViewFeatures/Rendering/TagBuilder.cs index 70c44c88ea..1acfeb3b91 100644 --- a/src/Microsoft.AspNet.Mvc.ViewFeatures/Rendering/TagBuilder.cs +++ b/src/Microsoft.AspNet.Mvc.ViewFeatures/Rendering/TagBuilder.cs @@ -206,10 +206,7 @@ namespace Microsoft.AspNet.Mvc.Rendering writer.Write(" "); writer.Write(key); writer.Write("=\""); - if (!string.IsNullOrEmpty(attribute.Value)) - { - encoder.Encode(writer, attribute.Value); - } + encoder.Encode(writer, attribute.Value); writer.Write("\""); } } diff --git a/src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/StringHtmlContent.cs b/src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/StringHtmlContent.cs index 282c3b72a4..bdbc8b8ef5 100644 --- a/src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/StringHtmlContent.cs +++ b/src/Microsoft.AspNet.Mvc.ViewFeatures/ViewFeatures/StringHtmlContent.cs @@ -39,10 +39,7 @@ namespace Microsoft.AspNet.Mvc.ViewFeatures throw new ArgumentNullException(nameof(encoder)); } - if (!string.IsNullOrEmpty(_input)) - { - encoder.Encode(writer, _input); - } + encoder.Encode(writer, _input); } private string DebuggerToString() diff --git a/test/Microsoft.AspNet.Mvc.ApiExplorer.Test/project.json b/test/Microsoft.AspNet.Mvc.ApiExplorer.Test/project.json index 499c402975..eeea81a7b5 100644 --- a/test/Microsoft.AspNet.Mvc.ApiExplorer.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.ApiExplorer.Test/project.json @@ -3,12 +3,14 @@ "warningsAsErrors": true }, "dependencies": { - "Microsoft.AspNet.Mvc" : "6.0.0-*", - "Microsoft.AspNet.Mvc.TestCommon": { "version": "6.0.0-*", "type": "build" }, + "Microsoft.AspNet.Mvc": "6.0.0-*", "Microsoft.AspNet.Mvc.Formatters.Xml": "6.0.0-*", + "Microsoft.AspNet.Mvc.TestCommon": { + "version": "6.0.0-*", + "type": "build" + }, "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.Extensions.Logging.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "Moq": "4.2.1312.1622", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/project.json b/test/Microsoft.AspNet.Mvc.Core.Test/project.json index ec1712980c..37230be1f2 100644 --- a/test/Microsoft.AspNet.Mvc.Core.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Core.Test/project.json @@ -5,20 +5,19 @@ "dependencies": { "Microsoft.AspNet.Http": "1.0.0-*", "Microsoft.AspNet.Mvc": "6.0.0-*", + "Microsoft.AspNet.Mvc.Formatters.Xml": "6.0.0-*", "Microsoft.AspNet.Mvc.TestCommon": { "version": "6.0.0-*", "type": "build" }, - "Microsoft.AspNet.Mvc.Formatters.Xml": "6.0.0-*", "Microsoft.AspNet.Mvc.TestDiagnosticListener.Sources": { "version": "6.0.0-*", "type": "build" }, "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.Extensions.DependencyInjection": "1.0.0-*", - "Microsoft.Extensions.Logging.Testing": "1.0.0-*", "Microsoft.Extensions.DiagnosticAdapter": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", + "Microsoft.Extensions.Logging.Testing": "1.0.0-*", "Moq": "4.2.1312.1622", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, diff --git a/test/Microsoft.AspNet.Mvc.Cors.Test/project.json b/test/Microsoft.AspNet.Mvc.Cors.Test/project.json index 8c87e255af..3e0984d906 100644 --- a/test/Microsoft.AspNet.Mvc.Cors.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Cors.Test/project.json @@ -10,7 +10,6 @@ "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.Extensions.DependencyInjection": "1.0.0-*", "Microsoft.Extensions.Logging.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "Moq": "4.2.1312.1622", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, diff --git a/test/Microsoft.AspNet.Mvc.DataAnnotations.Test/project.json b/test/Microsoft.AspNet.Mvc.DataAnnotations.Test/project.json index a1f5f7c9be..e5b59aa68e 100644 --- a/test/Microsoft.AspNet.Mvc.DataAnnotations.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.DataAnnotations.Test/project.json @@ -9,7 +9,6 @@ "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.Extensions.DependencyInjection": "1.0.0-*", "Microsoft.Extensions.Logging.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "Moq": "4.2.1312.1622", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, diff --git a/test/Microsoft.AspNet.Mvc.Formatters.Json.Test/project.json b/test/Microsoft.AspNet.Mvc.Formatters.Json.Test/project.json index ca7215c119..65487e6f12 100644 --- a/test/Microsoft.AspNet.Mvc.Formatters.Json.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Formatters.Json.Test/project.json @@ -10,7 +10,6 @@ "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.Extensions.DependencyInjection": "1.0.0-*", "Microsoft.Extensions.Logging.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "Moq": "4.2.1312.1622", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, diff --git a/test/Microsoft.AspNet.Mvc.Formatters.Xml.Test/project.json b/test/Microsoft.AspNet.Mvc.Formatters.Xml.Test/project.json index d8562f761f..12491bd286 100644 --- a/test/Microsoft.AspNet.Mvc.Formatters.Xml.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Formatters.Xml.Test/project.json @@ -8,7 +8,6 @@ "Microsoft.AspNet.Mvc.Formatters.Xml" : "6.0.0-*", "Microsoft.AspNet.Mvc.TestCommon": { "type": "build", "version": "6.0.0-*" }, "Microsoft.AspNet.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "Moq": "4.2.1312.1622", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, diff --git a/test/Microsoft.AspNet.Mvc.FunctionalTests/compiler/resources/HtmlGenerationWebSite.HtmlGeneration_Home.Script.Encoded.html b/test/Microsoft.AspNet.Mvc.FunctionalTests/compiler/resources/HtmlGenerationWebSite.HtmlGeneration_Home.Script.Encoded.html index 45c084fe91..433539425e 100644 --- a/test/Microsoft.AspNet.Mvc.FunctionalTests/compiler/resources/HtmlGenerationWebSite.HtmlGeneration_Home.Script.Encoded.html +++ b/test/Microsoft.AspNet.Mvc.FunctionalTests/compiler/resources/HtmlGenerationWebSite.HtmlGeneration_Home.Script.Encoded.html @@ -1,4 +1,4 @@ - +
@@ -62,10 +62,10 @@ - HtmlEncode[[]] + - HtmlEncode[[]] + - HtmlEncode[[]] + - HtmlEncode[[]] + - HtmlEncode[[]] + - HtmlEncode[[]] + - HtmlEncode[[]] + - HtmlEncode[[]] + \ No newline at end of file diff --git a/test/Microsoft.AspNet.Mvc.FunctionalTests/project.json b/test/Microsoft.AspNet.Mvc.FunctionalTests/project.json index 4f6f77c263..9e05bcbc0a 100644 --- a/test/Microsoft.AspNet.Mvc.FunctionalTests/project.json +++ b/test/Microsoft.AspNet.Mvc.FunctionalTests/project.json @@ -44,7 +44,6 @@ "Microsoft.AspNet.WebUtilities": "1.0.0-*", "Microsoft.Extensions.Configuration.Json": "1.0.0-*", "Microsoft.Extensions.Logging.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "ModelBindingWebSite": "1.0.0", "MvcSample.Web": "1.0.0", "PrecompilationWebSite": "1.0.0", diff --git a/test/Microsoft.AspNet.Mvc.IntegrationTests/project.json b/test/Microsoft.AspNet.Mvc.IntegrationTests/project.json index 7ff9180ac5..dc4ccfa792 100644 --- a/test/Microsoft.AspNet.Mvc.IntegrationTests/project.json +++ b/test/Microsoft.AspNet.Mvc.IntegrationTests/project.json @@ -11,7 +11,6 @@ "type": "build" }, "Microsoft.AspNet.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, "commands": { diff --git a/test/Microsoft.AspNet.Mvc.Localization.Test/project.json b/test/Microsoft.AspNet.Mvc.Localization.Test/project.json index 0740663363..8d766088cd 100644 --- a/test/Microsoft.AspNet.Mvc.Localization.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Localization.Test/project.json @@ -4,11 +4,13 @@ }, "dependencies": { "Microsoft.AspNet.Mvc": "6.0.0-*", - "Microsoft.AspNet.Mvc.Localization": "6.0.0-*", - "Microsoft.AspNet.Mvc.TestCommon": { "version": "6.0.0-*", "type": "build" }, - "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.AspNet.Mvc.Formatters.Xml": "6.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", + "Microsoft.AspNet.Mvc.Localization": "6.0.0-*", + "Microsoft.AspNet.Mvc.TestCommon": { + "version": "6.0.0-*", + "type": "build" + }, + "Microsoft.AspNet.Testing": "1.0.0-*", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, "commands": { diff --git a/test/Microsoft.AspNet.Mvc.Razor.Host.Test/project.json b/test/Microsoft.AspNet.Mvc.Razor.Host.Test/project.json index 33bb7f4eff..87f4f08114 100644 --- a/test/Microsoft.AspNet.Mvc.Razor.Host.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Razor.Host.Test/project.json @@ -6,10 +6,12 @@ "Microsoft.AspNet.Mvc.Formatters.Xml": "6.0.0-*", "Microsoft.AspNet.Mvc.Razor": "6.0.0-*", "Microsoft.AspNet.Mvc.Razor.Host": "6.0.0-*", + "Microsoft.AspNet.Mvc.TestCommon": { + "version": "6.0.0-*", + "type": "build" + }, "Microsoft.AspNet.Mvc.ViewFeatures": "6.0.0-*", - "Microsoft.AspNet.Mvc.TestCommon": { "version": "6.0.0-*", "type": "build" }, "Microsoft.AspNet.Testing": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, "commands": { diff --git a/test/Microsoft.AspNet.Mvc.Razor.Test/RazorViewTest.cs b/test/Microsoft.AspNet.Mvc.Razor.Test/RazorViewTest.cs index ebc7505f05..5a920ca219 100644 --- a/test/Microsoft.AspNet.Mvc.Razor.Test/RazorViewTest.cs +++ b/test/Microsoft.AspNet.Mvc.Razor.Test/RazorViewTest.cs @@ -914,7 +914,6 @@ namespace Microsoft.AspNet.Mvc.Razor "]]BodyContent" + "foo-content" + Environment.NewLine + - "HtmlEncode[[]]" + Environment.NewLine; var page = new TestableRazorPage(v => diff --git a/test/Microsoft.AspNet.Mvc.Razor.Test/project.json b/test/Microsoft.AspNet.Mvc.Razor.Test/project.json index 620a8f6cee..20d7e1ac28 100644 --- a/test/Microsoft.AspNet.Mvc.Razor.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.Razor.Test/project.json @@ -14,9 +14,8 @@ "type": "build" }, "Microsoft.AspNet.Testing": "1.0.0-*", - "Microsoft.Extensions.DependencyInjection": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "Microsoft.Dnx.Runtime": "1.0.0-*", + "Microsoft.Extensions.DependencyInjection": "1.0.0-*", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, "commands": { diff --git a/test/Microsoft.AspNet.Mvc.TagHelpers.Test/SelectTagHelperTest.cs b/test/Microsoft.AspNet.Mvc.TagHelpers.Test/SelectTagHelperTest.cs index def8206c70..3716847e44 100644 --- a/test/Microsoft.AspNet.Mvc.TagHelpers.Test/SelectTagHelperTest.cs +++ b/test/Microsoft.AspNet.Mvc.TagHelpers.Test/SelectTagHelperTest.cs @@ -45,15 +45,15 @@ namespace Microsoft.AspNet.Mvc.TagHelpers modelWithNull, modelWithText, }; - var noneSelected = "" + Environment.NewLine + + var noneSelected = "" + Environment.NewLine + "" + Environment.NewLine + "" + Environment.NewLine + "" + Environment.NewLine; - var innerSelected = "" + Environment.NewLine + + var innerSelected = "" + Environment.NewLine + "" + Environment.NewLine + "" + Environment.NewLine + "" + Environment.NewLine; - var outerSelected = "" + Environment.NewLine + + var outerSelected = "" + Environment.NewLine + "" + Environment.NewLine + "" + Environment.NewLine + "" + Environment.NewLine; diff --git a/test/Microsoft.AspNet.Mvc.TagHelpers.Test/TextAreaTagHelperTest.cs b/test/Microsoft.AspNet.Mvc.TagHelpers.Test/TextAreaTagHelperTest.cs index dcda8e8459..01a7ff2170 100644 --- a/test/Microsoft.AspNet.Mvc.TagHelpers.Test/TextAreaTagHelperTest.cs +++ b/test/Microsoft.AspNet.Mvc.TagHelpers.Test/TextAreaTagHelperTest.cs @@ -48,35 +48,32 @@ namespace Microsoft.AspNet.Mvc.TagHelpers { { null, typeof(Model), null, new NameAndId("Text", "Text"), - Environment.NewLine + "HtmlEncode[[]]" }, + Environment.NewLine }, { modelWithNull, typeof(Model), modelWithNull.Text, new NameAndId("Text", "Text"), - Environment.NewLine + "HtmlEncode[[]]"}, + Environment.NewLine }, { modelWithText, typeof(Model), modelWithText.Text, new NameAndId("Text", "Text"), Environment.NewLine + "HtmlEncode[[outer text]]" }, { modelWithNull, typeof(NestedModel), modelWithNull.NestedModel.Text, new NameAndId("NestedModel.Text", "NestedModel_Text"), - Environment.NewLine + "HtmlEncode[[]]" }, - + Environment.NewLine }, { modelWithText, typeof(NestedModel), modelWithText.NestedModel.Text, new NameAndId("NestedModel.Text", "NestedModel_Text"), Environment.NewLine + "HtmlEncode[[inner text]]" }, { models, typeof(Model), models[0].Text, new NameAndId("[0].Text", "z0__Text"), - Environment.NewLine + "HtmlEncode[[]]" }, - + Environment.NewLine }, { models, typeof(Model), models[1].Text, new NameAndId("[1].Text", "z1__Text"), Environment.NewLine + "HtmlEncode[[outer text]]" }, { models, typeof(NestedModel), models[0].NestedModel.Text, new NameAndId("[0].NestedModel.Text", "z0__NestedModel_Text"), - Environment.NewLine + "HtmlEncode[[]]" }, - + Environment.NewLine }, { models, typeof(NestedModel), models[1].NestedModel.Text, new NameAndId("[1].NestedModel.Text", "z1__NestedModel_Text"), Environment.NewLine + "HtmlEncode[[inner text]]" }, diff --git a/test/Microsoft.AspNet.Mvc.TagHelpers.Test/project.json b/test/Microsoft.AspNet.Mvc.TagHelpers.Test/project.json index e012418f28..1d25b03eae 100644 --- a/test/Microsoft.AspNet.Mvc.TagHelpers.Test/project.json +++ b/test/Microsoft.AspNet.Mvc.TagHelpers.Test/project.json @@ -10,7 +10,6 @@ }, "Microsoft.AspNet.Testing": "1.0.0-*", "Microsoft.Extensions.Logging.Abstractions": "1.0.0-*", - "Microsoft.Extensions.WebEncoders.Testing": "1.0.0-*", "xunit.runner.aspnet": "2.0.0-aspnet-*" }, "commands": { diff --git a/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/Rendering/HtmlHelperLinkGenerationTest.cs b/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/Rendering/HtmlHelperLinkGenerationTest.cs index 817dc0fd08..9418a5af20 100644 --- a/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/Rendering/HtmlHelperLinkGenerationTest.cs +++ b/test/Microsoft.AspNet.Mvc.ViewFeatures.Test/Rendering/HtmlHelperLinkGenerationTest.cs @@ -57,7 +57,7 @@ namespace Microsoft.AspNet.Mvc.Rendering GetRouteValuesAsString(routeValues), fragment, GetHtmlAttributesAsString(htmlAttributes)); - expectedLink = expectedLink.Replace("HtmlEncode[[]]", ""); + expectedLink = expectedLink.Replace("HtmlEncode[[]]", string.Empty); var urlHelper = new Mock